Age | Commit message (Collapse) | Author |
|
- Change made in partner CL introduced a regression in dialing from
the search results:
https://partner-android-review.googlesource.com/#/c/206297/
The problem with that change is that it was intended to ensure that the +
was not stripped off when dialing from the dial pad. It had the
unintential impact of rendering direct dial from the search box inoperative.
since mAddToContactNumber was null in this case.
Bug: 20068746
Change-Id: Ic3a75ccf00164e7c865cc633a6a16d1699227ed2
|
|
- The smart dial search normalizes the dial string and removes
anything other than digits
- Add a fix to add the + sign back to the normalized string
if original typed number had a + sign
- Add a check for prohibited numbers before making a call
and display an error dialog
Change-Id: Ib36462be573ce4fecc8821980226ae2920041cd2
|
|
With the addition of the visual voicemail sync adapter, we want to have
a flag in the voicemail provider that will indicate that a voicemail was
deleted but not yet synced to the server. However, we no longer want
the entry to show up in the dialer call log, so make sure to ignore all
voicemails marked with "deleted" when querying the call log table.
Bug: 19236241
Change-Id: Ib80537c3b8630dd99b5e2b9b20d81015eafd114c
|
|
bindView() gets called many times at dialer startup and layout updates.
Besides being costly, it invokes cross-process TelecomManager methods.
This change addresses the cross-process issues by adding a short-lived
cache to isVoicemail() method invocations.
Change-Id: Ib69c0eb3969a1b7d77c9fd1a2aa6e578a31fb5e9
|
|
Bug:19255194
Change-Id: I8eabe46ef6fff774291e3f943051c24eca8a00e0
|
|
Fixes a bug introduced in ag/608822. Reverts the code for the
getAccountOrNull method and modifies getAccountColor to have the
special-case cose which was in getAccountOrNull.
Bug: 19248327
Change-Id: I558cdbd8d9994a1f07f82073ba35e9ec69693a2a
|
|
|
|
Make sure that we check for the index to exist in the list before
we query for it. The problem is that the index is grabbed from the
listview but then applied to the contact entry arraylist. It is
possible that these two are out of temporarily out of sync. This check
will make sure that we do not throw an exception in those cases.
Bug: 19103509
Change-Id: Iba620ec859866b9f8bfc2614a17b1b1a11037230
|
|
installed." into lmp-mr1-dev
|
|
Before dialing voicemail when a default SIM is set, Dialer checks first if it
has a valid voicemail number. However, the previous code was checking the
voicemail number of the first SIM as opposed to the default SIM. This
change corrects the logic.
Bug: 18938231
Change-Id: Ia83aa44bc773e99aabbe7474439d22eb1c4e6fd9
|
|
- Removed telecomManager check hasMultipleCallCapableAccounts() which would
only return 1 when a single sim is installed in a multisim phone.
- For single-sim devices, the Sim color is 0 (ie not selected) for the
Sim PhoneAccount, so the default behavior is to not show a sim color.
Bug: 18696518
Change-Id: I8bbb956e204422e122b3c50e6fc98c2916151aa4
|
|
When the shortcut card was hidden due to the call log being cleared, the
offset for the overlapping pane needed to be recalculated based on the
new height of the top portion of the dialtacts activity.
Bug: 18849546
Change-Id: Ib5953a2a537e9a7520d4f022e43fa974f67eb410
|
|
This CL fixes a bug that could result in the progress dialog
that appears when clearing call logs to never be dismissed.
The cause of this bug is a race condition that causes
the original dialog fragment to be detached from the parent activity
before the progress dialog is dismissed.
If that happens, the progress dialog is never dismissed and stays
on screen forever. This CL fixes this by assigning the activity to
the dialog explicitly and retrieving it when trying to dismiss it.
Bug: 18836384
Change-Id: I5f8941e13dc7eb962b23e828cf47bc64f2b1a2aa
|
|
|
|
|
|
|
|
Bug: 18796407
Change-Id: Ib3001ac08e64b4efa04a2d9915abe2177475bbe1
|
|
|
|
Don't crash if unable to update the call log contact info cache because
the disk is full.
Bug:18770948
Change-Id: I4156581df0742d58ed28eeb0c767923e0bc78507
|
|
|
|
Use listview instead of root view as parent when inflating
footer view so that it is always inflated with AbsListView.LayoutParams
Bug: 18762303
Change-Id: If9f5a38017d07d35962881750e2b403aa95287cb
|
|
It's possible that it may no longer be necessary to dismiss this
specific dialog. For example, there may have been a rotation; in
those cases, we expect the DialogFragment to cleanup/dismiss its
own dialog.
Bug: 18728214
Change-Id: I307c299b1f0a6dabebaf4ac6af1d126bf548b190
|
|
Bug: 18738114
Change-Id: I3148d6c78561bf369d4ddbab09bf2fb9c7a7966b
|
|
Bug: 18678952
Change-Id: I2f15cad4b71ba780e6ed860b5dd67c745a3b4823
|
|
Traced through the original bug report; the problem is that a call to
TextUtils.expandTemplate was being made with a null 2nd parameter.
I traced through the callers to find out where a null could be introduced
and I was unable to identify a potential source. This change introduces
a last-ditch null check to protect against problems upstream.
Bug: 18684529
Change-Id: I7b608dfedf052d6933e94d1f23a658763b66059a
|
|
lmp-mr1-dev
|
|
The case handled here is when a user is in the Dialer app while there is
a call in progress and then the call ends, the Dialpad should revert to
its "normal" mode, i.e. digits. The previous approach, using
PhoneStateListener, was safe for single SIM phones, but no longer works
on Multi-SIM phones because a PhoneStateListener only listens to state
changes from a single subscription (e.g. SIM). A more robust way of
knowing when a call hass ended is to receive a
TelephonyManager.ACTION_PHONE_STATE_CHANGED broadcast.
Bug: 18269410
Change-Id: I9b0578d4281bc75d0f804dc695f4bd1a9c02f2cd
|
|
Bug: 17321294
Change-Id: Icc712da80e25e5a5294986ece055fcffaa558f1e
|
|
1. For recent call entries with a name and phone number, the name will
now also be added.
2. For recent call entries which have complete address information provided
by nearby places, all information except the contact photo will be added. The contact photo is
excluded, as the ContactsLoader would attempt to load the contact photo
while parsing the contact information. On a slow connection this could
cause a noticeable pause while adding the contact.
Bug: 17308163
Change-Id: If2e78bd1257096b344ff2dd266dcdbaeed4f1471
|
|
MSIM." into lmp-mr1-dev
|
|
Since user needs to select a subscription before Dialer can check whether a
voicemail number is set up for a certain subscription, go directly to
calling voicemail when the user dials '1' on a MSIM phone where 'Ask
first' is set.
Bug:18233678
Change-Id: I10dd56c14bfb98e4f8410e2de400da44e328682f
|
|
|
|
Make sure that we check the validity of the label before we
call a method on it. Also removed import of unused package.
Bug: 18572439
Change-Id: I4b9ae0b4ace4129fe92dcbd9abecc12620d45a86
|
|
lmp-mr1-dev
|
|
In TalkBack mode, when a user taps on a call log entry, it should read
back the name of the SIM/account used for the call. The string used is
"on <phoneAccount>".
Also add back periods removed in the string updates because they are
needed for verbal stopping points in TalkBack mode.
Bug:18517912
Change-Id: Iaadbd859ef980ca030f9fb60d3395ca057e8cefc
|
|
|
|
Bug: 18292176
Change-Id: I3d5229a44bff032178bf2eb9fde633a10db8c7d8
|
|
Check for mDraggedEntry == null
Bug:18524967
Change-Id: I323cf41ddd21444d4fd675543b822c29517e8b26
|
|
Instead of passing in the preference.
Bug: 18232725
Change-Id: Ic0eec7cd62f1d9106da4de6d9aa29aeeead9cc0e
|
|
lmp-mr1-dev
|
|
Bug: 17325604
Change-Id: Ida625d884088575760e394b2b58a4fc5b7126033
|
|
The issue is the onActivityResult callback which receives the result of
the voice search is called BEFORE the dialtacts activity is resumed, and
hence the search results fragment is not properly shown (since resume has
not yet completed).
Changed so that the search results are stored until onResume, where they
are applied to the search box.
Bug: 18410823
Change-Id: I02985f722643846067678a67f2c1fda76434fbc4
|
|
Change-Id: I0d26d0510edf5ea49d77d8c3c7ecd657b5989d52
|
|
* commit '4e97e09f0ae58f6065252022fe5cf5f7d90aef01':
Switch from CALL -> CALL_PRIVILEGED
|
|
Bug: 18332160
Change-Id: I5b9bcc8f413e5534bab94e0b2677371968a8e483
|
|
There is no reason to do the costly ToneGenerator initialization
inside onResume, which gets called during the Dialer -> InCallUI
transition. Move it to onStart/onStop so it only happens when Dialer
is actually in the background.
Measurement of time taken for InCallActivity start -> onResumed, 10 runs
Before: Average 541.9ms SD: 152.4ms
After: Average 350.5ms SD: 81.1ms
Bug: 18373617
Change-Id: I192e2bcc9fd4b7d423d804f333d8d32bff3f58c1
|
|
|
|
lmp-mr1-dev
|
|
The tint color of a phone account only refers to the color of the icon,
the highlight color is the general display color used for text,
backgrounds etc. We should use highlight color in Dialer
Bug: 18192071
Change-Id: Ia7e1c6cf055357df98b2b2f481b32a727d1f6d61
|
|
Per settings design guildelines, we should not be using the second line
to describe the contents of a setting with subscreen navigation (this
second line is now used for just status). Remove these second lines from
the dialer settings UI.
Bug: 17446974
Change-Id: Idbeace64c088805a19a77b1438dd66a618387848
|
|
|
|
If findPointerIndex returns -1, ignore the motion event. The
equivalent fix is done for other handlers of motion events as well.
Bug: 18186775
Change-Id: Ia7548335eeb84310510260381a8bcedf6556aa40
|
|
If a new call log view is provided, make sure to correctly
find and stash the correct member variables inside bindBadge.
Bug: 18016618
Change-Id: If01a68fc6c468905ab576b1c5927afa308238786
|
|
Bug: 18291787
Change-Id: Id53193a2597ac6a7827a484279e130d8bfb78b77
|
|
Expose the dialpad's ILD (international / long distance) fields to be
populated by the dialer.
Bug: 13334252
Change-Id: Ia366148ef1318a2dacc4971d51a3bd34ec3c39de
|
|
lmp-mr1-dev
|
|
|
|
into lmp-mr1-dev
|
|
The fragment member variables were being lost on rotation
because the FragmentManager does not call getItem on rotation.
Fix the way we save the fragments into member variables to ensure
that those references are always up to date so that mAllCallsFragment
is not null after rotation.
Bug: 17478780
Change-Id: I5a0c070273f2d86864afd96c6bb6551bcd0d1aa4
|
|
* Send screen view for first fragment loaded inside ListsFragment
* Send screen view for voicemail playback fragment
* Send screen view for currently active fragment when activity is restarted
* Don't send spurious screen views on rotation
* Send screen views for call log fragments in call log activity, and
differentiate between them with a tag
Bug: 18158037
Change-Id: I09fda53db33f6a6acc4a3b477de992aa94921c71
|
|
Currently mSavedState is reset to false in just onResume, but it needs
to be reset earlier so that the dialpad is allowed to show itself when
an ACTION_DIAL intent is sent.
Bug: 18242314
Change-Id: I9ddd2a431edc4c2d1cc447b14ee8d1347d139552
|
|
|
|
Bug: 18247185
Change-Id: I744355ea712f713d5510fa26f141ee2cce7491ff
|
|
The SelectPhoneAccountDialog fragment now supports optional/changeable title and
checkbox fields, but to simplify that case, add a method that will
initialize the dialog to default values.
Bug: 18204058
Change-Id: Icd3b880378ff9a7d8ee75e01ec85ed40b29a59ab
|
|
|
|
Bring up a dialog if no default subscription account is set by the
user when handling ADN queries.
Bug: 17917937
Change-Id: Icd6a6dc2843463ba68d281a24e00fdba1880adf4
|
|
Add a line under call log to display PhoneAccount label in the color of
the account/SIM.
Bug: 17971273
Change-Id: I16c37ae8828245f928bc3867a498a29e73b5925c
|
|
|
|
|
|
+ Add Telecomm and Telephony methods for handlePinMMIForSubscriber
+ Add Select Account dialog in Dialer for MMI
Bug: 17917937
Change-Id: Iaabd0c5705cdf0d325aa7514d04935747078b28c
|
|
Remove dependencies on old analytics code.
Initialize analytics inside DialerApplication.
Improving analytics CL #4/4
Bug: 18039620
Change-Id: I52f68e50297db2aae61d67d9bdbe66cb1d75aafc
|
|
|
|
|
|
The original CL to fix ActionBarControllerTest by using an
ActivityInstrumentationTestCase was too heavyweight and caused flaky
test. It was also indicative of a flaw in the original design that
ActionBar couldn't be mocked out easily.
Refactor the code so that:
1) getActionBar() is no longer needed
2) Respect the invariant that all access to the actionBar goes through the
ActionBarController (see the changes in ListsFragment) so that any change to
the ActionBar's hide offset can be tracked appropriately.
Bug: 17487016
Change-Id: I935b683ddb301ca5d3952889af1381bdbdcc97d3
|
|
|
|
Also remove some unnecessary strings
Bug: 17647791
Change-Id: I0e5797b3aad35dd37607fde944c1329fbeffbe88
|
|
Make sure to not commit any fragment transactions when
onSaveInstanceState has been called.
Bug: 18038718
Bug: 18142294
Bug: 18106980
Change-Id: I0755208ee6637431cb3e494b5494b1ccdd930489
|
|
- Remove helper method in DialtactsActivity.
+ Create intent in DialerSettingsActivity.
This is the only place the method is called; it seems that this code
to create the intent should live in DialerSettingsActivity instead
of DialtactsActivity.
Bug: 18114923
Change-Id: I129b716c2a247994647c123f1cbd945b7ef36778
|
|
|
|
|
|
Bug: 17487016
Change-Id: I4c13c3e826a4eb1de84708dfa27ad093b2134087
|
|
This allows it to correctly determine if the photo should be treated
as a thumbnail (and thus cropped into a circle), and also saves on
RAM since the full sized bitmap doesn't need to be decoded.
Bug: 17327890
Change-Id: Ia92cfd9005ea2060608284e3c1f6a539bdd6da72
|
|
|
|
CallLogListItemView is a custom view that might have done
something once, but doesn't anymore. It makes the code more
complicated to read and requires a lot of casting that does
nothing at all.
Change-Id: I53efb35367d748aa3d164d0fb56686175967c90e
|
|
Bug: 18114923
Change-Id: I93559004bb4fe31b24685155a57424e24770c115
|
|
Null check mCapturedView.
Bug:18114408
Change-Id: I5abb9f5bcca37aafab55f12c69d824ab92faf68f
|
|
Also renamed dialerbind package
Analytics CL #2/5
Bug: 18039620
Change-Id: I45722015978038cdccb6a848c28e4b6c90d5aa4f
|
|
* commit '8c258ac5eee9d1e0c3f8a4d895dda84a2c9ac71a':
Generalize the device IMEI display for IMEI/MEID and multi-SIM.
|
|
The user can initiate a call to display the IMEI device ID from the
dialpad. Since the code is almost identical for the IMEI/MEID cases,
factor out into one method. Also in the case where there is more than
one IMEI device ID (i.e. multi-SIM with multiple SIMs inserted), display
a list of IDs in order of slot number.
Bug: 17917937
Change-Id: Id465a5498787a0fe72d8317412c6eb7a2ec61d28
|
|
* commit 'f663fa083983a9b417f642e246d0873e0c424bb9':
Make a general call to voicemail when calling back from call log.
|
|
display." into lmp-sprout-dev
* commit 'f507886d96f74bd7e54c8f430f5c4e5b23a73b79':
Enable use of phone accounts for voicemail info display.
|
|
A voicemail call log entry is saved with the number of the voicemail
that was called. In the multi-sim case, however, we don't want to call
back to the voicemail number of the original call because it might be
the number of a different phone account.
Bug: 17925501
Change-Id: I528c4039cc227608e040ae71b6b10488376fb357
|
|
lmp-sprout-dev
|
|
Call the "isVoicemailNumber(subId, number)" method instead
of the one with just the number. This is because we need to check
whether a number is the voicemail number for a specific phone account,
otherwise the UI would never correctly display "voicemail" for the
non-default SIM.
Bug:17925501
Change-Id: If1d6cb1acfcb570aca5e639858af8804bac202c0
|
|
|
|
The TileInteractionTeaserView is no longer displayed in the UI.
Change-Id: Ieaf24cdf2ecd5971a22e58e34c49a4481b7d6320
|
|
Before, user needed to first tap on the the collapsed search box to
expand it. Afterwards, needed to long-press to open the paste option.
Now, if the user long-presses on the collapsed search box, it
simulates a click on the search box (causing it to expand), and then
invokes a long-press to open the paste option.
Bug: 17882004
Change-Id: Ie23df56fe1c340aacf484bc482fa8abb06a3574c
|
|
An accessbility delegate is set in the Call Log Adaptor to
automatically expand the call log list item when tapped in
accessibility mode. We don't want this for the shortcut card,
because it shouldn't be expandable.
When not doing this expansion, the shortcut card now obtains
accessibility focus and reading properly.
Change the description text for the shortcut card so it reads
"call back #/name". Should update this later with a string to
include the other information, but it's not straightforward to
do right now.
Bug: 17929331
Change-Id: I691fe238ea436916ab7505c39039b6c1cea27781
|
|
|
|
Bug: 17811695
Change-Id: I5dafca3177855940f51ba414b267f59bd13be467
|