summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2015-02-17Merge "Remove shortcut cards list view"Yorke Lee
2015-02-17Remove shortcut cards list viewYorke Lee
Remove ListView containing shortcut cards and replace it with a single ShortcutCard card. Rename ShortcutCardAdapter to ShortcutCardManager with slight refactor. Some corresponding logic changes inside ListsFragment. Reduces the number of getView calls at startup from 4 to 1. Change-Id: I11787bdb1d04cc19634c21bfd398b7533c75d339
2015-02-06am 328089ed: am 26be9374: am 06d7d08e: Fix voicemail playback position controlJay Shrauner
* commit '328089ed9e83eb007b3db8f9a7580de87f029732': Fix voicemail playback position control
2015-02-06Fix voicemail playback position controlJay Shrauner
Bug:19255194 Change-Id: I8eabe46ef6fff774291e3f943051c24eca8a00e0
2015-02-05Merge "Set adapter's query string to restore state."Andrew Lee
2015-02-05Merge "Extract SwipeableShortcutCard into its own class"Yorke Lee
2015-02-05Extract SwipeableShortcutCard into its own classYorke Lee
Intial work to separate shortcut card view logic and the actual adapter to prepare for removal of the shortcut cards list view. Change-Id: Ie102fcd1d0d7be13c326cdf4c47502194a2f5ad6
2015-02-04Set adapter's query string to restore state.Andrew Lee
Before, the adapter was losing the query string on rotation, when the fragment and adapter were torn down and then restored. As such, when setQueryString in the adapter was called, the formatted query string would be null and it would not show the shortcuts. Bug: 18634760 Change-Id: I7f29636b7d035b9b41ba81f3fdb626bf1fa26dd5
2015-02-04am f4f09521: am 2e7ea428: am 7aaf2414: Fixing issue where carrier name shows ↵Tyler Gunn
up in call log on single sim devices. * commit 'f4f09521c20134fb2690c6a58e4ce203e0055d9c': Fixing issue where carrier name shows up in call log on single sim devices.
2015-02-04Merge "Convert unnecessary RelativeLayout to FrameLayout"Yorke Lee
2015-02-04Merge "Move CallUtil into Dialer. P1/3"Brian Attwell
2015-02-03Move CallUtil into Dialer. P1/3Brian Attwell
CallUtil relies on the a priviliged intent that should only be used by system apps. Therefore, it shouldn't be used by an unbundled Contacts app. I'm leaving one (isVideoEnabled) method from CallUtil inside ContactsCommon. This way, when the changes that Tyler made inside m-wireless-telephony-shamu-dev (b/19062133) get merged back into master both ContactsCommon and Dialer will be updated. Bug: 18777272 Change-Id: I49c9cc714ded01d523ed770a5bf62cf92c378e2f
2015-02-03Convert unnecessary RelativeLayout to FrameLayoutYorke Lee
Change-Id: I8b68eadf13f581d10b92ae58eb78d04f31a6ff60
2015-02-03Fixing issue where carrier name shows up in call log on single sim devices.Tyler Gunn
Fixes a bug introduced in ag/608822. Reverts the code for the getAccountOrNull method and modifies getAccountColor to have the special-case cose which was in getAccountOrNull. Bug: 19248327 Change-Id: I558cdbd8d9994a1f07f82073ba35e9ec69693a2a
2015-02-02Add DialpadFragment on-demand instead at on startupYorke Lee
Add the DialpadFragment dynamically instead of everything at startup. Once added, it is then shown/hidden instead of removed for performance reasons. Reduces startup time on a N5 from 603ms to 440ms. Bug: 18431193 Change-Id: I0482bd8277896ed8a6956fc03b6afaf44b442eb3
2015-01-28Add systrace events to track Dialer startup performanceYorke Lee
Bug: 18431193 Change-Id: I92db4ae61405d8d8445b72e7ac0daa0794af8335
2015-01-22am a6993193: am 67ceb111: am 7c35a8e9: Merge "Fix crasher due to ↵Anthony Lee
IndexOutOfBoundsException" into lmp-mr1-dev * commit 'a69931938e85735a5762ef108a71b10850e59a2d': Fix crasher due to IndexOutOfBoundsException
2015-01-22Merge "Fix crasher due to IndexOutOfBoundsException" into lmp-mr1-devAnthony Lee
2015-01-22Fix crasher due to IndexOutOfBoundsExceptionAnthony Lee
Make sure that we check for the index to exist in the list before we query for it. The problem is that the index is grabbed from the listview but then applied to the contact entry arraylist. It is possible that these two are out of temporarily out of sync. This check will make sure that we do not throw an exception in those cases. Bug: 19103509 Change-Id: Iba620ec859866b9f8bfc2614a17b1b1a11037230
2015-01-22Merge "Ensure sim color is shown on multi-sim devices when only one sim ↵Tyler Gunn
installed." into lmp-mr1-dev
2015-01-20Merge "Ensure sim color is shown on multi-sim devices when only one sim ↵Tyler Gunn
installed."
2015-01-17am 8dd7ab8d: am ac54b6f5: am 1eb16ea1: When dialing voicemail, check ↵Nancy Chen
voicemail number of correct default SIM. * commit '8dd7ab8dd07641dd1b82ef39127f2f5c8edd341b': When dialing voicemail, check voicemail number of correct default SIM.
2015-01-16When dialing voicemail, check voicemail number of correct default SIM.Nancy Chen
Before dialing voicemail when a default SIM is set, Dialer checks first if it has a valid voicemail number. However, the previous code was checking the voicemail number of the first SIM as opposed to the default SIM. This change corrects the logic. Bug: 18938231 Change-Id: Ia83aa44bc773e99aabbe7474439d22eb1c4e6fd9
2015-01-13Ensure sim color is shown on multi-sim devices when only one sim installed.Tyler Gunn
- Removed telecomManager check hasMultipleCallCapableAccounts() which would only return 1 when a single sim is installed in a multisim phone. - For single-sim devices, the Sim color is 0 (ie not selected) for the Sim PhoneAccount, so the default behavior is to not show a sim color. Bug: 18696518 Change-Id: I8bbb956e204422e122b3c50e6fc98c2916151aa4
2015-01-09Add null checksJay Shrauner
Bug: 18959494 Change-Id: I6dca7a8696b3dc0d104cba974644e1c3a5179024
2015-01-09am bcbf5b1a: am 935dc32e: am 97d15c72: Merge "Fixing overlap pane offset ↵Tyler Gunn
when shortcut card disappears." into lmp-mr1-dev * commit 'bcbf5b1ac1eb65fc679c5b6e9c28a1af0c71fc65': Fixing overlap pane offset when shortcut card disappears.
2015-01-05Ensure sim color is shown on multi-sim devices when only one sim installed.Tyler Gunn
- Removed telecomManager check hasMultipleCallCapableAccounts() which would only return 1 when a single sim is installed in a multisim phone. - For single-sim devices, the Sim color is 0 (ie not selected) for the Sim PhoneAccount, so the default behavior is to not show a sim color. Bug: 18696518 Change-Id: I8bbb956e204422e122b3c50e6fc98c2916151aa4
2015-01-05Unbundle PhoneCommon 2/2Brian Attwell
Move getVibrateWhenRingingSetting() to the only place it is used, inside Dialer. This way we don't need to unhide the Settings.VIBRATE_WHEN_RINGING. Bug: 18777272 Change-Id: I18d1d6e19b0efa1f56985e63d917c398c957f5ab
2014-12-30Fixing overlap pane offset when shortcut card disappears.Tyler Gunn
When the shortcut card was hidden due to the call log being cleared, the offset for the overlapping pane needed to be recalculated based on the new height of the top portion of the dialtacts activity. Bug: 18849546 Change-Id: Ib5953a2a537e9a7520d4f022e43fa974f67eb410
2014-12-23Fix for clear call log dialog not being dismissedYorke Lee
This CL fixes a bug that could result in the progress dialog that appears when clearing call logs to never be dismissed. The cause of this bug is a race condition that causes the original dialog fragment to be detached from the parent activity before the progress dialog is dismissed. If that happens, the progress dialog is never dismissed and stays on screen forever. This CL fixes this by assigning the activity to the dialog explicitly and retrieving it when trying to dismiss it. Bug: 18836384 Change-Id: I5f8941e13dc7eb962b23e828cf47bc64f2b1a2aa
2014-12-19Merge "Fix ClassCastException in CallLogFragment" into lmp-mr1-devYorke Lee
2014-12-19Merge "Correctly set visibility of reused shortcut card" into lmp-mr1-devYorke Lee
2014-12-19Merge "Handle SQLiteFullExceptions" into lmp-mr1-devJay Shrauner
2014-12-18Correctly set visibility of reused shortcut cardYorke Lee
Bug: 18796407 Change-Id: Ib3001ac08e64b4efa04a2d9915abe2177475bbe1
2014-12-18Merge "Improve Talkback for "Speed dial" user interface" into lmp-mr1-devIhab Awad
2014-12-16Handle SQLiteFullExceptionsJay Shrauner
Don't crash if unable to update the call log contact info cache because the disk is full. Bug:18770948 Change-Id: I4156581df0742d58ed28eeb0c767923e0bc78507
2014-12-16Merge "Check for cases before clearing dialog." into lmp-mr1-devAndrew Lee
2014-12-15Fix ClassCastException in CallLogFragmentYorke Lee
Use listview instead of root view as parent when inflating footer view so that it is always inflated with AbsListView.LayoutParams Bug: 18762303 Change-Id: If9f5a38017d07d35962881750e2b403aa95287cb
2014-12-15Check for cases before clearing dialog.Andrew Lee
It's possible that it may no longer be necessary to dismiss this specific dialog. For example, there may have been a rotation; in those cases, we expect the DialogFragment to cleanup/dismiss its own dialog. Bug: 18728214 Change-Id: I307c299b1f0a6dabebaf4ac6af1d126bf548b190
2014-12-15Improve Talkback for "Speed dial" user interfaceIhab Awad
Bug: 18738114 Change-Id: I3148d6c78561bf369d4ddbab09bf2fb9c7a7966b
2014-12-12Avoid spurious Talkback notificationsIhab Awad
Bug: 18678952 Change-Id: I2f15cad4b71ba780e6ed860b5dd67c745a3b4823
2014-12-09Fix potential NPE when generating accessibility text.Tyler Gunn
Traced through the original bug report; the problem is that a call to TextUtils.expandTemplate was being made with a null 2nd parameter. I traced through the callers to find out where a null could be introduced and I was unable to identify a potential source. This change introduces a last-ditch null check to protect against problems upstream. Bug: 18684529 Change-Id: I7b608dfedf052d6933e94d1f23a658763b66059a
2014-12-08Merge "Use a BroadcastReceiver for Dialpad behavior upon call hangup." into ↵Nancy Chen
lmp-mr1-dev
2014-12-08Use a BroadcastReceiver for Dialpad behavior upon call hangup.Nancy Chen
The case handled here is when a user is in the Dialer app while there is a call in progress and then the call ends, the Dialpad should revert to its "normal" mode, i.e. digits. The previous approach, using PhoneStateListener, was safe for single SIM phones, but no longer works on Multi-SIM phones because a PhoneStateListener only listens to state changes from a single subscription (e.g. SIM). A more robust way of knowing when a call hass ended is to receive a TelephonyManager.ACTION_PHONE_STATE_CHANGED broadcast. Bug: 18269410 Change-Id: I9b0578d4281bc75d0f804dc695f4bd1a9c02f2cd
2014-12-05Add Text-to-Speech annotations for phone number displays (3/3)Ihab Awad
Bug: 17321294 Change-Id: Icc712da80e25e5a5294986ece055fcffaa558f1e
2014-12-05Updating "Add Contact" to pre-populate full contact info.Tyler Gunn
1. For recent call entries with a name and phone number, the name will now also be added. 2. For recent call entries which have complete address information provided by nearby places, all information except the contact photo will be added. The contact photo is excluded, as the ContactsLoader would attempt to load the contact photo while parsing the contact information. On a slow connection this could cause a noticeable pause while adding the contact. Bug: 17308163 Change-Id: If2e78bd1257096b344ff2dd266dcdbaeed4f1471
2014-12-05Merge "Bypass Dialpad code and allow InCallUI check voicemail number for ↵Nancy Chen
MSIM." into lmp-mr1-dev
2014-12-04Bypass Dialpad code and allow InCallUI check voicemail number for MSIM.Nancy Chen
Since user needs to select a subscription before Dialer can check whether a voicemail number is set up for a certain subscription, go directly to calling voicemail when the user dials '1' on a MSIM phone where 'Ask first' is set. Bug:18233678 Change-Id: I10dd56c14bfb98e4f8410e2de400da44e328682f
2014-12-03Merge "Pass string key when updating ringtone." into lmp-mr1-devAndrew Lee
2014-12-03NPE fix.Anthony Lee
Make sure that we check the validity of the label before we call a method on it. Also removed import of unused package. Bug: 18572439 Change-Id: I4b9ae0b4ace4129fe92dcbd9abecc12620d45a86
2014-12-02Merge "On MSIM devices, include account from call log in talkback." into ↵Nancy Chen
lmp-mr1-dev
2014-12-01On MSIM devices, include account from call log in talkback.Nancy Chen
In TalkBack mode, when a user taps on a call log entry, it should read back the name of the SIM/account used for the call. The string used is "on <phoneAccount>". Also add back periods removed in the string updates because they are needed for verbal stopping points in TalkBack mode. Bug:18517912 Change-Id: Iaadbd859ef980ca030f9fb60d3395ca057e8cefc
2014-12-01Merge "Telecom API updates (2/6)" into lmp-mr1-devIhab Awad
2014-11-28Telecom API updates (2/6)Ihab Awad
Bug: 18292176 Change-Id: I3d5229a44bff032178bf2eb9fde633a10db8c7d8
2014-11-25Fix NPE in markDropAreaJay Shrauner
Check for mDraggedEntry == null Bug:18524967 Change-Id: I323cf41ddd21444d4fd675543b822c29517e8b26
2014-11-24Pass string key when updating ringtone.Andrew Lee
Instead of passing in the preference. Bug: 18232725 Change-Id: Ic0eec7cd62f1d9106da4de6d9aa29aeeead9cc0e
2014-11-21Merge "Correcting population of search box with voice search results." into ↵Tyler Gunn
lmp-mr1-dev
2014-11-20Use REDIAL instead of CALL BACK for outgoing callsYorke Lee
Bug: 17325604 Change-Id: Ida625d884088575760e394b2b58a4fc5b7126033
2014-11-20Correcting population of search box with voice search results.Tyler Gunn
The issue is the onActivityResult callback which receives the result of the voice search is called BEFORE the dialtacts activity is resumed, and hence the search results fragment is not properly shown (since resume has not yet completed). Changed so that the search results are stored until onResume, where they are applied to the search box. Bug: 18410823 Change-Id: I02985f722643846067678a67f2c1fda76434fbc4
2014-11-17Merge commit '59edcfbc' into manualmergeYorke Lee
Change-Id: I0d26d0510edf5ea49d77d8c3c7ecd657b5989d52
2014-11-17am 4e97e09f: Switch from CALL -> CALL_PRIVILEGEDYorke Lee
* commit '4e97e09f0ae58f6065252022fe5cf5f7d90aef01': Switch from CALL -> CALL_PRIVILEGED
2014-11-17Switch from CALL -> CALL_PRIVILEGEDYorke Lee
Bug: 18332160 Change-Id: I5b9bcc8f413e5534bab94e0b2677371968a8e483
2014-11-14Move ToneGenerator recreation/release to onStart/onStopYorke Lee
There is no reason to do the costly ToneGenerator initialization inside onResume, which gets called during the Dialer -> InCallUI transition. Move it to onStart/onStop so it only happens when Dialer is actually in the background. Measurement of time taken for InCallActivity start -> onResumed, 10 runs Before: Average 541.9ms SD: 152.4ms After: Average 350.5ms SD: 81.1ms Bug: 18373617 Change-Id: I192e2bcc9fd4b7d423d804f333d8d32bff3f58c1
2014-11-12Merge "Use the highlight color instead of the tint color" into lmp-mr1-devNancy Chen
2014-11-12Merge "Lookup badge member variables correctly during bindBadge" into ↵Yorke Lee
lmp-mr1-dev
2014-11-12Use the highlight color instead of the tint colorNancy Chen
The tint color of a phone account only refers to the color of the icon, the highlight color is the general display color used for text, backgrounds etc. We should use highlight color in Dialer Bug: 18192071 Change-Id: Ia7e1c6cf055357df98b2b2f481b32a727d1f6d61
2014-11-11Remove summary/secondary text from settings.Nancy Chen
Per settings design guildelines, we should not be using the second line to describe the contents of a setting with subscreen navigation (this second line is now used for just status). Remove these second lines from the dialer settings UI. Bug: 17446974 Change-Id: Idbeace64c088805a19a77b1438dd66a618387848
2014-11-11Merge "Fix IOOB exception in ViewDragHelper" into lmp-mr1-devYorke Lee
2014-11-11Fix IOOB exception in ViewDragHelperYorke Lee
If findPointerIndex returns -1, ignore the motion event. The equivalent fix is done for other handlers of motion events as well. Bug: 18186775 Change-Id: Ia7548335eeb84310510260381a8bcedf6556aa40
2014-11-10Lookup badge member variables correctly during bindBadgeYorke Lee
If a new call log view is provided, make sure to correctly find and stash the correct member variables inside bindBadge. Bug: 18016618 Change-Id: If01a68fc6c468905ab576b1c5927afa308238786
2014-11-10Update PhoneAccount icon API (3/6)Ihab Awad
Bug: 18291787 Change-Id: Id53193a2597ac6a7827a484279e130d8bfb78b77
2014-11-08Allow ILD information to be populatedEvan Charlton
Expose the dialpad's ILD (international / long distance) fields to be populated by the dialer. Bug: 13334252 Change-Id: Ia366148ef1318a2dacc4971d51a3bd34ec3c39de
2014-11-06Merge "Fix for "Clear call log" menu item showing up incorrectly." into ↵Yorke Lee
lmp-mr1-dev
2014-11-06Merge "Improve Dialer analytics" into lmp-mr1-devYorke Lee
2014-11-06Merge "Reset mSavedState in onNewIntent because the activity is refreshing." ↵Nancy Chen
into lmp-mr1-dev
2014-11-06Fix for "Clear call log" menu item showing up incorrectly.Yorke Lee
The fragment member variables were being lost on rotation because the FragmentManager does not call getItem on rotation. Fix the way we save the fragments into member variables to ensure that those references are always up to date so that mAllCallsFragment is not null after rotation. Bug: 17478780 Change-Id: I5a0c070273f2d86864afd96c6bb6551bcd0d1aa4
2014-11-05Improve Dialer analyticsYorke Lee
* Send screen view for first fragment loaded inside ListsFragment * Send screen view for voicemail playback fragment * Send screen view for currently active fragment when activity is restarted * Don't send spurious screen views on rotation * Send screen views for call log fragments in call log activity, and differentiate between them with a tag Bug: 18158037 Change-Id: I09fda53db33f6a6acc4a3b477de992aa94921c71
2014-11-05Reset mSavedState in onNewIntent because the activity is refreshing.Nancy Chen
Currently mSavedState is reset to false in just onResume, but it needs to be reset earlier so that the dialpad is allowed to show itself when an ACTION_DIAL intent is sent. Bug: 18242314 Change-Id: I9ddd2a431edc4c2d1cc447b14ee8d1347d139552
2014-11-05Merge "Protect against ActivityNotFoundException" into lmp-mr1-devYorke Lee
2014-11-04Protect against ActivityNotFoundExceptionYorke Lee
Bug: 18247185 Change-Id: I744355ea712f713d5510fa26f141ee2cce7491ff
2014-11-03Refactoring: modifying SelectPhoneAccountDialogFragment constructor.Nancy Chen
The SelectPhoneAccountDialog fragment now supports optional/changeable title and checkbox fields, but to simplify that case, add a method that will initialize the dialog to default values. Bug: 18204058 Change-Id: Icd3b880378ff9a7d8ee75e01ec85ed40b29a59ab
2014-11-04Merge "Adn queries for multi-SIM. (1/3)" into lmp-mr1-devNancy Chen
2014-11-03Adn queries for multi-SIM. (1/3)Nancy Chen
Bring up a dialog if no default subscription account is set by the user when handling ADN queries. Bug: 17917937 Change-Id: Icd6a6dc2843463ba68d281a24e00fdba1880adf4
2014-10-31Add an additional line to Call Log for PhoneAccount nameNancy Chen
Add a line under call log to display PhoneAccount label in the color of the account/SIM. Bug: 17971273 Change-Id: I16c37ae8828245f928bc3867a498a29e73b5925c
2014-10-31Merge "Enable MMI for multi-SIM (3/3)" into lmp-mr1-devNancy Chen
2014-10-31Merge "Use improved analytics in Dialer" into lmp-mr1-devBrian Attwell
2014-10-30Enable MMI for multi-SIM (3/3)Nancy Chen
+ Add Telecomm and Telephony methods for handlePinMMIForSubscriber + Add Select Account dialog in Dialer for MMI Bug: 17917937 Change-Id: Iaabd0c5705cdf0d325aa7514d04935747078b28c
2014-10-30Use improved analytics in DialerBrian Attwell
Remove dependencies on old analytics code. Initialize analytics inside DialerApplication. Improving analytics CL #4/4 Bug: 18039620 Change-Id: I52f68e50297db2aae61d67d9bdbe66cb1d75aafc
2014-10-29Merge "Refactor ActionBarController and tests" into lmp-mr1-devYorke Lee
2014-10-29Merge "Remove "Dial to add call" text in Dialpad" into lmp-mr1-devYorke Lee
2014-10-28Refactor ActionBarController and testsYorke Lee
The original CL to fix ActionBarControllerTest by using an ActivityInstrumentationTestCase was too heavyweight and caused flaky test. It was also indicative of a flaw in the original design that ActionBar couldn't be mocked out easily. Refactor the code so that: 1) getActionBar() is no longer needed 2) Respect the invariant that all access to the actionBar goes through the ActionBarController (see the changes in ListsFragment) so that any change to the ActionBar's hide offset can be tracked appropriately. Bug: 17487016 Change-Id: I935b683ddb301ca5d3952889af1381bdbdcc97d3
2014-10-28Merge "Fix various IllegalStateExceptions in Dialer" into lmp-mr1-devYorke Lee
2014-10-28Remove "Dial to add call" text in DialpadYorke Lee
Also remove some unnecessary strings Bug: 17647791 Change-Id: I0e5797b3aad35dd37607fde944c1329fbeffbe88
2014-10-28Fix various IllegalStateExceptions in DialerYorke Lee
Make sure to not commit any fragment transactions when onSaveInstanceState has been called. Bug: 18038718 Bug: 18142294 Bug: 18106980 Change-Id: I0755208ee6637431cb3e494b5494b1ccdd930489
2014-10-27Create call settings intent in DialerSettingsActivity.Andrew Lee
- Remove helper method in DialtactsActivity. + Create intent in DialerSettingsActivity. This is the only place the method is called; it seems that this code to create the intent should live in DialerSettingsActivity instead of DialtactsActivity. Bug: 18114923 Change-Id: I129b716c2a247994647c123f1cbd945b7ef36778
2014-10-27Merge "Fix some broken Dialer tests" into lmp-mr1-devYorke Lee
2014-10-27Merge "Send desired size of photo to ContactPhotoManager" into lmp-mr1-devYorke Lee
2014-10-25Fix some broken Dialer testsYorke Lee
Bug: 17487016 Change-Id: I4c13c3e826a4eb1de84708dfa27ad093b2134087
2014-10-25Send desired size of photo to ContactPhotoManagerYorke Lee
This allows it to correctly determine if the photo should be treated as a thumbnail (and thus cropped into a circle), and also saves on RAM since the full sized bitmap doesn't need to be decoded. Bug: 17327890 Change-Id: Ia92cfd9005ea2060608284e3c1f6a539bdd6da72
2014-10-25Merge "Remove CallLogListItemView" into lmp-mr1-devYorke Lee
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-19 20:37:51 +0000