summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2014-02-18Switch favorites screen to grid layoutYorke Lee
* Add logic to PhoneFavoritesTileAdapter so that it now supports an unlimited number of tiled rows. * Tiles now have a configurable height to width ratio. * Fix animations so that tiles moving up and down rows appear to animate in from the correct direction. Tiles moving to the row above should animate in from right to left. Tiles moving to the row below should animate in from left to right. * Update the number of columns in the grid to 2. * Update layout of individual tiles to match redlines from UX. * Tweak font sizes for tiles * No longer truncate names in tiles * Tiles have a 2-3 height to width ratio * Update assets and layout for favorite and more info icons * Add content description for the favorite button * Add tests for PhoneFavoritesTileAdapter Change-Id: I50b298f0941698985d281f13e6a87c5a9b613efa
2014-02-03Call History Affordances SwapTyler Gunn
1. Swapped the intents for the primary view 2. Changed the icon for the secondary action button 3. Added a vertical divider line to separate the secondary action button from the primary view 4. Cleaned up the accessibility text Change-Id: Ifd4ceff0d67b1587c4378e29be7344de50057a7d
2014-01-16Fix synchronization in onNotNullableQueryCompleteJay Shrauner
Synchronize onNotNullableQueryComplete to protect mCallLogCursor and mCallsRequestId. Bug:12591404 Change-Id: Ib1de73d2da0f14875a98b25113a132681da0beaa
2014-01-09Fix NPE in deleted contact removalJay Shrauner
Fix NPE in deleted contact removal. Bug:12475233 Change-Id: I7f7a2c78e62e838728868063b0f76e6bffba2130
2013-12-20Merge "Fix potential NPE in saveHorizontalOffsets"Jay Shrauner
2013-12-20Merge "Protect against class cast exception"Jay Shrauner
2013-12-19Support long-click during lift-to-type accessibility modeAlan Viverette
BUG: 8310727 Change-Id: Icf9e103d2d6f5b5e7acb8c7f16244f0cebe9ffaa
2013-12-19Protect against class cast exceptionJay Shrauner
Protect against class cast exception. Bug:12228894 Change-Id: Ifae04d6354812e296890cfe0c4c5f2fff73c4c2a
2013-12-19Fix potential NPE in saveHorizontalOffsetsJay Shrauner
Fix potential NPE in saveHorizontalOffsets. Bug:12031506 Change-Id: I713fed5995356bdaaf93186454dcc53b92cb75ec
2013-12-17Add null check for cursor in UndemoteOutgoingCallReceiverYorke Lee
Bug: 12179558 Change-Id: I2a991b981a76afdec0282936f63732c43652baea
2013-12-13am a6536611: am f427ab83: am ce150742: am dc372cc7: Merge "Add a content ↵Elliott Hughes
observer for voicemail to the call log fragment" * commit 'a65366114ad3b1014c22d8a84c74a94fb7f47139': Add a content observer for voicemail to the call log fragment
2013-12-13am dc372cc7: Merge "Add a content observer for voicemail to the call log ↵Elliott Hughes
fragment" * commit 'dc372cc7464e7869e6ca0caed6a81bd53e43a6e1': Add a content observer for voicemail to the call log fragment
2013-12-13Merge "Add a content observer for voicemail to the call log fragment"Elliott Hughes
2013-12-11Fix NPE in DialerDatabaseHelper for null phone numbersYorke Lee
Bug: 12006585 Change-Id: Iaed732806cbb8fb0301596162102e81ab8ec6024
2013-12-11Merge "Hide voice search button if intent cannot be handled"Yorke Lee
2013-12-09Remove private reference to TelephonyIntents.SECRET_CODE_ACTIONYorke Lee
Bug: 6948882 Change-Id: Id08daec677abddf1c1987ac3f41dbefe89a10144
2013-12-06Hide voice search button if intent cannot be handledYorke Lee
If the Google Search app is disabled (this only seems to be possible on Nexus 4), the Dialer crashes if the voice search button is pressed. This CL hides/shows the voice search button every time the dialer is launched/resumed after checking to see if there exists an activity that can handle the ACTION_RECOGNIZE_SPEECH intent. A string to indicate that voice search is unavailable is also added just in case the user ends up in a weird state where the button is showing but clicking on it would throw an ActivityNotFoundException. Bug: 12015318 Change-Id: Idd7ec2da422425dd95ae0060ebc9b85a2cf35fb0
2013-12-05Merge "Always call through to super.onBackPressed in DialtactsActivity"Yorke Lee
2013-12-05Merge "Catch ActivityNotFoundException in CallDetailActivity"Yorke Lee
2013-12-05Always call through to super.onBackPressed in DialtactsActivityYorke Lee
moveTaskToBack is causing crashes in the Dialer when the back button is pressed. This was legacy code that was unchanged in the new dialer. We should probably just call through to super.onBackPressed regardless of whether or not the task was at the top of the stack, to behave the same (navigation wise) as other apps. Bug: 12015851 Change-Id: Ic0c3efb30b3874ad892b96a9fadd524313cfb782
2013-12-05Merge "Temporarily stop UI refresh during drag and drop"Yorke Lee
2013-12-05Catch ActivityNotFoundException in CallDetailActivityYorke Lee
Bug: 12015287 Change-Id: I23b167e22d0da7f9be98b49e120b5b8ac1700e9a
2013-12-05Add null check in CallLogNotificationsServiceYorke Lee
Bug: 12015853 Change-Id: Ia2394f1ee0f102de4eab3f5468fd6204727b607d
2013-12-05Add a content observer for voicemail to the call log fragmentHUANG Menghuai
The voicemail status message was not updated with new voicemail status. Change-Id: I3430bb5c21d8b25c863ca1e74f48774012c961c8 Signed-off-by: HUANG Menghuai <menghuai.huang@orange.com>
2013-12-03Temporarily stop UI refresh during drag and dropYorke Lee
If the user is in the middle of a drag and drop operation, temporarily stop UI refreshes when a new cursor is delivered, to prevent UI inconsistencies. This CL only fixes the dragging/dropping case. Swiping is still buggy (the fix is more complicated/risky), and swiping might be removed altogether in the future. Bug: 11119329 Change-Id: I2939c915d4eb5d8f9de19a369b21c6c98806ba94
2013-12-02Merge "Remove ContactPrefs from DialpadFragment"Yorke Lee
2013-11-26Remove ContactPrefs from DialpadFragmentYorke Lee
DialpadFragment currently instantiates an instance of ContactsPrefs that is not needed. Change-Id: I8207f8d55c578a748c5edab1f722b18b5d38b48b
2013-11-25Merge "Remove use of hidden TelephonyManager methods"Yorke Lee
2013-11-25Merge "Fix Dialer tests"Yorke Lee
2013-11-22Remove use of hidden TelephonyManager methodsYorke Lee
Bug: 6948882 Change-Id: Ibce04c24e64fdb33fba532c0f0e5dca3b11f1b6c
2013-11-22Fix SmartDialNameMatcher NANP testYorke Lee
Statically initialize prefix logic to use NANP matching for NANP tests Bug: 10346442 Change-Id: Ia268de8a9bc5ad8dae70fe6934823a3c289f0bae
2013-11-22Fix Smart dialing testsYorke Lee
Test contacts were being created without unique contact ids and lookup keys, causing them to be mistakenly identified as duplicates. Bug: 10346442 Change-Id: I47fd5bdae83346b6b2f620d7abe49326b1cfd23d
2013-11-22Fix Dialer testsYorke Lee
* Empty geocode is now " " instead of "-" per UX request * DialpadFragment now throws IllegalArgumentException instead of Log.wtf so that it can be tested * Added contact id column to contactsprovider query * Modified PhoneNumberDisplayHelper to take an instance of PhoneNumberUtilsWrapper so that it can be mocked out Fix label-related tests that were failing due to a change in how we treat empty labels Bug: 9111164 Change-Id: If2244586b9d09fa2839fa0ddfc9f369f9dc66e51
2013-11-21Remove use of SystemPropertiesYorke Lee
Remove private reference to SystemProperties, needed for Verizon requirements (per team email discussion) Bug: 6948882 Change-Id: Idc826e4a93609799e3c741d36fca5124abbc5bb9
2013-11-20Merge "Fix ANR in UndemoteOutgoingCallReceiver"Yorke Lee
2013-11-19Fix ANR in UndemoteOutgoingCallReceiverYorke Lee
Querying the contacts provider for the contact id should happen in a new thread as well. Bug: 11773499 Change-Id: I715e7e9b4a650efbd708d4ad3793dad742b74a14
2013-11-20Merge "Switch convertAndStrip to normalizeNumber"Yorke Lee
2013-11-20Merge "Remove private references to isUriNumber and getUsernameFromUriNumber"Yorke Lee
2013-11-20Merge "Rename PhoneNumberHelper in Dialer"Yorke Lee
2013-11-19Switch convertAndStrip to normalizeNumberYorke Lee
normalizeNumber(to be renamed in the future) is a bit stricter about converting the number into a dialable one. Bug: 6948882 Change-Id: I09417822de714beb45664ca4f0916e40013a34bb
2013-11-19Remove private references to isUriNumber and getUsernameFromUriNumberYorke Lee
These methods in PhoneNumberUtils are pretty specific, so don't make them public APIs. Instead, use the methods already in PhoneNumberhelper. Bug: 6948882 Change-Id: I487593543eba526c64588d9a3e70b19b4ed941ab
2013-11-19Merge "Use single instance of PhoneNumberUtilsWrapper"Yorke Lee
2013-11-19Rename PhoneNumberHelper in DialerYorke Lee
Rename PhoneNumberHelper to more appropriate PhoneNumberDisplayHelper Change-Id: I2c03f5cbb04c1e03f1fc1e0051a1cea641160dca
2013-11-19Fix crash when number is nullJay Shrauner
Fix crash in various routines when the number is null. Bug:11766758 Change-Id: I3bcedbd8ada663a8c47528f32e213f653195fe57
2013-11-18am 3ec7f823: am 8b7de609: am 1ae0cf68: Fix possible NPE in DialerDatabaseHelperYorke Lee
* commit '3ec7f823c3ec0eedaf4044bd535411e59bcc820a': Fix possible NPE in DialerDatabaseHelper
2013-11-18Fix possible NPE in DialerDatabaseHelperYorke Lee
In certain cases (third party contact backup solutions?) it is possible for raw contacts to end up with null display names, which the Dialer was crashing on. This fix performs a null check and inserts the default (No name) contact name if we find that the display name is null. Bug: 11750613 Change-Id: Ifbaf2861534e6eaf8a86d50d584d11a9fa38b65f
2013-11-18Use single instance of PhoneNumberUtilsWrapperYorke Lee
PhoneNumberUtilsWrapper is creating a new instance of the class everytime it tries to look up an unknown number. Just use a single instance for this instead to avoid redundant object creation. Change-Id: I418d95ced42c1db06c63848768050a181defb347
2013-11-13am a70f4547: am 43744cc2: am 349f3e1b: Merge "Color/layout tweaks for ↵Yorke Lee
Dialer" into klp-dev * commit 'a70f45478c1ff89a85d29dfda95e6082d67a4816': Color/layout tweaks for Dialer
2013-11-13am b48e4549: am 550e61cf: am 59a39432: Merge "Change all contacts button to ↵Yorke Lee
look like list item" into klp-dev * commit 'b48e45496dd75bb7de73327a5a238dc8e19dc91d': Change all contacts button to look like list item
2013-11-14Merge "Color/layout tweaks for Dialer" into klp-devYorke Lee
2013-11-14Merge "Change all contacts button to look like list item" into klp-devYorke Lee
2013-11-13Color/layout tweaks for DialerYorke Lee
Add search icon into search box Change background of recent cards shortcut to whiter one Whiten the action bar Darken background color of list items Reduce size of searchview text Bug: 11654293 Change-Id: I204b14e752b40563a6f7ebdd1d61f10854b41100
2013-11-13Change all contacts button to look like list itemYorke Lee
Rewrite layout of all contacts button to look like a regular contact list item. Update list default avatar background Bug: 11654293 Bug: 11668831 Change-Id: Iafa8f69e618b39eabf823cafd8153ed24ddbdfbd
2013-11-13am 1cc54f02: am f9d19153: am 759c264e: Merge "Dismiss dialpad when user ↵Chiao Cheng
touches spaces above it." into klp-dev * commit '1cc54f025ca77481f5346042a7eb107111158fc8': Dismiss dialpad when user touches spaces above it.
2013-11-13Merge "Dismiss dialpad when user touches spaces above it." into klp-devChiao Cheng
2013-11-12Dismiss dialpad when user touches spaces above it.Chiao Cheng
Only applies if the user has not input any digits yet. Bug: 11648799 Change-Id: I28a57fcd7eae0faaf5e234e9ec7531140903e2f5
2013-11-12am 86666e28: am 8e578cfe: am c3cb63b6: Merge "Fix possible FragmentManager ↵Yorke Lee
NPE in Dialer" into klp-dev * commit '86666e2852262162f5ba101b9ab054f981777ef1': Fix possible FragmentManager NPE in Dialer
2013-11-12Merge "Fix possible FragmentManager NPE in Dialer" into klp-devYorke Lee
2013-11-08am c51392d7: am a5b38196: am d20f843e: Merge "Treat unknown call types as ↵Yorke Lee
missed calls" into klp-dev * commit 'c51392d773e77376f182781bb2405a5043809fda': Treat unknown call types as missed calls
2013-11-08Merge "Treat unknown call types as missed calls" into klp-devYorke Lee
2013-11-08Treat unknown call types as missed callsYorke Lee
Don't crash on unknown call types. Instead, just treat them as missed calls. Bug: 11586034 Change-Id: I4ca1721e1526ade36237251e7636d161ca8490be
2013-11-08Fix possible FragmentManager NPE in DialerYorke Lee
Bug: 11595442 Change-Id: I7859f61bf8b5eb6b6e14d5f18cf689613124ce6c
2013-11-08am c317b836: am 967e0ed3: am cce501cb: Fix bug where resuming ↵Yorke Lee
CallDetailActivity loses the add contact intent * commit 'c317b8363d2369b4651fc4d88fa8c711f45ab23b': Fix bug where resuming CallDetailActivity loses the add contact intent
2013-11-08Fix bug where resuming CallDetailActivity loses the add contact intentYorke Lee
getLoaderManager.initLoader() performs the onLoadFinish callback immediately if CallDetailActivity is being resumed from a previously paused state. This causes bindContactPhotoAction to be called with a null intent later on causing the add contact button to be no longer clickable. To fix this, if we know that we will receive a loader call back that correctly binds the intent later on (or immediately), we should skip the initial bind. Bug: 11588776 Change-Id: I9407a88ec8bbde303109eb14496e01cf6c347c8f
2013-11-06am 256ff69b: am 05a28a4b: am b7126bf1: Merge "Load contact in ↵Yorke Lee
CallDetailActivity and add it to Add contact intent" into klp-dev * commit '256ff69b81dd538c8ec82a33036ca655fe8ab43c': Load contact in CallDetailActivity and add it to Add contact intent
2013-11-06Merge "Load contact in CallDetailActivity and add it to Add contact intent" ↵Yorke Lee
into klp-dev
2013-11-05Load contact in CallDetailActivity and add it to Add contact intentYorke Lee
Use a ContactLoader to load the contact data stored in the json-encoded URI asynchronously, and prepopulate the add contact intent with the contact data when the contact data is loaded. This fixes the problem of contact details (i.e. name, photo, address) not being pre-populated when adding a contact via a call log entry that was created by calling a contact from nearby places search. Bug: 11294679 Change-Id: I39a0d8ae40e80b350687a43be8ece6b32c88062a
2013-11-01am 6c97009c: am b911519f: am 16016d95: Add null check in ↵Yorke Lee
SmartDialCursorLoader.releaseResources * commit '6c97009c9fe8ea610717afb93ca2fafaff0bc261': Add null check in SmartDialCursorLoader.releaseResources
2013-11-01Add null check in SmartDialCursorLoader.releaseResourcesYorke Lee
Bug: 11474252 Change-Id: Id5a64aa72790bddef9e8fd2d4661635bd2eb6f44
2013-10-25Merge "Remove private references from Dialer"Yorke Lee
2013-10-24Merge "Remove use of applicationScale from ContactsCommon"Yorke Lee
2013-10-24Remove use of applicationScale from ContactsCommonYorke Lee
ApplicationScale is always 1.0 by default if android:anyDensity is not specified in AndroidManifest.xml Change-Id: I74893b9deb6500ed881aa48525a3becaef88480f
2013-10-22am 3a9b3115: am 32443904: am 934d3ee3: Fix call log jankYorke Lee
* commit '3a9b311556e967bd9deab6a258218fe4154867c9': Fix call log jank
2013-10-21Fix call log jankYorke Lee
Restore previous jank-fix while ensuring that contacts with images not in the ContactProvider are still updated Bug: 11289654 Change-Id: I89723bd08c9dc83731b7a7555dc0364c74faa9a4
2013-10-21Remove private references from DialerYorke Lee
Remove MathUtils.constrain Use VisibleForTesting annotation in Guava Use Sets class in Guava Change-Id: Ib46e50ae2c0f278f6f588bb769b89ea37d8c5b30
2013-10-21Use setMargins instead of setMarginsRelativeYorke Lee
setMarginsRelative is a private API and is not needed since margins are equal on all sides Change-Id: I2aeeb336e2c59132224a5b1a69560ca05f76bec2
2013-10-08Merge "Do not use implicit intent to up nav to call log." into klp-devChiao Cheng
2013-10-08Merge "Check for closed cursor to prevent crash." into klp-devChiao Cheng
2013-10-08Do not use implicit intent to up nav to call log.Chiao Cheng
Implemented according to developer docs: http://developer.android.com/training/implementing-navigation/ancestral.html Bug: 11116403 Change-Id: I02dd4900fbda921ddeaaa2a1ac8fa780152dc6ec
2013-10-08Merge "Don't show PII in logs for JSON-encoded uris" into klp-devYorke Lee
2013-10-08Check for closed cursor to prevent crash.Chiao Cheng
No-op if click detected while cursor is closed. Bug: 10937133 Change-Id: I702e30c91a0c76cd36204a4c689155e49b775c1e
2013-10-08Don't show PII in logs for JSON-encoded urisYorke Lee
Bug: 11127944 Change-Id: Id362b5bcd5822779aa070143f5d292da70e85ed1
2013-10-08Make enlarged actionbar invisible when showing dialpadYorke Lee
Bug: 11118584 Change-Id: Ia89c569f9c95912aeeef5c29cf6b6f140e7334dc
2013-10-07Clear phone number cache when call log is clearedYorke Lee
Bug: 11027471 Change-Id: I8437073e1d01e5223e89fce78795d5274db97c8e
2013-10-06Fix accessibility issues with dialpadYorke Lee
Each dialpad key needs to manually have the "focusable" flag set so that hovering and lift-to-type works properly. The edittext containing digits needs to receive focus at least once in order for it to report sendAccessibilityEventTypeViewTextChanged type events. In JB-MR2, the ViewPager would automatically give focus to the dialpad fragment when it was swiped into view, but now we have to manually give it focus ourselves when the dialpad fragment is swiped into view. Bug: 11067558 Change-Id: I56a1891b12d5ec7771a37e1f7c361242ebfe028d
2013-10-04Merge "Fix infinite dialpad tones due to rapid presses" into klp-devYorke Lee
2013-10-03Adds tooltip for DialerChristine Chen
Bug: 10916819 Change-Id: Ic18f982a6d478b165f576361cfec6edb8c6eb1c3
2013-10-03Fix infinite dialpad tones due to rapid pressesYorke Lee
Use a set of views, instead of a simple counter to track whether or not tones should still be played. Bug: 10906908 Change-Id: I6bdb08c253f17d9b0aa867b5cbdf4770bc52510b
2013-10-03Merge "Dynamically change layout params to avoid hiding no favorites view" ↵Yorke Lee
into klp-dev
2013-10-02Merge "Don't allow dialpad presses until it is fully in position" into klp-devYorke Lee
2013-10-02Fixes how voicemail looks up contact namesChristine Chen
Bug: 10966248 Change-Id: I6532e71c3a63104587e5f9bdba59ce2eb3423bb4
2013-10-02Merge "Clicking on dialer directory headers scrolls to selected directory" ↵Yorke Lee
into klp-dev
2013-10-02Don't allow dialpad presses until it is fully in positionYorke Lee
Bug: 11006188 Change-Id: I67861038510591384daf4e2c5da06af3dda5439c
2013-10-02Merge "Filters out legacy unknown numbers." into klp-devChristine Chen
2013-10-02Merge "Turn on reverse lookup by default." into klp-devChiao Cheng
2013-10-02Dynamically change layout params to avoid hiding no favorites viewYorke Lee
Bug: 11029206 Change-Id: I4965515b51592a5bb8808b9654cb246782875c0a
2013-10-01Fix brief flash when making a call from searchYorke Lee
Perform the fragment transaction to hide search in onPause. This prevents the brief flash that shows up in the time between pausing the activity and starting the in-call UI, but also ensures that we execute the transaction before onSaveInstance is called to prevent b/10953115. Bug: 10780429 Change-Id: I85b4c7e6719acede845d604087344401edc9ef3d
2013-10-01Clicking on dialer directory headers scrolls to selected directoryYorke Lee
Enable setScrollToSectionOnHeaderTouch for dialer search Bug: 10991974 Change-Id: If6021ece166ae0cba8bb3a9f1db77c7b3f8a9e5c
2013-10-01Fix crash when dragging a contact to searchboxYorke Lee
Also fix drag handling so that dropping outside the listview will also complete the drag animation. Bug: 11017468 Change-Id: I968cc8463e9d567b0a8c62f851c067d589571c6d
2013-09-30Fix flicker when long pressing to drag and dropYorke Lee
Initial creation of drag shadow now uses the same layout logic as drag hovering so that the shadow does not jump upon first creation. Removed setPressed from onLongClick listener to avoid toggling of pressed state when drag was started. Bug: 10991974 Change-Id: I186cd62060e3a79913aa89fb7af989f3497e0b10
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-19 07:07:27 +0000