summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2015-10-07Show blocked contact instead of profile photo.Andrew Lee
Does not yet update on change; figuring to do that in a followup CL because there are a number of other scenarios where that needs to be fixed too. Bug: 23943480 Change-Id: I73615c405d547e74667f6c635b5623708c723347
2015-10-07Merge "Consolidate setPhoto logic." into ub-contactsdialer-a-devAndrew Lee
2015-10-07Consolidate setPhoto logic.Andrew Lee
This makes the ViewHolder self-capable of updating/setting its photo, so if we want to update the photo in the future (either in teh scope of a listener, or in the ViewHolder itself), we don't need to worry about configuring and passing around a bunch of commands. Bug: 23943480 Change-Id: I17653014dd81fcb9ae7a667539e40a9310a72d36
2015-10-07Merge "Group blocked calls separately in call log." into ub-contactsdialer-a-devAndrew Lee
2015-10-06Show prompt to request for location permissionYorke Lee
Clicking on TURN ON currently only asks for the location permission. Showing the dialog that toggles location sources is planned for a follow up CL. Bug: 24172011 Change-Id: Ieb6bd58a60aacbda76f9c754efeebfdd9e89aa86
2015-10-06Merge "Don't set FilteredNumberAsyncQueryHandler." into ub-contactsdialer-a-devAndrew Lee
2015-10-06Merge "Convert caller information into list header." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-06Convert caller information into list header.Andrew Lee
this allows us to scroll the header with the rest of the screen, instead of having it pinned to the top, as it is currently. Bug: 24109819 Change-Id: Ic440bc18d31d196493a86130e06d954c453c9146
2015-10-06Merge "Show blocked icon in call log." into ub-contactsdialer-a-devAndrew Lee
2015-10-06Actually launch onboarding flow if neededYorke Lee
Launch OnboardingActivity for exported activities (DialtactsActivity, CallDetailsActivity) to ensure that a) We prompt the user to make us the default dialer at least once b) The user has granted us both the Phone and Contacts permissions Bug: 24270592 Change-Id: I232314e42f5331a72c1a84be917d9d74c5813976
2015-10-06Show blocked icon in call log.Andrew Lee
For calls of type BLOCKED, show the blocked call icon. Bug: 23943480 Change-Id: Ic1477090c31d51322dbe04dac29f1ca3b0dae4d1
2015-10-05Dismiss filter dialog on rotation.Andrew Lee
This simplifies addressing a number of rotation cases by eliminating them completely. Otherwise, we need to worry about updating references, such as having the right fragment or activity reference to be able to provide the correct parent view for the snackbar. This is particularly complicated in some cases in Dialer because we have a fragment => adapter => viewholder hierarchy to pass through. Bug: 24638328 Change-Id: Ic8a5d2c3ca35742f5bb0986d77ae3b8d5f44e4dd
2015-10-03Don't set FilteredNumberAsyncQueryHandler.Andrew Lee
Rather than creating single instances and setting them or passing them around, create them when we need them. This won't happen too often so instantiating the objects shouldn't be too much of a burden on the system. Instances of AsyncQueryHandler all end up running tasks off the same thread, so there should not be a negative consequence of spinning off more threads. Bug: 24638328 Change-Id: If53ce4f1fd83736c330c1ff02946ed45da575796
2015-10-03Group blocked calls separately in call log.Andrew Lee
+ Group blocked calls separately from other call types, but group adjacent blocked calls together. + Add unit tests. Bug: 23943480 Change-Id: Iffe6fac800007f6b88e0feb15d91c63515e496f8
2015-10-02Prepatory CallDetailActivity tweaks.Andrew Lee
Incremental CL in changing actions/layout of CallDetailActivity to move actions such as Block/Edit/Copy out of the overflow menu. + Make header at top of Call Detail Activity smaller. + Move delete options into actionbar button. - Delete call list header in CallDetailActivity. Bug: 24109819 Change-Id: If75f016e14de9e2c5ac8629c4bfa38e2380ce48b
2015-10-02Merge "Revert "Prepatory CallDetailActivity tweaks."" into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-02Revert "Prepatory CallDetailActivity tweaks."Andrew Lee
This reverts commit 11a7350843ec13c7ca4d27523e9ba146911d2767. Change-Id: Idf62da51c934ee598c1bbc1b5052e6cea2929feb
2015-10-02Merge "Add blocked number indicator to search screen for adding a blocked ↵Anne Rong
number." into ub-contactsdialer-a-dev
2015-10-02Merge "Modifying voicemail call log date and time format" into ↵Brandon Maxwell
ub-contactsdialer-a-dev
2015-10-02Add blocked number indicator to search screen for adding a blocked number.Anne Rong
Bug: 24468656 Change-Id: I31091e2dde07dabc432247fd4e409907fada152b
2015-10-02Merge "Prepatory CallDetailActivity tweaks." into ub-contactsdialer-a-devAndrew Lee
2015-10-02Prepatory CallDetailActivity tweaks.Andrew Lee
Incremental CL in changing actions/layout of CallDetailActivity to move actions such as Block/Edit/Copy out of the overflow menu. + Make header at top of Call Detail Activity smaller. + Move delete options into actionbar button. - Delete call list header in CallDetailActivity. Bug: 24109819 Change-Id: I1a5fedc54d1bb725597a07f4cfd8d7f6e8627a32
2015-10-02Merge "Add BLOCKED call type and util to mark in call log." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-02Add BLOCKED call type and util to mark in call log.Andrew Lee
To support call blocking, added BLOCKED call type. Also added utility to be able to mark the most recent call from a number as BLOCKEd in the call log database. Added REJECTED call type as well. This is not presently used within our application, but we want to reserve the integer, anticipating changes in the framework to add this constant. Introduced AppCompConstants, because BLOCKED and REJECTED call type values will not be defined as part of the API on M devices. Change existing call type constants to reference this compatability class. Bug: 24341350 Change-Id: I523ebd8dd1844a3b71a69a14bd38073be5940804
2015-10-02Modifying voicemail call log date and time formatBrandon Maxwell
Bug: 22168682 Change-Id: Id0135ca03310f6c1587151af81c29b22e9d20d2b
2015-10-02Merge "First pass for Dialer onboarding flow" into ub-contactsdialer-a-devYorke Lee
2015-10-02First pass for Dialer onboarding flowYorke Lee
* Add OnboardingActivity that controls the onboarding the UI ensuring that the user grants the necessary permissions before the Dialer can start. * Add first pass (no graphics, eyeballed measurements) for the screens that request for default dialer as well as permissions * OnboardingActivity is not actually launched at this moment - will be tied in to the various Dialer activities in a follow up CL. * Add tests for logic that controls the display of the screens in anticipation of future additions to the onboarding flow. * Add mockito library to DialerTests's Android.mk Bug: 24270592 Change-Id: I00d0f75edaecaa85042b136b0d830b5fbb3a0a73
2015-09-29Rename OnPhoneNumberPickerActionListener methodsAnne Rong
Bug: 24506966 Change-Id: Ibc1d334fc18235c3d5971364d7024db61c590c46
2015-09-29Add search for adding blocked numbers to the blocked number management screen.Anne Rong
Bug: 24134038 Change-Id: I30b283a6b67d7e64b58138762079c4bceb8fc64f
2015-09-25Merge "Show ImportExportDialogFragment based on tabs" into ↵Wenyi Wang
ub-contactsdialer-a-dev
2015-09-25Show ImportExportDialogFragment based on tabsWenyi Wang
Bug: 19850584 Change-Id: Ic2faade79bebfc352c3f492c4cb7679090022e63
2015-09-25Use TransactionSafeActivityJay Shrauner
Remove custom visibility tracking. Bug:24294419 Change-Id: I2ef53549e7d8c07e92319bc57c4aebd05edb8ea6
2015-09-24Fix IllegalStateException in onOptionsItemSelectedJay Shrauner
Check to make sure the activity is still visible before doing anything. Bug:24373052 Change-Id: I35a05227f02c117b29b5a29af9dfc54c00ba3616
2015-09-24Merge "Protect against more Telecom privileged operations" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-22Merge "Use displayNumber instead of info.formattedNumber for blocked number ↵Anne Rong
messages." into ub-contactsdialer-a-dev
2015-09-22Use displayNumber instead of info.formattedNumber for blocked number messages.Anne Rong
Bug: 24275589 Change-Id: I3810a04da0c7f48fc875c3456ddb36e3761530c0
2015-09-22Merge "Fix snackbar using out of scope View in blocked numbers list." into ↵Anne Rong
ub-contactsdialer-a-dev
2015-09-22Protect against more Telecom privileged operationsYorke Lee
Make sure that all invocations of TelecomManager methods that could possibly require a permission are protected by a permission check. Some of these are overcautious - for example, the UI should never show the option to return to a call (READ_PHONE_STATE) if we didn't detect an active call (READ_PHONE_STATE) in the first place, so it is not strictly necessary to protect against the former. But not crashing is the most preferable of all options. Bug: 20266292 Change-Id: Id91dd16e34320a5e607f91dbce9a4296025eeaaf
2015-09-21Fix snackbar using out of scope View in blocked numbers list.Anne Rong
Bug: 24272126, 24273593 Change-Id: I79f3ffbc745a914a11f9a61e5f06bb87be9d54de
2015-09-22Merge "Remove unused imports" into ub-contactsdialer-a-devYorke Lee
2015-09-21Remove unused importsYorke Lee
Change-Id: I1f90c31c022cb0c86d2c3e32e825744d13c5ba3c
2015-09-21Merge "Fix disabled 'Add number' button when there are no blocked numbers." ↵Anne Rong
into ub-contactsdialer-a-dev
2015-09-21Fix disabled 'Add number' button when there are no blocked numbers.Anne Rong
Bug: 24273004 Change-Id: Iab9ec3a12f9850bc100a78529b39559ed85256db
2015-09-21Fix a couple of Telecom caching bugsYorke Lee
Make sure that stuff is cached and used properly Change-Id: I57152d60077620163f4516205761c052f991f906
2015-09-21Merge "Fix for inconsistent smart dial database" into ub-contactsdialer-a-devYorke Lee
2015-09-21Merge "Wrap some privileged Telecom operations with permission checks" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-19Merge "Update time last blocked + times blocked fields on blocking a ↵Anne Rong
number." into ub-contactsdialer-a-dev
2015-09-18Update time last blocked + times blocked fields on blocking a number.Anne Rong
Bug: 24134609 Change-Id: I57db367f77a7e4e901f10ea419cc5214524b02c1
2015-09-18Merge "Fix IllegalStateException in onOptionsItemSelected" into ↵Jay Shrauner
ub-contactsdialer-a-dev
2015-09-18Merge "Record touch point when starting call from CallDetailActivity" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-18Record touch point when starting call from CallDetailActivityYorke Lee
Change-Id: Ib506072a22e9ac84ff866c0afee3fb22c8def640
2015-09-18Refactor FilteredNumberAsyncQueryHandler.isBlockedAnne Rong
Returns invalid status instead of throwing exception. Bug: 24177581 Change-Id: I6b731ab023a0cd0f50db2e3468bfccdebce6e488
2015-09-18Merge "Build management screen for managing blocked numbers." into ↵Anne Rong
ub-contactsdialer-a-dev
2015-09-17Handle wired headset during voicemail playback.Nancy Chen
- Switch to wired headset when plugged in even if playing on speaker - Remember if wired headset overrode speaker so it can be turned back on when the headset is unplugged. - Ensure proximity sensor is turned on iff the earpiece is the audio source. Bug: 23816959 Change-Id: I952c24ee51139f21a17344acd7698c9ed8f52860
2015-09-18Merge "Resume voicemail playback at previous position on resume." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-09-18Merge "Re-enable "start" button if loading voicemail fails." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-09-17Re-enable "start" button if loading voicemail fails.Nancy Chen
An enabled "start" button is a cue to the user that they can re-attempt downloading voicemail manually if the first attempt fails. Bug: 23899613 Change-Id: Ie5baf6cf45c48d0f1988d01dbed3e31919510869
2015-09-17Wrap some privileged Telecom operations with permission checksYorke Lee
If the Dialer is not the default dialer and does not have the CALL_PHONE permission, don't call TelecomManager methods that will cause SecurityExceptions. Bug: 20266292 Change-Id: I229dd045269a262632c4a911e2321203443de684
2015-09-17Resume voicemail playback at previous position on resume.Nancy Chen
Make sure that the position is saved when navigating away from the voicemail playback so that it can be restored when resuming. Also: - Disable seekbar when not loaded - Gray out seekbar handle when seek is disabled Bug: 23566924 Change-Id: Ic9d84425d7a3cde9d212bd758eb518577161d7ec
2015-09-17Merge "Fix IllegalStateException in onMenuItemClick" into ↵Jay Shrauner
ub-contactsdialer-a-dev
2015-09-17Build management screen for managing blocked numbers.Anne Rong
Currently uses a simple dialog for adding numbers. Search function to be added in separate CL. Bug: 23350280 Change-Id: Ib25b9e0d72e95853af88c446b2143341f6d077cb
2015-09-17Display duration and prepare voicemail if voicemail is downloaded.Nancy Chen
We should always know what the duration of the voicemail is even before it is downloaded. As such, when a voicemail is expanded, set the voicemail duration. For a downloaded voicemail, we can go even further and prepare the audio file when the card is expanded. This means the voicemail can be played immediately when the user clicks "play" instead of having to wait for the media player to buffer each time. Bug: 23566924 Change-Id: I0ce7570eab72b0bf079d3eb8cd10b71981576a9f
2015-09-17Fix for inconsistent smart dial databaseYorke Lee
The issue was caused by a contact's phone number being removed, but not the entire contact. Since we currently determine a list of contacts to be updated by querying for a list of all updated phone numbers, this would incorrectly exclude the aforementioned modified contact. * Use the Contact URI instead of the Phone URI when doing this query to fix the problem * Add tests for DialerDatabaseHelper update behavior * Refactor small portions of DialerDatabaseHelper to facilitate testing Bug: 24053247 Change-Id: I18a7706ebbfd39fd686dc84bdbb842cc9e9b5e20
2015-09-17Fix IllegalStateException in onMenuItemClickJay Shrauner
Make sure we're still visible before showing dialogs. Bug:24153279 Change-Id: I2eccdcd26064d73a59344107f79ee8eac1b47865
2015-09-16Fix IllegalStateException in onOptionsItemSelectedJay Shrauner
Make sure we're still visible before showing dialogs. Bug:24138858 Change-Id: I3a2cc7dba6144e055ae074177ba5c89258f69b1b
2015-09-16Merge "Call-Blocking causing crash with incoming SIP call" into ↵Anne Rong
ub-contactsdialer-a-dev
2015-09-16Call-Blocking causing crash with incoming SIP callAnne Rong
Check for SIP numbers and store them in normalizedNumber field. Bug: 24133922 Change-Id: I09541b77c5e9a8ce6fbe16564a9c5fd9a104fc35
2015-09-16Fix unused importsYorke Lee
Change-Id: Ibb8fa066e7da501a1227b413b48f0895352fb372
2015-09-16Merge "Log various call initiation entry points" into ub-contactsdialer-a-devYorke Lee
2015-09-16Log various call initiation entry pointsYorke Lee
Speed dial (PhoneNumberPickerInteraction, SpeedDialFragment) Regular search (RegularSearchFragment) Remote Directory (RegularSearchFragment) Call Log (CallLogAdapter) Smart Dial Search (SmartDialSearchFragment) Dialpad (DialpadFragment) Bug: 23164804 Change-Id: I7cc881ac655fca6d4f365b5de36a4087c4f17700
2015-09-16Merge "Update "X mins ago" on each minute change." into ub-contactsdialer-a-devSantos Cordon
2015-09-15Update "X mins ago" on each minute change.Santos Cordon
Reschedule an update when the next minute on the system clock changes. Bug: 2384475 Change-Id: Iead4ba7b0bf234f9e4c209a4e9c5b4f30efe4aa7
2015-09-16Merge "Fix VoicemailPlaybackTests." into ub-contactsdialer-a-devAndrew Lee
2015-09-15Fix VoicemailPlaybackTests.Andrew Lee
There appears to be two issues which were borking this, although I'm not sure why there was the change (maybe it's been around a long time). A single instance of presenter is retained over time, which is no good for our case where we're creating different FakeAsyncTaskExecutors each time, so added a method for testing where we can clear the instance. Secondly, the method checking the text views didn't work anymore. Not sure why, but I added a hook into the state text so the tests can continue to check for that. Bug: 23640774 Change-Id: Ie729627f3bb4ee08476d5ad0198e43cfea72ce5c
2015-09-15Handle null contact lookup.Andrew Lee
If we have a null contact lookup, replace the local reference with an EMPTY contact info instance. This fixes a test failure, and possible lookup scenario. Bug: 23640774 Change-Id: Ic83f1e73bfbb3b4e3920051f906a3d83524fc8cd
2015-09-15Merge "Refactor all voicemail audio handling to new audio manager class." ↵Nancy Chen
into ub-contactsdialer-a-dev
2015-09-15Merge "Refactor IntentUtil.getCallIntent variants to use builder" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-14Refactor IntentUtil.getCallIntent variants to use builderYorke Lee
Use the builder pattern to create a Call intent to replace the numerous variants of getCallIntent. This will facilitate the addition of future extras to the created call intent. Bug: 23164804 Change-Id: Ibab8473274de8e423f621ae6fbb9685eeb2a7cab
2015-09-15Merge "Translate FAB up and down when Snackbar appears and disappears." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-09-14Refactor all voicemail audio handling to new audio manager class.Nancy Chen
Since voicemail audio handling is about to get more complicated (adding head phone switching and bluetooth), we need a separate class to handle audio. Bug: 23816959 Change-Id: If891739ef80f5646145d7a44ec70f5b7544010b0
2015-09-14Fix IllegalStateException in showDiambigDialogueJay Shrauner
Check to make sure the activity is still running before showing the disambiguation dialogue Bug:24064251 Change-Id: Icf48434164e2aa9e5d89b71f637456f0f6c2b1b4
2015-09-14Merge "Improve speakerphone setting." into ub-contactsdialer-a-devAndrew Lee
2015-09-14Merge "Remove EXTRA_CALL_ORIGIN from Dialer" into ub-contactsdialer-a-devYorke Lee
2015-09-14Merge "Remove unused countryIso in ListsFragment" into ub-contactsdialer-a-devYorke Lee
2015-09-11Remove EXTRA_CALL_ORIGIN from DialerYorke Lee
This is legacy code from the PhoneApp days and no longer does anything. The method signatures in IntentUtils were kept unchanged to reduce code churn since they will be modified in a later CL. Change-Id: I76bcdd9b1302eed701e3d1cb5027a937ab2234c4
2015-09-11Translate FAB up and down when Snackbar appears and disappears.Nancy Chen
This is implements custom behavior according the Material Design spec that the Snackbar cannot obscure the FAB. Converts the dialtacts activity layout to a CoordinatorLayout and attaches the FloatingActionButtonBehavior to the FAB. Bug: 23687913 Change-Id: Ic4d0493db415bb97cf7e21de4f23a02df9f753b1
2015-09-10Improve jump to tab via intent logicYorke Lee
Respect the EXTRA_CALL_FILTER_TYPE extra if provided in an intent extra Fix bug where trying to jump to the voicemail tab for the first time before active voicemail sources were detected would not work. Bug: 23947505 Bug: 23388120 Change-Id: Ib4fcaf486ae01d023f21fd2fc3bfc78f1a0cf609
2015-09-10Improve speakerphone setting.Andrew Lee
+ Persist speakerphone setting across resume/pause. + Allow toggling speakerphone before voicemail is played or while loading. Bug: 23566924 Bug: 23716100 Change-Id: Icc7342be85bd6df0f4678134b222f2200d3fc56d
2015-09-10Remove unused countryIso in ListsFragmentYorke Lee
Change-Id: Ia6554810f614e76d83a666ac3a4ceec01bd74aab
2015-09-10Merge "Add stub implementations for logging changes" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-10Merge "Revert "Improve speakerphone setting."" into ub-contactsdialer-a-devChad Jones
2015-09-10Revert "Improve speakerphone setting."Chad Jones
This reverts commit 499902cca2562db728671a74044ffc2f70a7c39d. Change-Id: I9f6321f0d745aadd47085dde09db8dfc8d21af19
2015-09-10Merge "Improve speakerphone setting." into ub-contactsdialer-a-devAndrew Lee
2015-09-09Merge "Fuzzy match phone number for contact lookup." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-09-09Fuzzy match phone number for contact lookup.Andrew Lee
In some countries, it appears that the country code received is not always accurate to what we would expect (carrier kerfluffery?), so don't do a lookup with the normalized phone number. This is consistent with the logic we have been using for InCallUi. Bug: 23822088 Change-Id: I2c7ede596cbb8a2e5c4a3a35d04ca78e62767bcc
2015-09-09Improve speakerphone setting.Andrew Lee
+ Persist speakerphone setting across resume/pause. + Allow toggling speakerphone before voicemail is played or while loading. Bug: 23566924 Bug: 23716100 Change-Id: I5120e70ab7174608086d3cc643c09c2fd9a1f726
2015-09-09Add stub implementations for logging changesYorke Lee
Add abstract Logger class that serves as a contract for actual logging implementations. Bug: 23164804 Change-Id: Idaedae9b03aa60bbee21574584b47e3529ee9cad
2015-09-04Merge "Send notification when permission granted in search" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-04Merge "Genericize promo card." into ub-contactsdialer-a-devAndrew Lee
2015-09-03Merge "Display unread count for voicemail and update when vm is read." into ↵Nancy Chen
ub-contactsdialer-a-dev
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-12 03:51:20 +0000