summaryrefslogtreecommitdiff
path: root/src/com
AgeCommit message (Collapse)Author
2015-10-20Add import fragment, rearrange fragments.Andrew Lee
+ Add a fragment (and adapter) for displaying numbers from contacts marked as send to voicemail. This fragment has import functionality. + Refactor logic around the Blocked Numbers activity; relocate a lot of the fragment-specific logic, particularly around actionbars, to within the fragments themselves. + Simplify fragment management logic by using replace instead of show/hide. Bug: 23351616 Change-Id: I5c1076d6d001a8401234f57c27ada4bcd90e6c27
2015-10-20Fix broken reference.Andrew Lee
Bug: 24134270 Change-Id: I62c32b6cacdc931e7c99dca68b73aa6bf678b497
2015-10-20Add null check for cursor.Andrew Lee
Bug: 24134270 Change-Id: I5d28c633abee226f7bc2d63ec80340cd6deb9c79
2015-10-21Merge "Hide the hide blocked call settings if no VVM." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-21Merge "Delete voicemails from blocked users." into ub-contactsdialer-a-devAndrew Lee
2015-10-20Delete voicemails from blocked users.Andrew Lee
+ Delete voicemail when the notification is received if the number is blocked and the "hide" setting is set to true. + Changed utility to take time into account; only block voicemail notifications and delete voicemails if the voicemails are from after the time when the number was blocked. Bug: 24134270 Change-Id: I2f3b24d6291a6cec4a7d8530b00dd5a4656ab024
2015-10-20Merge "Set snackbar action text to blue." into ub-contactsdialer-a-devAndrew Lee
2015-10-20Hide the hide blocked call settings if no VVM.Andrew Lee
We can only honor deleting voicemail for VVM users. Bug:24134270 Change-Id: I2b4ea6856ab4bc79ad93ac111bc78bc7f8b4833e
2015-10-20Merge "Add setting for hiding blocked calls." into ub-contactsdialer-a-devAndrew Lee
2015-10-20Add setting for hiding blocked calls.Andrew Lee
+ Add settings switch to blocked number settings. + Add utility for checking/setting whether calls should be blocked. + Filter out blocked calls in call log query, if appropriate. + Refresh call log fragment after a change in setting. Followup work: delete voicemails for calls by blocked numbers after the time when the user blocked them. Bug: 24134270 Change-Id: I85088697559ef6fb446b82617f14f1c6fa893df1
2015-10-20Merge "Show unblock icon for blocked numbers." into ub-contactsdialer-a-devAndrew Lee
2015-10-19Show unblock icon for blocked numbers.Andrew Lee
Bug: 25095683 Change-Id: I244ec8312ad24081fd36967e063ddccd53b0253c
2015-10-20Merge "Remove unnecessary log statement" into ub-contactsdialer-a-devYorke Lee
2015-10-20Merge "Create superclass for BlockedNumberAdapter." into ub-contactsdialer-a-devAndrew Lee
2015-10-19Create superclass for BlockedNumberAdapter.Andrew Lee
To facilitate reusings the same views and adapter for both the manage blocked numbers list and the import list. The two will use different cursors because they are pulling data from different places (Contacts db vs FilteredNumbers db), and it seemed better to reuse code rather than creating parallel implementations. Bug: 23351616 Change-Id: I5cac5f2a6b8b3bf4a6e8f54c8bc3f1c1500ac5e7
2015-10-19Remove unnecessary log statementYorke Lee
Bug: 25090920 Change-Id: I367e2109acf4f60cedc84bb7c2cd4b472be04f77
2015-10-19Disable VM notification for blocked numbers.Andrew Lee
+ Added a utility to do a synchronous lookup for whether a number is blocked, but it should not be used normally from the UI thread. + Change voicemail notifier code to obtain countryIso, and pass back list of calls to notify as list (to make it easier to remove elements). Bug: 23944007 Change-Id: Iad1f8ee200b8f8734be3db0504482fcdee61e412
2015-10-19Don't allow blocking of emergency or VM numbers.Andrew Lee
Bug: 24680730 Bug: 24303461 Change-Id: Ibd7d431355ca97eb2ae7f29537809987a8d5f96d
2015-10-19Set snackbar action text to blue.Andrew Lee
Done for both snackbars in call blocking/unblocking and voicemail deletion. Bug: 24370325 Change-Id: I00fdebb635e60ac1d421ccf7f15df46693773870
2015-10-19Merge "Fix up blocked photo scenarios." into ub-contactsdialer-a-devAndrew Lee
2015-10-16Add import for SEND_TO_VOICEMAIL.Andrew Lee
+ Add utility class for async import functions. + Move check for contacts with SEND_TO_VOICEMAIl to util. + Add function for adding phone numbers of contacts with SEND_TO_VOICEMAIL to the block list, then clearing the SEND_TO_VOICEMAIL flag. + Fixed bug where the import text would not be shown for an empty block list. Rearranged layouts slightly to facilitate this. + Protect against null listeners in FilteredNumberAsyncQueryHandler. Bug: 23351616 Change-Id: Id526e16f20a3d28966bbc5e458cecfcd03ecb20f
2015-10-16Fix up blocked photo scenarios.Andrew Lee
+ Show blocked drawable in CallDetailActivity. Rearrange logic in the activity to facilitate updating the contact photo and block item action in accordance to blocked state. + Fix bug in FilterNumberDialogFragment where callback was not always invoked because of final/scope issues where it was possible for the callback to be unintentionally null and not invoked. + Clear blocked id cache when pausing the call log adapter, so that after changing the blocked state in the call detail activity the changes will be reflected in the call log. Bug: 24871853 Change-Id: I1d58b1e0c222ead90fa7b6c30a95bc3254a14776
2015-10-15Polish call blocking rotation/undo behaviors.Andrew Lee
+ Correctly dismiss filtered number dialog on rotate. + Polish listener interface, and extend across all block/unblock and undo scenarios. + Update UI across all blocking scenarios (call log, call detail, settings, blocked number list, blocked number search); + Conslidate creation of FilterNumberDialogFragment in a single static method. The listener interface is not ideal, because it does not maintain state well across rotation and multiple instances. This option was selected, however, because of the number of scenarios in which the dialog is invoked and various circumstances (in a RecyclerView list item, in a fragment, in an activity). This range of scenarios makes it convoluted to implement a uniform mechanism in any other way, so the approach opted for is to set a listener, and dismiss the dialog on rotation.. Bug: 24638328 Bug: 24109819 Bug: 24871853 Change-Id: I2332edda2cae0341af3e80b13aa96af6068f75ac
2015-10-15Merge "Reset view state to unmarked when binding." into ub-contactsdialer-a-devAndrew Lee
2015-10-15Merge "DO NOT MERGE Correct issue where content of "All" and "Missed" tabs ↵Tyler Gunn
reversed in RTL." into ub-contactsdialer-a-dev
2015-10-14Merge "Moving call type/location for voicemail" into ub-contactsdialer-a-devBrandon Maxwell
2015-10-14Moving call type/location for voicemailBrandon Maxwell
Combination of two related bugs. 22168682: In the voicemail call log, moved call type/location to below the call action button and removed the call details button as it didn't have any additional information. 22514722: Modified spacing and text sizes for call log. Moved voicemail transcription below call date as in mocks. Bug:22168682,22514722 Change-Id: I557761b815604fee4e6b61f4670608b8fa90d3a7
2015-10-14Merge "Correctly set query string for new SmartDialSearchFragment instance" ↵Yorke Lee
into ub-contactsdialer-a-dev
2015-10-14Correctly set query string for new SmartDialSearchFragment instanceYorke Lee
If DialtactsActivity is created for the first time by launching a DIAL intent, the SmartDialSearchFragment is not correctly populated with the correct number for the "Create new contact" and "Add to contact" shortcuts since it is not attached yet when the callback is fired. Fix this by persisting the number and setting it on the fragment when it is attached. Bug: 24358325 Change-Id: I24d4603376e739a7c9368a9b115109ba23753585
2015-10-13DO NOT MERGE Correct issue where content of "All" and "Missed" tabs reversed ↵Tyler Gunn
in RTL. Root cause of issue was that the tab indexes were not reversed in RTL mode. Made a similar change as was made in ListsFragment. Bug: 24690256 Change-Id: Ifa7ae1127298aa098dd8201b4d1e095baa3c14e8
2015-10-13Reset view state to unmarked when binding.Andrew Lee
Some numbers had been showing up marked as blocked, even though they were not blocked, because the adapter list items were not updated properly. Bug: 24910704 Change-Id: Id3aead5212f4e51d02ec5c6be6c77962546722e0
2015-10-13Add missing import to fix build breakYorke Lee
Change-Id: Iabbc27e509fe8abfdb769c2932a1a025287bdc88
2015-10-13Merge "Move capability checker out of RegularSearchFragment" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-10-13Merge "Implement behavior for import settings visibility." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-12Implement behavior for import settings visibility.Andrew Lee
Check to see if there are any contacts being sent to voicemail. If true, show the import settings in the BlockedNumberFragment, otherwise hide those settings. Bug: 23351616 Change-Id: I370d80508571ac654d8c10afab332b552f8dd99e
2015-10-12Fix NPE in requestContentJay Shrauner
Check for null context in resumePlayback. Bug:24858686 Change-Id: I7c65e3ae836535f15936ecb397a68ee6590f31ed
2015-10-12Move capability checker out of RegularSearchFragmentYorke Lee
AOSP Dialer does not care about having location enabled, so move the relevant code out into a separate fragment Bug: 24172011 Change-Id: I7c29ba4ed8e3fb0a600360c10e9c9fdd6d543b1f
2015-10-12Merge "Show icons for call detail actions." into ub-contactsdialer-a-devAndrew Lee
2015-10-12Merge "Fix crash in BlockedNumberSearchActivity" into ub-contactsdialer-a-devYorke Lee
2015-10-12Show icons for call detail actions.Andrew Lee
- Remove LinearLayouts and use drawableLeft instead. + Up block asset from 18dp to 24dp. Bug: 24109819 Change-Id: I941520f1b90e6f819c7f94269e395d26c56f5734
2015-10-12Merge "Add footer actions to Call Details." into ub-contactsdialer-a-devAndrew Lee
2015-10-12Merge "Combine blocked number fragments into Activity." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-12Merge "Show blocked contact instead of profile photo." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-09Fix crash in BlockedNumberSearchActivityYorke Lee
Don't require RegularSearchFragment's parent activity to implement CapabilityChecker interface. In the context of the BlockedNumberSearchActivity this functionality is not needed. Bug: 24804134 Change-Id: I848ae66c6f8afc6e60b19bc28e933ae1e2f59893
2015-10-08Don't assign invalid resource to imageViewYorke Lee
Bug: 24756948 Change-Id: Ifc05733528c473ec84f177e2c5d845ac534b26dc
2015-10-07Combine blocked number fragments into Activity.Andrew Lee
Mocks indicate that after adding, the user should be returned to the management UI and the snackbar should be shown there. This is kind of pain to do across fragments in different activities. To help address this, make one Activity the parent of both the blocked number manage and add/search UI. This also makes sense in terms of logical organization. Bug: 24134038 Change-Id: I682342a73c964a5d4eb90469f10d6584b85400f1
2015-10-07Add footer actions to Call Details.Andrew Lee
Some of these are moved down from the overflow. Others are added from the list of those shown after a call log list item long press. This hooks up the block/unblock functionality, although there is still polish (eg. icons) and cleanup (some noted as TODOs), to complete still. Bug: 24109819 Change-Id: I129f5b09ac1c5edb66ab5bd91a46b18961240fb5
2015-10-07Show blocked contact instead of profile photo.Andrew Lee
Does not yet update on change; figuring to do that in a followup CL because there are a number of other scenarios where that needs to be fixed too. Bug: 23943480 Change-Id: I73615c405d547e74667f6c635b5623708c723347
2015-10-07Merge "Consolidate setPhoto logic." into ub-contactsdialer-a-devAndrew Lee
2015-10-07Consolidate setPhoto logic.Andrew Lee
This makes the ViewHolder self-capable of updating/setting its photo, so if we want to update the photo in the future (either in teh scope of a listener, or in the ViewHolder itself), we don't need to worry about configuring and passing around a bunch of commands. Bug: 23943480 Change-Id: I17653014dd81fcb9ae7a667539e40a9310a72d36
2015-10-07Merge "Group blocked calls separately in call log." into ub-contactsdialer-a-devAndrew Lee
2015-10-06Show prompt to request for location permissionYorke Lee
Clicking on TURN ON currently only asks for the location permission. Showing the dialog that toggles location sources is planned for a follow up CL. Bug: 24172011 Change-Id: Ieb6bd58a60aacbda76f9c754efeebfdd9e89aa86
2015-10-06Merge "Don't set FilteredNumberAsyncQueryHandler." into ub-contactsdialer-a-devAndrew Lee
2015-10-06Merge "Convert caller information into list header." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-06Convert caller information into list header.Andrew Lee
this allows us to scroll the header with the rest of the screen, instead of having it pinned to the top, as it is currently. Bug: 24109819 Change-Id: Ic440bc18d31d196493a86130e06d954c453c9146
2015-10-06Merge "Show blocked icon in call log." into ub-contactsdialer-a-devAndrew Lee
2015-10-06Actually launch onboarding flow if neededYorke Lee
Launch OnboardingActivity for exported activities (DialtactsActivity, CallDetailsActivity) to ensure that a) We prompt the user to make us the default dialer at least once b) The user has granted us both the Phone and Contacts permissions Bug: 24270592 Change-Id: I232314e42f5331a72c1a84be917d9d74c5813976
2015-10-06Show blocked icon in call log.Andrew Lee
For calls of type BLOCKED, show the blocked call icon. Bug: 23943480 Change-Id: Ic1477090c31d51322dbe04dac29f1ca3b0dae4d1
2015-10-05Dismiss filter dialog on rotation.Andrew Lee
This simplifies addressing a number of rotation cases by eliminating them completely. Otherwise, we need to worry about updating references, such as having the right fragment or activity reference to be able to provide the correct parent view for the snackbar. This is particularly complicated in some cases in Dialer because we have a fragment => adapter => viewholder hierarchy to pass through. Bug: 24638328 Change-Id: Ic8a5d2c3ca35742f5bb0986d77ae3b8d5f44e4dd
2015-10-03Don't set FilteredNumberAsyncQueryHandler.Andrew Lee
Rather than creating single instances and setting them or passing them around, create them when we need them. This won't happen too often so instantiating the objects shouldn't be too much of a burden on the system. Instances of AsyncQueryHandler all end up running tasks off the same thread, so there should not be a negative consequence of spinning off more threads. Bug: 24638328 Change-Id: If53ce4f1fd83736c330c1ff02946ed45da575796
2015-10-03Group blocked calls separately in call log.Andrew Lee
+ Group blocked calls separately from other call types, but group adjacent blocked calls together. + Add unit tests. Bug: 23943480 Change-Id: Iffe6fac800007f6b88e0feb15d91c63515e496f8
2015-10-02Prepatory CallDetailActivity tweaks.Andrew Lee
Incremental CL in changing actions/layout of CallDetailActivity to move actions such as Block/Edit/Copy out of the overflow menu. + Make header at top of Call Detail Activity smaller. + Move delete options into actionbar button. - Delete call list header in CallDetailActivity. Bug: 24109819 Change-Id: If75f016e14de9e2c5ac8629c4bfa38e2380ce48b
2015-10-02Merge "Revert "Prepatory CallDetailActivity tweaks."" into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-02Revert "Prepatory CallDetailActivity tweaks."Andrew Lee
This reverts commit 11a7350843ec13c7ca4d27523e9ba146911d2767. Change-Id: Idf62da51c934ee598c1bbc1b5052e6cea2929feb
2015-10-02Merge "Add blocked number indicator to search screen for adding a blocked ↵Anne Rong
number." into ub-contactsdialer-a-dev
2015-10-02Merge "Modifying voicemail call log date and time format" into ↵Brandon Maxwell
ub-contactsdialer-a-dev
2015-10-02Add blocked number indicator to search screen for adding a blocked number.Anne Rong
Bug: 24468656 Change-Id: I31091e2dde07dabc432247fd4e409907fada152b
2015-10-02Merge "Prepatory CallDetailActivity tweaks." into ub-contactsdialer-a-devAndrew Lee
2015-10-02Prepatory CallDetailActivity tweaks.Andrew Lee
Incremental CL in changing actions/layout of CallDetailActivity to move actions such as Block/Edit/Copy out of the overflow menu. + Make header at top of Call Detail Activity smaller. + Move delete options into actionbar button. - Delete call list header in CallDetailActivity. Bug: 24109819 Change-Id: I1a5fedc54d1bb725597a07f4cfd8d7f6e8627a32
2015-10-02Merge "Add BLOCKED call type and util to mark in call log." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-02Add BLOCKED call type and util to mark in call log.Andrew Lee
To support call blocking, added BLOCKED call type. Also added utility to be able to mark the most recent call from a number as BLOCKEd in the call log database. Added REJECTED call type as well. This is not presently used within our application, but we want to reserve the integer, anticipating changes in the framework to add this constant. Introduced AppCompConstants, because BLOCKED and REJECTED call type values will not be defined as part of the API on M devices. Change existing call type constants to reference this compatability class. Bug: 24341350 Change-Id: I523ebd8dd1844a3b71a69a14bd38073be5940804
2015-10-02Modifying voicemail call log date and time formatBrandon Maxwell
Bug: 22168682 Change-Id: Id0135ca03310f6c1587151af81c29b22e9d20d2b
2015-10-02Merge "First pass for Dialer onboarding flow" into ub-contactsdialer-a-devYorke Lee
2015-10-02First pass for Dialer onboarding flowYorke Lee
* Add OnboardingActivity that controls the onboarding the UI ensuring that the user grants the necessary permissions before the Dialer can start. * Add first pass (no graphics, eyeballed measurements) for the screens that request for default dialer as well as permissions * OnboardingActivity is not actually launched at this moment - will be tied in to the various Dialer activities in a follow up CL. * Add tests for logic that controls the display of the screens in anticipation of future additions to the onboarding flow. * Add mockito library to DialerTests's Android.mk Bug: 24270592 Change-Id: I00d0f75edaecaa85042b136b0d830b5fbb3a0a73
2015-09-29Rename OnPhoneNumberPickerActionListener methodsAnne Rong
Bug: 24506966 Change-Id: Ibc1d334fc18235c3d5971364d7024db61c590c46
2015-09-29Add search for adding blocked numbers to the blocked number management screen.Anne Rong
Bug: 24134038 Change-Id: I30b283a6b67d7e64b58138762079c4bceb8fc64f
2015-09-25Merge "Show ImportExportDialogFragment based on tabs" into ↵Wenyi Wang
ub-contactsdialer-a-dev
2015-09-25Show ImportExportDialogFragment based on tabsWenyi Wang
Bug: 19850584 Change-Id: Ic2faade79bebfc352c3f492c4cb7679090022e63
2015-09-25Use TransactionSafeActivityJay Shrauner
Remove custom visibility tracking. Bug:24294419 Change-Id: I2ef53549e7d8c07e92319bc57c4aebd05edb8ea6
2015-09-24Fix IllegalStateException in onOptionsItemSelectedJay Shrauner
Check to make sure the activity is still visible before doing anything. Bug:24373052 Change-Id: I35a05227f02c117b29b5a29af9dfc54c00ba3616
2015-09-24Merge "Protect against more Telecom privileged operations" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-22Merge "Use displayNumber instead of info.formattedNumber for blocked number ↵Anne Rong
messages." into ub-contactsdialer-a-dev
2015-09-22Use displayNumber instead of info.formattedNumber for blocked number messages.Anne Rong
Bug: 24275589 Change-Id: I3810a04da0c7f48fc875c3456ddb36e3761530c0
2015-09-22Merge "Fix snackbar using out of scope View in blocked numbers list." into ↵Anne Rong
ub-contactsdialer-a-dev
2015-09-22Protect against more Telecom privileged operationsYorke Lee
Make sure that all invocations of TelecomManager methods that could possibly require a permission are protected by a permission check. Some of these are overcautious - for example, the UI should never show the option to return to a call (READ_PHONE_STATE) if we didn't detect an active call (READ_PHONE_STATE) in the first place, so it is not strictly necessary to protect against the former. But not crashing is the most preferable of all options. Bug: 20266292 Change-Id: Id91dd16e34320a5e607f91dbce9a4296025eeaaf
2015-09-21Fix snackbar using out of scope View in blocked numbers list.Anne Rong
Bug: 24272126, 24273593 Change-Id: I79f3ffbc745a914a11f9a61e5f06bb87be9d54de
2015-09-22Merge "Remove unused imports" into ub-contactsdialer-a-devYorke Lee
2015-09-21Remove unused importsYorke Lee
Change-Id: I1f90c31c022cb0c86d2c3e32e825744d13c5ba3c
2015-09-21Merge "Fix disabled 'Add number' button when there are no blocked numbers." ↵Anne Rong
into ub-contactsdialer-a-dev
2015-09-21Fix disabled 'Add number' button when there are no blocked numbers.Anne Rong
Bug: 24273004 Change-Id: Iab9ec3a12f9850bc100a78529b39559ed85256db
2015-09-21Fix a couple of Telecom caching bugsYorke Lee
Make sure that stuff is cached and used properly Change-Id: I57152d60077620163f4516205761c052f991f906
2015-09-21Merge "Fix for inconsistent smart dial database" into ub-contactsdialer-a-devYorke Lee
2015-09-21Merge "Wrap some privileged Telecom operations with permission checks" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-19Merge "Update time last blocked + times blocked fields on blocking a ↵Anne Rong
number." into ub-contactsdialer-a-dev
2015-09-18Update time last blocked + times blocked fields on blocking a number.Anne Rong
Bug: 24134609 Change-Id: I57db367f77a7e4e901f10ea419cc5214524b02c1
2015-09-18Merge "Fix IllegalStateException in onOptionsItemSelected" into ↵Jay Shrauner
ub-contactsdialer-a-dev
2015-09-18Merge "Record touch point when starting call from CallDetailActivity" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-18Record touch point when starting call from CallDetailActivityYorke Lee
Change-Id: Ib506072a22e9ac84ff866c0afee3fb22c8def640
2015-09-18Refactor FilteredNumberAsyncQueryHandler.isBlockedAnne Rong
Returns invalid status instead of throwing exception. Bug: 24177581 Change-Id: I6b731ab023a0cd0f50db2e3468bfccdebce6e488
2015-09-18Merge "Build management screen for managing blocked numbers." into ↵Anne Rong
ub-contactsdialer-a-dev
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-17 19:01:46 +0000