summaryrefslogtreecommitdiff
path: root/src/com
AgeCommit message (Collapse)Author
2015-10-20Fix NPE in requestContentJay Shrauner
Check for null context in resumePlayback. Bug:24858686 Change-Id: I7c65e3ae836535f15936ecb397a68ee6590f31ed
2015-10-12Correct issue where content of "All" and "Missed" tabs reversed in RTL.Tyler Gunn
Root cause of issue was that the tab indexes were not reversed in RTL mode. Made a similar change as was made in ListsFragment. Bug: 24690256 Change-Id: Ifa7ae1127298aa098dd8201b4d1e095baa3c14e8
2015-10-12DO NOT MERGE Handle null contact lookup.Andrew Lee
If we have a null contact lookup, replace the local reference with an EMPTY contact info instance. This fixes a test failure, and possible lookup scenario. Already submitted to master, do not merge. Bug: 24134231 Change-Id: Ia6edd9f601de391257fb805910ef0e42e060c667
2015-08-26Use View.performHapticFeedback for haptic vibrationYorke Lee
This ensures that haptic feedback always behaves similarly to other system widgets regardless of device. Bug: 23523043 Change-Id: Ic1cac22ef87dcaf92a1ac8e11f82956f90e99f99
2015-08-21am 9d1d797b: Prevent NPE in VoicemailPlaybackPresenter.Andrew Lee
* commit '9d1d797be52a41ed9a83790d231fa2e659666aa1': Prevent NPE in VoicemailPlaybackPresenter.
2015-08-21Prevent NPE in VoicemailPlaybackPresenter.Andrew Lee
Bug: 23386856 Change-Id: Ib87184199e8578a1fe3b0a6457b26069673f56ca
2015-08-13am 6b9d9a0b: Use correct "Can write to settings" check in ↵Yorke Lee
DefaultRingtonePreference * commit '6b9d9a0b7f7e9e2e5e4d7c03a63581bff84346a6': Use correct "Can write to settings" check in DefaultRingtonePreference
2015-08-13Use correct "Can write to settings" check in DefaultRingtonePreferenceYorke Lee
Bug: 23187565 Change-Id: I3a511e41ce9cb1e1c67dd2638e1f601e8ccebb9f
2015-08-07am 26b9e56b: Correctly check for ability to write to system settingsYorke Lee
* commit '26b9e56b19472a2608e3f3feefd647ca63306e33': Correctly check for ability to write to system settings
2015-08-06Correctly check for ability to write to system settingsYorke Lee
Use Settings.System.canWrite instead of direct check of AppOp using AppOpsManager Bug: 22987149 Change-Id: I2484d531cce988af6e054d4c900efa277f7e622f
2015-08-05Add "Call with Note" from dialpad.Tyler Gunn
Bug: 22685114 Change-Id: Id7d16634a0baad03b28b509b62315f43fa022ee4
2015-08-05Add "Call with a note" action.Tyler Gunn
- Adding call with a note action to the call log. Capability lookup is cached. - Moved getLookupKeyFromUri to ContactsCommon. - Added some extra required values in CallLogListItemViewHolder so that the call subject dialog is able to build the correct contact photo. Bug: 22685114 Change-Id: I6665c55137eef7db3ff7ac12d70d823937e8c28b
2015-07-29Merge "Use ACTION_SENDTO for send sms intent" into mnc-devYorke Lee
2015-07-28Use ACTION_SENDTO for send sms intentYorke Lee
This ensures the default SMS app is correctly launched. Bug: 22776119 Change-Id: I83610a49d435ba3917225621430b7c8015407f5a
2015-07-29Merge "Don't update call log in CallerInfoQueryThread without permission" ↵Yorke Lee
into mnc-dev
2015-07-28Don't update call log in CallerInfoQueryThread without permissionYorke Lee
Bug: 22801077 Change-Id: I16c9c574597564c9f84bbcc00211e097538529de
2015-07-28Start contact info cache query thread in onResumeYorke Lee
Bug: 22783484 Change-Id: If7881ad6a18eafe0b2ea8411b8472ba444320991
2015-07-28Merge "Fix bug in FAB action" into mnc-devYorke Lee
2015-07-27Fix bug in FAB actionYorke Lee
If in contact search, always show the dialpad if the FAB is clicked. Bug: 22751856 Change-Id: I069064489664a1f9c3749b34e8b333f878bbf04b
2015-07-27Remove onPreDrawListener logicYorke Lee
A bug in the PreDrawListener code was causing it to not be removed from the ViewTreeObserver. This means that everytime a view was rebound, another onPreDraw listener callback would be added but never removed. Compounding the problem is that in each callback, a costly permission check via IPC is done, causing each frame to slow down increasingly as more views are bound. In practice, these PreDrawListeners are no longer needed as they were only used to prime the Contact info query thread, which happens via other code paths anyway. Bug: 22759147 Change-Id: Ica2a31c0849c2eb34ac6f77d49cf23cbe32c6941
2015-07-25Merge "Protect against lack of WRITE_SYSTEM_SETTINGS AppOp" into mnc-devYorke Lee
2015-07-24Merge "Set correct view to display playback error text" into mnc-devYorke Lee
2015-07-24Protect against lack of WRITE_SYSTEM_SETTINGS AppOpYorke Lee
Guard the following entry points with checks against the AppOp 1) Launch of SoundSettingsFragment Fallback: Send to system sound settings instead 2) onResume of SoundSettingsFragment (this can happen if the AppOp is toggled by the user in the background) Fallback: Return to main Dialer settings instead 3) Toggling of various perferences (this can happen in monkey tests) Fallback: Show toast, ignore settings chance Bug: 22660372 Change-Id: Ief5d74166d35a9718ea664f378f6930e777f2923
2015-07-22Set correct view to display playback error textYorke Lee
Bug: 22642715 Change-Id: I01c8c8a7ec3dfa132c0aad37fe847fd58daae516
2015-07-21Merge "Reset voicemail playback when call log is paused." into mnc-devNancy Chen
2015-07-21Merge "Make permission request view intercept clicks" into mnc-devYorke Lee
2015-07-21Make permission request view intercept clicksYorke Lee
Bug: 22631821 Change-Id: I3f2ef3f0e1d16ec406e1bed7f6b4c980e17b058f
2015-07-20Don't auto expand next voicemail after deletingYorke Lee
Pipe onVoicemailDeleted notification through to CallLogAdapter. Reset expanded position when that happens. Bug: 22534894 Change-Id: Iec69082bd8b3259f500b523da6d0710bece69fa4
2015-07-17Reset voicemail playback when call log is paused.Nancy Chen
If the user navigates away from the call log, reset the currently playing voicemail playback. Which includes resetting the start point, pausing playback, and refreshing the play icon. Bug: 22530093 Change-Id: I78eda2d86cf0f5b24136a7a9ba299214f155672b
2015-07-17Refresh all contacts fragment when permission grantedYorke Lee
Bug: 22174668 Change-Id: I6d23fb76c6b67093ee1193fba45bd20baa50a68f
2015-07-17Merge "Add permission prompts for contacts and dialpad search" into mnc-devYorke Lee
2015-07-17Add permission prompts for contacts and dialpad searchYorke Lee
Update the following fragments to handle denied permissions -Contacts Search (Contacts and Location) -Dialpad Search (Phone) Tweak and remove some of the onTouch listener logic as they are no longer valid with the new UI. Instead of intercepting the touches when the query is empty and returning to the main dialer activity, allow the fragments to remain on screen if the permission request UI is showing. Modify signature of onEmptyViewActionButtonClicked to remove unused permissions parameter. Bug: 22174668 Change-Id: I96d00f2ab45df936dca602ac025f723638ac02c4
2015-07-16Catch CP2 exception in DefaultVoicemailNotifierYorke Lee
Bug: 22531073 Change-Id: I09f0b6d94de89ac9236308cec07b12fb8131bc19
2015-07-16Merge "Update Dialer permissions UI per mocks" into mnc-devYorke Lee
2015-07-15Update Dialer permissions UI per mocksYorke Lee
Bug: 22174668 Change-Id: If6757ff66c411228cfa22d70caaf6cc532fd2b31
2015-07-15Merge "Pause playback when voicemail is deleted." into mnc-devNancy Chen
2015-07-15Pause playback when voicemail is deleted.Nancy Chen
We don't want the voicemail to continue playing after deleted, so perform the pause behavior when the delete button is pressed. Bug: 22462516 Change-Id: I664c5aed0c2bd1910cdf1f20a33c0117dde8d0cc
2015-07-15Update Dialer UI to prompt for permissionsYorke Lee
First pass at adding functionality to Dialer to prompt for permissions. Also updates the UI for various fragments when there are no contacts/calls available to unify the UI with the new UI for the permissions denied state. * Refactor existing empty view functionality and encapsulate into a new custom view class * Add action buttons to existing empty views in various fragments -> Speed Dial (Add to favorites) - scrolls to all contacts fragment -> Recents (Make a call) - shows dialpad -> All contacts (Add a contact) - Launches add contact dialog * Add functionality to various fragments to detect if permissions are denied, and request the permission when the action button is pressed. -> Speed Dial (request for contacts permission) -> Call Log (request for phone permission) -> All contacts (request for contacts permission) * Remove now unneeded EmptyContactsListAdapter Remaining issues (to be addressed in a follow up CL to avoid bloating this CL): UI alignment tweaks for empty view to match mocks If the read contacts permission is requested from the speed dial screen, the all contacts fragment doesn't update with the list of contacts until restarted. Bug: 22174668 Change-Id: I70721914bb9b32910d746de288ccac049749e42e
2015-07-14Permission protect UndemoteOutgoingCallReceiverYorke Lee
Bug: 22479151 Change-Id: I7e2689cfd3b6a315e7a225d2a8646b5917f70570
2015-07-14Merge "Don't cache results of permission check" into mnc-devYorke Lee
2015-07-13Merge "Fix a bug in the dtmf tone length setting." into mnc-devRoshan Pius
2015-07-13Fix a bug in the dtmf tone length setting.Roshan Pius
Had an error in the preference setting string name. BUG: 22452758 Change-Id: Ia9b55cb0a41382e4307cff6f5a8b97d9de2ac883
2015-07-13Don't cache results of permission checkYorke Lee
For maximum safety, always check the current permission status on the fly. Bug: 22455059 Change-Id: I05da7ec1ad2e885e3e5e78e14585c876ac19178e
2015-07-13Fix SecurityException in DefaultVoicemailNotifierYorke Lee
Protect querying of ContentResolvers with the relevant permission checks. Check the correct permission in onHandleIntent of CallLogNotificationsService. Bug: 22436465 Change-Id: I7fed82545b10921c1a935f903a466d8894d7b7f1
2015-07-09Merge "Update call shortcuts even if contacts permission denied" into mnc-devYorke Lee
2015-07-08Update call shortcuts even if contacts permission deniedYorke Lee
Bug: 22232717 Change-Id: I3c32a6ca55a8e0f904c2147e2c2df05327dbe9ed
2015-07-08Merge "Fix some voicemail playback bugs" into mnc-devYorke Lee
2015-07-08Fix some voicemail playback bugsYorke Lee
* Don't fetch voicemail until playback is started * Prevent multiple voicemail fetches for the same voicemail * Fixed an issue where the seekbar would be stuck in the same position even after seeking * Fix for playback position getting reset after the voicemail view is scrolled out of view and back in * Respect the invariant that if mMediaPlayer is null, mPrepared is always false. This fixes potential NPEs when resuming playback. Bug: 22127956 Bug: 22333494 Change-Id: I5c419424950c0e21317cbd133ca6f7e1edd9fd31
2015-07-07Merge "Don't auto-expand first call log entry" into mnc-devYorke Lee
2015-07-07Don't auto-expand first call log entryYorke Lee
Bug: 22278550 Change-Id: I756703c9441801c623b9dbcbe0d96803de2a3063
2015-07-07Merge "Go to recents tab instead of CallLogActivity for call views." into ↵Nancy Chen
mnc-dev
2015-07-07Go to recents tab instead of CallLogActivity for call views.Nancy Chen
Use the DialtactsActivity instead of CallLogActivity when accepting ACTION_VIEW intents for the "calls" mime type. Also remove an unused method in CallLogFragment. Bug: 22266705 Change-Id: I1bf089901b1a5f9534c9f7a8484c12e535a87749
2015-07-06Fix NPE in setSpeakerphoneOnJay Shrauner
Null check mActivity Bug:22301343 Change-Id: Ia020f2a8c74cf16786af9ab7132da4eb9b9d0401
2015-07-03Fix NPE in pausePlaybackJay Shrauner
Null check mActivity as we do in onPause Bug:22249553 Change-Id: I147fbd517696205a2eb478a6df032f50cbbd5b34
2015-07-01Merge "Restore Dialer content after permissions granted" into mnc-devYorke Lee
2015-07-01Restore Dialer content after permissions grantedYorke Lee
First pass at making Dialer display the call log, favorites, all contacts, and contact search after permissions are granted withut having to restart the app. Update cached permission status in onResume for Dialer activities Update SpeedDialFragment to correctly initialize loader in onResume if it was null previously because of revoked permission. Bug: 22205650 Change-Id: I68982e69395bc9c7da84ff3221cd12b8f79005f9
2015-07-01Merge "Fix dialer monkey NPEs" into mnc-devYorke Lee
2015-07-01Fix dialer monkey NPEsYorke Lee
Monkey tests exposed a bug in Dialer where certain call shortcuts could show up if contacts permissions were disabled and the UI was changing quickly. Don't enable shortcuts by default, and make sure to correctly disable all shortcuts in the case of missing permissions. Bug: 22225052 Change-Id: Icdd81412f695860eb322d7ccdc30555591c584d0
2015-07-01Merge "Don't auto-expand first voicemail card" into mnc-devYorke Lee
2015-07-01Merge "Ensure the EXTRA_SHOW_TAB is checked for all new intents." into mnc-devNancy Chen
2015-07-01Ensure the EXTRA_SHOW_TAB is checked for all new intents.Nancy Chen
onNewIntent is only called when the activity is already active so when an intent is sent to start the DialtactsActivity on a specific tab when the DialtactsActivity is not already active, the code to switch to the specific tab is not called. Move this code to onResume() instead. Bug: 21120186 Change-Id: I735eae22ca5de54f4c17688777b4309616f2c691
2015-07-01Don't auto-expand first voicemail cardYorke Lee
Bug: 22127956 Change-Id: Ia1a62e799bf7b535da2390bc0e8fa62201b8a684
2015-06-30Protect against null mViewYorke Lee
Bug: 22194812 Change-Id: I95e07820ed97d02fe61ee3ceee62c7e76c6f1cb5
2015-06-29Add long press actions to call logYorke Lee
When a call log entry is long pressed, show a context menu that provides the following actions: 1) Copy to clipboard 2) Edit number before call Bug: 21453814 Change-Id: I796cffbec39847fd9c61891063217b15cb298479
2015-06-29Merge "Accessibility fix for Dialer search results" into mnc-devYorke Lee
2015-06-29Merge "Add missing null check in VoicemailPlaybackPresenter" into mnc-devYorke Lee
2015-06-29Accessibility fix for Dialer search resultsYorke Lee
In portrait mode, resize the listview to fit above the dialpad, so that accessibility services can correctly traverse the view hierarchy. Bug: 20172384 Change-Id: I35fb49be7bea5d13d951c4d954ddaf9d8d12780e
2015-06-29Add missing null check in VoicemailPlaybackPresenterYorke Lee
Bug: 22171979 Change-Id: Ia26ba711b888de3c787167bf9af99fcf26a80b7a
2015-06-29Merge "Remove voicemail tab in call history" into mnc-devYorke Lee
2015-06-29Remove voicemail tab in call historyYorke Lee
Bug: 22169419 Change-Id: I512153e31a13df5f36bcb8dc00d53d55ba70117c
2015-06-29Merge "Cache repeated Telecom requests from call log." into mnc-devYorke Lee
2015-06-29Merge "Make the full search bar respond to clicks" into mnc-devYorke Lee
2015-06-27Make the full search bar respond to clicksYorke Lee
Bug: 21663461 Change-Id: I79bf44f7956511e6894a122a98a69d7793b9a785
2015-06-26Null protect invocation of getContentResolver.Andrew Lee
Bug: 22118779 Change-Id: I9a11c2fc05f8a6f418bc0e6daa55dfb61707bd6a
2015-06-26Cache repeated Telecom requests from call log.Andrew Lee
This improves call log scrolling performance. + Split "Wrapper" into a utility and a cache. + Use cache for repeated calls related to call logs. + In the process of fixing plumbing and typer, moved some phone call detail classes into the more appropriate call log package. + Update tests. Bug: 20524705 Change-Id: Ib8ee21e417c19f98f6474a5793416e8f99103b55
2015-06-26Merge "Revise layout/style of VoicemailPlaybackLayout." into mnc-devAndrew Lee
2015-06-25Revise layout/style of VoicemailPlaybackLayout.Andrew Lee
- Delete now-unused old icons. + Add new material icons for voicemail playback. + Rearrange buttons, padding/spacing. + Change ripple feedback when pressing button. + Use different text fields for total duration and state labels. Bug: 22070564 Change-Id: Ibc9b9908154ac0a846f828bb9707a61ab15f8ba5
2015-06-25Merge "Update some icons/styles used in Dialer." into mnc-devAndrew Lee
2015-06-25Merge "Enable proximity sensor onPause." into mnc-devAndrew Lee
2015-06-24Update some icons/styles used in Dialer.Andrew Lee
Bug: 22070564 Change-Id: I7b0d691c18a011f1f61cc12fe063458560528bd4
2015-06-24Merge "Fix potential crash if uri is unavailable." into mnc-devNancy Chen
2015-06-24Enable proximity sensor onPause.Andrew Lee
+ When using speakerphone, add flag to keep the screen on. Bug: 22047261 Change-Id: I4e28ab526218b4cc1f53f2ec98c4749f24ac95af
2015-06-24Merge "Expand the first call log item for new cursors." into mnc-devAndrew Lee
2015-06-24Merge "Show transcriptions in voicemail notifications." into mnc-devAndrew Lee
2015-06-24Merge "Add a promo card for visual voicemail." into mnc-devNancy Chen
2015-06-23Show transcriptions in voicemail notifications.Andrew Lee
+ Get transcript when obtaining information for notification. + If there is only one voicemail, show the transcription in the expanded/long text of the notification. Bug: 21762588 Change-Id: I35958f863d6622147032561121073960a30a6f0e
2015-06-24Merge "Protect against null context." into mnc-devAndrew Lee
2015-06-23Expand the first call log item for new cursors.Andrew Lee
This increases discoverability of the expand actions, and also makes it quicker to interact with the most recent items. Bug: 21960523 Change-Id: I6aefdd5b96a86177b26ecc59879d1a787115221a
2015-06-23Protect against null context.Andrew Lee
Bug: 22031896 Change-Id: I2da646a30a119c5be07dba8ad71c8e902969454e
2015-06-24Merge "Protect against CP2 crash in Dialer" into mnc-devYorke Lee
2015-06-24Merge "Add extra to jump to DialtactsActivity tab." into mnc-devAndrew Lee
2015-06-23Add extra to jump to DialtactsActivity tab.Andrew Lee
+ For the voicemail notification, jump to voicemail tab. + Jump through some hoops to handle this properly when waiting for the voicemail status to be retrieved. Bug: 21120186 Change-Id: I5a82f3ecafadb45246e6637e8275a09f78cc188a
2015-06-23Protect against CP2 crash in DialerYorke Lee
Bug: 21755796 Change-Id: I81a337db0728455ffa72b3067bc5d2260dd03db8
2015-06-23Fix potential crash if uri is unavailable.Nancy Chen
If the voicemail is in the process of deleting, the uri may be unavailable after the async task has started executing. Make a null check first. Bug: 21978479 Change-Id: I0ec93e66b055c4e5d9ce2743a3cffc689c835f78
2015-06-23Add a promo card for visual voicemail.Nancy Chen
The promo card explains what visual voicemail is, along with a link to settings to disable it and an ok button to dismiss it. Also move common resources from GoogleDialer to the respective resource files. Bug: 21086059 Change-Id: Iecfe778b815fb572667d0cecdb958205ec1b48a0
2015-06-22Merge "Set FAB to invisible on hide if no animation." into mnc-devAndrew Lee
2015-06-19Set FAB to invisible on hide if no animation.Andrew Lee
ScaleIn animation will not trigger if FAB is already visible, so if we don't scaleOut, set the visibility of the FAB to GONE. Bug: 21903907 Change-Id: I25ef78ca4e042665d62c40b791d7217310515597
2015-06-20Merge "Rewrite of MediaPlayer logic." into mnc-devAndrew Lee
2015-06-19Rewrite of MediaPlayer logic.Andrew Lee
+ Control MediaPlayer instance more tightly. Wait until prepareContent to initialize instance. Release MediaPlayer when it is no longer needed. + Instead of using isFinishing, check explicitly for orientation change to know whether to release MediaPlayer. + Change Presenter to singleton, to address audio change wonkiness. + Only create a Presenter if the call log fragment shows voicemail. + ... fixing a variety of cases. - Temporarily disable proximity sensor until blocking issue is fixed. Bug: 21856243 Change-Id: Ic06e98bb5278467c3cce726a06b6cf3d855861a2
2015-06-19Visual indicator that voicemail is unread.Nancy Chen
Bold the text for unread voicemail messages. Bug: 21086059 Change-Id: Ieb07c7fa22a91669faeb425dabb60b1176ec1091
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-19 23:00:12 +0000