summaryrefslogtreecommitdiff
path: root/src/com/android
AgeCommit message (Collapse)Author
2015-06-18Merge "Clarify phone type magic constant naming." into mnc-devAndrew Lee
2015-06-18Merge "Pass activity into VoicemailPlaybackPresenter." into mnc-devAndrew Lee
2015-06-18Pass activity into VoicemailPlaybackPresenter.Andrew Lee
We will use it to set windows flags to help make playback behaviors reasonable. Bug: 21856243 Change-Id: I7c1ecb9e225a507ea8956ccc31d667361a4b6824
2015-06-18Clarify phone type magic constant naming.Andrew Lee
Bug: 21895943 Change-Id: I562eea49292704aa8b8c76706fa1ea196a180eed
2015-06-17Merge "Fix FAB state and transitions." into mnc-devAndrew Lee
2015-06-16Fix FAB state and transitions.Andrew Lee
+ Change to dialpad FAB in search (used to stay as add contact FAB, if we were in the Contacts list). + Position dialpad to align end in search (used to stay in the center, if we opened the search from Speed Dial). + Restore correct position/icon when exiting search. + Add correct FAB scale in/out behaviors in for transitions between lists fragment and search UI, search UI and dialpad, in particular for when the FAB changes position from END to MIDDLE when going from search UI back to Speed Dial. + Add FAB scale in/outs for showing/hiding the soft keyboard. Bug: 21161760 Change-Id: Idbddbac161e459e3708d43395850d80927d5e448
2015-06-15Add play voicemail primary action to call log.Andrew Lee
+ Add voicemail primary action button, which expands the call log and plays immediately when clicked. + Pass expand/collapse listener into the view holder. This is necessary because it needs to be triggered when the "play" primary action is clicked so that the CallLogAdapter correctly registers what has been added and binded. + Update primary action button state when showing or hiding actions, so the visibility of the voicemail play button is managed properly. + Ensure voicemail playback state is consistent between multiple call log items when the user initiates a collapse or expand. Add reset function to help manage this. + With the reset, protect against the possibility of functions in the presenter being called when no voicemail playback view is set. Bug: 21654755 Change-Id: I7bcf67d27fa08fe77d1334dc084b52effe8d3ccc
2015-06-15Merge "Fix abundance of "Custom" labels." into mnc-devAndrew Lee
2015-06-15Fix abundance of "Custom" labels.Andrew Lee
Not sure precisely why this changed, but hopefully this logic is more robust. Show the geocoded location if there is no name to use and a location is available. Removed GEOCODE_AS_LABEL, which wasn't really used anymore. Bug: 21814339 Change-Id: I1343282ef415647853d7995d900a3f50186ad156
2015-06-15Merge "Convert to primary action button on call log items." into mnc-devAndrew Lee
2015-06-12Convert to primary action button on call log items.Andrew Lee
+ This is the call button on the standard call log list item, but will be play on voicemail call log list items. + Add call "list" action for voicemail call log list items. Change-Id: I4b115b96738b77c8a19c1071d5290e65f93395ac
2015-06-12Merge "Don't include voicemails in ALL call type filter." into mnc-devAndrew Lee
2015-06-12Don't include voicemails in ALL call type filter.Andrew Lee
Bug: 21814327 Change-Id: I6f59781ba5f8e5e396d919fefed6bfd76ec9e206
2015-06-12Merge "Don't pass media player to VM playback layout." into mnc-devAndrew Lee
2015-06-12Don't pass media player to VM playback layout.Andrew Lee
Better to ask the presenter, where it can check if the media player is in the appropriate prepared state. Bug: 21765119 Change-Id: Ieeade86900da1eb0ed9407bea17a7fc6219b3ad2
2015-06-12Merge ""Emergency" dialpad behavior." into mnc-devSantos Cordon
2015-06-12Merge "Paranoid mIsPrepared checks." into mnc-devAndrew Lee
2015-06-11"Emergency" dialpad behavior.Santos Cordon
Change-Id: I132a119238c8de7249a4944e6dda472b3851637e
2015-06-11Merge "Default to earpiece for all voicemail." into mnc-devAndrew Lee
2015-06-11Default to earpiece for all voicemail.Andrew Lee
Bug: 21654804 Change-Id: I9fa76a33231ae95f4a233b4f6615c56280a0228e
2015-06-11Paranoid mIsPrepared checks.Andrew Lee
Returning early if media player is not prepared in all these cases, just in case. Bug: 21764908 Change-Id: Ieca0e9fd1c323ea5150464683600542fefb318b3
2015-06-11Merge "Check mIsPrepared before querying MediaPlayer." into mnc-devAndrew Lee
2015-06-11Check mIsPrepared before querying MediaPlayer.Andrew Lee
Bug: 21764908 Change-Id: I5336ccadf13724430c2f3ee76c37efacd73cd27f
2015-06-11Merge "Move "Report" to CallDetailActivity." into mnc-devAndrew Lee
2015-06-11Merge "Fix crash after rotation in SelectAccountDialogFragment" into mnc-devYorke Lee
2015-06-10Move "Report" to CallDetailActivity.Andrew Lee
- Delete old report button/handling code. + Convert menu click listeners into single onMenuItemClick method. + Add and populate objectId on PhoneCallDetails, to be able to tell from the CallDetailActivity whether to enable reporting. Change-Id: Ie4b9a3c1835792cbba04dc826f71fd2e53071400
2015-06-10Fix crash after rotation in SelectAccountDialogFragmentYorke Lee
* Refactor code so that the callback can be parcelled and persisted in the fragment after rotation. * Make callbacks inner static classes to avoid potential leaks Bug: 21650435 Change-Id: Ie7c640f580233256c99d0e9e1643153d4c599d20
2015-06-10Merge "Change PhoneCallDetail fields to be non-final." into mnc-devAndrew Lee
2015-06-10Change PhoneCallDetail fields to be non-final.Andrew Lee
It's been a pain to add/change fields on PhoneCallDetails because a multitude of parameters required for the constructors to create an instance. I ran into this while considering how to add an objectId to its parameters, and have previously too... Make fields non-final so that they are more easily set. This has the side-effect of making the casing of some initialization code more straightforward. + Change it's constructor to a subset of required fields. + Simplify/reorganize CallLogAdapter and CallLogAsyncTaskUtil code. + Simplify tests. Bug: 21733599 Change-Id: I236dfb0b8e6513f4b44dbdae17ce2eb9c9ae4778
2015-06-10Merge "Call log duration display for calls less than a minute." into mnc-devRoshan Pius
2015-06-10Call log duration display for calls less than a minute.Roshan Pius
Changing the call log details duration display to show only the seconds if the elapsed duration is less than a minute. Bug: 19383401 Change-Id: I8d39ca2c6c680e58602022250d4272d83024696d
2015-06-09Merge "Fix CallLogFragment UnitTests." into mnc-devAndrew Lee
2015-06-09Merge "Get rid of some now-unused VM code." into mnc-devAndrew Lee
2015-06-09Fix CallLogFragment UnitTests.Andrew Lee
Run "changeCursor" on the main thread. I'm not precisely sure why this fixes things, but it appeared before that the data I had on my local device was being used instead of the test data. Bug: 21471763 Change-Id: I6bece02e7c6828d54f76b5221ad10cf8f0052aa9
2015-06-09Merge "Fix some more unit tests..." into mnc-devAndrew Lee
2015-06-09Fix some more unit tests...Andrew Lee
+ Pull out voicemail playback tests into their own test class. + Fix CallDetailActivity unit tests. + Some minor tweaks to functional code to facilitate. Bug: 21471763 Change-Id: I0f1747ab7ad6eba7dd2a7f6f8cfd060b409771bc
2015-06-08Use carrier config BOOL_HIDE_CARRIER_NETWORK_SETTINGS.Junda Liu
Uses carrier config instead of settings to show/hide dialer settings. Bug: b/21355336 Change-Id: I2a19b82855cd5e48d1047edcf78d46718d68b3c9
2015-06-08Get rid of some now-unused VM code.Andrew Lee
Bug: 21471763 Change-Id: Ie28dc2715a173179ed753a7e38bd252c01e78f46
2015-06-08Merge "Fix class variable declaration." into mnc-devAndrew Lee
2015-06-08Fix class variable declaration.Andrew Lee
Bug: 21687649 Change-Id: I212243932c1be5306d97db9020874cadf5a55058
2015-06-05Handle FetchResultHandler race condition.Andrew Lee
Previously, the voicemail only needed to be looked up once, but now a single presenter may load multiple voicemails. As such, destroy the old FetchResultHandler if one already exists. Bug: 21663448 Change-Id: Ibdb08f03760b770d0800bd44d4cdcf0ca7c57fc9
2015-06-05Merge "Add call button to details, increase hit area." into mnc-devAndrew Lee
2015-06-05Merge "Add delete action to voicemail in call log." into mnc-devAndrew Lee
2015-06-05Merge changes Id1c7d48f,Ib903d19c into mnc-devAndrew Lee
* changes: Show empty view after load returns empty. Change text to "add to a contact".
2015-06-05Merge "Don't call isPlaying if not prepared." into mnc-devAndrew Lee
2015-06-05Show empty view after load returns empty.Andrew Lee
... instead of before. Mildly disorienting as a loading experience. Bug: 19937778 Change-Id: Id1c7d48f3379350030aaed4f4a50320d22f970f6
2015-06-05Add delete action to voicemail in call log.Andrew Lee
+ Cleanup some asset and variable naming. Bug: 21239168 Change-Id: I4c99484bee1fcd300857cf44080c38e19a98cb5a
2015-06-05Add call button to details, increase hit area.Andrew Lee
+ Add call back button in call details. + Increase touch target size of call back button. + Simplify tint styling and layouts. - Delete asset which was duplicate of one in ContactsCommon. Bug: 18331084 Bug: 21659613 Change-Id: Icbd5f66a294f1215dc2056e7f7aece2129af5630
2015-06-05Bidiformat number to force to LTR.Andrew Lee
Bug: 20981731 Change-Id: I659903305475691e241955555494b2596846af6f
2015-06-05Don't call isPlaying if not prepared.Andrew Lee
Bug: 21647046 Change-Id: Ib0f5c2d7cd973ba4732defeceb32fe956e8dbdb8
2015-06-05Merge "Fix shortcut action text length issues." into mnc-devAndrew Lee
2015-06-04Fix shortcut action text length issues.Andrew Lee
+ Lower shortcut char limits. There's probably 40 characters of space on a N6, but less on smaller devices. + Shorten "Add to existing contact" to "add to contact". Bug: 21550993 Change-Id: I136b01cd90ae36e07b7f567294e68316a57856a0
2015-06-04Merge "Bidi-format joined strings." into mnc-devAndrew Lee
2015-06-04Bidi-format joined strings.Andrew Lee
When joining strings, we want to respect RTL formatting for the individual elements being joined, and joined string as a whole. For example... In LTR: "<LTR-formatted string>, <RTL-formatted string>" In RTL: "<RTL-formatted string>, <LTR-formatted string>" Bug: 20988802 Change-Id: I984ff364cbd0b0378bc467213274080e9524b18b
2015-06-04Merge "Move VM playback from details to call log." into mnc-devAndrew Lee
2015-06-04Merge "Fix VoicemailStatusHelper unit tests." into mnc-devAndrew Lee
2015-06-03Fix unit test errors.Andrew Lee
When this was refactored before, some of the logic was bad. Some of the expected values were changed as well. I figured "add to contacts" is a really bad default text, because we don't actually support that action in call details. Also, the strings returned by the library for describing relative time spans changed. Bug: 21471763 Change-Id: I0c78c89c9c2e44de198f1f9299711fc31fe81cb1
2015-06-03Fix VoicemailStatusHelper unit tests.Andrew Lee
VoicemailStatusHelperImplTest was broken because of visibility issues caused by recent changes to how we read voicemail status. But, we plan to use this functionality again in the future. Bug: 21471763 Change-Id: I2049d2661c7d0686c8a439ea8a9e5bd20b009dd6
2015-06-03Move VM playback from details to call log.Andrew Lee
- Delete voicemail playback in the CallDetailActivity. + Add voicemail playback to the call log list items. + Move the VoicemailPlaybackPresenter to the CallLogFragment. + Fix some retaining state for both call log (expanded items), and preserve rotation/state functionality for voicemail playback. This included some changes to the Presenter logic. + Fix some tests. Bug: 21471763 Bug: 21170557 Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
2015-06-02Merge "Rename PhoneNumberUtils APIs" into mnc-devBrian Attwell
2015-06-02Rename PhoneNumberUtils APIsBrian Attwell
In response to more API review. Bug: 21571895 Change-Id: Ia1fa69da07a3427997919ba61c77fcbad7e79f2a
2015-06-02Merge "Continue voicemail playback during rotation." into mnc-devAndrew Lee
2015-06-02Merge "Enter search UI even if dialpad is not animating" into mnc-devYorke Lee
2015-06-02Merge "Don't use Log.isLoggable to determine DEBUG flag" into mnc-devYorke Lee
2015-06-01Don't use Log.isLoggable to determine DEBUG flagYorke Lee
This allows unnecessary debug statements to be stripped out by the compiler. Change-Id: Id1b6f8bd6c86cf5014e4b76524aa3839eb31bbb8
2015-06-01Enter search UI even if dialpad is not animatingYorke Lee
This fixes a UI bug that happens when the dialpad is displayed without animation. Bug: 21524134 Change-Id: Ic566b09c2839d7f34d5d983f67e592c1b2d50d2e
2015-06-01Continue voicemail playback during rotation.Andrew Lee
Don't pause playback or release the media player during onPause or onDestroy. Bug: 21235334 Change-Id: I0eccd4e38e89c3416817d80aa25cc3bb529a9d6b
2015-06-01Fix CallDetailActivity tests.Andrew Lee
+ Reset the AsyncTaskExecutor's instance between calls in tests. I don't know why this is necessary, but it fixes a class of problems which were happening. + Don't try to release a media player if it has not been prepared. + Handle possible race conditions since MediaPlayer's async prepare may be buffering or finished when a test assert is executed. + Add asset file no longer provided by variablespeed library. - Cleanup some stream copy code. Change-Id: I0ae5fde00514c6dcdb1e9c063435a13eed6e8528
2015-05-28Merge "Refactor Voicemail Playback into standalone view." into mnc-devAndrew Lee
2015-05-27Fix Talkback focus for call log action views.Andrew Lee
Bug: 21448455 Change-Id: Icb9f37643d12dde2d46743d2ce3aa2fade7a68a1
2015-05-27Refactor Voicemail Playback into standalone view.Andrew Lee
+ Substitutes the existing playback widget in CallDetailActivity, although the plan is to move this to the call log shortly. + Convert the widget from a fragment into a layout. This allows us to more easily create multiple instances of the voicemail widget in the same view, as we intend to do in the call log. + Shift UI-related logic from Presenter to the Layout. + Fix janky seeking, so that it now works correctly consistently rather than sporadically, and doesn't need to buffer again. - Remove the VariableSpeed player formerly used in the Presenter. We don't use this functionality anymore, and this allows us to directly used the framework MediaPlayer (instead of a custom legacy proxy). Bug: 21170557 Bug: 20693172 Change-Id: Ia34f459df10e43763b32fdb0954f83e882664231
2015-05-26Merge "Handle runtime phone permission" into mnc-devYorke Lee
2015-05-26Merge "Handle runtime permissions in Dialer" into mnc-devYorke Lee
2015-05-22Handle runtime phone permissionYorke Lee
We don't have access to the call log without the phone permission, so disable the following functionality: 1) Call log display 2) Show call history overflow menu option 3) Last number dialed functionality Bug: 20266292 Change-Id: I2f1d4b8b5f747d2fa04c3a9c291f9cf5147646b7
2015-05-22Handle runtime permissions in DialerYorke Lee
Conditionally disable the following features if the required permissions are not available: 1) Display of all contacts 2) Display of speed dial 3) Caller ID in call log 4) Import/export contacts 5) Conversion of People.CONTENT_ITEM_TYPE and Phones.CONTENT_ITEM_TYPE into a phone number (via DIAL intent) 6) UndemoteOutgoingCallReceiver 7) Contact Search 8) Contact lookup in call detail activity 9) Nearby places search Bug: 20266292 Change-Id: I6d26902acb0eac407ae7bc18c11aa6ec57299506
2015-05-22Merge "Transfer VM fragment logic to presenter." into mnc-devAndrew Lee
2015-05-22Merge "Some ListsFragment cleanups." into mnc-devAndrew Lee
2015-05-21Transfer VM fragment logic to presenter.Andrew Lee
We want the presenter to handle/manage resources pertinent to the activity lifecycle, so that we can convert the playback fragment into a component. My apologies to whoever has to disentangle this presenter logic later (though that could be me). Bug: 21170557 Change-Id: Icf65d3c23f1a12a7d63c2a281f96d2168a4a560f
2015-05-21Merge "Allow dialing SIP calls directly from search" into mnc-devYorke Lee
2015-05-21Allow dialing SIP calls directly from searchYorke Lee
Bug: 20554942 Change-Id: I47daa3491223aed7e988e7d81501a281f1566f1c
2015-05-21Some ListsFragment cleanups.Andrew Lee
- Delete unused shortcut code. + Consolidate logic for reporting the current lists view. + Change page position logic to make private the list fragment's calculation of the type of tab in RTL. Bug: 21328994 Change-Id: Ic05a895fce77fea668798fca6e67863a2fcfd88a
2015-05-21Add voicemail tab if there are active providers.Andrew Lee
Bug: 21328994 Change-Id: Id6cd45c5614fafcc6f01842a8ec1eaba45dc0928
2015-05-19Add AsyncTaskUtil for call log actions.Andrew Lee
+ Factors out async tasks from Call Detail activity, so that in the near future it can be invoked from the call log directly. + Create listener interfaces for actions to execute after tasks have been completed. + Should have no logical/behavioral changes. Hopefully, this creates a more opaque interface for activities or other classes to perform these actions as well. Bug: 21170557 Change-Id: I43aea7e37600d3978e285f047cba7ce75ebb5787
2015-05-19Performance improvements to call log scrolling.Andrew Lee
- Remove call to CallUtil to check if video is enabled. It seems like it's fine to include the content description of what the call was, if it was a video call, even if there is not a video-enabled call account. - Factor out PhoneNumberDisplayHelper so it doesn't need to be an instance. This reduces some extra calls to getDisplayNameHelper. Probably a marginal difference, performance-wise, but it probably helps a smidgen and also simplifies the need for creating and passing or recalculating various instances of things. TODO: It'd be much better if PhoneCallDetails had a builder. It's terribly painful to fix all the tests when adding fields... Change-Id: I6da13dc8b6b047043aba871796a8ed13b112a227
2015-05-18Merge "Only allow one expanded call log card." into mnc-devAndrew Lee
2015-05-18Remove voicemail transcript from details.Andrew Lee
It will continue to be shown in the call log, but will be removed from details since the widget will be moved. Bug: 21170557 Change-Id: I1ec3b090adc0736f7b134d0f67282ba7b4f9483b
2015-05-15Merge "Delete unused code in CallDetailActivity." into mnc-devAndrew Lee
2015-05-15Merge "Fix potential Dialer NPEs" into mnc-devYorke Lee
2015-05-15Fix potential Dialer NPEsYorke Lee
Fix NPEs encountered during monkey tests Bug: 21167534 Change-Id: I98b6f675adfd233d3583c363f7daeca1bc14d8b7
2015-05-15Delete unused code in CallDetailActivity.Andrew Lee
- I don't know of any affordances in call detail to make a call, so the onKeyDown code seems to be superfluous. - No references to ViewEntry or forceLeftToRight. Bug: 20433758 Change-Id: Idbf6ffb81d3697b27cb51eda346b46eb5d083878
2015-05-14Remove VM StatusMessage code from Call Details.Andrew Lee
This isn't used in any particular case right now. Remove some unused layouts too. Bug: 21170557 Change-Id: Ie21264d7059e73c905b2807b993b95c91a0dd3ec
2015-05-15Merge "Change VM playback fragment layout." into mnc-devAndrew Lee
2015-05-14Change VM playback fragment layout.Andrew Lee
- Remove increase/decrease playback rate functionality. - Flip button controls below the scrubber. - Delete TextController. Bug: 20433758 Change-Id: Id628bac0c9f8baed014079f2a89ce912fd2bb549
2015-05-14Only allow one expanded call log card.Andrew Lee
This was some functionality lost in the switch to RecyclerView and cards. + Consolidate old methods into single OnClickListener. - Deleted unused listener. Bug: 20433758 Change-Id: Ic4797687548e94c0459e2a3a4134ef0aa5191d90
2015-05-14Merge "Don't set voicemail status message in Call Log." into mnc-devAndrew Lee
2015-05-13Don't set voicemail status message in Call Log.Andrew Lee
This code has been unused for quite some time, as far as I can tell. Bug: 20433758 Change-Id: Ic9fef01954720c24d8ba6971534897a88af42a8f
2015-05-13Merge "Move proximity sensor logic into VM fragment." into mnc-devAndrew Lee
2015-05-13Merge "Fix NPE in keyPressed when getView is null" into mnc-devJay Shrauner
2015-05-13Merge "Send VM notification to VM call log tab." into mnc-devAndrew Lee
2015-05-13Send VM notification to VM call log tab.Andrew Lee
We used to send them straight into call details to play the voicemail. But, now we're removing that playback widget into the call log, so that doesn't work anymore. Instead, drop them into the call log. - Remove superfluous interface. Bug: 20433758 Change-Id: Icac220c65bb8ccf5589b4ae38db7b8c3fbf384f4
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-19 22:51:16 +0000