Age | Commit message (Collapse) | Author |
|
* The logger is responsible for sending it to its logging
implementation, and also to AnalyicsUtil.
* Standardize logic for creating a tagged version of a screen
name
Bug: 23164804
Change-Id: I9b817fba5359f78340f2d9fdba54af9ea73cdb37
|
|
ub-contactsdialer-a-dev
|
|
Bug:25456614
Change-Id: I6fdd34a0d619053d632e7364fc8ccaba8f8ef15f
|
|
ub-contactsdialer-a-dev
|
|
Format the number of the new voicemail for display to improve
readability and announce the number with individual digits in text-to-speech.
Bug: 25122678
Change-Id: I96ef815db72b5b0571f9dd662d68f4f6cc6d0416
|
|
ub-contactsdialer-a-dev
|
|
ub-contactsdialer-a-dev
|
|
"showing item" messages." into ub-contactsdialer-a-dev
|
|
messages.
+ DiatactsActivity set its' title to "Phone Dialpad" or just "Phone", so user
using Talkback can know the state of the activity when it is launched
+ SpeedDialFragment and SearchFragment no longer send accessibility events when
its' content is changed.
+ Add AccessibilityDelegate ContentChangedFilter to filter out
TYPE_WINDOW_CONTENT_CHANGED event for View.
Bug:25190037
Change-Id: If1fa34cc9a5d24dec3fe261da9c071bb5388ec58
|
|
ub-contactsdialer-a-dev
|
|
The accessibilty delegate automatically expands the call log cards when
the card is in focus. However, the voicemail state was not being reset
when this happened. Make sure to reset the voicemail playback state
when expanding the card in this manner.
Bug: 24105523
Change-Id: Ife7535980566d7b62959767d7b72df779d275270
|
|
The incorrect column was being used to populate mContactIdIndex
which was breaking the deduping logic (which is based on contactId.
Bug: 25432987
Change-Id: If8c435e84d191ed012a019a800cf18abbda3d907
|
|
+ Changed ContactInfoHelper.lookUpDisplayNameAlternative to public so
it's usable in InCallUi
+ Changed ContactInfoHelper.lookUpDisplayNamealternative to static to
cut down on object creation
+ Added tests for lookUpDisplayNameAlternative since it is public
Change-Id: Iede746655a1ca773cb0cd8cf26df665e34ab47fc
|
|
+ Renamed CallDetailActivity.updatePhotoAndBlockActionItem() to
updateFilteredNumberChanges() since it no longer updates the photo.
Bug:25446254
Change-Id: I7f20c38927c7ec9dd247550538f3fd79abba240e
|
|
Bug:25446254
Change-Id: If5bdcbc3f8c3951882667ee3abba46e1599cc68b
|
|
Bug: 25429251
Change-Id: If2b4b875e3433f252a34d1afeaf3eaa3a1a3c3fc
|
|
|
|
+ BlockedListSearchFragment.onChangeFilteredNumberSuccess() calls
activity.onBackPressed() instead of re-adding the management fragment.
Original fix was lost due to a bad merge.
Bug:25330660
Change-Id: Ib6d04dba55832845d145d2925cfb595237e7a19f
|
|
+ Clearer name about functionality, and async nature.
+ Change it to return "false" if it fails and is trying to block an
invalid number, rather than returning "true". This matches a more
standard success/fail return paradigm.
+ Update logic for showing "invalid" message based on return value.
+ Simplify parameter set which it takes in; always take nubmer and
countryIso, because they can be used to calculate the normalized #.
Bug: 25343277
Change-Id: If6fb28a6395e207047f4b27bfac37f5c70a9bac3
|
|
|
|
Some of the checking for invalid numbers was broken by code
cleanups yesterday, and blocking of numbers which can't be normalized
had been allowed (which is no good). Fixing this, by unifying checks
for whether or not a number can be blocked.
Bug: 25343277
Change-Id: Ia631a3e53e3f9ed58e173055a5e18086d95c9d02
|
|
|
|
This "shares" the cache among multiple instances of call log
fragment. This allows "clearing" the cache to propagate changes
across all instances. This should also have the side benefit
of fewer lookups.
~ Change to use ConcurrentHashMap, since it can now be accessed by
multiple call log fragments.
~ Do a little footwork with conversion, since ConcurrentHashMap
does not accept null values.
Bug: 25369105
Change-Id: Id21d1f6a18017c8e0bca88e57f09c9b4b173b843
|
|
- Speed dial names change based on whether user wants first name first
or last name first
- Sort order preferece is respected if ContactEntries have conflicting
pinned positions
- Added tests for PhoneFavoritesTileAdapter.arrangeContactsByPinnedPosition
method
Bug:19364093
Change-Id: I81214abce572e297cc21fcb4f5a901ecad958380
|
|
|
|
|
|
- Remove setting for show/hide.
- Remove utilities and behaviors for show/hide.
~ Continue filtering blocked call types in call log (which may be
marked by other applications.)
~ Change behavior after blocking call; instead of keeping the call
log entry but changing the type to BLOCKED, delete it instead.
+ Default behavior is now to delete entries and visual voicemails of
blocked calls.
Bug: 25378068
Bug: 25106387
Change-Id: I8cbc419b25cce6ba39099857cffe4eb1df9d0bef
|
|
ub-contactsdialer-a-dev
|
|
Before, it would linger around, even after the user had touched it
and visited the settings screen. Feels like more standard behavior
for it to be dismissed at this point (user has clearly seen it,
and it doesn't really contain any info which needs to persist).
Bug: 25377379
Change-Id: I5608a3d735fd084f4493c0fcd51d9dcedf04dc6f
|
|
Bug: 25343277
Change-Id: I166a142f1537835b13afb2d15c0893aacda4eedd
|
|
+ Convert from button into list item with ripple feedback.
- Removed divider line between list items, including the custom
background drawable which used to be used to achieve the divider
only for the bottom border.
Bug: 25356667
Change-Id: Ic19fd8b895b7b12a140c64a945f8ac8571e0a510
|
|
Bug: 25368270
Change-Id: Ie668b4f6cd029260440bafaf7951957a81cd7632
|
|
ub-contactsdialer-a-dev
|
|
Manage is more related to a specific screen, new name seems to
make more sense based on location in settings menu of application.
Bug: 25343277
Change-Id: Ia45c1b7aa91c045078fd1473500f5d474e1c598f
|
|
Reconstruct the normalized phone number from other params.
Bug: 25343277
Change-Id: Ibb526b0808e0b50a4e946d91279e5570af44c3ca
|
|
... really, this was just bugging me. I'm not trying to just pad
my CL count. ;)
Bug: 25343277
Change-Id: Ifa0e894415d64f373fc23b01eb6169b5fffd98ce
|
|
|
|
It bugged me how it was inconsistently named to other classes
(ie. FilterNumber vs FilteredNumber).
It's also specific to blocked numbers, for now, so it felt more
appropriate to name it accordingly.
Bug: 25343277
Change-Id: I33e2f9fd933d117326690901ec71e3e8c0e3bbd3
|
|
ub-contactsdialer-a-dev
|
|
The right thing to do is to return early in this case.
This is a theoretical fix for the tagged bug; presuming that this
exception caused code execution to terminate prematurely and delete
the voicemail as it would be expected to.
Bug: 25346075
Change-Id: I643ff4e8abf723f3673b38f5933416730e5d5f9f
|
|
|
|
|
|
+ Add method and listener to FilteredNumberAsyncQueryHandler to
query for whether there are any blocked numbers.
+ Added utility function for showing a notification, which points
to the blocked numbers setting screen. This notification will only
be shown if the user has blocked numbers.
+ Add a boolean flag to track whether we have shown this notification
after an emergency call. This is to address the (edge) case where the
user makes an emergency call when they have not blocked any numbers,
but then later blocks a number.
+ Added strings for notification.
Bug: 25327365
Change-Id: I3179f3884271ea0a504ef8c9a61bf9dfbd18ef10
|
|
ub-contactsdialer-a-dev
|
|
Bug: 25342525
Change-Id: I9a845ffa25323b53175dc0eac2da1f2b4311abe3
|
|
|
|
+ Saved search term.
+ Fix padding/shadow jank between rotations.
+ Fix title disappearing for import on rotation.
Bug: 24910704
Change-Id: Ib683bd07ad629917ac429a5f33be54ecf781e33d
|
|
ub-contactsdialer-a-dev
|
|
Discovered the bug was in the TalkBack code instead of the dialer code,
this change is no longer necessary.
Bug: 25127953
Change-Id: Ic02dab7ab448d4df55bb6f4d91a723805de58f32
|
|
+ Adjust talkback focus to allow the user to page through the cards
for the settings and import separately, even though they are
structurally part of the same header component, visually they
reside in different "cards".
+ Change the "hide setting" to be toggled by tapping on the text
description area.
Bug: 25163592
Change-Id: I0d1fcd28dba058d707bfe5099cdf912aed14f728
|
|
- Remove unnecessary getter.
+ Reorganized arguments logic in FilterNumberDialogFragment.
Bug: 25343277
Change-Id: I7541f21ed28794b4a5d73e0c6c6d895ca6402c77
|
|
+ BlockedListSearchFragment.onChangeFilteredNumberSuccess() calls
activity.onBackPressed() instead of re-adding the management fragment.
Bug:25330660
Change-Id: If3a4cd26a180cf08a0e28f0c4bd05e7fd6149c20
|
|
ub-contactsdialer-a-dev
|
|
Add a systems settings config, which is checked for the delay
threshold if a particular debug VERBOSE logging mode is used.
Usage:
adb shell setprop log.tag.DebugEmergencyCall VERBOSE
adb shell settings put system dialer_emergency_call_threshold_ms 60000
Bug: 25216954
Change-Id: Ia9b179e16819d3d8232cbedd49d5744d7b69a825
|
|
card." into ub-contactsdialer-a-dev
|
|
When rebinding the voicemail card, onPrepared gets called and resets the
voicemail playback to 0 because mPosition is not updated to the most
recent value. Update mPosition in this case to the position of the media
player and then call onPrepared.
Bug: 25080811
Change-Id: Ief3a021f4c11bac7b8c0a563765e14c897cb43b5
|
|
Straight revert of all onboarding flow related CLs -
the onboarding flow is not needed for now as the Dialer
will always at least be the system dialer.
Bug: 25020847
Change-Id: Ic1c5020b9b423de50801485f764209b21d5d7f33
|
|
ub-contactsdialer-a-dev
|
|
ub-contactsdialer-a-dev
|
|
The voicemail entries were reading "speed dial" because the focus would go
to the newly added "speed dial" tab since the tabs are all removed and
readded when the tab info changes. Change the logic so that only the
voicemail tab is changed when needed.
The voicemail entry reads "seek playback" instead of the information
about the voicemail because of custom expand logic for accessibilty.
Change it so that only the call log items are expanded when selected
(it is more important to be able to discover the overflow options).
Also change content description text because it was too long and confusing.
Bug: 25124120
Change-Id: I64c1b27d8c0db57525f7f4ada59655e9f8352245
|
|
- Updated the CallDetailActivity to choose whether to show last name first
or first name first based on user preferences.
- Modified callLog code to behave in a similar fashion
- Fixed bug in ContactInfoHelperTests
- Rename PhoneCallDetails.name -> PhoneCallDetails.namePrimary
Bug: 19364093
Change-Id: I50971ad0f26f6ede49f1c82965d1b00ce0cba4d3
|
|
ub-contactsdialer-a-dev
|
|
ub-contactsdialer-a-dev
|
|
+ Configure BlockedListSearchFragment so it will not show empty
when the search query is null.
+ Removed local reference and equality check for changes in the
query string. This is done in the superclasses already, so was
redundant.
- Removed unnecessary override in RegularSearchFragment.
Bug: 24910704
Change-Id: Ifd11eed9e3ba6fb00ba535ae019df477f81518fb
|
|
Distinguish between a manual long press and system long
press (via accessibility) when modifying the current
dial string.
Bug: 23554996
Change-Id: I3fc610c8e24bdb39729b827715e08a3e7d73ba1f
|
|
|
|
Though it is lighter on logic now, it still seems helpful to have
a common helper to return whether it should be possible to proceed
with blocking a number.
Bug: 25230222
Change-Id: I99f93f1cfc09988b3dec77f71541463c96d06225
|
|
- Updated ContactInfoHelper to retrieve DISPLAY_NAME_ALTERNATIVE (name
in last name first order)
- Stored alternative name in ContactInfo object
- Updated CallLogAdapter to choose between first name first and last
name first when showing contact name
- Added tests for ContactInfoHelper.lookupContactFromUri (changed to
public method)
- Fixed bug with ContactsPreferences so ChangeListener works
Bug:19364093
Change-Id: I73e8d8602a54e3134ef01b3d5167d828b26fa5ea
|
|
ub-contactsdialer-a-dev
|
|
Bug: 25122678
Change-Id: I83a7d231b8686152c63d9be71a652232664ea682
|
|
ub-contactsdialer-a-dev
|
|
This reverts commit 327fb5bb609a6bee44a62888d671c951b19782fd.
Change-Id: I134f0a26697bec20b746a6e8f041a715d8e95136
|
|
|
|
ub-contactsdialer-a-dev
|
|
- Updated ContactInfoHelper to retrieve DISPLAY_NAME_ALTERNATIVE (name
in last name first order)
- Stored alternative name in ContactInfo object
- Updated CallLogAdapter to choose between first name first and last
name first when showing contact name
- Added tests for ContactInfoHelper.lookupContactFromUri (changed to
public method)
- Fixed bug with ContactsPreferences so ChangeListener works
Bug:19364093
Change-Id: I188d8fc2eccb87edbe56625c9a7537b3d5f0e19e
|
|
- Update button styles and positioning
- Update background images
Bug: 24270592
Change-Id: Idaca76d25d8fc1362fb6c004ec053ac5ed618170
|
|
Crashes because the VoicemailPlaybackPresenter is alerted when the state
of the headset changes but the corresponding view may be out of focus.
Bug: 25090589
Change-Id: Iabe24eb969777ae3919ede05474f35d6c596b20e
|
|
|
|
Also, causes right fragment to retain after rotation and recreation.
Bug: 25154818
Bug: 24910704
Change-Id: Icafbc7ba6f3ad877c2d28d92e510b9afbd822b65
|
|
Will be disabled for 48 hours after an emergency call.
+ Add utility for noting last time of an emergency call.
+ Add utility for comparing current time to last time of an
emergency call.
+ If current time is within 48 hours of emergency call, display
text in settings explaining why call blocking is disabled.
Bug: 24418319
Change-Id: I6824340f04fae17b73f17843a9f6ef991afa0327
|
|
+ Add elements as header, so they scroll with the list.
+ Shuffle around some layouts to make this work correctly.
+ Replace default ListView divider with custom drawable, to achieve
the desired effect of removing the divider on the first list item.
+ Override BlockedNumberAdapter to never report itself as empty.
Otherwise, the header will disappear.
+ Tweak some padding.
Bug: 25134186
Change-Id: I07711437fea2d3042d3987983667ab5316d51fcc
|
|
+ Add a fragment (and adapter) for displaying numbers from contacts
marked as send to voicemail. This fragment has import functionality.
+ Refactor logic around the Blocked Numbers activity; relocate a lot
of the fragment-specific logic, particularly around actionbars, to
within the fragments themselves.
+ Simplify fragment management logic by using replace instead of
show/hide.
Bug: 23351616
Change-Id: I5c1076d6d001a8401234f57c27ada4bcd90e6c27
|
|
Bug: 24134270
Change-Id: I62c32b6cacdc931e7c99dca68b73aa6bf678b497
|
|
Bug: 24134270
Change-Id: I5d28c633abee226f7bc2d63ec80340cd6deb9c79
|
|
ub-contactsdialer-a-dev
|
|
|
|
+ Delete voicemail when the notification is received if the number
is blocked and the "hide" setting is set to true.
+ Changed utility to take time into account; only block voicemail
notifications and delete voicemails if the voicemails are from
after the time when the number was blocked.
Bug: 24134270
Change-Id: I2f3b24d6291a6cec4a7d8530b00dd5a4656ab024
|
|
|
|
We can only honor deleting voicemail for VVM users.
Bug:24134270
Change-Id: I2b4ea6856ab4bc79ad93ac111bc78bc7f8b4833e
|
|
|
|
+ Add settings switch to blocked number settings.
+ Add utility for checking/setting whether calls should be blocked.
+ Filter out blocked calls in call log query, if appropriate.
+ Refresh call log fragment after a change in setting.
Followup work: delete voicemails for calls by blocked numbers after
the time when the user blocked them.
Bug: 24134270
Change-Id: I85088697559ef6fb446b82617f14f1c6fa893df1
|
|
|
|
Bug: 25095683
Change-Id: I244ec8312ad24081fd36967e063ddccd53b0253c
|
|
|
|
|
|
To facilitate reusings the same views and adapter for both the
manage blocked numbers list and the import list. The two will
use different cursors because they are pulling data from different
places (Contacts db vs FilteredNumbers db), and it seemed better
to reuse code rather than creating parallel implementations.
Bug: 23351616
Change-Id: I5cac5f2a6b8b3bf4a6e8f54c8bc3f1c1500ac5e7
|
|
Bug: 25090920
Change-Id: I367e2109acf4f60cedc84bb7c2cd4b472be04f77
|
|
+ Added a utility to do a synchronous lookup for whether a number is
blocked, but it should not be used normally from the UI thread.
+ Change voicemail notifier code to obtain countryIso, and pass back
list of calls to notify as list (to make it easier to remove elements).
Bug: 23944007
Change-Id: Iad1f8ee200b8f8734be3db0504482fcdee61e412
|
|
Bug: 24680730
Bug: 24303461
Change-Id: Ibd7d431355ca97eb2ae7f29537809987a8d5f96d
|
|
Done for both snackbars in call blocking/unblocking and voicemail
deletion.
Bug: 24370325
Change-Id: I00fdebb635e60ac1d421ccf7f15df46693773870
|