summaryrefslogtreecommitdiff
path: root/src/com/android/dialer
AgeCommit message (Collapse)Author
2014-03-18Swap 9 patch for contact tilesYorke Lee
Tweak contact tile dimensions slightly Bug: 13526106 Change-Id: I7ae82dc1815c95577c204dd6ed955d0bf1bc0dc3
2014-03-17Merge "Fade out favorites screen when dialpad is displayed"Yorke Lee
2014-03-14Fade out favorites screen when dialpad is displayedYorke Lee
Bug: 13453829 Change-Id: Ief313d3da78350f9ce576a766ce7cd863aa3d180
2014-03-14Slight UX tweaks to DialerYorke Lee
* Add drawable and apply to dialpad fragment for shadow effect * Tweak name/number padding in tiles * Tweak default letter avatar placing in tiles * Add shadow for dialpad * Swap out 9patch drawable for recents * Add 9patch to contact tile Bug: 13421236 Bug: 13418523 Bug: 13421916 Bug: 13421236 Bug: 13419201 Bug: 13418712 Change-Id: I6ff8fe41d7e2d02db105bb542f425be13ae5fef7
2014-03-11Merge "Make dialpad slide down when dismissed by tapping outside"Yorke Lee
2014-03-11Merge "Remove unneeded references to ContactsContract.Intents.UI"Yorke Lee
2014-03-11Remove unneeded references to ContactsContract.Intents.UIYorke Lee
These private references are not used anymore and were probably left behind during the Contacts/Dialer split Bug: 6948882 Change-Id: Ibd6d0612164f7fc813cb10001b1da0eac4f7b63c
2014-03-11Make dialpad slide down when dismissed by tapping outsideYorke Lee
The dialpad currently simply disappears from view immediately when dismissed by tapping in the space above it. instead, it should slide downwards. Change-Id: Idba1b8c6ccf40a6b12ea611d880e9f86183e6478
2014-03-11Add null check in ContactInfoHelper.isBusinessYorke Lee
Bug: 13415510 Change-Id: Ie099d661edbc4de8c7b3625fed006d10f0d757dd
2014-03-06Merge "Fix jank in no favorites screen when showing/hiding dialpad"Yorke Lee
2014-03-06Fix jank in no favorites screen when showing/hiding dialpadYorke Lee
Reintroduce a spacer view (under the no favorites view) that is the same height as the search box + its margins, so that the no favorites view does not shift when the dialpad is shown/hidden Bug: 13341743 Change-Id: I00171b5fd546e30394c95d31976483d124f75f3b
2014-03-06Merge "Fix for letter tile avatars not displaying properly in calllog"Yorke Lee
2014-03-06Merge "Fix contact tile horizontal animations when swiping shortcut card"Yorke Lee
2014-03-06Fix contact tile horizontal animations when swiping shortcut cardYorke Lee
Instead of using the contact tile's position in the listview to determine what kind of horizontal animations it should undergo, use its position in the contact tile adapter. This ensures that its position remains the same if the shortcut card is swiped away, but is still calculated correctly if its actual position within the contact tile adapter changes. Bug: 13341497 Change-Id: Ia5d4bad1e01a4e47a3fcd934dd580c76ca183a20
2014-03-06Fix for letter tile avatars not displaying properly in calllogYorke Lee
Renable an accidentally disabled line of code which would retrieve the lookup key from the lookup URI, allowing letter tile avatars to display with the correct color and letter. Bug: 13341898 Change-Id: Ic65352053234e37f580aa44d9ed459755c3913f1
2014-03-06Merge "Fix threading problems in voicemail code"Jay Shrauner
2014-03-05Merge "Restricted the tap target for "All Contacts" to the "All Contacts" ↵Tyler Gunn
button alone,"
2014-03-05Restricted the tap target for "All Contacts" to the "All Contacts" button alone,Tyler Gunn
Bug: 13322769 Change-Id: Iea2bd8886efed50b5b5e463c6e9205af4ad97a6c
2014-03-05Fix threading problems in voicemail codeJay Shrauner
Hold libvariablespeed handle in a reference counted singleton. Don't always reinitialize the engine twice in quick succession on startup. Catch and properly handle RejectedExecutionException exceptions thrown by the executor service. Bug:11511992 Change-Id: I6198dec303209445a0efd0f410a67332d75c7507
2014-03-03Fix slight screen jank when sliding dialpad upwardsYorke Lee
Apply the translation animation to mSearchAndRemoveViewContainer (which houses the entire searchbox and its margins), so that the translation takes into account the entire height of the searchbox as well as its margins. Also refactored hideSearchBar slightly to remove an unused codepath. Bug: 13284310 Change-Id: I7b8873154059f616d8a52c4a0239ea6be89c8efc
2014-03-03Merge "Hide shadow overlay for contact tiles with letter tile avatars"Yorke Lee
2014-03-03Hide shadow overlay for contact tiles with letter tile avatarsYorke Lee
Also tweak layout of letter tiles to better match redlines Bug: 13101785 Change-Id: I1846947a389bbdccc30bfe388b24e80e8724a357
2014-03-03Merge "New appearance and look and feel for dialpad."Ihab Awad
2014-03-03New appearance and look and feel for dialpad.Ihab Awad
http://b/13189041 Change-Id: I91028c8fdee31c1f76610573a4396eb979c30170
2014-02-28Use new ContactPhotoManager APIs for letter tile avatarsYorke Lee
*Modify the following uses of ContactPhotoManager.loadPhoto in the following classes to include a DefaultImageRequest, populated with the contact's display name, lookupkey, and contact type as necessary CallDetailActivity CallLogAdapter PhoneFavoriteTileView *Add utility methods to ContactInfoHelper, to parse a lookupUri for a lookup key, as well as determine whether or not a contact is a business contact, from its sourceType field. *Add a sourceType field to PhoneCallDetails which can be used to track whether or not PhoneCallDetails belongs to a business contact *Add a lookupKey field to ContactInfo Bug: 13101785 Change-Id: If339a9c038f92a0212f8f8b45b5e3cc5f6442562
2014-02-27Fix Dialer OOM when building smart dialling indexYorke Lee
If a contacts database had contacts comprising an unreasonably large (> more than 50) raw contacts, querying for these lookup keys was likely to cause problems. Bug: 13133579 Change-Id: I26334dfce583eeaa1c7b8db7c03b7f847534de1b
2014-02-24Always show overflow icon for quick contacts affordanceYorke Lee
Remove the star icon used to bring up quick contacts, and in its place, always show the overflow icon. Bug: 13177113 Change-Id: I88e99b7c45da10013f4bdff879c106fac9e23f89
2014-02-24UX Changes: Dialer actionbar, tabs and searchbox.Tyler Gunn
See CL 423036 for the searchbox text changes. Bug: 13167901 Change-Id: I6806cb27c19f7f0ca55394d70134f0c30c93446b
2014-02-20Add drag to remove for favorites in DialerYorke Lee
* Add remove view in dialtacts_activity.xml, and rearrange layout slightly so that it takes up the same position in the layout as the search view container. Contacts that are dragged to this remove view will be unstarred and unpinned. * Add drag event logic to the Remove View, so that when the user hovers a contact over it, the UI will continue to respond. Previously, only the PhoneFavoritesListView would detect touch events. * Refactor DragDropController and OnDragDropListener into separate classes. DragDropController performs the work of receiving drag/drop events from multiple views, combining them, and then firing off callbacks as appropriate to OnDragDropListeners. Each OnDragDropListener can then update their UI or internal data model as necessary in response to the callbacks. OnDragDropListener <---------------------------------------- ^ | | | DialtactsActivity ---------------> RemoveView | | | | v | | callbacks PhoneFavoriteListFragment |drag events | | | | v v | PhoneFavoriteListView ------------> DragController-------- drag events | | callbacks v PhoneFavoritesTileAdapter --> OnDragDropListener * While in here, add a content description for the clear search button Change-Id: I044ad1c5aa42c7686bde6bf5074095a4fe879bde
2014-02-20Merge "Adding "Speed Dial" title to dialer favorites list and moving "All ↵Tyler Gunn
Contacts" affordance."
2014-02-19Adding "Speed Dial" title to dialer favorites list and moving "All Contacts" ↵Tyler Gunn
affordance. Bug: 13080167 Change-Id: Id825ef4bfc9de5340d40cae8176bdc13fcfb3ccd
2014-02-18Switch favorites screen to grid layoutYorke Lee
* Add logic to PhoneFavoritesTileAdapter so that it now supports an unlimited number of tiled rows. * Tiles now have a configurable height to width ratio. * Fix animations so that tiles moving up and down rows appear to animate in from the correct direction. Tiles moving to the row above should animate in from right to left. Tiles moving to the row below should animate in from left to right. * Update the number of columns in the grid to 2. * Update layout of individual tiles to match redlines from UX. * Tweak font sizes for tiles * No longer truncate names in tiles * Tiles have a 2-3 height to width ratio * Update assets and layout for favorite and more info icons * Add content description for the favorite button * Add tests for PhoneFavoritesTileAdapter Change-Id: I50b298f0941698985d281f13e6a87c5a9b613efa
2014-02-03Call History Affordances SwapTyler Gunn
1. Swapped the intents for the primary view 2. Changed the icon for the secondary action button 3. Added a vertical divider line to separate the secondary action button from the primary view 4. Cleaned up the accessibility text Change-Id: Ifd4ceff0d67b1587c4378e29be7344de50057a7d
2014-01-16Fix synchronization in onNotNullableQueryCompleteJay Shrauner
Synchronize onNotNullableQueryComplete to protect mCallLogCursor and mCallsRequestId. Bug:12591404 Change-Id: Ib1de73d2da0f14875a98b25113a132681da0beaa
2014-01-09Fix NPE in deleted contact removalJay Shrauner
Fix NPE in deleted contact removal. Bug:12475233 Change-Id: I7f7a2c78e62e838728868063b0f76e6bffba2130
2013-12-20Merge "Fix potential NPE in saveHorizontalOffsets"Jay Shrauner
2013-12-20Merge "Protect against class cast exception"Jay Shrauner
2013-12-19Support long-click during lift-to-type accessibility modeAlan Viverette
BUG: 8310727 Change-Id: Icf9e103d2d6f5b5e7acb8c7f16244f0cebe9ffaa
2013-12-19Protect against class cast exceptionJay Shrauner
Protect against class cast exception. Bug:12228894 Change-Id: Ifae04d6354812e296890cfe0c4c5f2fff73c4c2a
2013-12-19Fix potential NPE in saveHorizontalOffsetsJay Shrauner
Fix potential NPE in saveHorizontalOffsets. Bug:12031506 Change-Id: I713fed5995356bdaaf93186454dcc53b92cb75ec
2013-12-17Add null check for cursor in UndemoteOutgoingCallReceiverYorke Lee
Bug: 12179558 Change-Id: I2a991b981a76afdec0282936f63732c43652baea
2013-12-13am a6536611: am f427ab83: am ce150742: am dc372cc7: Merge "Add a content ↵Elliott Hughes
observer for voicemail to the call log fragment" * commit 'a65366114ad3b1014c22d8a84c74a94fb7f47139': Add a content observer for voicemail to the call log fragment
2013-12-13am dc372cc7: Merge "Add a content observer for voicemail to the call log ↵Elliott Hughes
fragment" * commit 'dc372cc7464e7869e6ca0caed6a81bd53e43a6e1': Add a content observer for voicemail to the call log fragment
2013-12-13Merge "Add a content observer for voicemail to the call log fragment"Elliott Hughes
2013-12-11Fix NPE in DialerDatabaseHelper for null phone numbersYorke Lee
Bug: 12006585 Change-Id: Iaed732806cbb8fb0301596162102e81ab8ec6024
2013-12-11Merge "Hide voice search button if intent cannot be handled"Yorke Lee
2013-12-09Remove private reference to TelephonyIntents.SECRET_CODE_ACTIONYorke Lee
Bug: 6948882 Change-Id: Id08daec677abddf1c1987ac3f41dbefe89a10144
2013-12-06Hide voice search button if intent cannot be handledYorke Lee
If the Google Search app is disabled (this only seems to be possible on Nexus 4), the Dialer crashes if the voice search button is pressed. This CL hides/shows the voice search button every time the dialer is launched/resumed after checking to see if there exists an activity that can handle the ACTION_RECOGNIZE_SPEECH intent. A string to indicate that voice search is unavailable is also added just in case the user ends up in a weird state where the button is showing but clicking on it would throw an ActivityNotFoundException. Bug: 12015318 Change-Id: Idd7ec2da422425dd95ae0060ebc9b85a2cf35fb0
2013-12-05Merge "Always call through to super.onBackPressed in DialtactsActivity"Yorke Lee
2013-12-05Merge "Catch ActivityNotFoundException in CallDetailActivity"Yorke Lee
2013-12-05Always call through to super.onBackPressed in DialtactsActivityYorke Lee
moveTaskToBack is causing crashes in the Dialer when the back button is pressed. This was legacy code that was unchanged in the new dialer. We should probably just call through to super.onBackPressed regardless of whether or not the task was at the top of the stack, to behave the same (navigation wise) as other apps. Bug: 12015851 Change-Id: Ic0c3efb30b3874ad892b96a9fadd524313cfb782
2013-12-05Merge "Temporarily stop UI refresh during drag and drop"Yorke Lee
2013-12-05Catch ActivityNotFoundException in CallDetailActivityYorke Lee
Bug: 12015287 Change-Id: I23b167e22d0da7f9be98b49e120b5b8ac1700e9a
2013-12-05Add null check in CallLogNotificationsServiceYorke Lee
Bug: 12015853 Change-Id: Ia2394f1ee0f102de4eab3f5468fd6204727b607d
2013-12-05Add a content observer for voicemail to the call log fragmentHUANG Menghuai
The voicemail status message was not updated with new voicemail status. Change-Id: I3430bb5c21d8b25c863ca1e74f48774012c961c8 Signed-off-by: HUANG Menghuai <menghuai.huang@orange.com>
2013-12-03Temporarily stop UI refresh during drag and dropYorke Lee
If the user is in the middle of a drag and drop operation, temporarily stop UI refreshes when a new cursor is delivered, to prevent UI inconsistencies. This CL only fixes the dragging/dropping case. Swiping is still buggy (the fix is more complicated/risky), and swiping might be removed altogether in the future. Bug: 11119329 Change-Id: I2939c915d4eb5d8f9de19a369b21c6c98806ba94
2013-12-02Merge "Remove ContactPrefs from DialpadFragment"Yorke Lee
2013-11-26Remove ContactPrefs from DialpadFragmentYorke Lee
DialpadFragment currently instantiates an instance of ContactsPrefs that is not needed. Change-Id: I8207f8d55c578a748c5edab1f722b18b5d38b48b
2013-11-25Merge "Remove use of hidden TelephonyManager methods"Yorke Lee
2013-11-25Merge "Fix Dialer tests"Yorke Lee
2013-11-22Remove use of hidden TelephonyManager methodsYorke Lee
Bug: 6948882 Change-Id: Ibce04c24e64fdb33fba532c0f0e5dca3b11f1b6c
2013-11-22Fix SmartDialNameMatcher NANP testYorke Lee
Statically initialize prefix logic to use NANP matching for NANP tests Bug: 10346442 Change-Id: Ia268de8a9bc5ad8dae70fe6934823a3c289f0bae
2013-11-22Fix Smart dialing testsYorke Lee
Test contacts were being created without unique contact ids and lookup keys, causing them to be mistakenly identified as duplicates. Bug: 10346442 Change-Id: I47fd5bdae83346b6b2f620d7abe49326b1cfd23d
2013-11-22Fix Dialer testsYorke Lee
* Empty geocode is now " " instead of "-" per UX request * DialpadFragment now throws IllegalArgumentException instead of Log.wtf so that it can be tested * Added contact id column to contactsprovider query * Modified PhoneNumberDisplayHelper to take an instance of PhoneNumberUtilsWrapper so that it can be mocked out Fix label-related tests that were failing due to a change in how we treat empty labels Bug: 9111164 Change-Id: If2244586b9d09fa2839fa0ddfc9f369f9dc66e51
2013-11-21Remove use of SystemPropertiesYorke Lee
Remove private reference to SystemProperties, needed for Verizon requirements (per team email discussion) Bug: 6948882 Change-Id: Idc826e4a93609799e3c741d36fca5124abbc5bb9
2013-11-20Merge "Fix ANR in UndemoteOutgoingCallReceiver"Yorke Lee
2013-11-19Fix ANR in UndemoteOutgoingCallReceiverYorke Lee
Querying the contacts provider for the contact id should happen in a new thread as well. Bug: 11773499 Change-Id: I715e7e9b4a650efbd708d4ad3793dad742b74a14
2013-11-20Merge "Switch convertAndStrip to normalizeNumber"Yorke Lee
2013-11-20Merge "Remove private references to isUriNumber and getUsernameFromUriNumber"Yorke Lee
2013-11-20Merge "Rename PhoneNumberHelper in Dialer"Yorke Lee
2013-11-19Switch convertAndStrip to normalizeNumberYorke Lee
normalizeNumber(to be renamed in the future) is a bit stricter about converting the number into a dialable one. Bug: 6948882 Change-Id: I09417822de714beb45664ca4f0916e40013a34bb
2013-11-19Remove private references to isUriNumber and getUsernameFromUriNumberYorke Lee
These methods in PhoneNumberUtils are pretty specific, so don't make them public APIs. Instead, use the methods already in PhoneNumberhelper. Bug: 6948882 Change-Id: I487593543eba526c64588d9a3e70b19b4ed941ab
2013-11-19Merge "Use single instance of PhoneNumberUtilsWrapper"Yorke Lee
2013-11-19Rename PhoneNumberHelper in DialerYorke Lee
Rename PhoneNumberHelper to more appropriate PhoneNumberDisplayHelper Change-Id: I2c03f5cbb04c1e03f1fc1e0051a1cea641160dca
2013-11-19Fix crash when number is nullJay Shrauner
Fix crash in various routines when the number is null. Bug:11766758 Change-Id: I3bcedbd8ada663a8c47528f32e213f653195fe57
2013-11-18am 3ec7f823: am 8b7de609: am 1ae0cf68: Fix possible NPE in DialerDatabaseHelperYorke Lee
* commit '3ec7f823c3ec0eedaf4044bd535411e59bcc820a': Fix possible NPE in DialerDatabaseHelper
2013-11-18Fix possible NPE in DialerDatabaseHelperYorke Lee
In certain cases (third party contact backup solutions?) it is possible for raw contacts to end up with null display names, which the Dialer was crashing on. This fix performs a null check and inserts the default (No name) contact name if we find that the display name is null. Bug: 11750613 Change-Id: Ifbaf2861534e6eaf8a86d50d584d11a9fa38b65f
2013-11-18Use single instance of PhoneNumberUtilsWrapperYorke Lee
PhoneNumberUtilsWrapper is creating a new instance of the class everytime it tries to look up an unknown number. Just use a single instance for this instead to avoid redundant object creation. Change-Id: I418d95ced42c1db06c63848768050a181defb347
2013-11-13am a70f4547: am 43744cc2: am 349f3e1b: Merge "Color/layout tweaks for ↵Yorke Lee
Dialer" into klp-dev * commit 'a70f45478c1ff89a85d29dfda95e6082d67a4816': Color/layout tweaks for Dialer
2013-11-13am b48e4549: am 550e61cf: am 59a39432: Merge "Change all contacts button to ↵Yorke Lee
look like list item" into klp-dev * commit 'b48e45496dd75bb7de73327a5a238dc8e19dc91d': Change all contacts button to look like list item
2013-11-14Merge "Color/layout tweaks for Dialer" into klp-devYorke Lee
2013-11-14Merge "Change all contacts button to look like list item" into klp-devYorke Lee
2013-11-13Color/layout tweaks for DialerYorke Lee
Add search icon into search box Change background of recent cards shortcut to whiter one Whiten the action bar Darken background color of list items Reduce size of searchview text Bug: 11654293 Change-Id: I204b14e752b40563a6f7ebdd1d61f10854b41100
2013-11-13Change all contacts button to look like list itemYorke Lee
Rewrite layout of all contacts button to look like a regular contact list item. Update list default avatar background Bug: 11654293 Bug: 11668831 Change-Id: Iafa8f69e618b39eabf823cafd8153ed24ddbdfbd
2013-11-13am 1cc54f02: am f9d19153: am 759c264e: Merge "Dismiss dialpad when user ↵Chiao Cheng
touches spaces above it." into klp-dev * commit '1cc54f025ca77481f5346042a7eb107111158fc8': Dismiss dialpad when user touches spaces above it.
2013-11-13Merge "Dismiss dialpad when user touches spaces above it." into klp-devChiao Cheng
2013-11-12Dismiss dialpad when user touches spaces above it.Chiao Cheng
Only applies if the user has not input any digits yet. Bug: 11648799 Change-Id: I28a57fcd7eae0faaf5e234e9ec7531140903e2f5
2013-11-12am 86666e28: am 8e578cfe: am c3cb63b6: Merge "Fix possible FragmentManager ↵Yorke Lee
NPE in Dialer" into klp-dev * commit '86666e2852262162f5ba101b9ab054f981777ef1': Fix possible FragmentManager NPE in Dialer
2013-11-12Merge "Fix possible FragmentManager NPE in Dialer" into klp-devYorke Lee
2013-11-08am c51392d7: am a5b38196: am d20f843e: Merge "Treat unknown call types as ↵Yorke Lee
missed calls" into klp-dev * commit 'c51392d773e77376f182781bb2405a5043809fda': Treat unknown call types as missed calls
2013-11-08Merge "Treat unknown call types as missed calls" into klp-devYorke Lee
2013-11-08Treat unknown call types as missed callsYorke Lee
Don't crash on unknown call types. Instead, just treat them as missed calls. Bug: 11586034 Change-Id: I4ca1721e1526ade36237251e7636d161ca8490be
2013-11-08Fix possible FragmentManager NPE in DialerYorke Lee
Bug: 11595442 Change-Id: I7859f61bf8b5eb6b6e14d5f18cf689613124ce6c
2013-11-08am c317b836: am 967e0ed3: am cce501cb: Fix bug where resuming ↵Yorke Lee
CallDetailActivity loses the add contact intent * commit 'c317b8363d2369b4651fc4d88fa8c711f45ab23b': Fix bug where resuming CallDetailActivity loses the add contact intent
2013-11-08Fix bug where resuming CallDetailActivity loses the add contact intentYorke Lee
getLoaderManager.initLoader() performs the onLoadFinish callback immediately if CallDetailActivity is being resumed from a previously paused state. This causes bindContactPhotoAction to be called with a null intent later on causing the add contact button to be no longer clickable. To fix this, if we know that we will receive a loader call back that correctly binds the intent later on (or immediately), we should skip the initial bind. Bug: 11588776 Change-Id: I9407a88ec8bbde303109eb14496e01cf6c347c8f
2013-11-06am 256ff69b: am 05a28a4b: am b7126bf1: Merge "Load contact in ↵Yorke Lee
CallDetailActivity and add it to Add contact intent" into klp-dev * commit '256ff69b81dd538c8ec82a33036ca655fe8ab43c': Load contact in CallDetailActivity and add it to Add contact intent
2013-11-06Merge "Load contact in CallDetailActivity and add it to Add contact intent" ↵Yorke Lee
into klp-dev
2013-11-05Load contact in CallDetailActivity and add it to Add contact intentYorke Lee
Use a ContactLoader to load the contact data stored in the json-encoded URI asynchronously, and prepopulate the add contact intent with the contact data when the contact data is loaded. This fixes the problem of contact details (i.e. name, photo, address) not being pre-populated when adding a contact via a call log entry that was created by calling a contact from nearby places search. Bug: 11294679 Change-Id: I39a0d8ae40e80b350687a43be8ece6b32c88062a
2013-11-01am 6c97009c: am b911519f: am 16016d95: Add null check in ↵Yorke Lee
SmartDialCursorLoader.releaseResources * commit '6c97009c9fe8ea610717afb93ca2fafaff0bc261': Add null check in SmartDialCursorLoader.releaseResources
2013-11-01Add null check in SmartDialCursorLoader.releaseResourcesYorke Lee
Bug: 11474252 Change-Id: Id5a64aa72790bddef9e8fd2d4661635bd2eb6f44