Age | Commit message (Collapse) | Author |
|
|
|
Telephony provides an API to send secret code broadcast in a
bgcheck-compliant way. The dialer app moves to this new API to
pass O bg-restriction check.
Bug:33753947
Test: Manual
Change-Id: Ib2c623d7d87a7581ae5898d6181c100fac3f12f6
|
|
am: c1bd6a1959 am: d0f276eb48
am: 8f2f4ad42d
Change-Id: I4fc6620da406f18f24900c8ec431fc413ae96eaf
|
|
By making the notification noisy a missed call will trigger
the pulsing of the notification LED.
Currently there is nothing that indicates that a user missed
a call when the display is off.
Bug: 34696338
Test: Call the device, miss the call, confirm LED is pulsing.
Change-Id: Ic0d3831bc847d9189a7318ded9e0b1a2869c25e4
|
|
am: 2c0f8284ce
Change-Id: I80458edc11a4d2833304898fa2dab413cab8d6bc
|
|
Fixed two typos in the comment section
Change-Id: If48c628648c388e5c2906b2922e1a2d514d9576a
Signed-off-by: alazar <alshenkute@gmail.com>
|
|
d1be0b9328 am: 4fb68ffaa1
am: cbe0b39ab3
Change-Id: I911ba292fd8bd9347dfe47b2681f91f0703d1252
|
|
am: d1be0b9328
Change-Id: I758fb90c7dac1ae50abfe29578b818279687772a
|
|
Added check whether DialtactActivity is in search mode or not.
Change-Id: I621a9f6b2a419a3cfaa0f2e3e117b41143cdcce8
|
|
am: aef5e7f1d2
Change-Id: Id2d331432d296cc79f4ea3e5e2861c9712c75ec4
|
|
am: 11bdbcaeb4
Change-Id: I283d7c1c371143bcf59b7746d01cfa95a83668c9
|
|
Names in Korean, Japanese, and Chinese are sorted and displayed by
family name. Because of this, we shouldn't show the "Display Options"
setting if the device is set for these locales. Other logic in the code
will ignore the user set preferences anyway.
Bug:30782253
Change-Id: I15ff7328609aea937940fc60c43e6f0c8dfdb5d2
|
|
am: b825046c97
Change-Id: I487b07a1bf1f87bc891de8b7e778bf7e7e14807f
|
|
am: a1e500b29a
Change-Id: I7d7ced10ae11b019841d0fe681a4ea53b45dce07
|
|
In the event that the PhoneAccountHandle is null, do not pass in null as
the account handle, instead use the handleMmi string that only takes the
dialString.
This change seems to have taken place in
http://ag/#/c/838273/11/src/com/android/dialer/util/TelecomUtil.java
Fixing that with this CL
Bug:31165762
Bug:29443147
Change-Id: Idc174639c48ab3c01ad5bde340272a8ec55d6ab1
(cherry picked from commit f9163d84e77a5287c16c679a946c3a8f934350d1)
|
|
am: ea87c66828
Change-Id: Iea0dd16f2ff98d3f34b4876d7b314251c5c1d883
|
|
am: d0ce6136fe
Change-Id: I3877801c200806adc15e559f4fc4514bc573dcef
|
|
Cherry pick to reflect code changes. The dialer in system image
is using //vendor/unbundled_google/packages/PrebuiltGoogleDialer
This was missed because it was not using ContactCommon compat library but
directly using Build.VERSION.CODENAME.
No other instances of Build.VERSION.CODENAME are found.
Bug: 29420691
Change-Id: Ia01a0aa1d95014da4abc2873a67cc0905fe8eb5f
|
|
am: eb66b0feee am: 097cb40f76
am: 73849c7b25
* commit '73849c7b25defd1af84e95dd61fa7ba3b0861f02':
Fix bug where a starred contact couldn't be removed
Change-Id: I6f1cf92c1ff2e33d3d576f794608f89d6c16bb92
|
|
am: eb66b0feee
am: 097cb40f76
* commit '097cb40f768cbd997fb2a27d4810255cb5b3a554':
Fix bug where a starred contact couldn't be removed
Change-Id: I8cf6be341c3fa5e64629d1ae202cdfc88e1057f7
|
|
am: eb66b0feee
* commit 'eb66b0feeeefd4e6362f0b5063978a6c057606f5':
Fix bug where a starred contact couldn't be removed
Change-Id: I12a76d5dc73101bec87a05d3fab04f6d0be664a6
|
|
|
|
am: 30371b9022
* commit '30371b9022d0b3740c74523208a9126b9890dab4':
Fix missed call notification dialing wrong number
Change-Id: Ic234f26998193e848c80f9763f585f7de36050e3
|
|
Removing a starred contact was broken on NYC. The problem was that the
code assumed ACTION_DRAG_STARTED had coordinates that were view
relative. On NYC the coordinates were window relative.
This is a cherry pick of http://cl/122480283 and http://cl/123125613
Bug: 29074238
Change-Id: Ib090c6240ed65e4333ad63b3ab4f8b4744181b13
(cherry picked from commit 198074d959385599e952656d0a1b2a306f54e56f)
|
|
This CL fixes a bug where clicking the "callback" button on the missed
call notification would dial the previous missed call.
To reproduce the bug you had to do the following:
- get a missed call from Party A
- clear the missed call count by launching dialer and navigating to
the call log then pressing home. Clearing the missed call count by
swipping away the notification should also work.
- get a missed call from Party B
- click "callback" on the new missed call notification Previously
this would result in Party A getting called back.
The problem was that we were using the wrong pending intent flags:
- Flag 0: before ag/925201 we were using 0 which meant that the pending
intent with Party A was being used.
- FLAG_ONE_SHOT: after ag/925201 we were using FLAG_ONE_SHOT which
meant that the pending intent would be cancelled after the first use
(after the user clicked callback on Party A). If the user never
clicked callback on Party A then the intent would be re-used.
Fix was to use FLAG_UPDATE_CURRENT instead. This ensured that the
pending intent was always updated with the last missed call number.
Bug: 29065901
Change-Id: I8515e82d178348235d775b7a110e662652b3385b
(cherry picked from commit e5b24ecbe50bd79d2ce7ad8a284ac17ad1284d83)
|
|
This CL fixes a bug where clicking the "callback" button on the missed
call notification would dial the previous missed call.
To reproduce the bug you had to do the following:
- get a missed call from Party A
- clear the missed call count by launching dialer and navigating to
the call log then pressing home. Clearing the missed call count by
swipping away the notification should also work.
- get a missed call from Party B
- click "callback" on the new missed call notification Previously
this would result in Party A getting called back.
The problem was that we were using the wrong pending intent flags:
- Flag 0: before ag/925201 we were using 0 which meant that the pending
intent with Party A was being used.
- FLAG_ONE_SHOT: after ag/925201 we were using FLAG_ONE_SHOT which
meant that the pending intent would be cancelled after the first use
(after the user clicked callback on Party A). If the user never
clicked callback on Party A then the intent would be re-used.
Fix was to use FLAG_UPDATE_CURRENT instead. This ensured that the
pending intent was always updated with the last missed call number.
Bug: 29065901
Change-Id: I8515e82d178348235d775b7a110e662652b3385b
|
|
am: 775071cc0d
* commit '775071cc0d03aa35cc5e34f504a052bf31b0627f':
Fix the bug that quick contact cannot be removed.
Change-Id: I20891ddc85bbcabaf1ef64628578ad38cc2d0351
|
|
am: 0065720a97
* commit '0065720a974377d8139679528f2e3e5c076e91b7':
Fix the bug that quick contact cannot be removed.
Change-Id: I6eb457f4e634254e05a582d5b88a80885c4005b6
|
|
The "removed" button doesn't received drag and drop event since it's not
visible at the time the drag event starts. The workaround is to change
the visibility of its child view instead.
Change-Id: Iada912fcc36983ad758296f33092cc54ad6f9f5e
Fix: 28479593
(cherry-picked from b20b76437ae6aae8fe4da64097351cc80f030919)
(cherry picked from commit 22a193b7babae99256149a0536748c6ad9c6b943)
|
|
One more place needed to be updated in master.
|
|
[This is a manual cherry pick from ub-contactsdialer-b-dev.]
This CL tracks latency for all incoming and outgoing calls. We now
measure the following latency values:
- time for a connection service to add a call to telecom.
- time for telecom to process a call
- time for the dialer app to launch and have a call added to it by telecom.
- time for dialer to check if a call should be blocked.
- time to show a notification about the call (incoming only)
- time it took to show the InCallUI (only if HUN wasn't displayed)
Change-Id: I08685d312cbaefc564feb4119350da71df9b9e6c
|
|
am: 91e928cffb
* commit '91e928cffb0ac82849dd89e7251e04dbb3b9a697':
Cache call type icons
Change-Id: I2229d2c103ae0da8bbcf194ac328f28d193be055
|
|
am: e5634164a0
* commit 'e5634164a0e89568cd79868e6bdcbc5610dc78ea':
Cache call type icons
Change-Id: I7cf4a33a18de4734075c3ba33c8752c5a81f03bf
|
|
|
|
nyc-dev am: 235d706 am: 859b425
am: 535bd2d
* commit '535bd2d98926e96dbced8fee8a371e8c9acf0b2c':
Performing auto-migration when there are no blocked nums
Change-Id: I028a710db5cb2e02eaa1dcc385327aa74506f8ff
|
|
fd95466 am: 5fffba0
am: e27b1da
* commit 'e27b1da7a4c4b3bfc1a22d0aa1db4c32c24ea478':
Adding migrate promo to blocked numbers setting ui
Change-Id: I1871490040968ee816d30885db225cde78b05ade
|
|
am: 71f6781
* commit '71f6781457dc388aca7f8443f6cad511fa8fc8a9':
Call correct number from missing call notification.
Change-Id: Ic0c2373af8223b7e80a98a53fc2059929945a4bb
|
|
am: 235d706
* commit '235d706e4aeba527c52c3cb13760791fe6380b37':
Performing auto-migration when there are no blocked nums
Change-Id: I470a2d25b69c38482ad72209e180fe91d424c94f
|
|
am: fd95466
* commit 'fd95466779e0a25c5d8de9a71ba1fc6c059ed7b8':
Adding migrate promo to blocked numbers setting ui
Change-Id: Iee5405b3a5497dbd1ff02922137b87d47bb098d0
|
|
|
|
|
|
The previous behavior was such that users that had no numbers in the
Dialer block list still had to go through steps to migrate to the
framework blocking solution, even though there was nothing to
migrate. This changes add logic to check if the blocked list is
empty, if that's the cause the user is automatically switched to the
framework blocking solution. This check is performed only once on app
startup.
Fixes: 27704106
Change-Id: I32482003279ef2070c1ebd8b801acf637c48ba8c
(cherry picked from commit ee4e15b40f0d20b5f04f3569efa12c0d26a38645)
|
|
Change-Id: I97c8214e620378dd32f3778040f2f2b3e1cd58f0
Fix: 28068914
(cherry picked from commit 217b96bd8ccc6874d14a1be84d639ee2d9ba1802)
|
|
Looking at the trace attached to b/28142787 it looks like
CallTypeIconsView.Resources is created frequently. In my local testing
with 9 items in my call log, it was created 23 times on load and 3 more
times on scroll.
According to the trace, creating a Resources object can be expensive.
In one frame decodeBitmap was called 3 times and took 1.4 milliseconds.
This CL works around the issue by caching the Resources object. This
should be ok. The only downside of this is:
- the cache won't be updated if the DPI variant changes
- the cache won't be released if we get a memory pressure event
Bug: 28142787
Change-Id: Ibc2ef02f7c92022deabedd70b1af135a10c9df29
(cherry picked from commit 341185547f9d54566055b270f69f1b93f0301c36)
|
|
This Migrate promo is shown so users have a way to migrate to the
framework blocking solution, directly from the settings. Previously,
users would have had to block a number to be presented with the
migration dialog.
UI: http://screen/GS8TdfKrnVv
Button Pressed: http://screen/ovd6NgVmOqq
Change-Id: I9c04b8afdf7c5681e09c02c7a4f6013c94b396d9
Fixes:27703938
(cherry picked from commit 3db9bde34452552973acefad5535a2273e9968fe)
|
|
+Add IntDef which contains all the possible locations numbers can be
reported as spam or not spam from.
+Updated method calls to include location
BUG=27323295
Change-Id: I549e439af328447fbbf0c61116cdff9b1b877334
|
|
+Put all the dialog creation code in one place so they can be re-used
+This is mainly for the after call notification because the same dialogs
will be shown in an invisible activity
+Create listener for determining whether a user checked the spam
checkbox
+Change to DialogFragments for easy reusing of dialogs
Change-Id: I67e13bc0e61952299a4770c9184543ef8b63728a
|
|
+Check if app has CONTACTS permission before querying contacts database
Fixes: 27977009
Change-Id: If6ed7c31b6a94383d1d3a6a888520b6ed400b037
|
|
|
|
+Add asynchronous call to update inCallHistory boolean variable which
specifies whether the number is in the call history (has previously
called before)
+Add CallHistoryStatus enum and variable to Call object to determine if
the number is present in the call history
+Added SpamCallListListener object which listens for changes in the
CallList
+Update the CallHistoryStatus for the call whenever an incoming call
comes in
+Added 11 tests for new listener
BUG=27323295
Change-Id: I242cd4a53b3aeca69fbce972221a2c941d9d37ce
|
|
Change-Id: I9daa0fd75fdeb201f5d7973a1431579ec7251bf7
Fix: 28068914
|
|
|
|
* Don't add spam related action menu to call log.
Change-Id: Id32a7e0e0819c780bcb60e917ea6f4a4d19394c9
|
|
|
|
|
|
* All funtion in ExtendedBlockingButtonRenderer has been migrated into
CallLogAdapter and CallLogListItemViewHolder.
Bug: 27655063
Change-Id: I74bf2a2b3207ea3ee07b557bce97a4ae70ea0cbf
|
|
+Revert ag/904832 and add proper fix
+ag/904832 was an incorrect fix for the bug because the
isBlockedNumber method in FilteredNumberAsyncQueryHandler is not
supposed to call onCheckComplete on the listener if the number was
invalid. All callers of the method isBlockedNumber must, in addition to
checking if the result was invalid in the callback, also check the
result of the call to see if it was false.
+This change removes the callback call if the number is invalid and
instead adds a check in CallLogAdapter right after isBlockedNumber is
called to determine if the number was valid. If not, the views are
rendered.
Change-Id: Ib4eaafd38c28afb8acacd94fd6716c4042286968
|
|
am: 8607dfb
* commit '8607dfb43c2707ca534d68f2dcf728fece01c82b':
Add via number to CallLog Account entry
Change-Id: I55e9f40fb5497a4edeec31fc0abeb2efd459f1a2
|
|
am: 87b9abf
* commit '87b9abf1fe4d480e15b2af03876003e6b8808b84':
Add via number to CallLog Account entry
Change-Id: I36077470df4217ffd623be6eca3f48fb413c5bf2
|
|
Call Log now provides the phone number that an incoming call was
received on if that number is different than the SIM subscription
number. This "via number" is appended to the Phone Account of the Call
Log entry in Dialer if it exists.
Screenshots:
- One PhoneAccount: http://screen/HuCSL0U6jU6.png
- Multiple PhoneAccounts: http://screen/pDg8F9zpMei.png
Bug: 25594198
Change-Id: I8c05ea98409e54d20493fbdb20096bf851480719
|
|
Screenshots:
1. block/report spam
https://screenshot.googleplex.com/5e772Kikikw
2. block
https://screenshot.googleplex.com/AEpYSYoL2E8
3. unblock(is spam and report not a spam)
https://screenshot.googleplex.com/AEZfhCXj4h8
4. unblock(not spam)
https://screenshot.googleplex.com/r7YkHuCMT1p
5. report not spam
https://screenshot.googleplex.com/jkcpm0pdKoj
Change-Id: I78fbbacece44632614026c03909289995bef5b14
Fix: 27295785
|
|
Before this fix, the isBlockedNumber method was returning false without
calling the listener/callback. This caused the CallLogAdapter to not
render items where the call was from an unknown or private number. This
fixes the issue by calling the listener.
Change-Id: I6283a71db872ef62586faacaf18d37ed368b492f
|
|
+Pass callType to ExtendedBlockingButtonRenderer so that when the user
reports a number as spam or not spam, the type of call (missed,
voicemail, etc.) is passed to the clearcut log
BUG=27323803
Change-Id: I5d3493d3d4212affc3e64e0f499143085baf0ec5
|
|
+ Add block and report spam actions.
+ Show spam icon and label for call log item.
+ Add stableIds for CallLogAdapter to improve performance(reuse same
viewItem to minimize update work).
* Fix funky UI of call log.
Change-Id: I6144d70b6a8e38061e1447d0d01910d53026d1db
Fix: 27295728
Fix: 26907466
|
|
+Remove line that was removed by ag/874074 and added back in by
ag/886674.
Change-Id: I8f501655356ccf5ff605a0eb705ec38e1ded9025
|
|
am: 758ba19
* commit '758ba199a0a2bce7c69bfcc751bb16138bb6e609':
[DO NOT MERGE] Fix Dialer crash loop for caller id in personal contact directory
Change-Id: Id4b9f738f6ed57d5c5e76c17a6db427c24ff985c
|
|
The bug is dialer queries CP2 for alternative name by lookup key of personal directory
CP2 throws IllegalArgumentException as the lookup key is not found locally
2 fixes are included to avoid this happening
1. slient IllegalArgumentException since alternative name is not very important to crash dialer.
(It's a fix by reverting some changes in ag/880910)
2. Check directory id before querying CP2
either one should fix this bug. Include both to make sure that it's not crashed.
Unit test added.
Bug:27905000
Change-Id: Ib8eab5f718a168fcec2785c3101e96bb91521d40
|
|
The bug is dialer queries CP2 for alternative name by lookup key of personal directory
CP2 throws IllegalArgumentException as the lookup key is not found locally
slient IllegalArgumentException since alternative name is not very important to crash dialer.
(It's a fix by reverting some changes in ag/880910)
Bug:27905000
Change-Id: I1d61f52df63d93c9c7da436c7f2da2bdf3cced0c
|
|
+ Add spam icon and label in notification of incoming call.
+ Add spam icon and label in primary call info of incall screen.
+ Change background color and status bar color if primary caller is spam.
Screenshots:
https://screenshot.googleplex.com/WFob2oPdXZd
https://screenshot.googleplex.com/ddCfg91Anef
Bug: 27611253
Change-Id: I03b3754f69631f5f6b07932b1a0006407b93c6e8
|
|
am: 1d57c63
* commit '1d57c63c9a4079460098bb04b7910d93e089e86f':
Updating blocked number dialog ui
|
|
am: 4ddabae
* commit '4ddabae31883749c26d200c8f679615a4fced3b9':
Updating blocked number dialog ui
|
|
+ Small fix for the blocked number dialog to match mocks. See related
bug.
Change-Id: I3082cb46adb780aaa96e7d3ccd5a19688cc1845c
Fixes: 27703247
|
|
am: 0a9d3be
* commit '0a9d3be7e92dce46dffeaedb1e6aefc163122bfc':
Update number blocking strings
|
|
am: 47af919
* commit '47af91907bc39b7b94173cc14809b932f516b1a2':
Clear voicemail status text when loading succeeded
|
|
+ No message string for unblocking, same as new filtering.
+ String for blocking with new filtering
Fixes:27703247
Change-Id: I4622d9223e03e3c3f207da581ce5b28ee4aa2b42
(cherry picked from commit f0f07d585c95d2bda8a59e9dcffdb687cb21c0fa)
|
|
In ag/874775, mStateText.setText(null) is removed from
VoicemailPlaybackLayout#setClipPosition(). This caused the error in
mStateText not to be cleared after the voicemail is sucessfully loaded.
This CL adds a setSuccess() method to the layout that clears the message,
which will be called from onPrepared() once the voicemail is loaded.
Fixes:27770842
Change-Id: Ic42e40b99d36f817532dec780b63311c1967300c
(cherry picked from commit f35cf6c6311aa253d679f61b8fd43babce4a90c3)
|
|
|
|
am: 5e530f2
am: 0790a2a
* commit '0790a2abada4a69413a3ed48deab6b7781e8db08':
Hide import number settings in Blocked Management UI
|
|
+ No message string for unblocking, same as new filtering.
+ String for blocking with new filtering
Fixes:27703247
Change-Id: I4622d9223e03e3c3f207da581ce5b28ee4aa2b42
|
|
am: 5e530f2
* commit '5e530f2d469cae13347a666fd9fe9d214d9e30b4':
Hide import number settings in Blocked Management UI
|
|
|
|
|
|
cf230a9
am: 6dd6151
* commit '6dd61510f2c019a8c662257e368568bb93e9d9e0':
No notification shown for blocking after E911 call
|
|
am: 9877f59
* commit '9877f59d3c4af34bedbbd27e45d00efa0ccb0b6a':
Updating logic for isBlockedNumber
|
|
am: cf230a9
* commit 'cf230a91080dcfddb82fe4a42c401d77e6ae9bca':
No notification shown for blocking after E911 call
|
|
am: fd75e4c
* commit 'fd75e4c3b3c1a8f5a6ee5d3ce6a8503cf83ea424':
Updating logic for isBlockedNumber
|
|
|
|
In ag/874775, mStateText.setText(null) is removed from
VoicemailPlaybackLayout#setClipPosition(). This caused the error in
mStateText not to be cleared after the voicemail is sucessfully loaded.
This CL adds a setSuccess() method to the layout that clears the message,
which will be called from onPrepared() once the voicemail is loaded.
Fixes:27770842
Change-Id: Ic42e40b99d36f817532dec780b63311c1967300c
|
|
The Dialer is no longer responsible for showing a notification that
call blocking is disabled after the user makes an emergency call.
This CL ensures that the notification isn't shown.
Change-Id: Ib87679a067831b771d99e5b2b205c84101f05fef
Fixes: 27705312
|
|
+ When new filtering is possible, we should hide the import number
settings from the blocked numbers management UI.
Bug:27705124
Change-Id: I59bf958540482fe4d1aa620e4a4bc60fdc479778
|
|
|
|
am: ecacd03
* commit 'ecacd03b1dc86afadecdf99ef3a11a09e4a38888':
Checking for blocked number after migrating
|
|
Merge in ag/886674 was done incorrectly on CallLogAdapter.
This CL revert the changes.
Change-Id: I1779c205f9be8250acd5a4455608b857c6198663
|
|
In the framework blocking, both the e164 and non-e164 formats of a
number can be blocked at the same time; these two formats will still
have the same e164 value. Since the original code expected the e164
column to be unique, in this situation the Dialer thought the number
was not blocked, resulting in a crash when attempting to block the
number a second time.
This CL changes the logic so multiple rows with the same e164 value
are expected.
Change-Id: I90995046df74b8ec2198eab1ef56a13f20dc1398
Fixes: 27724726
|
|
am: ac6cd58
* commit 'ac6cd58c8642d22e47a6d4b30295137a61177e85':
Checking for blocked number after migrating
|
|
+ There's an edge case crash in the Dialer when initiating the
migration workflow. If the user has blocked a number in the framework
prior to migrating the Dialer and then attempts to block that number
again in the Dialer, the migration workflow starts, completes, and
then the app crashes. This is because prior to migrating, the Dialer
doesn't know that the number is blocked in the framework, allowing it
to block the same number twice.
+ Since this case is specific to the situation where an already
blocked number initiates migration, this CL fixes the problem by
checking if the number is blocked in the framework, prior to blocking
it after the migration.
Change-Id: I31c8978afb871f364e63cab5cc6da3e5fd106b29
Fixes: 27720157
|
|
am: 25b094b
* commit '25b094b0473bb52238d7d45d4ba69b0d9949121c':
Only allow primary users to block numbers
|
|
am: c98a563
* commit 'c98a56336fd49a8c5ea2834a141627d3cf0d8d6d':
Only allow primary users to block numbers
|
|
+ By design, only the primary user has the capability to block
numbers.
+ This CL ensures that secondary users don't see the option to block
numbers in the call log or call details.
Change-Id: I576925510cfbef417c16910218014d9f7b7dd2a0
Fixes: 27366206
|
|
am: c0b805e
* commit 'c0b805e68c960ff7af4a25dff8b95eb2c620f22f':
Rename provider authority for AOSP Dialer
|