| Age | Commit message (Collapse) | Author |
|---|
|
It can be confusing to show the "smartdial" string converting chars
to digits, so only show the actions in a potential vanity-scenario.
Bug: 20699894
Change-Id: I4df5e94841c519cc591d1d5333d48efa739124e7
|
|
|
|
+ Change the icon/behavior depending on the tab position.
+ Move current tab position logic from DialtactsActivity into the
lists fragment.
- Delete unused method, shift some helpers around.
Bug: 19366434
Change-Id: I6da767300907b3afd006248afb882bebde7bdfe6
|
|
|
|
This reverts commit d10eef28fc67aea0e4f4f49813b802ce1df5f7c7.
Change-Id: I0867f991c071fc55d1eadf611386b713c910d17f
|
|
+ Add new VIEW_TYPE to the CallLogAdapter.
+ Reintroduce boolean on CallLogAdapter to specify if a call history
list item should be shown.
+ Add new ViewHolder and layout for footer.
+ Some minor styling tweaks and cleanups.
Bug: 20108202
Change-Id: Ie4a86bff9e53cfd69ef8b061af048f40f4358579
|
|
I'm not sure if anyone else is seeing this, but this change didn't
seem like it would be harmful to make. I was running into sadness
because mListsFragment was undefined.
Change-Id: I75712c2cb3626002372ac9b4812c44c2ed74c12f
|
|
When determining whether to notify for a particular voicemail, check the
voicemail IDs instead of the whole URI since sometimes the URI will
include query parameters and sometimes not so we don't want to do a
direct string comparison. Doing a direct comparison was causing a bug
where the sound and vibration of the new notification would be suppressed.
Bug: 19716109
Change-Id: I7a33b4d3bcd9ca707db9462fcebfec27fd5f8a74
|
|
Bug: 20348183
Change-Id: If1b193f933b4a7b2b322784b0cbbc66c210b25df
|
|
- Some minor cleanup and refactoring.
Bug: 20393675
Change-Id: I438a9ca222cac87c9323417a216453706393c190
|
|
Bug: 20421404
Change-Id: Icc8b4a74ea17e969577dbaaa794b85a2e66ef8df
|
|
Bug: 20348316
Change-Id: I066e6b93c63e09850ef2234dd5c724e44594aaf8
|
|
Change-Id: I3ad2277b4822d219bd53b35914befb4a4d52b45b
|
|
|
|
This isn't the prettiest thing ever, but with this the "framework" of
all of the changes for the new visual style of the call logs is in
place. From here on out, the remainder of tasks should be unblocked
and relatively independent.
+ Rename ...ItemViews to ...ItemViewHolder. This probably wasn't
completely necessary, but is more proper given the new architecture.
+ ViewHolder is now officially where most of the independent UI logic
for a single call log list item should live. This changelist moves
further in that direction by storing references and helpers in it, to
lessen what must be passed in from the adapter.
+ Split out the call action from the rest of the actions, since it
has a special treatment on the card.
+ Convert text action buttons into a vertical stack.
+ Consolidate action stylings into a single style, for simplicity.
+ Miscellaneous style and string changes to put things in a better
state. This included tweaking some of the (ripple) backgrounds.
+ Update tests, according to changes.
Bug: 19372817
Change-Id: Ic923c0bcbbc1c153952131d0c772df9e9589fb03
|
|
Bug: 20223485
Change-Id: Iaa8f140746d1266febfcacf0f007ef2b4ebba968
|
|
|
|
Bug: 20224972
Change-Id: If7f1bde0229044f60bc889b380bc3e49e043e3ff
|
|
Bug: 20160799
Change-Id: I667fb47cf261703af817a6a16405bcf56f2bf0f7
|
|
|
|
+ Added card view dependencies to makefile.
+ Convert call log list items to use card views.
+ Cleaned up code style and unused views in fragment xml.
- Removed deprecated expand code (more work to be done here).
- Removed now-unused constants.
Bug: 19372817
Change-Id: I237cf214f8f052de5fb1f41908d6012f52de994e
|
|
Change-Id: I79fa0e84dc5ba0f2f9282cd4b209c2022d740b8d
|
|
|
|
Yay, finally!
+ Replace ListView with RecyclerView in layout and fragment files.
+ Change GroupingListAdapter to extend RecyclerView.Adapter instead
of BaseAdapter.
+ Change CallLogListItemViews to extend RecyclerView.ViewHolder.
+ Adapt onBindViewHolder and onCreateViewHolder methods in the
CallLogAdapter.
+ Update/rework tests for related classes.
+ Fix a bug in the GroupingListAdapter, where childCount was not
updated for standalone views, and the previously cached group size
was used instead. Set childCount to 1 for standalone views.
- Removed the idea of creating different views for standalone vs
group vs group headers from the adapters. This logic has not been
used for quite some time and all these functions funneled into
createView/bindView methods anyways, so there is no logical
difference. If we need to create custom views in the future, we can
leverage onCreateViewHolder's viewType parameter.
Bug: 19372817
Change-Id: I1b7289340600609669db22d8bc89265240d0b561
|
|
|
|
|
|
Switch to getPhoneTtsSpannable
Bug:
Change-Id: I1024aea2a766f6ac284bc5207c0e32c29c0cb72f
|
|
- Remove custom testing method formerly in the adapter.
- Remove unused expand animate code.
Bug: 19372817
Change-Id: I78489d63ac9c3324cd80f8039d14a41813772e11
|
|
This depends on ListView footer functions, but the Call Log is being
migrated to the RecyclerView. This view will be added back later,
with that work tracked in b/20108202 in scope of M.
Bug: 20108202
Bug: 19372817
Change-Id: I55201e068362083bf5c18ebd08c2e57c97c1b827
|
|
|
|
Don't rely on setting the empty list on the ListView for controlling
visibility of the list view and empty view. Save the reference and
control this in the call log fragment.
This removes a dependency on ListView-specific functionality which
is not found in the RecyclerView.
Bug: 19372817
Change-Id: I0a7e2e2366e258013ddbe30bd2ee7efb38349421
|
|
+ Copied in from com.android.common.widget. This component is pretty
specific to phone number / call log grouping anyways.
+ Changed CallLogAdapter to reference this GroupingListAdapter
instead of the one in the framework library.
+ Changed CallLogGroupBuilder to reference this adapter too.
+ Copy in tests too.
Next step: change GroupingListAdapter to extend RecyclerView.Adapter.
This will preserve existing grouping logic, despite switching to the
new view.
Bug: 19372817
Change-Id: Ic0186ca5fad06a3ae398b9d8f8006210077149dc
|
|
- Remove animation logic in CallLogFragment.
- Remove expand listener from CallLogAdapter.
+ Update tests and constructor.
This preemptively removes expand/collapse behavior. While this
will result in a janky short-term experience, this is an incremental
step in shifting to RecyclerView and the new "Card" UI. I figured it
would be most efficient to delete it straight up, rather than coding
in intermediate logic to work with the RecyclerView because it will be
made obsolete by the Cards UI anyways.
In the long run, expand/collapse animation behavior will be
restored once the call log is migrated to RecyclerView and converted
to Cards.
Bug: 19372817
Change-Id: Icbdc7dcb9f2f2223456c29334c826d38917b087a
|
|
|
|
Bug:20064573
Change-Id: If528b7a06a9e5d1452cfbd99c6e11d7ce390038c
|
|
|
|
This was implemented formerly to prevent a crash on rotation, but
this can be done by specifying that the Report fragment should be
retained in GoogleDialer.
This means that the fragment will not be retained now if the activity
is killed off by the system, but I think this should be okay since
it is a dialog.
Bug: 19949319
Change-Id: If3ebca4625fce93d9d9ce3c9bde6d92729f21c40
|
|
|
|
- Change made in partner CL introduced a regression in dialing from
the search results:
https://partner-android-review.googlesource.com/#/c/206297/
The problem with that change is that it was intended to ensure that the +
was not stripped off when dialing from the dial pad. It had the
unintential impact of rendering direct dial from the search box inoperative.
since mAddToContactNumber was null in this case.
Bug: 20068746
Change-Id: Ic3a75ccf00164e7c865cc633a6a16d1699227ed2
|
|
This pulls code from the CallLogAdapter, with only tweaks to variable
names and comments, to create a ContactInfoCache responsible for logic
pertaining to looking up and caching contact info.
The logic is intended to be unchanged for now, although in the future
it can/should probably be cleaned up sometime.
Bug: 20038300
Change-Id: I60a57b0a665496522a6b51c9e6e41a4fd6dbad1f
|
|
This greatly improves the dialpad slidein animation on
low end devices.
Bug: 20055089
Change-Id: I17e04eeaad48b8d2245ef6d9ce5fef623588cccc
|
|
|
|
Once a ContactInfoCache is implemented, these will be changed to have
package visibility. This is an incremental step of breaking out and
moving these classes to a "contactinfo" package. The next CL will
actually implement the Cache and have more churn in terms of logic,
while this is more straightforward.
Bug: 20038300
Change-Id: Ie6082b2eeab52e25f861f2459517fff057370f82
|
|
Bug: 20038300
Change-Id: Id1636fdf6a1b15ac0c570f484e6f0c05985027e8
|
|
Bug: 19372817
Change-Id: Icddc1edd2ca1ad040a03726471a19ddc9d434d4d
|
|
Bug: 19372817
Change-Id: I92d9f001155d4a059c89bc4b00abcef4e817f32d
|
|
It will initialize itself if it does not exist, instead of relying
on getting a system service as the mechanism for initialization.
Bug: 19372817
Change-Id: Iae3eff986a79730bb2a8da9dcd4f28f664719673
|
|
|
|
There's a lot of logic around inflating/initializing which lives in
the adapter, but only really applies to the views. Move this into
the View Holder for now. This may not be its final resting place,
but in any case this seems like it can be extracted from the adapter.
Bug: 19372817
Change-Id: Ib3436ad4d8e666a8df8cb2f894e71b321ecb68da
|
|
|
|
I don't think this method has been used for quite some time, and
am uncertain what it was used for originally.
Bug: 19372817
Change-Id: I6abc7cb2699306706dd790247a038d94ed7d1583
|
|
Bug: 19949319
Change-Id: I32a2217a24915a7d862a1c9d521fc0c45f0ecb68
|
|
|
|
|
|
Log more info, to help with debugging misbehaving shortcuts.
Bug: 19406317
Change-Id: Ia1dd8e51f7129a142d23867179fd1db7ca86c865
|
|
Thsi allows Google Dialer to add a feedback option and handle its
behavior accordingly.
Bug: 19254693
Change-Id: I64ab34049406d10f53504af8d5eda9ac29758ef8
|
|
|
|
- The smart dial search normalizes the dial string and removes
anything other than digits
- Add a fix to add the + sign back to the normalized string
if original typed number had a + sign
- Add a check for prohibited numbers before making a call
and display an error dialog
Change-Id: Ib36462be573ce4fecc8821980226ae2920041cd2
|
|
|
|
|
|
Do not add null strings to list of device ids when responding to MMI
code for device ids (IMEI/MEID). Also fix string resource that is not
available in AOSP.
Bug: 19897433
Change-Id: Ie06bb793eafa66f451bf1843d2a5ad4d343999d2
|
|
|
|
Because the call detail activity is being used for playing voicemails,
this happens when playing voicemails but not looking at more details for
a non-voicemail call because the "details" option is not available for
non-voicemail entries. If the voicemail comes from an unknown number,
the activity attempts to get the number and convert it to a string for
use in intents within the call details activity, but since the number
does not exist, the app crashes instead.
Bug: 19627341
Change-Id: I5302527c1c51c620a66ead85984b2e2399839086
|
|
Bug: 19372539
Change-Id: I84055e620335483027a70c3693d06e9f83d4570a
|
|
Even if we don't need to reload the data, refresh the list view with
the data we currently have. We display the call log times using text
descriptions relative to the present. This refresh updates those
descriptions.
Bug: 19653523
Change-Id: Ib5bc79d52946baabac86c2b9459ab66901d5615b
|
|
+ Add a URI for smart dial database updates, and notify this URI
with the content resolver after finishing an update.
+ Add a content observer to the SmartDialCursorLoader, to force a
reload of its contents when notified.
Bug: 19372539
Change-Id: I963d0d0fcb519e672f580ea8d33dc80d0c3f7799
|
|
|
|
+ Update SEND_SMS in the regular search list adapter. Before, it was showing
up all the time, even when it wasn't supposed to.
+ Hide CREATE and ADD in the regular search list adapter.
+ Move disabling of DIRECT_CALL to the smart dial adapter. It's only used by
the single fragment right now, so centralizes the enabling of the shortcuts.
Bug: 19372539
Change-Id: Iea9108e83f15026d86400a5d1e63d5c011b2770a
|
|
These are now exposed as shortcuts in the search fragment.
Bug: 19372539
Change-Id: I526570cf8326dbfac1770c0f3c06b72ee1166cc8
|
|
Add a shortcut in the search fragment for "Create new contact" which
opens the compact editor with the entered phone number populated as
the main phone number.
Bug: 19372539
Change-Id: I9ccb462f399e3fab77c2d8ad536dbd0bd0e23609
|
|
We're going to "fork" the add action into "existing" and "new".
This converts the existing shortcut action to the scenario for
adding to an existing contact, and the action for adding to a new
contact will be added as a follow up.
Bug: 19372539
Change-Id: I9e78fa5637a6f0ff22ce1d74bca3fe98e531242f
|
|
|
|
Bug: 19372539
Change-Id: I8135a7e6fb7d5becdafcb0ecfb64d6f6c73aeb88
|
|
|
|
To assists with readability, clean up call log fragment by calling the
contents of the helper methods directly, to remove extra level of
indirection created by the helpers. In most cases, these helpers were
one-offs, or were direct calls to another helper method.
Bug: 19372817
Change-Id: I96d96bee6b300a26987513d50115de0c4cd522c1
|
|
|
|
|
|
|
|
This is the more established pattern for creating intents to be used
by call log list item actions.
Bug: 19372817
Change-Id: I62cf5170cf51c4fbec8d1d9910b3fa3380a3dc3e
|
|
|
|
- Remove isCallLog specific code from adapter; now everything will
always be in the call log.
- Remove unneeded adapter bits from ListsFragment; there is now no
shortcut card shown in the lists fragment.
- Remove call log list item extra. We won't bind badges using this
any more. This will be superseded by the actions. Remove
badge-related code in CallLogAdapter.
+ Leaving the add-person icon, since it will be used in the future.
Bug: 19372817
Bug: 19627987
Change-Id: I4db8149761b017e02e89c081930a05f3aafe9606
|
|
|
|
|
|
If TTY mode is not supported and the device is not configured to
support hearing aid compatibility, do not show the accessibility
settings header.
Bug: 19372734
Change-Id: Id10c49cfa99cbe1f22bb69dcd5a1245e54e18ec4
|
|
Bug 19546108
Change-Id: I06d3d9326fac25cd8f84e96121e3c40eaa643cc0
|
|
|
|
as wells as the missed-call notification.
Just PhoneLookup.ENTERPRISE_CONTENT_FILTER_URI instead of
PhoneLookup.CONTENT_FILTER_URI.
This CL requires the new column in calllog provider.
Change-Id: I61a2f63bcad102cb8a7e8021483b7dfe254abd95
|
|
|
|
+ Add resources and drawables for icons to label the tabs.
+ Pass drawable ids to the ViewPagerTabs in ListsFragment.
Change-Id: Ib7b3fcaa2257fc439b6fae8b017646c3d150eb56
|
|
- Remove the OverlappingPaneLayout, which is no longer needed
since the recents card has been removed.
- Known Issue: SearchBar is no longer hidden on scroll.
- Known Issue: shouldShowActionBar does not return correct value.
I plan to fix these KIs in a follow up CL, but going for incremental
changes for now to try to keep it apparent what is being done.
Bug: 19372817
Change-Id: I9ae1ca19820c87f252863074a5bcab6923b03558
|
|
|
|
- Delete SwipeableShortcutCard, ShortcutCardsManager.
- Remove related references in ListsFragment, layouts, helpers for
swipe behavrio, dimensions, and ids.
+ Update sliding logic in ListsFragment.
It's not ideal to use a frame layout to provide spacing/color, but this
is the most straightforward way to maintain behavior for now. This
can/should be revisited if removing the OverlappingPaneLayout.
Bug: 19372817
Change-Id: I789119fb8f87ea19cda545eec7c722306fc2813d
|
|
Bug: 19372734
Change-Id: I59742a36333b1923459b89c4f11f741feb4d3e78
|
|
Followup CL will prevent this from showing if TTY Mode and HAC are
not supported.
Bug: 19372734
Change-Id: I8f1e93efab6447d2099d5eb6e734704d6632e299
|
|
With the addition of the visual voicemail sync adapter, we want to have
a flag in the voicemail provider that will indicate that a voicemail was
deleted but not yet synced to the server. However, we no longer want
the entry to show up in the dialer call log, so make sure to ignore all
voicemails marked with "deleted" when querying the call log table.
Bug: 19236241
Change-Id: Ib80537c3b8630dd99b5e2b9b20d81015eafd114c
|
|
bindView() gets called many times at dialer startup and layout updates.
Besides being costly, it invokes cross-process TelecomManager methods.
This change addresses the cross-process issues by adding a short-lived
cache to isVoicemail() method invocations.
Change-Id: Ib69c0eb3969a1b7d77c9fd1a2aa6e578a31fb5e9
|
|
|
|
Change-Id: I46188070997ebc9b69f7d9b5a8ba9cb3c221b743
|
|
+ No functional change, but cleaner / more robust code.
+ Converted preference keys into shared string constants.
+ Reorganized code in SoundSettingsFragment into clearer helpers.
+ Defined constants for "magic" values used for sound preferences.
Bug: 19372734
Change-Id: Ic0eb44d72548909ae6c520b18e0f4e2a2d013ac6
|
|
|
