summaryrefslogtreecommitdiff
path: root/src/com/android/dialer/voicemail
AgeCommit message (Collapse)Author
2015-06-19Rewrite of MediaPlayer logic.Andrew Lee
+ Control MediaPlayer instance more tightly. Wait until prepareContent to initialize instance. Release MediaPlayer when it is no longer needed. + Instead of using isFinishing, check explicitly for orientation change to know whether to release MediaPlayer. + Change Presenter to singleton, to address audio change wonkiness. + Only create a Presenter if the call log fragment shows voicemail. + ... fixing a variety of cases. - Temporarily disable proximity sensor until blocking issue is fixed. Bug: 21856243 Change-Id: Ic06e98bb5278467c3cce726a06b6cf3d855861a2
2015-06-18Pass activity into VoicemailPlaybackPresenter.Andrew Lee
We will use it to set windows flags to help make playback behaviors reasonable. Bug: 21856243 Change-Id: I7c1ecb9e225a507ea8956ccc31d667361a4b6824
2015-06-15Add play voicemail primary action to call log.Andrew Lee
+ Add voicemail primary action button, which expands the call log and plays immediately when clicked. + Pass expand/collapse listener into the view holder. This is necessary because it needs to be triggered when the "play" primary action is clicked so that the CallLogAdapter correctly registers what has been added and binded. + Update primary action button state when showing or hiding actions, so the visibility of the voicemail play button is managed properly. + Ensure voicemail playback state is consistent between multiple call log items when the user initiates a collapse or expand. Add reset function to help manage this. + With the reset, protect against the possibility of functions in the presenter being called when no voicemail playback view is set. Bug: 21654755 Change-Id: I7bcf67d27fa08fe77d1334dc084b52effe8d3ccc
2015-06-12Merge "Don't pass media player to VM playback layout." into mnc-devAndrew Lee
2015-06-12Don't pass media player to VM playback layout.Andrew Lee
Better to ask the presenter, where it can check if the media player is in the appropriate prepared state. Bug: 21765119 Change-Id: Ieeade86900da1eb0ed9407bea17a7fc6219b3ad2
2015-06-12Merge "Paranoid mIsPrepared checks." into mnc-devAndrew Lee
2015-06-11Merge "Default to earpiece for all voicemail." into mnc-devAndrew Lee
2015-06-11Default to earpiece for all voicemail.Andrew Lee
Bug: 21654804 Change-Id: I9fa76a33231ae95f4a233b4f6615c56280a0228e
2015-06-11Paranoid mIsPrepared checks.Andrew Lee
Returning early if media player is not prepared in all these cases, just in case. Bug: 21764908 Change-Id: Ieca0e9fd1c323ea5150464683600542fefb318b3
2015-06-11Check mIsPrepared before querying MediaPlayer.Andrew Lee
Bug: 21764908 Change-Id: I5336ccadf13724430c2f3ee76c37efacd73cd27f
2015-06-09Fix some more unit tests...Andrew Lee
+ Pull out voicemail playback tests into their own test class. + Fix CallDetailActivity unit tests. + Some minor tweaks to functional code to facilitate. Bug: 21471763 Change-Id: I0f1747ab7ad6eba7dd2a7f6f8cfd060b409771bc
2015-06-05Handle FetchResultHandler race condition.Andrew Lee
Previously, the voicemail only needed to be looked up once, but now a single presenter may load multiple voicemails. As such, destroy the old FetchResultHandler if one already exists. Bug: 21663448 Change-Id: Ibdb08f03760b770d0800bd44d4cdcf0ca7c57fc9
2015-06-05Merge "Add delete action to voicemail in call log." into mnc-devAndrew Lee
2015-06-05Add delete action to voicemail in call log.Andrew Lee
+ Cleanup some asset and variable naming. Bug: 21239168 Change-Id: I4c99484bee1fcd300857cf44080c38e19a98cb5a
2015-06-05Don't call isPlaying if not prepared.Andrew Lee
Bug: 21647046 Change-Id: Ib0f5c2d7cd973ba4732defeceb32fe956e8dbdb8
2015-06-04Merge "Move VM playback from details to call log." into mnc-devAndrew Lee
2015-06-03Fix VoicemailStatusHelper unit tests.Andrew Lee
VoicemailStatusHelperImplTest was broken because of visibility issues caused by recent changes to how we read voicemail status. But, we plan to use this functionality again in the future. Bug: 21471763 Change-Id: I2049d2661c7d0686c8a439ea8a9e5bd20b009dd6
2015-06-03Move VM playback from details to call log.Andrew Lee
- Delete voicemail playback in the CallDetailActivity. + Add voicemail playback to the call log list items. + Move the VoicemailPlaybackPresenter to the CallLogFragment. + Fix some retaining state for both call log (expanded items), and preserve rotation/state functionality for voicemail playback. This included some changes to the Presenter logic. + Fix some tests. Bug: 21471763 Bug: 21170557 Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
2015-06-01Continue voicemail playback during rotation.Andrew Lee
Don't pause playback or release the media player during onPause or onDestroy. Bug: 21235334 Change-Id: I0eccd4e38e89c3416817d80aa25cc3bb529a9d6b
2015-06-01Fix CallDetailActivity tests.Andrew Lee
+ Reset the AsyncTaskExecutor's instance between calls in tests. I don't know why this is necessary, but it fixes a class of problems which were happening. + Don't try to release a media player if it has not been prepared. + Handle possible race conditions since MediaPlayer's async prepare may be buffering or finished when a test assert is executed. + Add asset file no longer provided by variablespeed library. - Cleanup some stream copy code. Change-Id: I0ae5fde00514c6dcdb1e9c063435a13eed6e8528
2015-05-27Refactor Voicemail Playback into standalone view.Andrew Lee
+ Substitutes the existing playback widget in CallDetailActivity, although the plan is to move this to the call log shortly. + Convert the widget from a fragment into a layout. This allows us to more easily create multiple instances of the voicemail widget in the same view, as we intend to do in the call log. + Shift UI-related logic from Presenter to the Layout. + Fix janky seeking, so that it now works correctly consistently rather than sporadically, and doesn't need to buffer again. - Remove the VariableSpeed player formerly used in the Presenter. We don't use this functionality anymore, and this allows us to directly used the framework MediaPlayer (instead of a custom legacy proxy). Bug: 21170557 Bug: 20693172 Change-Id: Ia34f459df10e43763b32fdb0954f83e882664231
2015-05-21Transfer VM fragment logic to presenter.Andrew Lee
We want the presenter to handle/manage resources pertinent to the activity lifecycle, so that we can convert the playback fragment into a component. My apologies to whoever has to disentangle this presenter logic later (though that could be me). Bug: 21170557 Change-Id: Icf65d3c23f1a12a7d63c2a281f96d2168a4a560f
2015-05-14Change VM playback fragment layout.Andrew Lee
- Remove increase/decrease playback rate functionality. - Flip button controls below the scrubber. - Delete TextController. Bug: 20433758 Change-Id: Id628bac0c9f8baed014079f2a89ce912fd2bb549
2015-05-13Move proximity sensor logic into VM fragment.Andrew Lee
In preparation for moving it from the CallDetailActivity into the call log. Seems to make sense to consolidate this within the fragment in any case. Bug: 20433758 Change-Id: I1aa0cd9a766fac3e1eb9285d31df5ed90523b8ad
2015-05-07Grab audio focus when listening to voicemail.Nancy Chen
Music and other audio should be paused when listening to a voicemail. The voicemail player grabs transient focus so that when the voicemail is paused or finished, the focus returns to the music that was playing. Bug: 19589110 Change-Id: I9876cc2700139d0db787d0e370020d2a38d82cda
2015-02-26Fix voicemail playback during rotation.gilles le brun
Avoid restarting the visual voice mail media player from the beginning while rotating the device. Bug: 18254556 Change-Id: I967fbcd8dbe9427b521de2b1830de040cca674c7 Signed-off-by: gilles le brun <gilles.lebrun.pro@gmail.com>
2015-02-06Fix voicemail playback position controlJay Shrauner
Bug:19255194 Change-Id: I8eabe46ef6fff774291e3f943051c24eca8a00e0
2014-11-05Improve Dialer analyticsYorke Lee
* Send screen view for first fragment loaded inside ListsFragment * Send screen view for voicemail playback fragment * Send screen view for currently active fragment when activity is restarted * Don't send spurious screen views on rotation * Send screen views for call log fragments in call log activity, and differentiate between them with a tag Bug: 18158037 Change-Id: I09fda53db33f6a6acc4a3b477de992aa94921c71
2014-10-30Use improved analytics in DialerBrian Attwell
Remove dependencies on old analytics code. Initialize analytics inside DialerApplication. Improving analytics CL #4/4 Bug: 18039620 Change-Id: I52f68e50297db2aae61d67d9bdbe66cb1d75aafc
2014-10-23Delete duplicated classBrian Attwell
Also renamed dialerbind package Analytics CL #2/5 Bug: 18039620 Change-Id: I45722015978038cdccb6a848c28e4b6c90d5aa4f
2014-07-30Changing Dialer Fragments to implement Analytics.Sai Cheemalapati
Dialer's Fragments now implement AnalyticsFragment. All Fragments now have access to sendHitEvent, which is a no op in AOSP Dialer. Change-Id: Ife6ab7d5369a1c96caaedbe1c59e6d07a0adae87
2014-06-09Applying call details red-lines.Tyler Gunn
- Contact photo is now quick-contact which invokes quick-contact view. - Removed send MS and call affordances, along with scrolling effect. - Added missing accessibility strings to voicemail controls. Bug: 15328410 Change-Id: I6d78d582af8c3a5cea8e051911cf3be763df2a36
2014-03-05Fix threading problems in voicemail codeJay Shrauner
Hold libvariablespeed handle in a reference counted singleton. Don't always reinitialize the engine twice in quick succession on startup. Catch and properly handle RejectedExecutionException exceptions thrown by the executor service. Bug:11511992 Change-Id: I6198dec303209445a0efd0f410a67332d75c7507
2013-10-21Remove private references from DialerYorke Lee
Remove MathUtils.constrain Use VisibleForTesting annotation in Guava Use Sets class in Guava Change-Id: Ib46e50ae2c0f278f6f588bb769b89ea37d8c5b30
2013-07-30Redlines for CallDetailActivity (call history items and voicemails)Yorke Lee
* Swapped out new assets * Changed background colors as necessary * Add padding view at bottom of seek container * Changed color of drawables * Removed unused assets Change-Id: I654ba417e03b2a32039504ae2de51fd75c5bec20
2012-10-23Removing contacts dependencies from CallDetailActivity.Chiao Cheng
Bug: 6993891 Change-Id: I3ef54efc0ff92367ea4f9b68c1629a99d90ff22c
2012-10-15Changing com.android.contacts.R to com.android.dialer.R.Chiao Cheng
Bug: 6993891 Change-Id: I921ec71fffbd4d4a058bab29ded8a6ac62adfb70
2012-08-30Moving more classes from contacts into dialer.Chiao Cheng
- These classes are only used by dialer code. - Fixed import order. Bug: 6993891 Change-Id: I7941a029989c4793b766fdc77a4666f9f99b750a
2012-08-21Initial move of dialer features from contacts app.Chiao Cheng
Bug: 6993891 Change-Id: I758ce359ca7e87a1d184303822979318be171921
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-19 07:11:19 +0000