Age | Commit message (Collapse) | Author |
|
In ag/874775, mStateText.setText(null) is removed from
VoicemailPlaybackLayout#setClipPosition(). This caused the error in
mStateText not to be cleared after the voicemail is sucessfully loaded.
This CL adds a setSuccess() method to the layout that clears the message,
which will be called from onPrepared() once the voicemail is loaded.
Fixes:27770842
Change-Id: Ic42e40b99d36f817532dec780b63311c1967300c
|
|
am: a2ee440
* commit 'a2ee44082c21014d3be1163ca362a556b5db30cc':
Add missing lock discovered by GuardedBy checker.
|
|
Found by error prone.
Change-Id: I8923c4e7095e644b8e09841ebda1911e6589b4e0
|
|
+Send intent to other applications with temporary file permission
granted
+Add voicemails folder to FileProvider paths
+When creating file in VoicemailArchiveProvider, append extension to
file name
+Check voicemail content exists before archiving it
+Refactor voicemail code
+Add tests for checking file extension
+Add tests for archiving and sharing vociemails
+Archive tab should not archive on share button press
BUG=22798485
Change-Id: Id8068aba92f7f1ca58532dca6c405cb2908841a3
|
|
+Created new class for all AsyncTasks and listener interfaces.
+Separated the archive code into separate methods
+Added 7 tests
BUG=22797391
Change-Id: I789125328bf079846e34c5fd57fd0d1c67dc6266
|
|
+Add share icon and string
+Added share button to voicemail_playback_layout.xml
+Link to icon: https://icons.googleplex.com/#icon=ic_share
BUG=22798485
Change-Id: Iab9051f4824a4fa0eed90049a762aaac032cf3bf
|
|
+Archive-specific actions are not drawn unless the runtime flag is
enabled
+Disable archive button and menu item
BUG=27375884
Change-Id: Ide7d0a162468279f614e09e01de99d782854a3e1
|
|
+ Added VoicemailArchiveActivity which displays all voicemails archived
by the user
+ VoicemailArchivePlaybackPresenter is the same as
VoicemailPlaybackPresenter except that it does not need to request
content from the voicemail server
+Added tests (combined common methods and attributes for regular
voicemail tab and voicemail archive used for tests)
BUG=22797391
Change-Id: I4064eea945b9e257ec6c7ada35cf5ac1657dc866
|
|
Bug: 25452893
Change-Id: Iae3b0a2c2db4642d7cebc74c3ae47f5ab7ad7bc2
|
|
Formerly dialer only checks for content when the view is loaded, will
only acknowledge the new content status if the fetch succeeded, and
will send a intent every time it thinks there is no content.
Suppose the server took really long to finish the fetch, but eventually
succeeds, it will cause the voicemail fetch to fail every time.
After this fix before a fetch intent is sent, content availability will
be checked first.
The following step is taken to simulate a slow fetching server:
1.disable prefetch in telephony
2.disable the content fetch on dialer load
3.set fetch timeout to 1ms
Verified a similar behavior to b/27388041. Voicemail load fails even if
the content is already there.
This fix was then applied. Voicemail fail for the first time as it should
(timeout), but plays normally after the second time.
Bug:27412247
Change-Id: I184e04fb88772f9006cf6db0fe50d6e773a45d4a
|
|
The number of unread missed calls are displayed beside the Call Log as a
badge. All unread missed calls are bolded under the call log tab. When
exiting the call log tab, all unread calls are marked as read. When
interacting with an unread missed call card while in the call log tab,
it will subtract 1 from the badge.
Cherry-picked from d118a8e0d8a68499398504f350f81175118e2ecf
BUG=24953555
Change-Id: If91a3bc89197465934cb773955e4bec005d6d14e
|
|
Instead of showing a 00:00 duration, nothing is displayed. When the
content is loaded, the duration field for the call log entry associated
with the voicemail is updated with the duration fetched from the
mediaplayer. The proper duration is then displayed in MM:SS format.
BUG=24175525
Change-Id: I1cafebae4fcbc749f573accfcf8833b598675f0b
(cherry picked from commit 6f3016d9065564bf09a5759f16563a05abbe105d)
|
|
Now that we're no longer backwards compatible with Lollipop we don't
need CallAudioStateCompat. See ag/870962 for more info.
Bug: 26676586
Change-Id: I7c754d89a6c9e13bf5a004b7c5b15b88b9aff9ad
|
|
Bug: 26092525
Change-Id: Id3e54a197ed8bfb51b9b01bbc98a4ee81b28d9ee
|
|
Bug: 25776171
Change-Id: Ia72b3d4a30783592f8894e0eaa890be7c60743ea
|
|
Null check mVoicemailUri.
Bug:25634572
Change-Id: I1d4a810516244ecc56426d757590360ed9d3e308
|
|
+ Adjusted UI/String according to new specifications.
+ Added class VisualVoicemailEnabledChecker
+ Block number dialog display different message depending
on whether VVM is activated.
Bug:25455707
Change-Id: I09425053c91a5517e309302d421beadcc2d81cd4
|
|
The accessibilty delegate automatically expands the call log cards when
the card is in focus. However, the voicemail state was not being reset
when this happened. Make sure to reset the voicemail playback state
when expanding the card in this manner.
Bug: 24105523
Change-Id: Ife7535980566d7b62959767d7b72df779d275270
|
|
When rebinding the voicemail card, onPrepared gets called and resets the
voicemail playback to 0 because mPosition is not updated to the most
recent value. Update mPosition in this case to the position of the media
player and then call onPrepared.
Bug: 25080811
Change-Id: Ief3a021f4c11bac7b8c0a563765e14c897cb43b5
|
|
Crashes because the VoicemailPlaybackPresenter is alerted when the state
of the headset changes but the corresponding view may be out of focus.
Bug: 25090589
Change-Id: Iabe24eb969777ae3919ede05474f35d6c596b20e
|
|
Check for null context in resumePlayback.
Bug:24858686
Change-Id: I7c65e3ae836535f15936ecb397a68ee6590f31ed
|
|
Done for both snackbars in call blocking/unblocking and voicemail
deletion.
Bug: 24370325
Change-Id: I00fdebb635e60ac1d421ccf7f15df46693773870
|
|
Check for null context in resumePlayback.
Bug:24858686
Change-Id: I7c65e3ae836535f15936ecb397a68ee6590f31ed
|
|
- Switch to wired headset when plugged in even if playing on speaker
- Remember if wired headset overrode speaker so it can be turned back on
when the headset is unplugged.
- Ensure proximity sensor is turned on iff the earpiece is the audio
source.
Bug: 23816959
Change-Id: I952c24ee51139f21a17344acd7698c9ed8f52860
|
|
ub-contactsdialer-a-dev
|
|
An enabled "start" button is a cue to the user that they can re-attempt
downloading voicemail manually if the first attempt fails.
Bug: 23899613
Change-Id: Ie5baf6cf45c48d0f1988d01dbed3e31919510869
|
|
Make sure that the position is saved when navigating away from the
voicemail playback so that it can be restored when resuming. Also:
- Disable seekbar when not loaded
- Gray out seekbar handle when seek is disabled
Bug: 23566924
Change-Id: Ic9d84425d7a3cde9d212bd758eb518577161d7ec
|
|
We should always know what the duration of the voicemail is even before
it is downloaded. As such, when a voicemail is expanded, set the voicemail
duration. For a downloaded voicemail, we can go even further and prepare
the audio file when the card is expanded. This means the voicemail can
be played immediately when the user clicks "play" instead of having to
wait for the media player to buffer each time.
Bug: 23566924
Change-Id: I0ce7570eab72b0bf079d3eb8cd10b71981576a9f
|
|
There appears to be two issues which were borking this, although I'm not sure why
there was the change (maybe it's been around a long time).
A single instance of presenter is retained over time, which is no good for our case
where we're creating different FakeAsyncTaskExecutors each time, so added a method
for testing where we can clear the instance.
Secondly, the method checking the text views didn't work anymore. Not sure why, but
I added a hook into the state text so the tests can continue to check for that.
Bug: 23640774
Change-Id: Ie729627f3bb4ee08476d5ad0198e43cfea72ce5c
|
|
Since voicemail audio handling is about to get more complicated (adding
head phone switching and bluetooth), we need a separate class to handle
audio.
Bug: 23816959
Change-Id: If891739ef80f5646145d7a44ec70f5b7544010b0
|
|
+ Persist speakerphone setting across resume/pause.
+ Allow toggling speakerphone before voicemail is played or while
loading.
Bug: 23566924
Bug: 23716100
Change-Id: Icc7342be85bd6df0f4678134b222f2200d3fc56d
|
|
In other cases (eg. buffering), just load without showing the text,
since it will likely appear only for a very short time, and give
the appearance of flickering.
Bug: 22333980
Change-Id: Ic2bbba7a2127654aaf12546b177c465c9311ddc1
|
|
|
|
But, set them to INVISIBLE, so they layout, but don't appear.
This prevents jank caused by the seekbar resizing later on when
times are set for the first time.
Bug: 22333980
Change-Id: I8523659b837008bae1789c1beaccc7edf9c15554
|
|
|
|
|
|
In setPlaybackView, if the MediaPlayer is not null, onPrepared is
called. However, there can be a race condition where the MediaPlayer is
not null, but also not yet prepared (since preparation is an
asynchronous call).
Bug: 23228984
Change-Id: I1536de9b2c67c0ae796224a717b1047fac0a8da4
|
|
If the view does not exist, this probably means resumePlayback() was
called as a result of an asynchronous callback that returned after
navigating away from the voicemail playback view. In this case, just
return null.
Bug: 23521761
Change-Id: I75e5e997bce463739612d65f61413d06eae82de3
|
|
in VoicemailPlaybackPresenter.
* commit '37ae6aad573094dbb49ab9e37d7e044539962aa7':
Prevent NPE in VoicemailPlaybackPresenter.
|
|
Bug: 23386856
Change-Id: Ib87184199e8578a1fe3b0a6457b26069673f56ca
|
|
Snackbar will appear for 3 seconds during which the user can undo the
last deletion. The way it works is the snackbar appears for 3 seconds
and a delayed callback is set for 3 seconds after which the voicemail is
permanently deleted from the database. If a second (or third or fourth)
voicemail is deleted subsequently, the previous voicemails that were
waiting for the undo timeout are deleted immediately.
Bug: 22460745
Change-Id: I84b70994275975e4e3020321884d382cc87098dc
|
|
|
|
Bug: 22642715
Change-Id: I01c8c8a7ec3dfa132c0aad37fe847fd58daae516
|
|
|
|
Pipe onVoicemailDeleted notification through to CallLogAdapter.
Reset expanded position when that happens.
Bug: 22534894
Change-Id: Iec69082bd8b3259f500b523da6d0710bece69fa4
|
|
If the user navigates away from the call log, reset the currently
playing voicemail playback. Which includes resetting the start point,
pausing playback, and refreshing the play icon.
Bug: 22530093
Change-Id: I78eda2d86cf0f5b24136a7a9ba299214f155672b
|
|
We don't want the voicemail to continue playing after deleted, so
perform the pause behavior when the delete button is pressed.
Bug: 22462516
Change-Id: I664c5aed0c2bd1910cdf1f20a33c0117dde8d0cc
|
|
* Don't fetch voicemail until playback is started
* Prevent multiple voicemail fetches for the same voicemail
* Fixed an issue where the seekbar would be stuck in the same
position even after seeking
* Fix for playback position getting reset after the voicemail
view is scrolled out of view and back in
* Respect the invariant that if mMediaPlayer is null, mPrepared
is always false. This fixes potential NPEs when resuming playback.
Bug: 22127956
Bug: 22333494
Change-Id: I5c419424950c0e21317cbd133ca6f7e1edd9fd31
|
|
Null check mActivity
Bug:22301343
Change-Id: Ia020f2a8c74cf16786af9ab7132da4eb9b9d0401
|
|
Null check mActivity as we do in onPause
Bug:22249553
Change-Id: I147fbd517696205a2eb478a6df032f50cbbd5b34
|
|
Bug: 22194812
Change-Id: I95e07820ed97d02fe61ee3ceee62c7e76c6f1cb5
|
|
Bug: 22171979
Change-Id: Ia26ba711b888de3c787167bf9af99fcf26a80b7a
|
|
Bug: 22118779
Change-Id: I9a11c2fc05f8a6f418bc0e6daa55dfb61707bd6a
|
|
|
|
- Delete now-unused old icons.
+ Add new material icons for voicemail playback.
+ Rearrange buttons, padding/spacing.
+ Change ripple feedback when pressing button.
+ Use different text fields for total duration and state labels.
Bug: 22070564
Change-Id: Ibc9b9908154ac0a846f828bb9707a61ab15f8ba5
|
|
|
|
|
|
+ When using speakerphone, add flag to keep the screen on.
Bug: 22047261
Change-Id: I4e28ab526218b4cc1f53f2ec98c4749f24ac95af
|
|
Bug: 22031896
Change-Id: I2da646a30a119c5be07dba8ad71c8e902969454e
|
|
If the voicemail is in the process of deleting, the uri may be
unavailable after the async task has started executing. Make a null
check first.
Bug: 21978479
Change-Id: I0ec93e66b055c4e5d9ce2743a3cffc689c835f78
|
|
+ Control MediaPlayer instance more tightly. Wait until
prepareContent to initialize instance. Release MediaPlayer when it
is no longer needed.
+ Instead of using isFinishing, check explicitly for orientation
change to know whether to release MediaPlayer.
+ Change Presenter to singleton, to address audio change wonkiness.
+ Only create a Presenter if the call log fragment shows voicemail.
+ ... fixing a variety of cases.
- Temporarily disable proximity sensor until blocking issue is fixed.
Bug: 21856243
Change-Id: Ic06e98bb5278467c3cce726a06b6cf3d855861a2
|
|
We will use it to set windows flags to help make playback behaviors
reasonable.
Bug: 21856243
Change-Id: I7c1ecb9e225a507ea8956ccc31d667361a4b6824
|
|
+ Add voicemail primary action button, which expands the call log
and plays immediately when clicked.
+ Pass expand/collapse listener into the view holder. This is
necessary because it needs to be triggered when the "play" primary
action is clicked so that the CallLogAdapter correctly registers
what has been added and binded.
+ Update primary action button state when showing or hiding actions,
so the visibility of the voicemail play button is managed properly.
+ Ensure voicemail playback state is consistent between multiple
call log items when the user initiates a collapse or expand. Add
reset function to help manage this.
+ With the reset, protect against the possibility of functions in
the presenter being called when no voicemail playback view is set.
Bug: 21654755
Change-Id: I7bcf67d27fa08fe77d1334dc084b52effe8d3ccc
|
|
|
|
Better to ask the presenter, where it can check if the media player
is in the appropriate prepared state.
Bug: 21765119
Change-Id: Ieeade86900da1eb0ed9407bea17a7fc6219b3ad2
|
|
|
|
|
|
Bug: 21654804
Change-Id: I9fa76a33231ae95f4a233b4f6615c56280a0228e
|
|
Returning early if media player is not prepared in all these cases,
just in case.
Bug: 21764908
Change-Id: Ieca0e9fd1c323ea5150464683600542fefb318b3
|
|
Bug: 21764908
Change-Id: I5336ccadf13724430c2f3ee76c37efacd73cd27f
|
|
+ Pull out voicemail playback tests into their own test class.
+ Fix CallDetailActivity unit tests.
+ Some minor tweaks to functional code to facilitate.
Bug: 21471763
Change-Id: I0f1747ab7ad6eba7dd2a7f6f8cfd060b409771bc
|
|
Previously, the voicemail only needed to be looked up once, but now
a single presenter may load multiple voicemails. As such, destroy
the old FetchResultHandler if one already exists.
Bug: 21663448
Change-Id: Ibdb08f03760b770d0800bd44d4cdcf0ca7c57fc9
|
|
|
|
+ Cleanup some asset and variable naming.
Bug: 21239168
Change-Id: I4c99484bee1fcd300857cf44080c38e19a98cb5a
|
|
Bug: 21647046
Change-Id: Ib0f5c2d7cd973ba4732defeceb32fe956e8dbdb8
|
|
|
|
VoicemailStatusHelperImplTest was broken because of visibility issues
caused by recent changes to how we read voicemail status. But, we
plan to use this functionality again in the future.
Bug: 21471763
Change-Id: I2049d2661c7d0686c8a439ea8a9e5bd20b009dd6
|
|
- Delete voicemail playback in the CallDetailActivity.
+ Add voicemail playback to the call log list items.
+ Move the VoicemailPlaybackPresenter to the CallLogFragment.
+ Fix some retaining state for both call log (expanded items), and
preserve rotation/state functionality for voicemail playback. This
included some changes to the Presenter logic.
+ Fix some tests.
Bug: 21471763
Bug: 21170557
Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
|
|
Don't pause playback or release the media player during onPause or
onDestroy.
Bug: 21235334
Change-Id: I0eccd4e38e89c3416817d80aa25cc3bb529a9d6b
|
|
+ Reset the AsyncTaskExecutor's instance between calls in tests.
I don't know why this is necessary, but it fixes a class of problems
which were happening.
+ Don't try to release a media player if it has not been prepared.
+ Handle possible race conditions since MediaPlayer's async prepare
may be buffering or finished when a test assert is executed.
+ Add asset file no longer provided by variablespeed library.
- Cleanup some stream copy code.
Change-Id: I0ae5fde00514c6dcdb1e9c063435a13eed6e8528
|
|
+ Substitutes the existing playback widget in CallDetailActivity,
although the plan is to move this to the call log shortly.
+ Convert the widget from a fragment into a layout. This allows us
to more easily create multiple instances of the voicemail widget in
the same view, as we intend to do in the call log.
+ Shift UI-related logic from Presenter to the Layout.
+ Fix janky seeking, so that it now works correctly consistently
rather than sporadically, and doesn't need to buffer again.
- Remove the VariableSpeed player formerly used in the Presenter. We
don't use this functionality anymore, and this allows us to directly
used the framework MediaPlayer (instead of a custom legacy proxy).
Bug: 21170557
Bug: 20693172
Change-Id: Ia34f459df10e43763b32fdb0954f83e882664231
|
|
We want the presenter to handle/manage resources pertinent to
the activity lifecycle, so that we can convert the playback
fragment into a component.
My apologies to whoever has to disentangle this presenter logic
later (though that could be me).
Bug: 21170557
Change-Id: Icf65d3c23f1a12a7d63c2a281f96d2168a4a560f
|
|
- Remove increase/decrease playback rate functionality.
- Flip button controls below the scrubber.
- Delete TextController.
Bug: 20433758
Change-Id: Id628bac0c9f8baed014079f2a89ce912fd2bb549
|
|
In preparation for moving it from the CallDetailActivity into
the call log. Seems to make sense to consolidate this within the
fragment in any case.
Bug: 20433758
Change-Id: I1aa0cd9a766fac3e1eb9285d31df5ed90523b8ad
|
|
Music and other audio should be paused when listening to a voicemail.
The voicemail player grabs transient focus so that when the voicemail is
paused or finished, the focus returns to the music that was playing.
Bug: 19589110
Change-Id: I9876cc2700139d0db787d0e370020d2a38d82cda
|
|
Avoid restarting the visual voice mail media player from the
beginning while rotating the device.
Bug: 18254556
Change-Id: I967fbcd8dbe9427b521de2b1830de040cca674c7
Signed-off-by: gilles le brun <gilles.lebrun.pro@gmail.com>
|
|
Bug:19255194
Change-Id: I8eabe46ef6fff774291e3f943051c24eca8a00e0
|
|
* Send screen view for first fragment loaded inside ListsFragment
* Send screen view for voicemail playback fragment
* Send screen view for currently active fragment when activity is restarted
* Don't send spurious screen views on rotation
* Send screen views for call log fragments in call log activity, and
differentiate between them with a tag
Bug: 18158037
Change-Id: I09fda53db33f6a6acc4a3b477de992aa94921c71
|
|
Remove dependencies on old analytics code.
Initialize analytics inside DialerApplication.
Improving analytics CL #4/4
Bug: 18039620
Change-Id: I52f68e50297db2aae61d67d9bdbe66cb1d75aafc
|
|
Also renamed dialerbind package
Analytics CL #2/5
Bug: 18039620
Change-Id: I45722015978038cdccb6a848c28e4b6c90d5aa4f
|
|
Dialer's Fragments now implement AnalyticsFragment.
All Fragments now have access to sendHitEvent, which is a no op in
AOSP Dialer.
Change-Id: Ife6ab7d5369a1c96caaedbe1c59e6d07a0adae87
|
|
- Contact photo is now quick-contact which invokes quick-contact view.
- Removed send MS and call affordances, along with scrolling effect.
- Added missing accessibility strings to voicemail controls.
Bug: 15328410
Change-Id: I6d78d582af8c3a5cea8e051911cf3be763df2a36
|
|
Hold libvariablespeed handle in a reference counted singleton. Don't
always reinitialize the engine twice in quick succession on startup.
Catch and properly handle RejectedExecutionException exceptions thrown
by the executor service.
Bug:11511992
Change-Id: I6198dec303209445a0efd0f410a67332d75c7507
|
|
Remove MathUtils.constrain
Use VisibleForTesting annotation in Guava
Use Sets class in Guava
Change-Id: Ib46e50ae2c0f278f6f588bb769b89ea37d8c5b30
|
|
* Swapped out new assets
* Changed background colors as necessary
* Add padding view at bottom of seek container
* Changed color of drawables
* Removed unused assets
Change-Id: I654ba417e03b2a32039504ae2de51fd75c5bec20
|
|
Bug: 6993891
Change-Id: I3ef54efc0ff92367ea4f9b68c1629a99d90ff22c
|
|
Bug: 6993891
Change-Id: I921ec71fffbd4d4a058bab29ded8a6ac62adfb70
|
|
- These classes are only used by dialer code.
- Fixed import order.
Bug: 6993891
Change-Id: I7941a029989c4793b766fdc77a4666f9f99b750a
|
|
Bug: 6993891
Change-Id: I758ce359ca7e87a1d184303822979318be171921
|