| Age | Commit message (Collapse) | Author |
|---|
|
into nyc-dev
|
|
The remove button will be announced when user hovers contact onto it or
drop it.
Bug: 25559343
Change-Id: I31f51f6d074d8b1721439e7a484e1e316cb006fe
|
|
+Redraw voicemail tab every time notifyDataSetChanged method is called
+Remove voicemail fragment once it is disabled
BUG=23522864
Change-Id: I9cb1e6a0bbb91c38709a0ac5b8908f4f1252e509
|
|
When swiping to a new tab, if the previous tab that the user was in was
the call history tab, all missed calls are marked as read and the tab
count is updated. Also fixes b/27153608 and clearing of missed calls on
orientation change.
BUG=27136093
BUG=27153608
BUG=27154514
Change-Id: I5be31b1a3978784b941fb8e1af22f93fb6ca944a
|
|
The number of unread missed calls are displayed beside the Call Log as a
badge. All unread missed calls are bolded under the call log tab. When
exiting the call log tab, all unread calls are marked as read. When
interacting with an unread missed call card while in the call log tab,
it will subtract 1 from the badge.
Cherry-picked from d118a8e0d8a68499398504f350f81175118e2ecf
BUG=24953555
Change-Id: If91a3bc89197465934cb773955e4bec005d6d14e
|
|
- The smart dial search normalizes the dial string, and removes
anything other than digits.
- Original dial string contains the number which is actully entered
by user. Pass this number as it is as dialed number validation is
already taken care by APIs defined in PhoneNumberUtils.
Bug=27074055
Change-Id: Ib85750abef765ace127ebde3a13397b4dfad48fa
|
|
Moved visual voicemail code from CallLogFragment to
VisualVoicemailCallLogFragment.
Expected to have a lot of VVM specific code in the fragment, so it's
better to separate them.
Change-Id: I0fcad51d08f1a174a42f940fd455ce885d76c4ae
|
|
An extended directory is custom directory in the app,
but not a directory provided by framework. So it can't
be USER_TYPE_WORK
When a search result is selected, RegularSearchFragment
calls getContactInfo and caches the resulting @{link ContactInfo}
into a local db. Set userType to USER_TYPE_WORK only
if it's NOT extended directory id and is enterprise directory
BUG=26680007
Change-Id: I92aa4b7c3dac20257e689eb0a4dfa0afbd81764c
|
|
Add work badge icon in calllog for work contacts
To see this feature
1. Receive/Make a call from work contact
(a contact in work profile has the phone number)
2. Drop/miss the call. See a badge icon next to phone label in calllog
BUG=26082618
Change-Id: I7371795e3c3ef925739096f39a70f03722dd430b
|
|
ub-contactsdialer-b-dev
|
|
- Update SmartDial database to track carrier presence.
- Add video call style elements to dialer stylesheet.
- Tore out hair in frustration tracing through code.
- Add listeners to allow dialing of video calls from search results.
Bug: 20257833
Change-Id: I476cccb8c2805ae6f9949366fc5c2ce2669b7734
|
|
Check for null activity.
Bug:26183802
Change-Id: Ic1bdae3611513f43b5556145ea72aaf22d602a74
|
|
Restores code deleted in ag/643285 because the code was used on pre-M.
Bug:25629359
Change-Id: Ief60d301fd8d3c018ce03388c56264a2db727224
|
|
requestPermissions is not available to the Fragments class and
checkSelfPermission is not available to the Context class in API < 23.
Use other backwards compatible methods to implement the behavior.
Bug: 25776171
Change-Id: I6cb221236f28b319f618d2cf32a9f503a6f4e6e0
|
|
Bug: 25694033
Bug: 25668829
Change-Id: I5254eed0c473fa8a9e801f4fa253d6fdfc885836
|
|
+ Added Clearcut logging when users block, unblock, undo,
or import blocked numbers. Location of blocking is noted, e.g. CallLog,
CallDetails, ManagementScreen
+ Added class with Constants matching proto definition
Bug: 25288435
Change-Id: I7fbef52d0e31b49c31dadbc0b4d775969d97420a
|
|
messages." into ub-contactsdialer-a-dev
|
|
Simplify code as this should be needed very rarely, since all activities that
call BlockNumberDialogFragment already need to update the status themselves.
+ Removed param context in BlockNumberDialogFragment.show()
Change-Id: I21f51292208fe59d8dec02d306782df1822b8834
|
|
ub-contactsdialer-a-dev
|
|
ub-contactsdialer-a-dev
|
|
When we refresh the voicemail tab information, we want to specify
whether we will be removing the tab or refreshing the data, this plays
along with the method change in ViewPagerTabs in ContactsCommon.
Bug: 25620191
Change-Id: Iddc9739ab545a55c5bc375639fbde64302f22cd8
|
|
|
|
Bug:25591800
Change-Id: Id858afc7771d6357e780de1826f0333b7601b26f
|
|
* Add blocked number screen types to Logger
* Log screen views for SearchFragments in DialtactsActivity
rather than in onStart, to avoid double logging for some
fragments (e.g. children of RegularSearchFragment)
* Log screen view for call log context menu (where the block
number action appears
Bug: 25288435
Change-Id: I4ebf1410f93afb37d20be2cc57f933e5d635cfb6
|
|
-Changed BlockedListSearchFragment to save queryString in the super
class, rather than duplicating logic
~ Changed BlockedListSearchFragment to show a blank screen when the user
initially clicks on the 'Add number' button
Bug:25568357
Change-Id: I649294ebb4ee6e96be67ee27039ac6543644f763
|
|
|
|
* Change logScreenView to log by an integer rather than string
representing a screen name
* Add some missing log events (SmartDialSearchFragment, etc)
* Add mapping of integer to screen name strings for AnalyticsUtil
Bug: 23164804
Change-Id: If34a01b71a3fb598caa237e4b679cfeb30c4dd01
|
|
ub-contactsdialer-a-dev
|
|
This reverts commit 8bea0950ff04891b7aaf58bb4ca758010c813fb4.
Change-Id: I1ad4cbda2dc4e6212084399fe53142e9e19dc888
|
|
|
|
* Replace inlined strings with consolidated string constants
* Log event when import/export to contacts dialog is shown
Bug: 23164804
Change-Id: I45ba0663f28bd7ea41c5c33c8a5106dc83cd41f3
|
|
Change-Id: Ieedf62ce9648a611f36cbb118d626d135abef132
|
|
Bug:25452669
Change-Id: I9c1685ee05f2ffc2fc6ac94714c2ae4d1137ffbe
|
|
+ Adjusted UI/String according to new specifications.
+ Added class VisualVoicemailEnabledChecker
+ Block number dialog display different message depending
on whether VVM is activated.
Bug:25455707
Change-Id: I09425053c91a5517e309302d421beadcc2d81cd4
|
|
* The logger is responsible for sending it to its logging
implementation, and also to AnalyicsUtil.
* Standardize logic for creating a tagged version of a screen
name
Bug: 23164804
Change-Id: I9b817fba5359f78340f2d9fdba54af9ea73cdb37
|
|
Bug:25456614
Change-Id: I6fdd34a0d619053d632e7364fc8ccaba8f8ef15f
|
|
"showing item" messages." into ub-contactsdialer-a-dev
|
|
messages.
+ DiatactsActivity set its' title to "Phone Dialpad" or just "Phone", so user
using Talkback can know the state of the activity when it is launched
+ SpeedDialFragment and SearchFragment no longer send accessibility events when
its' content is changed.
+ Add AccessibilityDelegate ContentChangedFilter to filter out
TYPE_WINDOW_CONTENT_CHANGED event for View.
Bug:25190037
Change-Id: If1fa34cc9a5d24dec3fe261da9c071bb5388ec58
|
|
The incorrect column was being used to populate mContactIdIndex
which was breaking the deduping logic (which is based on contactId.
Bug: 25432987
Change-Id: If8c435e84d191ed012a019a800cf18abbda3d907
|
|
|
|
+ BlockedListSearchFragment.onChangeFilteredNumberSuccess() calls
activity.onBackPressed() instead of re-adding the management fragment.
Original fix was lost due to a bad merge.
Bug:25330660
Change-Id: Ib6d04dba55832845d145d2925cfb595237e7a19f
|
|
+ Clearer name about functionality, and async nature.
+ Change it to return "false" if it fails and is trying to block an
invalid number, rather than returning "true". This matches a more
standard success/fail return paradigm.
+ Update logic for showing "invalid" message based on return value.
+ Simplify parameter set which it takes in; always take nubmer and
countryIso, because they can be used to calculate the normalized #.
Bug: 25343277
Change-Id: If6fb28a6395e207047f4b27bfac37f5c70a9bac3
|
|
- Speed dial names change based on whether user wants first name first
or last name first
- Sort order preferece is respected if ContactEntries have conflicting
pinned positions
- Added tests for PhoneFavoritesTileAdapter.arrangeContactsByPinnedPosition
method
Bug:19364093
Change-Id: I81214abce572e297cc21fcb4f5a901ecad958380
|
|
ub-contactsdialer-a-dev
|
|
Manage is more related to a specific screen, new name seems to
make more sense based on location in settings menu of application.
Bug: 25343277
Change-Id: Ia45c1b7aa91c045078fd1473500f5d474e1c598f
|
|
Reconstruct the normalized phone number from other params.
Bug: 25343277
Change-Id: Ibb526b0808e0b50a4e946d91279e5570af44c3ca
|
|
It bugged me how it was inconsistently named to other classes
(ie. FilterNumber vs FilteredNumber).
It's also specific to blocked numbers, for now, so it felt more
appropriate to name it accordingly.
Bug: 25343277
Change-Id: I33e2f9fd933d117326690901ec71e3e8c0e3bbd3
|
|
Bug: 25342525
Change-Id: I9a845ffa25323b53175dc0eac2da1f2b4311abe3
|
|
+ Saved search term.
+ Fix padding/shadow jank between rotations.
+ Fix title disappearing for import on rotation.
Bug: 24910704
Change-Id: Ib683bd07ad629917ac429a5f33be54ecf781e33d
|
|
+ BlockedListSearchFragment.onChangeFilteredNumberSuccess() calls
activity.onBackPressed() instead of re-adding the management fragment.
Bug:25330660
Change-Id: If3a4cd26a180cf08a0e28f0c4bd05e7fd6149c20
|
|
ub-contactsdialer-a-dev
|
|
The voicemail entries were reading "speed dial" because the focus would go
to the newly added "speed dial" tab since the tabs are all removed and
readded when the tab info changes. Change the logic so that only the
voicemail tab is changed when needed.
The voicemail entry reads "seek playback" instead of the information
about the voicemail because of custom expand logic for accessibilty.
Change it so that only the call log items are expanded when selected
(it is more important to be able to discover the overflow options).
Also change content description text because it was too long and confusing.
Bug: 25124120
Change-Id: I64c1b27d8c0db57525f7f4ada59655e9f8352245
|
|
+ Configure BlockedListSearchFragment so it will not show empty
when the search query is null.
+ Removed local reference and equality check for changes in the
query string. This is done in the superclasses already, so was
redundant.
- Removed unnecessary override in RegularSearchFragment.
Bug: 24910704
Change-Id: Ifd11eed9e3ba6fb00ba535ae019df477f81518fb
|
|
+ Add a fragment (and adapter) for displaying numbers from contacts
marked as send to voicemail. This fragment has import functionality.
+ Refactor logic around the Blocked Numbers activity; relocate a lot
of the fragment-specific logic, particularly around actionbars, to
within the fragments themselves.
+ Simplify fragment management logic by using replace instead of
show/hide.
Bug: 23351616
Change-Id: I5c1076d6d001a8401234f57c27ada4bcd90e6c27
|
|
Bug: 24680730
Bug: 24303461
Change-Id: Ibd7d431355ca97eb2ae7f29537809987a8d5f96d
|
|
+ Correctly dismiss filtered number dialog on rotate.
+ Polish listener interface, and extend across all block/unblock
and undo scenarios.
+ Update UI across all blocking scenarios (call log, call detail,
settings, blocked number list, blocked number search);
+ Conslidate creation of FilterNumberDialogFragment in a single
static method.
The listener interface is not ideal, because it does not maintain
state well across rotation and multiple instances. This option was
selected, however, because of the number of scenarios in which
the dialog is invoked and various circumstances (in a RecyclerView
list item, in a fragment, in an activity). This range of scenarios
makes it convoluted to implement a uniform mechanism in any other
way, so the approach opted for is to set a listener, and dismiss
the dialog on rotation..
Bug: 24638328
Bug: 24109819
Bug: 24871853
Change-Id: I2332edda2cae0341af3e80b13aa96af6068f75ac
|
|
|
|
Some numbers had been showing up marked as blocked, even though
they were not blocked, because the adapter list items were not
updated properly.
Bug: 24910704
Change-Id: Id3aead5212f4e51d02ec5c6be6c77962546722e0
|
|
AOSP Dialer does not care about having location enabled,
so move the relevant code out into a separate fragment
Bug: 24172011
Change-Id: I7c29ba4ed8e3fb0a600360c10e9c9fdd6d543b1f
|
|
|
|
Don't require RegularSearchFragment's parent activity to
implement CapabilityChecker interface. In the context of the
BlockedNumberSearchActivity this functionality is not needed.
Bug: 24804134
Change-Id: I848ae66c6f8afc6e60b19bc28e933ae1e2f59893
|
|
Mocks indicate that after adding, the user should be returned to
the management UI and the snackbar should be shown there. This is
kind of pain to do across fragments in different activities. To
help address this, make one Activity the parent of both the blocked
number manage and add/search UI. This also makes sense in terms of
logical organization.
Bug: 24134038
Change-Id: I682342a73c964a5d4eb90469f10d6584b85400f1
|
|
Clicking on TURN ON currently only asks for the location
permission. Showing the dialog that toggles location sources
is planned for a follow up CL.
Bug: 24172011
Change-Id: Ieb6bd58a60aacbda76f9c754efeebfdd9e89aa86
|
|
Rather than creating single instances and setting them or passing
them around, create them when we need them. This won't happen too
often so instantiating the objects shouldn't be too much of a
burden on the system.
Instances of AsyncQueryHandler all end up running tasks off
the same thread, so there should not be a negative consequence of
spinning off more threads.
Bug: 24638328
Change-Id: If53ce4f1fd83736c330c1ff02946ed45da575796
|
|
Bug: 24468656
Change-Id: I31091e2dde07dabc432247fd4e409907fada152b
|
|
Bug: 24506966
Change-Id: Ibc1d334fc18235c3d5971364d7024db61c590c46
|
|
Bug: 24134038
Change-Id: I30b283a6b67d7e64b58138762079c4bceb8fc64f
|
|
Change-Id: Ibb8fa066e7da501a1227b413b48f0895352fb372
|
|
Speed dial (PhoneNumberPickerInteraction, SpeedDialFragment)
Regular search (RegularSearchFragment)
Remote Directory (RegularSearchFragment)
Call Log (CallLogAdapter)
Smart Dial Search (SmartDialSearchFragment)
Dialpad (DialpadFragment)
Bug: 23164804
Change-Id: I7cc881ac655fca6d4f365b5de36a4087c4f17700
|
|
|
|
Respect the EXTRA_CALL_FILTER_TYPE extra if provided in an
intent extra
Fix bug where trying to jump to the voicemail tab for the
first time before active voicemail sources were detected
would not work.
Bug: 23947505
Bug: 23388120
Change-Id: Ib4fcaf486ae01d023f21fd2fc3bfc78f1a0cf609
|
|
Change-Id: Ia6554810f614e76d83a666ac3a4ceec01bd74aab
|
|
ub-contactsdialer-a-dev
|
|
Bug: 23686207
Change-Id: I2ac23ab403159f1f335d3c0e92752558d7ddc293
|
|
Query for number of unread voicemails when dialer starts and update this
number when the user reads the voicemails.
Pass the tab icons into the ViewPagerTabs class: changed so that the raw
image is passed instead of the modified drawable because the ripple is
applied in through the ViewPagerTabs layout instead of through the
drawable containing the icons.
Bug: 21086059
Change-Id: Ie426b042d72926ea3feb7baa4717108776152754
|
|
|
|
+ All user-facing indications should now say "Call History".
+ I renamed many references in code to "Call Log", which is how
we internally refer to many of the components related to call
history. It seemed excessive to rename the fragment, list items,
adapters, and other references to that throughout our codebase.
Bug: 23017190
Change-Id: I99719122ce592962ff99705dcf4b16e17eee3ab7
|
|
In order to add an "Undo" snackbar for voicemail, dialer activities need
to inherit from the AppCompat library. Add the relevant libraries to the
make files and change the styles to be compatible.
Bug: 22460745
Change-Id: Ia3cc4002cbd943da818fec67f888d085d53a3b25
|
|
+ Rename some logic around identifying the scenario (tab vs activity)
for the call log.
+ Add padding at the bottom of the call log.
+ Make call log in tab show all history, not just recent history.
+ Rename promo card logic in CallLogAdapter, since it is VM specific.
- Remove extra view holder, and associated logic.
Bug: 23017190
Change-Id: I1f36f414647705a779ee14e8b43e88bf711bba56
|
|
contacts fragment when permission granted
* commit '791799c680b5d86148d69241ecc51ad843256c88':
Refresh all contacts fragment when permission granted
|
|
Bug: 22174668
Change-Id: I6d23fb76c6b67093ee1193fba45bd20baa50a68f
|
|
permission prompts for contacts and dialpad search" into mnc-dev
* commit '478f44816cfe54498d3306176e955887370b5a00':
Add permission prompts for contacts and dialpad search
|
|
Update the following fragments to handle denied permissions
-Contacts Search (Contacts and Location)
-Dialpad Search (Phone)
Tweak and remove some of the onTouch listener logic as they are
no longer valid with the new UI. Instead of intercepting the touches
when the query is empty and returning to the main dialer activity,
allow the fragments to remain on screen if the permission request
UI is showing.
Modify signature of onEmptyViewActionButtonClicked to remove unused
permissions parameter.
Bug: 22174668
Change-Id: I96d00f2ab45df936dca602ac025f723638ac02c4
|
|
"Update Dialer permissions UI per mocks" into mnc-dev
* commit '4aa980e5eabb25ce7b597f6dc2a544bbb5ce836a':
Update Dialer permissions UI per mocks
|
|
Bug: 22174668
Change-Id: If6757ff66c411228cfa22d70caaf6cc532fd2b31
|
|
Dialer UI to prompt for permissions
* commit '59ed388bf4327a78f24bf7a2755af3eecc4e30c7':
Update Dialer UI to prompt for permissions
|
|
First pass at adding functionality to Dialer to prompt for
permissions. Also updates the UI for various fragments when
there are no contacts/calls available to unify the UI with the
new UI for the permissions denied state.
* Refactor existing empty view functionality and encapsulate
into a new custom view class
* Add action buttons to existing empty views in various fragments
-> Speed Dial (Add to favorites) - scrolls to all contacts fragment
-> Recents (Make a call) - shows dialpad
-> All contacts (Add a contact) - Launches add contact dialog
* Add functionality to various fragments to detect if permissions
are denied, and request the permission when the action button
is pressed.
-> Speed Dial (request for contacts permission)
-> Call Log (request for phone permission)
-> All contacts (request for contacts permission)
* Remove now unneeded EmptyContactsListAdapter
Remaining issues (to be addressed in a follow up CL to avoid bloating
this CL):
UI alignment tweaks for empty view to match mocks
If the read contacts permission is requested from the
speed dial screen, the all contacts fragment doesn't update with
the list of contacts until restarted.
Bug: 22174668
Change-Id: I70721914bb9b32910d746de288ccac049749e42e
|
|
"Update call shortcuts even if contacts permission denied" into mnc-dev
* commit 'b292bb7a063c3bfeed32ecd7a875de6f77c1c319':
Update call shortcuts even if contacts permission denied
|
|
Bug: 22232717
Change-Id: I3c32a6ca55a8e0f904c2147e2c2df05327dbe9ed
|
|
permissions granted" into mnc-dev
* commit 'ace779434cb82410aa44469be37119296c124b9e':
Restore Dialer content after permissions granted
|
|
mnc-dev
* commit 'ac330ca173b76e7167ee2dae9bb086c698ef00f4':
Fix dialer monkey NPEs
|
|
checked for all new intents." into mnc-dev
* commit '6d0d211666969335012b6b0d94efef6810c05515':
Ensure the EXTRA_SHOW_TAB is checked for all new intents.
|
|
|
|
First pass at making Dialer display the call log, favorites,
all contacts, and contact search after permissions are granted
withut having to restart the app.
Update cached permission status in onResume for Dialer activities
Update SpeedDialFragment to correctly initialize loader in
onResume if it was null previously because of revoked permission.
Bug: 22205650
Change-Id: I68982e69395bc9c7da84ff3221cd12b8f79005f9
|
|
|
|
Monkey tests exposed a bug in Dialer where certain call shortcuts
could show up if contacts permissions were disabled and the UI was
changing quickly.
Don't enable shortcuts by default, and make sure to correctly
disable all shortcuts in the case of missing permissions.
Bug: 22225052
Change-Id: Icdd81412f695860eb322d7ccdc30555591c584d0
|
|
onNewIntent is only called when the activity is already active so when
an intent is sent to start the DialtactsActivity on a specific tab when
the DialtactsActivity is not already active, the code to switch to the
specific tab is not called. Move this code to onResume() instead.
Bug: 21120186
Change-Id: I735eae22ca5de54f4c17688777b4309616f2c691
|
|
search results" into mnc-dev
* commit '9677b253034fd79eb8eccdfa40e4bb50bb2801dc':
Accessibility fix for Dialer search results
|
|
In portrait mode, resize the listview to fit above the dialpad,
so that accessibility services can correctly traverse the
view hierarchy.
Bug: 20172384
Change-Id: I35fb49be7bea5d13d951c4d954ddaf9d8d12780e
|
|
in Dialer." into mnc-dev
* commit 'c1541e9aac277957d09cbb24340b8f4abd87c9bc':
Update some icons/styles used in Dialer.
|
