Age | Commit message (Collapse) | Author |
|
The dialpad currently simply disappears from view immediately when
dismissed by tapping in the space above it. instead, it should
slide downwards.
Change-Id: Idba1b8c6ccf40a6b12ea611d880e9f86183e6478
|
|
http://b/13189041
Change-Id: I91028c8fdee31c1f76610573a4396eb979c30170
|
|
BUG: 8310727
Change-Id: Icf9e103d2d6f5b5e7acb8c7f16244f0cebe9ffaa
|
|
|
|
DialpadFragment currently instantiates an instance of ContactsPrefs
that is not needed.
Change-Id: I8207f8d55c578a748c5edab1f722b18b5d38b48b
|
|
|
|
Statically initialize prefix logic to use NANP matching for NANP tests
Bug: 10346442
Change-Id: Ia268de8a9bc5ad8dae70fe6934823a3c289f0bae
|
|
* Empty geocode is now " " instead of "-" per UX request
* DialpadFragment now throws IllegalArgumentException instead
of Log.wtf so that it can be tested
* Added contact id column to contactsprovider query
* Modified PhoneNumberDisplayHelper to take an instance of
PhoneNumberUtilsWrapper so that it can be mocked out
Fix label-related tests that were failing due to a change in how we
treat empty labels
Bug: 9111164
Change-Id: If2244586b9d09fa2839fa0ddfc9f369f9dc66e51
|
|
Remove private reference to SystemProperties, needed for Verizon
requirements (per team email discussion)
Bug: 6948882
Change-Id: Idc826e4a93609799e3c741d36fca5124abbc5bb9
|
|
|
|
Only applies if the user has not input any digits yet.
Bug: 11648799
Change-Id: I28a57fcd7eae0faaf5e234e9ec7531140903e2f5
|
|
Bug: 11474252
Change-Id: Id5a64aa72790bddef9e8fd2d4661635bd2eb6f44
|
|
Each dialpad key needs to manually have the "focusable" flag set so that
hovering and lift-to-type works properly.
The edittext containing digits needs to receive focus at least once in
order for it to report sendAccessibilityEventTypeViewTextChanged type events.
In JB-MR2, the ViewPager would automatically give focus to the dialpad
fragment when it was swiped into view, but now we have to manually give it
focus ourselves when the dialpad fragment is swiped into view.
Bug: 11067558
Change-Id: I56a1891b12d5ec7771a37e1f7c361242ebfe028d
|
|
Use a set of views, instead of a simple counter to track whether
or not tones should still be played.
Bug: 10906908
Change-Id: I6bdb08c253f17d9b0aa867b5cbdf4770bc52510b
|
|
Bug: 11006188
Change-Id: I67861038510591384daf4e2c5da06af3dda5439c
|
|
Change-Id: Ib5c98b51c4f3113e434208b83310754b825a197f
|
|
|
|
|
|
Centralize dialpad keys
Change voicemail icon
Bug: 10445734
Bug: 10510368
Change-Id: I1e9dc98c9aed07c26bdfe176f4a4c94c65fc6d85
|
|
Bug: 10314426
Change-Id: Ieecb5cc64ce93fb8457ed0cab0d054b5a1b1586c
|
|
* Add a new class DialerPhoneNumberListAdapter, which both
RegularSearchListADapter and SmartDialNumberListAdapter extend.
DialerPhoneNumberListAdapter allows the addition of pre-defined call
shortcuts at the end of the phone number list that can be toggled
on or off.
* For the SmartDialSearchFragment, the only shortcut that is available is
always the Add number to contacts shortcut.
* For the RegularSearchFragment, if the user enters a string that contains
all dialable numbers, it is treated as a phone number and the call directly
and add number to contacts shortcuts are enabled. Otherwise, it is treated
as a name, and only the add contact with a new name shortcut is enabled.
* Add a intent that allows the user to directly create a new contact
that has the name field pre-populated. This intent is used if the user
enters input that looks like a name in the search view.
Bug: 10339630
Change-Id: I2ae757ce505d85a8780d28d89e09fb7084c773b1
|
|
Add properties table to dialer database
Database helper access is now performed through a
DatabaseHelperManager
Bug: 10414852
Change-Id: I2717a94faf1b79370f9307b4ea7d0c39b7a36cb5
|
|
Bug: 10328290
Change-Id: I3fc560f0727c493ae5f051320ea6abe4715f0e79
|
|
* Remove account filter header container
* Remove frequent header position
* Move dialer database updating to DialtactsActivity
Change-Id: I8a6a092f25609537a47ffafb28aa4df9f55b1bd5
|
|
into klp-dev
|
|
|
|
Bug: 9465444
Change-Id: Ibe7f463da5ba0a5276701fa10ce01c28a5d4b16d
|
|
This change prevents the dialpad from animating in when
the dialer is launched directly with a dial intent.
Change-Id: I6d7378de0484dcdadecbbc0e9c25d4c8ed1e3800
|
|
Bug: 10248510
Change-Id: Ib70b6b5eee8f1f16e2a9ea306292e324bfe3474d
|
|
* No code was changed, just either removed or renamed
* Reshuffled a couple of ids around in dialpad_fragment to fix some
compile time errors that somehow weren't caught before
Change-Id: I9e2381edfb14b0940015deb8cbd94786a1242f43
|
|
Add BIND_DIRECTORY_SEARCH permission to manifest. Use new methods
for GAL support. Change SmartDialing cursor and adapter to use
PhoneNumberListAdapter projections directly.
Bug:
Change-Id: I5f8181cfeec7adab4865e680ebc85ba2b476fc39
|
|
Removed unused classes and renamed NewDialpadFragment to DialpadFragment.
Removed some unused static imports
Change-Id: If16a8bfe8cc113a570514b6d0edd87cb946758fa
|
|
Change-Id: I51351f252338eee4d0be5723beafc044786b801e
|
|
* Reduced size of star and pound keys
* Made star and pound key gray
* Add voicemail image view
* Add light versions of menu assets
* Renamed other menu assets to be more consistent
* Assign proper menu items to dialpad fragment
Change-Id: I67f2e7eecb177fc8ab7b4bc9b2855b385c622a7f
|
|
|
|
Change-Id: I603eb29203b2ae65fe35f423c574a33bb86662a2
|
|
Change-Id: Ib2ee17d3a236c79a5a4495fd28281e2c29479a99
|
|
Change-Id: I5a67cf690be172e5d55a426f61e53e6b1bb7a935
|
|
Change-Id: Iea40db1bd4162a3e5f5a80e7af8b2902afd438b1
|
|
As far as possible, this change does not modify any behavior/look
of the existing dialer. All modifications to classes/layouts/style attributes
that would affect functionality of the old dialer are instead done in
separate new files.
Added new versions of all activities, fragments, layouts, menus
and resources that have been rewritten or modified.
The activities do not have intent filters yet in order to not interfere
with the existing dialer.
Added some new values in colors/styles/dimens for the newly added
layouts.
Added NewCallLogActivity to separate the CallLogFragment from
DialtactsActivity. All call log and voicemail entries are now presented
in a separate (New)CallLogActivity.
IntentProvider.getCallDetailIntent now takes a cursor instead of an
adapter for more flexibility.
Add OnListFragmentScrolledListener interface for DialtactsActivity
to receive callback when one of its children fragment is scrolled.
Added slide in and slide out animations for DialpadFragment.
Add slide up and hide animations for search view
All menu options now show up in a PopupMenu in NewPhoneFavoriteFragment.
Added call log adapter into NewPhoneFavoriteMergedAdapter.
Rewrote layout of DialpadFragment to show up as a fragment partially overlaying
the screen.
Removed some unused code in DialpadFragment (smart dialing, menu handling)
Add fragments and adapters for SmartDial.
- Update Dialer database to support highlight masking and record contact
data Uri, as well as photo uri
- Add a fragment and adapter for smart dialing
- Add SmartDialCursorLoader to load SmartDial results.
- Typing in the dialpad now returns smart dialing results instead of regular
search results
QuickContactTiles for all sub-adapters of PhoneFavoriteMergedAdapter now use
light theme instead of the the default dark theme.
Removed all redundant call log filter and contacts to display filter code
Moved Dialer specific UI list-related classes to the Dialer package
Change-Id: I34885813e4fa79b69e29ac870a87a56d6f08a5e7
|
|
No code has been modified at all in this CL. All classes
were copied from existing classes and renamed to add the New prefix.
Change-Id: Idbb522c9dd1ef5db8e3dffcb73155ca603f861b2
|
|
Change-Id: I405535654240b959cf8b0caa7ecfa8456a632791
|
|
- Creates a database helper to create a smartdial database for the Dialer app.
- Queries all rows in the Contact database and copies related columns to
the smart dial database.
- Create another prefix database to contain all prefixes of a contact.
- During keypad input, the prefix databse is queried to find contact
suggestions, and suggestions are ranked by the usage data and contact
status (starred, primary contact, etc.)
- Created unit test for the SmartDial database insertion and prefix
computing functions.
Change-Id: I4d7c3b3bcc52dd6efa4d6e69d3f1687c3abaeb69
|
|
* commit '1dd46a5c676325d20b7a042d0d0d3c7d9365d0bd':
Fix crash in Dialer in landscape mode
|
|
Change-Id: I57ffcea3d3fc43e8c87a47a97d6b4f7e5edf1525
|
|
Bug 9369806
Change-Id: I286ebb828c0f6ce7c005c541661b9aa67284847e
|
|
Added check on whether the intent is new to decide when to fill in the
number in dialer automatically. If the intent is not new, the dialer
will be filled with previously used number, preserving any edits on that
number.
Bug: 8484457
Change-Id: I45f02d395ce402670b380485b5ba1e7190600ec3
|
|
Switch to using public TelephonyManager calls (needed for unbundling).
Bug: 6948882
Change-Id: I301590efa5c45dfc3d31a16181694941a2bee092
|
|
All character validation, remap and index calculations in both
SmartDialTrie and SmartDialNameMatcher now go through a
SmartDialMap. The LatinSmartDialMap is used by default.
Bug: 8769026
Change-Id: I4ff90acc380e802f035ca1fbc55c022bf3b76aa3
|
|
Bug 9086662
Change-Id: Iab8fc869180188930f84edb794e0a24a1a0a2229
|
|
Suggestions now appear with a fade in and slide up animation.
Suggestions vanish with a fade out and slide down animation.
If a suggestion is moved into the middle, it slides to the left/right
as appropriate.
Change the layout containing suggestions to a LinearLayout, in order to
better support animations.
Renamed SmartDialAdapter to SmartDialController, and also refactored
it to handle entries for a LinearLayout instead of a GridView, as well
as adding animation support and view management.
Use null object pattern in SmartDialEntry to better handle null entries.
Start displaying suggestions on the first digit entered.
Bug 8840240
Change-Id: If4e16006c0b36d2244434e0b2d8f3d3b997b0ad2
|
|
Make sure that smart dialing state is properly set before
any digits in the dialpad EditText is populated.
Also turn smart dialing off by default even if the system
setting hasn't been previously set.
Bug 8963485
Change-Id: If556d8b1405cc9e60043774b3aafd5e111e4e7ee
|
|
|
|
Bug 8840243
Change-Id: I1d1fea4f958821f3a9273ba189e2140367049516
|
|
https://googleplex-android-review.googlesource.com/#/c/253417/
Converts vanity numbers such as 1-800-FLOWERS to the numeric
equivalents when the number string is populated via a DIAL intent
or pasted from the clipboard. Does not remove valid formatting such
as dashes, periods, spaces, etc.
Bug: 8858358
Change-Id: I553c91628b8fd86ff38a8eeec7823ebdc96bfe6b
|
|
Bug 8769688
Change-Id: I4aadd0f9e5495fb1b604910306dfd918d1540136
|
|
Names with an extremely large number of name tokens were
using exponentially increasing amounts of memory since we have
to insert entries for all possible initial name combinations.
Added a check in the trie insertion algorithm to only add initial
matches for the 1st 2, and the last 2 name tokens.
This change only affects search by initial matches for names exceeding
4 name tokens. Full token search for names of all lengths should still
work. E.g. "frank", "enstein" would still match "Dr Frank En Stein DDS".
However initial matching would be limited to the first 2 and last 2 tokens.
So "dfsd" or "fsd" would work, but "fes" or "fed" would not.
Also fixes a bug caused by integer overflow when calculating thresholds
for bucketing frequently used contacts
Bug 8737986
Change-Id: I804184368b78fe2fa407667ed83874d839c28115
|
|
For SmartDialTrie, also include numbers as valid characters when
calculating indexes when generating the byte array.
For SmartDialNameMatcher, include '0'-'9' as valid latin characters,
and handle them appropriately after remapping accented characters.
Also fixed a subtle matching bug that would manifest itself when
matching against multiple tokens with similar initials - E.g.
"Dr.Dredd"
Bug 8659001
Change-Id: If461d2760a723ef7fd03dda0c1a1515cd7b44cf6
|
|
Add handling of country codes if the number starts with a '+' prefix
Also add special case handling for NANP numbers in SmartDialTrie
if we determine that the user is in North America.
Save user's SIM country ISO into SharedPreferences.
Add SmartDialNameMatcher methods to correctly match NANP numbers
Fix tests to use assertTrue/assertFalse instead of assertEquals
Bug 8292294
Change-Id: Ic61dac75ee3b772986d3008240bbda81322c8f31
|
|
|
|
Bug: 8435819
Change-Id: I69c32207d123e5da4ae5421a5fe83ffeee4e5070
|
|
Bug 8281648
Change-Id: I55bfaf137f9657a47616187fe7b7999c321b21f9
|
|
The content observer doesn't help to detect changes that happen
outside the application (e.g. user modifies a contact in the People
app), and seems to be called multiple times while in the dialer for
no reason, causing multiple unnecessary recaches. Instead, just force
a recache in onResume upon startup to refresh the cache.
Bug 8527847
Change-Id: I52f5c435ad573ce8b195d7b7828f19501e068c60
|
|
Bug 8518729
Change-Id: Ib6626385c3b7cd9a6c3a18335444db21b937ea02
|
|
|
|
Used to hide menu items when not applicable. Now we show them always
and only perform the action in those cases where menu items were
previously visible.
Updated code to do zero-position checks when there is no
selection...previously missing check.
Changed code to use chars instead of Strings when dealing with single
digits.
Consolidated duplicate code with updateDialString() function.
bug: 7478840
Change-Id: I2aa5d3badd40079e9aa75abf7e4051f9dba5e667
|
|
Bug: 8369906
Change-Id: Ibdf8a4d43d0898429333af03e98a9aa494e5c819
|
|
into jb-mr2-dev
|
|
Bug: 8328641
Change-Id: I76fda040f709a9a5c0e88e67abfa106763b75ffb
|
|
Bug: 8330225
Change-Id: I0c61e12b4090ff6eeaff5ef5791ac62814d90383
|
|
Behavior:
Use a prefix tree to cache contacts instead of an array list
Perform matches against phone numbers as well
DialpadFragment now ignores results from stale tasks where
queries no longer match
Add ability to not use default phone number for phone number
disambiguation dialog
Contacts are now ranked by the order which they were sorted
by in the ContactsProvider (affinity)
Change remapAccentedChars to always return lowercase characters to avoid
overhead of uppercase character conversion
Resource/Layout changes:
Tweak margins so that the section containing smart dial
suggestions looks cleaner
Use color resource instead of hardcoding color values
Add phone number to SmartDial items
ContentObserver:
Add a contentobserver to be notified on changes in contacts
Refactored cache to allow for forced cache refreshes
Use a single instance of SmartDialCache
Tests:
Added SmartDialTrie tests
Comments:
Comment cleanup
Change-Id: Ica2854e2845d4d75048aa1fd982f139496d21bf3
|
|
Change-Id: If851c291273aa5296f1d59edccc83e6d4019be76
|
|
Allow the name matcher function used by smart dialling to perform
initial matches of the variety 57 - (J)ohn (S)mith
Refactor SmartDialNameMatcher testing method to allow checking multiple
match positions.
Add tests for initial matches
Change-Id: Iadc5e3e8b2f408136c704015d2297e9b520e1065
|
|
Change-Id: Idcab1877b341b42440e336fa09ba7d631c28c7d0
|
|
Change-Id: If60fc1d68bf7d32807f61716aecc7eb5d2ac1677
|
|
Bug: 6656969
Change-Id: I0bb094125eb9be2b6508e6ca658ae23da9da19d1
|
|
Extract caching methods from SmartDialLoaderTask
and use a standalone SmartDialCache object instead. This
cache object handles caching failures as well as concurrent
multiple cache requests.
Bug: 6977981
Change-Id: I6df9e273191c7ac434d094e567d7a91814f8c030
|
|
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I0399fee27960d46cd5b6f629d32868ff0c2ce38e
|
|
|
|
Instead of normalizing names during caching, add a function that
that maps accented characters to their alphabetic equivalents
using switch statements.
This character map is used in the on-the-fly matching algorithm.
This speeds up the caching process(11k contacts) from 800-1500ms
to about 600-1000ms since we no longer perform the normalizing
step during caching.
Bug: 6977981
Change-Id: I98dfc3cba00258bb7ff03b346eab7ca7dc1065be
|
|
Add null check for mContext to prevent NPE if somehow
SmartDialLoaderTask receives a null context
Bug: 6977981
Change-Id: Id87b254520a48ad78dc0c579f0fd58d7f7ce270e
|
|
|
|
Layout changes to dialpad fragment to make space for smart dial suggestions.
This feature does not appear in landscape mode.
SmartDialTextView automatically resizes text to fit within the bounds of the view.
SmartDialAdapter highlights certain portions of the matching name based on match
positions provided by SmartDialNameMatcher.
SmartDialLoaderTask is an AsyncTask that caches all contacts with a phone number
into memory, or matches all contact names against a provided query to return a
list of matches (maximum of 3).
SmartDialNameMatcher contains utility functions to remove accents from accented
characters and normalize a phone number. It also contains the matching logic that
determines if a contact's display name matches a numeric query.
Added some tests for SmartDialNameMatcher
Bug: 6977981
Change-Id: I43e1a70d8d0d46e02fc67fe1caaec9a1769124f5
|
|
This fixes the problem where the chooser is not shown when the dialpad is
started and pushed to recents before a call comes in. When the call comes
and dial pad is selected from recents, the dialpad is shown. Instead, we
should be showing the chooser so the user has the option of getting back
into the call.
Bug: 5761141
Change-Id: I315117c6607dbb71e5359cf98785591d20c21881
|
|
Bug: 6993891
Change-Id: I21b3afb81855ae728b9e20f8af8632c9cd9f4e58
|
|
Bug: 6993891
Change-Id: I0137ea3a72e0ee1a75f9218fec471049abf36d97
|
|
Bug: 6993891
Change-Id: I3ef54efc0ff92367ea4f9b68c1629a99d90ff22c
|
|
Bug: 6993891
Change-Id: I921ec71fffbd4d4a058bab29ded8a6ac62adfb70
|
|
Cherry pick of I7d4a292ebc306b51666d9aa840ddcb2a7e5770fb from jb-mr1
bug: 7297096
Change-Id: I6d95d5d6e2f9ef320002b344af82c9c7a38ffde8
|
|
- Also moving some shared utilities.
Bug: 6993891
Change-Id: I5fa18d26e4f5423f4d3f3450b8f3e3dacbfb947a
|
|
- These classes are only used by dialer code.
- Fixed import order.
Bug: 6993891
Change-Id: I7941a029989c4793b766fdc77a4666f9f99b750a
|
|
- removed dependency on com.android.phone.common jar (old package)
Bug: 7054788
Change-Id: I8c1f6449534a946f4660a9e8924079c08ff1786c
|
|
Bug: 6993891
Change-Id: I758ce359ca7e87a1d184303822979318be171921
|