summaryrefslogtreecommitdiff
path: root/src/com/android/dialer/calllog
AgeCommit message (Collapse)Author
2017-03-01Update dialer sources.Eric Erfanian
Test: Built package and system image. This change clobbers the old source, and is an export from an internal Google repository. The internal repository was forked form Android in March, and this change includes modifications since then, to near the v8 release. Since the fork, we've moved code from monolithic to independent modules. In addition, we've switched to Blaze/Bazel as the build sysetm. This export, however, still uses make. New dependencies have been added: - Dagger - Auto-Value - Glide - Libshortcutbadger Going forward, development will still be in Google3, and the Gerrit release will become an automated export, with the next drop happening in ~ two weeks. Android.mk includes local modifications from ToT. Abridged changelog: Bug fixes ● Not able to mute, add a call when using Phone app in multiwindow mode ● Double tap on keypad triggering multiple key and tones ● Reported spam numbers not showing as spam in the call log ● Crash when user tries to block number while Phone app is not set as default ● Crash when user picks a number from search auto-complete list Visual Voicemail (VVM) improvements ● Share Voicemail audio via standard exporting mechanisms that support file attachment (email, MMS, etc.) ● Make phone number, email and web sites in VVM transcript clickable ● Set PIN before declining VVM Terms of Service {Carrier} ● Set client type for outbound visual voicemail SMS {Carrier} New incoming call and incall UI on older devices (Android M) ● Updated Phone app icon ● New incall UI (large buttons, button labels) ● New and animated Answer/Reject gestures Accessibility ● Add custom answer/decline call buttons on answer screen for touch exploration accessibility services ● Increase size of touch target ● Add verbal feedback when a Voicemail fails to load ● Fix pressing of Phone buttons while in a phone call using Switch Access ● Fix selecting and opening contacts in talkback mode ● Split focus for ‘Learn More’ link in caller id & spam to help distinguish similar text Other ● Backup & Restore for App Preferences ● Prompt user to enable Wi-Fi calling if the call ends due to out of service and Wi-Fi is connected ● Rename “Dialpad” to “Keypad” ● Show "Private number" for restricted calls ● Delete unused items (vcard, add contact, call history) from Phone menu Change-Id: I2a7e53532a24c21bf308bf0a6d178d7ddbca4958
2017-01-27Merge "Make missed call notification a noisy notification" am: 1e721c9f30 ↵sail
am: c1bd6a1959 am: d0f276eb48 am: 8f2f4ad42d Change-Id: I4fc6620da406f18f24900c8ec431fc413ae96eaf
2017-01-25Make missed call notification a noisy notificationHans Månsson
By making the notification noisy a missed call will trigger the pulsing of the notification LED. Currently there is nothing that indicates that a user missed a call when the display is off. Bug: 34696338 Test: Call the device, miss the call, confirm LED is pulsing. Change-Id: Ic0d3831bc847d9189a7318ded9e0b1a2869c25e4
2016-06-01Fix missed call notification dialing wrong numberSailesh Nepal
This CL fixes a bug where clicking the "callback" button on the missed call notification would dial the previous missed call. To reproduce the bug you had to do the following: - get a missed call from Party A - clear the missed call count by launching dialer and navigating to the call log then pressing home. Clearing the missed call count by swipping away the notification should also work. - get a missed call from Party B - click "callback" on the new missed call notification Previously this would result in Party A getting called back. The problem was that we were using the wrong pending intent flags: - Flag 0: before ag/925201 we were using 0 which meant that the pending intent with Party A was being used. - FLAG_ONE_SHOT: after ag/925201 we were using FLAG_ONE_SHOT which meant that the pending intent would be cancelled after the first use (after the user clicked callback on Party A). If the user never clicked callback on Party A then the intent would be re-used. Fix was to use FLAG_UPDATE_CURRENT instead. This ensured that the pending intent was always updated with the last missed call number. Bug: 29065901 Change-Id: I8515e82d178348235d775b7a110e662652b3385b (cherry picked from commit e5b24ecbe50bd79d2ce7ad8a284ac17ad1284d83)
2016-06-01Fix missed call notification dialing wrong numberSailesh Nepal
This CL fixes a bug where clicking the "callback" button on the missed call notification would dial the previous missed call. To reproduce the bug you had to do the following: - get a missed call from Party A - clear the missed call count by launching dialer and navigating to the call log then pressing home. Clearing the missed call count by swipping away the notification should also work. - get a missed call from Party B - click "callback" on the new missed call notification Previously this would result in Party A getting called back. The problem was that we were using the wrong pending intent flags: - Flag 0: before ag/925201 we were using 0 which meant that the pending intent with Party A was being used. - FLAG_ONE_SHOT: after ag/925201 we were using FLAG_ONE_SHOT which meant that the pending intent would be cancelled after the first use (after the user clicked callback on Party A). If the user never clicked callback on Party A then the intent would be re-used. Fix was to use FLAG_UPDATE_CURRENT instead. This ensured that the pending intent was always updated with the last missed call number. Bug: 29065901 Change-Id: I8515e82d178348235d775b7a110e662652b3385b
2016-05-06Update isRemoteDirectory to isRemoteDirectoryId in dialerTony Mak
One more place needed to be updated in master.
2016-04-28Merge "Cache call type icons" into nyc-dev am: e5634164a0 am: 83d13261baSailesh Nepal
am: 91e928cffb * commit '91e928cffb0ac82849dd89e7251e04dbb3b9a697': Cache call type icons Change-Id: I2229d2c103ae0da8bbcf194ac328f28d193be055
2016-04-28Merge "Cache call type icons" into nyc-devUsman Abdullah
2016-04-20Call correct number from missing call notification.Qi Wang
Change-Id: I97c8214e620378dd32f3778040f2f2b3e1cd58f0 Fix: 28068914 (cherry picked from commit 217b96bd8ccc6874d14a1be84d639ee2d9ba1802)
2016-04-20Cache call type iconsSailesh Nepal
Looking at the trace attached to b/28142787 it looks like CallTypeIconsView.Resources is created frequently. In my local testing with 9 items in my call log, it was created 23 times on load and 3 more times on scroll. According to the trace, creating a Resources object can be expensive. In one frame decodeBitmap was called 3 times and took 1.4 milliseconds. This CL works around the issue by caching the Resources object. This should be ok. The only downside of this is: - the cache won't be updated if the DPI variant changes - the cache won't be released if we get a memory pressure event Bug: 28142787 Change-Id: Ibc2ef02f7c92022deabedd70b1af135a10c9df29 (cherry picked from commit 341185547f9d54566055b270f69f1b93f0301c36)
2016-04-15Update ExtendedCallInfoService reporting methods to accept location.Sarmad Hashmi
+Add IntDef which contains all the possible locations numbers can be reported as spam or not spam from. +Updated method calls to include location BUG=27323295 Change-Id: I549e439af328447fbbf0c61116cdff9b1b877334
2016-04-15Refactor block/report dialogs and put into utility class.Sarmad Hashmi
+Put all the dialog creation code in one place so they can be re-used +This is mainly for the after call notification because the same dialogs will be shown in an invisible activity +Create listener for determining whether a user checked the spam checkbox +Change to DialogFragments for easy reusing of dialogs Change-Id: I67e13bc0e61952299a4770c9184543ef8b63728a
2016-04-13Merge "Call correct number from missing call notification."Qi Wang
2016-04-12Add after call notification code in InCallUI.Sarmad Hashmi
+Add asynchronous call to update inCallHistory boolean variable which specifies whether the number is in the call history (has previously called before) +Add CallHistoryStatus enum and variable to Call object to determine if the number is present in the call history +Added SpamCallListListener object which listens for changes in the CallList +Update the CallHistoryStatus for the call whenever an incoming call comes in +Added 11 tests for new listener BUG=27323295 Change-Id: I242cd4a53b3aeca69fbce972221a2c941d9d37ce
2016-04-12Call correct number from missing call notification.Qi Wang
Change-Id: I9daa0fd75fdeb201f5d7973a1431579ec7251bf7 Fix: 28068914
2016-04-08Merge "Fix UI issues in call logs when spam is not enabled."Qi Wang
2016-04-08Fix UI issues in call logs when spam is not enabled.Qi Wang
* Don't add spam related action menu to call log. Change-Id: Id32a7e0e0819c780bcb60e917ea6f4a4d19394c9
2016-04-07Merge "Fix bug where call cards from private number are blank."Sarmad Hashmi
2016-04-07Fix bug where call cards from private number are blank.Sarmad Hashmi
+Revert ag/904832 and add proper fix +ag/904832 was an incorrect fix for the bug because the isBlockedNumber method in FilteredNumberAsyncQueryHandler is not supposed to call onCheckComplete on the listener if the number was invalid. All callers of the method isBlockedNumber must, in addition to checking if the result was invalid in the callback, also check the result of the call to see if it was false. +This change removes the callback call if the number is invalid and instead adds a check in CallLogAdapter right after isBlockedNumber is called to determine if the number was valid. If not, the views are rendered. Change-Id: Ib4eaafd38c28afb8acacd94fd6716c4042286968
2016-04-07Merge "Add via number to CallLog Account entry" into nyc-dev am: 87b9abfBrad Ebinger
am: 8607dfb * commit '8607dfb43c2707ca534d68f2dcf728fece01c82b': Add via number to CallLog Account entry Change-Id: I55e9f40fb5497a4edeec31fc0abeb2efd459f1a2
2016-04-06Add via number to CallLog Account entryBrad Ebinger
Call Log now provides the phone number that an incoming call was received on if that number is different than the SIM subscription number. This "via number" is appended to the Phone Account of the Call Log entry in Dialer if it exists. Screenshots: - One PhoneAccount: http://screen/HuCSL0U6jU6.png - Multiple PhoneAccounts: http://screen/pDg8F9zpMei.png Bug: 25594198 Change-Id: I8c05ea98409e54d20493fbdb20096bf851480719
2016-04-06Add dialogs for spam report and block.Qi Wang
Screenshots: 1. block/report spam https://screenshot.googleplex.com/5e772Kikikw 2. block https://screenshot.googleplex.com/AEpYSYoL2E8 3. unblock(is spam and report not a spam) https://screenshot.googleplex.com/AEZfhCXj4h8 4. unblock(not spam) https://screenshot.googleplex.com/r7YkHuCMT1p 5. report not spam https://screenshot.googleplex.com/jkcpm0pdKoj Change-Id: I78fbbacece44632614026c03909289995bef5b14 Fix: 27295785
2016-04-04Integrate spam feature into call logs.Qi Wang
+ Add block and report spam actions. + Show spam icon and label for call log item. + Add stableIds for CallLogAdapter to improve performance(reuse same viewItem to minimize update work). * Fix funky UI of call log. Change-Id: I6144d70b6a8e38061e1447d0d01910d53026d1db Fix: 27295728 Fix: 26907466
2016-03-30Fix merge.Sarmad Hashmi
+Remove line that was removed by ag/874074 and added back in by ag/886674. Change-Id: I8f501655356ccf5ff605a0eb705ec38e1ded9025
2016-03-30Fix Dialer crash loop for caller id in personal contact directoryVictor Chang
The bug is dialer queries CP2 for alternative name by lookup key of personal directory CP2 throws IllegalArgumentException as the lookup key is not found locally 2 fixes are included to avoid this happening 1. slient IllegalArgumentException since alternative name is not very important to crash dialer. (It's a fix by reverting some changes in ag/880910) 2. Check directory id before querying CP2 either one should fix this bug. Include both to make sure that it's not crashed. Unit test added. Bug:27905000 Change-Id: Ib8eab5f718a168fcec2785c3101e96bb91521d40
2016-03-30[DO NOT MERGE] Fix Dialer crash loop for caller id in personal contact directoryVictor Chang
The bug is dialer queries CP2 for alternative name by lookup key of personal directory CP2 throws IllegalArgumentException as the lookup key is not found locally slient IllegalArgumentException since alternative name is not very important to crash dialer. (It's a fix by reverting some changes in ag/880910) Bug:27905000 Change-Id: I1d61f52df63d93c9c7da436c7f2da2bdf3cced0c
2016-03-21Fix mergeTa-wei Yen
Merge in ag/886674 was done incorrectly on CallLogAdapter. This CL revert the changes. Change-Id: I1779c205f9be8250acd5a4455608b857c6198663
2016-03-21Merge "Only allow primary users to block numbers" into nyc-dev am: c98a563Brandon Maxwell
am: 25b094b * commit '25b094b0473bb52238d7d45d4ba69b0d9949121c': Only allow primary users to block numbers
2016-03-18Only allow primary users to block numbersBrandon Maxwell
+ By design, only the primary user has the capability to block numbers. + This CL ensures that secondary users don't see the option to block numbers in the call log or call details. Change-Id: I576925510cfbef417c16910218014d9f7b7dd2a0 Fixes: 27366206
2016-03-18Merge "Fix dialer crash on unknown number call." into nyc-dev am: 5da20d4Sarmad Hashmi
am: 74a4339 * commit '74a4339953bf2a41a4cd1e73a88b0edfafa50585': Fix dialer crash on unknown number call.
2016-03-18Fix dialer crash on unknown number call.Sarmad Hashmi
+Number is set to empty string if null +Added 11 tests for getContactInfo method, mainly testing various combinations of inputs BUG=27725458 BUG=27724999 Change-Id: Ic64fbdb7490a3c07145310cf02249555bfc963a3
2016-03-17Merge "Return null constructing a malformed PhoneAccountHandle" into nyc-dev ↵Brad Ebinger
am: ef2fdd5 am: ad6fbc0 * commit 'ad6fbc0f594341d23f33ccf73c765e9b2dc9adab': Return null constructing a malformed PhoneAccountHandle
2016-03-17Merge "Return null constructing a malformed PhoneAccountHandle" into nyc-devBrad Ebinger
2016-03-17Return null constructing a malformed PhoneAccountHandleBrad Ebinger
Return null when constructing a PhoneAccountHandle if the ComponentName from the database is malformed. Bug: 26684527 Change-Id: I76a3e61699e0646cdf0b715d7b3908611cdca8ff
2016-03-17Prevent incorrect call log item from expanding when new item arrives am: fa15094Ta-wei Yen
am: ad39eb2 * commit 'ad39eb2ab71faf5c1750595e4fd8adcf898113f1': Prevent incorrect call log item from expanding when new item arrives
2016-03-16Prevent incorrect call log item from expanding when new item arrivesTa-wei Yen
mCurrentlyExpandedPosition is unreliable when the list is changing, use mCurrentlyExpandedRowId to determine which item is expanded instead. Positions stored in CallLogAdaptor are also invalidated when the list is changing. Bug:25283769 Change-Id: Iffca8c7d65933cfcdd12f2f3cc85170226db1c4a
2016-03-16Merge "Add default phone account fallback for voicemail notification" into ↵Ta-wei Yen
nyc-dev am: fb29931 am: c1f6650 * commit 'c1f6650d632e7aba3d9ec5a2ca28cf4c25a929f9': Add default phone account fallback for voicemail notification
2016-03-16Merge "Add default phone account fallback for voicemail notification" into ↵Ta-wei Yen
nyc-dev
2016-03-15Add default phone account fallback for voicemail notificationTa-wei Yen
Sometimes the accountComponentName and accountId field of the new voicemail will not be populated by the voicemail source, so a PhoneAccountHandle used to retrieve the voicemail ringtone can not be created. Previously we fallback to the default notification sound. In this CL we will attempt to get the voicemail ringtone from the default phone account before falling back to notification sound. Bug:21699149 Change-Id: Ia1c09f5aa32c000cca245c669304cacf4f792c01
2016-03-15Fixing buildSarmad Hashmi
+ A merge was performed improperly which caused an import to be removed, but the code using the imported object wasn't. This resulted in build failures since the necessary class wasn't imported. + This change properly performs the merge of cdc14da9275c67d123b55e668f48f73c4b58d948. Change-Id: Ifb78cc75aff18a9c632c7c5e1a3121858383296a
2016-03-15Merge "Removing hardcoded database column name" into nyc-dev am: aae1559613Brandon Maxwell
am: 3cd1ce6c88 * commit '3cd1ce6c8801c338f45dad8688e2f742f910382d': Removing hardcoded database column name
2016-03-15Merge "Removing hardcoded database column name" into nyc-devBrandon Maxwell
2016-03-15Merge "Implemented blocked numbers migration" into nyc-dev am: 4cdae0926cBrandon Maxwell
am: 55c2efe5a5 * commit '55c2efe5a514447c697a678c52708b8eb7fc5406': Implemented blocked numbers migration
2016-03-15Merge "Implemented blocked numbers migration" into nyc-devBrandon Maxwell
2016-03-14Implemented blocked numbers migrationBrandon Maxwell
+ After upgrading to N, users need to be able to migrate their blocked number list from the Dialer solution to the framework solution. Prior to migrating, when a user attempts to block a number, a Dialog is shown prompting them to migrate their numbers. Users must migrate to continue adding numbers to their block list. Users that decide not to migrate will still have calls and voicemails blocked for numbers that are currently on their block list. + This CL implements the logic which copies users' blocked numbers lists to the framework solution. Bug: 26664600 Change-Id: I44dee1306b5daca6f558c81b2b58252b35013e09
2016-03-14Merge "Potential fix for voicemail icon near dialer but no voicemail." into ↵Sarmad Hashmi
nyc-dev am: 1034966af6 am: 290a699617 * commit '290a699617772faab8cc0c48f322b52ad954462b': Potential fix for voicemail icon near dialer but no voicemail.
2016-03-14Merge "Potential fix for voicemail icon near dialer but no voicemail." into ↵Sarmad Hashmi
nyc-dev
2016-03-14Potential fix for voicemail icon near dialer but no voicemail.Sarmad Hashmi
+Only count voicemails that are unread and have not been marked for deletion. BUG=27548694 Change-Id: I8d6707087bd4a400eb073ac4c2c7e2689a065052
2016-03-14Adding block numbers migration dialog am: c6ed16091cBrandon Maxwell
am: fbbc38a5bb * commit 'fbbc38a5bb9aac10906c901987352ef2d7c74bf4': Adding block numbers migration dialog
2016-03-14Adding block numbers migration dialogBrandon Maxwell
+ When the user attempts to block a number and they haven't migrated to the framework blocking implementation, they should be shown a dialog that asks them to migrate. This CL introduces the Dialog that is shown and updates the Call log and Call details to open it. + As part one of the change, the Dialog is shown every time the user attempts to block or unblock a number (when the feature is enabled). A later CL will complete this migration step to ensure that the dialog is only shown until migration is finished. Bug: 26664600 Change-Id: Ia4c2d504f8d98679b90d232058eb5ee6ea9b38f1
2016-03-11Merge "Query lookup uri with work lookup key directly is not allowed" into ↵Tony Mak
nyc-dev am: ebfbfa10d9 am: 769f26fe74 * commit '769f26fe7488415cb677d4980540bbd7dcfc3ac0': Query lookup uri with work lookup key directly is not allowed
2016-03-11Removing hardcoded database column nameBrandon Maxwell
+ We were previously hardcoding the post_dial_digits column name. This code was written before we had src-N and src-pre-N folders. + This CL converts the hard coded column name to follow the pattern we have for new stuff in the SDK. + Additionally, this CL removes an unneeded method which checks the SDK version, instead using the CompatUtils class. Bug: 25021389 Change-Id: I017d47f7efd323254e616a64d7ac824c5cfb8902
2016-03-11Query lookup uri with work lookup key directly is not allowedTony Mak
Query lookup uri with work lookup key directly is not allowed, app crashes if doing so. And actually, all APIs do not support work lookup key except those explicitly say it does. This Cls changed two places: 1. Do not pass lookup uri with work lookup to NotificationManager to avoid NotificationManager using the uri to query. 2. Dialer perform query for alternative display name using lookup key. But if it is a work contact, do not do so. Bug: 27146678 Change-Id: Ie59c37ff43b6f953a96564c446d79d8812f5ada1
2016-03-10Merge "Fixing missed call notifications for FBE" into nyc-dev am: bb293bfd56Brandon Maxwell
am: d34a408c71 * commit 'd34a408c71e8f791f74c5b19e5c8d5cb2a710522': Fixing missed call notifications for FBE
2016-03-10Fixing missed call notifications for FBEBrandon Maxwell
+ Our new components for creating missed call notifications are not marked as encryption aware so Telecom was always creating the missed call notification. + This CL marks the appropriate components as encryption aware so Telecom can check to see if we support putting up the notification. + Updated logic so missed call notifications only have 'callback' and 'message' actions when not locked. + Misc FBE cleanup + Since the call log is not available when on the File based encryption lock screen, dismissed notifications will not attempt to mark the calls as read; attempting do so causes exceptions. + Updated AOSP Dialer to ensure that we don't store data in device encrypted storage by default. This storage location is always available, regardless of whether we're in the FBE locked state or not. None of our preferences/databases need to be available in this state, so this change causes the Dialer to store data in credential encrypted storage by default. This storage location is only available when the device is unlocked. + Updated AOSP Dialer so it doesn't use device encrypted storage by default. This is because we currently don't want any of the preferences/databases stored by the Dialer to be available when FBE locked. + Updated AOSP Dialer so specific components must mark themselves as encryption aware, rather than having everything aware because the application is marked as such. Bug: 27455726 Change-Id: Ib5d28267116ec007bf9beb57862796235460ddf5
2016-03-08Merge "Add contact photo for missed call notifications" into nyc-dev am: ↵Ta-wei Yen
5d635baea2 am: e70be0ca00 * commit 'e70be0ca00a5ed4699f1a91759de2905e8bcefdc': Add contact photo for missed call notifications
2016-03-07Add contact photo for missed call notificationsTa-wei Yen
+ ContactPhotoLoader to create the appropriate icon from a ContactInfo - NameLookupQuery in CallLogNotificationsHelper#getContactInfo To show a photo the name is not enough. Full query need to be made to retrieve the photoUri. + class Assert in util + Gradle directory setup for dialer tests (Note: this is just for project setup in Android Studio, tests are still not runnable in gradle) Bug:27276108 Change-Id: I0ed2147f2bb60454fe5a5ad6c25fe99727441880
2016-03-04Merge "Add files for voicemail archive tab." into nyc-dev am: ee8f5a3c0dSarmad Hashmi
am: af04b7b8d5 * commit 'af04b7b8d5bad8998f875ee0a28df36d5b6e97c5': Add files for voicemail archive tab.
2016-03-04Update call log adapter and related files for archived voicemails. am: ↵Sarmad Hashmi
6b0056f348 am: 5054493a46 * commit '5054493a465991ad2b8d4b1d885a66810e08414a': Update call log adapter and related files for archived voicemails.
2016-03-04Merge "Add files for voicemail archive tab." into nyc-devSarmad Hashmi
2016-03-04Update call log adapter and related files for archived voicemails.Sarmad Hashmi
+ Populate CallLogAdapter items with different data depending on whether it is in the voicemail archive activity or not + Added addVoicemailGroups method to CallLogGroupBuilder so that every voicemail is put into an individual group + Voicemails grouped differently than regular calls, so added changeCursorVoicemail in GroupingListAdapter +Fix CallLogAdapter tests and add test for archive adapter BUG=22797391 Change-Id: Ib8387c5b3ab8c5e39876cfaf20fde5a44295f152
2016-03-03Add files for voicemail archive tab.Sarmad Hashmi
+ Added VoicemailArchiveActivity which displays all voicemails archived by the user + VoicemailArchivePlaybackPresenter is the same as VoicemailPlaybackPresenter except that it does not need to request content from the voicemail server +Added tests (combined common methods and attributes for regular voicemail tab and voicemail archive used for tests) BUG=22797391 Change-Id: I4064eea945b9e257ec6c7ada35cf5ac1657dc866
2016-03-03Merge "CallLogListItemViewHolder distinguishes block/spam numbers" into ↵Gilles Franck Mevaa
nyc-dev am: 79e26069d2 am: ee9552eca9 * commit 'ee9552eca9cd2692124f4eb0aea628871992910e': CallLogListItemViewHolder distinguishes block/spam numbers
2016-03-03Merge "Fixing missed call badge query" into nyc-dev am: 81aeb4053aBrandon Maxwell
am: 7210993449 * commit '7210993449b31ee80e56e77bd0acbc1dceea2494': Fixing missed call badge query
2016-03-03Merge "CallLogListItemViewHolder distinguishes block/spam numbers" into nyc-devGilles Franck Mevaa
2016-03-02CallLogListItemViewHolder distinguishes block/spam numbersGilles Franck Mevaa
A new method is added to show the appropriate photo and label if the number is either blocked or spam. This occurs after the normal photo and labels are rendered. Because of that, there is a flickering if the photo and labels should be changed. b/27295728 will help track the fix of the flickering bug. Change-Id: I639c0c0d4167b48956892f2b955d4e1f0cc8e8eb
2016-03-02Fixing missed call badge queryBrandon Maxwell
+ Previously the query for the missed calls only checked if the calllog is_read column was equal to 1. The situation where a callog entry exists because it was copied from another user's calllog (such as for File based encryption), the value of is_read is null rather than 0 or 1. + This CL updates the query to return those calllog entries that have null for is_read too. This logic matches the logic for making a calllog entry bold when it's unread. Bug: 27168340 Change-Id: I73dba6920a3eaf352feae4d23cc3f55d51bd1efd
2016-02-25Mark missed calls as read on swipe. am: cb55981252Sarmad Hashmi
am: 55b9d729f5 * commit '55b9d729f5a80621449756eced19faf8dde9420c': Mark missed calls as read on swipe.
2016-02-24Mark missed calls as read on swipe.Sarmad Hashmi
When swiping to a new tab, if the previous tab that the user was in was the call history tab, all missed calls are marked as read and the tab count is updated. Also fixes b/27153608 and clearing of missed calls on orientation change. BUG=27136093 BUG=27153608 BUG=27154514 Change-Id: I5be31b1a3978784b941fb8e1af22f93fb6ca944a
2016-02-24[DO NOT MERGE] Display missed call count for call log.Sarmad Hashmi
The number of unread missed calls are displayed beside the Call Log as a badge. All unread missed calls are bolded under the call log tab. When exiting the call log tab, all unread calls are marked as read. When interacting with an unread missed call card while in the call log tab, it will subtract 1 from the badge. Cherry-picked from d118a8e0d8a68499398504f350f81175118e2ecf BUG=24953555 Change-Id: If91a3bc89197465934cb773955e4bec005d6d14e
2016-02-24Fix bug where 00:00 duration is shown for voicemails without a duration.Sarmad Hashmi
Instead of showing a 00:00 duration, nothing is displayed. When the content is loaded, the duration field for the call log entry associated with the voicemail is updated with the duration fetched from the mediaplayer. The proper duration is then displayed in MM:SS format. BUG=24175525 Change-Id: I1cafebae4fcbc749f573accfcf8833b598675f0b (cherry picked from commit 6f3016d9065564bf09a5759f16563a05abbe105d)
2016-02-24Collapsed and expanded voicemail cards show duration.Sarmad Hashmi
The duration of the voicemail is appended to the date in a MM:SS format. BUG=25728257 Change-Id: I9c3e392336877c2ca69707e14c6ab2eed6f2e7c6 (cherry picked from commit 3f70c27d80b2e3176159f561248f95612d66afe2)
2016-02-22[Gradle] Allow dialer to be compiled as a library am: 68d86c656eSailesh Nepal
am: 429e15a3de * commit '429e15a3de2e5cfbc2c44071e97981e583f1ed15': [Gradle] Allow dialer to be compiled as a library
2016-02-22Merge "Show Briefcase icon not displayed in in-call UI for work SIP calls" ↵Tony Mak
into nyc-dev am: 639ed3451d am: c58829eee0 * commit 'c58829eee08d834b40909ea780ba666af44262ed': Show Briefcase icon not displayed in in-call UI for work SIP calls
2016-02-22[Gradle] Allow dialer to be compiled as a librarySailesh Nepal
This CL adds a new build-library.gradle file for AOSP dialer. This allows the dialer to be built as a library that can be included from GoogleDialer. Switching to a library project meant making two other changes: - changed all switch statements that used resources to if statements. This was required because resource IDs are not final in library projects. - changed InCalUI code to import com.android.dialer.R instead of com.android.incallui.R. See http://b.android.com/82743 for more info on why this is required. src-N isn't supported yet. Also, this isn't the ideal project layout. In the future we should consider switching to the following layout: - dialer/incallui/ <- incall UI as an independent library project - dialer/dialerlib/ <- dialer code as an independent library project - dialer/app <- skelent app that builds a standalone dialer AOSP app Bug: 26676586 Change-Id: I07fbee4d33cc683539e4f8b3953c93f1427af9d7
2016-02-22Merge "Show Briefcase icon not displayed in in-call UI for work SIP calls" ↵Tony Mak
into nyc-dev
2016-02-22Show Briefcase icon not displayed in in-call UI for work SIP callsTony Mak
Current dialer always queries PhoneLookup._ID and uses this as a contact ID. In pre-N, contact id of non-sip query is stored in PhoneLookup._ID and it is actually a mistake. This problem does not exist in sip query, and contact id of sip query is stored in Data.CONTACT_ID. So it is a "bug" in dialer that we use PhoneLooup._ID for sip query as it is not really a contacat id. The bug of missing work badge may not be the only issue introduced by this. In N, the issue is get fixed in framework, PhoneLookup.CONTACT_ID is introduced. We should access PhoneLookup.CONTACT_ID no matter what phone lookup query we are having. The ideal case is we always use PhoneLookup.CONTACT_ID for retrieving contact id, but given that we need to support in pre-N, we need to query PhoneLookup._ID for contact id in non-sip query in pre-N. BUG:27242975 Change-Id: Id14378e3dce5b07629ffe0c6e83c3d107fbb468e
2016-02-20Merge "Null check for accountComponentName and Id" into nyc-dev am: 6a39673606Brandon Maxwell
am: 5842e41f3f * commit '5842e41f3f336041569d2c3537491d2bd99ed1bc': Null check for accountComponentName and Id
2016-02-19Null check for accountComponentName and IdBrandon Maxwell
+ Voicemails were coming in with a null accountComponent name causing crashes. It's unknown why this is the case. This change checks for null prior to attempting to use these fields. Bug=27202534 Change-Id: I48f4f188bd75aca7204d74aecfe76f2c75b730d8
2016-02-18Merge "Fix bug where 00:00 duration is shown for voicemails without a duration."Sarmad Hashmi
2016-02-17DO NOT MERGE: Listener of spam eventsGilles Franck Mevaa
Getting rid of the Manager to have the ButtonRenderer directly communicate changes to an event listener. Implementation changes in ag/863096. Cherry picking to nyc-dev to fix build. Change-Id: I8061116f0b91e3f5a6a3a6eac09fe2171ebcbd5c
2016-02-16Listener of spam eventsGilles Franck Mevaa
Getting rid of the Manager to have the ButtonRenderer directly communicate changes to an event listener. Implementation changes in ag/863096. Change-Id: Ie67de81bfc6fe8c3dd6812c35685d4709be7f133
2016-02-12Use DATA.CONTACT_ID when lookup SIP callTony Mak
It is actually a naming mistake in framework, the column store contact id of normal query is _id, but that of sip query is contact_id. It is an old issue and we can't do much in the framework side. So, we need to use the correct projection when it is a SIP call. Bug:27143980 Bug:27141566 (cherry picked from commit 328f75ff518bf7d8863c6cf4446e26636e05b297) Change-Id: I0551c308072892ef13c8cb14ea4a4ab37ffa6f83
2016-02-12Merge "Use DATA.CONTACT_ID when lookup SIP call"Tony Mak
2016-02-11Temporary fix for call history crash.Sarmad Hashmi
The call history crashes because the call log fragment tries to update unread tab counts but these do not exist within the call history activity. BUG=27153608 Change-Id: Ica5517ca733b29981dab76dbdca2b678d69e0306
2016-02-11Use DATA.CONTACT_ID when lookup SIP callTony Mak
It is actually a naming mistake in framework, the column store contact id of normal query is _id, but that of sip query is contact_id. It is an old issue and we can't do much in the framework side. So, we need to use the correct projection when it is a SIP call. Bug:27143980 Bug:27141566 Change-Id: I6a7eb6952f9cec5b8ea2461540806224c7a69640
2016-02-11Renaming Dialer elements from Spam to ExtendedBlockingGilles Franck Mevaa
Change-Id: I2ad8e07cf6538ed7b5685b2f9695acb09a71e483 (cherry picked from commit 5c0cbaeaadf976a821128a99462beda4ac6955d7)
2016-02-10Fix bug where 00:00 duration is shown for voicemails without a duration.Sarmad Hashmi
Instead of showing a 00:00 duration, nothing is displayed. When the content is loaded, the duration field for the call log entry associated with the voicemail is updated with the duration fetched from the mediaplayer. The proper duration is then displayed in MM:SS format. BUG=24175525 Change-Id: I1cafebae4fcbc749f573accfcf8833b598675f0b
2016-02-10Merge "Collapsed and expanded voicemail cards show duration." into ↵Sarmad Hashmi
ub-contactsdialer-master-dev am: 6b6c6b756c * commit '6b6c6b756c54ef97c8ef6b445152dfaa1c42a5eb': Collapsed and expanded voicemail cards show duration.
2016-02-09resolve merge conflicts of e14ae7dd12 to master.Sarmad Hashmi
Change-Id: I44128233cb86b34db3f7d2b1e4ca1aa0f6d1b518
2016-02-09Merge "Collapsed and expanded voicemail cards show duration." into ↵Sarmad Hashmi
ub-contactsdialer-master-dev
2016-02-09Display missed call count for call log.Sarmad Hashmi
The number of unread missed calls are displayed beside the Call Log as a badge. All unread missed calls are bolded under the call log tab. When exiting the call log tab, all unread calls are marked as read. When interacting with an unread missed call card while in the call log tab, it will subtract 1 from the badge. BUG=24953555 Change-Id: If91a3bc89197465934cb773955e4bec005d6d14e
2016-02-09Collapsed and expanded voicemail cards show duration.Sarmad Hashmi
The duration of the voicemail is appended to the date in a MM:SS format. BUG=25728257 Change-Id: I9c3e392336877c2ca69707e14c6ab2eed6f2e7c6
2016-02-06Renaming Dialer elements from Spam to ExtendedBlockingGilles Franck Mevaa
Change-Id: I2ad8e07cf6538ed7b5685b2f9695acb09a71e483
2016-02-04Show work call title for missed call notificationVictor Chang
1. return complete ContactInfo in CallLogNotificationsHelper 2. use ContactInfo.userType to decide use work call title or not BUG=26902076 Change-Id: Ic58fea1002de053ba69bc0aff06691b8a8605e64
2016-02-01Refactor VVM specific code from CallLogFragmentTa-wei Yen
Moved visual voicemail code from CallLogFragment to VisualVoicemailCallLogFragment. Expected to have a lot of VVM specific code in the fragment, so it's better to separate them. Change-Id: I0fcad51d08f1a174a42f940fd455ce885d76c4ae
2016-01-28Merge "Remove the work badge icon for Google caller id in call log" into ↵Victor Chang
ub-contactsdialer-b-dev
2016-01-27Look up missed call contact info in cache.Nancy Chen
For missed calls that can be identified with Google Caller ID, we want to look up the contact information in the cache because that's where the information will be if it was looked up when the call was incoming. Bug: 22857261 Change-Id: I2563c9f5e99bdc91674b9b46def1eeabeb45794d
2016-01-27Display missed call notifications in Dialer.Nancy Chen
Dialer is now putting up the missed call notification instead of Telecom. As a result, it has to handle receiving a new missed call broadcast and sending requests back to Telecom to update the missed call count. + MissedCallNotifier class displays notifications and triggers call back sms, and dismiss intents. + CallLogNotificationsService added actions it can handle for missed calls. + MissedCallNotificationReceiver receives the missed call intent to update the notifications. Bug: 22857261 Change-Id: I03a3c3b5a2533a3ea26d668124fcaf3fa72347fc
2016-01-27Remove the work badge icon for Google caller id in call logVictor Chang
An extended directory is custom directory in the app, but not a directory provided by framework. So it can't be USER_TYPE_WORK When a search result is selected, RegularSearchFragment calls getContactInfo and caches the resulting @{link ContactInfo} into a local db. Set userType to USER_TYPE_WORK only if it's NOT extended directory id and is enterprise directory BUG=26680007 Change-Id: I92aa4b7c3dac20257e689eb0a4dfa0afbd81764c