Age | Commit message (Collapse) | Author |
|
Previously visual voicemail notifications did not align with the
telephony voicemail notification settings that the user could visit
through dialer settings. After adding an API to access those telephony
settings, dialer can now read those settings and use them when providing
notifications for visual voicemail.
Bug: 24164917
Change-Id: I2510dc3d3f1b5b54a378b2c0d59a24ae1ff198d7
|
|
ub-contactsdialer-b-dev
|
|
In preparation for sharing code with the MissedCallNotifier, factor out
the potential common code into CallLogNotificationsHelper.
+ Turn CallLogNotificationsHelper into a singleton.
+ Copy over NewCallsQuery and NameLookupQuery classes.
+ If it is a voicemail with unknown number, display the string
"unknown".
Bug: 22857261
Bug: 25020236
Change-Id: Ie181472bd4588466ec5f37c8cbacf023ba1a21c4
|
|
ub-contactsdialer-b-dev
|
|
This includes small UI additions to the call log UI; Mainly,
two new buttons to mark each phone number entry as a Spam number
or remove the phone number from the spam list. This also includes
a service definition that will be needed to render the buttons or
keep them hidden.
Change-Id: I7cf22f6027728ebc0dfe9e3b5b923ee70bcaadd2
|
|
For calls, we will never display an empty name field because we have the
"name presentation" from the call that will inform the UI how to display
the name (whether "restricted", "unknown", etc.). However for
voicemails, there is no such similar field because the voicemail is not
associated with a particular call. In the case where the name field in
the voicemail table is blank (which would be the case if the server failed to
provide it or the caller obscured their phone number), instead of
displaying an empty string, this CL defaults the name to "unknown".
Bug: 25020236
Change-Id: I7355abb88ac4ac90f7b19c86f335964aaad336aa
|
|
ub-contactsdialer-b-dev
|
|
This reverts commit 5cfa2c31a9877563a383c3c6ee10790af9db61d0.
Change-Id: Iabae03ca3dc671775779e2a61e380193341fad8a
|
|
ub-contactsdialer-b-dev
|
|
Add work badge icon in calllog for work contacts
To see this feature
1. Receive/Make a call from work contact
(a contact in work profile has the phone number)
2. Drop/miss the call. See a badge icon next to phone label in calllog
BUG=26082618
Change-Id: I7371795e3c3ef925739096f39a70f03722dd430b
|
|
Previously visual voicemail notifications did not align with the
telephony voicemail notification settings that the user could visit
through dialer settings. After adding an API to access those telephony
settings, dialer can now read those settings and use them when providing
notifications for visual voicemail.
Bug: 24164917
Change-Id: I3e8335be7fa1d265616818a6543bfe9242104560
|
|
NumbersAdapater didn't properly handle null returns from
ContactInfoHelper#lookupNumber(String, String), which is part of
the method's documented contract.
Bug=26337800
Change-Id: Ib974e83c22982ad4151fab564c91a61c112ca2ae
|
|
+ Add methods to TelecomManagerCompat
- Move TelecomManagerCompat to ContactsCommon because it is called
within ContactsCommon
- Move TestTelecomCallLogCache to the right package so tests pass
Bug: 25776171
Change-Id: I1963959292d8038ab505488d831afd06e6fef6d0
|
|
am: 52cd5fd66d
* commit '52cd5fd66d0b97e066f89281eb55016dedfeec3a':
Fix potential NPE in DefaultVoicemailNotifier
|
|
Don't try to format an empty number
Bug: 26095129
Change-Id: I6356c24e03066babd22217b24004f9ae9a53a67b
|
|
ub-contactsdialer-b-dev
|
|
BUG=25899500
Change-Id: Ie235822462e2a430b1bec93923bd8c1fe00f101f
|
|
|
|
Bug:25776171
Change-Id: Id6cccaa6af10e91defa70b1c4759cd3b48494e7c
|
|
into ub-contactsdialer-b-dev
|
|
known issue:b/25859809
BUG=25899500
Change-Id: Ia61250707981b49efebb6e2c2e4910f58a1233dd
|
|
|
|
TelecomCallLogCache creates a mapping between PhoneAccount and per-SIM
information like voicemail number which is not relevant pre-LMr1. Create
a compatibility classes so that MSIM functionality is factored out
pre-LMr1.
Bug: 25776171
Change-Id: I67b012110829121dffa42d542aa0395d683fa78b
|
|
Change-Id: Ib4baa544925f8bcc6b8f4df8989927ebb3635ce3
|
|
Bug: 25776171
Change-Id: Ib123da80c6f902c81ad09d9b9ca7fb93df057d1a
|
|
Only if the current sdk version is at least M, do we look up the
CACHED_PHOTO_URI
Bug: 25776171
Change-Id: I79ac81abb4da719ffdb5476476a9a28c287c95f6
|
|
Trap NPE thrown by pre-N CP2.
Bug:25941069
Change-Id: Id510e84e6e7e4a63a9b3267c183e23b73b0fabbc
|
|
Restores code deleted in ag/643285 because the code was used on pre-M.
Bug:25629359
Change-Id: Ief60d301fd8d3c018ce03388c56264a2db727224
|
|
Bug: 25776171
Change-Id: Id567c28af9e2578036c9db97389f66093198de09
|
|
requestPermissions is not available to the Fragments class and
checkSelfPermission is not available to the Context class in API < 23.
Use other backwards compatible methods to implement the behavior.
Bug: 25776171
Change-Id: I6cb221236f28b319f618d2cf32a9f503a6f4e6e0
|
|
am: cbed581719
* commit 'cbed581719fdd31daa0f7aa096bb2ca7d40456d3':
Catch work profile CP2 lookup exception
|
|
Catch IllegalArgumentExceptions throw for work profile contact alternative
display name lookups.
Bug:25680927
Change-Id: I1e3245239c8521de6edc5286a898547fc83bd23e
|
|
am: f3b23ba40d
* commit 'f3b23ba40d6c6c60f7e01c84df69712d7ae9bae0':
Modiying callLog context menu to force numbers LTR
|
|
Bug:25516713
Change-Id: I5b239afa81c7a5e8225f21d57161a5012ab5e421
|
|
am: d81cc6c64f
* commit 'd81cc6c64f3213f571c1f1e7a5c7e59b71491fb0':
Adding Logging to call blocking interactions
|
|
+ Added Clearcut logging when users block, unblock, undo,
or import blocked numbers. Location of blocking is noted, e.g. CallLog,
CallDetails, ManagementScreen
+ Added class with Constants matching proto definition
Bug: 25288435
Change-Id: I7fbef52d0e31b49c31dadbc0b4d775969d97420a
|
|
messages." into ub-contactsdialer-a-dev
am: 07c23f071a
* commit '07c23f071adc133571613766174812bd21b25a79':
Remove VVM status update for BlockNumberDialogFragment dialog messages.
|
|
messages." into ub-contactsdialer-a-dev
|
|
Simplify code as this should be needed very rarely, since all activities that
call BlockNumberDialogFragment already need to update the status themselves.
+ Removed param context in BlockNumberDialogFragment.show()
Change-Id: I21f51292208fe59d8dec02d306782df1822b8834
|
|
ub-contactsdialer-b-dev
|
|
ub-contactsdialer-a-dev
am: 73feb2b978
* commit '73feb2b978dff00d4a7aa37633c02f2df0f2ef82':
Refresh unread count when voicemail data changes.
|
|
ub-contactsdialer-a-dev
|
|
When a new voicemail comes in, kick off an update to the unread count.
Bug: 25293846
Change-Id: Id1de18d8a7e1772bf179a385df10c5a903c26fee
|
|
ub-contactsdialer-a-dev
am: 5358ca6a91
* commit '5358ca6a9128971a046605413358486241f93379':
Log screen events for blocked call fragments
|
|
Append dialed post-dial digits(if any exist) to the displayed number
and changes the intent sent by the redial button to include the
post-dial digits.
Bug: 24955678
Change-Id: I0ec2cb2d5504f7fd715132eba7d969ff284e23d1
|
|
Lazily initialize instance of VoicemailQueryHandler,
to avoid blocking the main thread in onCreate
Bug: 25627946
Change-Id: I35efb459897251f0157accac129c0abe5f5a8df7
|
|
* Add blocked number screen types to Logger
* Log screen views for SearchFragments in DialtactsActivity
rather than in onStart, to avoid double logging for some
fragments (e.g. children of RegularSearchFragment)
* Log screen view for call log context menu (where the block
number action appears
Bug: 25288435
Change-Id: I4ebf1410f93afb37d20be2cc57f933e5d635cfb6
|
|
|
|
|
|
* Change logScreenView to log by an integer rather than string
representing a screen name
* Add some missing log events (SmartDialSearchFragment, etc)
* Add mapping of integer to screen name strings for AnalyticsUtil
Bug: 23164804
Change-Id: If34a01b71a3fb598caa237e4b679cfeb30c4dd01
|
|
ub-contactsdialer-a-dev
|
|
This reverts commit 8bea0950ff04891b7aaf58bb4ca758010c813fb4.
Change-Id: I1ad4cbda2dc4e6212084399fe53142e9e19dc888
|
|
|
|
* Replace inlined strings with consolidated string constants
* Log event when import/export to contacts dialog is shown
Bug: 23164804
Change-Id: I45ba0663f28bd7ea41c5c33c8a5106dc83cd41f3
|
|
Change-Id: Ieedf62ce9648a611f36cbb118d626d135abef132
|
|
Bug:25452669
Change-Id: I9c1685ee05f2ffc2fc6ac94714c2ae4d1137ffbe
|
|
+ Adjusted UI/String according to new specifications.
+ Added class VisualVoicemailEnabledChecker
+ Block number dialog display different message depending
on whether VVM is activated.
Bug:25455707
Change-Id: I09425053c91a5517e309302d421beadcc2d81cd4
|
|
* The logger is responsible for sending it to its logging
implementation, and also to AnalyicsUtil.
* Standardize logic for creating a tagged version of a screen
name
Bug: 23164804
Change-Id: I9b817fba5359f78340f2d9fdba54af9ea73cdb37
|
|
ub-contactsdialer-a-dev
|
|
Format the number of the new voicemail for display to improve
readability and announce the number with individual digits in text-to-speech.
Bug: 25122678
Change-Id: I96ef815db72b5b0571f9dd662d68f4f6cc6d0416
|
|
ub-contactsdialer-a-dev
|
|
The accessibilty delegate automatically expands the call log cards when
the card is in focus. However, the voicemail state was not being reset
when this happened. Make sure to reset the voicemail playback state
when expanding the card in this manner.
Bug: 24105523
Change-Id: Ife7535980566d7b62959767d7b72df779d275270
|
|
+ Changed ContactInfoHelper.lookUpDisplayNameAlternative to public so
it's usable in InCallUi
+ Changed ContactInfoHelper.lookUpDisplayNamealternative to static to
cut down on object creation
+ Added tests for lookUpDisplayNameAlternative since it is public
Change-Id: Iede746655a1ca773cb0cd8cf26df665e34ab47fc
|
|
Having a voicemail with no voicemail URI should not happen, but if it does,
the app should not crash.
Bug:25425730
Change-Id: I38cac03316432d2400a5eb23ebacf71fd94e75ee
|
|
Bug:25446254
Change-Id: If5bdcbc3f8c3951882667ee3abba46e1599cc68b
|
|
+ Clearer name about functionality, and async nature.
+ Change it to return "false" if it fails and is trying to block an
invalid number, rather than returning "true". This matches a more
standard success/fail return paradigm.
+ Update logic for showing "invalid" message based on return value.
+ Simplify parameter set which it takes in; always take nubmer and
countryIso, because they can be used to calculate the normalized #.
Bug: 25343277
Change-Id: If6fb28a6395e207047f4b27bfac37f5c70a9bac3
|
|
|
|
Some of the checking for invalid numbers was broken by code
cleanups yesterday, and blocking of numbers which can't be normalized
had been allowed (which is no good). Fixing this, by unifying checks
for whether or not a number can be blocked.
Bug: 25343277
Change-Id: Ia631a3e53e3f9ed58e173055a5e18086d95c9d02
|
|
|
|
This "shares" the cache among multiple instances of call log
fragment. This allows "clearing" the cache to propagate changes
across all instances. This should also have the side benefit
of fewer lookups.
~ Change to use ConcurrentHashMap, since it can now be accessed by
multiple call log fragments.
~ Do a little footwork with conversion, since ConcurrentHashMap
does not accept null values.
Bug: 25369105
Change-Id: Id21d1f6a18017c8e0bca88e57f09c9b4b173b843
|
|
- Remove setting for show/hide.
- Remove utilities and behaviors for show/hide.
~ Continue filtering blocked call types in call log (which may be
marked by other applications.)
~ Change behavior after blocking call; instead of keeping the call
log entry but changing the type to BLOCKED, delete it instead.
+ Default behavior is now to delete entries and visual voicemails of
blocked calls.
Bug: 25378068
Bug: 25106387
Change-Id: I8cbc419b25cce6ba39099857cffe4eb1df9d0bef
|
|
Reconstruct the normalized phone number from other params.
Bug: 25343277
Change-Id: Ibb526b0808e0b50a4e946d91279e5570af44c3ca
|
|
It bugged me how it was inconsistently named to other classes
(ie. FilterNumber vs FilteredNumber).
It's also specific to blocked numbers, for now, so it felt more
appropriate to name it accordingly.
Bug: 25343277
Change-Id: I33e2f9fd933d117326690901ec71e3e8c0e3bbd3
|
|
Discovered the bug was in the TalkBack code instead of the dialer code,
this change is no longer necessary.
Bug: 25127953
Change-Id: Ic02dab7ab448d4df55bb6f4d91a723805de58f32
|
|
ub-contactsdialer-a-dev
|
|
ub-contactsdialer-a-dev
|
|
The voicemail entries were reading "speed dial" because the focus would go
to the newly added "speed dial" tab since the tabs are all removed and
readded when the tab info changes. Change the logic so that only the
voicemail tab is changed when needed.
The voicemail entry reads "seek playback" instead of the information
about the voicemail because of custom expand logic for accessibilty.
Change it so that only the call log items are expanded when selected
(it is more important to be able to discover the overflow options).
Also change content description text because it was too long and confusing.
Bug: 25124120
Change-Id: I64c1b27d8c0db57525f7f4ada59655e9f8352245
|
|
- Updated the CallDetailActivity to choose whether to show last name first
or first name first based on user preferences.
- Modified callLog code to behave in a similar fashion
- Fixed bug in ContactInfoHelperTests
- Rename PhoneCallDetails.name -> PhoneCallDetails.namePrimary
Bug: 19364093
Change-Id: I50971ad0f26f6ede49f1c82965d1b00ce0cba4d3
|
|
- Updated ContactInfoHelper to retrieve DISPLAY_NAME_ALTERNATIVE (name
in last name first order)
- Stored alternative name in ContactInfo object
- Updated CallLogAdapter to choose between first name first and last
name first when showing contact name
- Added tests for ContactInfoHelper.lookupContactFromUri (changed to
public method)
- Fixed bug with ContactsPreferences so ChangeListener works
Bug:19364093
Change-Id: I73e8d8602a54e3134ef01b3d5167d828b26fa5ea
|
|
ub-contactsdialer-a-dev
|
|
Bug: 25122678
Change-Id: I83a7d231b8686152c63d9be71a652232664ea682
|
|
This reverts commit 327fb5bb609a6bee44a62888d671c951b19782fd.
Change-Id: I134f0a26697bec20b746a6e8f041a715d8e95136
|
|
- Updated ContactInfoHelper to retrieve DISPLAY_NAME_ALTERNATIVE (name
in last name first order)
- Stored alternative name in ContactInfo object
- Updated CallLogAdapter to choose between first name first and last
name first when showing contact name
- Added tests for ContactInfoHelper.lookupContactFromUri (changed to
public method)
- Fixed bug with ContactsPreferences so ChangeListener works
Bug:19364093
Change-Id: I188d8fc2eccb87edbe56625c9a7537b3d5f0e19e
|
|
+ Delete voicemail when the notification is received if the number
is blocked and the "hide" setting is set to true.
+ Changed utility to take time into account; only block voicemail
notifications and delete voicemails if the voicemails are from
after the time when the number was blocked.
Bug: 24134270
Change-Id: I2f3b24d6291a6cec4a7d8530b00dd5a4656ab024
|
|
+ Add settings switch to blocked number settings.
+ Add utility for checking/setting whether calls should be blocked.
+ Filter out blocked calls in call log query, if appropriate.
+ Refresh call log fragment after a change in setting.
Followup work: delete voicemails for calls by blocked numbers after
the time when the user blocked them.
Bug: 24134270
Change-Id: I85088697559ef6fb446b82617f14f1c6fa893df1
|
|
+ Added a utility to do a synchronous lookup for whether a number is
blocked, but it should not be used normally from the UI thread.
+ Change voicemail notifier code to obtain countryIso, and pass back
list of calls to notify as list (to make it easier to remove elements).
Bug: 23944007
Change-Id: Iad1f8ee200b8f8734be3db0504482fcdee61e412
|
|
Bug: 24680730
Bug: 24303461
Change-Id: Ibd7d431355ca97eb2ae7f29537809987a8d5f96d
|
|
+ Show blocked drawable in CallDetailActivity. Rearrange logic in
the activity to facilitate updating the contact photo and block
item action in accordance to blocked state.
+ Fix bug in FilterNumberDialogFragment where callback was not
always invoked because of final/scope issues where it was possible
for the callback to be unintentionally null and not invoked.
+ Clear blocked id cache when pausing the call log adapter, so that
after changing the blocked state in the call detail activity the
changes will be reflected in the call log.
Bug: 24871853
Change-Id: I1d58b1e0c222ead90fa7b6c30a95bc3254a14776
|
|
+ Correctly dismiss filtered number dialog on rotate.
+ Polish listener interface, and extend across all block/unblock
and undo scenarios.
+ Update UI across all blocking scenarios (call log, call detail,
settings, blocked number list, blocked number search);
+ Conslidate creation of FilterNumberDialogFragment in a single
static method.
The listener interface is not ideal, because it does not maintain
state well across rotation and multiple instances. This option was
selected, however, because of the number of scenarios in which
the dialog is invoked and various circumstances (in a RecyclerView
list item, in a fragment, in an activity). This range of scenarios
makes it convoluted to implement a uniform mechanism in any other
way, so the approach opted for is to set a listener, and dismiss
the dialog on rotation..
Bug: 24638328
Bug: 24109819
Bug: 24871853
Change-Id: I2332edda2cae0341af3e80b13aa96af6068f75ac
|
|
reversed in RTL." into ub-contactsdialer-a-dev
|
|
Combination of two related bugs.
22168682: In the voicemail call log, moved call type/location to below the call
action button and removed the call details button as it didn't have any
additional information.
22514722: Modified spacing and text sizes for call log. Moved voicemail
transcription below call date as in mocks.
Bug:22168682,22514722
Change-Id: I557761b815604fee4e6b61f4670608b8fa90d3a7
|
|
in RTL.
Root cause of issue was that the tab indexes were not reversed in RTL mode.
Made a similar change as was made in ListsFragment.
Bug: 24690256
Change-Id: Ifa7ae1127298aa098dd8201b4d1e095baa3c14e8
|
|
- Remove LinearLayouts and use drawableLeft instead.
+ Up block asset from 18dp to 24dp.
Bug: 24109819
Change-Id: I941520f1b90e6f819c7f94269e395d26c56f5734
|
|
|
|
Some of these are moved down from the overflow. Others are added
from the list of those shown after a call log list item long press.
This hooks up the block/unblock functionality, although there is
still polish (eg. icons) and cleanup (some noted as TODOs), to
complete still.
Bug: 24109819
Change-Id: I129f5b09ac1c5edb66ab5bd91a46b18961240fb5
|
|
Does not yet update on change; figuring to do that in a followup
CL because there are a number of other scenarios where that
needs to be fixed too.
Bug: 23943480
Change-Id: I73615c405d547e74667f6c635b5623708c723347
|
|
|
|
This makes the ViewHolder self-capable of updating/setting its
photo, so if we want to update the photo in the future (either
in teh scope of a listener, or in the ViewHolder itself), we
don't need to worry about configuring and passing around a
bunch of commands.
Bug: 23943480
Change-Id: I17653014dd81fcb9ae7a667539e40a9310a72d36
|
|
|
|
|