summaryrefslogtreecommitdiff
path: root/src/com/android/dialer/calllog/CallLogListItemHelper.java
AgeCommit message (Collapse)Author
2015-06-10Move "Report" to CallDetailActivity.Andrew Lee
- Delete old report button/handling code. + Convert menu click listeners into single onMenuItemClick method. + Add and populate objectId on PhoneCallDetails, to be able to tell from the CallDetailActivity whether to enable reporting. Change-Id: Ie4b9a3c1835792cbba04dc826f71fd2e53071400
2015-06-10Change PhoneCallDetail fields to be non-final.Andrew Lee
It's been a pain to add/change fields on PhoneCallDetails because a multitude of parameters required for the constructors to create an instance. I ran into this while considering how to add an objectId to its parameters, and have previously too... Make fields non-final so that they are more easily set. This has the side-effect of making the casing of some initialization code more straightforward. + Change it's constructor to a subset of required fields. + Simplify/reorganize CallLogAdapter and CallLogAsyncTaskUtil code. + Simplify tests. Bug: 21733599 Change-Id: I236dfb0b8e6513f4b44dbdae17ce2eb9c9ae4778
2015-06-03Move VM playback from details to call log.Andrew Lee
- Delete voicemail playback in the CallDetailActivity. + Add voicemail playback to the call log list items. + Move the VoicemailPlaybackPresenter to the CallLogFragment. + Fix some retaining state for both call log (expanded items), and preserve rotation/state functionality for voicemail playback. This included some changes to the Presenter logic. + Fix some tests. Bug: 21471763 Bug: 21170557 Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
2015-05-19Performance improvements to call log scrolling.Andrew Lee
- Remove call to CallUtil to check if video is enabled. It seems like it's fine to include the content description of what the call was, if it was a video call, even if there is not a video-enabled call account. - Factor out PhoneNumberDisplayHelper so it doesn't need to be an instance. This reduces some extra calls to getDisplayNameHelper. Probably a marginal difference, performance-wise, but it probably helps a smidgen and also simplifies the need for creating and passing or recalculating various instances of things. TODO: It'd be much better if PhoneCallDetails had a builder. It's terribly painful to fix all the tests when adding fields... Change-Id: I6da13dc8b6b047043aba871796a8ed13b112a227
2015-05-08Improve talkback on call log actions.Andrew Lee
- Remove previous/next hints; not needed. + Add descriptions for new actions. - Make TextViews not important for accessibility. Descriptions on the actions will be used instead. Bug: 20433758 Change-Id: I043b03075631134f37151e165360b038f3961b2a
2015-04-16Move call log actions into expandable view.Andrew Lee
This isn't the prettiest thing ever, but with this the "framework" of all of the changes for the new visual style of the call logs is in place. From here on out, the remainder of tasks should be unblocked and relatively independent. + Rename ...ItemViews to ...ItemViewHolder. This probably wasn't completely necessary, but is more proper given the new architecture. + ViewHolder is now officially where most of the independent UI logic for a single call log list item should live. This changelist moves further in that direction by storing references and helpers in it, to lessen what must be passed in from the adapter. + Split out the call action from the rest of the actions, since it has a special treatment on the card. + Convert text action buttons into a vertical stack. + Consolidate action stylings into a single style, for simplicity. + Miscellaneous style and string changes to put things in a better state. This included tweaking some of the (ripple) backgrounds. + Update tests, according to changes. Bug: 19372817 Change-Id: Ic923c0bcbbc1c153952131d0c772df9e9589fb03
2014-12-09Fix potential NPE when generating accessibility text.Tyler Gunn
Traced through the original bug report; the problem is that a call to TextUtils.expandTemplate was being made with a null 2nd parameter. I traced through the callers to find out where a null could be introduced and I was unable to identify a potential source. This change introduces a last-ditch null check to protect against problems upstream. Bug: 18684529 Change-Id: I7b608dfedf052d6933e94d1f23a658763b66059a
2014-12-05Add Text-to-Speech annotations for phone number displays (3/3)Ihab Awad
Bug: 17321294 Change-Id: Icc712da80e25e5a5294986ece055fcffaa558f1e
2014-12-01On MSIM devices, include account from call log in talkback.Nancy Chen
In TalkBack mode, when a user taps on a call log entry, it should read back the name of the SIM/account used for the call. The string used is "on <phoneAccount>". Also add back periods removed in the string updates because they are needed for verbal stopping points in TalkBack mode. Bug:18517912 Change-Id: Iaadbd859ef980ca030f9fb60d3395ca057e8cefc
2014-10-15Enable use of phone accounts for voicemail info display.Nancy Chen
Call the "isVoicemailNumber(subId, number)" method instead of the one with just the number. This is because we need to check whether a number is the voicemail number for a specific phone account, otherwise the UI would never correctly display "voicemail" for the non-default SIM. Bug:17925501 Change-Id: If1d6cb1acfcb570aca5e639858af8804bac202c0
2014-08-20Pass application context into isVideoEnabled usages.Andrew Lee
Bug: 16211386 Change-Id: I0bda040bd6cd5c55ee7c708044befaad8977d460
2014-08-19Moves isVideoEnabled to ContactsCommon (2/3)Paul Soulos
bug: 16015752 Change-Id: Idaedd70a53b81e375d3a8bf8d9a4fbce1c62cd3f
2014-08-11Disable VT features in Dialer,Andrew Lee
+ Should be contingent on a setting in any case. In teh future this will be derived from capability, but for the moment this feature just won't be supported. + Pointed everything to a false flag in DialerUtils. Bug: 16211386 Change-Id: I37e027c94e3411d8e73a349b3101fdb6ad598b3b
2014-07-15Various call log / call details video call changes.Tyler Gunn
Requires cl/501841. Call log: 1. Add video call affordance. 2. Add accessibility text for calls, video call afforance. 3. Fixed unit test Call details: 1. Showing video icon when a call had video. 2. Changing call headings to indicate they were video calls. Bug: 16013879 Bug: 16013344 Bug: 16013684 Change-Id: I53b5bf9b0b1a63f9d119318d59f690d310cca7c8
2014-05-21Removing the delete button from call log entries.Tyler Gunn
Bug: 13962594 Change-Id: I59ee9badc239f4ce3a81320cb0e801af973707a5
2014-05-16Adding call details affordance to call log.Tyler Gunn
Bug: 14876142 Change-Id: Ic4e806153156489473aeff91dbb9380302431ace
2014-05-12Removing highlighting of missed calls and voicemails in the call log.Tyler Gunn
Also fixing some broken unit tests. Bug: 13962594 Change-Id: I3ca2d72b3013b6324da19717dbc984f3e7e576e2
2014-05-05Adding support for expandable call log entries.Tyler Gunn
Bug: 13962594 Change-Id: I19a4a65dce922619df0a709293ca291c345c8be7
2014-02-03Call History Affordances SwapTyler Gunn
1. Swapped the intents for the primary view 2. Changed the icon for the secondary action button 3. Added a vertical divider line to separate the secondary action button from the primary view 4. Cleaned up the accessibility text Change-Id: Ifd4ceff0d67b1587c4378e29be7344de50057a7d
2013-11-19Rename PhoneNumberHelper in DialerYorke Lee
Rename PhoneNumberHelper to more appropriate PhoneNumberDisplayHelper Change-Id: I2c03f5cbb04c1e03f1fc1e0051a1cea641160dca
2013-09-14Follow up on build break to fix unit tests.Chiao Cheng
Change-Id: I82b7fa50601f6dad60038fd1b9c5f0aad2f374f5
2013-09-13Add xxhdpi assets for DialerYorke Lee
Bug: 10491107 Change-Id: I56312e712595c1d5bbae3d4d8655078af1f59857
2013-08-15Change primary actions of the CallLog items.Christine Chen
- When the CallLog item is in the CallLog fragment, the primary action remains to be opening the call detail page. - When the CallLog item is in the Favorite fragment, the primary action changes to be calling the number directly. The secondary action is hidden unless it is to play a voicemail. Bug: 10308694 Change-Id: I28ca7aa783bcca35eb8b41f6e8508d08062dd253
2013-08-09Clean up todos in DialerYorke Lee
Change-Id: I336373f089d1956606451e320c103d53bd737264
2013-08-05Code cleanup for call log related itemsYorke Lee
Change-Id: I2aa0458e1fb74abaea60a02f430a4e413dfed365
2013-06-13Use new CallLog number presentation columnJay Shrauner
Switch to using new number presentation column in the CallLog table and discontinue using special phone number strings in CallerInfo. Needed for unbundling. Bug:6948882 Change-Id: Ibf27ea55cee783c4530101e4e228198e245e6684
2012-10-15Changing com.android.contacts.R to com.android.dialer.R.Chiao Cheng
Bug: 6993891 Change-Id: I921ec71fffbd4d4a058bab29ded8a6ac62adfb70
2012-08-30Moving more classes from contacts into dialer.Chiao Cheng
- These classes are only used by dialer code. - Fixed import order. Bug: 6993891 Change-Id: I7941a029989c4793b766fdc77a4666f9f99b750a
2012-08-21Initial move of dialer features from contacts app.Chiao Cheng
Bug: 6993891 Change-Id: I758ce359ca7e87a1d184303822979318be171921
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-19 07:06:56 +0000