summaryrefslogtreecommitdiff
path: root/src/com/android/dialer/DialtactsActivity.java
AgeCommit message (Collapse)Author
2017-03-01Update dialer sources.Eric Erfanian
Test: Built package and system image. This change clobbers the old source, and is an export from an internal Google repository. The internal repository was forked form Android in March, and this change includes modifications since then, to near the v8 release. Since the fork, we've moved code from monolithic to independent modules. In addition, we've switched to Blaze/Bazel as the build sysetm. This export, however, still uses make. New dependencies have been added: - Dagger - Auto-Value - Glide - Libshortcutbadger Going forward, development will still be in Google3, and the Gerrit release will become an automated export, with the next drop happening in ~ two weeks. Android.mk includes local modifications from ToT. Abridged changelog: Bug fixes ● Not able to mute, add a call when using Phone app in multiwindow mode ● Double tap on keypad triggering multiple key and tones ● Reported spam numbers not showing as spam in the call log ● Crash when user tries to block number while Phone app is not set as default ● Crash when user picks a number from search auto-complete list Visual Voicemail (VVM) improvements ● Share Voicemail audio via standard exporting mechanisms that support file attachment (email, MMS, etc.) ● Make phone number, email and web sites in VVM transcript clickable ● Set PIN before declining VVM Terms of Service {Carrier} ● Set client type for outbound visual voicemail SMS {Carrier} New incoming call and incall UI on older devices (Android M) ● Updated Phone app icon ● New incall UI (large buttons, button labels) ● New and animated Answer/Reject gestures Accessibility ● Add custom answer/decline call buttons on answer screen for touch exploration accessibility services ● Increase size of touch target ● Add verbal feedback when a Voicemail fails to load ● Fix pressing of Phone buttons while in a phone call using Switch Access ● Fix selecting and opening contacts in talkback mode ● Split focus for ‘Learn More’ link in caller id & spam to help distinguish similar text Other ● Backup & Restore for App Preferences ● Prompt user to enable Wi-Fi calling if the call ends due to out of service and Wi-Fi is connected ● Rename “Dialpad” to “Keypad” ● Show "Private number" for restricted calls ● Delete unused items (vcard, add contact, call history) from Phone menu Change-Id: I2a7e53532a24c21bf308bf0a6d178d7ddbca4958
2016-10-11Fixed Dial fab changed to add to contact when multiwindow modeNaoki Amano
Added check whether DialtactActivity is in search mode or not. Change-Id: I621a9f6b2a419a3cfaa0f2e3e117b41143cdcce8
2016-03-07Merge "Add contact photo for missed call notifications" into nyc-devTa-wei Yen
2016-03-07Add contact photo for missed call notificationsTa-wei Yen
+ ContactPhotoLoader to create the appropriate icon from a ContactInfo - NameLookupQuery in CallLogNotificationsHelper#getContactInfo To show a photo the name is not enough. Full query need to be made to retrieve the photoUri. + class Assert in util + Gradle directory setup for dialer tests (Note: this is just for project setup in Android Studio, tests are still not runnable in gradle) Bug:27276108 Change-Id: I0ed2147f2bb60454fe5a5ad6c25fe99727441880
2016-03-04Disable voicemail archive by default.Sarmad Hashmi
+Archive-specific actions are not drawn unless the runtime flag is enabled +Disable archive button and menu item BUG=27375884 Change-Id: Ide7d0a162468279f614e09e01de99d782854a3e1
2016-03-03Add files for voicemail archive tab.Sarmad Hashmi
+ Added VoicemailArchiveActivity which displays all voicemails archived by the user + VoicemailArchivePlaybackPresenter is the same as VoicemailPlaybackPresenter except that it does not need to request content from the voicemail server +Added tests (combined common methods and attributes for regular voicemail tab and voicemail archive used for tests) BUG=22797391 Change-Id: I4064eea945b9e257ec6c7ada35cf5ac1657dc866
2016-02-24Mark missed calls as read on swipe.Sarmad Hashmi
When swiping to a new tab, if the previous tab that the user was in was the call history tab, all missed calls are marked as read and the tab count is updated. Also fixes b/27153608 and clearing of missed calls on orientation change. BUG=27136093 BUG=27153608 BUG=27154514 Change-Id: I5be31b1a3978784b941fb8e1af22f93fb6ca944a
2016-02-22[Gradle] Allow dialer to be compiled as a librarySailesh Nepal
This CL adds a new build-library.gradle file for AOSP dialer. This allows the dialer to be built as a library that can be included from GoogleDialer. Switching to a library project meant making two other changes: - changed all switch statements that used resources to if statements. This was required because resource IDs are not final in library projects. - changed InCalUI code to import com.android.dialer.R instead of com.android.incallui.R. See http://b.android.com/82743 for more info on why this is required. src-N isn't supported yet. Also, this isn't the ideal project layout. In the future we should consider switching to the following layout: - dialer/incallui/ <- incall UI as an independent library project - dialer/dialerlib/ <- dialer code as an independent library project - dialer/app <- skelent app that builds a standalone dialer AOSP app Bug: 26676586 Change-Id: I07fbee4d33cc683539e4f8b3953c93f1427af9d7
2016-01-21Dismiss dialpad when clicking in search area.Nancy Chen
If a user goes from the search fragment to the dialpad and then clicks on the space above the dialpad, they probably expect to go back to the search fragment--dismiss the dialpad. See the bug for context. Bug: 23302853 Change-Id: I69053a2c8289f18d99e47c5d539a5ba94bde2ab6
2015-12-18Support carrier presence-based video calling icon.Tyler Gunn
- Update SmartDial database to track carrier presence. - Add video call style elements to dialer stylesheet. - Tore out hair in frustration tracing through code. - Add listeners to allow dialing of video calls from search results. Bug: 20257833 Change-Id: I476cccb8c2805ae6f9949366fc5c2ce2669b7734
2015-11-11Merge "Log screen events for blocked call fragments" into ↵Yorke Lee
ub-contactsdialer-a-dev am: 5358ca6a91 * commit '5358ca6a9128971a046605413358486241f93379': Log screen events for blocked call fragments
2015-11-10Log screen events for blocked call fragmentsYorke Lee
* Add blocked number screen types to Logger * Log screen views for SearchFragments in DialtactsActivity rather than in onStart, to avoid double logging for some fragments (e.g. children of RegularSearchFragment) * Log screen view for call log context menu (where the block number action appears Bug: 25288435 Change-Id: I4ebf1410f93afb37d20be2cc57f933e5d635cfb6
2015-11-09Merge "More work to hook up screen event logging" into ub-contactsdialer-a-devYorke Lee
am: 4aabaacd84 * commit '4aabaacd849235864c16f8e6bc72e0d0412a02e6': More work to hook up screen event logging
2015-11-09More work to hook up screen event loggingYorke Lee
* Change logScreenView to log by an integer rather than string representing a screen name * Add some missing log events (SmartDialSearchFragment, etc) * Add mapping of integer to screen name strings for AnalyticsUtil Bug: 23164804 Change-Id: If34a01b71a3fb598caa237e4b679cfeb30c4dd01
2015-11-07Merge "Revert "More work to hook up screen event logging"" into ↵Yorke Lee
ub-contactsdialer-a-dev am: f58d982e72 * commit 'f58d982e72724c5da05365cdaea7b1007b9351c2': Revert "More work to hook up screen event logging"
2015-11-07Revert "More work to hook up screen event logging"Yorke Lee
This reverts commit 8bea0950ff04891b7aaf58bb4ca758010c813fb4. Change-Id: I1ad4cbda2dc4e6212084399fe53142e9e19dc888
2015-11-07Merge "More work to hook up screen event logging" into ub-contactsdialer-a-devYorke Lee
am: 305eb447e8 * commit '305eb447e82d5a67e7b558a769059c2e8e5842ef': More work to hook up screen event logging
2015-11-06More work to hook up screen event loggingYorke Lee
* Replace inlined strings with consolidated string constants * Log event when import/export to contacts dialog is shown Bug: 23164804 Change-Id: I45ba0663f28bd7ea41c5c33c8a5106dc83cd41f3
2015-11-06Route all existing screen view events through the LoggerYorke Lee
am: 6e0fd6b777 * commit '6e0fd6b77759baf43cb37d407041be051b4856b5': Route all existing screen view events through the Logger
2015-11-06Route all existing screen view events through the LoggerYorke Lee
* The logger is responsible for sending it to its logging implementation, and also to AnalyicsUtil. * Standardize logic for creating a tagged version of a screen name Bug: 23164804 Change-Id: I9b817fba5359f78340f2d9fdba54af9ea73cdb37
2015-11-04Merge "Fix "Cleared text" announcement when placing a call" into ↵Ta-wei Yen
ub-contactsdialer-b-dev
2015-11-03DiatactsActivity title indicate dialpad status, removed excessive "showing item"Ta-wei Yen
messages. + DiatactsActivity set its' title to "Phone Dialpad" or just "Phone", so user using Talkback can know the state of the activity when it is launched + SpeedDialFragment and SearchFragment no longer send accessibility events when its' content is changed. + Add AccessibilityDelegate ContentChangedFilter to filter out TYPE_WINDOW_CONTENT_CHANGED event for View. Bug:25190037 Change-Id: If1fa34cc9a5d24dec3fe261da9c071bb5388ec58
2015-11-04Fix "Cleared text" announcement when placing a callTa-wei Yen
+ Accessibility for the dialpad EditBox is temporarily disabled while DialtactsActvity.hideDialpadFragment() is called with true for clearDialpad. Bug:24570971 Change-Id: Ieeab034a65a66910c02981f7ba6505a768ddef33
2015-10-27Remove onboarding flowYorke Lee
Straight revert of all onboarding flow related CLs - the onboarding flow is not needed for now as the Dialer will always at least be the system dialer. Bug: 25020847 Change-Id: Ic1c5020b9b423de50801485f764209b21d5d7f33
2015-10-26Fix issue with entering '+' with switch accessYorke Lee
Distinguish between a manual long press and system long press (via accessibility) when modifying the current dial string. Bug: 23554996 Change-Id: I3fc610c8e24bdb39729b827715e08a3e7d73ba1f
2015-10-14Correctly set query string for new SmartDialSearchFragment instanceYorke Lee
If DialtactsActivity is created for the first time by launching a DIAL intent, the SmartDialSearchFragment is not correctly populated with the correct number for the "Create new contact" and "Add to contact" shortcuts since it is not attached yet when the callback is fired. Fix this by persisting the number and setting it on the fragment when it is attached. Bug: 24358325 Change-Id: I24d4603376e739a7c9368a9b115109ba23753585
2015-10-12Move capability checker out of RegularSearchFragmentYorke Lee
AOSP Dialer does not care about having location enabled, so move the relevant code out into a separate fragment Bug: 24172011 Change-Id: I7c29ba4ed8e3fb0a600360c10e9c9fdd6d543b1f
2015-10-09Fix crash in BlockedNumberSearchActivityYorke Lee
Don't require RegularSearchFragment's parent activity to implement CapabilityChecker interface. In the context of the BlockedNumberSearchActivity this functionality is not needed. Bug: 24804134 Change-Id: I848ae66c6f8afc6e60b19bc28e933ae1e2f59893
2015-10-06Show prompt to request for location permissionYorke Lee
Clicking on TURN ON currently only asks for the location permission. Showing the dialog that toggles location sources is planned for a follow up CL. Bug: 24172011 Change-Id: Ieb6bd58a60aacbda76f9c754efeebfdd9e89aa86
2015-10-06Actually launch onboarding flow if neededYorke Lee
Launch OnboardingActivity for exported activities (DialtactsActivity, CallDetailsActivity) to ensure that a) We prompt the user to make us the default dialer at least once b) The user has granted us both the Phone and Contacts permissions Bug: 24270592 Change-Id: I232314e42f5331a72c1a84be917d9d74c5813976
2015-09-29Rename OnPhoneNumberPickerActionListener methodsAnne Rong
Bug: 24506966 Change-Id: Ibc1d334fc18235c3d5971364d7024db61c590c46
2015-09-25Merge "Show ImportExportDialogFragment based on tabs" into ↵Wenyi Wang
ub-contactsdialer-a-dev
2015-09-25Show ImportExportDialogFragment based on tabsWenyi Wang
Bug: 19850584 Change-Id: Ic2faade79bebfc352c3f492c4cb7679090022e63
2015-09-25Use TransactionSafeActivityJay Shrauner
Remove custom visibility tracking. Bug:24294419 Change-Id: I2ef53549e7d8c07e92319bc57c4aebd05edb8ea6
2015-09-22Protect against more Telecom privileged operationsYorke Lee
Make sure that all invocations of TelecomManager methods that could possibly require a permission are protected by a permission check. Some of these are overcautious - for example, the UI should never show the option to return to a call (READ_PHONE_STATE) if we didn't detect an active call (READ_PHONE_STATE) in the first place, so it is not strictly necessary to protect against the former. But not crashing is the most preferable of all options. Bug: 20266292 Change-Id: Id91dd16e34320a5e607f91dbce9a4296025eeaaf
2015-09-21Merge "Wrap some privileged Telecom operations with permission checks" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-17Wrap some privileged Telecom operations with permission checksYorke Lee
If the Dialer is not the default dialer and does not have the CALL_PHONE permission, don't call TelecomManager methods that will cause SecurityExceptions. Bug: 20266292 Change-Id: I229dd045269a262632c4a911e2321203443de684
2015-09-17Fix IllegalStateException in onMenuItemClickJay Shrauner
Make sure we're still visible before showing dialogs. Bug:24153279 Change-Id: I2eccdcd26064d73a59344107f79ee8eac1b47865
2015-09-16Log various call initiation entry pointsYorke Lee
Speed dial (PhoneNumberPickerInteraction, SpeedDialFragment) Regular search (RegularSearchFragment) Remote Directory (RegularSearchFragment) Call Log (CallLogAdapter) Smart Dial Search (SmartDialSearchFragment) Dialpad (DialpadFragment) Bug: 23164804 Change-Id: I7cc881ac655fca6d4f365b5de36a4087c4f17700
2015-09-15Merge "Refactor IntentUtil.getCallIntent variants to use builder" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-09-14Refactor IntentUtil.getCallIntent variants to use builderYorke Lee
Use the builder pattern to create a Call intent to replace the numerous variants of getCallIntent. This will facilitate the addition of future extras to the created call intent. Bug: 23164804 Change-Id: Ibab8473274de8e423f621ae6fbb9685eeb2a7cab
2015-09-15Merge "Translate FAB up and down when Snackbar appears and disappears." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-09-11Remove EXTRA_CALL_ORIGIN from DialerYorke Lee
This is legacy code from the PhoneApp days and no longer does anything. The method signatures in IntentUtils were kept unchanged to reduce code churn since they will be modified in a later CL. Change-Id: I76bcdd9b1302eed701e3d1cb5027a937ab2234c4
2015-09-11Translate FAB up and down when Snackbar appears and disappears.Nancy Chen
This is implements custom behavior according the Material Design spec that the Snackbar cannot obscure the FAB. Converts the dialtacts activity layout to a CoordinatorLayout and attaches the FloatingActionButtonBehavior to the FAB. Bug: 23687913 Change-Id: Ic4d0493db415bb97cf7e21de4f23a02df9f753b1
2015-09-10Improve jump to tab via intent logicYorke Lee
Respect the EXTRA_CALL_FILTER_TYPE extra if provided in an intent extra Fix bug where trying to jump to the voicemail tab for the first time before active voicemail sources were detected would not work. Bug: 23947505 Bug: 23388120 Change-Id: Ib4fcaf486ae01d023f21fd2fc3bfc78f1a0cf609
2015-09-03Merge "Display unread count for voicemail and update when vm is read." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-09-02Don't show dialpad when adding a callYorke Lee
When receiving a DIAL intent with the "add_call_mode" extra set, don't show the dialpad when DialtactsActivity is launched. Bug: 23519909 Change-Id: I5e8d462b3e75a12a5ccd38cfb8871b9626f2e9bb
2015-09-01Display unread count for voicemail and update when vm is read.Nancy Chen
Query for number of unread voicemails when dialer starts and update this number when the user reads the voicemails. Pass the tab icons into the ViewPagerTabs class: changed so that the raw image is passed instead of the modified drawable because the ripple is applied in through the ViewPagerTabs layout instead of through the drawable containing the icons. Bug: 21086059 Change-Id: Ie426b042d72926ea3feb7baa4717108776152754
2015-08-17Merge "Convert Dialer activities to AppCompat to support Snackbar."Nancy Chen
2015-08-14Rename "Recents" to "Call History".Andrew Lee
+ All user-facing indications should now say "Call History". + I renamed many references in code to "Call Log", which is how we internally refer to many of the components related to call history. It seemed excessive to rename the fragment, list items, adapters, and other references to that throughout our codebase. Bug: 23017190 Change-Id: I99719122ce592962ff99705dcf4b16e17eee3ab7
2015-08-13Convert Dialer activities to AppCompat to support Snackbar.Nancy Chen
In order to add an "Undo" snackbar for voicemail, dialer activities need to inherit from the AppCompat library. Add the relevant libraries to the make files and change the styles to be compatible. Bug: 22460745 Change-Id: Ia3cc4002cbd943da818fec67f888d085d53a3b25
2015-07-28am e10dd056: am 052597e2: am e32de99b: am 0fc67af1: am ed058349: Merge "Fix ↵Yorke Lee
bug in FAB action" into mnc-dev * commit 'e10dd05600d2d7f71163ea29c7cecb4bf70cfaab': Fix bug in FAB action
2015-07-27Fix bug in FAB actionYorke Lee
If in contact search, always show the dialpad if the FAB is clicked. Bug: 22751856 Change-Id: I069064489664a1f9c3749b34e8b333f878bbf04b
2015-07-23If nearby places is disabled, change search hint text.Anne Rong
Added method setSearchBoxText to DialtactsActivity, for overriding in Google Dialer. Bug: 20699994 Change-Id: I82ac9bfd7aea705d2b32b63ee58220ac231fc489
2015-07-17Add permission prompts for contacts and dialpad searchYorke Lee
Update the following fragments to handle denied permissions -Contacts Search (Contacts and Location) -Dialpad Search (Phone) Tweak and remove some of the onTouch listener logic as they are no longer valid with the new UI. Instead of intercepting the touches when the query is empty and returning to the main dialer activity, allow the fragments to remain on screen if the permission request UI is showing. Modify signature of onEmptyViewActionButtonClicked to remove unused permissions parameter. Bug: 22174668 Change-Id: I96d00f2ab45df936dca602ac025f723638ac02c4
2015-07-15Update Dialer UI to prompt for permissionsYorke Lee
First pass at adding functionality to Dialer to prompt for permissions. Also updates the UI for various fragments when there are no contacts/calls available to unify the UI with the new UI for the permissions denied state. * Refactor existing empty view functionality and encapsulate into a new custom view class * Add action buttons to existing empty views in various fragments -> Speed Dial (Add to favorites) - scrolls to all contacts fragment -> Recents (Make a call) - shows dialpad -> All contacts (Add a contact) - Launches add contact dialog * Add functionality to various fragments to detect if permissions are denied, and request the permission when the action button is pressed. -> Speed Dial (request for contacts permission) -> Call Log (request for phone permission) -> All contacts (request for contacts permission) * Remove now unneeded EmptyContactsListAdapter Remaining issues (to be addressed in a follow up CL to avoid bloating this CL): UI alignment tweaks for empty view to match mocks If the read contacts permission is requested from the speed dial screen, the all contacts fragment doesn't update with the list of contacts until restarted. Bug: 22174668 Change-Id: I70721914bb9b32910d746de288ccac049749e42e
2015-07-13Don't cache results of permission checkYorke Lee
For maximum safety, always check the current permission status on the fly. Bug: 22455059 Change-Id: I05da7ec1ad2e885e3e5e78e14585c876ac19178e
2015-07-07Go to recents tab instead of CallLogActivity for call views.Nancy Chen
Use the DialtactsActivity instead of CallLogActivity when accepting ACTION_VIEW intents for the "calls" mime type. Also remove an unused method in CallLogFragment. Bug: 22266705 Change-Id: I1bf089901b1a5f9534c9f7a8484c12e535a87749
2015-07-01Merge "Restore Dialer content after permissions granted" into mnc-devYorke Lee
2015-07-01Restore Dialer content after permissions grantedYorke Lee
First pass at making Dialer display the call log, favorites, all contacts, and contact search after permissions are granted withut having to restart the app. Update cached permission status in onResume for Dialer activities Update SpeedDialFragment to correctly initialize loader in onResume if it was null previously because of revoked permission. Bug: 22205650 Change-Id: I68982e69395bc9c7da84ff3221cd12b8f79005f9
2015-07-01Merge "Fix dialer monkey NPEs" into mnc-devYorke Lee
2015-07-01Fix dialer monkey NPEsYorke Lee
Monkey tests exposed a bug in Dialer where certain call shortcuts could show up if contacts permissions were disabled and the UI was changing quickly. Don't enable shortcuts by default, and make sure to correctly disable all shortcuts in the case of missing permissions. Bug: 22225052 Change-Id: Icdd81412f695860eb322d7ccdc30555591c584d0
2015-07-01Ensure the EXTRA_SHOW_TAB is checked for all new intents.Nancy Chen
onNewIntent is only called when the activity is already active so when an intent is sent to start the DialtactsActivity on a specific tab when the DialtactsActivity is not already active, the code to switch to the specific tab is not called. Move this code to onResume() instead. Bug: 21120186 Change-Id: I735eae22ca5de54f4c17688777b4309616f2c691
2015-06-29Accessibility fix for Dialer search resultsYorke Lee
In portrait mode, resize the listview to fit above the dialpad, so that accessibility services can correctly traverse the view hierarchy. Bug: 20172384 Change-Id: I35fb49be7bea5d13d951c4d954ddaf9d8d12780e
2015-06-27Make the full search bar respond to clicksYorke Lee
Bug: 21663461 Change-Id: I79bf44f7956511e6894a122a98a69d7793b9a785
2015-06-23Add extra to jump to DialtactsActivity tab.Andrew Lee
+ For the voicemail notification, jump to voicemail tab. + Jump through some hoops to handle this properly when waiting for the voicemail status to be retrieved. Bug: 21120186 Change-Id: I5a82f3ecafadb45246e6637e8275a09f78cc188a
2015-06-16Fix FAB state and transitions.Andrew Lee
+ Change to dialpad FAB in search (used to stay as add contact FAB, if we were in the Contacts list). + Position dialpad to align end in search (used to stay in the center, if we opened the search from Speed Dial). + Restore correct position/icon when exiting search. + Add correct FAB scale in/out behaviors in for transitions between lists fragment and search UI, search UI and dialpad, in particular for when the FAB changes position from END to MIDDLE when going from search UI back to Speed Dial. + Add FAB scale in/outs for showing/hiding the soft keyboard. Bug: 21161760 Change-Id: Idbddbac161e459e3708d43395850d80927d5e448
2015-06-11"Emergency" dialpad behavior.Santos Cordon
Change-Id: I132a119238c8de7249a4944e6dda472b3851637e
2015-06-02Merge "Enter search UI even if dialpad is not animating" into mnc-devYorke Lee
2015-06-01Don't use Log.isLoggable to determine DEBUG flagYorke Lee
This allows unnecessary debug statements to be stripped out by the compiler. Change-Id: Id1b6f8bd6c86cf5014e4b76524aa3839eb31bbb8
2015-06-01Enter search UI even if dialpad is not animatingYorke Lee
This fixes a UI bug that happens when the dialpad is displayed without animation. Bug: 21524134 Change-Id: Ic566b09c2839d7f34d5d983f67e592c1b2d50d2e
2015-05-26Merge "Handle runtime phone permission" into mnc-devYorke Lee
2015-05-26Merge "Handle runtime permissions in Dialer" into mnc-devYorke Lee
2015-05-22Handle runtime phone permissionYorke Lee
We don't have access to the call log without the phone permission, so disable the following functionality: 1) Call log display 2) Show call history overflow menu option 3) Last number dialed functionality Bug: 20266292 Change-Id: I2f1d4b8b5f747d2fa04c3a9c291f9cf5147646b7
2015-05-22Handle runtime permissions in DialerYorke Lee
Conditionally disable the following features if the required permissions are not available: 1) Display of all contacts 2) Display of speed dial 3) Caller ID in call log 4) Import/export contacts 5) Conversion of People.CONTENT_ITEM_TYPE and Phones.CONTENT_ITEM_TYPE into a phone number (via DIAL intent) 6) UndemoteOutgoingCallReceiver 7) Contact Search 8) Contact lookup in call detail activity 9) Nearby places search Bug: 20266292 Change-Id: I6d26902acb0eac407ae7bc18c11aa6ec57299506
2015-05-21Some ListsFragment cleanups.Andrew Lee
- Delete unused shortcut code. + Consolidate logic for reporting the current lists view. + Change page position logic to make private the list fragment's calculation of the type of tab in RTL. Bug: 21328994 Change-Id: Ic05a895fce77fea668798fca6e67863a2fcfd88a
2015-05-15Fix potential Dialer NPEsYorke Lee
Fix NPEs encountered during monkey tests Bug: 21167534 Change-Id: I98b6f675adfd233d3583c363f7daeca1bc14d8b7
2015-05-13Reorganize Intent utilities, add send SMS intent.Andrew Lee
+ Rename CallIntentUtils.java to IntentUtil.java. + Consolidate various intent creation methods to new file, and update referenes throughout the application. Bug: 20433758 Change-Id: Iee9e37985217c38c816124d0e74dff40a2871680
2015-05-08Merge "Fix jank when showing dialpad" into mnc-devYorke Lee
2015-05-08Fix jank when showing dialpadYorke Lee
Reorder sequence of events so that the search fragment is only displayed after the dialpad animation is complete. Bug: 20891354 Change-Id: I3aaba7c715f740d7a7ee8f5273eee3b85bfdc958
2015-05-05Merge "Change FAB icon and behavior for contacts tab." into mnc-devAndrew Lee
2015-05-05Change FAB icon and behavior for contacts tab.Andrew Lee
+ Change the icon/behavior depending on the tab position. + Move current tab position logic from DialtactsActivity into the lists fragment. - Delete unused method, shift some helpers around. Bug: 19366434 Change-Id: I6da767300907b3afd006248afb882bebde7bdfe6
2015-05-05Merge "Revert "Fix NPE from ListsFragment crash."" into mnc-devAndrew Lee
2015-05-05Revert "Fix NPE from ListsFragment crash."Andrew Lee
This reverts commit d10eef28fc67aea0e4f4f49813b802ce1df5f7c7. Change-Id: I0867f991c071fc55d1eadf611386b713c910d17f
2015-05-04Add "show call history" list item.Andrew Lee
+ Add new VIEW_TYPE to the CallLogAdapter. + Reintroduce boolean on CallLogAdapter to specify if a call history list item should be shown. + Add new ViewHolder and layout for footer. + Some minor styling tweaks and cleanups. Bug: 20108202 Change-Id: Ie4a86bff9e53cfd69ef8b061af048f40f4358579
2015-05-01Fix NPE from ListsFragment crash.Andrew Lee
I'm not sure if anyone else is seeing this, but this change didn't seem like it would be harmful to make. I was running into sadness because mListsFragment was undefined. Change-Id: I75712c2cb3626002372ac9b4812c44c2ed74c12f
2015-04-23Use TelecomManager.placeCall APIYorke Lee
Bug: 20348183 Change-Id: If1b193f933b4a7b2b322784b0cbbc66c210b25df
2015-03-25Make menu options protected instead of private.Andrew Lee
Thsi allows Google Dialer to add a feedback option and handle its behavior accordingly. Bug: 19254693 Change-Id: I64ab34049406d10f53504af8d5eda9ac29758ef8
2015-03-06Remove OverlappingPaneLayout.Andrew Lee
- Remove the OverlappingPaneLayout, which is no longer needed since the recents card has been removed. - Known Issue: SearchBar is no longer hidden on scroll. - Known Issue: shouldShowActionBar does not return correct value. I plan to fix these KIs in a follow up CL, but going for incremental changes for now to try to keep it apparent what is being done. Bug: 19372817 Change-Id: I9ae1ca19820c87f252863074a5bcab6923b03558
2015-02-26Fix FrameLayout cast exception.Andrew Lee
I was seeing a ClassCastException: android.widget.FrameLayout cannot be cast to com.android.dialer.widget.SearchEditTextLayout. But, it's kind of bizarre, because it disappeared after I tried implementing this fix, even when creating what should have been a clean branch replicating the original conditions (?). In any case, this would make us more resilient to changes in the custom view used by the action bar by searching for the SearchEditTextLayout by id. Change-Id: I9f4909b55e4ef29562712643048eb3fb942ff684
2015-02-04Merge "Move CallUtil into Dialer. P1/3"Brian Attwell
2015-02-03Move CallUtil into Dialer. P1/3Brian Attwell
CallUtil relies on the a priviliged intent that should only be used by system apps. Therefore, it shouldn't be used by an unbundled Contacts app. I'm leaving one (isVideoEnabled) method from CallUtil inside ContactsCommon. This way, when the changes that Tyler made inside m-wireless-telephony-shamu-dev (b/19062133) get merged back into master both ContactsCommon and Dialer will be updated. Bug: 18777272 Change-Id: I49c9cc714ded01d523ed770a5bf62cf92c378e2f
2015-02-02Add DialpadFragment on-demand instead at on startupYorke Lee
Add the DialpadFragment dynamically instead of everything at startup. Once added, it is then shown/hidden instead of removed for performance reasons. Reduces startup time on a N5 from 603ms to 440ms. Bug: 18431193 Change-Id: I0482bd8277896ed8a6956fc03b6afaf44b442eb3
2015-01-28Add systrace events to track Dialer startup performanceYorke Lee
Bug: 18431193 Change-Id: I92db4ae61405d8d8445b72e7ac0daa0794af8335
2014-12-05Updating "Add Contact" to pre-populate full contact info.Tyler Gunn
1. For recent call entries with a name and phone number, the name will now also be added. 2. For recent call entries which have complete address information provided by nearby places, all information except the contact photo will be added. The contact photo is excluded, as the ContactsLoader would attempt to load the contact photo while parsing the contact information. On a slow connection this could cause a noticeable pause while adding the contact. Bug: 17308163 Change-Id: If2e78bd1257096b344ff2dd266dcdbaeed4f1471
2014-11-20Correcting population of search box with voice search results.Tyler Gunn
The issue is the onActivityResult callback which receives the result of the voice search is called BEFORE the dialtacts activity is resumed, and hence the search results fragment is not properly shown (since resume has not yet completed). Changed so that the search results are stored until onResume, where they are applied to the search box. Bug: 18410823 Change-Id: I02985f722643846067678a67f2c1fda76434fbc4
2014-11-08Allow ILD information to be populatedEvan Charlton
Expose the dialpad's ILD (international / long distance) fields to be populated by the dialer. Bug: 13334252 Change-Id: Ia366148ef1318a2dacc4971d51a3bd34ec3c39de
2014-11-06Merge "Improve Dialer analytics" into lmp-mr1-devYorke Lee
2014-11-05Improve Dialer analyticsYorke Lee
* Send screen view for first fragment loaded inside ListsFragment * Send screen view for voicemail playback fragment * Send screen view for currently active fragment when activity is restarted * Don't send spurious screen views on rotation * Send screen views for call log fragments in call log activity, and differentiate between them with a tag Bug: 18158037 Change-Id: I09fda53db33f6a6acc4a3b477de992aa94921c71
2014-11-05Reset mSavedState in onNewIntent because the activity is refreshing.Nancy Chen
Currently mSavedState is reset to false in just onResume, but it needs to be reset earlier so that the dialpad is allowed to show itself when an ACTION_DIAL intent is sent. Bug: 18242314 Change-Id: I9ddd2a431edc4c2d1cc447b14ee8d1347d139552