summaryrefslogtreecommitdiff
path: root/java
AgeCommit message (Collapse)Author
2017-09-28Refactor DialerStrictMode into an interface.wangqi
-bypassed violations are no longer logged in AospDialer The default implementation will use system strict mode and crash on bugfood build same as before. Bug: 66003745 Test: manual PiperOrigin-RevId: 170214128 Change-Id: Iab630f19499e90b15eb0b7f0707b4a70c7d81fbe
2017-09-28Adding logging for transcription polling requestsmdooley
This will allow us to tune the polling rate. Bug: 66966157 Test: none PiperOrigin-RevId: 170210987 Change-Id: I6ef204acc6e0d43a3ada524511866d4a629fe1e2
2017-09-27Updating non-verizon ToS string for declining ToSmdooley
screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdGY1RnVXM3JuMXB4OVRVOFhrSU9qRDR6c2pj Bug: 37340510 Test: manual PiperOrigin-RevId: 170131627 Change-Id: Ib022bba44e24675082299132a5965fbcb58257fa
2017-09-27Update v13 licencesuabdullah
Test: N/A PiperOrigin-RevId: 170130892 Change-Id: Ifc59f239043c66eaa8341fe34c080dad08454236
2017-09-27Setup recycler view for new voicemail uiuabdullah
Screenshot:http://screen/RK42CXn5uB6 Bug: 64882313,33006245 Test: VoicemailFragmentTest, NewVoicemailCallLogAdapterTest, NewVoicemailCallLogViewHolderTest PiperOrigin-RevId: 170129401 Change-Id: Ib82357763bd9cf9f215804225be009650402fe84
2017-09-27Force dialpad to hide on resume if it should be hiddentwyen
On M the framework does not retain the hidden state of a fragment properly when restoring it from a savedInstanceState. This appears to be fixed in N, but the exact cause and fix are unknown. This behavior will cause a fragment previously hidden coming back as visible when the device is rotated or going through any save/restore life cycle. Previously whether to show the dialpad is stored in a separate flag, and the dialpad will be hidden when it is reattached. This was regresed in cl/169614750 In this CL, if the saved mIsDialpadShown indicate the dialpad should not be shown, but the dialpad is not hidden, it will be hidden on resume. Bug: 66893723 Test: DialtactsActivityTest PiperOrigin-RevId: 170124711 Change-Id: I6f8ed21fb970d6f688cb75f854442115a6803f3c
2017-09-27Bypassed some strict mode violations.zachh
These are old code and considered to be grandfathered in. Cleaned up some warnings in GoogleLocationSettingHelper. Bug: 66498656 Test: none PiperOrigin-RevId: 170090310 Change-Id: I2c43564af751eb5f431a395d75afa5ce126b5d18
2017-09-26Fix onVisible/onNotVisible called on CallLogFragment without being attahced ↵twyen
after rotation mCurrentPage is set onResume before the fragment is attached. In this CL, mCurrentPage is still used for page change, but for resume and pause, it is detected directly in CallLogFragment using getUserVisibleHint() Bug: 65161134 Test: manual - change call volume after rotation, check ToS FAB not visible after rotation. CallLogFragment is not testable. PiperOrigin-RevId: 169984576 Change-Id: I870cbe3b83e38ac2cb505193309ab4f8e75a859f
2017-09-26Increase location title lengthmdooley
Need to increase character limit for location title text as the title string is now longer than the original character limit. This should have been part of cl/169270157 Bug: 66330058,66330115,66411110 Test: none PiperOrigin-RevId: 169967227 Change-Id: Ib49da4086c190d60da832d4ef64689e44b114150
2017-09-26Fix bug that phone number is not shown for non-contacts. (CNAP, business etc.)wangqi
Phone number should always be shown for non-contacts. Screenshots: https://screenshot.googleplex.com/guKEWdQKDpG https://screenshot.googleplex.com/iMcPte5Vhyc Bug: 64685156 Test: TopRowTest PiperOrigin-RevId: 169961072 Change-Id: Iaf8fc5b1e7f3d386d20deb01f4325efb5e645363
2017-09-26Use help center for GoogleDialer abouttwyen
The about in settings is removed in google dialer, it is accessed through the dialtacts overflow "Help & feedback" instead: https://screenshot.googleplex.com/9L1kdQz6c2B https://screenshot.googleplex.com/FqqdG6X9JTR Note that help articles has not been migrated at this moment. Features in the original about is placed in the overflow https://screenshot.googleplex.com/OmCVPqwGBM9 Version info is stock google help https://screenshot.googleplex.com/EdveVnXUSML Privacy policy/Terms of service opens the browser to the link we had before Open source license opens the same license activity in about. Bug: 34872689 Test: manual PiperOrigin-RevId: 169953610 Change-Id: Ib1c25ddecbf28293b447112cb280a8f9788692d3
2017-09-26Upgrade and refactor latency test over Dialer. Now it has Incall UI latency ↵weijiaxu
besides app launch latency. Alert functionality is not included in this cl. Add a new idlingResource for incall ui and a new method called waitForInCallUiShown in DialerCallEspresso. Add UiListener interface in CallList and insert uilisteners on onCallAdded() and onInCallUiShown(). Also, a g3doc page has been created in http://cl/168901452 to show the dashboards. Test: Run on a local device PiperOrigin-RevId: 169934618 Change-Id: I0ea10aca051c62cd8252ee5a3c9dfbce81316a33
2017-09-26Tweaking verizon's voicemail TOS textmdooley
Change verizon's ToS title to use the string 'visual voicemail' This change seems a bit strange since the verizon legal text uses the string 'Visual Voice Mail', but the title uses 'visual voice mail' screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuIR1lmaUF4OXk1SnFLdS1fbFpfMlFieWlTQ25v https://drive.google.com/open?id=0B9o_KvtLkcuIRURWd0hhYjc4NUdKQ1hzM2RIcG5fSmlHcGhJ Bug: 37340510 Test: update unit tests PiperOrigin-RevId: 169933539 Change-Id: Idba526293604b7a27083a91b86825ef66ce23bcd
2017-09-26Update text of call back number in emergency calls.wangqi
Screeshot: Before: https://screenshot.googleplex.com/bnByOaCTV4O After: https://screenshot.googleplex.com/v0vhkuuvT28 Bug: 38347145 Test: manual PiperOrigin-RevId: 169933363 Change-Id: Ia3728be488ff329531c171b03a3045f1839d1d5e
2017-09-25Fixing bug where missed call notifications were getting clobberedmdooley
The problem was that the same notification id was being used by both VisualVoicemailNotifier and MissedCallNotifier, causing the voicemail notification update code to filter out missed call notifications instead of ignoring them. Bug: 66168999 Test: manual and verified existing unit tests pass PiperOrigin-RevId: 169925851 Change-Id: Ifa69506a250557dd7bba631122fdd6d0744d6341
2017-09-25Don't show Lightbringer disclosure dialog after 1 day since viewed.yueg
We think it's viewed by user if it's showing and user scrolls on call log tab, since action in the same tab that moves the dialog is a strong proof. Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 169763132 Change-Id: Ie520c65627b1e5d364860507321fb268c89e0cf7
2017-09-25Fix crash on ending call.yueg
We moved onUiShowing() call from InCallActivityCommon.onPause to onStop in cl/169615685, which causes the crash since InCallPresenter is cleared up before calling onUiShowing() and mContext is null at that time. This CL fix the crash by also moving the clearup(InCallPresenter.unsetActivity()) from onPause to onStop. It also makes sense because InCallPresenter.onActivityStarted() is called in onStart instead of onPause. Test: manual PiperOrigin-RevId: 169756942 Change-Id: I222009be1b672f8a6dcb8bfdcea2d633c5810575
2017-09-25Update HD and Wifi feature of call log to use framework API.wangqi
Bug: 35359461 Test: none PiperOrigin-RevId: 169752834 Change-Id: If78723774babb86a55e07d4b94d9f1d784791b76
2017-09-25Updated image asset in location permission request.calderwoodra
screenshots http://screen/d2qPOq3h1o1 http://screen/wHcnO5LXRO2 Bug: 65858857 Test: n/a PiperOrigin-RevId: 169748652 Change-Id: Ie255f0d9be958f004c8bc9639d478553f66109d3
2017-09-22Log non-contact lightbringer actionstwyen
video call upgrade and calling from call log is logged Bug: 66222115 Test: DialerCallTest, GoogleCallLogAdapterTest PiperOrigin-RevId: 169703001 Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b
2017-09-22Delay commiting of promo fragment until user visits the contacts tabAndroid Dialer
Also fixes an issue where if the promo is shown after the dialpad or search UI is brought up then the promo will be added to the bottom of those UIs. Bug: 64491095 Test: manual PiperOrigin-RevId: 169700496 Change-Id: I76a1aa977df623964b843d8e4b20146ba7c2f874
2017-09-22Fixed call duration bug.calderwoodra
SimpleDateFormatter just wasn't working. This CL simplifies this method to something similar to what we had before the call details rewrite. To avoid going through the trouble of having the strings retranslated through the i18n coordinator, I've left them as is and worked around it. screenshots: before: http://screen/eJqs5EijCYe after: http://screen/AbrLFn0caL0 Bug: 63370483 Test: existing PiperOrigin-RevId: 169626011 Change-Id: I160529e276db2fc098a29b005db104e7ac601f15
2017-09-22Don't show bubble when InCallActivity is visible in multi screen mode.yueg
By moving InCallPresenter.onUiShowing() from InCallActivityCommon.onResume/onPause to onStart/onStop. Test: manual PiperOrigin-RevId: 169615685 Change-Id: I146a5d87028040b0f5e587b8163f29d55b9e7ff7
2017-09-22Fixed bug where dialer would sometimes show blank screen.zachh
To repro the bug: 1) Turn on "Don't keep activities" option in developer options 2) Open dialpad 3) Press home 4) Launch dialer from home screen 5) Observe blank screen Bug: 65458054,64129606 Test: unit PiperOrigin-RevId: 169614750 Change-Id: I65e53add0f1f53c510c402f4f8b7ed60dcef273b
2017-09-22Update ViLTE strings to reflect "carrier" video callingroldenburg
Outgoing video call: https://drive.google.com/open?id=0B7uuA4cyYX0xQjhUTGhrUWRKUlE Incoming video call: https://drive.google.com/open?id=0B7uuA4cyYX0xZFMyREVDWVNqaE0 Outgoing upgrade: https://drive.google.com/open?id=0B7uuA4cyYX0xdll3elRsUWhDT3M Incoming upgrade: https://drive.google.com/open?id=0B7uuA4cyYX0xZFMyREVDWVNqaE0 Incoming upgrade (Wi-Fi): https://drive.google.com/open?id=0B7uuA4cyYX0xWkJ6dU16Rmd1ckk Bug: 65131278 Test: manual, screenshots PiperOrigin-RevId: 169612967 Change-Id: I5163be6966ed7d68d19cff51e0d1637bd20b2c7e
2017-09-22Adding some contacts permission guards.calderwoodra
Bug: 64302851 Test: manual PiperOrigin-RevId: 169600984 Change-Id: I65376894012f2d570b6c918f3f5575e7f45bf938
2017-09-22Better handling country iso when getting geo location of phone number.wangqi
1. Use existing country iso info instead of guessing current country iso from sim and locale for blocked number. 2. Use country iso of current sim instead of default sim for incall location info. This fixes bug in multi sim device when default sim is out of service and making call with the other sim. Bug: 65399976 Test: manual PiperOrigin-RevId: 169554641 Change-Id: I416d7e2d6bc3c872bfec3eda4005a5a1684f0e40
2017-09-22Dialer integration of contacts suggestions promoAndroid Dialer
Illustration icon TBD https://photos.app.goo.gl/ZDLNLlXg9VBKNHGx1 Manual testing of duplicates promo end to end flow accept/dismiss states Bug: 64491095 Test: http://sponge/db7bd5c3-ec97-46c8-a058-ed7f46a5e4ce PiperOrigin-RevId: 169480950 Change-Id: Ia553e87ce72d84a001769851abb925da1ab31756
2017-09-22Updated ongoing call notification to reflect video call state.calderwoodra
screenshots: ongoing: http://screen/FkAM9hOU5Rq paused: http://screen/mrp6UJCoWAu Bug: 63274792,63271690 Test: StatusBarNotifierTest PiperOrigin-RevId: 169469414 Change-Id: I442e21d93b7e11dea191311acd28846ea257c156
2017-09-22Added dismiss button to location permission request.calderwoodra
This change adds a dismiss button to the location permission prompt shown in the search UI. A few other minor changes: - Permission prompt is always the first element in the list - Adjusted a few dimensions and strings screenshot: http://screen/9CkRPUQ5dwh Bug: 65858857 Test: SAT, NSFT PiperOrigin-RevId: 169466585 Change-Id: I8177c23fe3f635fec5fdcdbe6675428cebb19f5d
2017-09-22Refactor CallList to call onUpdateCall and notifyGenericListeners directly.wangqi
Bug: 62426694 Test: none PiperOrigin-RevId: 169447674 Change-Id: I3014b289c26d24ac571421bc54fcacc303278b41
2017-09-22Added location permission request inline the search fragment.calderwoodra
This change adds a prompt inline the search fragment list view to request the location permission (if they haven't already granted it). screenshot: http://screen/upu9t55mghq Bug: 65858857 Test: NSFT, SAT, SCMT PiperOrigin-RevId: 169447095 Change-Id: I6c312057ff3c4e2362ce21b0c57e1e5de7b25ce0
2017-09-22Update package assets and strings.Eric Erfanian
Test: TH Change-Id: I48e807f3eafbc82401b2674a2610b20bf118c275
2017-09-20Forgot to keep this file in sync with ↵Android Dialer
//google/internal/communications/voicemailtranscription/v1/voicemail_transcription.proto Test: n/a PiperOrigin-RevId: 169425975 Change-Id: I0d53a576e1245cc1c4d7c8e36df3a510d8c7bdbe
2017-09-20Fixed issue where all contacts weren't beign shown.calderwoodra
The underlying issue was that if a query was input that filtered out all of the on device contacts, then the device rotated, the cursor would be reloaded with all contacts filtered and getCount == 0. This would cause the cursor to never be set in SearchCursorManager and on device contacts would no longer be shown because the cursor wasn't being saved. The reason this check was here, was because cursor headers were being managed by SearchCursorManager. Since headers were moved into the cursors we no longer need to set cursors to null if they are empty. Bug: 65859191 Test: existing PiperOrigin-RevId: 169425922 Change-Id: I0baf31c3747d679f394f3746f609b9487e52472d
2017-09-20Add more logging when video surface texture is destroyed.wangqi
Bug: 63608380 Test: none PiperOrigin-RevId: 169425768 Change-Id: I297b945c9601bb070f3ef08d7ca34a76629b42c7
2017-09-20Don't truncate long voicemail transcriptionsmdooley
Also repostion contact icon (for allen, is there a bug for that?) Originally i tried wrapping the transcription in a ScrollView, but that didn't really work since there's no easy way to set a max-height for it. Since most voicemails transcriptions are not that long, an easier solution was just to not limit the number of lines for the transcription. screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuINkdXeVV0U0dOZVNfdExzSDNsai1Ld2F3ZlBN https://drive.google.com/open?id=0B9o_KvtLkcuIZTZFQzRQaW1nblBPN2JkVW1hMkR3YWl1b2JV Bug: 64211399 Test: manual PiperOrigin-RevId: 169425482 Change-Id: I63c9165f48d902c06e288280116cd9b95d67852c
2017-09-20Added some bug fixes in call details.calderwoodra
When a user dials a number with post dial digits, they are now carried to contact details and used when they redial that number. Additionally, when a user clicks on a photo in call details, they will be taken to Bugle now. This behavior already exists with messages in CD. Bug: 62236726,62230491 Test: CDEVHT PiperOrigin-RevId: 169422921 Change-Id: I1507cb64876540cfc9a683a5a1ea01910443f77b
2017-09-19Enable Orange FR/BE visual voicemailtwyen
Bug: 65980572 Test: manual PiperOrigin-RevId: 169336670 Change-Id: I6acd6226c1a03b8f0c12309bc84ae7c2bdad5f30
2017-09-19Show legacy voicemail notification under FBEtwyen
This CL partially revert cl/159492498, since data SMS cannot be properly processed under FBE and visual voicemail notification won't be received. Bug: 65555345 Test: LegacyVoicemailNotificationReceiverTest PiperOrigin-RevId: 169321096 Change-Id: I7134d80479efef67de8d5d44131eea30f82297a0
2017-09-19Fix notification update bugmdooley
The problem was that the query for looking up a voicemail by URI was broken which was causing the notifications to be cancelled then when they were supposed to be updated they were actually getting re-added thus causing the notification sound. Bug: 65692173 Test: manual and unit test PiperOrigin-RevId: 169304391 Change-Id: I1e8f648231b6f0ab984a5b0e4facd8351b01391a
2017-09-19Refactor second call logginguabdullah
Just easier readability since getFirstCall() is null until it's added to the call map. Test: N/A PiperOrigin-RevId: 169287247 Change-Id: Ifda5ead27d987e17f259da761a0109d930efa6c3
2017-09-19Perform remote reachability query if caller is not in contactstwyen
Lightbringer.supportsUpgrade() is changed to return absent optional when it does not have data for the number. Seeing this LightbringerTech will use Lightbringer.updateReachability() to retrieve it from the remote package, which will store it in the reachability cache. Bug: 63601277 Test: RemoteReachabillityQueryHandlerTest, LightbringerTechTest PiperOrigin-RevId: 169283953 Change-Id: I3f26d9158fc6cfed196fd533da2aad598c8e6a7a
2017-09-19Only enable voicemail transcription on android O and latermdooley
Bug: 65648343 Test: updated unit tests (already submitted in previous cl) PiperOrigin-RevId: 169280819 Change-Id: I5950087765ffd038c31b872c6468951472980407
2017-09-19Removed zero suggest from dialpad search in new search fragment.calderwoodra
Zero suggest in dialpad search clutters the UI and we shouldn't show and search results until the user has input something into the dialpad. Additionally, this change ensures the fab stays hidden through device rotation in regular search. Bug: 65858825 Test: implemented PiperOrigin-RevId: 169270161 Change-Id: Ia08ce56ffd02f74ea9e4d9d8a1efc3726fcc66d9
2017-09-19Tweaking emergency location textmdooley
Bug: 37242283 Test: none PiperOrigin-RevId: 169270157 Change-Id: Ic07df7a1611ebf1b997f1a908fa341f9bf542cbd
2017-09-19Add "Turn speaker on"/"Turn speaker off" action button in notification.yueg
Add action button when create in call notification and when audio state changes to ROUTE_SPEAKER or ROUTE_WIRED_OR_EARPIECE. Ignore when audio state is ROUTE_BLUETOOTH. Screenshot: Speaker on: https://screenshot.googleplex.com/hnsQL0YcFJj Speaker off: https://screenshot.googleplex.com/oFrbvbs9gVG Test: StatusBarNotifierTest PiperOrigin-RevId: 169169372 Change-Id: I2f96f20170dd174b35dfd3f7578fe5b9450391ab
2017-09-18Log if a call is IMS reachable.yueg
And fix a related test in ImsVideoTechTest. LOG_STORAGE_INCREASE(GB/week): 0.7 5M active block user/day * 10 events/active = 350M event/wk 350M event/wk * (2 [bool])/event = 0.7GB/wk Test: LoggerUtilsTest PiperOrigin-RevId: 169153878 Change-Id: Ia8038a5b0961f1a5572541f21df7a2680d85bbbb
2017-09-18Use logCallImpression for bubble expand/collapse if possible.yueg
So we can associate all bubble actions with call id, and analyze bubble actions per call session. Also move code for sending primary action back to primaryButtonClick(), which is introduced in cl/167347311. Test: manual PiperOrigin-RevId: 169152088 Change-Id: I97f0971f162684d882f6addbc012f6e8552216b7
2017-09-18Always show line1 number in emergency call.wangqi
The subcription number might be different than the line1 number (sim number), which could be confusion to user during emergency call when it's not same as the sim number the user knows of. Bug: 65685277 Test: manual PiperOrigin-RevId: 169147724 Change-Id: I2f89559d10a188b13937e80528b756cc9b11a02e
2017-09-18Now persist state through configuration changes in Search.calderwoodra
This CL adds logic to persist the search query and call initiation type through configuration changes like device rotation. list of bugs: https://docs.google.com/document/d/1GajzkAqXXRqbj_-qeYeDxIKr0fPsSZC3nXhRkIQg5tE/edit#heading=h.bopot1qivvxg Bug: 65751247 Test: NSFT PiperOrigin-RevId: 169146766 Change-Id: I7a68c01d5698c07a362ad621642a9138fd9a9aaa
2017-09-18Bump versions for v14maxwelb
v13 is now at go/dialer-v13, I've set it's max version to 1899999. Test: N/A PiperOrigin-RevId: 169123311 Change-Id: Ib8304953d0ad974a2f22c1b390ff3bb180360244
2017-09-18Fixed crash when users press back twice in call composer.calderwoodra
Bug: 65686665 Test: manual PiperOrigin-RevId: 168983351 Change-Id: I6443a05c8435e777c52ed3586dfc228a0fb0f51f
2017-09-18Pressing back when the dialpad is empty now exist the search UI.calderwoodra
Bug: 65687672 Test: existing PiperOrigin-RevId: 168951800 Change-Id: Ie840acd608424551198ba3440d6060a7cd7a629f
2017-09-18Dialpad VM and + are now only accessible w/ double-tap instead of long hover.calderwoodra
Users using touch to explore with TalkBack on the dialpad would occasionally call voicemail if they hovered over 1 for a long period of time. This functionality doesn't align with keyboards, where a long hover still acts as a normal click. This CL updates the Dialpad to align better with a keyboard and now users can only speeddial voicemail and type a 0 with double-tap activation. Bug: 62712616 Test: manual PiperOrigin-RevId: 168909308 Change-Id: Ib46342f173aef7c2ef64c2b42745966f83266b98
2017-09-15Make voicemail transcription text selectable and phone numbers clickablemdooley
Also replace deprecate android:singleLine=true with android:maxLines=1 video: https://drive.google.com/open?id=0B9o_KvtLkcuIWGVBOElWdFNKa1E Bug: 65678844 Test: manual PiperOrigin-RevId: 168858718 Change-Id: I8be70e8496a8f0c562ca09eb315bb4e28b3e9c00
2017-09-15Updating voicemail TOS UI to match mocksmdooley
verizon TOS screen shot 1: https://drive.google.com/open?id=0B9o_KvtLkcuIU3VpLUpqcXBUYy1QY19UUk81a29sdGQyNEZZ verizon TOS screen shot 2: https://drive.google.com/open?id=0B9o_KvtLkcuIN3R6SUFjS3RVTWhZQUM1UzhoajhNUF9ZbzJJ non-verizon TOS screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIeVFYaWhYZmRzYVctU2F6N1VqazcycGpmNmRZ Bug: 37340510 Test: manual and update unit test PiperOrigin-RevId: 168851805 Change-Id: I7be27360093cae315b7249152e10d1beae5c5966
2017-09-15Dialpad chooser now properly shows when in a call.calderwoodra
Bug: 65212837 Test: DialpadFragmentTest PiperOrigin-RevId: 168745371 Change-Id: I62da45cdac58e3387343589b952e5d6bce7a4ee2
2017-09-13Fixed an animation bug in new search fragment that was clipping results.calderwoodra
Test: manual PiperOrigin-RevId: 168612783 Change-Id: I811133aee3301bac6936d5ba101719c30322d3be
2017-09-13Setup SMS filter even if VVM is already activatedtwyen
VVM can be "activated" through restoring shared preferences from another device. In this case the SMS filter in telephony is still not configured, and needs to be set up. Bug: 65542413 Test: ActivationTaskTest PiperOrigin-RevId: 168560153 Change-Id: I46dd9b31e43899d8d567e7e6baebf06559548525
2017-09-13Log opening dialpad.yueg
Bug: 64399026 Test: None. PiperOrigin-RevId: 168456040 Change-Id: I65fdae8dff1c9bb8e05e79f3ece2480b92f08c69
2017-09-13Fixed crash in RemoteContactCusror.calderwoodra
Test: manual PiperOrigin-RevId: 168427349 Change-Id: Ie58920b76266ebb298210b5faac8fcbda4dbcd15
2017-09-13Log swiping and clicking for switching tabs.yueg
If it's a swipe, onPageScrolled() is called several times before onPageScrollStateChanged(SCROLL_STATE_SETTLING) and onPageSelected(). If it's a click, only onPageScrollStateChanged(SCROLL_STATE_SETTLING) is called before onPageSelected(). And onPageScrollStateChanged(SCROLL_STATE_SETTLING) will not be called if user don't switch to a new tab. We use the difference to tell if user switching tabs by swiping or clicking. Test: DialtactsActivityTest PiperOrigin-RevId: 168403148 Change-Id: Iaaf84ab9c4955d0bc2c1e9857ba59fd37b3984af
2017-09-11Send PhoneAccountHandle with ACTION_CONFIGURE_VOICEMAILtwyen
When opening a voicemail setting from Dialer with ACTION_CONFIGURE_VOICEMAIL, no subId is passed. So on a multi-SIM device, it is always configuration on the default phone regardless of SIM. To solve this, set the PhoneAccountHandle to intent extra for ACTION_CONFIGURE_VOICEMAIL. In the advanced settings, obtains subId from the PhoneAccountHandle. Test: manual - Checked that correct PhoneAccountHandle will be passed with ACTION_CONFIGURE_VOICEMAIL intent Bug: 65001008 Author: xuegang.x.liu <xuegang.x.liu@sony.com> Bug: 65001008 Test: manual - Checked that correct PhoneAccountHandle will be passed PiperOrigin-RevId: 168019873 Change-Id: I8578dd2c4ac24e4af121a90b2b175baae2832461
2017-09-11Fix NPE in contacts fragment.calderwoodra
Bug: 64716624 Test: manual PiperOrigin-RevId: 168017541 Change-Id: Ia8e581f19a0a9c4d45bacc4ab94e54131763640a
2017-09-11This is a rollforward of cl/167332236calderwoodra
Improved behavior of back button in search ui. Pressing the back button in the search UI now functions as follows: - If the keyboard is opened, the keyboard is minimized - If the dialpad is opened, the dialpad is closed - If the keyboard and dialpad is closed, the search ui is closed Our existing behavior was dependent on whether a query had been built yet. basically, if the user pressed back with no query selected, the search ui was closed. From the bugbash: 7. No scroll bar in the search results if the results do not fill the entire view. The keyboard overlaps the results and there is no way to get to the enter list without dismissing the keyboard. 10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow points down but works like back button Bug: 62685859,63691995,63939331,64137632,64902476 Test: manual PiperOrigin-RevId: 168004913 Change-Id: Ia566fce6d90454a3eae6ecccfa81ce7e909e878f
2017-09-11Updating voicemail notificationsmdooley
This is mostly just a revived version of cl/158901400. It adds a job service that is triggered by changes to the voicemail database. The job updates voicemail notifications, as necessary. video of notification update: https://drive.google.com/open?id=0B9o_KvtLkcuId1ptNk1EbGotWFU Bug: 37340510,27535759 Test: manual and unit test PiperOrigin-RevId: 167934550 Change-Id: I36f03c0769645f7a0cb478172171f1079eca2108
2017-09-11Updating voicemail notifications for transcription, part 2mdooley
Changing voicemail notifications to match the latest mocks, (replacing the 'Voicemail' title with what was the notification content, and putting the voicemail status or transcription in the notification content). The notifications will be updated in a following cl. screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIbDdjaTNHTFFZLW9YZEo1SG5scDR6SzloaWc4 Bug: 37340510 Test: manual PiperOrigin-RevId: 167928866 Change-Id: I81492f7fbf1cc398401a948e036854d6a8ff878b
2017-09-11Automated g4 rollback of changelist 167310802.calderwoodra
*** Reason for rollback *** Turns out blocked number activity is actually used for devices on M. *** Original change description *** Removes the unused dialer/app/filterednumber package. *** Test: n/a PiperOrigin-RevId: 167663280 Change-Id: I6af1fc7d6eb61f946d4fba255fe7374bcdee0e72
2017-09-11Automated g4 rollback of changelist 167332236.calderwoodra
*** Reason for rollback *** Based off a CL that needs to be rolled back. *** Original change description *** Improved behavior of back button in search ui. Pressing the back button in the search UI now functions as follows: - If the keyboard is opened, the keyboard is minimized - If the dialpad is opened, the dialpad is closed - If the keyboard and dialpad is closed, the search ui is closed Our existing behavior was dependent on whether a query had been built yet. basically, if the user pressed back with no query selected, the search ui was closed. From the bugbash: 7. No scroll bar in the search... *** Bug: 64902476,64137632,62685859,63691995,63939331 Test: n/a PiperOrigin-RevId: 167661409 Change-Id: I0627d54af33fb55c64b5edcd459dde6a73d93266
2017-09-11Updating transcription UI to match latest mocks, part 1mdooley
-add branding 'Google is transcribing' -add branding 'Transcribed by Google' in-progress screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVVTX3BBZkNzV180alZPQ3EtR3gzRFNoamhV transcribed by screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuISUdaRjBlUFpjYTBWWTg1STVHS0oyQmNiSUVR Bug: 37340510 Test: manual PiperOrigin-RevId: 167620447 Change-Id: I5526bebb6999cf77b0902ae50ca72e380538a6e7
2017-09-11Fixing transcription crashes caused by job stoppagemdooley
Apparently, scheduling a new job when one is already running (even using the enqueue api) causes the running job to be stopped. We weren't handling that case correctly. This cl makes sure no more work is attempted after a job is stopped by cancelling any active transcription task. We request that stopped task be rescheduled by the job scheduler, so it will get run eventually. I was able to verify this fix by sending a new voicemail while backfill old transcription tasks were running. Bug: 64908823,63524274,65129734,63803709 Test: manual and unit tests PiperOrigin-RevId: 167617191 Change-Id: Icc92997c2687e61bef9b3b7f9ff572da2cb4ed2e
2017-09-11Strip trace info for release build.wangqi
Each trace info will add several milliseconds overhead and it's not used by end user. Bug: 64542087 Test: none. PiperOrigin-RevId: 167614347 Change-Id: I70c032fde162d6c8aa46be72c9ece3b7c3249fe8
2017-09-11Load VVM config override before loading anything elsetwyen
The override config is used by carriers to test out different configs using a prod dialer. Previously the type was loaded before the override config, causing carriers that is not currently supported never able to force enable VVM. This CL also fixes getCarrierPackageNames() and getDisabledCapabilities() not loading the override. Bug: 65370543 Test: revived OmtpVvmCarrierConfigHelperTest PiperOrigin-RevId: 167614182 Change-Id: Ibafdaf5fdc3e948bc65656f94c4bdc7d6e97046c
2017-09-11Fix bubble crash when dismiss audio route selector dialog.yueg
When AudioRouteSelectorDialogFragment tries to call onAudioRouteSelectorDismiss() on its parent AudioRouteSelectorActivity, the parent might already finish, which causes NPE. We should make sure the fragment is dismissed and removed before the activity finished. We do it when activity onPause because we don't expect it to resume. Test: AudioRouteSelectorDialogFragmentTest PiperOrigin-RevId: 167607068 Change-Id: Ifd2efcc92eb45262da2c6441bfac8119799d78f2
2017-09-11Ignore read missed calls and voicemails for notificationtwyen
When the call log is restored by the system, all items are marked as new even though they could already been read. This causes a torrent of "missed" calls after restoring call log with the setup wizard. This CL ignore read entities in the query. Bug: 62871863 Test: CallLogNotificationQueryHelperTest PiperOrigin-RevId: 167602820 Change-Id: Iba5609ace895a309685bfcd61eae85e080562ec5
2017-09-11Switch Dialer to use new third_party bubble librarysail
This CL switches Dialer to use the new common bubble libary. It also moves the integration tests into the bubble libary. Bug: 64797730 Test: BubbleIntegrationTest PiperOrigin-RevId: 167439680 Change-Id: Ie2e9367cb6a6561efb8abd425b6a12f8c1e78138
2017-09-07Added search actions to the end of the dialpad search results.calderwoodra
Users can now create new contacts, add to existing contacts, send sms and make ViLTE calls from dialpad search results. screenshot: http://screen/7iR038nUvmh from the bugbash: 11. Missing “Create new contact” “Add to a contact” “Send SMS” from search results with a phone number search Bug: 64902476 Test: many PiperOrigin-RevId: 167362073 Change-Id: I2f94d863035c119ec526e02e088992c618a858a9
2017-09-07Disable action on bubble when hiding, and reable it when showing.yueg
Allowing click or moving bubble when hiding bubble makes no sense. Also, hide() and swapViewHolders() (called when expand/collapse) may add/remove the same view to windowManager and cause crash. Before: https://drive.google.com/a/google.com/file/d/0Bz1rQbdSCWSKRDEyT2JDdk9LVDA After: https://drive.google.com/a/google.com/file/d/0Bz1rQbdSCWSKUE53aldna0RFVFE Test: BubbleTest PiperOrigin-RevId: 167334496 Change-Id: Id7f5ce4bdfa074840c1e9fac981abad59e261c0e
2017-09-07Improved behavior of back button in search ui.calderwoodra
Pressing the back button in the search UI now functions as follows: - If the keyboard is opened, the keyboard is minimized - If the dialpad is opened, the dialpad is closed - If the keyboard and dialpad is closed, the search ui is closed Our existing behavior was dependent on whether a query had been built yet. basically, if the user pressed back with no query selected, the search ui was closed. From the bugbash: 7. No scroll bar in the search results if the results do not fill the entire view. The keyboard overlaps the results and there is no way to get to the enter list without dismissing the keyboard. 10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow points down but works like back button Bug: 64902476,64137632,62685859,63691995,63939331 Test: manual PiperOrigin-RevId: 167332236 Change-Id: I1c0b5b429316dae119b5fb21be4303d7fe052e35
2017-09-07Fix crash when Context is null in InCallPresenterroldenburg
We need to use the Context to check if the device is a ODR device for a workaround (http://cl/165734624). It turns out the Context can be null (rarely). In those cases, we should not crash. Bug: 64954483 Test: manual PiperOrigin-RevId: 167326838 Change-Id: I4d8d8de86b5e3a4eca165a562f2ddc6106052c6e
2017-09-07Bump version code and name to Dialer v12.1 and Dialer v13 (again).Android Dialer
This CL updates version codes and name for Dialer v12.1 to 17*****. Doing so also bumps v13 to 18*****. Test: N/A PiperOrigin-RevId: 167326768 Change-Id: I3765a9ae8b06669a3eb96fef03a8a1432b3fc278
2017-09-07Adding dialer specific transcription error codesmdooley
These new states will be used to show descriptive failure messages to the user. Also moved the VoicemailCompat class to avoid duplicate code. Bug: 37340510 Test: none PiperOrigin-RevId: 167314611 Change-Id: I618d7f196ea2b0161cbd33479553cae3521328d7
2017-09-07Removes the unused dialer/app/filterednumber package.calderwoodra
Test: manual PiperOrigin-RevId: 167310802 Change-Id: Ie27a1b2f4daf73133edfb9de7f4e4aff1d87b6c8
2017-09-07Ignore invalid action for LegacyVociemailNotificationReceivertwyen
Somehow a null action will be sent to the receiver. Bug: 64934925 Test: LegacyVoicemailNotificationReceiveverTest PiperOrigin-RevId: 167300542 Change-Id: Ifa001d102d265e1dad42806b48f0a1710d05b195
2017-09-07Use simulator to add in-call UI integration testssail
This CL uses the simulator connection service to perform integration tests for incallui. The main pieces of this CL are: - DialerCallEvent - this is how we track changes to the incallui calls - Simulator.Event - this is how we track changes to a simulator connection With the above two we can do things like: - block until a DialerCall switches from ACTIVE TO ONHOLD: - DialerCallEspresso.waitForNextEvent(tracker, call, new DialerCallEvent(STATE_CHANGE, "ACTIVE", "ONHOLD") - block for a connection to recive a particular DTMF code: - SimulatorConnectionEspresso.waitForNextEvent(call, Event.DTMF) Future CLs will include things like: - fling to answer / reject - conference calls - screenshot diffing - video calling Test: InCallActivityTest PiperOrigin-RevId: 167211015 Change-Id: Ib013b10fe963092fad0816b07b1659efd69d9468
2017-09-06Adjusted layout dimensions in new search UI.calderwoodra
screenshots: default: http://screen/qEdB51A3PDn zero-query: http://screen/qEBDg0auGA8 query: http://screen/SuLp2GwyvYr Bug: 64806278 Test: manual PiperOrigin-RevId: 167205946 Change-Id: I07563fd23801da8d9d2eb95f6d09a079474403eb
2017-09-06Lazy loading animation of hd icon.wangqi
This save us ~180ms on Go device. (analyzed by systrace) This change also adds some trace information on incallui. Bug: 64542087 Test: manual PiperOrigin-RevId: 167201182 Change-Id: I0e8549cfb3534d518e3990696616855bcf7733f2
2017-09-06Use TelecomManager#isInManagedCall starting from O.wangqi
The TelecomManager#isInCall method returns true anytime the user is in a call. Starting in O, the APIs include support for self-managed ConnectionServices so that other apps like Duo can tell Telecom about its calls. So, if the user is in a Duo call, isInCall would return true. Dialer uses this to determine whether to show the "return to call in progress" when Dialer is launched. Instead, Dialer should use TelecomManager#isInManagedCall, which only returns true if the device is in a managed call which Dialer would know about. Bug: 36991070 Test: none PiperOrigin-RevId: 167200903 Change-Id: I12ac7b893dcbfa2fc842ca5ab356fbbc490a098b
2017-09-06Setup SMS filter during activation if legacy mode is usedtwyen
If the user disabled VVM on pre-O devices then upgrade to O, dialer will not setup the filter because VVM is disabled. The legacy mode which translate VVM SMS into traditional notifications needs the filter to operate. This CL sets up the filter if legacy mode is used. Bug: 65050952 Test: ActivationTaskTest PiperOrigin-RevId: 167199492 Change-Id: I2c77f0c6964b157d36bfa2adde7169b9ac6ccc3a
2017-09-06Last contact in search is now visible when dialpad is closed.calderwoodra
When the dialpad closes and we enter regular search, the fragment translates downwards so the upper contact is not cropped. This resulted in the bottom contact being cropped. Now the fragment translates and resizes so all contacts fit in the provided space. from the bugbash: #20: last contact is hidden off screen when in regular search screenshot: http://screen/vbduKLKKor2 Bug: 64902476,36880551 Test: manual PiperOrigin-RevId: 167189351 Change-Id: I3ba5795ba4c2f781dc320add3928c5ad74070b46
2017-09-06Added logging to aid debugging of issue where dialer shows blank screen.zachh
Bug: 64129606 Test: none PiperOrigin-RevId: 167174480 Change-Id: I4b5a494b0b334b42ee053c4d4d1e81d7699461d0
2017-09-06NewSearchFragment contact photos now properly open quick contact cards.calderwoodra
There was an issue where businesses' and remote contacts' contact photos wouldn't open contact cards correctly. The issue was rooted in the incorrect contact uri being assigned to the quick contact badge. from the bugbash: 16. Tap on business icon from search results says “ no application found” instead of opening the business info 17. Same as #16 but with contact from Directory Google.com - “The contact doesn’t exist” when tapping contact icon Bug: 64902476 Test: existing PiperOrigin-RevId: 167111016 Change-Id: I4b6f7ca812d2fc4dc220951e8c05db2c8b8d6114
2017-09-06Added presubmit check to remove static imports from third_party java/calderwoodra
Test: http://screen/9eBrOUZj90T PiperOrigin-RevId: 167099613 Change-Id: I3ae96b376ced290ff9d1f328cfaf29b8f8fce979
2017-08-31Update Dialer source to latest internal Google revision.Eric Erfanian
Previously, Android's Dialer app was developed in an internal Google source control system and only exported to public during AOSP drops. The Dialer team is now switching to a public development model similar to the telephony team. This CL represents all internal Google changes that were committed to Dialer between the public O release and today's tip of tree on internal master. This CL squashes those changes into a single commit. In subsequent changes, changes will be exported on a per-commit basis. Test: make, flash install, run Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160 Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8 PiperOrigin-RevId: 167068436
2017-06-12Disable Orange VVM in AOSP dialerTa-wei Yen
Orange has made a few request that cannot be resolved in the O timeframe. VVM support for it should be disabled in AOSP so OEMs won't get it by default without the fixes. These issues will be resolved in August when O is released and dialer is doing regular drops in the public. France is live in prod while Belgium/Luxembourg is experimental behind a flag. This CL does not affect GoogleDialer in the system image Change-Id: Ia7e5c9b5d2411a15453f585bb9eae88aae1bbc00 Fixes: 62536071 Test: manual
2017-06-01Merge "Remove usages of ActionBarActivity." into oc-devTreeHugger Robot
2017-05-31Update Dialer to v10 RC45.Eric Erfanian
This release was created following the instructions at: go/dialer-aosp-release Subsequent dialer releases will follow as O bugs are fixed, until we reach our final RC. Version: 10 Candidate: RC45 Branch: dialer-android_release_branch/153304843.1 dialer-android_20170416.00/dialer-android_20170416.00_RC45 This release contains the following bug fixes since RC39: Bug: 38131932 38302993 38347350 38368993 38395481 62100344 Test: make, on device Change-Id: Ib4af5dcc58c684d51ea1f4628b301e40184b81b3
2017-05-26Set camera to null when disabling IMS video transmissionSailesh Nepal
From Tyler's investigation: In the past (Marshmallow days) we used to call setCamera(null) as well as sending the downgrade request. Stopping the video transmission is one thing but I think the modem implementation depends on the camera being nulled to clean up its resources. (This CL is a manual cherry pick of cl/157154988 from google3 to gerrit.) Bug: 38395481 Change-Id: I7f71c1ffb7194165b8968cd4a033ffea1af443ed
2017-05-24Remove usages of ActionBarActivity.Aurimas Liutikas
ActionBarActivity has been deprecated for 2+ years and has been extending AppCompatActivity for all that time. These changes should be no-ops. Bug: 35253513 Test: None Change-Id: Ic87c8db6f9733fbcfa59d3bc08c77013799ae652 (cherry picked from commit 27b5eaeb2d0cdffb0b89db4971894548da8afdd4)
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 12:52:27 +0000