summaryrefslogtreecommitdiff
path: root/java
AgeCommit message (Collapse)Author
2018-04-13Increased tap target for 3-dot menu in new call log.zachh
Accomplished by replacing margin with padding. TEST=manual Bug: 77812328 Test: manual PiperOrigin-RevId: 192818386 Change-Id: Iaf58b8460c18259a0472fd154695238c7e93a489
2018-04-12Add Duo disclosure card to the new call log.linyuh
Bug: 70989614 Test: NewCallLogAdapterTest PiperOrigin-RevId: 192692744 Change-Id: I42dbb5738558803ad6eae9fe2c2f98b31c49f360
2018-04-12Added impressions.zachh
Bug: 77715083 Test: unit PiperOrigin-RevId: 192688918 Change-Id: I4448162871ea69ba07c1ed022e9c7daa936dab64
2018-04-12Add RTT transcript to call details.wangqi
1. Save RTT transcript when call is destroyed 2. Show RTT transcript link when it's available Bug: 67596257,77717594 Test: manual PiperOrigin-RevId: 192673172 Change-Id: If541ad9137c965166548d2fb449e835b95566727
2018-04-12Get dialpad fragment hint text sooner and hold onto it.calderwoodra
Bug: 77908301 Test: opened dialpad, didn't crash PiperOrigin-RevId: 192654487 Change-Id: If5bf9b6df7f15364358fb601d154d4bb99dd5b55
2018-04-12Add SpeedDialFragment to the old peer.calderwoodra
Bug: 36841782 Test: OldMainActivityPeerTest PiperOrigin-RevId: 192647371 Change-Id: I3fff1784ce642b86f1e87a27e38737833f74c6b0
2018-04-11Added context menu for favorite contacts in new speed dial.calderwoodra
Bug: 36841782,77761023 Test: WIP PiperOrigin-RevId: 192556602 Change-Id: I50c0baef7ef6c8ae533545567ec797283a9a870f
2018-04-11Ignore case for GID matchingtwyen
TEST=TAP Bug: 77838297 Test: TAP PiperOrigin-RevId: 192534802 Change-Id: I9c6b0aaab33f5ae5e9d26131c7a9a2858005c385
2018-04-11Add support for support fragments in UiListener.calderwoodra
Bug: 36841782 Test: SupportUiListenerTest PiperOrigin-RevId: 192502743 Change-Id: Id06ed732528db1ae486def86ecc2f44828635d81
2018-04-11Add RTT badge to new call log.wangqi
Bug: 77717594 Test: ContactPhotoViewTest PiperOrigin-RevId: 192492913 Change-Id: I6db36017fde2cf9dca580d60d5c88bf2ad2dfe16
2018-04-11Update logic for incoming and active calls.erfanian
Bug: 73774461,73774884,73775516,73775590 Test: unit PiperOrigin-RevId: 192456945 Change-Id: I0f0b44e56550939d4af16297bd305297e6c74310
2018-04-10Change speaker button for in call UI and bubble.yueg
Bug: 74238896 Test: ButtonControllerTest PiperOrigin-RevId: 192370117 Change-Id: I265cc9541957c2dd376176ed7a703b4938fe4563
2018-04-10Add RTT icon to RTT call log.wangqi
This is for old call log UI. This change also improves scaling for vector drawable icons. Bug: 67596257 Test: manual PiperOrigin-RevId: 192359601 Change-Id: I3322fe08b668f01c1e3a7ce3264c2988e2703aae
2018-04-10Add a flag to control whether to show spam blocking promotionAndroid Dialer
Test: SpamBlockingPromoHelperTest PiperOrigin-RevId: 192355809 Change-Id: Id9fc792b6e4649af4df588a523299a8fcf7727f0
2018-04-10Implement the disambig dialog for favorite contacts.calderwoodra
Bug: 36841782,77760800 Test: DisambigDialogTest PiperOrigin-RevId: 192354880 Change-Id: Ie7e9f0e3994d871ce6c90e4028131204ccb0a32a
2018-04-10Wire up SpeedDial fragment with SpeedDialUiItemLoader.calderwoodra
This change is mostly just a migration from a cursor loader and cursor to a listenable future and list of POJOs. Bug: 36841782 Test: tap PiperOrigin-RevId: 192349724 Change-Id: I37140dcc2e5e03bc5745573c0d777e18c4f1a880
2018-04-10Add Tracfone VZW GID to vvm_config.twyen
TEST=Manual Bug: 77838297 Test: Manual PiperOrigin-RevId: 192343100 Change-Id: I2f054d432c54359b99dcf4e15d9059abdda91293
2018-04-10For an audio call log entry, add a video call option in the bottom sheet if ↵linyuh
the capability is present. Bug: 70989603 Test: ModulesTest PiperOrigin-RevId: 192302145 Change-Id: I3162e7d22223aa02709d0d401c70c6fc37a00e3b
2018-04-09Autogenerate IDs for inserts and consolidate loader into one transaction.calderwoodra
Bug: 36841782,77724716,77725859 Test: implemented PiperOrigin-RevId: 192191296 Change-Id: I7a22367b33c7555d014a29a2af2942f2eb76c0a5
2018-04-09Ensure listeners are added each time setUp is calledroldenburg
Bug: 77666799 Test: existing tests in InCallPresenterTest PiperOrigin-RevId: 192191167 Change-Id: Ifa35451cf94d925f9d73397460b48754952cb216
2018-04-09Implemented SpeedDialUiItemLoader.calderwoodra
SpeedDialUiItemLoader builds a listenable future for returning a list of SpeedDialUiItems which are the POJO representation of each speed dial list element. Bug: 36841782 Test: SpeedDialContentObserverTest PiperOrigin-RevId: 192186376 Change-Id: I70f3abbeac14117ff4a68355e3a07b395b72386b
2018-04-08Have PhoneLookup read carrier presence data from CP2.linyuh
Bug: 70988687 Test: Cp2DefaultDirectoryPhoneLookupTest, PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 192085574 Change-Id: I4512c9e2e9e14340fa3aa9b2d7d6aaea6344bba6
2018-04-06Update ToS for donationuabdullah
Disambiguates the "this" by adding the reference to settings as required by privacy. Test: N/A PiperOrigin-RevId: 191970994 Change-Id: Idc357e8c908b4f54273bf1b2823a6759ea1332b6
2018-04-06Resolve resource conflicts.linyuh
Bug: 77710848 Test: None PiperOrigin-RevId: 191957734 Change-Id: I0b2674298722a405f4f2e970e877671cff37e60f
2018-04-06Change voicemail empty state icon to voicemail icon.calderwoodra
Bug: 75962146 Test: screenshot PiperOrigin-RevId: 191948101 Change-Id: Icba3cb63cbfe42ce0f193e731dbe2240b3dfc27d
2018-04-06Use sensible audio route for bubble mode.yueg
Bug: 74022483 Test: InCallPresenterTest PiperOrigin-RevId: 191941513 Change-Id: If2090c6dae63981a46586d785e2836edbdf8a729
2018-04-06Convert new speed dial to support fragment and add it to new peer.calderwoodra
Bug: 36841782 Test: MainActivityNewPeerTest PiperOrigin-RevId: 191924314 Change-Id: I5e4a4adadd5477115d6b4daf8afb8c6f819496c8
2018-04-06Only request focus on search edit text when it's slide down.calderwoodra
Bug: 77586391 Test: manual PiperOrigin-RevId: 191924178 Change-Id: I792a6f0308f0dde9b4ae82227aa6a8327208a192
2018-04-06Merge "Reorganized rootcomponentgenerator package and added demo."Treehugger Robot
2018-04-06Reorganized rootcomponentgenerator package and added demo.Zachary Heidepriem
-Moved rootcomponentgenerator/annotations to dialer/inject to reduce the number of deps engineers need to include -Move rootcomponentgenerator/processor into rootcomponentgenerator/ since the other package is now gone -Added inject/demo and tests TEST=unit, tap Test: unit, tap PiperOrigin-RevId: 191916595 Change-Id: Ic155808c7435bdce198970caa92309edb9fadac8
2018-04-06Add tests for RttChatFragment.wangqi
This is to test how the fragment handle messages. Test: RttChatFragmentTest PiperOrigin-RevId: 191912866 Change-Id: Ia50688cdf8eceab376e163aa09bda56406a64933
2018-04-05Exclude Duo audio calls from the new call log.linyuh
Bug: 77496097 Test: SystemCallLogDataSourceTest PiperOrigin-RevId: 191845115 Change-Id: Id0d3770e0cd21383cf2f4c5ae5314ca4de258edd
2018-04-05Implement background calling.yueg
Bug: 74022483 Test: InCallPresenterTest PiperOrigin-RevId: 191825857 Change-Id: I9c70290da32484faf42a2a25fd6b22ba706cb63e
2018-04-05Add Spam#updateSpamSync API to control when syncing the Apdl spam list is ↵maxwelb
enabled Bug: 69072794 Test: Tap PiperOrigin-RevId: 191824966 Change-Id: Ia219074f32f77f308d88e9c29edb1e56c694bcc7
2018-04-05Change @DialerComponent to @IncludeInDialerRoot and turn on ↵weijiaxu
@IncludeInDialerRoot in root component generator. Test: local test. PiperOrigin-RevId: 191820677 Change-Id: I9df15cccf65e8c51c8fadf57eabec4fd41a51007
2018-04-05Add settings fragment boilerplate.erfanian
Bug: 73736474 Test: unit tests PiperOrigin-RevId: 191776448 Change-Id: Idf3eaee2d6639d5a6643c9670230e88d0028bf3c
2018-04-05Fix leak of InCallActivity's DecorView and stuck on disconnection bug.wangqi
This is caused by not dismissing error dialog when recreating InCallActivity. The dialog will be shown again after recreating. Bug: 71376489,77152802 Test: manual PiperOrigin-RevId: 191775030 Change-Id: I07ef5041979c0bbb2d44df9e41b55f0ac41e9339
2018-04-05Expand Duo Interfacetwyen
Added status() and audioCallable() TEST=TAP Bug: 76430187 Test: TAP PiperOrigin-RevId: 191767563 Change-Id: I5852b93bd3042f3c6ed8f2155e57fdefe58edd32
2018-04-05Support new voicemail fragment in old peer.uabdullah
This makes the old peer read the CallLogConfig#isNewVoicemailFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewVoicemail and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog database would be read, which would trigger creation. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the voicemail tab, call log tab and ensuring that they are independent. Bug: 77601968 Test: unit and manual. Some tests are failing, so to ensure we can have the voicemail ready for the bug bash tomorrow, I've ignored them temporarily but will be fixed in a follow up CL (tracked by b/77601893) PiperOrigin-RevId: 191738860 Change-Id: I24ca38b862e98324cf802a3020e7e9df31c0b966
2018-04-04Fix search bar margin issue in RTLtwyen
The RemoveView is pushing it around. Since RemoveView and SearchBarView are mutually exclusive, this CL put them into a FrameLayout to avoid position interference. Bug: 77273749 Test: manual PiperOrigin-RevId: 191678018 Change-Id: If4000f63c77c9da6794193d389f890d21452dcbf
2018-04-04Prevent crash when dialpad animation ends after activity is saved.twyen
Bug: 77484989 Test: TAP PiperOrigin-RevId: 191677909 Change-Id: If49a357a9ba158cd740eb789befd2ff802f670d4
2018-04-04Fixed some issues in dialer's dialpad for talkback users.calderwoodra
- Content description for voicemail button is now "1... double tap and hold to call vociemail" - Content description for 0 button is now "0... double tap and hold for plus symbol" Bug: 19621015,62712616 Test: manual + a11y office hours PiperOrigin-RevId: 191673375 Change-Id: I9b5d8d875f1bf218be6fcc33dff4ac9e479e4f43
2018-04-04Voicemail and Call log notifications now open GoogleMainActivity.calderwoodra
Bug: 75972847,77595270 Test: manual PiperOrigin-RevId: 191672019 Change-Id: I9ea7fb67b4dffeb6acb30840eaf093e4d00a3bcf
2018-04-04Added some logging for mysterious bugs.calderwoodra
Bug: 74196353,77485680,77486095,77540395 Test: tap PiperOrigin-RevId: 191666270 Change-Id: I0423735dde42299bf33ea0b8482c03fd3c2d4675
2018-04-04Remove null check.erfanian
Bug: 77486043 Test: unit tests PiperOrigin-RevId: 191660058 Change-Id: Ia68c8b06e266950cb964a796ea338e4bbc1d6b07
2018-04-04Better support for multi call.erfanian
Bug: 73775453,73775590 Test: unit tests PiperOrigin-RevId: 191657758 Change-Id: If1ae5505185191f04fd57aa828ae5bcc9c21b173
2018-04-04Migrate RTT chat history to use proto buffer.wangqi
This change also moved chat history to be saved in DialerCall, thus it will be persist when switching calls. Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 191626079 Change-Id: I65e9c6ac7aa41beb45dfe561b0a48506ea938e6f
2018-04-04Disable RTT request button when the call is not active yet.wangqi
Bug: 70177426 Test: unit PiperOrigin-RevId: 191612825 Change-Id: I1a72ca86fe9c74fb6420dcfa14f417a8aa6bd5d7
2018-04-04Use the default phone account for a voice call when the call log item is for ↵linyuh
Duo. Bug: 77535982 Test: ModulesTest + Manual PiperOrigin-RevId: 191612821 Change-Id: I417b46ed3ec131bf409c427d82f5b2fa6b791054
2018-04-04Explicitly hide the badge in ContactPhotoView when it shouldn't be shown.linyuh
Bug: 70988682 Test: ContactPhotoViewTest PiperOrigin-RevId: 191600243 Change-Id: I60f979241898f1799a57c2401cbddb8975a9caa7
2018-04-03Remove reference to RTT system setting.wangqi
This should be handled by PhoneAccount.hasCapabilities(PhoneAccount.CAPABILITY_RTT) Test: none PiperOrigin-RevId: 191522319 Change-Id: I28244a725c63fb3b83e97fd9a585473a94da96d9
2018-04-03Fix the button style of RTT request dialog.wangqi
Change to use public android API of button style. Also changed padding left and right to 16dp (up from default 8dp). Bug: 70177426 Test: manual PiperOrigin-RevId: 191505606 Change-Id: Ic984f95843775af3057fb15bf5fe54d3384c478d
2018-04-03Don't deadlock in DialerDatabaseHelper.zachh
The fix is to use FutureSerializer instead of synchronizing on the method. FutureSerializer provides the guarantee that the next AsyncCallable won't even be submitted until the ListenableFuture returned by the previous one completes. Bug: 73877234 Test: added sleep to update task, and verified that resuming activity > 5 times does not deadlock the app PiperOrigin-RevId: 191494662 Change-Id: I5dc2bed7e117fd3ba5a3cd6a8c39c82a565ce070
2018-04-03Fix NPE for details numbermaxwelb
The phone number can be null in the call log (typically for conference calls), but this wasn't handled properly for calls from non-contacts. This CL fixes the issue by instead using the display number. PhoneNumberUtils properly handles null values and can parse the formatted version. Bug: 77486039 Test: manual :/ PiperOrigin-RevId: 191492307 Change-Id: I1be427b3f4ed1381bea3943d130256618f730f5d
2018-04-03Per linguists' request, increase CHAR_LIMIT of "Carrier video" from 30 to 31.linyuh
Bug: 77513242 Test: None PiperOrigin-RevId: 191470111 Change-Id: I0220a342dc1ff04f247ad09dc1fc308f61bbe80c
2018-04-03Fix permissionroldenburg
Bug: 76445204 Test: manual PiperOrigin-RevId: 191470043 Change-Id: I8d57331b2fbeff358535d92852d6bbb2ac677613
2018-04-03Handle missed calls for new call log in old peer.zachh
Test: unit PiperOrigin-RevId: 191380073 Change-Id: If554d5ee0c55754802692a364bae591c3951c060
2018-04-03Separate calls with the video feature from others when coalescing rows in ↵linyuh
the new call log. Test: CoalescerTest PiperOrigin-RevId: 191376690 Change-Id: Id5939175edddd164a1b477319fb20e6d2a9671a9
2018-04-03Support placing Duo calls in the new UI's bottom sheet.linyuh
Bug: 70988685 Test: DuoCallModuleTest, PlaceDuoCallEndToEndTest, Manual testing PiperOrigin-RevId: 191372706 Change-Id: I439be71c361eaca722820b81278e5f95322e100c
2018-04-03Turn off component generating step of RootComponentGenerato and ↵weijiaxu
@DialerCompoennt. Delete related tests. Test: On a local device. PiperOrigin-RevId: 191365675 Change-Id: Ia90463b936f3f07df99909c463b2bdb51223fbe6
2018-04-03Implement dialog for responding RTT request.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 191365412 Change-Id: Ida741a837d6495c0d5f51b748f4d6c09a1beafec
2018-04-02Disable transcrption downloads for T-Mobile.twyen
In this CL, the client will stop treating text/* attachments as transcrptions for T-mobile. Transcriptions are already disabled by the device type sent during provisioning so this will not affect any existing functionality. This prevents other data on the server showing up as transcription. Bug: 77342321 Test: TAP, exact behavior not testable. PiperOrigin-RevId: 191350836 Change-Id: I758996c3fef75ece7cecf0f7a0b4df7ace970d80
2018-04-02Update contact photo for RTT call screen.wangqi
Bug: 70177426 Test: manual PiperOrigin-RevId: 191348602 Change-Id: I332d53ab0c3c628b3dca0c184435bafcf2a13d02
2018-04-02Fix the bug that number format is not correct in RTL mode.wangqi
Bug: 76227259 Test: manual PiperOrigin-RevId: 191347301 Change-Id: I18d63f4e85ca07be00f7564a5ee256d3a6b1b480
2018-03-30Use IS_READ instead of NEW in new call log.zachh
We want to be more consistent with other usages of NEW in the app, i.e. NEW should be used primarily by notifications. Bug: 74821515 Test: unit PiperOrigin-RevId: 191139559 Change-Id: Ib6fbead8b5589aedd881db26a07f7daed4d83543
2018-03-30Add upgrade to RTT call button.wangqi
This button has higher priority over add call button if RTT is enabled. Bug: 67596257 Test: ButtonChooserIntegrationTest PiperOrigin-RevId: 191129313 Change-Id: I5a3302a0970e77a933439749e0e559a691235523
2018-03-30Add SpeedDialEntry database helper.calderwoodra
Bug: 36841782 Test: SpeedDialEntryDatabaseHelperTest PiperOrigin-RevId: 191121137 Change-Id: Iab712d5fac56e515bd4e977282656bf80db4337d
2018-03-30Fix bubble showing after dismiss bug.yueg
Now we also show bubble in onCallListChange(), but we shouldn't show bubble after dismiss in this case. Test: ReturnToCallControllerTest PiperOrigin-RevId: 191101307 Change-Id: I13ff6bf4ae7ab574966c43c0e6fee13853899ba0
2018-03-30Added logging for popping in new call log.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 191099351 Change-Id: I47f1e487e2a0cc23af7b39ae89e20abf993933ea
2018-03-30Move update color code from CallCardPresenter to InCallPresenter.yueg
Bug: 74022483 Test: manual PiperOrigin-RevId: 191098829 Change-Id: I715a97ba48db9a3a81ef7b27750131a3a3a331b7
2018-03-30Log the number of "invalid" CP2 rows.zachh
Also use a flag to control the threshold at which we process invalid numbers. Bug: 70989667 Test: unit PiperOrigin-RevId: 191095892 Change-Id: Idb424831d637ae44e5e5915afaf59c3d534ce4a0
2018-03-30Implement new blockingtwyen
Old blocking is deprecated. Bug: 70989544 Test: TAP PiperOrigin-RevId: 191086875 Change-Id: Icde4963fce603fc4e16e486b78c070bd439e26e4
2018-03-30Differentiate video call types (carrier/Duo) in call descriptions for the ↵linyuh
new UI. Bug: 70988686 Test: CallLogEntryTextTest PiperOrigin-RevId: 191071267 Change-Id: I392e3b4c47e266f0a553fe28079d4800fc174a8f
2018-03-29Use existing transcription from transcription server if availableuabdullah
Repeated requests from the server responds in an ALREADY_EXISTS error and does not transcribe the voicemails. In that case we should ask the server if the request is present already on the server, and if so retrieve it. Bug: 77236260 Test: N/A PiperOrigin-RevId: 191016332 Change-Id: I605c546a3bec3599c7b162853463ca7e46f63886
2018-03-29Update what happens when donation is rejected & use correct donation ↵uabdullah
availability check Checking donation is not a simple config check, but everything that donation availability is dependent on via the isVoicemailDonationAvailable() helper method. We update the code accordingly. When the user declines the promo for donation, we should also update the toggle accordingly. Bug: 74033229 Test: N/A PiperOrigin-RevId: 191011808 Change-Id: I6e4ff9914355deed72175179fc7b9009f2395ef5
2018-03-29UI adjustment to RTT screen.wangqi
1. Don't close overflow menu after menu item is clicked. 2. Add correct shadow and animation to overflow menu. 3. Only scroll when remote message is updated if input box is empty. 4. Only hide keyboard if scrolling up is triggered by user. 5. Add paddingTop to recyclerView so that first message won't be covered by toolbar. Bug: 70177426 Test: manual PiperOrigin-RevId: 191002774 Change-Id: Ic69f80323e3d31d7853d4e8d0c6e4c100fe4a776
2018-03-29Mark spam voicemail as old after we auto block it.Android Dialer
Bug: 77242856 Test: N/A PiperOrigin-RevId: 191002650 Change-Id: Ia74423f28a40f148d507fb9f907fc2e5c41fc183
2018-03-29Fix bug preventing rejecting video callsroldenburg
Bug: 75602772,77235335 Test: ImsVideoTechTest PiperOrigin-RevId: 190988177 Change-Id: I2f4883f6bf492b380ef839562fd65ff6ac630bfb
2018-03-29Fixed a few issues in search with new nav.calderwoodra
- back arrow in search now flips in RTL mode http://screen/1eccBLDqPp0 - search text no longer overlaps icons http://screen/Mq0omQEuZez - keyboard now always closes on pause - location permission is no longer visible in dialpad search Bug: 73088433,74784637,76117373,76440832,76441216 Test: keyboard and rtl tested manually, added test for location permission PiperOrigin-RevId: 190981686 Change-Id: Ia121d410c158df0de9cd731ab280a6d8e9b300d9
2018-03-29Replace png icons with vector drawable for video call screen.wangqi
Bug: 76221932 Test: manual PiperOrigin-RevId: 190948113 Change-Id: I4151ab3fc5231183d49fc1bdc247a09e5ffadc22
2018-03-29Badge contact photos for video calls in the bottom sheet.linyuh
Bug: 70988682 Test: Existing tests PiperOrigin-RevId: 190946639 Change-Id: Iaa8294e8ba6e85ab3c27bb2e67200d7972a240f2
2018-03-28Show toast when handing off from LTE to WiFiroldenburg
Bug: 65490850 Test: manual PiperOrigin-RevId: 190859631 Change-Id: I89aeb41a7709e9366367cdc54ba506e276685b5f
2018-03-28Create a common widget (ContactPhotoView) for a contact photo and its ↵linyuh
optional badge. Bug: 70988682 Test: ContactPhotoViewTest PiperOrigin-RevId: 190855440 Change-Id: Ib658efa6486b66548c710804049517905dc67b13
2018-03-28Remove unnecessary call to StatusBarNotifier.updateNotification().yueg
The call for incoming call is covered in StatusBarNotifier.onStateChange(). The two calls in InCallActivity is not useful (maybe is before notification becoming foreground). Test: manual PiperOrigin-RevId: 190845157 Change-Id: I0f84f15cfda5294566fa8976e09aac5163f85aa9
2018-03-28Update spam blocking promo wordings.Android Dialer
Bug: 75308663 Test: N/A PiperOrigin-RevId: 190825933 Change-Id: Iaf112cfec81c82e127d77aedba351788a03eee54
2018-03-28Replace assets "quantum_ic_videocam_white_24" with a vector asset.linyuh
Test: Existing tests PiperOrigin-RevId: 190820867 Change-Id: I4835bcbc7698075fb54015dccc6823ada4c71651
2018-03-28Delete dialer blocking in NUItwyen
System blocking should be used instead. These code are obsolete. Bug: 70989544 Test: TAP PiperOrigin-RevId: 190818334 Change-Id: I71475905ba110fdc0560991a2a9c2b9e2f2de9f2
2018-03-28Turn transcription on if new user accepts Dialer ToSuabdullah
When a user accepts the Dialer ToS for the first time, we should also enable transcription if it is available. Bug: 74033229 Test: N/A PiperOrigin-RevId: 190794147 Change-Id: I7eb9b3d481426aceb55a8990fdbd246101937e7b
2018-03-28When declining Transcription ToS, we should hide the feature ToS.uabdullah
When a user declines the transcription, we should turn off transcription and never show the transcription promo ever again. Bug: 74033229 Test: N/A PiperOrigin-RevId: 190790323 Change-Id: Ida60592b0550b18b28e7f7a7a22d19100f56231a
2018-03-28Badge contact photos in the new call log for video calls.linyuh
Bug: 70988682 Test: NewCallLogViewHolderTest PiperOrigin-RevId: 190783830 Change-Id: Ib0b1ec23b7c278b83516019924b6c68ff12adaf9
2018-03-27Support new call log fragment in old peer.zachh
This makes the old peer read the CallLogConfig#isNewCallLogFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewCallLog and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog and PhoneLookupHistory databases would be read, which would trigger creation. I don't expect this to be a common case because 1) we hopefully never have to disable the framework and 2) Framework is only updated on Phenotype broadcasts and JobScheduler jobs, which hopefully don't typically happen when user is viewing the call log. However, I still want to make sure that if it happens we don't irreversibly break users when we turn the framework back on. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the call log tab, speed dial tab, and while the activity was paused (pressing Home after viewing call log). Note that this CL doesn't address showing missed calls and badge counts correctly with the new fragment; that will come in a later CL. Bug: 74821995 Test: unit and manual PiperOrigin-RevId: 190706481 Change-Id: I618d9c1649169abd65733502cfebc662a835e787
2018-03-27Use CallLogConfig for enabling new peer.zachh
ConfigProvider should not be used directly for reading NUI flags as CallLogConfig needs to perform work when they change. Bug: 74821995 Test: existing PiperOrigin-RevId: 190698415 Change-Id: Ic084d9032d2a6f35ffba9f395eaaff9053cfa262
2018-03-27Turn on transcription when existing dialer user accepts ToS and ↵uabdullah
transcription is available. Also updated the isVoicemailAvailable helper method, since just checking if the flag and OS is not enough (we have other things such as is VVM enabled, is VM activated), if we don't do this, it doesnt make sense to turn on transcription e.g Why what would happen if transcription is turned on but vvm is disabled Bug: 74033229 Test: Added a todo, will be added later (there are a few more similar CL's that I am sending for other ToS conditions) to ensure the logic is correct for all ToS conditions first and I can add a test right at the end for all conditions. PiperOrigin-RevId: 190696695 Change-Id: I9cb063a97e11943abeb1f823dc661efe88dfa3f1
2018-03-27Turn off transcription when user declines tos (existing dialer user)uabdullah
When an existing dialer user is shown the ToS and they declines it, the transcription setting must be turned off, to respect the users wishes. We also no longer take the user to the settings page. Bug: 74033229,77147114 Test: Unit test PiperOrigin-RevId: 190682249 Change-Id: I8c0abf9f3cbb15ded12a760abe540c557fd2e7d3
2018-03-27Delete debugging logging statement in voicemail spam blockingAndroid Dialer
Test: N/A PiperOrigin-RevId: 190673495 Change-Id: I1587449f6b0b53e7a16aac0b334225649a94f27b
2018-03-27Add permission for in-call visibility changeroldenburg
Bug: 76445204 Test: n/a PiperOrigin-RevId: 190650130 Change-Id: I594a16676cfcca4e6a10c1f5bc6604509417ad23
2018-03-27When transcription setting is enabled, retranscribe voicemailsuabdullah
When transcription toggle is turned off, we delete all local transcriptions. However when it is turned back on, we should re-transcribe all those( previously transcribed, then deleted) voicemails again. Bug: 74033229 Test: N/A PiperOrigin-RevId: 190640972 Change-Id: Iaaf324e74c7630852daeb314f34c2c3095fe3196
2018-03-27Update T-Mo Transcription ToS for existing usersuabdullah
Adds the we can turn off transcription from settings. Bug: 76226374 Test: N/A PiperOrigin-RevId: 190626638 Change-Id: I22b56f133cc83749cdd52a4406be0c36c5a0d0ac
2018-03-27Update T-Mo Transcription ToSuabdullah
Adds the we can turn off transcription from settings. Bug: 76226374 Test: N/A PiperOrigin-RevId: 190623712 Change-Id: Ib2990f9ba025cc5a7f51ba7f7b7d85085327cae9
2018-03-26Remove TODOs left for M in the new call log as the min SDK has been bumped to N.linyuh
Bug: 72125574 Test: None. PiperOrigin-RevId: 190572832 Change-Id: I581d3c9e366a1190c1608b369700aeb511fe51d1