summaryrefslogtreecommitdiff
path: root/java
AgeCommit message (Collapse)Author
2018-03-16Refactor VM Settings and add support for voicemail transcriptionuabdullah
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following: - ensuring that when the VVM toggle is turned off, transcription and donations are gone. - when transcription is off, donation preference is gone. - donation is only available when transcription is available and enabled - as part of the refactor, fixes existing logging bugs - breaks preferences and its associated methods into helper methods when possible - groups relevant preferences together when possible Bug: 74033229 Test: Unit tests PiperOrigin-RevId: 189418217 Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
2018-03-16Use single return to break bubble of RTT chat.wangqi
Also change "done" button to "send" in input box and disallow multiple line since return will be interpreted as "send". Bug: 67596257 Test: manual PiperOrigin-RevId: 189409725 Change-Id: I3d3bf3e11cd04d6689125399f4567e88ee3f28f0
2018-03-16Make MainActivity the default activity for AOSP.calderwoodra
This also finishes moving all of the old tests over from Dialtacts to Main. The only 2 tests that fail are: - searchBoxClosedWhenHandlingNotificationIntent - openSearchFragment_fabGoneInRegularSearchAfterRotation I will fix these in a follow up CL. Bug: 72525887 Test: dialer_aosp build target launches MainActivity, TAP PiperOrigin-RevId: 189408987 Change-Id: Ice30191d95c19c62bcd89503e89f66440f30beac
2018-03-16Remove contact id from all non-local directory contacts.calderwoodra
Bug: 72755010 Test: manaul PiperOrigin-RevId: 189408046 Change-Id: Ia23442b2243e2008042e0046a21f840a30dbf008
2018-03-16Use current county ISO for PhoneLookupHistoryRecordertwyen
Previously it is unclear what the "county ISO" should be so the originating county of the SIM is used. When telecom writes to the call log the county the user is in is used. This caused the DialerPhoneNumber key in in call UI and call log to differ and info to be lost. In this CL, the current country is used in PhoneLookupHistoryRecorder to make it consistent with the call log. PhoneLookupHistoryRecorder is currently the only consumer for telecom call util.getCountryCode(). Additionally, dialer/location no longer depends on dialer/util. dialer/util has too many unnecessary dependencies that will cause cycles. Bug: 73752730 Test: Unit tests PiperOrigin-RevId: 189378542 Change-Id: I59773f7745c835a6523efda951c475e2fde9aaf9
2018-03-16Add Cequint contact lookup result type.wangqi
Bug: 73741286 Test: none PiperOrigin-RevId: 189377028 Change-Id: Ifb9c6375d0026fb012ae868741b471f2ca02c5f9
2018-03-16Work contacts quick contact badge no longer crashes.calderwoodra
Apperently contact ids are invalid for work contacts, so the URI needs to exclude them. Bug: 72755010 Test: manual PiperOrigin-RevId: 189374262 Change-Id: Ibeaa555dc035e14ea67905c342369188ecfd1832
2018-03-16Check if dialpad is already open when handleing new intents.calderwoodra
If the user had the dialpad open when they received a call, they could potentially crash dialer if they pressed add call or clicked on a phone number in another app. Bug: 74711879 Test: manual PiperOrigin-RevId: 189371425 Change-Id: I14df55e2467be07dd30e3971004e601216f57daf
2018-03-16Use a vector "unblock" icon in the bottom sheetlinyuh
Bug: 73133096 Test: ModulesTest PiperOrigin-RevId: 189303135 Change-Id: Id92d65e4c0bbb3c325c9d89d41d0645df19cde06
2018-03-15Restore delete call log item logging in call details.calderwoodra
This was accidentally removed in cl/176677167. This change restores the logging in call details and also adds it to the call log menu. Bug: 73774284 Test: OldCallDetailsActivityIntegrationTest, CallLogActivityIntegrationTest PiperOrigin-RevId: 189279107 Change-Id: Iadda16d7f1e4d720f828b5a72f210bcb8029f939
2018-03-15Close keyboard when placing a call to nearby places and remote contacts.calderwoodra
Bug: 74784637 Test: manual PiperOrigin-RevId: 189276349 Change-Id: I27b0f911ab5165f902bef017e8c09276441a9dee
2018-03-15Adjust bottom nav margins, sizes, ect.calderwoodra
Test: n/a PiperOrigin-RevId: 189274795 Change-Id: I495e326ce74568d8add739275562284ef12e276f
2018-03-15Resolve all build resource conflicts.calderwoodra
For simplicity, instead of resolve the nui shortcut string, I deleted it since it isn't used anymore. Test: build log PiperOrigin-RevId: 189260472 Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
2018-03-15Add utility used to style content with learn more linksmaxwelb
Bug: 74017355 Test: ContentWithLearnMoreSpannerTest PiperOrigin-RevId: 189252365 Change-Id: I3464fb56b86a6b3ddd25e9eed14152eaeed9925c
2018-03-15Remove deprecated android.graphics.Canvas APIsAndroid Dialer
Bug: 73777445 Test: TAP PiperOrigin-RevId: 189225531 Change-Id: I806be1c2a05d842b4991a9c95c19238f999d814d
2018-03-15Fix bubble not showing on device restart.yueg
Test: ReturnToCallControllerTest PiperOrigin-RevId: 189225436 Change-Id: I845855d0b66941e311f3db239d10249015473c65
2018-03-15Add Brazil to the set of countries we do not format phone numbersroldenburg
Test: existing test (MotorolaUtils) PiperOrigin-RevId: 189225421 Change-Id: Id15181746cd087c82bc0b97262b03c76bc571b3f
2018-03-15Register ShowBlockReportSpamDialogReceiver in MainActivity.linyuh
Bug: 73830902 Test: Manual PiperOrigin-RevId: 189222303 Change-Id: I0397986d784d28e7948b39778319e3936f6c55e9
2018-03-15Fix but that avatar overlapping with status bar.wangqi
This happens when outgoing video call is accepted as voice call or switching between video call and voice call. Bug: 71590134 Test: manual PiperOrigin-RevId: 189206585 Change-Id: I564c261614990b9b6baab6025f1625f42058ba70
2018-03-15Add audio select menu.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 189204691 Change-Id: I9ecd36ce1c27072dea4ae87beeecd4565bf05378
2018-03-15Introduce GlidePhotoManager to CallDetailsActivitylinyuh
Bug: 74202944 Test: ModulesTest, CallDetailsActivityTest PiperOrigin-RevId: 189204143 Change-Id: I917bac76009522c6a99fdb63299556ec2a454dfa
2018-03-14Added CallLogConfig.zachh
This class is responsible for enabling or disabling the call log framework when flags change. Bug: 74821995 Test: unit PiperOrigin-RevId: 189143911 Change-Id: I4727645ce621fbc01acbcd0acab523fe955d4075
2018-03-14Split CallDetailsActivitylinyuh
Bug: 74202944 Test: Existing tests PiperOrigin-RevId: 189095432 Change-Id: I13015ee6c5767edd95b78c3fb2e7338495e9e1d7
2018-03-14Add swap call button to RTT call.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 189064976 Change-Id: I3265881114baceb4d63fcc3d55d1c904cd3216dc
2018-03-13Fixed overlapping fragments issue.calderwoodra
Fast consercutive calls to #showFragment can have undesirable effects because fragment manager doesn't handle transactions sychronously. This CL resolves one of the scanrios where voicemail fetch status was calling #showFragment nearly simulataniously to the #onHandleIntent call. This issue may show itself again and I'm looking into more long term solutions but we should be fine in the short term since the all of our fragment logic is implemented. Bug: 74051208,74621909 Test: manual PiperOrigin-RevId: 188956984 Change-Id: I0796e31b03e0b749ae7e81f82859ea6f814a5fb5
2018-03-13Fix full screen issue when switching between RTT and voice call.wangqi
Incall and answer screen is using transparent status and navigation bar, while RTT screen is using customized color. Switch between them require correct setting of system UI. Bug: 67596257 Test: manually test to make RTT call and voice call, then switch between them. PiperOrigin-RevId: 188956868 Change-Id: I3c17ff453be943f0b2ad28fe5cae434453fbe326
2018-03-13Add impression for spam blocking setting interaction.Android Dialer
Test: N/A PiperOrigin-RevId: 188953886 Change-Id: I3279efe088e8a37df79d635bd44c6fa831109f2e
2018-03-13Removed references to MainActivity since they weren't necessary.calderwoodra
Test: existing PiperOrigin-RevId: 188928916 Change-Id: I2b6fb73545194fa175526a77ce2a76b1d23c049d
2018-03-13Sanitize inputs for PreferredSimFallbackProvider.query()twyen
SQLiteQueryBuilder.query() is used in strict mode with a projection map. Bug: 74601176 Test: Unit tests PiperOrigin-RevId: 188907943 Change-Id: I2f34e185ad175695d941697cd0dbdc8ad6172321
2018-03-13Add 6dp spacing between transcription and secondary text for nui vmuabdullah
Add 6dp of spacing between transcription and the secondary text. Bug: 69963448 Test: N/A PiperOrigin-RevId: 188902056 Change-Id: Iba1c9c110bd238842567e7b1b36a757d388cea2d
2018-03-13Make NUI VM Background Whiteuabdullah
Makes the views where the voicemails are displayed and the empty view white. Bug: 74402112 Test: N/A PiperOrigin-RevId: 188901487 Change-Id: I55a12dd067e66cc0f4efca3eb79b5a8f9e761082
2018-03-13Fix RTL label alignment in select SIM dialogtwyen
The default text alignment of a TextView is based on the content of the view (does it has any RTL characters or not). Previously the TextView width is match parent so the text will either align to the left or right depending on the content (the label is user content which we don't control). In this CL it is changed to wrap content so the whole text will align to the parent's gravity which is "start". Bug: 74421655 Test: N/A PiperOrigin-RevId: 188899698 Change-Id: Id754ed97bb6d3b6bba05d0a96c83623daca01cc8
2018-03-12Don't fetch calls if the parent doesn't exist.calderwoodra
This CL is a continuation of cl/187700318. In that CL, we were able to unregister the call log's content observer and prevent this crash, but it's reshowing itself in voicemail now. Since the voicemail's observer is registered in the adapter and is unaware of lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll just check that the parent isn't null. Bug: 73972084 Test: n/a PiperOrigin-RevId: 188812159 Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f
2018-03-12Keyboard and search now close when appropriate.calderwoodra
Keyboard should close when: - requeting permission - placing a call - leaving the app Search should close when: - placing a call - leaving the app Bug: 74235853 Test: search closing onPause tests already exist (MainActivityOldPeerSearchIntegrationTest#placingCallFromSearchClosesSearch) PiperOrigin-RevId: 188812026 Change-Id: Iaee084c59b4c514d10375deff5d73d5a456ef9df
2018-03-12Use config provider for OEM MMI codestwyen
Previously the OEM MMI codes are hardcoded and inadvertently affected other devices. In this CL it is read from the config provider instead. The config provider is expected to provide values based on the OEM. Bug: 72162360,74016291 Test: SpecialCharSequenceMgrTest PiperOrigin-RevId: 188786408 Change-Id: Ie70e49a8a9d2ced5da9cf502c020477615bbe8a2
2018-03-12Use white background in new call log.zachh
Bug: 74402112 Test: none PiperOrigin-RevId: 188782198 Change-Id: I36c2adcd8f0403c88694343cbbf12e9aba229afb
2018-03-12Make VVM Transcription Promo padding 4dp instead of 10dpuabdullah
Decrease the padding from 10dp to 4dp for bottom and top Bug: 68727352 Test: N/A PiperOrigin-RevId: 188776245 Change-Id: I7ced053a5989e15e84fad6a264683a5c8e5d9339
2018-03-12Generate default lookup URI for quick contact badge if lookup URI is not ↵twyen
available. Bug: 70989591 Test: GlidePhotoManagerImplTest PiperOrigin-RevId: 188758361 Change-Id: I038b5618a0005159ebae28e4b95ef5a4d388e2be
2018-03-12Make NUI VM avatar and icon consistent with nui call loguabdullah
Makes the avatar and more icon the same as the nui call log. Bug: 69963448 Test: N/A PiperOrigin-RevId: 188756733 Change-Id: I93303a2a872ac156470d223d6fb4fd2959766adc
2018-03-12Move HIDE_VOICEMAIL_SETTINGS_MENU out of voicemail/impltwyen
The metadata belongs with the voicemail settings menu, which is moved into dialer a while ago. Not moving the metadata causes build variants without VVM to have duplicated voicemail settings in telephony and dialer. Also removed the redundant metadata in incall ui manifest. Bug: 73096806 Test: manual PiperOrigin-RevId: 188756468 Change-Id: I00174f84024c5b9ab809d99e40a55d22a07bd063
2018-03-09Remove bubble "new" prefix.yueg
Test: BubbleImplTest, BubbleImplIntegrationTest, ReturnToCallControllerTest, ReturnToCallActionReceiverTest, BottomActionViewControllerTest, ChangeOnScreenBoundsTest PiperOrigin-RevId: 188558386 Change-Id: Ieab3ee3f148092312a50597b41c0975419756e23
2018-03-09Dismiss keyboard when opening overflow menu in RTT call.wangqi
This is to prevent dialpad showing with keyboard open. The alternative way to dismiss keyboard after dialpad shows up doesn't work. Bug: 67596257 Test: manual PiperOrigin-RevId: 188556453 Change-Id: I4b917d8ac83246d2002641ae7759261699149c65
2018-03-09Implement redlines for NUI VM Tabuabdullah
Makes the redlines similar to what we have for the call log nui. The values are structured and copied as much as possible from /calllog/ui/res/layout/new_call_log_*.xml Things to note for: -Today/Older header the same as call log -More items all the way to the right -Padding in voicemail icon gone -Removed padding between each recycler view item Bug: 69963448 Test: N/A PiperOrigin-RevId: 188547442 Change-Id: I515d75e392591243510634c3fabe444a7ba10d7f
2018-03-09Add spam blocking setting in spam module.Android Dialer
Test: InAppSpamTest,ApdlSpamTest,VisualVoicemailUpdateTaskTest PiperOrigin-RevId: 188509191 Change-Id: I8b9c07dcc1c7b3b80ffc914ec99f4e6d80d50985
2018-03-09Save RTT chat history during the call.wangqi
Thus putting call into background won't lose the history. This is only stored in memory by making RttChatMessage Parcelable and saved along with fragment's life cycle. Bug: 67596257 Test: manual PiperOrigin-RevId: 188500104 Change-Id: I11e8e55f0475defd9c3b9a8cc10db4186392ddd8
2018-03-08Implement non-ui logic for delete/undo delete voicemailsuabdullah
When a voicemail is deleted we have to allow the user the option of cancelling the deleting of voicemail. This is done by showing the user a snack bar which when a user taps will prevent the voicemail from being deleted. This CL only adds the underlying logic for the delete/undelete to take place via a ScheduledFuture, it does not fix all the UI issues that come with it, which will be sent in a follow up CL, issues such as: -Updating the group label when a delete/undo happens -Updating the entries above and below when a delete/undo happens -Showing the empty view immediately when a user deletes a single voicemail -Removing the empty view immediately when a user taps undo -Updating tests Bug: 69858266 Test: Manual PiperOrigin-RevId: 188424489 Change-Id: Iecf5cb7be5b80fa5e91acaad3a7cc4a6c8702521
2018-03-08Add support of dialpad in RTT call.wangqi
This change also dismiss overflow menu when any button is clicked inside it. Bug: 67596257 Test: manual PiperOrigin-RevId: 188424236 Change-Id: I90b803d592f12525cdb8727aaeebc45c3da5dcdd
2018-03-08Add flag for filtering emergency calls from call logmaxwelb
Bug: 73368638 Test: CallLogAdapterTest PiperOrigin-RevId: 188414469 Change-Id: I7d7522c841a6b4054e2e387346973c597174ee87
2018-03-08Bring back new navigation screen event logging.yueg
Test: MainActivityOldPeerTest PiperOrigin-RevId: 188409482 Change-Id: I0c132c49d63b9af849522851c55f51d431faa603
2018-03-08Show bubble when call connected and in-call UI not showing.yueg
We used to only show bubble when leaving in-call UI, so answering from Bluetooth does not show bubble. Fix it by also showing bubble in onCallListChanged(). Test: NewReturnToCallControllerTest PiperOrigin-RevId: 188403460 Change-Id: I5e6a3c37b2773e426dcc73ae5661b9e145b20cb8
2018-03-08Add divider line to nui voicemail alertuabdullah
Adds a divider line to differentiate the voicemail entries and the alerts. Bug: 73158572 Test: N/A PiperOrigin-RevId: 188389442 Change-Id: I33bd32fc310cdf52f20bcb2d0b2cd4266420cab6
2018-03-08Optimize characters sent to remote party for RTT chat.wangqi
Instead of using things provided by Android of onTextChanged, we compare the text in EditText with the text in bubble before the change and compute the delta string need to send to remote party. This way we could minimize characters sent thus reduce latency. Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 188389325 Change-Id: I3023b484c32b2369ca8720104da74cf6906bb46e
2018-03-08Refactor array of RttChatMessage to List.wangqi
Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 188373256 Change-Id: I0f0798a5310225456619757dcca5bbd5df372b91
2018-03-08Disable phone number formatting for Argentina only (MCC = 722).linyuh
Bug: 73718977 Test: Existing tests PiperOrigin-RevId: 188359859 Change-Id: I513e1111b643d6fa476d1e56b60c0d6e61e131f4
2018-03-08Implement logic for unblocking a number from the new call log's bottom sheet.linyuh
Bug: 70989547 Test: ShowBlockReportSpamDialogNotifierEndToEndTest PiperOrigin-RevId: 188357953 Change-Id: Ie1b1f439f043805892876790d7590a4c721dbf8c
2018-03-08Implement logic for blocking a number from the new call log's bottom sheet.linyuh
Bug: 70989547 Test: ShowBlockReportSpamDialogNotifierEndToEndTest PiperOrigin-RevId: 188351591 Change-Id: I634fb821592bdc890df291fdf83cdf307c94ffa9
2018-03-07Support local emergency phone number check when there are multiple SIMs.linyuh
Bug: 73994020 Test: PhoneNumberHelperTest PiperOrigin-RevId: 188260007 Change-Id: I23025e9b9454f487117c35e7a3b09307371ae825
2018-03-07Add additional logging to missed call notification code pathroldenburg
Bug: 73877234 Test: just logging PiperOrigin-RevId: 188256051 Change-Id: Ic9486b3fc1d97338cb016b86a243612baa6282fe
2018-03-07Fix view not attached to window manager crash and add logs.yueg
Test: none PiperOrigin-RevId: 188244536 Change-Id: I7d41adaf600ba7829054ab8af6b4d30fd0873c3b
2018-03-07Combine fragment hide/show transactions into one transaction.roldenburg
My hypothesis is that trying to commit multiple seperate transactions back to back causes the fragment container to get into a weird state. So this change has two parts: - Disable preloading call log - Combine the seperate hide/show transactions into one transaction - Don't call conflicting transactions (i.e. hide then immediately show) Bug: 74051208 Test: existing tests, manual PiperOrigin-RevId: 188215791 Change-Id: I699fc02f1e2716bc019a29dc047ee4bc0d52df35
2018-03-07Handle preferred SIM for ACTION_CALLtwyen
Previously preferred SIM is handled only by precall, which covers dialing with dialer or with the special receiver contacts uses. If a third party app uses ACTION_CALL or telecomManager.placeCall(), then the in call UI will be launched directly and the old account selection dialog will be used without preferred SIM support. In this CL logic from CallingAccountSelector is refactored out so InCallActivity can use it for the dialog. Bug: 73718976 Test: Unit tests, In call UI not covered. PiperOrigin-RevId: 188214007 Change-Id: Ifaacf982a3e98601dc362b649c3501d4ee96e63e
2018-03-06Show a warning dialog about charges when user starts a video callwangqi
The user starts a video call a warning dialog shall be presented. If the user presses "OK" with the "Do not show again" box selected, the dialog shall not be presented anymore. Test: manual - Verified that a warning dialog about charges is shown when a video call is started if KEY_SHOW_VIDEO_CALL_CHARGES_ALERT_DIALOG_BOOL is true. This is an upstream change from: https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/518977/8 Bug: 67832837 Test: partner manual test PiperOrigin-RevId: 188103414 Change-Id: I62628a32557297acaef096db90d2ddf049ef5017
2018-03-06NUI loggingyueg
- Add screen events for 4 tabs, dialpad and search. - Add impressions for opening MainActivity with tabs/dialpad (non user tab selection). - Add impression for VVM visible. Bug: 72525843 Test: MainActivityOldPeerTest, MainSearchControllerTest PiperOrigin-RevId: 188090249 Change-Id: Ifdf3519f07d7230f20b5d82691a96747b1944d63
2018-03-06Make user able to set default sim when there is no account.yueg
Test: CallingAccountSelectorTest, manual PiperOrigin-RevId: 188089149 Change-Id: Id1be88124e243e46ac9b0277f40de142af6bb5a9
2018-03-06Covnert @AutoValue PhotoInfo into a proto.linyuh
Bug: 74202944 Test: Existing tests PiperOrigin-RevId: 188060790 Change-Id: I4d79a353abf767935383d4149f261f5e96fd7acb
2018-03-06Updating voicemail_donation_promo_content per UXWmaxwelb
Bug: 73798533 Test: N/A PiperOrigin-RevId: 188046222 Change-Id: I1b66afa787bb5c91d71dbeda544218226ae8f5fd
2018-03-05Add support for bluetooth etc. audio route for RTT call.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187944752 Change-Id: I2bbe45d2bda22bb000239f8613576fffb9f6ab28
2018-03-05Disable phone number formatting for LATAM MCCs.linyuh
Bug: 73718977 Test: MotorolaUtilsTest & PhoneNumberHelperTest PiperOrigin-RevId: 187889473 Change-Id: I00d58071ba18ddce5a09c07de9edd2d0956d6478
2018-03-05Check if the activity is still alive before refreshing unread tab counts.calderwoodra
My hypothesis is that there is a race condition where the call log changes and we are leaving the activity before the content observer is unregistered or the loader it starts is finished. This results in a callback calling #fetchCalls while Dialer is in the background, resulting in a crash. This change will confirm my hypothesis. Even if my hypothesis is incorrect, we have similar checks throughout this class which indicates to me that some issue exists here and that this check is safe to do. Bug: 73972084 Test: n/a PiperOrigin-RevId: 187700318 Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
2018-03-02Added impression logging for AnnotatedCallLog rebuild operations.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 187694255 Change-Id: Ie6ec70a70a4c59cbdfe25c34003d21fa2f751564
2018-03-02Added timing to some more AnnotatedCallLog operations.zachh
This includes: 1) Made RefreshAnnotatedCallLogWorker.refresh() methods return a result which is "not dirty", "dirty but no changes needed" or "dirty and changes need". It will be interesting to see how often these cases occur (will log impressions in a future CL) so I thought we might as well log the latency of each case separately as well. 2) To support 1) added a new method to FutureTimer which allows you to compute the event name from the result of the timed Future. Also needed to update the Metrics interface to support deferring the event name when starting a timer via a generic token. 3) Timing the coalesce operation which is very heavyweight. 4) Made StubMetrics do some logcat logging to easily observe timing information using AOSP Bug: 70989667 Test: unit PiperOrigin-RevId: 187691203 Change-Id: I5f19a2fc94d86639486299b65b0edd66eeaab52e
2018-03-02Move assisted dialing out of P.erfanian
Bug: 73727182 Test: tested PiperOrigin-RevId: 187673539 Change-Id: I9c790e912990fb8dc46da1c1057339c979ac9501
2018-03-02Remove voicemail instruction textmaxwelb
Bug: 74028377 Test: Manual :/ PiperOrigin-RevId: 187634587 Change-Id: I51be6c151db37988bd68558a6af8c2bab31939a1
2018-03-02Update fragment class.erfanian
Bug: 73775453 Test: unit tests. PiperOrigin-RevId: 187630263 Change-Id: Ib8e1b852b4ab4ca6614182db0cb72e413c1612eb
2018-03-02Add ripple effect to RTT incall buttons.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187564625 Change-Id: I7e848e975bbab19e605d09283dee24eeb02550f1
2018-03-02Remove dialer sounds and vibrations settings fragments and redirect to the ↵uabdullah
system sound settings fragment instead. There is no need for dialer to have it's own sounds and vibrations fragment. Instead of maintaining two separate fragments that do that same thing (and have to be kept in sync), we can just have one source of truth and have users modify those settings. Thus we have removed the dialer and vibrations settings fragment and have it instead re-direct to the system sound settings. The automatic advantage of this is also that for dual sim cases, dialer settings don't need to be updated. Bug: 73750524 Test: Manual. Navigated to the dialer sound and settings fragment, and it opened the system settings. Also pressing back took us back to Dialer as expected. PiperOrigin-RevId: 187564461 Change-Id: I7d620721237f1c932ed8cea949486ae7dbdefba1
2018-03-01Use voicemail image for empty voicemail tab and update coloruabdullah
This CL updates the icon for the empty voicemail tab and updates the tint of it as well. It also updates the size of the voicemail icon when in landscape mode. Bug: 25661977,74085541 Test: N/A PiperOrigin-RevId: 187557890 Change-Id: Ic19643f4e63e3ce70ba6b029ce45a570404f28e7
2018-03-01Implemented DialerFloatingActionButtoncalderwoodra
Implemented wrapper class for FloatingActionButton to resolve some of FloatingActinButton's many issues. One of which is alllowing clicks while animating that was causing a crash in NUI. This change also fixes an issue with the dialpad exit animation. Bug: 73995512 Test: Robolectric and Espresso don't support these kinds of tests very well PiperOrigin-RevId: 187556390 Change-Id: I4cb7c2346a0ef09f2f3d8b48e7e14d01460cd1a7
2018-03-01Instead of just cancelling loaders, reset them as well.calderwoodra
Bug: 71385186 Test: manual PiperOrigin-RevId: 187552834 Change-Id: If4e1f7c18d5f5aae2a152762189948c3543ba321
2018-03-01Update RTT icon on ringing screen.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187551861 Change-Id: I38facbaaa48ba4afe29e382de9c8241d8936c3ab
2018-03-01Disable phone number formatting for devices with Argentinian SIMs.linyuh
Bug: 73718977 Test: PhoneNumberHelperTest PiperOrigin-RevId: 187540382 Change-Id: I814ec62b2215c24b8cde3442c5dc83d98ad87164
2018-03-01Implement overflow menu for RTT call.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187529383 Change-Id: I6ef6593a79ef0c4fb407284eede966a1eaabcd1e
2018-03-01Rename NUI logging prefix from NUI_ to MAIN_yueg
Bug: 72525843 Test: none PiperOrigin-RevId: 187500135 Change-Id: Iaa73b9355a6b5c299f73fd113eb1f74a3eb47dd4
2018-03-01Updating SecondaryInfo value class to use AutoValue with builder pattern.Android Dialer
Test: CallCardPresenterTest,SecondaryInfoTest PiperOrigin-RevId: 187481728 Change-Id: I3d2b23b5d51ea1e5ff30b8f6b6570d76c006fe86
2018-03-01Added same primes metrics that existed in Dialtacts to NUI.calderwoodra
Test: n/a PiperOrigin-RevId: 187442952 Change-Id: I9463e2c976102276ebc5886531397ad0cf160b78
2018-02-28Preload call log fragment on app start.calderwoodra
Default is set to true but if we see issues with startup latency we can disable this server side. Test: n/a PiperOrigin-RevId: 187419851 Change-Id: I6d1debfed86dbcaf3ee73ec0906e514a2687e2c0
2018-02-28Some small bug fixes in NUI.calderwoodra
- Never show the dialpad chooser in MainActivity. - If the call log changed while dialer was in the background, it would trigger the content observer to fetch the new info, which would request it's parent that wasn't there. Now we register/unregister them in onResume/onPause. This is safe to do because we force refresh the data onResume anyways, so any changes will still be shown. Bug: 73972084,73975555,73995512 Test: manual PiperOrigin-RevId: 187407058 Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030
2018-02-28Log contact source when reporting spam from the new UI.linyuh
Bug: 73780748 Test: PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 187404074 Change-Id: I1db81304909fbf63aba00088c12e18922042c3b1
2018-02-28Add accessibility label for voicemail transcription ratingmaxwelb
Bug: 73788896 Test: Manual :/ PiperOrigin-RevId: 187401558 Change-Id: I1c2c08cc01fd38ad5820c454991473cfb8f0fc76
2018-02-28Parity of OldMainActivityPeer with ListsFragment for VMuabdullah
This CL helps to ensure that when the VVM settings toggle is turned on or off, or a sim is swapped, inserted or removed the VM tab disappears and appears, just like it currently does. When a VM tab disappears we also move to the speed dial index. Bug: 73123614,73998717 Test: N/A PiperOrigin-RevId: 187400703 Change-Id: I76a0b43da86713caa67956413a39299c7ecbc8d1
2018-02-28Show empty view when there are no voicemailsuabdullah
When there are no voicemails to be shown, we show an empty view. This is done by hiding the recycler view and showing the empty view. Similarly when a voicemail is present, we hide the empty view and then show the recycler view. Bug: 25661977 Test: Unit Tests PiperOrigin-RevId: 187396952 Change-Id: Ifa718fb05c1be37aabdf4c91bc2c1653357565b2
2018-02-28Never start playing voicemails in the NUI VM tab from the speakeruabdullah
All voicemails played from the VM tab should always be played from the non-speaker mode. Bug: 71500892 Test: N/A PiperOrigin-RevId: 187388964 Change-Id: I3f6a5887784b0192074157cfd8a91727d124ed06
2018-02-28Remove background of RTT chat fragment.wangqi
The default incall gradiant background will be shown instead. Bug: 67596257 Test: manual PiperOrigin-RevId: 187384455 Change-Id: Icf91804d78aa98d051248a9eca0d13be0ea880f0
2018-02-28Update voicemail donations stringsmaxwelb
Bug: 73798533 Test: Manual :/ PiperOrigin-RevId: 187383740 Change-Id: I0f35ccbf19a59b35338cb144f0192b692585159f
2018-02-28Group info needed to show a block/report spam dialog into a proto to avoid ↵linyuh
long method signatures. Test: Existing tests PiperOrigin-RevId: 187338094 Change-Id: I0d7a5206d127931d322b5604b2bb81f5202b8de8
2018-02-27set connection state after adding NonSimulatorConnectionListener and set ↵weijiaxu
connection to active at the end. This is necessary to make sure that NonSimulatorConnectionListener gets event callback when Connection.setDialing() or Connection.setActive() is called. Test: On a local device. PiperOrigin-RevId: 187266120 Change-Id: I6ee5d5113285e7a27a4e8497a95b28844ac6b397
2018-02-27Do not show the voicemail tab if the VM toggle is turned off.uabdullah
Bug: 73123614 Test: N/A PiperOrigin-RevId: 187255950 Change-Id: I9ab50a7a8052f325f1743721bf6432e6c4787a4e
2018-02-27Internal cleanup for the new UI's bottom sheet.linyuh
Test: Existing tests PiperOrigin-RevId: 187254014 Change-Id: I8a57b632d45e87ad075eb8bbb25180858e890f08
2018-02-27Fab now hides/shows correctly when you enter and leave the voicemail tab.calderwoodra
Test: manual, going between tabs hides/shows the fab properly when ToS is (in)visible. PiperOrigin-RevId: 187253210 Change-Id: Ied9ea44892786268b9dfa68816840dfbfc74aa6e
2018-02-27Fixed some a11y issues in MainActivity.calderwoodra
- main fragments are no longer detected by talkback while search is open. - FAB now has a content description Bug: 73587831,73891132 Test: tap PiperOrigin-RevId: 187248081 Change-Id: I5a8fe2df23542d19c935cba77d1337ec753064af