summaryrefslogtreecommitdiff
path: root/java
AgeCommit message (Collapse)Author
2018-01-24Add skeleton for SpamPhoneLookuplinyuh
Bug: 70989534 Test: SpamPhoneLookupTest PiperOrigin-RevId: 183174131 Change-Id: I46e819a0710ccce293195594e2f249e91d74551a
2018-01-24Show Icon and label for blocked numberstwyen
CallLogPhoto.getPhotoUri() returns a URI to a drawable so it will be easier to transition into glide. Meanwhile ContactPhotoManager will just show the drawable directly. Bug: 70989547 Test: Unit tests PiperOrigin-RevId: 183163818 Change-Id: I4ee4ff98782e35d2be03dfe14f8bf3dfd6ded074
2018-01-24Bubble v2 a11y.yueg
- Set checkable for bubble buttons so the check status of non checkable button (back to call, end call) is not read. - Add support for bottom action buttons. Test: manual PiperOrigin-RevId: 183150371 Change-Id: Ifae9c912ec923e8d2cda3146413138bd2eb94b47
2018-01-24Add flag to enable NUI shortcut.calderwoodra
Bug: 64655802 Test: n/a PiperOrigin-RevId: 183149638 Change-Id: Idc58efced8f70311eccd67f403bc5bd98f3f8518
2018-01-24Rename "ApdlInfo" as "SpamInfo" in proto PhoneLookupInfo.linyuh
Bug: 70989534 Test: Existing tests PiperOrigin-RevId: 183145910 Change-Id: I60b0122fb236a7e7ee7b746867c40fefe0a3b487
2018-01-24Add support for forwarding more special codesroldenburg
Bug: 72162360 Test: SpecialCharSequenceMgrTest, manual PiperOrigin-RevId: 183138805 Change-Id: I57903a6b3bc30243e4f225d758d1ace550e8ab99
2018-01-24Define methods in Spam interface to be used later in the PhoneLookup for ↵linyuh
spam features. Bug: 70989534 Test: ApdlSpamTest, InAppSpamTest PiperOrigin-RevId: 183138320 Change-Id: I647568c31e234995f44d6cbeb2f97f73952db6bb
2018-01-24Link to the correct Assisted Dialing settings depending on platform version.erfanian
Bug: 72162646 Test: unit tests PiperOrigin-RevId: 183134859 Change-Id: I73d3349f0ff33188cfe0a121b7737a57155683c7
2018-01-24Add foreground service permissionroldenburg
Bug: 72116995 Test: built APK, verified permission PiperOrigin-RevId: 183126225 Change-Id: I0889ea619a21413e510a7b58143c5011ed81b688
2018-01-24Fixed a regression where we incorrectly reported that the dialpad was visible.calderwoodra
A request was made to update the value of #isDialpadVisible, in the process a regression was introduced that would cause #isDialpadVisible to return true when the dialpad's root view was null. This caused a NPE when we tried to animate it. We should now return the correct value in the scenarios important to our partners as well our users and animations. Bug: 64657832,72384544 Test: manual/logging PiperOrigin-RevId: 183122628 Change-Id: I981e944dbb003064163b8ec11883dbc5381cba0e
2018-01-24Add support for yesterday header in NUI Voicemail Tabuabdullah
Currently NUI only supports today and older, however we also need to support yesterday and be consistent with the call log. Bug: 69858354,72331988 Test: Unit Tests PiperOrigin-RevId: 183121631 Change-Id: Ica75164c28ee60a2f776287eefd7eed5db08e035
2018-01-23Updated nearby places search permission icon for Material.calderwoodra
Bug: 68272797 Test: manual PiperOrigin-RevId: 183023158 Change-Id: Iccee9278a89c944c443cb0d4022554ce7f634bab
2018-01-23Updated call number by NW is not displayedwangqi
CallCardPresenter updates a call number if the number is updated by NW. But the logic is worng. The comparing numbers are always same. Because it compares with the same objects in DialerCall#areSameNumber. This is a upstream change from: https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/556000 originating number is shown in the call screen. Bug: 70201489 Test: manual - Verified that a call number that changed from a PiperOrigin-RevId: 183022988 Change-Id: I04305998e77ca120b1248636c63984b3d20f0db1
2018-01-23Search no longer crashes if you don't have the contacts permission.calderwoodra
Bug: 71737256 Test: NewSearchFragmentTest PiperOrigin-RevId: 183020934 Change-Id: Ifed4364901ca77036fa6d0b149857fbbd7e9fca0
2018-01-23-Add cleaning blocked numbers stored in a separate database when people try ↵weijiaxu
to clean calllog database. Bug: 71898641,72104419 Test: On a local device. PiperOrigin-RevId: 183016474 Change-Id: Ib59bf558d5552e9b88c3feee1c47d96791fd542c
2018-01-23Don't garbage collect voicemails in AnnotatedCallLog.zachh
We currently limit the size of AnnotatedCallLog to 999 via a trigger, but it doesn't exclude voicemails. Since we don't want to ever garbage collect the user's voicemails, exclude them from the trigger. This means that we can no longer assume a maximum size for the table (the user culd have more than 999 voicemails) so I've updated the places in the code where we did that before. Finally, I changed AnnotatedCallLog's CALL_TYPE column to be non-null. This is so that we can have more confidence that the trigger will work as intended. Null values cannot be compared in SQLite, so an expression like "where call_type != 4" won't actually match a null call type. Rather than implicitly fail to clean up such rows, we just crash completely when encountering such rows (even though I don't expect that to happen). Bug: 70989634 Test: unit PiperOrigin-RevId: 183006714 Change-Id: I9f4394a4812afe4b65c1e8427c355d825356557c
2018-01-23Bubble bottom action changes.yueg
- Hide bottom action view when bubble move canceled - Get display height every time when show bottom action view (onConfigurationChanged() won't be called when bubble is not visible) Test: manual PiperOrigin-RevId: 182979768 Change-Id: I989422c4ab5866b22c78bffbc82f229842a6dd9e
2018-01-23Contacts recyclerview is now hidden when we don't have contacts permission.calderwoodra
Bug: 71867982 Test: ContactsFragmentTest PiperOrigin-RevId: 182977635 Change-Id: Ibdefc49c76dd607c5f1316ae46da5e38f74c0e85
2018-01-23Moved coalesced_ids.proto and number_attributes.proto to ↵zachh
calllog/database/contract. The "model" package should be reserved for call history proper (and not voicemail) so it shouldn't contain things needed by voicemail. Test: existing PiperOrigin-RevId: 182976719 Change-Id: I463c8ed4600950a8d18db49d991609bfaa49c709
2018-01-23Write PhoneLookup results to PhoneLookupHistory in RealtimeRowProcessor.zachh
This is an optimization to reduce "popping" in the new call log. Since we have to do the PhoneLookup anyway to update the UI, we may as well write the result to PhoneLookupHistory so that the next time the AnnotatedCallLog is refreshed, the updated results can be retrieved from PhoneLookupHistory. I also updated RealtimeRowProcessorTest to use FakePhoneLookup rather than the real Cp2PhoneLookup since RealtimeRowProcessor no longer uses Cp2PhoneLookup directly (it was updated to use the general-purpose PhoneLookup in a previous CL but I didn't update the test at that time). Test: unit PiperOrigin-RevId: 182974567 Change-Id: I813e9d69f802ca08757238290fdfcf58e78b3592
2018-01-23Attempt to work around sqlite database cursor window issuemaxwelb
Bug: 72320869 Test: DialerDatabaseHelperTest PiperOrigin-RevId: 182964251 Change-Id: Ie6539ce27bcbd97b093a47e1f5882770fc345e59
2018-01-23Bubble change when display size change.yueg
- Set primary button background oval and transparent. - Provide outline for primary button since elevation doesn't work when background is transparent. - Re-draw bubble on configuration changed to propagate changes. Test: manual PiperOrigin-RevId: 182949653 Change-Id: I71e70d6fa43fa5867f9cf37002930c5a8dc42b06
2018-01-23Update Assisted Dialing references.erfanian
Test: existing unit tests PiperOrigin-RevId: 182949031 Change-Id: I40955c6e5f4fe06687880d3e9ef4b91ef9c0b371
2018-01-23Pressing back button twice really quickly no longer crashes dialer.calderwoodra
Bug: 72319656 Test: manual PiperOrigin-RevId: 182947143 Change-Id: I70ed303ba8cdb64591ab6debf60eef540aacea73
2018-01-22Move legacy voicemail/error to nui voicemail/listui/erroruabdullah
All packages relating to NUI voicemail should be under third_party/java_src/android_app/dialer/java/com/android/dialer/voicemail/listui. Since there is a chance that during NUI development the legacy third_party/java_src/android_app/dialer/java/com/android/dialer/app/voicemail/error might undergo changes, it makes sense to move this package to the nui, so that no changes in the legacy code are missed for nui. This refactoring would also allow us to ensure that the strings do not need to be translated and that most of the code can be re-used for nui by hooking up the fragment and adapter to voicemail/listui/error. Bug: 71700117 Test: Unit tests PiperOrigin-RevId: 182868896 Change-Id: I23329654df5ce2bf612101708ed001ca308ae1ac
2018-01-22Implement System blocked numbertwyen
This CL implements looking up blocked number in the Android system blocked number provider, which is available after N. Dialer and system blocked number will return empty if requirements are not made (N+ and migration completed is needed for system, otherwise dialer should not be used). Bug: 70989543 Test: Unit tests PiperOrigin-RevId: 182852672 Change-Id: I1360b7eed7c18f459292d769529ffcfceb61a7ed
2018-01-22Don't let the FAB obscure the last item of speed dial/call log/voicemail.linyuh
Bug: 72235391 Test: Manual PiperOrigin-RevId: 182848699 Change-Id: I587f5f4dd770278747114da17581c8fc253651c0
2018-01-22Changed PhoneLookup#lookup to accept a DialerPhoneNumber.zachh
There's a problem with the existing implementation of RealtimeRowProcessor; when CP2 information is not present, data from other sources can potentially be erased. This CL fixes the problem by fetching the latest data from all sources, instead of just CP2. This requires being able to fetch PhoneLookup info without a Call, using only a number, so I changed PhoneLookup#lookup to accept a DialerPhoneNumber rather than a Call. (The reason that it accepted a Call was to support CNAP so we'll need a revised solution for that later.) There is a potential concern with performance in RealtimeRowProcessor due to performing a full [Composite]PhoneLookup vs. a CP2 lookup, because the full lookup includes network requests. However, it's anticipated that the real time lookups will very rarely have changes to apply so this might be OK as-is. If not, a mitigation strategy could be improving the performance of CompositePhoneLookup#lookup by short-circutiing slower sources when faster, higher priority sources have already completed. A follow-up CL will write the result of RealtimeRowProcessor queries to PhoneLookupHistory to further reduce how frequently real time updates need to be applied. Bug: 72229553 Test: existing unit PiperOrigin-RevId: 182839130 Change-Id: I8cb26827b4f4dc4702fb416234c8938179cd5ac5
2018-01-22For call log entry labels, remove the dot after abbreviated time units.linyuh
The platform utility adds a dot after time units (e.g., "8 min. ago") but we prefer not to have it (e.g., "8 min ago"). Bug: 70989595 Test: CallLogDatesTest, CallLogEntryTextTest PiperOrigin-RevId: 182838540 Change-Id: Ib8766a892aa04decb38917a6c5660804755725e0
2018-01-22Implement blocking commandstwyen
Test: Unit tests PiperOrigin-RevId: 182813080 Change-Id: I952f49352fb57c02c4efb9cc4ede84dc7c32c893
2018-01-22Properly display date and/or time of entries in the new call log.linyuh
Bug: 70989595 Test: CallLogDatesTest, CallLogEntryTextTest PiperOrigin-RevId: 182809700 Change-Id: I84b699536ae7f77e6c27db0b1b008e3ebc6216c2
2018-01-22Add simulator enriched call related to interfaces and stubs.weijiaxu
Test: on a local Device. PiperOrigin-RevId: 182809258 Change-Id: Ic996a31437d4b07cb2c7372005fe8d797757dfc0
2018-01-19Update Simulator to launch SpeakEasyAndroid Dialer
Test: PiperOrigin-RevId: 182625448 Change-Id: I4fe514c429a6b5a88060f326b0c73c2f3a960c1c
2018-01-19Improve & reorganize logic related to directories/remote contacts in the ↵linyuh
search fragment. Test: DirectoriesCursorLoaderTest, RemoteContactsCursorLoaderTest PiperOrigin-RevId: 182578207 Change-Id: I03c81bd8581c8abbef1bbca1a960f3380d588d22
2018-01-19Add the "Yesterday" header in the new call loglinyuh
Bug: 70989598 Test: NewCallLogAdapterTest, CallLogDatesTest PiperOrigin-RevId: 182567571 Change-Id: Ieabbe709668d843334bc3bf4a128834fddb57cb8
2018-01-19Bubble v2 layout changes.yueg
To display expanded view properly with display size and font size set to largest, we made the following changes: - increase expanded view width - use fixed expanded view button height - remove blue background behind avatar Test: manual PiperOrigin-RevId: 182565152 Change-Id: Ie4cea2c42b66320767e283144ddd5d7c5ff40e1c
2018-01-19Improved support for post dial digits in new call log.zachh
-Don't ever coalesce rows with different post-dial digits -Made matching of unparsable numbers a little more intelligent by comparing national/postdial portions which have undialable characters removed (rather than exact string match) -Read and append the post-dial digits from the system call log when building DialerPhoneNumbers to place in the AnnotatedCallLog. Note: PhoneNumberUtil will parse numbers with exactly one post-dial character, but not more than one. -Use post-dial digits when building the AnnotatedCallLog's FORMATTED_NUMBER value -Display the formatted number in CallDetails when the name is missing, instead of the unformatted number -Don't set the displayNumber in CallDetails when the name is missing, because we are showing the (formatted) number via the nameOrNumber field. -Treat numbers with post-dial digits as invalid in PartitionedNumbers; batch operations are not possible with these numbers because their normalized representations strip the post-dial digits (and they are significant for contact matching) Bug: 70989632 Test: unit and manual PiperOrigin-RevId: 182557754 Change-Id: Idcdefce0946a189e5b350a53ec2a16a96a8d4552
2018-01-18Search, Dialpad, BottomBar and Toolbar now persist state through rotation.calderwoodra
Bug: 64655802 Test: MainActivityIntegrationTest PiperOrigin-RevId: 182460232 Change-Id: I59b5f6417dd4f1c2b56a9b8d08b9e12e0c51c411
2018-01-18Descrease bubble bottom text scaling factor.yueg
Also set TextView width according to the scaling factor so texts don't go off screen when scaling. Test: manual PiperOrigin-RevId: 182452685 Change-Id: If438f1b7e0432c2856bd2cb937adfc4131e57410
2018-01-18Fixed regression with search not reacting properly to on touch events.calderwoodra
There are a few interesting UX niceties that we support in search: 1) When in regular search with an empty query, close the UI if the user touches the blank space. 2) When in regular search with a non-empty query, hide the keyboard if the user touches the the list so they can see all results. 2) When in dialpad search with an empty query, close the UI if the user touches the blank space. 3) When in dialpad search with a non-empty query, hide the dialpad so the user can see the full list of results. This change also adds logic to transfer the dialpad query to the search bar. Bug: 64655802 Test: MainActivityIntegrationTest PiperOrigin-RevId: 182434126 Change-Id: Iabb73b0018fa20e2811010a73a35d3aa3b35343b
2018-01-18Pass PhoneAccountHandle into VideoTech isAvailableroldenburg
Bug: 71840382 Test: DuoImplTest, existing tests PiperOrigin-RevId: 182424150 Change-Id: I25607d43e1915d57134feac99b2c2240ae9559f9
2018-01-17Relax number matching when coalescing rows in new call log.zachh
We currently require two numbers to be a PhoneNumberUtil.MatchType.EXACT_MATCH to coalesce them, but this means that two numbers like "456-7890" and "408 456-7890" won't ever be collapsed. This is potentially a likely situation since it is possible to dial numbers without an area code so we should better support it (and the old call log coalesces such numbers today). Bug: 70989626 Test: unit PiperOrigin-RevId: 182289194 Change-Id: If884d5a1f2631116a2729e0635f9a97aeca3e057
2018-01-17Move onUiShowing() call from onResume/onPause to onStart/onStop.yueg
It makes sure bubble doesn't appear on split screen when in-call UI is not showing. Although bubble still shows in recents screen. It also make sure the same onUiShowing() is not called multiple times. Bug: 67605985,71746139 Test: InCallActivityTest PiperOrigin-RevId: 182280886 Change-Id: I2a28d0258c722d530000729a89751c6d6b1ee6fd
2018-01-17Support deleting PhoneLookupHistory rows with empty phone numbers.zachh
Test: unit PiperOrigin-RevId: 182280850 Change-Id: I51a89f50d56af344425d5f67c6bcaa3928b457e9
2018-01-17Show existing CP2 information for invalid numbers even if out of date.zachh
This is an optimization to reduce popping in the new call log. Currently when Cp2LocalPhoneLookup determines a number to be "incomplete" (because it is an invalid number and there are too many invalid numbers in the call log to efficiently bulk update) we clear the existing data, which has been populated in PhoneLookupHistory (for example, from InCallUi). This means that we will show the number initially when displaying the call log, and then when the query completes we will "pop in" the new information. This change makes it so that we don't clear the existing data from PhoneLookupHistory, and just add the "incomplete" bit. The result of this is that we immediately display the available information when initially displaying the call log (even though it may be out of date). When the query completes, the row will be updated with the most recent information; in most cases this is likely to be the same as the information used to initially display the row, and no update will need to be applied. Additoinal changes to support this functionality: -RealtimeRowProcessor is now just responsible for returning an updated row, and NewCallLogView holder will compare the result to the originally displayed row and only update the UI if there are differences. -NewCallLogFragment now calls clears the RealtimeRowProcessor's cache and notifies data set changed during onResume. This is to account for the fact that AnnotatedCallLog no longer contains the complete set of information necessary to show the call log; there may be changes we need to show which can't be detected by the cursor loader. We now show those potential changes in onResume. Additional notes: -If there is real-time data that changes after onResume it won't be detected but there shouldn't be such cases; changes made to contact information from dialer are always done through contact cards which pause the fragment. -This change has the effect that whatever information was written to PhoneLookupHistory during the previous invocation of InCallUi will always be (initially) shown. For example, if the contact name for number "123" is "Joe" when the call comes in, we'll write "Joe" to PhoneLookupHistory. If the user changes Joe's name to "Jane", the UI will pop from "Joe" to "Jane" until PhoneLookupHistory is updated (which is currently only done from InCallUi). If this turns out to be a problem it could be mitigated by writing updated results to PhoneLookupHistory from the UI. Test: unit, manual PiperOrigin-RevId: 182277145 Change-Id: I3d9916b7747390ff956f399fe84b26d578e5a07f
2018-01-17Update "Call blocking" to "Blocked numbers"roldenburg
Bug: 27705124 Test: n/a PiperOrigin-RevId: 182275405 Change-Id: Ic70b34790956f2d3652a23800ba0f5e37cfefca8
2018-01-17Search query is now shared with the Search Fragment in NUI.calderwoodra
This change also adds the logic for triggering SmartDialDatabase updates in Activity#onResume so that Dialpad search has results it can show. Bug: 181512198 Test: n/a PiperOrigin-RevId: 182272002 Change-Id: I3f7f7795df5038c37c1c26e23f4fc816d515e41f
2018-01-17Moved SearchController into its own class.calderwoodra
It was starting to get pretty big and it's probably safe to say it deserves its own file now to declutter the main activity. Bug: 181512198 Test: existing PiperOrigin-RevId: 182264121 Change-Id: Id3314839bcd2fa10f48cc1f0df0bf202ce36ea3a
2018-01-17Updated toolbar and dialpad interactions in NUI.calderwoodra
Toolbar, Dialpad, Bottom Nav, FAB and Search now all show and hide properly according to the state of the application. Follow up CLs will include: - saving/restoring state - sending query to search fragment to display results Bug: 181512198 Test: MainActivityIntegrationTest PiperOrigin-RevId: 182259200 Change-Id: I1309d8df2a5425bf051e52a459a1f78e1157fe08
2018-01-17Take voicemail alert position into account for "older" header for NUI ↵uabdullah
Voicemail Tab The older header must take into account and be offset when there is a voicemail alert being shown. Bug: 71700117 Test: N/A PiperOrigin-RevId: 182243160 Change-Id: Ib38ba82e75fedf9a2939078447e4791f5239524c
2018-01-17Replace PhoneLookupSelector with PhoneLookupInfoConsolidator.linyuh
PhoneLookupInfoConsolidator is designed for the following two purposes. (1) Different sub-messages in a PhoneLookupInfo proto can contain information for the same purpose. For example, all of cp2_local_info, cp2_remote_info, and people_api_info have the information for a contact's name. PhoneLookupInfoConsolidator defines the rules that determine which sub-message should be used to display the name in the UI. This is the same as PhoneLookupSelector. (2) Avoid mixing info from different sub-messages when we are supposed to stick with only one sub-message. For example, if a PhoneLookupInfo proto has both cp2_local_info and cp2_remote_info but only cp2_remote_info has a photo URI, PhoneLookupInfoConsolidator should return an *empty* photo URI as cp2_local_info has higher priority and we should not use cp2_remote_info's photo URI to display the contact's photo. This is what PhoneLookupSelector is unable to do. Bug: 71763594 Test: PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 182236013 Change-Id: If19cdc1a9e076f3ebc8f9e2901f050b519e273f2
2018-01-17Correctly show the contact's photo in CallDetailsActivity when launched from ↵linyuh
the new call log. Bug: 70218437,71867391 Test: ModulesTest & Manual PiperOrigin-RevId: 182233967 Change-Id: I6eb4bf236230eee6bbecc99b128fef5afddfd1e9
2018-01-17Handle hiding bubble right after showing it.yueg
If hide bubble right after showing it, we should cancel animation, remove view and set visibility to HIDEN. Otherwise we can't retrieve correct bubble status later, thus hide/show bubble unexpectedly. It at least fix some cases of IllegalArgumentException. Bug: 71746139 Test: NewBubbleTest PiperOrigin-RevId: 182222155 Change-Id: If020b83cfffd9c643fd6fe3d2879a05e5969281f
2018-01-16Update string to include dashroldenburg
Bug: 26742642 Test: n/a PiperOrigin-RevId: 182144609 Change-Id: I4d4364892775c18224f37981d5e3f128dee086cc
2018-01-16Implement dialer command line interfacetwyen
This CL adds a generic interface to perform action and retrieve data in dialer. Test: Unit tests PiperOrigin-RevId: 182128015 Change-Id: Ib45ce9808bd4e0e4a9c9e05c0017e19c3213bb0d
2018-01-16Use EmptyVideoTech instead of null RcsVideoShare VideoTech impl when unavailableroldenburg
Bug: 67005309,71880949 Test: VideoTechManagerTest PiperOrigin-RevId: 182091664 Change-Id: I0be4d4f9740e2bb678e772ec8526ccf176c334eb
2018-01-14Make sure that voicemail transcriptions are processed seriallymdooley
Since we are now using the AlarmManager to decide when to poll for voicemail transcriptions, we need to ensure that we don't start transcribing a voicemail until polling for the previous one ends. This cl postpones a voicemail transcription task if there is an alarm set to poll for a transcription result. After a transcription result is received (or we give up) the db is scanned for any pending transcriptions and the next one is started. Bug: 70242961 Test: manual and updated unit tests PiperOrigin-RevId: 181899975 Change-Id: I7b8fb696164980cf710aa58a79418c6954e2b4d2
2018-01-12Fixed recycling issues in new call log.zachh
-Reset the text appearance when recycling -Clear the secondary call types when recycling Test: unit PiperOrigin-RevId: 181824011 Change-Id: I92cf2c570754e60f3559ad6b47157b3538c6e2cc
2018-01-12Clear the cache in RealtimeRowProcessor when there's new data.zachh
Otherwise changes to "incomplete" rows won't take effect until a new adapter is created. Test: unit and manual PiperOrigin-RevId: 181823087 Change-Id: I24e1b1b465c8d37cf794312b88b6cdd3ad394b5d
2018-01-12Added some verbose logging to Cp2LocalPhoneLookupzachh
Test: none PiperOrigin-RevId: 181816649 Change-Id: I4e951366e9458899181fb95230a2815ed5fcdaa8
2018-01-12Cleaned up wording around "valid" and "formattable".zachh
We don't actually parition by "formattable", we parition by "valid". An invalid number like 456-7890 can be formatted to E164 ("+14567890") but what ParitionedNumbers actually does is parition by valid/invalid (and then converts the valid numbers to E164). Also added a new sharded test suite for phonenumberproto tests which had occasionally been timing out on TAP. Test: existing PiperOrigin-RevId: 181800443 Change-Id: Id64fc32c893025b0115dd350dd87e3277607f21c
2018-01-12Added Dialpad to NUI.calderwoodra
This change adds the existing dialpad to the new UI and the animation logic required to show/hide it along with the toolbar. A follow up CL will come afterwards to combine these animations with the toolbar expanding/collapsing. known issue: bottom nav appears over the dialpad. Bug: 181512198 Test: MainActivityTest PiperOrigin-RevId: 181777370 Change-Id: Ief1591174ebca3a709df6d1d38c8b8ecbdc1878e
2018-01-12Added search bar animations to NUI toolbar.calderwoodra
Bug: 181512198 Test: MainActivityIntegrationTest PiperOrigin-RevId: 181771027 Change-Id: Id2b6d35cec928cbd2fed8ad75a9da007af9e826e
2018-01-12Do not show deleted voicemails in the NUI Voicemail tabuabdullah
Voicemails that are deleted or marked as deleted should not show up in the annotated call log. Bug: 71885122 Test: N/A PiperOrigin-RevId: 181719056 Change-Id: I7a5f7769ecbfc5feaaee36f0f1de48155576f458
2018-01-11Implement PhoneLookup for CP2 remote contactslinyuh
Bug: 71763594 Test: Cp2LocalPhoneLookupTest, Cp2RemotePhoneLookupTest PiperOrigin-RevId: 181681435 Change-Id: I2e091371b6705390adf4be63c78344f78bd19d6e
2018-01-11Merge PhoneLookupDataSource results into a proto in annotated call log.twyen
This allow extra information from PhoneLookup to be more easily added. Only PhoneLookupSelector and the proto will be affected for new attributes. Test: Unit tests. PiperOrigin-RevId: 181675568 Change-Id: I4e0bc1c6005b58a9b684b030b55bea6223af9ce3
2018-01-11Attempt to place call even call permission is missingtwyen
Telecom might still allow emergency calls to be placed if dialer is the default dialer. Bug: 71739167 Test: Unit tests. PiperOrigin-RevId: 181661814 Change-Id: I24063ee42d646c4b614f3fdeb5685490f064a898
2018-01-11Fixed bug in handling of empty numbers in new call log.zachh
Empty numbers were not being inserted into PhoneLookupHistory because the URI "content://.../PhoneLookupHistory/" is treated the same as "content://.../PhoneLookupHistory" (w/o the trailing slash). This caused the update (i.e. replace) operation to incorrectly update all rows in the table when it should have updated a single row. The fix for this was to switch to a query parameter, so the empty number URI now looks like "content://.../PhoneLookupHistory?number=" Also improved some logging while debugging this problem. Bug: 71866050 Test: unit and manual PiperOrigin-RevId: 181659081 Change-Id: Idec4fb77e74920cd5485620b0a997db03aa8ff9b
2018-01-11Minor polish and bugfixes for new call log.zachh
-Reuse the adapter in NewCallLogFragment to maintain position in call log when returning from call details -Convert empty values to null when invoking ContactPhotoManager to make photos appear correctly in new call log bottom sheets -Added CallLogContactTypes to be shared between proper call log and bottom sheets -Fixed vertical alignment in bottom sheet when there was no secondary text -Added some verbose logging Test: unit and manual PiperOrigin-RevId: 181655715 Change-Id: I9c1a42ad8d529ee2327e15fcc1d32b7b83982014
2018-01-11Allow preferred SIM to be fully clearedtwyen
Bug: 70503524 Test: Unit tests. PiperOrigin-RevId: 181627615 Change-Id: I9e48dd3acc339509ff3805ea38cc6399858ade1d
2018-01-10Initial setup of voicemail TOSuabdullah
This CL only setups the layouts, images and strings associated with the voicemail terms of service. Additional logic of when to display the ToS will be in a follow up CL. Bug: 71699918 Test: N/A PiperOrigin-RevId: 181548639 Change-Id: Ia99dcc5ad8a96dcac71946fe611b3ee4ad24814f
2018-01-10-Add a new log entry in loggingBindings.weijiaxu
Test: Run in dialer lab. PiperOrigin-RevId: 181525979 Change-Id: Ie1c66f0c740fcd91618810c49251eed580aeae84
2018-01-10Add the boilerplate dagger logic for SpeakEasy.erfanian
Test: NONE PiperOrigin-RevId: 181524242 Change-Id: If5d3632421722b4da7b64f78d904b58723408b7c
2018-01-10Add events for displaying set up or invite buttonsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 181515491 Change-Id: I62dc4d4d4ebb02e8e1e8dce6c6970bb7c8845952
2018-01-10Added Search Bar to NUI.calderwoodra
This change only adds the views but doesn't implement any logic or functionality. That will come in a future CL. A decision was made here about whether to create a new search bar or reuse the old one. I opted to make a new one to avoid breaking the old one while it's still being used. Bug: 64655802 Test: n/a PiperOrigin-RevId: 181512198 Change-Id: Ib377b1d99f4eb8100204ac9a110dc5899bced392
2018-01-10Fix PhoneLookupDataSource ignoring inserts if history is emptytwyen
Test: Unit tests. PiperOrigin-RevId: 181512134 Change-Id: If64b4cd184c60a807541cfe8727aa03532a80cb4
2018-01-10Roll forward the broadcast in-call UI changes.yueg
Test: InCallPresenterTest PiperOrigin-RevId: 181512032 Change-Id: Id120d9fe6f46ad157eab7f97614d0c18b6aef8e1
2018-01-10Update content description of back button on banner of RTT chat.wangqi
Bug: 70177426 Test: none PiperOrigin-RevId: 181500079 Change-Id: Ia07e5fc487b9fe64ecfedb074a543fc993b303c4
2018-01-10Log impression when bubble v2 appears.yueg
Bug: 67605985 Test: NewBubbleTest PiperOrigin-RevId: 181493569 Change-Id: I30f7204ad9c78693e2c9b054bd69307fb4768a0b
2018-01-09Rename Cp2PhoneLookup as Cp2LocalPhoneLookup and PhoneLookupInfo.cp2_info as ↵linyuh
PhoneLookupInfo.cp2_local_info. To support remote CP2 contacts, there will be a new PhoneLookup ("Cp2RemotePhoneLookup") and a new field in proto PhoneLookupInfo ("cp2_remote_info"). In proto PhoneLookupInfo, cp2_local_info and cp2_remote_info will be of the same type ("Cp2Info"). Bug: 71763594 Test: Existing tests PiperOrigin-RevId: 181405798 Change-Id: I6c43b486229d4e9ae7b55c579d9c9997a2884c80
2018-01-09Adjustment to banner of RTT chat window.wangqi
1. Change name and timer font to roboto medium 2. Change close button to back button Bug: 67596257,70177426 Test: manual PiperOrigin-RevId: 181404033 Change-Id: I19137c51a6617276dd5ae6a7ba47c12d995e2feb
2018-01-09Changed behavior of failures in DialerFutures#firstMatching.zachh
DialerFutures#firstMatching now fails if one of its provided futures fails before a match is found. This is to accomodate the case where no source returns true for isDirty, but one or more fail; we want to be notified of the failure in that case and not silently treat that case as not dirty. Also fixed a bug in NewCallLogFragment where the failed future wasn't causing the application to crash. Also improved some related logging in RefreshAnnotatedCallLogWorker and Cp2PhoneLookup, and fixed a bug where empty numbers were not being handled correctly. Bug: 71504246 Test: unit PiperOrigin-RevId: 181401710 Change-Id: I23e207ac334ff80ac95b08a8f4f775a528a8c511
2018-01-09Allow SimSuggestionProvider to auto select phone account.twyen
Bug: 70503524 Test: Unit tests. PiperOrigin-RevId: 181400523 Change-Id: I07f2f2cd7c1402d1acb6bfbde9db8d90c888edf6
2018-01-09Bubble v2 dismiss changes.yueg
Including: - Smaller bottom action view - Make gradient darker - Text("hide" and "end call") not all caps - Larger text size - Padding between icon and text - Speed up scaling and hiding animation - Animate opacity together with scaling - Show "Call ended" text in toast instead of bubble Bug: 67605985 Test: NewBubbleTest PiperOrigin-RevId: 181400165 Change-Id: I21b4dcc6324d2dc3eb41377d5264a391c116262f
2018-01-09Added RealtimeRowProcessor.zachh
This is for performing work inside of the call log's RecyclerView, when the view holder is bound. Most of the time, this should be a no-op but there are possible edge cases where the call log data cannot be updated efficiently through the standard batch mechanism. One example of this is when there are too many invalid numbers in the call log; the CP2 information for invalid numbers cannot be efficiently batch updated so we fetch this information at display time. (Note that we do handle up to 5 invalid numbers in the batch update mechanism, but if there are more than that we fallback to this realtime processing.) Test: unit, manual PiperOrigin-RevId: 181400016 Change-Id: Iea6b380742e757b48d19f319fe46dc5fae837604
2018-01-09Fix NPE in NewReturnToCallController.createLettleTileDrawable().yueg
After searching contact info, the associated dialer call object might be removed from CallList, which causes NPE. Test: NewReturnToCallControllerTest PiperOrigin-RevId: 181387022 Change-Id: Icabaeccc96e039c8ac53d66c23af89d3eb0823a9
2018-01-09Let RCS Video Share take over Duo as the active video tech for a callroldenburg
Bug: 67005309 Test: VideoTechManagerTest PiperOrigin-RevId: 181368613 Change-Id: I8a13bd04d3ac342a06febb7437a0e0dd3d25affd
2018-01-09Handle android.telephony.event.EVENT_CALL_FORWARDED.wangqi
Bug: 33761801 Test: none PiperOrigin-RevId: 181347696 Change-Id: Iaf09d1b45a2e97e4d8da24b5bd7172da152d703c
2018-01-09InCallActivity should not call onUiShowing(false) when recreating.yueg
InCallActivity recreates when onNewIntent() and is not visible. Althought onPause() is called, we should not call onUiShowing(false) since the activity is going to be visible. The extra call confuses bubble animation. Bug: 67605985,71746139 Test: InCallActivityTest PiperOrigin-RevId: 181343690 Change-Id: I4d540be0e3e38400322f9b9c3e71e50b1f85977c
2018-01-09Implemented Bottom Nav in Dialer NUI.calderwoodra
Bug: 64655802 Test: existing PiperOrigin-RevId: 181339724 Change-Id: I05c48d0a046010baf6b6593de3b934fdaf3e9f08
2018-01-08Update strings for Duo "Set up" and "Invite" buttonsroldenburg
Bug: 70034799 Test: manual PiperOrigin-RevId: 181241050 Change-Id: Iddf5ef331741f8ab8500eeb3d5481598ef5caca4
2018-01-08Hide emergency calls in the call logmaxwelb
Bug: 38494024,66926712 Test: CallLogAdapterTest, manually checked UI PiperOrigin-RevId: 181238101 Change-Id: I1b718e30a4bc874e098e30a3aaae39bdd69d0c9a
2018-01-08Simplifying implementation of the coalescing logic in the new call log.linyuh
Bug: 70388714 Test: Existing tests PiperOrigin-RevId: 181231987 Change-Id: I0c7386f60e92f7087f9f5ad1b1f454b43b7227e7
2018-01-08Updating Dialer v16 licenses.Android Dialer
Bug: 71713599 Test: 'N/A' PiperOrigin-RevId: 181231841 Change-Id: I810699487db763f9afebabff9ae55e9767afd9fa
2018-01-08Use ContactsContract.PhoneLookup for invalid numbers in Cp2PhoneLookup.zachh
"Invalid" numbers are identified according to PhoneNumberUtil.isValidNumber. This is necessary to support loose matching for such numbers. However, ContactsContract.PhoneLookup only supports looking up individual numbers, which means that we cannot issue batch queries and must issue individiual queries for each invalid number. The hope is that these numbers won't appear frequently so performance should still be acceptable. However, as a failsafe, if there are more than 5 invalid numbers we just give up trying to bulk update the invalid numbers and signal that those numbers are INCOMPLETE so that the UI can query for their CP2 information on the fly (the UI will be updated in a future CL). It was necessary to convert much of the class to use futures to support parallelization of the queries. Bug: 71504246 Test: unit PiperOrigin-RevId: 181216674 Change-Id: I3bec477d305772b4ca3e46d0bd326cfebf9fa313
2018-01-08Add RTT call chat window.wangqi
This change add a mock in simulator with a type bot that's simulating remote typing. The integration into incall UI will be in following changes. Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 181211591 Change-Id: If6cdcb010afc0c25e90d3a44fe349920d5a856c6
2018-01-08Updated T9 search bolding to include wrapping to the next word.calderwoodra
T9 bolding now works when the query continues past a single name and extends to the next. For example, a query of "2226" would bold "[AAA M]om". This was supported in the old search. Bug: 71384038 Test: existing + new PiperOrigin-RevId: 181211263 Change-Id: I7d7fe8be794f410e697ddbcb26c6bc10c7893e5a
2018-01-08Initial setup of voicemail error messagesuabdullah
This CL setups the initial adapter logic to be able to display voicemail error messages. The errors and the code to display those errors will be shown in a follow up CL. Bug: 71700117 Test: N/A PiperOrigin-RevId: 181210330 Change-Id: I5b9e9e675ad7a4825692fb93ca4237d05b0407f0
2018-01-08Automated rollback of changelist 178323108zachh
Test: tap PiperOrigin-RevId: 181196939 Change-Id: I97405c5356814fe3ad02d498cfa96c210921c477
2018-01-08Add "delete" option in the 3-dot menu of the new call loglinyuh
Bug: 69639422 Test: DeleteCallLogItemModuleTest, ModulesTest, and Manual PiperOrigin-RevId: 181191883 Change-Id: I86c19e8a402b03a58c6b236b9ca54fd81f0b6f9a
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-08 20:36:07 +0000