Age | Commit message (Collapse) | Author |
|
When a user enters the voicemail settings page and the voicemail is still being activated, we need to show the "Activating...." string to tell the user that something is still happening. This is important since unless the activation has happened, other settings are not visible e.g transcription and donation
Bug: 76107888
Test: N/A
PiperOrigin-RevId: 189970472
Change-Id: Ib9eeee64cd67c2adc4830a743516851ffa637fbf
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189969399
Change-Id: I8e287cc7884dde7640721bd385fe383a4635f3c8
|
|
This CL updates the call log to show "Emergency number" for call log rows from
numbers that PhoneNumberUtils.isEmergencyNumber considers to be emergency
numbers.
Bug: 66926712
Test: Manual, see above
PiperOrigin-RevId: 189953302
Change-Id: Ibaae243ead8b918a26f6058164316e042a4f82fd
|
|
If we get no location data for emergency call, we used to show spinner forever. This change shows error after 5s with no data, but still tries to get location.
Test: LocationFragmentTest
PiperOrigin-RevId: 189946803
Change-Id: Iaa0b429eec806337b9ab9cae3ca95e737fc667bf
|
|
Bug: 74421656
Test: Existing tests
PiperOrigin-RevId: 189935875
Change-Id: I834e15b7ff102ea021d7a99ebe568998a9c43603
|
|
Bug: 73774242
Test: unit tests where they exist
PiperOrigin-RevId: 189853302
Change-Id: Ibf3431cc0d7716c2c53c7ea165dfc130102a1bc7
|
|
This is necessary to disable the call log framework via flags.
This isn't yet called anywhere.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189838957
Change-Id: I926c02c41151528eabc208c874acbfe7897a2f93
|
|
Bug: 72162360
Test: SpecialCharSequenceMgrTest, TranssionUtilsTest
PiperOrigin-RevId: 189825957
Change-Id: Ia161ad47c4122d33c108b545540707bb18076464
|
|
There is still some jank on first open, but it's much less janky
on close and consecutive open calls.
Test: existing tests confirm no regressions
PiperOrigin-RevId: 189802733
Change-Id: I49d6c2def7c33be0fdbb79c89772a5e4513cde3b
|
|
In order to correctly show animation, we have to ensure:
1. fab.scaleIn() is not called before dialpad is slide up.
2. fab is invisible before scaleIn is called.
Caveat:
This change is not tested on old UI (DialtactsActivity) since it's deprecated.
Test: manual
PiperOrigin-RevId: 189765153
Change-Id: Iada96b2789f96ca1612ae2048020a649f8b57b6b
|
|
This is needed to support flag changes which should cause the call log framework to become disabled.
It's not called anywhere yet.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189761665
Change-Id: I914c690448f03ebacd7d05c9ad082aba7bf1a4ce
|
|
Test: Existing tests
PiperOrigin-RevId: 189683790
Change-Id: I0209e7fa839175041da29e9a6d8a590133121376
|
|
Test: Existing tests
PiperOrigin-RevId: 189678764
Change-Id: I6b9edd99e727788c65d325c1be43f0190c25c30e
|
|
Test: Existing tests
PiperOrigin-RevId: 189675976
Change-Id: Ieae92b5ac2aefd3f0397bbb07ebb1c97bd72ed42
|
|
Test: SpamBlockingPromoHelperTest
PiperOrigin-RevId: 189674918
Change-Id: I0b22eb9b8128125cc5b439674099820a01c3889f
|
|
NUI dialpad is still broken.
Test: Unit tests
PiperOrigin-RevId: 189674304
Change-Id: I58d114ed45839f8ff85a3a0e48c3d200337915c9
|
|
Test: InAppSpamTest
PiperOrigin-RevId: 189670786
Change-Id: Ie7bf394ecc02ac647211f7375faaf3e1b48ad7dd
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189670163
Change-Id: Ifdfcab7dc4493cbe688ef77d43df7e7a1400fa27
|
|
This data source determines if the call is to the voicemail inbox.
isVoicemail() is removed from NumberAttributes and PhoneLookup. It is yet decided how in call UI should handle voicemail calls in the future.
TAG_CHANGE_OK=proto not in prod yet. Please clear app data.
TYPE_CHANGE_OK=above
Bug: 70989587
Test: Unit tests
PiperOrigin-RevId: 189650273
Change-Id: Iafebf1abb18c74301b62a72d1d04deecd6d78d29
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189648655
Change-Id: I9918bd6f35bf7eb1bebb9862c2d78880457efa91
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Other usages already has the null check.
Bug: 75598828
Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause.
PiperOrigin-RevId: 189644833
Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Bug: 75598828
Test: In a follow up CL, where all instance of these will be fixed.
PiperOrigin-RevId: 189635573
Change-Id: I897db6e8e7706bc8afe6f25d89fd2ca4405900df
|
|
Repro steps:
1. open dialer, click on FAB to open dialpad
2. make outgoing call, end call, press home
3. enable WiFi call
4. open dialer again, click on FAB to open dialpad
This is caused by change icon called after the FAB is visible and scaleIn won't do anything since it's already visible. But for some reason the icon is changed so nothing is drawn on the screen when the dialpad slide up. (dialpadfragment is visible even before it's slide up before user trigger it)
The fix is to scaleOut the FAB when the fragment onStop thus the changed icon will be correctly drawn.
Bug: 74586190
Test: manual
PiperOrigin-RevId: 189629441
Change-Id: I3dcbedcd171c992e5df14bff35758fce1bb67bc1
|
|
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 189418664
Change-Id: I3dadea08dad1f2a594f5a7e0daf055721c3222a3
|
|
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following:
- ensuring that when the VVM toggle is turned off, transcription and donations are gone.
- when transcription is off, donation preference is gone.
- donation is only available when transcription is available and enabled
- as part of the refactor, fixes existing logging bugs
- breaks preferences and its associated methods into helper methods when possible
- groups relevant preferences together when possible
Bug: 74033229
Test: Unit tests
PiperOrigin-RevId: 189418217
Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
|
|
Also change "done" button to "send" in input box and disallow multiple line since return will be interpreted as "send".
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189409725
Change-Id: I3d3bf3e11cd04d6689125399f4567e88ee3f28f0
|
|
This also finishes moving all of the old tests over from
Dialtacts to Main. The only 2 tests that fail are:
- searchBoxClosedWhenHandlingNotificationIntent
- openSearchFragment_fabGoneInRegularSearchAfterRotation
I will fix these in a follow up CL.
Bug: 72525887
Test: dialer_aosp build target launches MainActivity, TAP
PiperOrigin-RevId: 189408987
Change-Id: Ice30191d95c19c62bcd89503e89f66440f30beac
|
|
Bug: 72755010
Test: manaul
PiperOrigin-RevId: 189408046
Change-Id: Ia23442b2243e2008042e0046a21f840a30dbf008
|
|
Previously it is unclear what the "county ISO" should be so the originating county of the SIM is used. When telecom writes to the call log the county the user is in is used. This caused the DialerPhoneNumber key in in call UI and call log to differ and info to be lost.
In this CL, the current country is used in PhoneLookupHistoryRecorder to make it consistent with the call log.
PhoneLookupHistoryRecorder is currently the only consumer for telecom call util.getCountryCode().
Additionally, dialer/location no longer depends on dialer/util. dialer/util has too many unnecessary dependencies that will cause cycles.
Bug: 73752730
Test: Unit tests
PiperOrigin-RevId: 189378542
Change-Id: I59773f7745c835a6523efda951c475e2fde9aaf9
|
|
Bug: 73741286
Test: none
PiperOrigin-RevId: 189377028
Change-Id: Ifb9c6375d0026fb012ae868741b471f2ca02c5f9
|
|
Apperently contact ids are invalid for work contacts, so the URI needs to
exclude them.
Bug: 72755010
Test: manual
PiperOrigin-RevId: 189374262
Change-Id: Ibeaa555dc035e14ea67905c342369188ecfd1832
|
|
If the user had the dialpad open when they received a call, they could
potentially crash dialer if they pressed add call or clicked on a phone number
in another app.
Bug: 74711879
Test: manual
PiperOrigin-RevId: 189371425
Change-Id: I14df55e2467be07dd30e3971004e601216f57daf
|
|
Bug: 73133096
Test: ModulesTest
PiperOrigin-RevId: 189303135
Change-Id: Id92d65e4c0bbb3c325c9d89d41d0645df19cde06
|
|
This was accidentally removed in cl/176677167. This change restores
the logging in call details and also adds it to the call log menu.
Bug: 73774284
Test: OldCallDetailsActivityIntegrationTest, CallLogActivityIntegrationTest
PiperOrigin-RevId: 189279107
Change-Id: Iadda16d7f1e4d720f828b5a72f210bcb8029f939
|
|
Bug: 74784637
Test: manual
PiperOrigin-RevId: 189276349
Change-Id: I27b0f911ab5165f902bef017e8c09276441a9dee
|
|
Test: n/a
PiperOrigin-RevId: 189274795
Change-Id: I495e326ce74568d8add739275562284ef12e276f
|
|
For simplicity, instead of resolve the nui shortcut string, I
deleted it since it isn't used anymore.
Test: build log
PiperOrigin-RevId: 189260472
Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
|
|
Bug: 74017355
Test: ContentWithLearnMoreSpannerTest
PiperOrigin-RevId: 189252365
Change-Id: I3464fb56b86a6b3ddd25e9eed14152eaeed9925c
|
|
Bug: 73777445
Test: TAP
PiperOrigin-RevId: 189225531
Change-Id: I806be1c2a05d842b4991a9c95c19238f999d814d
|
|
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 189225436
Change-Id: I845855d0b66941e311f3db239d10249015473c65
|
|
Test: existing test (MotorolaUtils)
PiperOrigin-RevId: 189225421
Change-Id: Id15181746cd087c82bc0b97262b03c76bc571b3f
|
|
Bug: 73830902
Test: Manual
PiperOrigin-RevId: 189222303
Change-Id: I0397986d784d28e7948b39778319e3936f6c55e9
|
|
This happens when outgoing video call is accepted as voice call or switching
between video call and voice call.
Bug: 71590134
Test: manual
PiperOrigin-RevId: 189206585
Change-Id: I564c261614990b9b6baab6025f1625f42058ba70
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189204691
Change-Id: I9ecd36ce1c27072dea4ae87beeecd4565bf05378
|
|
Bug: 74202944
Test: ModulesTest, CallDetailsActivityTest
PiperOrigin-RevId: 189204143
Change-Id: I917bac76009522c6a99fdb63299556ec2a454dfa
|
|
This class is responsible for enabling or disabling the call log framework when flags change.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189143911
Change-Id: I4727645ce621fbc01acbcd0acab523fe955d4075
|
|
Bug: 74202944
Test: Existing tests
PiperOrigin-RevId: 189095432
Change-Id: I13015ee6c5767edd95b78c3fb2e7338495e9e1d7
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189064976
Change-Id: I3265881114baceb4d63fcc3d55d1c904cd3216dc
|
|
Fast consercutive calls to #showFragment can have undesirable effects because
fragment manager doesn't handle transactions sychronously. This CL resolves one
of the scanrios where voicemail fetch status was calling #showFragment nearly
simulataniously to the #onHandleIntent call.
This issue may show itself again and I'm looking into more long term solutions
but we should be fine in the short term since the all of our fragment logic
is implemented.
Bug: 74051208,74621909
Test: manual
PiperOrigin-RevId: 188956984
Change-Id: I0796e31b03e0b749ae7e81f82859ea6f814a5fb5
|
|
Incall and answer screen is using transparent status and navigation bar, while RTT screen is using customized color. Switch between them require correct setting of system UI.
Bug: 67596257
Test: manually test to make RTT call and voice call, then switch between them.
PiperOrigin-RevId: 188956868
Change-Id: I3c17ff453be943f0b2ad28fe5cae434453fbe326
|
|
Test: N/A
PiperOrigin-RevId: 188953886
Change-Id: I3279efe088e8a37df79d635bd44c6fa831109f2e
|
|
Test: existing
PiperOrigin-RevId: 188928916
Change-Id: I2b6fb73545194fa175526a77ce2a76b1d23c049d
|
|
SQLiteQueryBuilder.query() is used in strict mode with a projection map.
Bug: 74601176
Test: Unit tests
PiperOrigin-RevId: 188907943
Change-Id: I2f34e185ad175695d941697cd0dbdc8ad6172321
|
|
Add 6dp of spacing between transcription and the secondary text.
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188902056
Change-Id: Iba1c9c110bd238842567e7b1b36a757d388cea2d
|
|
Makes the views where the voicemails are displayed and the empty view white.
Bug: 74402112
Test: N/A
PiperOrigin-RevId: 188901487
Change-Id: I55a12dd067e66cc0f4efca3eb79b5a8f9e761082
|
|
The default text alignment of a TextView is based on the content of the view (does it has any RTL characters or not). Previously the TextView width is match parent so the text will either align to the left or right depending on the content (the label is user content which we don't control). In this CL it is changed to wrap content so the whole text will align to the parent's gravity which is "start".
Bug: 74421655
Test: N/A
PiperOrigin-RevId: 188899698
Change-Id: Id754ed97bb6d3b6bba05d0a96c83623daca01cc8
|
|
This CL is a continuation of cl/187700318. In that CL, we were able to unregister
the call log's content observer and prevent this crash, but it's reshowing
itself in voicemail now.
Since the voicemail's observer is registered in the adapter and is unaware of
lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll
just check that the parent isn't null.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 188812159
Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f
|
|
Keyboard should close when:
- requeting permission
- placing a call
- leaving the app
Search should close when:
- placing a call
- leaving the app
Bug: 74235853
Test: search closing onPause tests already exist (MainActivityOldPeerSearchIntegrationTest#placingCallFromSearchClosesSearch)
PiperOrigin-RevId: 188812026
Change-Id: Iaee084c59b4c514d10375deff5d73d5a456ef9df
|
|
Previously the OEM MMI codes are hardcoded and inadvertently affected other devices. In this CL it is read from the config provider instead. The config provider is expected to provide values based on the OEM.
Bug: 72162360,74016291
Test: SpecialCharSequenceMgrTest
PiperOrigin-RevId: 188786408
Change-Id: Ie70e49a8a9d2ced5da9cf502c020477615bbe8a2
|
|
Bug: 74402112
Test: none
PiperOrigin-RevId: 188782198
Change-Id: I36c2adcd8f0403c88694343cbbf12e9aba229afb
|
|
Decrease the padding from 10dp to 4dp for bottom and top
Bug: 68727352
Test: N/A
PiperOrigin-RevId: 188776245
Change-Id: I7ced053a5989e15e84fad6a264683a5c8e5d9339
|
|
available.
Bug: 70989591
Test: GlidePhotoManagerImplTest
PiperOrigin-RevId: 188758361
Change-Id: I038b5618a0005159ebae28e4b95ef5a4d388e2be
|
|
Makes the avatar and more icon the same as the nui call log.
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188756733
Change-Id: I93303a2a872ac156470d223d6fb4fd2959766adc
|
|
The metadata belongs with the voicemail settings menu, which is moved into dialer a while ago. Not moving the metadata causes build variants without VVM to have duplicated voicemail settings in telephony and dialer.
Also removed the redundant metadata in incall ui manifest.
Bug: 73096806
Test: manual
PiperOrigin-RevId: 188756468
Change-Id: I00174f84024c5b9ab809d99e40a55d22a07bd063
|
|
Test: BubbleImplTest, BubbleImplIntegrationTest, ReturnToCallControllerTest, ReturnToCallActionReceiverTest, BottomActionViewControllerTest, ChangeOnScreenBoundsTest
PiperOrigin-RevId: 188558386
Change-Id: Ieab3ee3f148092312a50597b41c0975419756e23
|
|
This is to prevent dialpad showing with keyboard open.
The alternative way to dismiss keyboard after dialpad shows up doesn't work.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188556453
Change-Id: I4b917d8ac83246d2002641ae7759261699149c65
|
|
Makes the redlines similar to what we have for the call log nui. The values are structured and copied as much as possible from /calllog/ui/res/layout/new_call_log_*.xml
Things to note for:
-Today/Older header the same as call log
-More items all the way to the right
-Padding in voicemail icon gone
-Removed padding between each recycler view item
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188547442
Change-Id: I515d75e392591243510634c3fabe444a7ba10d7f
|
|
Test: InAppSpamTest,ApdlSpamTest,VisualVoicemailUpdateTaskTest
PiperOrigin-RevId: 188509191
Change-Id: I8b9c07dcc1c7b3b80ffc914ec99f4e6d80d50985
|
|
Thus putting call into background won't lose the history.
This is only stored in memory by making RttChatMessage Parcelable and saved
along with fragment's life cycle.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188500104
Change-Id: I11e8e55f0475defd9c3b9a8cc10db4186392ddd8
|
|
When a voicemail is deleted we have to allow the user the option of cancelling the deleting of voicemail. This is done by showing the user a snack bar which when a user taps will prevent the voicemail from being deleted.
This CL only adds the underlying logic for the delete/undelete to take place via a ScheduledFuture, it does not fix all the UI issues that come with it, which will be sent in a follow up CL, issues such as:
-Updating the group label when a delete/undo happens
-Updating the entries above and below when a delete/undo happens
-Showing the empty view immediately when a user deletes a single voicemail
-Removing the empty view immediately when a user taps undo
-Updating tests
Bug: 69858266
Test: Manual
PiperOrigin-RevId: 188424489
Change-Id: Iecf5cb7be5b80fa5e91acaad3a7cc4a6c8702521
|
|
This change also dismiss overflow menu when any button is clicked inside it.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188424236
Change-Id: I90b803d592f12525cdb8727aaeebc45c3da5dcdd
|
|
Bug: 73368638
Test: CallLogAdapterTest
PiperOrigin-RevId: 188414469
Change-Id: I7d7522c841a6b4054e2e387346973c597174ee87
|
|
Test: MainActivityOldPeerTest
PiperOrigin-RevId: 188409482
Change-Id: I0c132c49d63b9af849522851c55f51d431faa603
|
|
We used to only show bubble when leaving in-call UI, so answering from Bluetooth does not show bubble. Fix it by also showing bubble in onCallListChanged().
Test: NewReturnToCallControllerTest
PiperOrigin-RevId: 188403460
Change-Id: I5e6a3c37b2773e426dcc73ae5661b9e145b20cb8
|
|
Adds a divider line to differentiate the voicemail entries and the alerts.
Bug: 73158572
Test: N/A
PiperOrigin-RevId: 188389442
Change-Id: I33bd32fc310cdf52f20bcb2d0b2cd4266420cab6
|
|
Instead of using things provided by Android of onTextChanged, we compare the
text in EditText with the text in bubble before the change and compute the
delta string need to send to remote party. This way we could minimize
characters sent thus reduce latency.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 188389325
Change-Id: I3023b484c32b2369ca8720104da74cf6906bb46e
|
|
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 188373256
Change-Id: I0f0798a5310225456619757dcca5bbd5df372b91
|
|
Bug: 73718977
Test: Existing tests
PiperOrigin-RevId: 188359859
Change-Id: I513e1111b643d6fa476d1e56b60c0d6e61e131f4
|
|
Bug: 70989547
Test: ShowBlockReportSpamDialogNotifierEndToEndTest
PiperOrigin-RevId: 188357953
Change-Id: Ie1b1f439f043805892876790d7590a4c721dbf8c
|
|
Bug: 70989547
Test: ShowBlockReportSpamDialogNotifierEndToEndTest
PiperOrigin-RevId: 188351591
Change-Id: I634fb821592bdc890df291fdf83cdf307c94ffa9
|
|
Bug: 73994020
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 188260007
Change-Id: I23025e9b9454f487117c35e7a3b09307371ae825
|
|
Bug: 73877234
Test: just logging
PiperOrigin-RevId: 188256051
Change-Id: Ic9486b3fc1d97338cb016b86a243612baa6282fe
|
|
Test: none
PiperOrigin-RevId: 188244536
Change-Id: I7d41adaf600ba7829054ab8af6b4d30fd0873c3b
|
|
My hypothesis is that trying to commit multiple seperate transactions back to
back causes the fragment container to get into a weird state. So this change
has two parts:
- Disable preloading call log
- Combine the seperate hide/show transactions into one transaction
- Don't call conflicting transactions (i.e. hide then immediately show)
Bug: 74051208
Test: existing tests, manual
PiperOrigin-RevId: 188215791
Change-Id: I699fc02f1e2716bc019a29dc047ee4bc0d52df35
|
|
Previously preferred SIM is handled only by precall, which covers dialing with dialer or with the special receiver contacts uses. If a third party app uses ACTION_CALL or telecomManager.placeCall(), then the in call UI will be launched directly and the old account selection dialog will be used without preferred SIM support.
In this CL logic from CallingAccountSelector is refactored out so InCallActivity can use it for the dialog.
Bug: 73718976
Test: Unit tests, In call UI not covered.
PiperOrigin-RevId: 188214007
Change-Id: Ifaacf982a3e98601dc362b649c3501d4ee96e63e
|
|
The user starts a video call a warning dialog shall be presented.
If the user presses "OK" with the "Do not show again" box selected,
the dialog shall not be presented anymore.
Test: manual - Verified that a warning dialog about charges is shown
when a video call is started if
KEY_SHOW_VIDEO_CALL_CHARGES_ALERT_DIALOG_BOOL is true.
This is an upstream change from:
https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/518977/8
Bug: 67832837
Test: partner manual test
PiperOrigin-RevId: 188103414
Change-Id: I62628a32557297acaef096db90d2ddf049ef5017
|
|
- Add screen events for 4 tabs, dialpad and search.
- Add impressions for opening MainActivity with tabs/dialpad (non user tab selection).
- Add impression for VVM visible.
Bug: 72525843
Test: MainActivityOldPeerTest, MainSearchControllerTest
PiperOrigin-RevId: 188090249
Change-Id: Ifdf3519f07d7230f20b5d82691a96747b1944d63
|
|
Test: CallingAccountSelectorTest, manual
PiperOrigin-RevId: 188089149
Change-Id: Id1be88124e243e46ac9b0277f40de142af6bb5a9
|
|
Bug: 74202944
Test: Existing tests
PiperOrigin-RevId: 188060790
Change-Id: I4d79a353abf767935383d4149f261f5e96fd7acb
|
|
Bug: 73798533
Test: N/A
PiperOrigin-RevId: 188046222
Change-Id: I1b66afa787bb5c91d71dbeda544218226ae8f5fd
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 187944752
Change-Id: I2bbe45d2bda22bb000239f8613576fffb9f6ab28
|
|
Bug: 73718977
Test: MotorolaUtilsTest & PhoneNumberHelperTest
PiperOrigin-RevId: 187889473
Change-Id: I00d58071ba18ddce5a09c07de9edd2d0956d6478
|
|
My hypothesis is that there is a race condition where the call log changes and
we are leaving the activity before the content observer is unregistered or the
loader it starts is finished. This results in a callback calling #fetchCalls
while Dialer is in the background, resulting in a crash. This change will
confirm my hypothesis.
Even if my hypothesis is incorrect, we have similar checks throughout this
class which indicates to me that some issue exists here and that this check is
safe to do.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 187700318
Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
|
|
Bug: 70989667
Test: unit
PiperOrigin-RevId: 187694255
Change-Id: Ie6ec70a70a4c59cbdfe25c34003d21fa2f751564
|
|
This includes:
1) Made RefreshAnnotatedCallLogWorker.refresh() methods return a result which is "not dirty", "dirty but no changes needed" or "dirty and changes need". It will be interesting to see how often these cases occur (will log impressions in a future CL) so I thought we might as well log the latency of each case separately as well.
2) To support 1) added a new method to FutureTimer which allows you to compute the event name from the result of the timed Future. Also needed to update the Metrics interface to support deferring the event name when starting a timer via a generic token.
3) Timing the coalesce operation which is very heavyweight.
4) Made StubMetrics do some logcat logging to easily observe timing information using AOSP
Bug: 70989667
Test: unit
PiperOrigin-RevId: 187691203
Change-Id: I5f19a2fc94d86639486299b65b0edd66eeaab52e
|
|
Bug: 73727182
Test: tested
PiperOrigin-RevId: 187673539
Change-Id: I9c790e912990fb8dc46da1c1057339c979ac9501
|
|
Bug: 74028377
Test: Manual :/
PiperOrigin-RevId: 187634587
Change-Id: I51be6c151db37988bd68558a6af8c2bab31939a1
|
|
Bug: 73775453
Test: unit tests.
PiperOrigin-RevId: 187630263
Change-Id: Ib8e1b852b4ab4ca6614182db0cb72e413c1612eb
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 187564625
Change-Id: I7e848e975bbab19e605d09283dee24eeb02550f1
|
|
system sound settings fragment instead.
There is no need for dialer to have it's own sounds and vibrations fragment. Instead of maintaining two separate fragments that do that same thing (and have to be kept in sync), we can just have one source of truth and have users modify those settings. Thus we have removed the dialer and vibrations settings fragment and have it instead re-direct to the system sound settings. The automatic advantage of this is also that for dual sim cases, dialer settings don't need to be updated.
Bug: 73750524
Test: Manual. Navigated to the dialer sound and settings fragment, and it opened the system settings. Also pressing back took us back to Dialer as expected.
PiperOrigin-RevId: 187564461
Change-Id: I7d620721237f1c932ed8cea949486ae7dbdefba1
|