Age | Commit message (Collapse) | Author |
|
Test: ondevice
PiperOrigin-RevId: 161548092
Change-Id: If4cde06669bc33cca69a9b602f54d873b735c730
|
|
This CL attempts to improve many related issues.
The first was that the (post-greenscreen) preview was "squished" when making an outgoing IMS video call:
BEFORE: https://screenshot.googleplex.com/cRcZYmgq1rh
AFTER: https://screenshot.googleplex.com/8cWFQw7Au2U
Another issue is that the preview on the green screen sometimes appears very zoomed:
BEFORE: https://screenshot.googleplex.com/0vyq3U87xVX
AFTER: https://screenshot.googleplex.com/zyhkdATMuUj
These two issues seem to be improved by removing our manual attempts to scale the video via VideoScale. (Note that transforms to fix rotation are still needed in landscape mode and remain.)
Another issue is that when hanging up an unanswered outgoing video call, the preview becomes temporarily extremely zoomed and unblurred:
BEFORE: https://screenshot.googleplex.com/mqwSsTXhwSw
AFTER: https://screenshot.googleplex.com/uKfEpVmd8A2
Another issue is that when rotating the device, the preview would sometimes remain rotated incorrectly.
BEFORE: https://screenshot.googleplex.com/p2mVnPJ7dww
AFTER: https://screenshot.googleplex.com/S8R0FsS0Vsn
I believe that these problems (and possibly other video related flakiness I sometimes observed) happen because we update scaling and views immediately after applying layout changes. Often times, the layout changes haven't taken effect because we're in the middle of a layout pass so the updates are not working correctly. So, I moved most of those updates into specific layout listeners for the preview and remote texture views.
(Note that something similar before was attempted using a global layout listener, but that layout listener removed itself after the first invocation so didn't seem to be working as intended AFAICT.)
The last issue was that when toggling the front/rear camera, when returning to the front camera, the video would appear zoomed. This was fixed by removing the call to setDefaultBufferSize in VideoSurfaceTextureImpl. From the javadoc of that method, it doesn't sound like something that we should need to be doing and it reliably fixes the problem.
BEFORE: https://screenshot.googleplex.com/6j0XDfLGAzk
AFTER: https://screenshot.googleplex.com/Hs7zsbtyjwc
Bug: 62437862
Test: manually placed and received IMS calls and observed improved preview scaling on multiple devices when calling from O to N, O to O, and N to O. Observed that basic features (mute/umute video, swapping cameras, greenscreens, answer screens, hanging up, etc) still behave reasonably. Open to suggestions for automated tests.
PiperOrigin-RevId: 161444534
Change-Id: I4be348875de11b8517feba86da07fe41a3e5351d
|
|
Although we don't know the reason why v.getParent() can be null, we can avoid calling it.
Test: manual
PiperOrigin-RevId: 161442696
Change-Id: I07af0da9b64fb3fa77b01c0b619837a79d593b67
|
|
Methods such as getAccountLabel() is called on different threads which may cause
race condition issue.
This change also delete CallLogCacheLollopopMr1 since it's not necessary that Dialer is targeting M+.
Bug: 63415147,63524435
Test: none
PiperOrigin-RevId: 161440757
Change-Id: Ia609c52e53dabdce78ffb4320f4cd66e38112e47
|
|
OC preview devices are hitting the assert and skewing crash rate numbers.
Bug: 62338925
Test: LegacyVoicemailNotificaitonReceiverTest
PiperOrigin-RevId: 161438516
Change-Id: Ib533947d2cd9e9a87ffd9fb629f09f877f683026
|
|
In b/63143138 we discovered an issue with the LetterTileDrawable code.
The class has static fields that are shared across both the main and
background threads, which aren't threadsafe. We attempted to make the
code threadsafe in cl/160696979, but that ended up causing issues as
well.
This CL takes a different approach. Rather than trying to make the code
threadsafe, it instead removes the shared fields and makes them final
and initialized in the constructor. This is inherently threadsafe since
threads cannot interact with the object until it is constructed.
Now that the objects aren't shared, we would potentially use more
memory, since each LetterTileDrawable will now hold onto an instance of
the formally shared object. This was not determined to be an issue
in practice, see the data and conclusion in
(go/lettertiledrawable-caching).
Bug: 63143138
Test: LetterTileDrawableTest (can't verify everything :/ )
PiperOrigin-RevId: 161432711
Change-Id: I443bef01ffac405f5e14e9d981ce1d5a8f3f8fec
|
|
* Don't allow cleartext traffic in the voicemail module. This was being overridden, anyway.
Bug: 62339559
Test: See below.
PiperOrigin-RevId: 161418474
Change-Id: Icd945902ed089bf37b43d93d8fe32983a9f88fea
|
|
This CL bumps the version name of Dialer from Dialer v11 to Dialer v12. This CL
also bumps the version code from 15***** to 1600000.
I've also set 'version_conf_incrementer_max_version_code' at go/dialer-v11
to 1599999.
Test: N/A
PiperOrigin-RevId: 161418347
Change-Id: I961f22481d813d66b950894b3783e13624de733e
|
|
We cannot use ConfigBindings as full backups happen with a base Application, not the app's custom subclass.
Bug: 63104326
Test: N/A
PiperOrigin-RevId: 161398864
Change-Id: I7f559fe7cfd8bfdd65f49efea943f3f75488d1a6
|
|
This will prevent merged conference having participant with name as following:
1. Restrict and non-restriced
"<phone number or name>"
"Restricted 2"
2. Two restricted number
"Restricted 3"
"Restricted 4"
After the change it will become:
case 1:
"<phone number or name>"
"Restricted"
case 2:
"Restricted 1"
"Restricted 2"
Note: Unfortunately there isn't a way to relate the pre-merge restricted calls to the post-merge restricted calls. So "Restricted 2" is not necessary the one pre-merge. This also means reset is safe here for merge.
Bug: 63315372
Test: manual
PiperOrigin-RevId: 161267675
Change-Id: I2df16b6f9802932c06f0bdd62618c49f4e6e87a8
|
|
The dialer voicemail UI will send the broadcast even below O.
Ideally all receiver for system and external broadcasts should be moved out of impl/ since they will not be disabled with the module, but at this point changes should be kept at minimal.
Bug: 63437675
Test: VoicemailClientReceiverTest
PiperOrigin-RevId: 161264508
Change-Id: I99476bb27ce3da9396f3b7205c98cb847bfff9b7
|
|
The tests now call through the click listener to expand instead of just calling
the expanding method directly. This was done after we had a bug come up inside
the click listener that these tests did not catch.
The bug: Lightbringer.getPackageName can return null, so when using a stub there was an NPE inside the ExpandCollapseListener.
Test: only tests
PiperOrigin-RevId: 161121777
Change-Id: Ie58a4c14a32984c183b6159db2076a96cf46b37e
|
|
This is changed in ag/2484808 to be defined by a constant telecom string. It
will be available to public in O MR. We have to hard code it until then.
(This is a take over of cl/161020406 from wangqi@)
Test: VideoCallNotAvailablePromptTest
PiperOrigin-RevId: 161030078
Change-Id: I0e1d8d98cb1f64b035d9063b28f8ba039c7378e4
|
|
There's a bug in O notification framework that the HUN(heads up notification) will always show when a notification with fullScreenIntent is updated.
Previously NOTIFICATION_INCOMING_CALL_QUIET is only used when the call is already active when the new incoming call is received. NOTIFICATION_INCOMING_CALL_QUIET will post the notification to the ongoing call channel instead of the incoming call, which in theory will have lower importance and the HUN will not show. In this CL, all incoming call notification will become "quiet" if the InCallUi is visible.
Bug: 62458080
Test: StatusBarNotiferTest.java
PiperOrigin-RevId: 161029526
Change-Id: I671105ecfc102beb43e52cf4d91d55a66d31cd0e
|
|
The reason of disconnect cause could be null.
This is regression caused by cl/160563754
Bug: 63156395,63302714
Test: manual
PiperOrigin-RevId: 160987545
Change-Id: I3fd726947601f55d5dc917b11626b64bfc9d0135
|
|
*** Reason for rollback ***
Causes crash on launch (b/63252565)
*** Original change description ***
Fix concurrency issue in constructor.
Before:
sColors served as the branch to initialize all member variables.
Subsequent calls to the constructor after sColors had been initialized,
would result in the use of static members that were not yet initialized.
Now:
We guard each reference with an explicit null check during construct.
Members that require synchronized initialization were put into a small synchronized
method.
This was chosen instead of AtomicReferences, and instead of double check...
***
Bug: 63143138
Test: N/A
PiperOrigin-RevId: 160837963
Change-Id: I2586f7586c8f39182d64c3b28a59886c5ba94789
|
|
Test: cl/160695183
PiperOrigin-RevId: 160697524
Change-Id: I07127554a968d8dc36c02b522b7536438be7fb90
|
|
Before:
sColors served as the branch to initialize all member variables.
Subsequent calls to the constructor after sColors had been initialized,
would result in the use of static members that were not yet initialized.
Now:
We guard each reference with an explicit null check during construct.
Members that require synchronized initialization were put into a small synchronized
method.
This was chosen instead of AtomicReferences, and instead of double checked locking,
because -- although verbose -- we can tolerate a small number of overwrites to
each member variable (they are idempotent within the Application scope), thus avoiding the need for any one thread to wait/acquire a lock, as well as avoiding the need to import the Atomic library (which added no incremental benefit).
It is assumed that the JVM will not garbage collect overwritten references to
member variables that are still in use across instances of LetterTileDrawable.
This shouldn't matter because the references are volatile, anyway.
Initialization-on-demand was not available due to the use of non-static
resources on construct.
Bug: 63143138
Test: No. Old unit tests.
PiperOrigin-RevId: 160696979
Change-Id: Ie17a29e48f91cb3df07d81d29b6428b70fb4408a
|
|
The original code is somehow triggering when the VVM tab is not selected.
Bug: 62517716
Test: VisualVoicemailCallLogFragment is utterly untestable
PiperOrigin-RevId: 160692310
Change-Id: Ia9da8e5aa7dd28f22c46d87dd25ebf6097918a9a
|
|
When telecom disconnect the video call with the code of DisconnectCause.ERROR and the DisconnectCause#getReason() of "IMS_ACCESS_BLOCKED", we should show an error dialog to user indicating that video call is not available and providing a option to make a voice call instead.
Screenshots:
https://screenshot.googleplex.com/YTUGVouoLmj
Bug: 33821263
Test: manual, VideoCallNotAvailablePromptTest
PiperOrigin-RevId: 160563754
Change-Id: Ie2eb735a92c577b5ae5a5e8b7efa2d699fc964bc
|
|
This CL bumps the version name of Dialer from
also bumps the version code from 14***** to 15*****.
go/dialer-v10_1 did not have a version_conf_incrementer_max_version_code set, which let it to share the version code increments between v10.1 and v11. There are version codes in v10.1 which are higher than v11 which will lead to users downgrading when we submit v10.1 to the playstore (http://cl/160476738)
To make sure users are not downgraded from v11 to v10.1 when we push to the play store, I've also set 'version_conf_incrementer_max_version_code' at go/dialer-v10_1
to 1504907.
Test: N/A
PiperOrigin-RevId: 160555974
Change-Id: I4a9e64aa2fe461019e179f544fe959b8389a02cf
|
|
*** Reason for rollback ***
Possible cause of Dialer crash: b/63128348
*** Original change description ***
Add accessibility info for bubble.
***
Bug: 62886248,63128348
Test: N/A
PiperOrigin-RevId: 160531267
Change-Id: Ia9bf5fe29523d6f6280e4ed6fcf9a8d23ee72579
|
|
*** Reason for rollback ***
Causes crash, see b/63127884
*** Original change description ***
All Fragments are now support library Fragments.
Switch a bunch of imports to support library Fragments (and Loaders) instead of framework Fragments (and Loaders). This was needed to use FragmentManager.isStateSaved() instead of manually tracking that state. This should reduce errors around committing after state is saved.
Also adds METADATA presubmit to prevent new usages of framework Fragments or Loaders.
***
Bug: 38241305,63127884
Test: N/A
PiperOrigin-RevId: 160530287
Change-Id: Ie2c4d3561ebea2d0f05097ce89bdd9bc8767c8cf
|
|
I think this was inadvertently (?) disabled.
Test: no
PiperOrigin-RevId: 160455622
Change-Id: I9f00331d7ef53108eb0adb9bec9c91be22422d2f
|
|
The state of a session is more closely tied to the session itself,
rather than the EnrichedCallManager. The enum was originally placed in
the Manager as it was used in the API, but now that's no longer the
case.
This CL moves the Session State declaration into Session, which is a
more appropriate location.
Test: tap
PiperOrigin-RevId: 160448612
Change-Id: I907476140bc174a061d48ee8e58878af64a62b29
|
|
The old Log class uses the calling class name for the tag. Proguard
minifies class names, making it annoying to figure out which class is
logging in a bugreport. You'd see something like:
06-14 08:50:10.942 10022 20233 20233 I Dialer : bhp - Phone switching
state: OUTGOING -> OUTGOING
Now you'll see
06-14 08:50:10.942 10022 20233 20233 I Dialer :
InCallPresenter.onCallListChange - Phone switching state: OUTGOING -> OUTGOING
Test: Code builds, no changes were made to the actual logged strings
PiperOrigin-RevId: 160445433
Change-Id: Id4d07a33b9ec7a9bceca48e71cdcfc5e6291b571
|
|
b/38149414 building with dreamchip regressed startup time by 400ms. This seems to be caused by linking against the library with cc_library, but the true reason is still unknown.
In this CL, dreamchip libraries is stored as an asset instead. During runtime the asset will be copied into the data directory then loaded.
Currently the copying happens on the main thread. Whether if it's acceptable to introduce further risk to handle this is to be discussed. Disk IO could already happen before this change.
Bug: 38149414
Test: N/A
PiperOrigin-RevId: 160444223
Change-Id: I9f098e7b79df113b2992d8590b33f423942716e4
|
|
populated. Will just return null in createAnimation() thus not animating (this will likely only happen if the View hasn't laid out yet, so there's nothing to animate from).
Bug: 63054791
Test: ChangeOnScreenBoundsTest.java
PiperOrigin-RevId: 160433277
Change-Id: Ib87d274fd6f109290ec74f2241e2fb559d6138cd
|
|
Including in:
- expanded call log item
- collapsed call log item
- search
- in call UI
LOG_STORAGE_INCREASE(GB/week): 3.15
5M active block user/day * 10 events/active = 350M event/wk
350M event/wk * (3 * 3 [int32])/event = 3.15GB/wk
Test: GoogleCallLogAdapterTest, ContactListItemViewTest, InCallFragmentTest
PiperOrigin-RevId: 160423797
Change-Id: I6c0ade53caf767ea9b2610a4c0eb68fcc2bcedf7
|
|
Bug: 62886248
Test: Manual with talkback enabled
PiperOrigin-RevId: 160349111
Change-Id: I9eaaac90b93b7e6f3a002288d0d68fbbe3fae56c
|
|
Bug: 63012482
Test: CallLogCacheLollipopMr1Test
PiperOrigin-RevId: 160303077
Change-Id: I00c80a681963c5a7a25fffd04e02db32ca2386dd
|
|
*** Reason for rollback ***
This CL causes a crash when swapping SIMs.
*** Original change description ***
Adding voicemail transcription branding and progress UI
screen shot showing branding (its harder to capture the progress UI):
https://drive.google.com/open?id=0B9o_KvtLkcuIdkkycVo1RFhsaENYV3J2Yi1LWnJzR0FfSHJR
***
Bug: 63059930
Test: N/A
PiperOrigin-RevId: 160296762
Change-Id: Ib8d709d03d6d8a3fee4a0c384c15df00f55cb182
|
|
The request to stop transmission can be in-flight at the time Dialer goes into the background so the pause request will still include Rx. This happens because pausing previously just gets the current video state and adds pause.
Bug: 62990728
Test: ImsVideoTechTest
PiperOrigin-RevId: 160210111
Change-Id: Ie9134c285a73d4348036f6bbb847abae53a1d373
|
|
This prevents accidental logging.
Test: GoogleCallLogAdapterTest, CallLogListItemViewHolderTest
PiperOrigin-RevId: 160207870
Change-Id: Ib0582613979114c24bb0bd38df41ad7d7dadb63a
|
|
Switch a bunch of imports to support library Fragments (and Loaders) instead of framework Fragments (and Loaders). This was needed to use FragmentManager.isStateSaved() instead of manually tracking that state. This should reduce errors around committing after state is saved.
Also adds METADATA presubmit to prevent new usages of framework Fragments or Loaders.
Bug: 38241305
Test: Covered by existing tests.
PiperOrigin-RevId: 160202511
Change-Id: I5dc0b467da984ca571e49b4dfa0deea44eb372b2
|
|
The previous fix (cl/159623587) has a regression in this scenario:
Device A: video call Device B
Device B: accept video call
Device B: go into background (press Home)
Device A: go into background (press Home)
Device B: return to foreground (return to call)
Unexpected result: A is transmitting video even though it has not returned to the foreground as well
Bug: 62784036,38359325
Test: manual
PiperOrigin-RevId: 160013824
Change-Id: I6e9c89c8fa52882c49d32e061032b93b1e8552f0
|
|
• moved scrollbar to edge of screen
• changed divider to .5dp and added shadow
• change "DECLINE" to "NO THANKS" for verizon TOS (it already was that way for non-verizon)
• changed "ACCEPT" button to "TURN ON" text
• increased the bottom bar height
• made the google transcription text in the TOS bold
• add an image to the non-verizon TOS screen (just using test image for now)
i didn't add the 'Learn more' link, since its not ready yet.
verizon screen shot:
https://drive.google.com/open?id=0B9o_KvtLkcuIcVk0dHBtWmFfdjJWQVV3OEdVc0JXN01XZHQ4
non-verizon screen shot:
https://drive.google.com/open?id=0B9o_KvtLkcuIci1OMlVXTHVuMGYwMWZVTS01dGVwMUpLdmRr
Bug: 62375681
Test: manual and updated unit tests
PiperOrigin-RevId: 160006810
Change-Id: Id45a3a848bb219a70fddbb5a7ada29cd39e604a9
|
|
screen shot showing branding (its harder to capture the progress UI):
https://drive.google.com/open?id=0B9o_KvtLkcuIdkkycVo1RFhsaENYV3J2Yi1LWnJzR0FfSHJR
Bug: 62376944,62424455
Test: device testing
PiperOrigin-RevId: 159993127
Change-Id: I8355164b5831e85de13915e221f6e0f0163e8c81
|
|
Logging impressions for interactions with the voicemail transcription server.
Bug: 62423554
Test: none
PiperOrigin-RevId: 159985772
Change-Id: I782d7eb4df917ae42940f359d98abc87f7ec0f95
|
|
screenshots:
short message (before cl): http://screen/pMAgfV540Y5
short message (after cl): http://screen/VN3TVTBYjPN
long message (before cl): http://screen/V8jSApXmEC2
long message (after cl): http://screen/Vd7zyf2JGvP
long message zoomed (before cl): http://screen/urWDNGACgOf
long message zoomed (after cl): http://screen/i2xEch8HHoq
PiperOrigin-RevId: 159968371
Change-Id: Icaf0a69949b206efd8d08001065cfb4ccdcb1726
|
|
By not checking CallUtil.isVideoEnabled, we were offering upgrading even after the user had disabled it.
I also tried to make the isAvailable method a bit more readable.
PiperOrigin-RevId: 159966735
Change-Id: Ibf828a561654e0e9521a6d86ad18269da426bba4
|
|
There is still one more violation in hangouts that i will address in a separate cl.
PiperOrigin-RevId: 159955865
Change-Id: I61cb65d5f099baae497dfe2daddb4f7da6866ad6
|
|
Replace the null "client type" value by a more detailed value in the MO SMS.
Create a client type value based on :
- Manufacturer name
- Model name
- Android os version
Test: OmtpConstantsTest.java
Original author:
http://aosp/319963 - Alexis MARCOU <alexis.marcou@orange.com>
PiperOrigin-RevId: 159906976
Change-Id: If759f7c96c9fb9a3895f8d944c842c350b8d2472
|
|
If the user disallowed the "Display over other apps" permission then
incoming calls would no longer show up on the lock screen.
The problem was that if the permission was denied then we would attempt
to ask the user to give us the permission. This causes us to start an
activity while the in-call activity is starting which break things.
Fix was to never prompt the user to give us this permission. This is ok
because not having this functionlity doesn't break anything.
PiperOrigin-RevId: 159901233
Change-Id: I3c06ba327ef265fd7981931f49c44e00d1c25350
|
|
Test: IconFactoryTest.java
PiperOrigin-RevId: 159871437
Change-Id: I8df921f36bde619811129ae0f3013ff77903fc8e
|
|
This fixes two bugs we previously had:
1) If video calling was disabled in Settings, we would still show a video call option in the call log (fixed by checking the setting)
2) If a different app from Dialer inserted a video call into the history, we would incorrectly show a video call button in the call log (fixed by checking the account handle matches the default phone account)
PiperOrigin-RevId: 159870114
Change-Id: I19ef6b50db50f9961a486f48996427a1da8f8813
|
|
PiperOrigin-RevId: 159845977
Change-Id: I5615960a4d007924d3db64fc777c7a40593df612
|
|
|
|
https://googleplex-android-review.git.corp.google.com/#/c/2446830/
Test: TH, make
Change-Id: I39aba7e972bac6e5864e70ed693849d90ecd7e08
|
|
This will better handle the cases where a show/hide action is performed while the Bubble is animating.
PiperOrigin-RevId: 159771812
Change-Id: I87779da8c0360906587355279b3cc9674289e30f
|
|
Reports when a user sucesfully reports a number is inaccurate caller id and
when their report fails.
PiperOrigin-RevId: 159762210
Change-Id: I8507b4d2a3d4b6f3004e8145f4ba0f9e8065e5d7
|
|
Log which tab is presented when app first launched, including:
- speed dial
- call log
- contacts
- voicemail (if not available, we move to contacts tab immediately and log the
move)
Test: manual
PiperOrigin-RevId: 159754375
Change-Id: Ice5be6c0f2c0463204fe3c1c7cf83c4dfc7df5d1
|
|
When a user uses call composer for the first time, it isn't obvious that their
messages are being stored in the Android Messages app. So we display this toast
to them on the first time they make a enriched call to let them know for
privacy purposes.
screenshots:
http://screen/pcuu4GG037Z
http://screen/MLRJiY9V7cH
PiperOrigin-RevId: 159749893
Change-Id: I0cee7b49321f1d2302ba8ed8f6e1c19c44feb19a
|
|
Current auto fill content is usually the device's own number thus not useful
and it covers "1" key.
PiperOrigin-RevId: 159742824
Change-Id: I753832120bf9436506bf5394b47c94f94899a92b
|
|
b/62666193 is one of the top crashers, the assert that the VVM config is valid has failed. This is likely caused by the PhoneAccountHandle being invalid. While the PhoneAccountHandle must be valid when the broadcast is made, the SIM might have been removed and invalidated the PhoneAccountHandle when the broadcast is still in flight.
In this CL the validity is checked first.
PiperOrigin-RevId: 159737846
Change-Id: Iae5a65978879fd1bfdf726008e8b6463499c99e8
|
|
An empty string isn't as clear and can lead to incorrectly matching other
intents when just comparing package names.
PiperOrigin-RevId: 159725546
Change-Id: I2943b3569fb6409f5c69deb2032f3d8248f6c14d
|
|
TEST=N/A
Video: https://drive.google.com/a/google.com/file/d/0ByIs9UmqOFZFZjBsUS1HQVBxUUE/view?usp=sharing
PiperOrigin-RevId: 159637501
Change-Id: If1b088f7abff2ec52fd54fbbb36d6b7c6d54a926
|
|
We need to check that we have a Context before passing it to
RenderScript.create. getContext can return null if the fragment has been
removed.
I switched this to an early return approach to avoid the deep nesting and added tests.
It is safe to ignore the IfThisThenThat
PiperOrigin-RevId: 159633511
Change-Id: If2286a545c2e514c328dff22c48a99b9ed232e88
|
|
When a user deletes a call from the call log, it might not be clear that they
aren't deleting the attachments they made with the call. So we present them
with a snackbar letting them know to open android messages to delete
attachments.
screenshot: http://screen/TSoWmNhjcn4
screenshot: http://screen/vUXShdYpXem
PiperOrigin-RevId: 159631807
Change-Id: Iaad903258160dc789e0c6a524adba56299523636
|
|
This fixes a bug where we would remember being paused after receiving a second
call incorrectly after we swap back to it.
@tgunn, adding you here to double-check I am interpreting those call session events correctly.
PiperOrigin-RevId: 159623587
Change-Id: Ic52e3e9046f767321a48e22274b8a1c27b4dfa86
|
|
PiperOrigin-RevId: 159622902
Change-Id: Idabc3122601e442a07b31c38287af767651e9970
|
|
The WindowRoot now provides a listener for when the Configuration state changes. Bubble will then reinitialize the MoveHandler (to account for potential changes in screen bounds) and ensure the window is within bounds.
PiperOrigin-RevId: 159614123
Change-Id: Icace5b52299825836fb398ce1e6234ad0bb212f3
|
|
|
|
e4de90c6d9
am: cccd0a8597
Change-Id: I56fa753c4191d6969b75f4e22b2013eb56655a9f
|
|
|
|
*** Reason for rollback ***
It's not necessary anymore after we verified it could be controlled from server side.
*** Original change description ***
Flip flag to enable ReturnToCall bubble.
Enables ReturnToCall bubble and changes the name of the flag so that it can be toggled independently from previous versions.
***
Also in the change: Restore TODOs
Test: TH
PiperOrigin-RevId: 159587541
Change-Id: I88f01550f07a7859f41b4f0fc843e92b38f5a85b
|
|
Issue steps:
1. Show overflow menu in dialpad.
2. Press Home button, start another app such as Messaging.
3. Make phone call by Messaging app.
4. After the call is active, press home button and start Dialer again.
5. Dialpad is dismissed but popup overflow menu still shows.
Solution:
Dismiss popup menu when show dialpad chooser.
Credit to:
yifan.bai <yifan.bai@spreadtrum.com>
https://android-review.googlesource.com/#/c/417719/
Test: TH, manual
Change-Id: I019a799d52282bfb47a09d43cf25c14b053f8d9b
|
|
Copybara will do this on export.
Test: TH
PiperOrigin-RevId: 159512079
Change-Id: If47ac04c42f8cc1f56e5d761d4ab1f1b6f17b57e
|
|
BitmapFactory.createBitmap doesn't carry-over image exif data. We now
hold onto exif data and reapply it through matrix transformations so
images are displayed properly.
Test: TH
PiperOrigin-RevId: 159492684
Change-Id: Ief58f5fc506214e4a6afaf36a1be7dd53c712d4d
|
|
VVM activation state is required to suppress legacy voicemail notification. It should not be shown if VVM is activated. Before this CL this information is stored in credential protected storage, and cannot be accessed right after boot. Telephony might have a stale VM count and will attempt to refresh the notification after reboot, which will not be suppressed.
In this CL the activation state is moved to device protected storage. Other account info are sensitive and remain in credential protected storage.
Test: TH
PiperOrigin-RevId: 159492498
Change-Id: I918546cd9874e47c4aa96889aa35916ca6c59890
|
|
Number shouldn't be shown in bottom row if it's already shown on name row.
Test: TH
PiperOrigin-RevId: 159468064
Change-Id: Ieb3eff270d247dd712d2fbf6fe2428038ba643c3
|
|
An annoying part of development on enriched calling is that it was
difficult to determine what sessions were in memory. We have a
number of bugs related to incorrect sessions being shown, and knowing
exactly what sessions are available in memory can help debug them.
This CL adds a "Simulator" for enriched calling. This is more of a debug
tool than a simulator since it doesn't yet support adding a new enriched
calling session.
To allow the simulator to view all of the sessions in memory, a new
EnrichedCallManager API was introduced: getAllSessionsView. This API was
designed in a way to prevent abuse, so it returns a list of string
representations of the sessions. Just returning the full list of
sessions would have allowed clients to bypass the getSession logic and
examine sessions that shouldn't be available.
Also in this change:
* Integrate changes to form a base for future copybara imports.
Test: TH
PiperOrigin-RevId: 159445010
Change-Id: Ie8fc35d817a4e3b0eac37e0c34a6592060c43b23
|
|
cl/159428781.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/158012278 (6/05/2017) to cl/159428781 (6/19/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Merged-In: Ie60a84b3936efd0ea3d95d7c86bf96d2b1663030
Change-Id: If1fa394df2609f0d38b4f794c83f4db3f1006484
|
|
cl/159428781.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/152373142 (4/06/2017) to cl/159428781 (6/19/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: Ie60a84b3936efd0ea3d95d7c86bf96d2b1663030
|
|
cl/158012278. am: 91ce7d2a47"
This reverts commit c67d658e7daa453fe9ad9fd1a37f81eaf2048c44.
Reason for revert: This CL broke the sailfish-userdebug_javac-all target on master.
Change-Id: I9b54333a654c00154ca84f4ece84bea4f07cc19b
|
|
cl/158012278.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/152373142 (4/06/2017) to cl/158012278 (6/05/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I4d3f14b5140e2e51bead9497bc118a205b3ebe76
|
|
am: ae06b1b3b8
Change-Id: I37dfc5acf163aa0942803da64ec47629622580c4
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC45
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC45
This release contains the following bug fixes since RC39:
Bug: 38131932 38302993 38347350 38368993 38395481
62100344
Test: make, on device
Change-Id: Ib4af5dcc58c684d51ea1f4628b301e40184b81b3
|
|
am: 7f7f25f903
Change-Id: I9ecaf153cf214e099228ec43cdcf8b565129ff0a
|
|
From Tyler's investigation:
In the past (Marshmallow days) we used to call setCamera(null) as well
as sending the downgrade request. Stopping the video transmission is
one thing but I think the modem implementation depends on the camera
being nulled to clean up its resources.
(This CL is a manual cherry pick of cl/157154988 from google3 to
gerrit.)
Bug: 38395481
Change-Id: I7f71c1ffb7194165b8968cd4a033ffea1af443ed
|
|
am: 651d758b59
Change-Id: Ie6d59b702b6504c3957836597445c9b7c1bf7f72
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC39
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC39
This release contains the following bug fixes since RC32:
Bug: 38137349 38249439 38299262 38329114
Test: make
Change-Id: I65f695db8aa20902fa60835d58b41cfdfe42704b
|
|
ActionBarActivity has been deprecated for 2+ years and has been
extending AppCompatActivity for all that time. These changes
should be no-ops.
Bug: 35253513
Test: None
Change-Id: Ic87c8db6f9733fbcfa59d3bc08c77013799ae652
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC32
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC32
This release contains the following bug fixes since RC17:
Bug: 33176679 33272455 3646510 36773894 37297649 37413780
37513689 37640315 37680595 37698062 37873639 37901752
37919295 37953423 38062852 38069600 38137349 38173549
38180252 38191514
Test: make, on device
Change-Id: I4e4bb630082758e418ff24892b7db3142c6eb09a
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC17
Branch: dialer-android_release_branch/153304843.1
dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC17
This release contains the following bug fixes since RC16:
Bug: 37962346
Test: make, on device
Change-Id: I1852cc096ef242c7bfcd85b11f954ddb00903c39
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC16
Branch: dialer-android_release_branch/153304843.1
dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC16
This release contains the following bug fixes since RC00:
Bug: 37324705 35304403 36067503 35304446 33203808 37280992
37346084 35766990 37481880 37424493 36470282 37347691
37519015 37168472 35805360 37545472 27704934 36515614
35766990 37577470 34739750 35801628 36788693 35264204
36708536 37628370 36904650 37314436 37642171 37530847
37637799 37666625 37548549 37648036 37636412 37323529
37630507 35919141 37198343 37548572 36178218 37640315
37663896 37720467 37275944 37710497 31634477 37744796
37348506 37744796 37568534 37672424 34872683 34873026
37681461 34873295 37748373 37526812 37618638 37663896
37536088 37727455 37165687 36651204 36900708 37323529
36902926 37256480 37328353 37432034 37436952 34093562
37720889 37321935 37780300 37781115 37755902 36588206
34258266 37290464 37698062 37618638 37473004 37432034
37918676 37870494 37722091
Test: make, on device
Change-Id: I99e1a484ccd578c1f8a13e7a6a4b4952f0791297
|
|
RC00 is based on:
branch: dialer-android_release_branch/153304843.1
synced to: 153304843
following the instructions at go/dialer-aosp-release.
In this release:
* Removes final apache sources.
* Uses native lite compilation.
More drops will follow with subsequent release candidates
until we reach our final v10 release, in cadence with our
prebuilt drops.
Test: TreeHugger, on device
Change-Id: Ic9684057230f9b579c777820c746cd21bf45ec0f
|
|
Test: builds, boots
Change-Id: I223faf55c1e1b4d81d11b4c8b2d93ccd131c969b
Fixes: 37775662
Fixes: 37748635
Fixes: 37673408
Fixes: 37672564
Fixes: 37672218
Fixes: 37638323
Fixes: 37637423
|
|
cl/152373142.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/151342913 (3/27/2017) to cl/152373142 (4/06/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I2fbc88cf6867b90ac8b65f75e5e34468988c7217
|
|
cl/151342913.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/151128062 (3/24/2017) to cl/151342913 (3/27/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I8d4855628b62e9067e71f32ed40317617a1e3b02
|
|
cl/151128062
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/150756069 (3/21/2017) to cl/151128062 (3/24/2017).
Notable this release:
- Explicitly enumerate host and target dependencies.
- Update proguard flag references.
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Bug: 33210202 36511925
Addresses
33210202 - Proguard support
36511925 - Compiler warnings when building against platform sdk
Change-Id: I448ec3b3f2358886859cf7a4ef76a8fcef3244ae
|
|
cl/150756069
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/150392808 (3/16/2017) to cl/150756069 (3/21/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I0888b5db52efb28eb8194600e0c7804592f975f3
|
|
cl/150622237"
This reverts commit 06b6b56e9eaa91ebf757ea641e38a9c885fa40bd.
Change-Id: Ida8c5ee67669524dc63b9adc60a6dd392cb9b9a6
|
|
cl/150622237
Test: make, treehugger, on device testing.
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/150392808 (3/16/2017) to cl/150622237 (3/20/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: Id53e0e580a4ef73760a8afb7bb8c265ee27ad535
|
|
Test: Treehugger
Notable this release:
* Reintroduce localization.
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from 3/15/2017 to cl/150392808 (3/16/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: Ia16d68469c2ca1ff42c7fa31d922bdb78c4e244a
|
|
This reverts commit 1019500220518fb5fb023fcb7d370ab3cbf12307.
Change-Id: Ie6e4f81a995fca7345132b596521b0bd06ceffb9
|
|
Test: Treehugger
Change-Id: If2baab1d3fc2dee602a4f784bba532182e7174f5
|
|
* Refactor voicemail component
* Add new enriched calling components
Test: treehugger, manual aosp testing
Change-Id: I521a0f86327d4b42e14d93927c7d613044ed5942
|
|
Include libraries needed at runtime.
Remove autolink (bug b/35934614) which causes crash on launch,
missing webkit. Currently investigating.
Bug: 35934614
Test: Loaded on arm64 AOSP
Change-Id: I39abf56e422766ea6d9525c107aeb05768cdb002
|
|
Test: Built package and system image.
This change clobbers the old source, and is an export
from an internal Google repository.
The internal repository was forked form Android in March,
and this change includes modifications since then, to
near the v8 release.
Since the fork, we've moved code from monolithic to independent modules. In addition,
we've switched to Blaze/Bazel as the build sysetm. This export, however, still uses make.
New dependencies have been added:
- Dagger
- Auto-Value
- Glide
- Libshortcutbadger
Going forward, development will still be in Google3, and the Gerrit release
will become an automated export, with the next drop happening in ~ two weeks.
Android.mk includes local modifications from ToT.
Abridged changelog:
Bug fixes
● Not able to mute, add a call when using Phone app in multiwindow mode
● Double tap on keypad triggering multiple key and tones
● Reported spam numbers not showing as spam in the call log
● Crash when user tries to block number while Phone app is not set as default
● Crash when user picks a number from search auto-complete list
Visual Voicemail (VVM) improvements
● Share Voicemail audio via standard exporting mechanisms that support file attachment
(email, MMS, etc.)
● Make phone number, email and web sites in VVM transcript clickable
● Set PIN before declining VVM Terms of Service {Carrier}
● Set client type for outbound visual voicemail SMS {Carrier}
New incoming call and incall UI on older devices
(Android M)
● Updated Phone app icon
● New incall UI (large buttons, button labels)
● New and animated Answer/Reject gestures
Accessibility
● Add custom answer/decline call buttons on answer screen for touch exploration
accessibility services
● Increase size of touch target
● Add verbal feedback when a Voicemail fails to load
● Fix pressing of Phone buttons while in a phone call using Switch Access
● Fix selecting and opening contacts in talkback mode
● Split focus for ‘Learn More’ link in caller id & spam to help distinguish similar text
Other
● Backup & Restore for App Preferences
● Prompt user to enable Wi-Fi calling if the call ends due to out of service and Wi-Fi is
connected
● Rename “Dialpad” to “Keypad”
● Show "Private number" for restricted calls
● Delete unused items (vcard, add contact, call history) from Phone menu
Change-Id: I2a7e53532a24c21bf308bf0a6d178d7ddbca4958
|