summaryrefslogtreecommitdiff
path: root/java
AgeCommit message (Collapse)Author
2018-03-30Implement new blockingtwyen
Old blocking is deprecated. Bug: 70989544 Test: TAP PiperOrigin-RevId: 191086875 Change-Id: Icde4963fce603fc4e16e486b78c070bd439e26e4
2018-03-30Differentiate video call types (carrier/Duo) in call descriptions for the ↵linyuh
new UI. Bug: 70988686 Test: CallLogEntryTextTest PiperOrigin-RevId: 191071267 Change-Id: I392e3b4c47e266f0a553fe28079d4800fc174a8f
2018-03-29Use existing transcription from transcription server if availableuabdullah
Repeated requests from the server responds in an ALREADY_EXISTS error and does not transcribe the voicemails. In that case we should ask the server if the request is present already on the server, and if so retrieve it. Bug: 77236260 Test: N/A PiperOrigin-RevId: 191016332 Change-Id: I605c546a3bec3599c7b162853463ca7e46f63886
2018-03-29Update what happens when donation is rejected & use correct donation ↵uabdullah
availability check Checking donation is not a simple config check, but everything that donation availability is dependent on via the isVoicemailDonationAvailable() helper method. We update the code accordingly. When the user declines the promo for donation, we should also update the toggle accordingly. Bug: 74033229 Test: N/A PiperOrigin-RevId: 191011808 Change-Id: I6e4ff9914355deed72175179fc7b9009f2395ef5
2018-03-29UI adjustment to RTT screen.wangqi
1. Don't close overflow menu after menu item is clicked. 2. Add correct shadow and animation to overflow menu. 3. Only scroll when remote message is updated if input box is empty. 4. Only hide keyboard if scrolling up is triggered by user. 5. Add paddingTop to recyclerView so that first message won't be covered by toolbar. Bug: 70177426 Test: manual PiperOrigin-RevId: 191002774 Change-Id: Ic69f80323e3d31d7853d4e8d0c6e4c100fe4a776
2018-03-29Mark spam voicemail as old after we auto block it.Android Dialer
Bug: 77242856 Test: N/A PiperOrigin-RevId: 191002650 Change-Id: Ia74423f28a40f148d507fb9f907fc2e5c41fc183
2018-03-29Fix bug preventing rejecting video callsroldenburg
Bug: 75602772,77235335 Test: ImsVideoTechTest PiperOrigin-RevId: 190988177 Change-Id: I2f4883f6bf492b380ef839562fd65ff6ac630bfb
2018-03-29Fixed a few issues in search with new nav.calderwoodra
- back arrow in search now flips in RTL mode http://screen/1eccBLDqPp0 - search text no longer overlaps icons http://screen/Mq0omQEuZez - keyboard now always closes on pause - location permission is no longer visible in dialpad search Bug: 73088433,74784637,76117373,76440832,76441216 Test: keyboard and rtl tested manually, added test for location permission PiperOrigin-RevId: 190981686 Change-Id: Ia121d410c158df0de9cd731ab280a6d8e9b300d9
2018-03-29Replace png icons with vector drawable for video call screen.wangqi
Bug: 76221932 Test: manual PiperOrigin-RevId: 190948113 Change-Id: I4151ab3fc5231183d49fc1bdc247a09e5ffadc22
2018-03-29Badge contact photos for video calls in the bottom sheet.linyuh
Bug: 70988682 Test: Existing tests PiperOrigin-RevId: 190946639 Change-Id: Iaa8294e8ba6e85ab3c27bb2e67200d7972a240f2
2018-03-28Show toast when handing off from LTE to WiFiroldenburg
Bug: 65490850 Test: manual PiperOrigin-RevId: 190859631 Change-Id: I89aeb41a7709e9366367cdc54ba506e276685b5f
2018-03-28Create a common widget (ContactPhotoView) for a contact photo and its ↵linyuh
optional badge. Bug: 70988682 Test: ContactPhotoViewTest PiperOrigin-RevId: 190855440 Change-Id: Ib658efa6486b66548c710804049517905dc67b13
2018-03-28Remove unnecessary call to StatusBarNotifier.updateNotification().yueg
The call for incoming call is covered in StatusBarNotifier.onStateChange(). The two calls in InCallActivity is not useful (maybe is before notification becoming foreground). Test: manual PiperOrigin-RevId: 190845157 Change-Id: I0f84f15cfda5294566fa8976e09aac5163f85aa9
2018-03-28Update spam blocking promo wordings.Android Dialer
Bug: 75308663 Test: N/A PiperOrigin-RevId: 190825933 Change-Id: Iaf112cfec81c82e127d77aedba351788a03eee54
2018-03-28Replace assets "quantum_ic_videocam_white_24" with a vector asset.linyuh
Test: Existing tests PiperOrigin-RevId: 190820867 Change-Id: I4835bcbc7698075fb54015dccc6823ada4c71651
2018-03-28Delete dialer blocking in NUItwyen
System blocking should be used instead. These code are obsolete. Bug: 70989544 Test: TAP PiperOrigin-RevId: 190818334 Change-Id: I71475905ba110fdc0560991a2a9c2b9e2f2de9f2
2018-03-28Turn transcription on if new user accepts Dialer ToSuabdullah
When a user accepts the Dialer ToS for the first time, we should also enable transcription if it is available. Bug: 74033229 Test: N/A PiperOrigin-RevId: 190794147 Change-Id: I7eb9b3d481426aceb55a8990fdbd246101937e7b
2018-03-28When declining Transcription ToS, we should hide the feature ToS.uabdullah
When a user declines the transcription, we should turn off transcription and never show the transcription promo ever again. Bug: 74033229 Test: N/A PiperOrigin-RevId: 190790323 Change-Id: Ida60592b0550b18b28e7f7a7a22d19100f56231a
2018-03-28Badge contact photos in the new call log for video calls.linyuh
Bug: 70988682 Test: NewCallLogViewHolderTest PiperOrigin-RevId: 190783830 Change-Id: Ib0b1ec23b7c278b83516019924b6c68ff12adaf9
2018-03-27Support new call log fragment in old peer.zachh
This makes the old peer read the CallLogConfig#isNewCallLogFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewCallLog and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog and PhoneLookupHistory databases would be read, which would trigger creation. I don't expect this to be a common case because 1) we hopefully never have to disable the framework and 2) Framework is only updated on Phenotype broadcasts and JobScheduler jobs, which hopefully don't typically happen when user is viewing the call log. However, I still want to make sure that if it happens we don't irreversibly break users when we turn the framework back on. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the call log tab, speed dial tab, and while the activity was paused (pressing Home after viewing call log). Note that this CL doesn't address showing missed calls and badge counts correctly with the new fragment; that will come in a later CL. Bug: 74821995 Test: unit and manual PiperOrigin-RevId: 190706481 Change-Id: I618d9c1649169abd65733502cfebc662a835e787
2018-03-27Use CallLogConfig for enabling new peer.zachh
ConfigProvider should not be used directly for reading NUI flags as CallLogConfig needs to perform work when they change. Bug: 74821995 Test: existing PiperOrigin-RevId: 190698415 Change-Id: Ic084d9032d2a6f35ffba9f395eaaff9053cfa262
2018-03-27Turn on transcription when existing dialer user accepts ToS and ↵uabdullah
transcription is available. Also updated the isVoicemailAvailable helper method, since just checking if the flag and OS is not enough (we have other things such as is VVM enabled, is VM activated), if we don't do this, it doesnt make sense to turn on transcription e.g Why what would happen if transcription is turned on but vvm is disabled Bug: 74033229 Test: Added a todo, will be added later (there are a few more similar CL's that I am sending for other ToS conditions) to ensure the logic is correct for all ToS conditions first and I can add a test right at the end for all conditions. PiperOrigin-RevId: 190696695 Change-Id: I9cb063a97e11943abeb1f823dc661efe88dfa3f1
2018-03-27Turn off transcription when user declines tos (existing dialer user)uabdullah
When an existing dialer user is shown the ToS and they declines it, the transcription setting must be turned off, to respect the users wishes. We also no longer take the user to the settings page. Bug: 74033229,77147114 Test: Unit test PiperOrigin-RevId: 190682249 Change-Id: I8c0abf9f3cbb15ded12a760abe540c557fd2e7d3
2018-03-27Delete debugging logging statement in voicemail spam blockingAndroid Dialer
Test: N/A PiperOrigin-RevId: 190673495 Change-Id: I1587449f6b0b53e7a16aac0b334225649a94f27b
2018-03-27Add permission for in-call visibility changeroldenburg
Bug: 76445204 Test: n/a PiperOrigin-RevId: 190650130 Change-Id: I594a16676cfcca4e6a10c1f5bc6604509417ad23
2018-03-27When transcription setting is enabled, retranscribe voicemailsuabdullah
When transcription toggle is turned off, we delete all local transcriptions. However when it is turned back on, we should re-transcribe all those( previously transcribed, then deleted) voicemails again. Bug: 74033229 Test: N/A PiperOrigin-RevId: 190640972 Change-Id: Iaaf324e74c7630852daeb314f34c2c3095fe3196
2018-03-27Update T-Mo Transcription ToS for existing usersuabdullah
Adds the we can turn off transcription from settings. Bug: 76226374 Test: N/A PiperOrigin-RevId: 190626638 Change-Id: I22b56f133cc83749cdd52a4406be0c36c5a0d0ac
2018-03-27Update T-Mo Transcription ToSuabdullah
Adds the we can turn off transcription from settings. Bug: 76226374 Test: N/A PiperOrigin-RevId: 190623712 Change-Id: Ib2990f9ba025cc5a7f51ba7f7b7d85085327cae9
2018-03-26Remove TODOs left for M in the new call log as the min SDK has been bumped to N.linyuh
Bug: 72125574 Test: None. PiperOrigin-RevId: 190572832 Change-Id: I581d3c9e366a1190c1608b369700aeb511fe51d1
2018-03-26Change the maximum number of notifications per tag from 10 to 8.linyuh
For grouped notifications, the system UI only displays the last 8. Bug: 74132249 Test: NotificationThrottlerTest PiperOrigin-RevId: 190544350 Change-Id: Idc52f4e98c1262bcb16a7a5052829b0a0faaacc6
2018-03-26Replace png icon with vector drawable for voice call screen.wangqi
Icons in video call screen will be replaced in following change. Bug: 76221932 Test: manual PiperOrigin-RevId: 190534558 Change-Id: Ia8abb468c71ffa4f6322043bc3bbbbe475b20a1f
2018-03-26Fixed drag to remove favorite contacts on a few devices.calderwoodra
There were 2 issues at play here: 1) views not being able to leave the list view bounds 2) RemoveView not getting drag events. Their resolutions are: 1) add a drag drop listener to the root layout of the activity, now the view can be dragged anywhere. 2) Drag events are only sent to views that are visible, so we no longer set the remove view visibility to GONE and instead set it's contents to GONE. Bug: 76086197 Test: manual PiperOrigin-RevId: 190526568 Change-Id: I3360015f65a134a896601d6298d07163844e302c
2018-03-26Add 311910 to motorola sprint configs.twyen
Bug: 76405608 Test: TAP PiperOrigin-RevId: 190517564 Change-Id: If0de75264b9c604f6bdf9536997c95c3cee9e0b5
2018-03-26Remove obsolete methods in CompatUtils and rename it as "LocaleUtils".linyuh
Test: Existing tests PiperOrigin-RevId: 190516504 Change-Id: I5fa9e123b45beb9728257ecd160a348fb3f4732c
2018-03-26Placing a call from a search action now closes the keyboard.calderwoodra
Bug: 74784637 Test: impl PiperOrigin-RevId: 190515545 Change-Id: I70f2e6db078f3a83fc33e8493b6af143184fe736
2018-03-26Add Motorola hidden menu to all Sprint MCCMNCstwyen
Before this CL it is only added to 310120. The values are moved to the base values, and the overrides override the enabled flag instead. Multiple SPN matching is also added. Bug: 76405608 Test: TAP PiperOrigin-RevId: 190515244 Change-Id: Ia937f0300ade57dc7a1b36df1433865ee4837a23
2018-03-26Remove obsolete version checks and compat utilities after min SDK was bumped ↵linyuh
up to N. Test: Existing tests PiperOrigin-RevId: 190508397 Change-Id: Ia5f33e45af1d1cc666fec5f43efa564b2b68c193
2018-03-26Bump version codes and name to v20roldenburg
Test: n/a PiperOrigin-RevId: 190500474 Change-Id: I1d73a90bf37b36c454b2d72102193764f4e25013
2018-03-26Catch BadParcelableExceptiontwyen
This happens when an old dialer submitted a job and the newer dialer is trying to handle it. The class fingerprint changed so it can no longer be unparceled. In this CL, such tasks will be dropped. Bug: 64225192 Test: N/A PiperOrigin-RevId: 190491751 Change-Id: I90fe2d24a435201cfae09970387e9b1c3a58b094
2018-03-26Move spam setting related methods out of spam interface into a separate spamAndroid Dialer
setting interface. Test: All the existing tests PiperOrigin-RevId: 190314880 Change-Id: I030acbd70120f508c5a4616757d89113524110fa
2018-03-26Add logging support for auto blocked spam calls.Android Dialer
Test: N/A PiperOrigin-RevId: 190307083 Change-Id: Ifb0ee63d8d9c7cd247f2a2d36595e48f33fa72af
2018-03-26Switch setLabel and setLocationtwyen
Solves copy and paste error where call to setLabel and setLocation has been mixed up. Problem was introduced in: Ifb90019b6a5568788d51f4a55a07f7693c803eaf Bug: 76190741 Test: Verifies that phone number is correct in callscreen when calling contact Cherry picked from https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/648300 Bug: 76190741 Test: N/A PiperOrigin-RevId: 190305044 Change-Id: Ie268f02cabadc939e6a2e1f73ae4e126e314dc57
2018-03-26Forward extras from pre call external receivers to placeCall().twyen
All extras that CallIntentBuilder handles will be stripped and read into the builder. Other entries will be send to telecom when the intent is build. Renamed CallIntentBuilder.outGoingCallExtras for clarity. Bug: 72877810 Test: Unit tests PiperOrigin-RevId: 190301333 Change-Id: I9a8bf6664b270078d91dbfb3398f8990d243b9f8
2018-03-26Bumped a few more tests to N.calderwoodra
Bug: 73902692 Test: tap PiperOrigin-RevId: 190298092 Change-Id: Icb9f26a93b6e3c27a836442c48a9dd6f99124785
2018-03-26Check empty number before querying data ID for preferred accounttwyen
In call UI might use PreferredAccountWorker with a voicemail URI that has no numbers. Bug: 76205637 Test: Unit tests PiperOrigin-RevId: 190298082 Change-Id: I9949de5499958c408d6e1bf18cab6e77852d2487
2018-03-26Fix UK numbers in international format with extra 0twyen
See class comment on UkRegionPrefixInInternationalFormatHandler Bug: 32501490 Test: Unit tests PiperOrigin-RevId: 190296011 Change-Id: I6f01935f022fc288ad702735b38cb297fb9d2621
2018-03-26Cleaned up the AndroidManifest Intent Filters.calderwoodra
Bug: 75962274,75967273,75972847 Test: manual PiperOrigin-RevId: 190251834 Change-Id: I3673a6b20a886ded86dc4e1a8f75a82e5e0bb199
2018-03-26Removed NUI shortcut.zachh
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig. Other related changes to help accomplish this: -Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework. -Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest). -The "Main" package is also on longer needed since it existed to control the shortcut. Bug: 74821995 Test: existing PiperOrigin-RevId: 190251418 Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
2018-03-26Implement wifi emergency calling warningtwyen
The warning is shown when there is no service, and the carrier requires the message to be shown because they cannot make emergency call over wifi. Bug: 68030294 Test: Unit tests, integration tests. PiperOrigin-RevId: 190241868 Change-Id: Ia6b838ac1e8e62ad6b40d97c1cf1a970491c1e6f
2018-03-26Fix CallLogGroupBuilderTest after min SDK was bumped up to N.linyuh
Bug: 76154272 Test: CallLogGroupBuilderTest PiperOrigin-RevId: 190187854 Change-Id: Ib96c406c4bb0627729c24c58c526850ff4fda22f
2018-03-26Delete locally transcribed transcripts when transcription is turned off.uabdullah
When a user turns off transcription setting we should delete all the voicemails locally transcribed by google. We do this by deleting all the transcripts associated with the source package of the app. Bug: 74033229,76167428 Test: Unit Test PiperOrigin-RevId: 190159353 Change-Id: I328aece594aa0e66de59e43fa3619b5e9ae15f78
2018-03-26Show SIM auto select reason in in call UItwyen
The assisted dialed string will also along show with the "calling via" label. To handle the long string, Top row is now a marquee. Bug: 72571130 Test: Unit tests PiperOrigin-RevId: 190156719 Change-Id: I18a13712bdc9d780f744ef65a1773d249e40fb15
2018-03-26Correctly display phone numbers containing whitespaces in RTL context.linyuh
Bug: 74421656 Test: DialerBidiFormatterTest PiperOrigin-RevId: 190154072 Change-Id: Ic7cb3be702dd28b07b6e5e1e6d89f75f0bb12655
2018-03-26Add waiting for join banner to RTT outgoing call.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 190126654 Change-Id: I412f8fbf5b345005f9fb3651c345303d965e4e02
2018-03-26Allow user to delete previous bubbles.wangqi
After this change, user will be able to delete text in previous finished bubble. It will also correctly handle deletion from remote. Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 190122728 Change-Id: Ifebcbe874e5f03857d109b58e758e53f408e7e44
2018-03-26Increase minSdk to 24.calderwoodra
Manually set to M - MissedCallNotifierTest (not sure what the issue is here...) - CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown) - MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory)) Ignore Tests - a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason) - VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear) Bug: 73902692 Test: tap PiperOrigin-RevId: 190030202 Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
2018-03-26Delete old search, old contacts, p13n logger, filtered numbers add number ↵calderwoodra
search. These components are safe to delete because: - New Contacts has been in prod for several releases. - New Search has been in in prod for 2 releases. - p13n logger was based on old search and is no longer being implemented in Dialer. - Filtered Number Settings contact search since we no longer support M. Bug: 37208802,73902692 Test: tap PiperOrigin-RevId: 189992017 Change-Id: I2720a252ababd164b5d0fb1011753a3c96a704d1
2018-03-26Add learn more info to VM Transcription settinguabdullah
Updates the transcription setting from using a switch preference to a SwitchPreferenceWithClickableSummary. This allows the voicemail transcription setting preferences summary to be clicked and opened to the specified learn more url. Bug: 74033229 Test: Unit Tests PiperOrigin-RevId: 189983125 Change-Id: I1b162f3e2e582243fe8f84633e9401155170194c
2018-03-26Add RootComponentGenerator to auto-generate root components for different ↵Weijia Xu
dialer variants. Bug: 35612086 Test: Test included PiperOrigin-RevId: 189981890 Change-Id: Ife99969189d5d37bb1ad8ba61361a51e78abdfbb
2018-03-22Use SwitchPreferenceWithClickableSummary instead of SwitchPreference for VM ↵uabdullah
Donation The learn more link needs to be in the summary of the switch preference, however having a hyperlink in the summary text view of a switch preference does not open the hyperlink. To do this we made our custom switch preference which allows the summary to be clicked. All other aspects of the switch preference remain the same. Bug: 74033229 Test: Unit test PiperOrigin-RevId: 189978676 Change-Id: I31e744f3545e576ee3f5ac4a8fee249e22835e19
2018-03-22Removed appContext from CallLogDataSource and PhoneLookup.zachh
Impls can access appContext via dagger. Test: existing PiperOrigin-RevId: 189974157 Change-Id: Ie64d2c6f9ba08fc914d3c31f7e014c2beef3ab00
2018-03-22Show VM activating in settingsuabdullah
When a user enters the voicemail settings page and the voicemail is still being activated, we need to show the "Activating...." string to tell the user that something is still happening. This is important since unless the activation has happened, other settings are not visible e.g transcription and donation Bug: 76107888 Test: N/A PiperOrigin-RevId: 189970472 Change-Id: Ib9eeee64cd67c2adc4830a743516851ffa637fbf
2018-03-22Enable and disable the call log framework on flag changes.zachh
Bug: 74821995 Test: unit PiperOrigin-RevId: 189969399 Change-Id: I8e287cc7884dde7640721bd385fe383a4635f3c8
2018-03-21Display "Emergency number" in the call log for emergency numbersmaxwelb
This CL updates the call log to show "Emergency number" for call log rows from numbers that PhoneNumberUtils.isEmergencyNumber considers to be emergency numbers. Bug: 66926712 Test: Manual, see above PiperOrigin-RevId: 189953302 Change-Id: Ibaae243ead8b918a26f6058164316e042a4f82fd
2018-03-21Show error when finding location time out.yueg
If we get no location data for emergency call, we used to show spinner forever. This change shows error after 5s with no data, but still tries to get location. Test: LocationFragmentTest PiperOrigin-RevId: 189946803 Change-Id: Iaa0b429eec806337b9ab9cae3ca95e737fc667bf
2018-03-21Remove "contacts/common" from the dependency list of package "dialer/widget".linyuh
Bug: 74421656 Test: Existing tests PiperOrigin-RevId: 189935875 Change-Id: I834e15b7ff102ea021d7a99ebe568998a9c43603
2018-03-20Add more boilerplate to the incallui.erfanian
Bug: 73774242 Test: unit tests where they exist PiperOrigin-RevId: 189853302 Change-Id: Ibf3431cc0d7716c2c53c7ea165dfc130102a1bc7
2018-03-20Added "clearData" to CallLogDataSource and PhoneLookup interfaces.zachh
This is necessary to disable the call log framework via flags. This isn't yet called anywhere. Bug: 74821995 Test: unit PiperOrigin-RevId: 189838957 Change-Id: I926c02c41151528eabc208c874acbfe7897a2f93
2018-03-20Identify MMI codes specific to some OEM devices via hard-coding.linyuh
Bug: 72162360 Test: SpecialCharSequenceMgrTest, TranssionUtilsTest PiperOrigin-RevId: 189825957 Change-Id: Ia161ad47c4122d33c108b545540707bb18076464
2018-03-20Mitigate some of the jank in opening/closeing search.calderwoodra
There is still some jank on first open, but it's much less janky on close and consecutive open calls. Test: existing tests confirm no regressions PiperOrigin-RevId: 189802733 Change-Id: I49d6c2def7c33be0fdbb79c89772a5e4513cde3b
2018-03-20Fix animation of first time showing dialpad FAB.wangqi
In order to correctly show animation, we have to ensure: 1. fab.scaleIn() is not called before dialpad is slide up. 2. fab is invisible before scaleIn is called. Caveat: This change is not tested on old UI (DialtactsActivity) since it's deprecated. Test: manual PiperOrigin-RevId: 189765153 Change-Id: Iada96b2789f96ca1612ae2048020a649f8b57b6b
2018-03-20Added unregisterContentResolvers() to CallLogDataSource and PhoneLookup.zachh
This is needed to support flag changes which should cause the call log framework to become disabled. It's not called anywhere yet. Bug: 74821995 Test: unit PiperOrigin-RevId: 189761665 Change-Id: I914c690448f03ebacd7d05c9ad082aba7bf1a4ce
2018-03-19Make the top row of the bottom sheet not clickable.linyuh
Test: Existing tests PiperOrigin-RevId: 189683790 Change-Id: I0209e7fa839175041da29e9a6d8a590133121376
2018-03-19Convert @AutoValue VoicemailEntry to a protolinyuh
Test: Existing tests PiperOrigin-RevId: 189678764 Change-Id: I6b9edd99e727788c65d325c1be43f0190c25c30e
2018-03-19Convert @AutoValue CoalescedRow to a protolinyuh
Test: Existing tests PiperOrigin-RevId: 189675976 Change-Id: Ieae92b5ac2aefd3f0397bbb07ebb1c97bd72ed42
2018-03-19Show spam blocking promo after block spam dialogAndroid Dialer
Test: SpamBlockingPromoHelperTest PiperOrigin-RevId: 189674918 Change-Id: I0b22eb9b8128125cc5b439674099820a01c3889f
2018-03-19Implement call commandtwyen
NUI dialpad is still broken. Test: Unit tests PiperOrigin-RevId: 189674304 Change-Id: I58d114ed45839f8ff85a3a0e48c3d200337915c9
2018-03-19Add spam blocking setting related operations in spam moduleAndroid Dialer
Test: InAppSpamTest PiperOrigin-RevId: 189670786 Change-Id: Ie7bf394ecc02ac647211f7375faaf3e1b48ad7dd
2018-03-19Added polling job for CallLogConfig.zachh
Bug: 74821995 Test: unit PiperOrigin-RevId: 189670163 Change-Id: Ifdfcab7dc4493cbe688ef77d43df7e7a1400fa27
2018-03-19Implement VoicemailDataSourcetwyen
This data source determines if the call is to the voicemail inbox. isVoicemail() is removed from NumberAttributes and PhoneLookup. It is yet decided how in call UI should handle voicemail calls in the future. TAG_CHANGE_OK=proto not in prod yet. Please clear app data. TYPE_CHANGE_OK=above Bug: 70989587 Test: Unit tests PiperOrigin-RevId: 189650273 Change-Id: Iafebf1abb18c74301b62a72d1d04deecd6d78d29
2018-03-19Watch for phenotype flag changes and update CallLogConfig.zachh
Bug: 74821995 Test: unit PiperOrigin-RevId: 189648655 Change-Id: I9918bd6f35bf7eb1bebb9862c2d78880457efa91
2018-03-19Check null for getPhoneAccount()twyen
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null. Other usages already has the null check. Bug: 75598828 Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause. PiperOrigin-RevId: 189644833 Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
2018-03-19Check null for getPhoneAccount() in VoicemailChannelUtilstwyen
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null. Bug: 75598828 Test: In a follow up CL, where all instance of these will be fixed. PiperOrigin-RevId: 189635573 Change-Id: I897db6e8e7706bc8afe6f25d89fd2ca4405900df
2018-03-19Fix bug that dialpad fab wifi calling icon not showing.wangqi
Repro steps: 1. open dialer, click on FAB to open dialpad 2. make outgoing call, end call, press home 3. enable WiFi call 4. open dialer again, click on FAB to open dialpad This is caused by change icon called after the FAB is visible and scaleIn won't do anything since it's already visible. But for some reason the icon is changed so nothing is drawn on the screen when the dialpad slide up. (dialpadfragment is visible even before it's slide up before user trigger it) The fix is to scaleOut the FAB when the fragment onStop thus the changed icon will be correctly drawn. Bug: 74586190 Test: manual PiperOrigin-RevId: 189629441 Change-Id: I3dcbedcd171c992e5df14bff35758fce1bb67bc1
2018-03-16Check if parent is null since fetch call can be called while Dialer is paused.calderwoodra
Bug: 73972084 Test: n/a PiperOrigin-RevId: 189418664 Change-Id: I3dadea08dad1f2a594f5a7e0daf055721c3222a3
2018-03-16Refactor VM Settings and add support for voicemail transcriptionuabdullah
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following: - ensuring that when the VVM toggle is turned off, transcription and donations are gone. - when transcription is off, donation preference is gone. - donation is only available when transcription is available and enabled - as part of the refactor, fixes existing logging bugs - breaks preferences and its associated methods into helper methods when possible - groups relevant preferences together when possible Bug: 74033229 Test: Unit tests PiperOrigin-RevId: 189418217 Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
2018-03-16Use single return to break bubble of RTT chat.wangqi
Also change "done" button to "send" in input box and disallow multiple line since return will be interpreted as "send". Bug: 67596257 Test: manual PiperOrigin-RevId: 189409725 Change-Id: I3d3bf3e11cd04d6689125399f4567e88ee3f28f0
2018-03-16Make MainActivity the default activity for AOSP.calderwoodra
This also finishes moving all of the old tests over from Dialtacts to Main. The only 2 tests that fail are: - searchBoxClosedWhenHandlingNotificationIntent - openSearchFragment_fabGoneInRegularSearchAfterRotation I will fix these in a follow up CL. Bug: 72525887 Test: dialer_aosp build target launches MainActivity, TAP PiperOrigin-RevId: 189408987 Change-Id: Ice30191d95c19c62bcd89503e89f66440f30beac
2018-03-16Remove contact id from all non-local directory contacts.calderwoodra
Bug: 72755010 Test: manaul PiperOrigin-RevId: 189408046 Change-Id: Ia23442b2243e2008042e0046a21f840a30dbf008
2018-03-16Use current county ISO for PhoneLookupHistoryRecordertwyen
Previously it is unclear what the "county ISO" should be so the originating county of the SIM is used. When telecom writes to the call log the county the user is in is used. This caused the DialerPhoneNumber key in in call UI and call log to differ and info to be lost. In this CL, the current country is used in PhoneLookupHistoryRecorder to make it consistent with the call log. PhoneLookupHistoryRecorder is currently the only consumer for telecom call util.getCountryCode(). Additionally, dialer/location no longer depends on dialer/util. dialer/util has too many unnecessary dependencies that will cause cycles. Bug: 73752730 Test: Unit tests PiperOrigin-RevId: 189378542 Change-Id: I59773f7745c835a6523efda951c475e2fde9aaf9
2018-03-16Add Cequint contact lookup result type.wangqi
Bug: 73741286 Test: none PiperOrigin-RevId: 189377028 Change-Id: Ifb9c6375d0026fb012ae868741b471f2ca02c5f9
2018-03-16Work contacts quick contact badge no longer crashes.calderwoodra
Apperently contact ids are invalid for work contacts, so the URI needs to exclude them. Bug: 72755010 Test: manual PiperOrigin-RevId: 189374262 Change-Id: Ibeaa555dc035e14ea67905c342369188ecfd1832
2018-03-16Check if dialpad is already open when handleing new intents.calderwoodra
If the user had the dialpad open when they received a call, they could potentially crash dialer if they pressed add call or clicked on a phone number in another app. Bug: 74711879 Test: manual PiperOrigin-RevId: 189371425 Change-Id: I14df55e2467be07dd30e3971004e601216f57daf
2018-03-16Use a vector "unblock" icon in the bottom sheetlinyuh
Bug: 73133096 Test: ModulesTest PiperOrigin-RevId: 189303135 Change-Id: Id92d65e4c0bbb3c325c9d89d41d0645df19cde06
2018-03-15Restore delete call log item logging in call details.calderwoodra
This was accidentally removed in cl/176677167. This change restores the logging in call details and also adds it to the call log menu. Bug: 73774284 Test: OldCallDetailsActivityIntegrationTest, CallLogActivityIntegrationTest PiperOrigin-RevId: 189279107 Change-Id: Iadda16d7f1e4d720f828b5a72f210bcb8029f939
2018-03-15Close keyboard when placing a call to nearby places and remote contacts.calderwoodra
Bug: 74784637 Test: manual PiperOrigin-RevId: 189276349 Change-Id: I27b0f911ab5165f902bef017e8c09276441a9dee
2018-03-15Adjust bottom nav margins, sizes, ect.calderwoodra
Test: n/a PiperOrigin-RevId: 189274795 Change-Id: I495e326ce74568d8add739275562284ef12e276f
2018-03-15Resolve all build resource conflicts.calderwoodra
For simplicity, instead of resolve the nui shortcut string, I deleted it since it isn't used anymore. Test: build log PiperOrigin-RevId: 189260472 Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
2018-03-15Add utility used to style content with learn more linksmaxwelb
Bug: 74017355 Test: ContentWithLearnMoreSpannerTest PiperOrigin-RevId: 189252365 Change-Id: I3464fb56b86a6b3ddd25e9eed14152eaeed9925c
2018-03-15Remove deprecated android.graphics.Canvas APIsAndroid Dialer
Bug: 73777445 Test: TAP PiperOrigin-RevId: 189225531 Change-Id: I806be1c2a05d842b4991a9c95c19238f999d814d