summaryrefslogtreecommitdiff
path: root/java/com
AgeCommit message (Collapse)Author
2017-11-13Add a new impression proto for same prefix call marked as spam.Android Dialer
Test: LoggerUtilsTest PiperOrigin-RevId: 175555340 Change-Id: Ic38e4e60559d91d3471629a5ffff496081fb5fb9
2017-11-11Implement PreferredSimFallbackProvidertwyen
The PhoneAccountHandle is keyed with the DATA_ID of a Phone row in the Contacts provider. Bug: 64213352 Test: PreferredSimFallbackProviderTest PiperOrigin-RevId: 175354818 Change-Id: I828ff9d5a1e03e18b05256bcf8a61170be8ce7bc
2017-11-11Use lambdas in CompositePhoneLookup.zachh
They should work now that we target guava 20 instead of 18 in AOSP. Test: tap PiperOrigin-RevId: 175354039 Change-Id: Id7844c3a1c8e29e5ecb13fa36a92dd80be0cfc7c
2017-11-11Adjust weights of layouts on the dialpad so that key letters aren't clipped.linyuh
Bug: 30215380 Test: Manual PiperOrigin-RevId: 175342952 Change-Id: I0e0318c5471605dfc47553552f558c65d41f9e9e
2017-11-11Fix bug that "+" is dropped when performing actions in smart dial search.wangqi
This is caused by normalizing numbers from dialpad search into search box, while "add new contacts" and "send sms" etc. wouldn't work properly without full number. This change also fix "send sms" in old search fragment. This change includes upstream change from: https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/530377/ Change address format when sending message from smart dial In Android O, send search key number as address to message app. In Android N, send real input number as address to message app. Fixed the issue by reverting to Android N implementation. Affected Area: Send SMS operation from Dialer smart dial search result list. Bug: 68962106 Test: manual PiperOrigin-RevId: 175317850 Change-Id: I96dd576144f93f7502977bfdb4b9e9d9c8f73526
2017-11-11Use parent message for CP2 info in phone_lookup_info.proto.zachh
PhoneLookupInfo should contain one message per PhoneLookup implementation for clarity. Instead of having a repeated Cp2Info field, we now have a single Cp2Info field which wraps a repeated Cp2ContactInfo field. Also added ApdlInfo to the message to make testing of CompositePhoneLookup more realistic, in that it tests merging across submessages now. (ApdlInfo is more or less a placeholder until ApdlPhoneLookup is implemented.) Test: yes PiperOrigin-RevId: 175316738 Change-Id: I196c2eaa885e1268ff80ebaad6d85840a9cc7a15
2017-11-11Added content provider for PhoneLookupHistory.zachh
Bug: 34672501 Test: yes PiperOrigin-RevId: 175243488 Change-Id: Iec3b5eb0e81f6e6cc04c64c3ea65c9c7fcb33fe3
2017-11-12Use type TEXT instead of STRING for annotated call log columns.zachh
The declared type of "STRING" has an affinity of NUMERIC, not TEXT per: https://sqlite.org/datatype3.html Bug: 34672501 Test: existing PiperOrigin-RevId: 175237916 Change-Id: I220a35f3060eb60870f6e930c821bdb2f6d2c7ed
2017-11-12Stop turning on the screen when the incoming/outgoing call is via Bluetooth.linyuh
Bug: 38453773 Test: InCallActivityTest PiperOrigin-RevId: 175230358 Change-Id: I2460308e1af554e2198c256fb1f4c62d2b8124b2
2017-11-12Filter out contacts with null primary display names in search.zachh
Bug: 68848807 Test: unit PiperOrigin-RevId: 175190786 Change-Id: I15b525951cb87afb8b48f3bdb2174605c94c99cf
2017-11-12Conferece call management screen UI adjustment.yueg
Including: - change action icon color - hide TextView for name if name is empty - if name is empty, use number to generate avatar - don't show number type Bug: 67053842 Test: manual PiperOrigin-RevId: 175188810 Change-Id: I4ba40e5332d7b8567932360d36c8dc6ec3d604a5
2017-11-12Renamed string.xml to strings.xml to match Android conventionroldenburg
Bug: 68844134 Test: n/a PiperOrigin-RevId: 175102999 Change-Id: I63e930809d4bb96669062f724fb9cab90d675afa
2017-11-11Add UiThreadExecutorZachary Heidepriem
This CL adds an executor which runs tasks on the Ui thread, using the existing ThreadUtil class. Bug: 67752611 Test: UiThreadExecutorTest PiperOrigin-RevId: 175046280 Change-Id: Iff15e216be0e91891a9d63fddf1288ecbec41f83
2017-11-11Expose tab index to protectedAndroid Dialer
Bug: 68840377 Test: manual verify no regression from inconsistently showing promo PiperOrigin-RevId: 174957368 Change-Id: I0ed4fa1b24e693e91705744f60a7a385385cec64
2017-11-11Added temporary logging to debug problem with null phone numbers from remote ↵zachh
contacts. Bug: 68942044 Test: none PiperOrigin-RevId: 174944384 Change-Id: Ie03ce41e517cfb73081231898a7e9dcc3feee2f2
2017-11-11Hook up pre-call actionstwyen
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction. Bug: 64216442 Test: manual PiperOrigin-RevId: 174924323 Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
2017-11-11Implement CallingAccountSelector and AssistedDialActionZachary Heidepriem
CallingAccountSelector examines the CallIntentBuilder, and if the PhoneAccountHandle is missing on a multi-SIM device while the default is not set, it will show a dialog to let the user select it. This step used to be after the in call UI is launched and telecom wants dialer to disambiguate. This step is moved to pre call as dialer need more control, like voicemail calls should always prompt, or the preferred SIM info might be available. This also allows telecom to send the selected PhoneAccountHandle to other apps so they have more information on how to rewrite numbers. AssistedDialAction replaces the step previously in CallIntentBuilder.build(), and rewrites the URI. Pre-call actions are not hooked up for dialing in this CL yet, assisted dialing will still be broken. Bug: 64216442 Test: CallingAccountSelectorTest, AssistedDialActionTest PiperOrigin-RevId: 174917321 Change-Id: Iba2e9092f83c036b402d4044a48ff5c44e806210
2017-11-11Implement PreCallCoordinatortwyen
When the user makes a call, the PreCallCoordinator will get a list of actions to perform from PreCallActionProviderComponent and apply them to the pending CallIntentBuilder, before sending the built intent to telecom Bug: 64216442 Test: PreCallExecutorImplTest PiperOrigin-RevId: 174911537 Change-Id: Ide5ec431d4e6e7879fcdfdbbbd7ea5eed9963b2c
2017-11-11Make CallIntentBuilder parcelabletwyen
Multi-SIM and several other new features requires additional user input (ie. select the phone account to call with) or processing (ie. rewrite phone number for assisted dialing) before the call is actually made. The plan is to use a chain of pre-call actions to complete the dialing infomation,with the CallIntentBuilder holding the intermediate steps. For example, a pre-call action can examine the CallIntentBuilder and figure that the PhoneAccountHandle cannot be inferred, and show a dialog for the user the select it. Only after pre-call actions are completed, the intent is built and sent to telecom. Since pre-call actions involves dialogs and the process can be interrupted, the CallIntentBuilder must be persistable so the state can be restored. This CL made it parcelable so it can be stored with onSaveInstanceState(). The AssistedDialingMediator in CallIntentBuilder is temporarily removed as it would be called using a pre-call action in a future CL. Bug: 64216442 Test: CallIntentBuilderTest PiperOrigin-RevId: 174902775 Change-Id: Icf2f8fae620868d1a2f5acf0d08ae0a6bec4fb76
2017-11-11Use layout_gravity to horizontally center each dialpad key in landscape mode.linyuh
Test: Manual PiperOrigin-RevId: 174792372 Change-Id: I80ff3852c40cd532fdd2ed332e8b84ffb211a6e2
2017-11-11Unify voicemail call placingtwyen
All voicemails are called by using CallIntentBuilder.forVoicemail() so the PhoneAccountHandle can be designated. A future CL will use dialogs to customize the call (multi SIM selection, RTT, etc.) As a result voicemail error messages and legacy voicemail notifications will call the account it is received from directly. Bug: 64216442 Test: Unit tests PiperOrigin-RevId: 174784322 Change-Id: Ibe1c57bc7852e3d55a39a0cc2da19b6a79954c0f
2017-11-11Stop storing device orientation in DialpadView's instance variable to ↵linyuh
improve reliability. Bug: 68941995 Test: Manual PiperOrigin-RevId: 174782574 Change-Id: I93f358507f1f60b87e26e1bdcddf50ed1ef8e1b2
2017-11-11Rename value name to avoid conflict.yueg
Test: None PiperOrigin-RevId: 174782468 Change-Id: Iaf842b35f6f5fa4ac0e1505ce39e7470fb23b51d
2017-11-11Fix previous usage of LoggingBinding with Logger class.weijiaxu
Test: In dialer lab. PiperOrigin-RevId: 174781953 Change-Id: I987c0d191a7c5613debb857bab9438d0c1aa20a7
2017-11-11Disable "Switch Camera" button when not transmittingroldenburg
Author: Ravi Paluri <rpaluri@codeaurora.org> Bug: 68677786 Test: CallButtonPresenterTest PiperOrigin-RevId: 174740252 Change-Id: If20e9fb92c4d729a75edf8ac6d088a88d4d319d8
2017-11-11Updating SendTranscriptionFeedback for consistency.Android Dialer
Bug: 68900535 Test: SendTranscriptionFeedbackActionTest PiperOrigin-RevId: 174732357 Change-Id: I9a99606a13cfc32f53a6ce8a15ad258bb48d7130
2017-11-11Add expand and collapse media player logic for NUI Voicemail Fragmentuabdullah
This adds a file called new_voicemail_media_player_layout.xml that can be expanded and collapsed on tapping the voicemail entry. This file will later be updated in accordance with the specs, but the logic for expansion and collapsing would not be affected by the future cosmetic change. Video=https://drive.google.com/open?id=1aIpmVfUYrFrg_FZ4tRX_TX6pU9YgPQaN Bug: 64882313,68382421 Test: Unit Tests PiperOrigin-RevId: 174713873 Change-Id: I15a6c5f01715429a6eb51fee447a5b42f25fdb56
2017-11-11Defining transcription feedback APImdooley
Bug: 68712148 Test: none PiperOrigin-RevId: 174535170 Change-Id: I436335d142f369f8e7c3249463117ffd5c00d6b4
2017-11-11Added phone paused icon to on hold banner.calderwoodra
Public-Origin-Change-Id: If22474d96ee53ce4f7c31fac828fb56022f4fa49 Signed-off-by: Allen Calderwood <calderwoodra@google.com> Author: Kitta Koutarou <koutarou.x.kitta@sonymobile.com> Bug: 62440523 Test: manual PiperOrigin-RevId: 174532793 Change-Id: I436307d42f42387c3d37eb79c99ef9200703d57f
2017-11-11Implemented CompositePhoneLookup#bulkUpdate.zachh
Bug: 34672501 Test: unit PiperOrigin-RevId: 174532642 Change-Id: I0115fb26f99fe764bc90625e3ed51f3c4c99439d
2017-11-11Allow the client to specify voicemail transcript id'smdooley
This is needed for rating transcription quality since we don't persist the transcript id. The id we generate is just the md5 hash of the voicemail audio data. Bug: 68712148 Test: manual and updated unit tests PiperOrigin-RevId: 174527907 Change-Id: I7a29bf5a96447129fc1437074f20ecebcdb1f43b
2017-11-11Implement bulk update for Cp2PhoneLookup.calderwoodra
Test: Cp2PhoneLookupTest PiperOrigin-RevId: 174525877 Change-Id: I7888f3b6adc58416c560271166ec6bd85306d58b
2017-11-11Add character mappings for Bulgarian & Ukrainian in DialpadCharMappings.linyuh
Bug: 30215380 Test: Manual PiperOrigin-RevId: 174493347 Change-Id: I06d5d3d8877ac29d148b3945e28dc0a094660eca
2017-11-11Support dual alphabets in smart search when a secondary alphabet is available.linyuh
Bug: 30215380 Test: QueryBoldingUtilTest, QueryFilteringUtilTest, ContactFilterCursorTest PiperOrigin-RevId: 174408771 Change-Id: I4c601b16dd90db6b7b2a05c9daa6804749ea2a43
2017-11-11Commit transaction synchronously for OnHoldFragment.yueg
We show OnHoldFragment for new conference call, and remove it after updating info. After cl/172475223, the update only happens once and sometimes removing the fragment happens before adding the fragment. Committing synchronously fix the bug. Test: manual PiperOrigin-RevId: 174374676 Change-Id: I5337f6592ca2924ed6a089ecaefe00d920f85738
2017-11-10Expand Voicemails on tappinguabdullah
Currently we only show as much of the voicemail transcription, as we can see on the first line. This CL allows us to tap the voicemail, so that it is expanded and the whole transcription is now visible. Bug: 68382421,64882313 Test: Unit Tests PiperOrigin-RevId: 174267231 Change-Id: I19d3dea028c06d7c31aeb2949a19360eff648dcd
2017-11-10Implemented CompositePhoneLookup#isDirty.zachh
IsDirty is implemented by (possibly in parallel) executing all child lookups, and completing as soon as the first lookup reports itself as dirty, cancelling other lookups upon completion. If a lookup fails for some reason, it is treated as not being dirty. This required adding a new method DialerFutures#firstMatching. Bug: 34672501 Test: yes PiperOrigin-RevId: 174261470 Change-Id: Icb4f7b5d9926094fc446542411d15d02a4b873a3
2017-11-10Fixed AOSP breakage due to incompatible guava api.zachh
Test: none PiperOrigin-RevId: 174258291 Change-Id: Idf4eb0096fef383bd5f3544fdedba03528d14f41
2017-11-10Implement some UI changes.yueg
Including: - merge end call button with other buttons - add ripple effect for buttons - adjust elevation according to material design guide - add triangle in expanded view Bug: 67605985 Test: manual PiperOrigin-RevId: 174253861 Change-Id: I7b5315245a322235efb39a9cda26b8686cc7bbf9
2017-11-10Stop ringtone when user opens "respond via message" optionroldenburg
Ringtone should be stopped if user uses the "respond via message" option because user already notices the incoming call and user just feels the ringtone is noisy. Author: Takeshi Tanigawa <takeshi.tanigawa@sonymobile.com> Bug: 63089671 Test: AnswerFragmentTest PiperOrigin-RevId: 174249368 Change-Id: I2c6353cd662f23c20ac3ce873c38f18e8378b0a9
2017-11-10Fixing bug in donation settingsmdooley
in cl/173731907 we added a setting for donating voicemails, but didn't distinguish between when this feature is enabled/disabled by the user or by configuration. this cl fixes that by adding a method to check if the feature is available (ie enabled by config). Bug: 62423454 Test: manual and unit test PiperOrigin-RevId: 174245260 Change-Id: I45a59de7f4a171d759e2fcf86db27a100a84de67
2017-11-10Set the ceiling at O.erfanian
Test: no PiperOrigin-RevId: 174239092 Change-Id: I6672c5b0a41df6426b527d1565f0cb216dc82917
2017-11-07Fixed that name mixed Hebrew is not displayed correctly at call logerfanian
The display name mixed with Hebrew and English is not displayed correctly at call log, because the TextDirection of the display name area is not set correctly.　Fixed by correctly setting TextDirection. Affected Area: Direction of display name of call log list. Bug: 68024853 Public-Origin-Change-Id: I3fb0e248d380d5431a8026b8491534b46911af99 Signed-off-by: Eric Erfanian <erfanian@google.com> Author: yuichiro fujiwara <yuichiro.fujiwara@sony.com> Test: manual PiperOrigin-RevId: 174200487 Change-Id: Ib2d207ebb91a99662e4156f84c696caca82f877a
2017-11-07Show dual alphabets on the dialpad if a secondary alphabet is available.linyuh
Bug: 30215380 Test: Manual PiperOrigin-RevId: 174197504 Change-Id: Ide61f65a9dc1c104fa5bf136143c34e193c21396
2017-11-06Move voicemail settings to dialer UIZachary Heidepriem
The voicemail module should not contain any UI code. Bug: 37258159 Test: DialerSettingsActivityTest,VoicemailSettingsFragmentTest. A future CL is refactoring VoicemailChangePinActivity into a fragment. PiperOrigin-RevId: 174125949 Change-Id: I89cf6a083b0a0952332440d76e7ae0cb1c801931
2017-11-03Show HD icon in call logs.wangqi
This change removes restriction of showing HD icon only for some Motorola devices. After this change, any devices writing android.provider.CallLog.Calls.FEATURES_HD_CALL into call logs' feature will be able to show HD icon. To be able to write HD features into call logs, both CarrierConfigManager#KEY_DISPLAY_HD_AUDIO_PROPERTY_BOOL and CarrierConfigManager#KEY_IDENTIFY_HIGH_DEFINITION_CALLS_IN_CALL_LOG_BOOL must be enabled. It's part of upstream change to enable HD icon in call logs: https://android-review.googlesource.com/#/q/topic:hd_icon_call_log Bug: 68108125 Test: none PiperOrigin-RevId: 174091763 Change-Id: I17c62153ebbc866c91acdaa7a7fcbd124594772b
2017-11-03Add avatar and small icon in bubble primary button.yueg
Bug: 67605985 Test: NewBubbleIntegrationTest, NewReturnToCallControllerTest PiperOrigin-RevId: 174089572 Change-Id: Icaeb41482cffe522e09ee1ec068b5d47f476b146
2017-11-01Renamed call_details string, which was conflicting with one from the ↵zachh
calldetails package. Test: tap PiperOrigin-RevId: 174084052 Change-Id: I10c07767392060fafed048a74df5aece4090cd68
2017-11-01Update heads up notification based on video stateroldenburg
Refresh heads up notification to show only accept and reject options when incoming Video call is handed over to CS. Author: Suresh Koleti <skolet@codeaurora.org> Bug: 63157046 Test: StatusBarNotifierTest PiperOrigin-RevId: 174077146 Change-Id: Ic74d5a201392c6764ee33f1512bf528f86b80f69
2017-11-01Add more log entries in loggingBinding.weijiaxu
Test: Run in dialer lab PiperOrigin-RevId: 174075702 Change-Id: Ib663dc34d2c0c9e737c6d5f13b16d2b42b714127
2017-11-01Use unencrypted storage for shared prefs in new call log.zachh
We need to be able to write the shared prefs when the device is in direct boot mode, and this data is not sensitive so can be unencrypted. Bug: 68350256 Test: existing unit, manual PiperOrigin-RevId: 174075154 Change-Id: Ib52e11c6abba0812d1dc07c642691359089c3e6e
2017-11-01Removed helper methods in DialerExecutors.zachh
We now use dagger everywhere for consistency and explicitness. Test: tap PiperOrigin-RevId: 174071122 Change-Id: I15d2f8261a7b753353be9e7d3b80692aa0c1b64d
2017-11-01Add country code support to ad settings.erfanian
This allows users to override our automatically selected country code. Bug: 63994464 Test: unit tests PiperOrigin-RevId: 174064853 Change-Id: I12bd770300b041f3c7d5b8d5f5c0b75c4945492e
2017-11-01Add VoLTE conference call to simulator and fix a minor issue for GSM conference.weijiaxu
Bug: 67785540 Test: On a walleye. PiperOrigin-RevId: 174062497 Change-Id: I757b423f1c9ffe286fab15d3d8b5be8fe7c549dc
2017-11-01Use DialpadTextView instead of TextView to show letters under each digit key.linyuh
Bug: 30215380 Test: Manual PiperOrigin-RevId: 174055180 Change-Id: Iac6deb8f9dcb6f3e9da6dfd0d732f29cc34bb7f6
2017-11-01Disable assisted dialing when the phone is User Locked.erfanian
Because the phone is one of the few applications that operate when the phone is locked, disable the feature to avoid reading/writing any encrypted preferences while the user is in the locked state. I do not anticipate this being a necessary feature when the device is locked. Bug: 65399148 Test: unit test PiperOrigin-RevId: 174044403 Change-Id: I1b9a2ac677ced2af06455a384bf169c417ffc1a5
2017-11-01Add logging statement to assert InCallUI branched as expected.erfanian
Test: none PiperOrigin-RevId: 174042820 Change-Id: Ia09f55d9f38b9335b23234cfe399987a3f3a65b1
2017-11-01Added CompositePhoneLookup and added and implemented "lookup" method.Zachary Heidepriem
Fleshed out docs for PhoneLookup. Added dagger components and modules. Bug: 34672501 Test: unit PiperOrigin-RevId: 173977963 Change-Id: If07795d9d3d56a59afd27cdda3e98543bf30fdb8
2017-10-30Roll forward cl/172154863: Do not load every DialtactsActivity fragment on ↵wangqi
app open With this change we now only load the Favorites and Call Log Fragments when the app opens. Paging to the CallLogFragment makes the ContactsFragment load as we would want. This should result in a faster app start time. I'll need to verify the impact of this using the same method as http://cl/170422671 I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change. This change also fixes flaky test of voicemailTabVisibleNotVisible_volumeStreamCorrect. Bug: 64541209,65460373,67297718 Test: DialtactsActivityIntegrationTest PiperOrigin-RevId: 173734472 Change-Id: Ifd4a3064a6fdcffe5a373eaad6ee4aeebdadda1e
2017-10-30Let InCallPresenter instead of StatusBarNotifier implement AudioModeListener.yueg
The bug is caused by old StatusBarNotifier object cancelling new notification. Remove listener for InCallPresenter is safer than for StatusBarNotifer. Test: manual PiperOrigin-RevId: 173734079 Change-Id: Iefdc2d0e399da97bf31dbd5f99beb9ed34bcd874
2017-10-30Clear cached requested video stateroldenburg
This CL accepts this AOSP CL: ag/64881150 Author: Ravi Paluri <rpaluri@codeaurora.org> Bug: 64881150 Test: manual, ImsVideoTechTest PiperOrigin-RevId: 173734014 Change-Id: Ibccc610c85c4bd06f34fc6bb057c356dd74f362d
2017-10-30internal changemdooley
Bug: 62423454 Test: manual and updated unit test PiperOrigin-RevId: 173731907 Change-Id: Ic73600197b1c4fa6ac0937a8c38b048cd8faded8
2017-10-30Make dialpad key alignment responsive to font size.linyuh
In portrait mode, we surround the icon and letters with a linear layout so that we can adjust its height. In landscape mode, we add a horizontal placeholder to each key's layout so that we can adjust its width. This approach was put forward by Ryan Oldenburg (roldenburg@). Bug: 30215380 Test: Manual PiperOrigin-RevId: 173717443 Change-Id: I9b60657ca20d371a60c303a9683578663fc28a09
2017-10-27Center align numbers in each column of the dialpad when in landscape mode.linyuh
No changes are made to the portrait-mode UI. Bug: 30215380 Test: Manual PiperOrigin-RevId: 173710022 Change-Id: I9ef8a57b044e069af2eb886ea6baa30c279f4f70
2017-10-27Fix HOLD option not displayed in voice calls in CDMA + GSM.wangqi
Add hold button for all phone types and rely on SUPPORT_HOLD capability to show it. The issue is that if GSM call is made on devices with CDMA + GSM sim, the default phone type is CDMA so the hold button is not available. This change is a workaround that adding hold button to CDMA button chooser so button choose of all phone type has hold button available and it's totally controlled by telecom's CAPABILITY_SUPPORT_HOLD and CAPABILITY_HOLD. It shouldn't affect CDMA call. Idealy we should use correct phone type but unfortunately it's not well supported on pre-O device. This is upstream change from https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/482377/ Bug: 63911282 Test: ButtonChooserIntegrationTest PiperOrigin-RevId: 173614690 Change-Id: I6e17c1cc69ad50b1ba4c9b09804d5a7b5eeaf496
2017-10-27Use string concatenation for CREATE_TABLE_SQL instead of StringBuilder()uabdullah
The current implementation is easy to read but causes klippy warnings. Also removed the AnnotatedCallLogDatabaseHelperTest.voicemailColumnsExist and combined it with the onCreate Test Test: Unit Test PiperOrigin-RevId: 173614534 Change-Id: If00f7e91f48e582aa481268d88a4871cc2364684
2017-10-27Move the functionality of ↵linyuh
DialerUtils#getDefaultSharedPreferenceForDeviceProtectedStorageContext(Context) to StorageComponent. Bug: 30224215 Test: none PiperOrigin-RevId: 173612463 Change-Id: Ia89d5d85c31ea2114b196393ae43b803023fc9bf
2017-10-26Fix issue of huge latency measured from app#onCreate to activity#onCreateweijiaxu
When dialer application class got launced but GoogleDialtactsActivity was not launched, there was an unstopped timer started by dialer application, causing the measurement to be very huge next time. Test: Run on devices in dialer lab. PiperOrigin-RevId: 173570185 Change-Id: If835c7b0b7cf01b9ec3f7bc36a5104f57c697908
2017-10-26Set incall button color to match sim color.wangqi
This change also add a handy adb command script run before UI integration test. Bug: 67429956 Test: IncallActivityTest PiperOrigin-RevId: 173565382 Change-Id: I9b8b957f00a0b7d11dbb7f40e8c9f1dbdb8c3928
2017-10-26Cp2 Phonelookup isDirty implementation.calderwoodra
Checks if a cp2 contact has been modified or deleted. Bug: 67605130,64099602 Test: Cp2PhoneLookupTest PiperOrigin-RevId: 173499443 Change-Id: I1fa267c05732fba09f00113232d4370b159aa735
2017-10-26App latency test migration.weijiaxu
Migrate the existing app latency test to a new solution from Project Fi team. The main change on this new solution is that the data collection part is done by Primes now. Also, a few changes has been made on DialerPrimes class and a new Dialer variant dialer_release_test has been created. The benefits of using primes to collect data are: 1. latency tests dont need to insert lines of code to track latency in dialer codebase 2. be able to collect data on any variants with or without Proguard 3. latency tests now only contain ui interaction to trigger scenarios on which we want add measurements 4. share the same logic with primes on production so that data from testbeds and normal users are comparable. 5. easier for anyone to add interesting data entries. ----------Mobile Harness Below----------------------------------- RELNOTES[INC]:Add entries for dialer to use mobileharness plugin. Test: No PiperOrigin-RevId: 173481741 Change-Id: Ia6812794141382898bea4b34bca90278c5663464
2017-10-26Search fragment now closes after placing a call.calderwoodra
Moved SearchContactViewHolder listener logic from SearchAdapter to SearchFragment to make it easier to close search after placing a call. Bug: 68201142 Test: existing + DialtactsActivityTest PiperOrigin-RevId: 173454972 Change-Id: Ib5715d0f427d62344641b4bf841d34145fc3f65e
2017-10-26Display CDMA voice privacy icon on notification bar.Eric Erfanian
The locked phone icon will be shown for voice privacy call on CDMA for non-hold status(dialing, ongoing etc.) The onhold icon is same as usual. This change also update on hold icon to quantum vector drawable resources. WANT_LGTM=all Bug: 37529280 Test: StatusBarNotifierTest PiperOrigin-RevId: 173451922 Change-Id: I71d4c03b6953ca72def339c9c0a77bacbaf145f8
2017-10-25Fix crash that isInMultiWindownMode is not supported on M.wangqi
Bug: 68143529 Test: none PiperOrigin-RevId: 173439449 Change-Id: I80ebb4e8b17551144e492424e7aa6d92f26cc576
2017-10-25Fix TMO frozen ViLTE video upon swapping callroldenburg
We were not using the VideoTech interface for these calls and as a result could not restore the camera when swapping calls. Bug: 68160072 Test: manual PiperOrigin-RevId: 173437432 Change-Id: Iec1d363178e2332014f95246637c23f9040cdfee
2017-10-25Fix contacts promo not showing consistently due to scroll settling tab indexAndroid Dialer
Follow repro steps to see contacts promo always consistently shown Bug: 68158965 Test: manual PiperOrigin-RevId: 173427472 Change-Id: I3717ee674aa81d1f1c563920796ef0f21dcdd963
2017-10-25Add support for voicemailURI to annotated call log for new voicemail tabuabdullah
VoicemailUri is required to play voicemail audio files. We need it to be able to play the voicemails in the voicemail tab. A follow up CL will be using the uri to play the audio, but via a media player. Bug: 64882313 Test: Unit tests PiperOrigin-RevId: 173422683 Change-Id: Ib438e3020c83e11a2c54c3e941c93e83dba9bc90
2017-10-25Improved dagger support for executor services.zachh
By always creating executor services via dagger, we can now bind special versions during espresso tests that can implement idling resources. We should be using idling resources during espresso tests for threads that we create ourselves, because espresso does not know about them. Hopefully this reduces some of the flakiness of espresso tests that we have today. This required converting all existing calls to DialerExecutors to pass a context used to fetch the component, and also required creating new application classes for espresso tests. Test: temporarily added a task which just slept to DialtactsActivity and verified that its integration test failed due to idling resource timeout PiperOrigin-RevId: 173334773 Change-Id: I876a93022d235d62cfc377bf5b06687e21a34758
2017-10-25Refactor client platform checks to be DRY.erfanian
It didn't sit well with me that we would check for platform eligibility in two places. Test: existing unit tests; PiperOrigin-RevId: 173334224 Change-Id: Ia7075bc40e935c2794646671b5cfea34b7a06afb
2017-10-24Rename the new bubble package name from "bubble" to "newbubble".Eric Erfanian
It fixes AOSP for package name conflict. Test: manual PiperOrigin-RevId: 173298696 Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
2017-10-19Automated g4 rollback of changelist 172154863.maxwelb
*** Reason for rollback *** Causes crashes on rotation: http://b/67839843 *** Original change description *** Do not load every DialtactsActivity fragment on app open With this change we now only load the Favorites and Call Log Fragments when the app opens. Paging to the CallLogFragment makes the ContactsFragment load as we would want. This should result in a faster app start time. I'll need to verify the impact of this using the same method as http://cl/170422671 I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the ch... *** Bug: 64541209,65460373 Test: Manually verified regression fixed PiperOrigin-RevId: 172684553 Change-Id: I9a5b30d6619d930adfb82b19ac3ff9da00decaaa
2017-10-19Take into account special dialable characters when grouping calls in the ↵linyuh
call log UI. Currently we use PhoneNumberUtils#compare(String, String) to determine whether two numbers in the call log should be grouped. The method ignores special dialable characters such as "#", "*", "+", etc, which can cause phone numbers and service dialing numbers to be grouped. For example, suppose the user has a contact named "John Smith" with number 123456789 and a contact named "Service" with number #123456789, and called each contact once. The old grouping logic will put the two numbers in the same group. The new grouping logic in this CL can separate the two numbers. Bug: 30225112 Test: CallLogGroupBuilderTest, PhoneNumberHelperTest PiperOrigin-RevId: 172683494 Change-Id: Ie9e7b7418d6d7c74830cbae09c04ff1feb1b827d
2017-10-19Move more Video Share stuff to third_partyroldenburg
Bug: 36565933 Test: manual, just moving PiperOrigin-RevId: 172671853 Change-Id: I415f5b7e518cca22fad96b017a573322af3f73be
2017-10-19Fix NPE in TelecomAdapter.stopForegroundNotification().yueg
In InCallServiceImpl.tearDown(), we should only clear inCallService after InCallPresenter.tearDown() where we remove all notification. Also remove null assertion in stopForegroundNotification() since other crash should only happens when there is no notification. Test: StatusBarNotifierTest PiperOrigin-RevId: 172657924 Change-Id: I86e720b80f885aa93f12215fda899ee62eeaba5b
2017-10-19wrapping %s in in <xliff:g> </xliff:g> tags to prevent translationmdooley
Bug: 67322107 Test: manual PiperOrigin-RevId: 172656296 Change-Id: Ia8b7d508ef35ff0091b762c28e1091af60ce15b4
2017-10-19Check AD eligibility before utilizing the feature.erfanian
Bug: 67914094 Test: unit tests PiperOrigin-RevId: 172650441 Change-Id: Ie7df3174a07df2de3a102fb70a126004f704b22f
2017-10-17Support bulk inserted voicemails.twyen
Bulk insert is implemented in ag/3073902 When more than one voicemail is inserted into the VoicemailProvider, the URI type is Voicemails.DIR_TYPE instead of ITEM_TYPE. This CL adds support to the new type. Previously when multiple voicemails are being notified, each one of them will generate a ringtone because the notifiction is set to alert children. In this CL, the summary will have alert instead, and will only alert when new voicemails are received. Bug: 21281858 Test: VisualVoicemailNotifierTest PiperOrigin-RevId: 172546076 Change-Id: I4df6098fc3a793139e3d4e77fe1339efdc001944
2017-10-17Fix top text cropping issue in new voicemail tabuabdullah
The numbers used to be cropped (http://screen/YYBG8T0Ma0J). We've fixed that issue in this CL and also removed the term "call_log" from the file name. Screenshot: http://screen/uHCPwf5smVX Bug: 64882313 Test: N/A PiperOrigin-RevId: 172541833 Change-Id: Ib2746b38284c2c04c84ab369d449412d8a9880b4
2017-10-17Update SearchAdapter query if fragment has query before fragment is ready.calderwoodra
If a user made a search using the voice/mic icon, the search results weren't being applied to on device contacts because SearchAdapter wasn't receiving the query. Bug: 67633975 Test: manual PiperOrigin-RevId: 172540423 Change-Id: Ib92b055dddf4e4fbdf88eadd62583bf1bac32055
2017-10-17Contacts are now searchable by company name.calderwoodra
This change coalesces Cp2 contacts into a new cursor so that they can be associated with the Company name. The following logs can help explain how the data is organizes in the original cursor: display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/name), data1 (A Pixel) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/note), data1 () display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/group_membership), data1 (1) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/phone_v2), data1 (+1 650-200-7932) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/phone_v2), data1 (+1 540-555-6666) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/organization), data1 (Walmart) This is an example of what is returned for a single contact. We can easily associate contact rows together using the lookup key and determine which rows have relevant data by checking the mime type. I use the data here to coalesce the contacts together into one row for easy parsing in ContactFilterCursor. Rows with mime type phone_v2 contain contact information (for example, this contact has 2 phone numbers). Rows with mime type organization contain contact's company information (for example, this contact works at Walmart). Bug: 67675742,64894607,67848713 Test: existing + SCCT.filter_companyName PiperOrigin-RevId: 172528797 Change-Id: I5c9f66ff0c27276869295eff97bb0216f92995be
2017-10-17Update simulator to add emergency callmaxwelb
Test: Manual :/ PiperOrigin-RevId: 172521778 Change-Id: Ibc853aa429d61c13a43b56411fb00a0fcb38795f
2017-10-17Allow voicemail transcription notifications to expandmdooley
Bug: 67430264 Test: manual PiperOrigin-RevId: 172520128 Change-Id: I061e3b45599e1c14be387713e63f6fdeae367be4
2017-10-17Hide voice search button when exiting search if it is not availabletwyen
Bug: 67820772 Test: DialtactsActivityIntegrationTest PiperOrigin-RevId: 172519580 Change-Id: I31983153cedb24c436cbaeef69fe6a2f4e558c65
2017-10-17Stop showing partially matched numbers that are not global phone numbers.linyuh
When determining whether two phone numbers are identical enough for caller ID purposes, the Contacts Provider ignores special dialable characters such as '#', '*', '+', etc. This makes it possible for the cursor returned by the Contacts Provider to have multiple rows even when the URI asks for a specific number. For example, suppose the user has two contacts whose numbers are "#123" and "123", respectively. When the URI asks for number "123", both numbers will be returned. Therefore, the following strategy is employed to find a match. If the cursor points to a global phone number (i.e., a number that can be accepted by PhoneNumberUtils#isGlobalPhoneNumber(String)) and the lookup number in the URI is a PARTIAL match, the cursor is a match. If the cursor points to a number that is not a global phone number, the cursor is a match iff the lookup number in the URI is an EXACT match. There is no matched cursor in all other circumstances. UI demo: Suppose the user has a contact named "Service1" with number "#123". Before: Incall UI after the user dials "123": https://photos.app.goo.gl/xFWCD4qy2VR3YEuJ2 Call log UI after the call ends: https://photos.app.goo.gl/FT28GdTBy1dtANtI2 After: Incall UI after the user dials "123": https://photos.app.goo.gl/Io3BisQmsyfnvitV2 Call log UI after the call ends: https://photos.app.goo.gl/6GgRrmx75yUTga3B3 Bug: 30225112 Test: PhoneNumberHelperTest PiperOrigin-RevId: 172505648 Change-Id: Ida554313455ff9ce40432897681f89f58d64af04
2017-10-17Display Voicemail Contact Name and Photo in Voicemail Fragment.uabdullah
This CL lays the foundation of querying the annotated call log, retrieving only the voicemail entries and some of the voicemail information in the Voicemail tab. This CL only displays the name/number as well as the corresponding photo of the voicemails present on the device. WANT_LGTM=zachh SCREENSHOT: http://screen/YYBG8T0Ma0J Bug: 33006245, 64882313 Test: Unit tests and manual verification. PiperOrigin-RevId: 172504512 Change-Id: Ie7187b021abf42d1a4522458a1ab28537a7c222c
2017-10-17Add temporary assisted dialing setting to Dialer.Eric Erfanian
Bug: 63994464 Test: integration test PiperOrigin-RevId: 172499750 Change-Id: I7a7c23b403f649c1bbec0bb068e1285e02fddd22
2017-10-17Some cleanup of incoming call latency.wangqi
1. Only update secondary info when it's changed. 2. Removed redundant call to update notification on activity start (b/36649622) 3. Use same call back for notification update from contact info query to avoid duplicated call backs. The actual latency reduction is insignificant (<10%). Bug: 36649622,64542087 Test: manual PiperOrigin-RevId: 172475223 Change-Id: I1c91cb5715287991de774a1d9b95e4c8b722d28f
2017-10-17Move Duo related constants out of interfaceroldenburg
Fixed notifying for Duo missed calls using the new constants to check if a call is a Duo call. Bug: 66946794 Test: existing tests, manual PiperOrigin-RevId: 172400311 Change-Id: I84ec0ac5c933cf1aec68b6d1f422c2effe6b69ec
2017-10-17Dismissing location prompt now actually prevents it from reshowing.calderwoodra
Bug: 67709163 Test: NewSearchFragmentTest PiperOrigin-RevId: 172378559 Change-Id: I2b92e1e06057a57638d23a333d04239b2e288bc1
2017-10-17Add GSM conference calling to simulator.yueg
This CL adds a new item to the simulator menu: - Add GSM conference The GSM conference action creates a conference with 5 phone calls. Users can individually separate or kick calls out of the conference. Hanging up the second last call finishes the conference. Bug: 67785540 Test: SimulatorConferenceTest PiperOrigin-RevId: 172377631 Change-Id: Ic30fa6c65cf782247f75bcdd1ecbd86b1c16f143
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 14:11:00 +0000