Age | Commit message (Collapse) | Author |
|
Previously when the dialpad is shown the fragment manager is checked to decide whether to create a new fragment or not. This check does not account for pending transactions. If multiple ACTION_DIAL intents is received before the first showDialpad transaction is actually committed (due to the system lagging), multiple dialpad fragment will be added and cause crashes.
In this CL, the MainSearchController will hold on to the dialpad and search fragment instance, instead of querying the fragment manager.
TEST=manual - modify code to delay the commit. The timing is difficult to set up in tests.
Bug: 77540395
Test: manual - modify code to delay the commit. The timing is difficult to set up in tests.
PiperOrigin-RevId: 196197187
Change-Id: Ie649a9fba0ecfd8944781949c179ac8739930830
|
|
Bug: 194611503
Test: Unit Test
PiperOrigin-RevId: 196190392
Change-Id: I11fc1a02bd89207bf1c2d12f2821ef4447529c6e
|
|
This is caused by apps modifying dialer resources.
TEST=TAP
Bug: 79441501
Test: TAP
PiperOrigin-RevId: 196175830
Change-Id: Ia42e8debe66adbaa2e4e7bdfea7bafe1ef7372bf
|
|
Test: presubmit.
PiperOrigin-RevId: 196158524
Change-Id: Iec1e457039e97be0236cd700d397b4095ee3c2c3
|
|
Bug: 67596257
Test: unit tests
PiperOrigin-RevId: 196049621
Change-Id: I6f9c6292b1d56e3faf7808aa668b03d07230a70b
|
|
Test: blaze test.
PiperOrigin-RevId: 196047666
Change-Id: Ia54e342113f9dbc9fe884b9a85d0f4db33f94cf5
|
|
Bug: 73774884
Test: unit
PiperOrigin-RevId: 196021103
Change-Id: Id2176e6ef4259dc6e1136564051dae14e30175d4
|
|
Test: N/A
PiperOrigin-RevId: 195995975
Change-Id: I0311770eecdf36f275d81ba481098259344cbf5b
|
|
Bug: 77835800
Test: Manual
PiperOrigin-RevId: 195861757
Change-Id: I79f99c3468324922560961ea71dcc792a4d83a24
|
|
Test: manual
PiperOrigin-RevId: 195856176
Change-Id: I8579afff48e9c07d422505b81d703adc03656435
|
|
Use it when logging performance metrics.
Unfortunately the class names returned by Class#getSimpleName() are obfuscated by proguard and make viewing the metrics difficult to impossible.
TEST=none
Test: none
PiperOrigin-RevId: 195749831
Change-Id: I40320f388d34e059c9a913e2b72a1acf1a727f60
|
|
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 195747611
Change-Id: Ibce7ef45af2f79cc5a35825a2bb38fe268a4681c
|
|
OldMainPeer and
Always fetch the voicemail status when resuming OldMainPeerActivity. There is no reason why this should not happen.
TEST=N/A
Bug: 79365547
Test: N/A
PiperOrigin-RevId: 195744525
Change-Id: Ie31551bfecd5056b0b3b559946e9cd2c8f6ef23f
|
|
This CL consolidates common duo calling operations into precall, including checking reachability, falling back to carrier video call, placing the call to duo with startActivityForResult.
TEST=TAP
Bug: 78783816
Test: TAP
PiperOrigin-RevId: 195742478
Change-Id: I9fea1e4999f604e1f3a153b28079cd0db77b7393
|
|
Bug: 78243194
Test: CallIntentTest
PiperOrigin-RevId: 195718047
Change-Id: I09134e13c9c5a811dba313cb4415a36aba7d7262
|
|
In this case we don't have a name, but set the DISPLAY_NAME to the number to make the contact card look nice. However, when using STRUCTURED_NAME and creating a new contact with the number, the number is populated in both the first/last name fields and the number field. Using PHONE makes it so the number is displayed on the contact card but the number is not populated in the name fields when creating a contact. This is consistent with the old call log's behavior (see ContactInfoHelper:createTemporaryContactUri).
TEST=manual
Bug: 78252466
Test: manual
PiperOrigin-RevId: 195714742
Change-Id: I26cf18a76af60f48d7979cd8cc8e47d72de1bf5e
|
|
sheet)
Bug: 77835800
Test: Manual
PiperOrigin-RevId: 195706300
Change-Id: Iccc97d5cc3ab6f196dc917faf1d7b6659b06cf30
|
|
Bug: 71719349
Test: CallLogEntryTextTest, HistoryItemActionModulesBuilderTest
PiperOrigin-RevId: 195694340
Change-Id: Ib53305c36f7ca062ef798ab3f61585d3c71adef3
|
|
Bug: 71719349
Test: EmergencyPhoneLookupTest, PhoneLookupInfoConsolidatorTest
PiperOrigin-RevId: 195691356
Change-Id: I705721fa6e6a22e5b2d541578b83196181c895eb
|
|
Test: Build
PiperOrigin-RevId: 195502147
Change-Id: I5f88fb91e52f36da73725e392dee8dfef2666be0
|
|
Test: Build
PiperOrigin-RevId: 195498557
Change-Id: I28525d0475f847b2ff5a128580256e2688ed47d5
|
|
Bug: 79171382
Test: Build
PiperOrigin-RevId: 195485088
Change-Id: I306c1ab0fdd629baf1feb0a689debe72eb08b450
|
|
Bug: 79171382
Test: Tap, manually verified spam calls (and autoblock)
PiperOrigin-RevId: 195480993
Change-Id: Ifefee382ae6181c20e83d16b2e0519dd05e60c6a
|
|
This happens when the number exists in call log, which usually shouldn't happen but some OEMs may have different behavior. Adding an additional check to align it with call action so block option won't show up if the number is not callable.
Bug: 79202933
Test: verified on LG device.
PiperOrigin-RevId: 195480184
Change-Id: Icde5f5b0914b2198d9031d188b22a65d6a3085cc
|
|
Bug: 77908301
Test: listnr
PiperOrigin-RevId: 195479105
Change-Id: Ieb64d5df486392b9bc1f6e9bbd340dc18e7b6e26
|
|
Bug: 77807682
Test: listnr
PiperOrigin-RevId: 195477904
Change-Id: I5408f4fad9bbc20ff7ce72b25201c23b11a35c43
|
|
Bug: 79171382
Test: Tap, manually verified incoming spam call
PiperOrigin-RevId: 195472160
Change-Id: I0cda8f36b350a9fc03e098667e8bd83ad8b1d161
|
|
This avoids a cast and generally improves understandability.
TEST=existing
Test: existing
PiperOrigin-RevId: 195457457
Change-Id: Ida9d3fc85bed8ff1e0f8064805e23fab00fdeddf
|
|
Bug: 79239533
Test: tap
PiperOrigin-RevId: 195456757
Change-Id: Ief432ae2fbd54d20f8fca198e102b22b169bcb77
|
|
Test: Tap
PiperOrigin-RevId: 195453152
Change-Id: Ida07f465a832e3541d4c9f6abad97b633c38ac13
|
|
call details
Bug: 71719349
Test: CallLogEntryText
PiperOrigin-RevId: 195444242
Change-Id: I62268c02ef7ad277364869e713a1d58ab1928e7e
|
|
Test: yes
PiperOrigin-RevId: 195442132
Change-Id: If0cf189700bc0340cbaed065047504db22d8b618
|
|
Bug: 74522027
Test: None
PiperOrigin-RevId: 195439124
Change-Id: Ibab0bc7e58bd1b23255d9af476c5b98ed89f13fa
|
|
Bug: 74238896
Test: manual
PiperOrigin-RevId: 195437669
Change-Id: I1cb26187b8b90664b72de2a4451283a9fbdc0f10
|
|
Bug: 79195339
Test: manual
PiperOrigin-RevId: 195344623
Change-Id: I64225b781c84d363848a15bcdaa351585dce6b04
|
|
Previously the listener is not cleared, and clicking on a private will call whatever the view was previously bound to.
TEST=TAP
Bug: 79219109
Test: TAP
PiperOrigin-RevId: 195332291
Change-Id: I4806ab659099dc7986b90c68f2e52d8efd4f5f5b
|
|
Bug: 78476115
Test: HistoryItemActionModulesBuilderTest
PiperOrigin-RevId: 195319447
Change-Id: I7d431e74c2f4efe6ea3ce24b7d3ae42ebb4525b2
|
|
The bottomsheet in v28-prelease support library is no longer available. So
revert back to the deprecated bottom sheet.
Test: manual
PiperOrigin-RevId: 195319010
Change-Id: I580ef4d979d50864ea385b01245dfbeb68b8579d
|
|
TEST=TAP
Bug: 79089209
Test: TAP
PiperOrigin-RevId: 195317152
Change-Id: I2d456dc786f2ea6555b76d3ef6721140acee7413
|
|
Test: HistoryItemActionModulesBuilderTest, ModulesTest
PiperOrigin-RevId: 195294876
Change-Id: Iac44f965a585975389da7dee758a94a8ad8311d3
|
|
This change also add a null check for RttCall when saving RTT transcript.
Test: DialerCallTest
PiperOrigin-RevId: 195293823
Change-Id: I67cf3410480ac106933486d9d31f0fbb3183b074
|
|
There are some upcoming changes to CallList#onCallAdded, so this CL adds the
tests needed to verify that behavior doesn't regress. This became something of a
rabbit hole because:
1) CallListTest needed to use a FakeSpam so spam status could be changed
2) FakeSpam needed updates so it wouldn't crash when CallList calls it. This was
implemented as a no-op for simplicity. It also needed to support the single
number lookup method.
3) FakeCall needed updates to support setting the details' extras (needed tests)
4) ShadowCall needed updates to support setting the details' extras
5) DetailsProperty needed a new value
6) There was an old TODO to use a string that's now visible in the SDK
7) SharedPrefConfigProvider needed a new method to set the emergency call window
long.
Bug: 33779976,79171382
Test: Tap
PiperOrigin-RevId: 195287258
Change-Id: Ib8b9fde35263183393e9bcbdcf73eeada24f28eb
|
|
Test: unit
PiperOrigin-RevId: 195188099
Change-Id: Ie2273229c257a9a767715831c15d90a6985fdda8
|
|
|
|
|
|
|
|
* changes:
Translation tweaks.
Migrated context menu to be a PopupMenu instead.
Add column for call mapping id to AnnotatedCallLog database.
Don't force open keyboard when RTT is active.
|
|
Bug: 78490736
Test: manual
PiperOrigin-RevId: 195161904
Change-Id: I7d3600267223fcfafae42f3f52bfd6cfff8b9146
|
|
Test: tap
PiperOrigin-RevId: 195148588
Change-Id: I07ca65e6320347cfe537fc80c9a585e71291829a
|
|
Bug: 79153175
Test: Compiled and verified that merged manifest had targetSdkVersion=28
PiperOrigin-RevId: 195145440
Change-Id: I12cde947d8fe8594f91bcc3dacdba6f9c72ac84a
|
|
Bug: 36922756
Test: none
PiperOrigin-RevId: 195136037
Change-Id: I481fbbc771d2e91eed54993163912a139483b6ca
|
|
This gives us huge amounts of functionality with very little technical cost but
some trade off in UX.
Bug: 77761183,78492250
Test: existing
PiperOrigin-RevId: 195133774
Change-Id: I57e48b5defc4ae1c7bfbed13e3fbc16ebd607944
|
|
This will ensure call mapping used by RTT etc. won't break when migrating to
new way to generate the call mapping id since they are stored in the database
already.
Bug: 77717594
Test: unit tests
PiperOrigin-RevId: 195132562
Change-Id: Ieb52489b19b37ac2701967eb570a96457ceed4c0
|
|
Bug: 79094585
Test: manual
PiperOrigin-RevId: 195130360
Change-Id: I2763ddd950d0fe2479b442fe18363b8ec45a3178
|
|
cut off.
Test: N/A
PiperOrigin-RevId: 195116198
Change-Id: Ic0802144c6e52ec56e14ceb012bee1b6c774f826
|
|
Test: TAP
PiperOrigin-RevId: 195098682
Change-Id: I95621b8fdc9d0e887fae1a48e915612c3b12f817
|
|
Bug: 76224138
Test: DialerCallTest
PiperOrigin-RevId: 195027298
Change-Id: I5e341af68d7efedff6047421c9fd45b612133a8c
|
|
They are not constant across different Duo implementations.
TEST=TAP
Bug: 76430187,78783816
Test: TAP
PiperOrigin-RevId: 195001650
Change-Id: I4356d04c9eeac50fefd41e1142f3123591e93bc0
|
|
So TalkBack user know if an audio route is selected or not.
Bug: 74238896
Test: manual
PiperOrigin-RevId: 194999585
Change-Id: I849352d87dbbfcfb3d16e148daa2e0bcf0af0158
|
|
Pulled this out of the previous CL to investigate why it
breaks some of our tests.
Test: tap
PiperOrigin-RevId: 194983149
Change-Id: I07cbb956b5d15315f6b258ff534dd2c3e1cc9f9a
|
|
Bug: 74238896
Test: manual
PiperOrigin-RevId: 194983140
Change-Id: I7dda119fd97445906bb6df93726d475ba634f4e4
|
|
Bug: 78922118
Test: tap + manual
PiperOrigin-RevId: 194971448
Change-Id: I906250cb83c17198fac87f5ad6d3014cc8a34db2
|
|
|
|
|
|
Additionally, change the style of the bottom sheet to unbreak AOSP.
Bug: 79150335
Test: manual
PiperOrigin-RevId: 195169624
Change-Id: I86d2f5b7931b3c928252c5d5e1e6eef6973a35cd
|
|
Follow-up CLs will include:
- white bottom nav
- setting status bar color when expanded, translucent otherwise
- automatically dismissing the bottomsheet onPause in calllog/vvm
Bug: 73495458,77761183,77812338,77816530,77833456
Test: manual
PiperOrigin-RevId: 194967761
Change-Id: Iea81035efd06ae7692950ca1f11757b7d9ebfd1c
|
|
Test: check code of generated application.
PiperOrigin-RevId: 195121315
Change-Id: I213770a2bb5dca7e565ee1006d7044c2e7acc6d9
|
|
App would crash when users attempted to remove a starred contact because we try
to update Phone.CONTENT_URI, which is not allowed. Test assumed that
we could update PHone.CONTENT_URI, which is why this wasn't caught.
Updated the test to verify the contact in Contacts.CONTENT_URI get updated to
starred = 0. Unforunately, since fakeContentProvider doesn't work exactly like
cp2, the update won't propogate to Phone.CONTENT_URI, so out test is less than
ideal, but it should cover our bases.
Also updated the image and text for starring a suggestion.
Bug: 78923466
Test: tap
PiperOrigin-RevId: 194962080
Change-Id: I9f8f71d70ba83510682890917081380a3c51cd7a
|
|
Previously the NUI call log call backs with whatever SIM the call was made/received in, which is inconsistent with the old UI. The Old UI behavior should be kept.
TEST=TAP
Bug: 78291136
Test: TAP
PiperOrigin-RevId: 194878167
Change-Id: If9c5adcbed6a194c801d2b558abb45573b97d2ae
|
|
Bug: 74022483
Test: InCallPresenterTest
PiperOrigin-RevId: 194877539
Change-Id: If140d716a8019738e145c24cbaab3c03827662cb
|
|
Bug: 74022483
Test: manual
PiperOrigin-RevId: 194864239
Change-Id: I89a186faa1831634bbaecbe30c83bded4b321c06
|
|
Thre is no point to save an empty transcript.
This change will also prevent showing transcript button in call details.
Bug: 70177426
Test: manual
PiperOrigin-RevId: 194863630
Change-Id: Iee4e5c0929c3ebfc75377ed0f529934a6cfe01f5
|
|
devices
When the SIM is removed, telephony will signal cancel notifications on the "null" account (the framework doen't know what was there.). Previously this has no effect. In this CL, all legacy voicemail notifications are removed since all SIM will be removed together.
TEST=TAP
Bug: 78446801
Test: TAP
PiperOrigin-RevId: 194856211
Change-Id: I5df97f0c73e0644daa46ab182f19e60044e39d96
|
|
Bug: 78653623
Test: manual
PiperOrigin-RevId: 194851988
Change-Id: I55f75dc35ffc4fb0638dfc1727a1cd554fa67cdb
|
|
When dual SIM selection support is added to In Call UI it was a rush order and codes are duplicated. This CL moves the duplicated logic into PreferredAccountWorker so the same dialog can be shown for both.
TEST=manual
Bug: 69675796,72618783
Test: manual
PiperOrigin-RevId: 194845320
Change-Id: Id283ca7616580b0efd4e8f02e63691c70ee7f93c
|
|
Test: manual
PiperOrigin-RevId: 194828525
Change-Id: Ib9f1faece83525c00feadf32b43a6901d54ea76e
|
|
UiListener nulls out the callbacks onDetach(), which is after onSaveInstanceState().
TEST=N/A InCallActivity is not testable.
Bug: 78517857
Test: N/A InCallActivity is not testable.
PiperOrigin-RevId: 194824783
Change-Id: I2c4f41cf58a498a841f69ef078e58d07ec5b3c5a
|
|
Bug: 74022483
Test: manual
PiperOrigin-RevId: 194822680
Change-Id: I4df144b21a0fc32e39eb970fadc24ef7eb6e7199
|
|
If the call disconnects when RTT UI is in background, any messages received from remote should be saved to transcript. RttCallPrensenter might not be available at this point, so the job is done inside DialerCall#onRemovedFromCallList
Bug: 78576798
Test: presubmit
PiperOrigin-RevId: 194821868
Change-Id: I10381b1c292f918763360c7a4bcd0470250f2293
|
|
Bug: 78519871
Test: none
PiperOrigin-RevId: 194814100
Change-Id: Iaaa1b250ca8242f459e89043915db1328ae50f49
|
|
Bug: 77761183
Test: SpeedDialIntegrationTest
PiperOrigin-RevId: 194687428
Change-Id: Ib542122c1ff3104fcb4c08cb7bcbb7f1deb20d76
|
|
Bug: 78492066
Test: numerous
PiperOrigin-RevId: 194635336
Change-Id: I7be0efad4dc9e11beceb02c9b2f4c719d29dbbd1
|
|
This is triggered by long pressing a SpeedDialUiItem and selecting remove in
the resulting menu. This will remove it's assocaited entry from the
SpeedDialEntry database and if the contact associated with the SpeedDialUiItem
being removed only has one speed dial entry, additionally we will unstar the
contact as well.
Bug: 77761023
Test: WIP
PiperOrigin-RevId: 194606709
Change-Id: I4d6fb104a388c39c77796f7626cd63e991303a51
|
|
Bug: 74022483
Test: manual
PiperOrigin-RevId: 194600612
Change-Id: Idc15d873abfcb47a799e43468ffdd0fe1d90cc5c
|
|
This refactoring will remove dependency on incall/call package for those classes only dependent on DialerCall.State.
The benefit is to remove unnecessary dependency and avoid potential loop dependency in the future.
Test: presubmit
PiperOrigin-RevId: 194594382
Change-Id: I6b3241bcf10a0a15c495c3c90a13f174c32e3f72
|
|
Bug: 74022483,74238896
Test: InCallPresenterTest, AudioRouteSelectorDialogFragmentTest
PiperOrigin-RevId: 194589147
Change-Id: If8c6e79838d27b1ca33ed677c19f6555cbdb4494
|
|
Test: manual
PiperOrigin-RevId: 194561401
Change-Id: Ia94765a3979b5f3c3e4d02c1dc235f5e41fbf6f9
|
|
missed calls.
Bug: 78458610
Test: MainActivityOldPeerTest
PiperOrigin-RevId: 194555035
Change-Id: Ib3ef02ec3f4a8ce7cfce6d052fce3b9b6daf75e5
|
|
Bug: 70989584
Test: PhoneLookupInfoConsolidatorTest
PiperOrigin-RevId: 194494486
Change-Id: I706802c000da953f962786bd07ca5da2fd59dc8a
|
|
Bug: 70989584
Test: CequintPhoneLookupTest
PiperOrigin-RevId: 194493484
Change-Id: I59f9b334f0a218e7ba1c34948db4ddbf11490df3
|
|
notification.
Test: N/A
PiperOrigin-RevId: 194465415
Change-Id: Ica9301f4315b549c343112a824c8f7c51213bb99
|
|
The bottom sheet should include:
- contact row
- voice call
- video call
- sms
- divider
- add favorite (follow up)
- remove (follow up)
- contact info
Bug: 77761183
Test: WIP
PiperOrigin-RevId: 194440839
Change-Id: I78e0e0fc0a4834338a59b458fe7639786de57877
|
|
This change also increase the button size for easier clicking.
Bug: 76207637
Test: manual
PiperOrigin-RevId: 194440220
Change-Id: I1d5742876e4a9ce27b81182e2abd5d2a27c71790
|
|
Bug: 78519871
Test: RttChatFragmentTest.java
PiperOrigin-RevId: 194421459
Change-Id: I4d04ee3045afdd4d5553032d7434ead280810543
|
|
Bug: 78491298
Test: WIP
PiperOrigin-RevId: 194323952
Change-Id: I6883ce1506684c93cb5538ebbc0e14aecc300a00
|
|
This is caused by transcript set to non-null again in some cases.
Test: manual
PiperOrigin-RevId: 194303928
Change-Id: Ife5e6bad3874751efab1d94a4262d83017b79808
|
|
Bug: 74022483
Test: InCallPresenterTest
PiperOrigin-RevId: 194275941
Change-Id: If5a40a9778e3c0f5a05c7e33f365cb609bf6e74a
|
|
1. Hide input box when RTT call is not connected
2. Auto show keyboard when RTT call is connected
Bug: 70177426,76209308
Test: manual
PiperOrigin-RevId: 194273134
Change-Id: I36916560910e5bd47c291c8d3864db3948304db0
|
|
Bug: 36841782
Test: SpeedDialAdapterTest
PiperOrigin-RevId: 194210091
Change-Id: I5b8ad5ca43ee6f519de09ad2a8b1b959637a825b
|
|
Before this CL it is ran on a non-UI task, where the callback might happen after the activity has already ended.
TEST=manual
Bug: 78517857
Test: manual
PiperOrigin-RevId: 194169377
Change-Id: I0011019cb31b0b2c01c9d774776fb44dcac4d8c6
|