Age | Commit message (Collapse) | Author |
|
Test: manual
PiperOrigin-RevId: 170511271
Change-Id: Ief58171c675c6ece3cea5055abb6836487f23f9c
|
|
This avoid some spurious strict mode violations.
Test: observed no strict mode notification launching google dialer
PiperOrigin-RevId: 170505918
Change-Id: Ie48671dcd306ea18b041a0bd7989b419bab903f5
|
|
This is a regression caused by cl/169961072.
This change will make sure phone number is only shown on top row for non-local contacts if the name is not number and the call is active.
Bug: 67047386
Test: TopRowTest
PiperOrigin-RevId: 170424277
Change-Id: I9b3ab9432a938b2fb1c6632f2d9404bee413588f
|
|
Project Fi devices crash when declining voicemail TOS because
of an invalid PhoneAccountHandle. This cl fixes the problem by
not showing the TOS when the PhoneAccountHandle is not valid.
Bug: 67001886,66969838
Test: manual and updated unit tests
PiperOrigin-RevId: 170418189
Change-Id: I36dd0b10ab7468b0937a81f3f0427a4d64091955
|
|
Also tuning the location request accuracy and minimum update interval.
i noticed during testing that we often get locations with
uncertainties greater than our threshold (100 meters), which we ignore.
That combined with the long update interval can result in not showing
a location for a long time.
Bug: 67046739
Test: manual
PiperOrigin-RevId: 170407138
Change-Id: I1a84088f9fa09b474b07e375b92af25852dd6f46
|
|
1. Use onCancel() instead of onDismiss(). onCancel() is not called when changing orientation, so it won't crash on getParentUnsafe(). onCancel() is also not called when pressing home button, but it will be handled by AudioRouteSelectorActivity.onPause(). b/67013452 will happen after the fix.
2. Use FLAG_ACTIVITY_NEW_TASK and FLAG_ACTIVITY_MULTIPLE_TASK when starting AudioRouteSelectorActivity. This prevents showing Dialer with AudioRouteSelectorActivity. The downside is that the activity is no longer excluded from recent screen.
The two fixes can affect each other, so they are in one CL.
Video: https://drive.google.com/open?id=0Bz1rQbdSCWSKYVJkd3R1SkI4c3c
Test: manual
PiperOrigin-RevId: 170404203
Change-Id: Ifa8ebcd566670115d3865b0d67c311c296fbbd51
|
|
The problem is that InCallActivityCommon#onStop will try to commit any fragment which will crash.
This change also fix a bug that simulatorRemoteVideo is not stopped after hanging up.
Bug: 67045513
Test: manual
PiperOrigin-RevId: 170380589
Change-Id: I25e0f43141eaa573189f4d9c0109fd2689c10374
|
|
This is a upstream fix from AOSP:
https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/475598/
Bug: 63608380
Test: none
PiperOrigin-RevId: 170365033
Change-Id: Id58cf4c67a3b0144521622a14997a83403017bee
|
|
Previously post call notifications are inserted by launching CallLogNotificationService. This usually works because the call has just broght dialer to the foreground and there are some grace period before the app is consider background again. However if the post call message comes later background check will crash the app.
This CL made the broadcast receiver async and complete the insertion in a worker since it wouldn't take more than a few seconds.
Bug: 66444859
Test: unit tests
PiperOrigin-RevId: 170275928
Change-Id: I0ff396b51a173f2e4bab0bca6b6e5c5b56ab62da
|
|
This implements the core assisted dialing logic specified in
go/assisted-dialing-dd-v1
Bug: 36414469,63995261
Test: new unit tests
PiperOrigin-RevId: 170232634
Change-Id: I3b668c3a0e9fb5398eca4614548c8141b200e70e
|
|
-bypassed violations are no longer logged in AospDialer
The default implementation will use system strict mode and crash on bugfood build same as before.
Bug: 66003745
Test: manual
PiperOrigin-RevId: 170214128
Change-Id: Iab630f19499e90b15eb0b7f0707b4a70c7d81fbe
|
|
This will allow us to tune the polling rate.
Bug: 66966157
Test: none
PiperOrigin-RevId: 170210987
Change-Id: I6ef204acc6e0d43a3ada524511866d4a629fe1e2
|
|
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIdGY1RnVXM3JuMXB4OVRVOFhrSU9qRDR6c2pj
Bug: 37340510
Test: manual
PiperOrigin-RevId: 170131627
Change-Id: Ib022bba44e24675082299132a5965fbcb58257fa
|
|
Test: N/A
PiperOrigin-RevId: 170130892
Change-Id: Ifc59f239043c66eaa8341fe34c080dad08454236
|
|
Screenshot:http://screen/RK42CXn5uB6
Bug: 64882313,33006245
Test: VoicemailFragmentTest, NewVoicemailCallLogAdapterTest, NewVoicemailCallLogViewHolderTest
PiperOrigin-RevId: 170129401
Change-Id: Ib82357763bd9cf9f215804225be009650402fe84
|
|
On M the framework does not retain the hidden state of a fragment properly when restoring it from a savedInstanceState. This appears to be fixed in N, but the exact cause and fix are unknown. This behavior will cause a fragment previously hidden coming back as visible when the device is rotated or going through any save/restore life cycle.
Previously whether to show the dialpad is stored in a separate flag, and the dialpad will be hidden when it is reattached. This was regresed in cl/169614750
In this CL, if the saved mIsDialpadShown indicate the dialpad should not be shown, but the dialpad is not hidden, it will be hidden on resume.
Bug: 66893723
Test: DialtactsActivityTest
PiperOrigin-RevId: 170124711
Change-Id: I6f8ed21fb970d6f688cb75f854442115a6803f3c
|
|
These are old code and considered to be grandfathered in.
Cleaned up some warnings in GoogleLocationSettingHelper.
Bug: 66498656
Test: none
PiperOrigin-RevId: 170090310
Change-Id: I2c43564af751eb5f431a395d75afa5ce126b5d18
|
|
after rotation
mCurrentPage is set onResume before the fragment is attached. In this CL, mCurrentPage is still used for page change, but for resume and pause, it is detected directly in CallLogFragment using getUserVisibleHint()
Bug: 65161134
Test: manual - change call volume after rotation, check ToS FAB not visible after rotation. CallLogFragment is not testable.
PiperOrigin-RevId: 169984576
Change-Id: I870cbe3b83e38ac2cb505193309ab4f8e75a859f
|
|
Need to increase character limit for location title text
as the title string is now longer than the original character limit.
This should have been part of cl/169270157
Bug: 66330058,66330115,66411110
Test: none
PiperOrigin-RevId: 169967227
Change-Id: Ib49da4086c190d60da832d4ef64689e44b114150
|
|
Phone number should always be shown for non-contacts.
Screenshots:
https://screenshot.googleplex.com/guKEWdQKDpG
https://screenshot.googleplex.com/iMcPte5Vhyc
Bug: 64685156
Test: TopRowTest
PiperOrigin-RevId: 169961072
Change-Id: Iaf8fc5b1e7f3d386d20deb01f4325efb5e645363
|
|
The about in settings is removed in google dialer, it is accessed through the dialtacts overflow "Help & feedback" instead:
https://screenshot.googleplex.com/9L1kdQz6c2B
https://screenshot.googleplex.com/FqqdG6X9JTR
Note that help articles has not been migrated at this moment.
Features in the original about is placed in the overflow
https://screenshot.googleplex.com/OmCVPqwGBM9
Version info is stock google help
https://screenshot.googleplex.com/EdveVnXUSML
Privacy policy/Terms of service opens the browser to the link we had before
Open source license opens the same license activity in about.
Bug: 34872689
Test: manual
PiperOrigin-RevId: 169953610
Change-Id: Ib1c25ddecbf28293b447112cb280a8f9788692d3
|
|
besides app launch latency. Alert functionality is not included in this cl.
Add a new idlingResource for incall ui and a new method called waitForInCallUiShown in DialerCallEspresso.
Add UiListener interface in CallList and insert uilisteners on onCallAdded() and onInCallUiShown().
Also, a g3doc page has been created in http://cl/168901452 to show the dashboards.
Test: Run on a local device
PiperOrigin-RevId: 169934618
Change-Id: I0ea10aca051c62cd8252ee5a3c9dfbce81316a33
|
|
Change verizon's ToS title to use the string 'visual voicemail'
This change seems a bit strange since the verizon legal text uses the string 'Visual Voice Mail', but the title uses 'visual voice mail'
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuIR1lmaUF4OXk1SnFLdS1fbFpfMlFieWlTQ25v
https://drive.google.com/open?id=0B9o_KvtLkcuIRURWd0hhYjc4NUdKQ1hzM2RIcG5fSmlHcGhJ
Bug: 37340510
Test: update unit tests
PiperOrigin-RevId: 169933539
Change-Id: Idba526293604b7a27083a91b86825ef66ce23bcd
|
|
Screeshot:
Before:
https://screenshot.googleplex.com/bnByOaCTV4O
After:
https://screenshot.googleplex.com/v0vhkuuvT28
Bug: 38347145
Test: manual
PiperOrigin-RevId: 169933363
Change-Id: Ia3728be488ff329531c171b03a3045f1839d1d5e
|
|
The problem was that the same notification id was being used by
both VisualVoicemailNotifier and MissedCallNotifier, causing the
voicemail notification update code to filter out missed call notifications
instead of ignoring them.
Bug: 66168999
Test: manual and verified existing unit tests pass
PiperOrigin-RevId: 169925851
Change-Id: Ifa69506a250557dd7bba631122fdd6d0744d6341
|
|
We think it's viewed by user if it's showing and user scrolls on call log tab,
since action in the same tab that moves the dialog is a strong proof.
Test: GoogleCallLogAdapterTest
PiperOrigin-RevId: 169763132
Change-Id: Ie520c65627b1e5d364860507321fb268c89e0cf7
|
|
We moved onUiShowing() call from InCallActivityCommon.onPause to onStop in
cl/169615685, which causes the crash since InCallPresenter is cleared up before
calling onUiShowing() and mContext is null at that time.
This CL fix the crash by also moving the clearup(InCallPresenter.unsetActivity()) from onPause
to onStop. It also makes sense because InCallPresenter.onActivityStarted() is
called in onStart instead of onPause.
Test: manual
PiperOrigin-RevId: 169756942
Change-Id: I222009be1b672f8a6dcb8bfdcea2d633c5810575
|
|
Bug: 35359461
Test: none
PiperOrigin-RevId: 169752834
Change-Id: If78723774babb86a55e07d4b94d9f1d784791b76
|
|
screenshots
http://screen/d2qPOq3h1o1
http://screen/wHcnO5LXRO2
Bug: 65858857
Test: n/a
PiperOrigin-RevId: 169748652
Change-Id: Ie255f0d9be958f004c8bc9639d478553f66109d3
|
|
video call upgrade and calling from call log is logged
Bug: 66222115
Test: DialerCallTest, GoogleCallLogAdapterTest
PiperOrigin-RevId: 169703001
Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b
|
|
Also fixes an issue where if the promo is shown after the dialpad or search UI is brought up then the promo will be added to the bottom of those UIs.
Bug: 64491095
Test: manual
PiperOrigin-RevId: 169700496
Change-Id: I76a1aa977df623964b843d8e4b20146ba7c2f874
|
|
SimpleDateFormatter just wasn't working. This CL simplifies this method to
something similar to what we had before the call details rewrite. To avoid
going through the trouble of having the strings retranslated through the i18n
coordinator, I've left them as is and worked around it.
screenshots:
before: http://screen/eJqs5EijCYe
after: http://screen/AbrLFn0caL0
Bug: 63370483
Test: existing
PiperOrigin-RevId: 169626011
Change-Id: I160529e276db2fc098a29b005db104e7ac601f15
|
|
By moving InCallPresenter.onUiShowing() from InCallActivityCommon.onResume/onPause to onStart/onStop.
Test: manual
PiperOrigin-RevId: 169615685
Change-Id: I146a5d87028040b0f5e587b8163f29d55b9e7ff7
|
|
To repro the bug:
1) Turn on "Don't keep activities" option in developer options
2) Open dialpad
3) Press home
4) Launch dialer from home screen
5) Observe blank screen
Bug: 65458054,64129606
Test: unit
PiperOrigin-RevId: 169614750
Change-Id: I65e53add0f1f53c510c402f4f8b7ed60dcef273b
|
|
Outgoing video call: https://drive.google.com/open?id=0B7uuA4cyYX0xQjhUTGhrUWRKUlE
Incoming video call: https://drive.google.com/open?id=0B7uuA4cyYX0xZFMyREVDWVNqaE0
Outgoing upgrade: https://drive.google.com/open?id=0B7uuA4cyYX0xdll3elRsUWhDT3M
Incoming upgrade: https://drive.google.com/open?id=0B7uuA4cyYX0xZFMyREVDWVNqaE0
Incoming upgrade (Wi-Fi): https://drive.google.com/open?id=0B7uuA4cyYX0xWkJ6dU16Rmd1ckk
Bug: 65131278
Test: manual, screenshots
PiperOrigin-RevId: 169612967
Change-Id: I5163be6966ed7d68d19cff51e0d1637bd20b2c7e
|
|
Bug: 64302851
Test: manual
PiperOrigin-RevId: 169600984
Change-Id: I65376894012f2d570b6c918f3f5575e7f45bf938
|
|
1. Use existing country iso info instead of guessing current country iso from sim and locale for blocked number.
2. Use country iso of current sim instead of default sim for incall location info. This fixes bug in multi sim device when default sim is out of service and making call with the other sim.
Bug: 65399976
Test: manual
PiperOrigin-RevId: 169554641
Change-Id: I416d7e2d6bc3c872bfec3eda4005a5a1684f0e40
|
|
Illustration icon TBD
https://photos.app.goo.gl/ZDLNLlXg9VBKNHGx1
Manual testing of duplicates promo end to end flow accept/dismiss states
Bug: 64491095
Test: http://sponge/db7bd5c3-ec97-46c8-a058-ed7f46a5e4ce
PiperOrigin-RevId: 169480950
Change-Id: Ia553e87ce72d84a001769851abb925da1ab31756
|
|
screenshots:
ongoing: http://screen/FkAM9hOU5Rq
paused: http://screen/mrp6UJCoWAu
Bug: 63274792,63271690
Test: StatusBarNotifierTest
PiperOrigin-RevId: 169469414
Change-Id: I442e21d93b7e11dea191311acd28846ea257c156
|
|
This change adds a dismiss button to the location permission prompt shown in
the search UI. A few other minor changes:
- Permission prompt is always the first element in the list
- Adjusted a few dimensions and strings
screenshot: http://screen/9CkRPUQ5dwh
Bug: 65858857
Test: SAT, NSFT
PiperOrigin-RevId: 169466585
Change-Id: I8177c23fe3f635fec5fdcdbe6675428cebb19f5d
|
|
Bug: 62426694
Test: none
PiperOrigin-RevId: 169447674
Change-Id: I3014b289c26d24ac571421bc54fcacc303278b41
|
|
This change adds a prompt inline the search fragment list view
to request the location permission (if they haven't already
granted it).
screenshot: http://screen/upu9t55mghq
Bug: 65858857
Test: NSFT, SAT, SCMT
PiperOrigin-RevId: 169447095
Change-Id: I6c312057ff3c4e2362ce21b0c57e1e5de7b25ce0
|
|
Test: TH
Change-Id: I48e807f3eafbc82401b2674a2610b20bf118c275
|
|
//google/internal/communications/voicemailtranscription/v1/voicemail_transcription.proto
Test: n/a
PiperOrigin-RevId: 169425975
Change-Id: I0d53a576e1245cc1c4d7c8e36df3a510d8c7bdbe
|
|
The underlying issue was that if a query was input that filtered out all of the
on device contacts, then the device rotated, the cursor would be reloaded with
all contacts filtered and getCount == 0. This would cause the cursor to never be
set in SearchCursorManager and on device contacts would no longer be shown
because the cursor wasn't being saved.
The reason this check was here, was because cursor headers were being managed
by SearchCursorManager. Since headers were moved into the cursors we no
longer need to set cursors to null if they are empty.
Bug: 65859191
Test: existing
PiperOrigin-RevId: 169425922
Change-Id: I0baf31c3747d679f394f3746f609b9487e52472d
|
|
Bug: 63608380
Test: none
PiperOrigin-RevId: 169425768
Change-Id: I297b945c9601bb070f3ef08d7ca34a76629b42c7
|
|
Also repostion contact icon (for allen, is there a bug for that?)
Originally i tried wrapping the transcription in a ScrollView,
but that didn't really work since there's no easy way to set
a max-height for it. Since most voicemails transcriptions are
not that long, an easier solution was just to not limit the number
of lines for the transcription.
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuINkdXeVV0U0dOZVNfdExzSDNsai1Ld2F3ZlBN
https://drive.google.com/open?id=0B9o_KvtLkcuIZTZFQzRQaW1nblBPN2JkVW1hMkR3YWl1b2JV
Bug: 64211399
Test: manual
PiperOrigin-RevId: 169425482
Change-Id: I63c9165f48d902c06e288280116cd9b95d67852c
|
|
When a user dials a number with post dial digits, they are now
carried to contact details and used when they redial that number.
Additionally, when a user clicks on a photo in call details, they will
be taken to Bugle now. This behavior already exists with messages in CD.
Bug: 62236726,62230491
Test: CDEVHT
PiperOrigin-RevId: 169422921
Change-Id: I1507cb64876540cfc9a683a5a1ea01910443f77b
|
|
Bug: 65980572
Test: manual
PiperOrigin-RevId: 169336670
Change-Id: I6acd6226c1a03b8f0c12309bc84ae7c2bdad5f30
|
|
This CL partially revert cl/159492498, since data SMS cannot be properly processed under FBE and visual voicemail notification won't be received.
Bug: 65555345
Test: LegacyVoicemailNotificationReceiverTest
PiperOrigin-RevId: 169321096
Change-Id: I7134d80479efef67de8d5d44131eea30f82297a0
|
|
The problem was that the query for looking up a voicemail by URI was broken
which was causing the notifications to be cancelled then when they were supposed
to be updated they were actually getting re-added thus causing the notification
sound.
Bug: 65692173
Test: manual and unit test
PiperOrigin-RevId: 169304391
Change-Id: I1e8f648231b6f0ab984a5b0e4facd8351b01391a
|
|
Just easier readability since getFirstCall() is null until it's added to the call map.
Test: N/A
PiperOrigin-RevId: 169287247
Change-Id: Ifda5ead27d987e17f259da761a0109d930efa6c3
|
|
Lightbringer.supportsUpgrade() is changed to return absent optional when it does not have data for the number. Seeing this LightbringerTech will use Lightbringer.updateReachability() to retrieve it from the remote package, which will store it in the reachability cache.
Bug: 63601277
Test: RemoteReachabillityQueryHandlerTest, LightbringerTechTest
PiperOrigin-RevId: 169283953
Change-Id: I3f26d9158fc6cfed196fd533da2aad598c8e6a7a
|
|
Bug: 65648343
Test: updated unit tests (already submitted in previous cl)
PiperOrigin-RevId: 169280819
Change-Id: I5950087765ffd038c31b872c6468951472980407
|
|
Zero suggest in dialpad search clutters the UI and we shouldn't show and search
results until the user has input something into the dialpad.
Additionally, this change ensures the fab stays hidden through device rotation
in regular search.
Bug: 65858825
Test: implemented
PiperOrigin-RevId: 169270161
Change-Id: Ia08ce56ffd02f74ea9e4d9d8a1efc3726fcc66d9
|
|
Bug: 37242283
Test: none
PiperOrigin-RevId: 169270157
Change-Id: Ic07df7a1611ebf1b997f1a908fa341f9bf542cbd
|
|
Add action button when create in call notification and when audio state changes to ROUTE_SPEAKER or ROUTE_WIRED_OR_EARPIECE. Ignore when audio state is ROUTE_BLUETOOTH.
Screenshot:
Speaker on: https://screenshot.googleplex.com/hnsQL0YcFJj
Speaker off: https://screenshot.googleplex.com/oFrbvbs9gVG
Test: StatusBarNotifierTest
PiperOrigin-RevId: 169169372
Change-Id: I2f96f20170dd174b35dfd3f7578fe5b9450391ab
|
|
And fix a related test in ImsVideoTechTest.
LOG_STORAGE_INCREASE(GB/week): 0.7
5M active block user/day * 10 events/active = 350M event/wk
350M event/wk * (2 [bool])/event = 0.7GB/wk
Test: LoggerUtilsTest
PiperOrigin-RevId: 169153878
Change-Id: Ia8038a5b0961f1a5572541f21df7a2680d85bbbb
|
|
So we can associate all bubble actions with call id, and analyze bubble actions per call session.
Also move code for sending primary action back to primaryButtonClick(), which is introduced in cl/167347311.
Test: manual
PiperOrigin-RevId: 169152088
Change-Id: I97f0971f162684d882f6addbc012f6e8552216b7
|
|
The subcription number might be different than the line1 number (sim number),
which could be confusion to user during emergency call when it's not same as
the sim number the user knows of.
Bug: 65685277
Test: manual
PiperOrigin-RevId: 169147724
Change-Id: I2f89559d10a188b13937e80528b756cc9b11a02e
|
|
This CL adds logic to persist the search query and call
initiation type through configuration changes like device
rotation.
list of bugs:
https://docs.google.com/document/d/1GajzkAqXXRqbj_-qeYeDxIKr0fPsSZC3nXhRkIQg5tE/edit#heading=h.bopot1qivvxg
Bug: 65751247
Test: NSFT
PiperOrigin-RevId: 169146766
Change-Id: I7a68c01d5698c07a362ad621642a9138fd9a9aaa
|
|
v13 is now at go/dialer-v13, I've set it's max version to 1899999.
Test: N/A
PiperOrigin-RevId: 169123311
Change-Id: Ib8304953d0ad974a2f22c1b390ff3bb180360244
|
|
Bug: 65686665
Test: manual
PiperOrigin-RevId: 168983351
Change-Id: I6443a05c8435e777c52ed3586dfc228a0fb0f51f
|
|
Bug: 65687672
Test: existing
PiperOrigin-RevId: 168951800
Change-Id: Ie840acd608424551198ba3440d6060a7cd7a629f
|
|
Users using touch to explore with TalkBack on the dialpad would occasionally
call voicemail if they hovered over 1 for a long period of time. This
functionality doesn't align with keyboards, where a long hover still acts as a
normal click. This CL updates the Dialpad to align better with a keyboard and
now users can only speeddial voicemail and type a 0 with double-tap activation.
Bug: 62712616
Test: manual
PiperOrigin-RevId: 168909308
Change-Id: Ib46342f173aef7c2ef64c2b42745966f83266b98
|
|
Also replace deprecate android:singleLine=true with android:maxLines=1
video: https://drive.google.com/open?id=0B9o_KvtLkcuIWGVBOElWdFNKa1E
Bug: 65678844
Test: manual
PiperOrigin-RevId: 168858718
Change-Id: I8be70e8496a8f0c562ca09eb315bb4e28b3e9c00
|
|
verizon TOS screen shot 1: https://drive.google.com/open?id=0B9o_KvtLkcuIU3VpLUpqcXBUYy1QY19UUk81a29sdGQyNEZZ
verizon TOS screen shot 2: https://drive.google.com/open?id=0B9o_KvtLkcuIN3R6SUFjS3RVTWhZQUM1UzhoajhNUF9ZbzJJ
non-verizon TOS screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIeVFYaWhYZmRzYVctU2F6N1VqazcycGpmNmRZ
Bug: 37340510
Test: manual and update unit test
PiperOrigin-RevId: 168851805
Change-Id: I7be27360093cae315b7249152e10d1beae5c5966
|
|
Bug: 65212837
Test: DialpadFragmentTest
PiperOrigin-RevId: 168745371
Change-Id: I62da45cdac58e3387343589b952e5d6bce7a4ee2
|
|
Test: manual
PiperOrigin-RevId: 168612783
Change-Id: I811133aee3301bac6936d5ba101719c30322d3be
|
|
VVM can be "activated" through restoring shared preferences from another device. In this case the SMS filter in telephony is still not configured, and needs to be set up.
Bug: 65542413
Test: ActivationTaskTest
PiperOrigin-RevId: 168560153
Change-Id: I46dd9b31e43899d8d567e7e6baebf06559548525
|
|
Bug: 64399026
Test: None.
PiperOrigin-RevId: 168456040
Change-Id: I65fdae8dff1c9bb8e05e79f3ece2480b92f08c69
|
|
Test: manual
PiperOrigin-RevId: 168427349
Change-Id: Ie58920b76266ebb298210b5faac8fcbda4dbcd15
|
|
If it's a swipe, onPageScrolled() is called several times before onPageScrollStateChanged(SCROLL_STATE_SETTLING) and onPageSelected().
If it's a click, only onPageScrollStateChanged(SCROLL_STATE_SETTLING) is called before onPageSelected().
And onPageScrollStateChanged(SCROLL_STATE_SETTLING) will not be called if user don't switch to a new tab.
We use the difference to tell if user switching tabs by swiping or clicking.
Test: DialtactsActivityTest
PiperOrigin-RevId: 168403148
Change-Id: Iaaf84ab9c4955d0bc2c1e9857ba59fd37b3984af
|
|
When opening a voicemail setting from Dialer with
ACTION_CONFIGURE_VOICEMAIL, no subId is passed.
So on a multi-SIM device, it is always configuration on the default
phone regardless of SIM.
To solve this, set the PhoneAccountHandle to intent extra for
ACTION_CONFIGURE_VOICEMAIL. In the advanced settings, obtains subId
from the PhoneAccountHandle.
Test: manual - Checked that correct PhoneAccountHandle will be passed
with ACTION_CONFIGURE_VOICEMAIL intent
Bug: 65001008
Author: xuegang.x.liu <xuegang.x.liu@sony.com>
Bug: 65001008
Test: manual - Checked that correct PhoneAccountHandle will be passed
PiperOrigin-RevId: 168019873
Change-Id: I8578dd2c4ac24e4af121a90b2b175baae2832461
|
|
Bug: 64716624
Test: manual
PiperOrigin-RevId: 168017541
Change-Id: Ia8e581f19a0a9c4d45bacc4ab94e54131763640a
|
|
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search results if the results do not fill the entire
view. The keyboard overlaps the results and there is no way to get to the
enter list without dismissing the keyboard.
10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow
points down but works like back button
Bug: 62685859,63691995,63939331,64137632,64902476
Test: manual
PiperOrigin-RevId: 168004913
Change-Id: Ia566fce6d90454a3eae6ecccfa81ce7e909e878f
|
|
This is mostly just a revived version of cl/158901400. It adds a job service that is triggered by changes to the voicemail database. The job updates voicemail notifications,
as necessary.
video of notification update:
https://drive.google.com/open?id=0B9o_KvtLkcuId1ptNk1EbGotWFU
Bug: 37340510,27535759
Test: manual and unit test
PiperOrigin-RevId: 167934550
Change-Id: I36f03c0769645f7a0cb478172171f1079eca2108
|
|
Changing voicemail notifications to match the latest mocks,
(replacing the 'Voicemail' title with what was the notification
content, and putting the voicemail status or transcription in
the notification content). The notifications will be updated in
a following cl.
screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIbDdjaTNHTFFZLW9YZEo1SG5scDR6SzloaWc4
Bug: 37340510
Test: manual
PiperOrigin-RevId: 167928866
Change-Id: I81492f7fbf1cc398401a948e036854d6a8ff878b
|
|
*** Reason for rollback ***
Turns out blocked number activity is actually used for devices on M.
*** Original change description ***
Removes the unused dialer/app/filterednumber package.
***
Test: n/a
PiperOrigin-RevId: 167663280
Change-Id: I6af1fc7d6eb61f946d4fba255fe7374bcdee0e72
|
|
*** Reason for rollback ***
Based off a CL that needs to be rolled back.
*** Original change description ***
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search...
***
Bug: 64902476,64137632,62685859,63691995,63939331
Test: n/a
PiperOrigin-RevId: 167661409
Change-Id: I0627d54af33fb55c64b5edcd459dde6a73d93266
|
|
-add branding 'Google is transcribing'
-add branding 'Transcribed by Google'
in-progress screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVVTX3BBZkNzV180alZPQ3EtR3gzRFNoamhV
transcribed by screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuISUdaRjBlUFpjYTBWWTg1STVHS0oyQmNiSUVR
Bug: 37340510
Test: manual
PiperOrigin-RevId: 167620447
Change-Id: I5526bebb6999cf77b0902ae50ca72e380538a6e7
|
|
Apparently, scheduling a new job when one is already running (even using the enqueue api) causes the running job to be stopped. We weren't handling that case correctly. This cl makes sure no more work is attempted after a job is stopped by cancelling any
active transcription task. We request that stopped task be rescheduled by the job scheduler, so it will get run eventually.
I was able to verify this fix by sending a new voicemail while backfill old transcription tasks were running.
Bug: 64908823,63524274,65129734,63803709
Test: manual and unit tests
PiperOrigin-RevId: 167617191
Change-Id: Icc92997c2687e61bef9b3b7f9ff572da2cb4ed2e
|
|
Each trace info will add several milliseconds overhead and it's not used by end user.
Bug: 64542087
Test: none.
PiperOrigin-RevId: 167614347
Change-Id: I70c032fde162d6c8aa46be72c9ece3b7c3249fe8
|
|
The override config is used by carriers to test out different configs using a prod dialer. Previously the type was loaded before the override config, causing carriers that is not currently supported never able to force enable VVM.
This CL also fixes getCarrierPackageNames() and getDisabledCapabilities() not loading the override.
Bug: 65370543
Test: revived OmtpVvmCarrierConfigHelperTest
PiperOrigin-RevId: 167614182
Change-Id: Ibafdaf5fdc3e948bc65656f94c4bdc7d6e97046c
|
|
When AudioRouteSelectorDialogFragment tries to call
onAudioRouteSelectorDismiss() on its parent AudioRouteSelectorActivity, the parent might already finish,
which causes NPE. We should make sure the fragment is dismissed and removed before the activity finished. We do it when activity onPause because we don't expect it to resume.
Test: AudioRouteSelectorDialogFragmentTest
PiperOrigin-RevId: 167607068
Change-Id: Ifd2efcc92eb45262da2c6441bfac8119799d78f2
|
|
When the call log is restored by the system, all items are marked as new even though they could already been read. This causes a torrent of "missed" calls after restoring call log with the setup wizard.
This CL ignore read entities in the query.
Bug: 62871863
Test: CallLogNotificationQueryHelperTest
PiperOrigin-RevId: 167602820
Change-Id: Iba5609ace895a309685bfcd61eae85e080562ec5
|
|
This CL switches Dialer to use the new common bubble libary. It also moves the
integration tests into the bubble libary.
Bug: 64797730
Test: BubbleIntegrationTest
PiperOrigin-RevId: 167439680
Change-Id: Ie2e9367cb6a6561efb8abd425b6a12f8c1e78138
|
|
Users can now create new contacts, add to existing contacts, send sms and make
ViLTE calls from dialpad search results.
screenshot: http://screen/7iR038nUvmh
from the bugbash:
11. Missing “Create new contact” “Add to a contact” “Send SMS” from search results with a phone number search
Bug: 64902476
Test: many
PiperOrigin-RevId: 167362073
Change-Id: I2f94d863035c119ec526e02e088992c618a858a9
|
|
Allowing click or moving bubble when hiding bubble makes no sense. Also, hide()
and swapViewHolders() (called when expand/collapse) may add/remove the same
view to windowManager and cause crash.
Before: https://drive.google.com/a/google.com/file/d/0Bz1rQbdSCWSKRDEyT2JDdk9LVDA
After: https://drive.google.com/a/google.com/file/d/0Bz1rQbdSCWSKUE53aldna0RFVFE
Test: BubbleTest
PiperOrigin-RevId: 167334496
Change-Id: Id7f5ce4bdfa074840c1e9fac981abad59e261c0e
|
|
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search results if the results do not fill the entire
view. The keyboard overlaps the results and there is no way to get to the
enter list without dismissing the keyboard.
10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow
points down but works like back button
Bug: 64902476,64137632,62685859,63691995,63939331
Test: manual
PiperOrigin-RevId: 167332236
Change-Id: I1c0b5b429316dae119b5fb21be4303d7fe052e35
|
|
We need to use the Context to check if the device is a ODR device for a workaround (http://cl/165734624). It turns out the Context can be null (rarely). In those cases, we should not crash.
Bug: 64954483
Test: manual
PiperOrigin-RevId: 167326838
Change-Id: I4d8d8de86b5e3a4eca165a562f2ddc6106052c6e
|
|
This CL updates version codes and name for Dialer v12.1 to 17*****. Doing so also bumps v13 to 18*****.
Test: N/A
PiperOrigin-RevId: 167326768
Change-Id: I3765a9ae8b06669a3eb96fef03a8a1432b3fc278
|
|
These new states will be used to show descriptive failure messages to the user.
Also moved the VoicemailCompat class to avoid duplicate code.
Bug: 37340510
Test: none
PiperOrigin-RevId: 167314611
Change-Id: I618d7f196ea2b0161cbd33479553cae3521328d7
|
|
Test: manual
PiperOrigin-RevId: 167310802
Change-Id: Ie27a1b2f4daf73133edfb9de7f4e4aff1d87b6c8
|
|
Somehow a null action will be sent to the receiver.
Bug: 64934925
Test: LegacyVoicemailNotificationReceiveverTest
PiperOrigin-RevId: 167300542
Change-Id: Ifa001d102d265e1dad42806b48f0a1710d05b195
|
|
This CL uses the simulator connection service to perform integration
tests for incallui.
The main pieces of this CL are:
- DialerCallEvent - this is how we track changes to the incallui calls
- Simulator.Event - this is how we track changes to a simulator
connection
With the above two we can do things like:
- block until a DialerCall switches from ACTIVE TO ONHOLD:
- DialerCallEspresso.waitForNextEvent(tracker, call, new
DialerCallEvent(STATE_CHANGE, "ACTIVE", "ONHOLD")
- block for a connection to recive a particular DTMF code:
- SimulatorConnectionEspresso.waitForNextEvent(call, Event.DTMF)
Future CLs will include things like:
- fling to answer / reject
- conference calls
- screenshot diffing
- video calling
Test: InCallActivityTest
PiperOrigin-RevId: 167211015
Change-Id: Ib013b10fe963092fad0816b07b1659efd69d9468
|
|
screenshots:
default: http://screen/qEdB51A3PDn
zero-query: http://screen/qEBDg0auGA8
query: http://screen/SuLp2GwyvYr
Bug: 64806278
Test: manual
PiperOrigin-RevId: 167205946
Change-Id: I07563fd23801da8d9d2eb95f6d09a079474403eb
|
|
This save us ~180ms on Go device. (analyzed by systrace)
This change also adds some trace information on incallui.
Bug: 64542087
Test: manual
PiperOrigin-RevId: 167201182
Change-Id: I0e8549cfb3534d518e3990696616855bcf7733f2
|
|
The TelecomManager#isInCall method returns true anytime the user is in a call.
Starting in O, the APIs include support for self-managed ConnectionServices so that other apps like Duo can tell Telecom about its calls. So, if the user is in a Duo call, isInCall would return true.
Dialer uses this to determine whether to show the "return to call in progress" when Dialer is launched.
Instead, Dialer should use TelecomManager#isInManagedCall, which only returns true if the device is in a managed call which Dialer would know about.
Bug: 36991070
Test: none
PiperOrigin-RevId: 167200903
Change-Id: I12ac7b893dcbfa2fc842ca5ab356fbbc490a098b
|
|
If the user disabled VVM on pre-O devices then upgrade to O, dialer will not setup the filter because VVM is disabled. The legacy mode which translate VVM SMS into traditional notifications needs the filter to operate. This CL sets up the filter if legacy mode is used.
Bug: 65050952
Test: ActivationTaskTest
PiperOrigin-RevId: 167199492
Change-Id: I2c77f0c6964b157d36bfa2adde7169b9ac6ccc3a
|