Age | Commit message (Collapse) | Author |
|
calldetails package.
Test: tap
PiperOrigin-RevId: 174084052
Change-Id: I10c07767392060fafed048a74df5aece4090cd68
|
|
Refresh heads up notification to show only accept and reject options when
incoming Video call is handed over to CS.
Author: Suresh Koleti <skolet@codeaurora.org>
Bug: 63157046
Test: StatusBarNotifierTest
PiperOrigin-RevId: 174077146
Change-Id: Ic74d5a201392c6764ee33f1512bf528f86b80f69
|
|
Test: Run in dialer lab
PiperOrigin-RevId: 174075702
Change-Id: Ib663dc34d2c0c9e737c6d5f13b16d2b42b714127
|
|
We need to be able to write the shared prefs when the device is in direct boot mode, and this data is not sensitive so can be unencrypted.
Bug: 68350256
Test: existing unit, manual
PiperOrigin-RevId: 174075154
Change-Id: Ib52e11c6abba0812d1dc07c642691359089c3e6e
|
|
We now use dagger everywhere for consistency and explicitness.
Test: tap
PiperOrigin-RevId: 174071122
Change-Id: I15d2f8261a7b753353be9e7d3b80692aa0c1b64d
|
|
This allows users to override our automatically selected country code.
Bug: 63994464
Test: unit tests
PiperOrigin-RevId: 174064853
Change-Id: I12bd770300b041f3c7d5b8d5f5c0b75c4945492e
|
|
Bug: 67785540
Test: On a walleye.
PiperOrigin-RevId: 174062497
Change-Id: I757b423f1c9ffe286fab15d3d8b5be8fe7c549dc
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174055180
Change-Id: Iac6deb8f9dcb6f3e9da6dfd0d732f29cc34bb7f6
|
|
Because the phone is one of the few applications that operate
when the phone is locked, disable the feature to avoid reading/writing
any encrypted preferences while the user is in the locked state.
I do not anticipate this being a necessary feature when
the device is locked.
Bug: 65399148
Test: unit test
PiperOrigin-RevId: 174044403
Change-Id: I1b9a2ac677ced2af06455a384bf169c417ffc1a5
|
|
Test: none
PiperOrigin-RevId: 174042820
Change-Id: Ia09f55d9f38b9335b23234cfe399987a3f3a65b1
|
|
Fleshed out docs for PhoneLookup.
Added dagger components and modules.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 173977963
Change-Id: If07795d9d3d56a59afd27cdda3e98543bf30fdb8
|
|
app open
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change.
This change also fixes flaky test of voicemailTabVisibleNotVisible_volumeStreamCorrect.
Bug: 64541209,65460373,67297718
Test: DialtactsActivityIntegrationTest
PiperOrigin-RevId: 173734472
Change-Id: Ifd4a3064a6fdcffe5a373eaad6ee4aeebdadda1e
|
|
The bug is caused by old StatusBarNotifier object cancelling new notification. Remove listener for InCallPresenter is safer than for StatusBarNotifer.
Test: manual
PiperOrigin-RevId: 173734079
Change-Id: Iefdc2d0e399da97bf31dbd5f99beb9ed34bcd874
|
|
This CL accepts this AOSP CL: ag/64881150
Author: Ravi Paluri <rpaluri@codeaurora.org>
Bug: 64881150
Test: manual, ImsVideoTechTest
PiperOrigin-RevId: 173734014
Change-Id: Ibccc610c85c4bd06f34fc6bb057c356dd74f362d
|
|
Bug: 62423454
Test: manual and updated unit test
PiperOrigin-RevId: 173731907
Change-Id: Ic73600197b1c4fa6ac0937a8c38b048cd8faded8
|
|
In portrait mode, we surround the icon and letters with a linear layout so that we can adjust its height.
In landscape mode, we add a horizontal placeholder to each key's layout so that we can adjust its width.
This approach was put forward by Ryan Oldenburg (roldenburg@).
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 173717443
Change-Id: I9b60657ca20d371a60c303a9683578663fc28a09
|
|
No changes are made to the portrait-mode UI.
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 173710022
Change-Id: I9ef8a57b044e069af2eb886ea6baa30c279f4f70
|
|
Add hold button for all phone types and rely on SUPPORT_HOLD capability to show it.
The issue is that if GSM call is made on devices with CDMA + GSM sim, the default phone type is CDMA so the hold button is not available. This change is a workaround that adding hold button to CDMA button chooser so button choose of all phone type has hold button available and it's totally controlled by telecom's CAPABILITY_SUPPORT_HOLD and CAPABILITY_HOLD. It shouldn't affect CDMA call.
Idealy we should use correct phone type but unfortunately it's not well supported on pre-O device.
This is upstream change from
https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/482377/
Bug: 63911282
Test: ButtonChooserIntegrationTest
PiperOrigin-RevId: 173614690
Change-Id: I6e17c1cc69ad50b1ba4c9b09804d5a7b5eeaf496
|
|
The current implementation is easy to read but causes klippy warnings.
Also removed the AnnotatedCallLogDatabaseHelperTest.voicemailColumnsExist and combined it with the onCreate Test
Test: Unit Test
PiperOrigin-RevId: 173614534
Change-Id: If00f7e91f48e582aa481268d88a4871cc2364684
|
|
DialerUtils#getDefaultSharedPreferenceForDeviceProtectedStorageContext(Context) to StorageComponent.
Bug: 30224215
Test: none
PiperOrigin-RevId: 173612463
Change-Id: Ia89d5d85c31ea2114b196393ae43b803023fc9bf
|
|
When dialer application class got launced but GoogleDialtactsActivity was not launched, there was an unstopped timer started by dialer application, causing the measurement to be very huge next time.
Test: Run on devices in dialer lab.
PiperOrigin-RevId: 173570185
Change-Id: If835c7b0b7cf01b9ec3f7bc36a5104f57c697908
|
|
This change also add a handy adb command script run before UI integration test.
Bug: 67429956
Test: IncallActivityTest
PiperOrigin-RevId: 173565382
Change-Id: I9b8b957f00a0b7d11dbb7f40e8c9f1dbdb8c3928
|
|
Checks if a cp2 contact has been modified or deleted.
Bug: 67605130,64099602
Test: Cp2PhoneLookupTest
PiperOrigin-RevId: 173499443
Change-Id: I1fa267c05732fba09f00113232d4370b159aa735
|
|
Migrate the existing app latency test to a new solution from Project Fi team.
The main change on this new solution is that the data collection part is done by Primes now.
Also, a few changes has been made on DialerPrimes class and a new Dialer variant dialer_release_test has been created.
The benefits of using primes to collect data are:
1. latency tests dont need to insert lines of code to track latency in dialer codebase
2. be able to collect data on any variants with or without Proguard
3. latency tests now only contain ui interaction to trigger scenarios on which we want add measurements
4. share the same logic with primes on production so that data from testbeds and normal users are comparable.
5. easier for anyone to add interesting data entries.
----------Mobile Harness Below-----------------------------------
RELNOTES[INC]:Add entries for dialer to use mobileharness plugin.
Test: No
PiperOrigin-RevId: 173481741
Change-Id: Ia6812794141382898bea4b34bca90278c5663464
|
|
Moved SearchContactViewHolder listener logic from SearchAdapter
to SearchFragment to make it easier to close search after placing a call.
Bug: 68201142
Test: existing + DialtactsActivityTest
PiperOrigin-RevId: 173454972
Change-Id: Ib5715d0f427d62344641b4bf841d34145fc3f65e
|
|
The locked phone icon will be shown for voice privacy call on CDMA for non-hold status(dialing, ongoing etc.)
The onhold icon is same as usual.
This change also update on hold icon to quantum vector drawable resources.
WANT_LGTM=all
Bug: 37529280
Test: StatusBarNotifierTest
PiperOrigin-RevId: 173451922
Change-Id: I71d4c03b6953ca72def339c9c0a77bacbaf145f8
|
|
Bug: 68143529
Test: none
PiperOrigin-RevId: 173439449
Change-Id: I80ebb4e8b17551144e492424e7aa6d92f26cc576
|
|
We were not using the VideoTech interface for these calls and as a result could
not restore the camera when swapping calls.
Bug: 68160072
Test: manual
PiperOrigin-RevId: 173437432
Change-Id: Iec1d363178e2332014f95246637c23f9040cdfee
|
|
Follow repro steps to see contacts promo always consistently shown
Bug: 68158965
Test: manual
PiperOrigin-RevId: 173427472
Change-Id: I3717ee674aa81d1f1c563920796ef0f21dcdd963
|
|
VoicemailUri is required to play voicemail audio files. We need it to be able to play the voicemails in the voicemail tab. A follow up CL will be using the uri to play the audio, but via a media player.
Bug: 64882313
Test: Unit tests
PiperOrigin-RevId: 173422683
Change-Id: Ib438e3020c83e11a2c54c3e941c93e83dba9bc90
|
|
By always creating executor services via dagger, we can now bind special versions during espresso tests that can implement idling resources. We should be using idling resources during espresso tests for threads that we create ourselves, because espresso does not know about them.
Hopefully this reduces some of the flakiness of espresso tests that we have today.
This required converting all existing calls to DialerExecutors to pass a context used to fetch the component, and also required creating new application classes for espresso tests.
Test: temporarily added a task which just slept to DialtactsActivity and verified that its integration test failed due to idling resource timeout
PiperOrigin-RevId: 173334773
Change-Id: I876a93022d235d62cfc377bf5b06687e21a34758
|
|
It didn't sit well with me that we would check for platform eligibility
in two places.
Test: existing unit tests;
PiperOrigin-RevId: 173334224
Change-Id: Ia7075bc40e935c2794646671b5cfea34b7a06afb
|
|
It fixes AOSP for package name conflict.
Test: manual
PiperOrigin-RevId: 173298696
Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
|
|
*** Reason for rollback ***
Causes crashes on rotation: http://b/67839843
*** Original change description ***
Do not load every DialtactsActivity fragment on app open
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the ch...
***
Bug: 64541209,65460373
Test: Manually verified regression fixed
PiperOrigin-RevId: 172684553
Change-Id: I9a5b30d6619d930adfb82b19ac3ff9da00decaaa
|
|
call log UI.
Currently we use PhoneNumberUtils#compare(String, String) to determine whether two numbers in the call log should be grouped. The method ignores special dialable characters such as "#", "*", "+", etc, which can cause phone numbers and service dialing numbers to be grouped.
For example, suppose the user has a contact named "John Smith" with number 123456789 and a contact named "Service" with number #123456789, and called each contact once. The old grouping logic will put the two numbers in the same group.
The new grouping logic in this CL can separate the two numbers.
Bug: 30225112
Test: CallLogGroupBuilderTest, PhoneNumberHelperTest
PiperOrigin-RevId: 172683494
Change-Id: Ie9e7b7418d6d7c74830cbae09c04ff1feb1b827d
|
|
Bug: 36565933
Test: manual, just moving
PiperOrigin-RevId: 172671853
Change-Id: I415f5b7e518cca22fad96b017a573322af3f73be
|
|
In InCallServiceImpl.tearDown(), we should only clear inCallService after
InCallPresenter.tearDown() where we remove all notification.
Also remove null
assertion in stopForegroundNotification() since other crash should only happens
when there is no notification.
Test: StatusBarNotifierTest
PiperOrigin-RevId: 172657924
Change-Id: I86e720b80f885aa93f12215fda899ee62eeaba5b
|
|
Bug: 67322107
Test: manual
PiperOrigin-RevId: 172656296
Change-Id: Ia8b7d508ef35ff0091b762c28e1091af60ce15b4
|
|
Bug: 67914094
Test: unit tests
PiperOrigin-RevId: 172650441
Change-Id: Ie7df3174a07df2de3a102fb70a126004f704b22f
|
|
Bulk insert is implemented in ag/3073902
When more than one voicemail is inserted into the VoicemailProvider, the URI type is Voicemails.DIR_TYPE instead of ITEM_TYPE. This CL adds support to the new type.
Previously when multiple voicemails are being notified, each one of them will generate a ringtone because the notifiction is set to alert children. In this CL, the summary will have alert instead, and will only alert when new voicemails are received.
Bug: 21281858
Test: VisualVoicemailNotifierTest
PiperOrigin-RevId: 172546076
Change-Id: I4df6098fc3a793139e3d4e77fe1339efdc001944
|
|
The numbers used to be cropped (http://screen/YYBG8T0Ma0J). We've fixed that issue in this CL and also removed the term "call_log" from the file name.
Screenshot:
http://screen/uHCPwf5smVX
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 172541833
Change-Id: Ib2746b38284c2c04c84ab369d449412d8a9880b4
|
|
If a user made a search using the voice/mic icon, the search results weren't
being applied to on device contacts because SearchAdapter wasn't receiving the
query.
Bug: 67633975
Test: manual
PiperOrigin-RevId: 172540423
Change-Id: Ib92b055dddf4e4fbdf88eadd62583bf1bac32055
|
|
This change coalesces Cp2 contacts into a new cursor so that
they can be associated with the Company name. The following logs
can help explain how the data is organizes in the original cursor:
display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/name), data1 (A Pixel)
display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/note), data1 ()
display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/group_membership), data1 (1)
display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/phone_v2), data1 (+1 650-200-7932)
display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/phone_v2), data1 (+1 540-555-6666)
display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/organization), data1 (Walmart)
This is an example of what is returned for a single contact. We can easily
associate contact rows together using the lookup key and determine which
rows have relevant data by checking the mime type. I use the data here to
coalesce the contacts together into one row for easy parsing in ContactFilterCursor.
Rows with mime type phone_v2 contain contact information (for example, this
contact has 2 phone numbers).
Rows with mime type organization contain contact's company information (for
example, this contact works at Walmart).
Bug: 67675742,64894607,67848713
Test: existing + SCCT.filter_companyName
PiperOrigin-RevId: 172528797
Change-Id: I5c9f66ff0c27276869295eff97bb0216f92995be
|
|
Test: Manual :/
PiperOrigin-RevId: 172521778
Change-Id: Ibc853aa429d61c13a43b56411fb00a0fcb38795f
|
|
Bug: 67430264
Test: manual
PiperOrigin-RevId: 172520128
Change-Id: I061e3b45599e1c14be387713e63f6fdeae367be4
|
|
Bug: 67820772
Test: DialtactsActivityIntegrationTest
PiperOrigin-RevId: 172519580
Change-Id: I31983153cedb24c436cbaeef69fe6a2f4e558c65
|
|
When determining whether two phone numbers are identical enough for caller ID purposes, the Contacts Provider ignores special dialable characters such as '#', '*', '+', etc. This makes it possible for the cursor returned by the Contacts Provider to have multiple rows even when the URI asks for a specific number.
For example, suppose the user has two contacts whose numbers are "#123" and "123", respectively. When the URI asks for number "123", both numbers will be returned. Therefore, the following strategy is employed to find a match.
If the cursor points to a global phone number (i.e., a number that can be accepted by PhoneNumberUtils#isGlobalPhoneNumber(String)) and the lookup number in the URI is a PARTIAL match, the cursor is a match.
If the cursor points to a number that is not a global phone number, the cursor is a match iff the lookup number in the URI is an EXACT match.
There is no matched cursor in all other circumstances.
UI demo:
Suppose the user has a contact named "Service1" with number "#123".
Before:
Incall UI after the user dials "123": https://photos.app.goo.gl/xFWCD4qy2VR3YEuJ2
Call log UI after the call ends: https://photos.app.goo.gl/FT28GdTBy1dtANtI2
After:
Incall UI after the user dials "123": https://photos.app.goo.gl/Io3BisQmsyfnvitV2
Call log UI after the call ends: https://photos.app.goo.gl/6GgRrmx75yUTga3B3
Bug: 30225112
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 172505648
Change-Id: Ida554313455ff9ce40432897681f89f58d64af04
|
|
This CL lays the foundation of querying the annotated call log, retrieving only the voicemail entries and some of the voicemail information in the Voicemail tab. This CL only displays the name/number as well as the corresponding photo of the voicemails present on the device.
WANT_LGTM=zachh
SCREENSHOT: http://screen/YYBG8T0Ma0J
Bug: 33006245, 64882313
Test: Unit tests and manual verification.
PiperOrigin-RevId: 172504512
Change-Id: Ie7187b021abf42d1a4522458a1ab28537a7c222c
|
|
Bug: 63994464
Test: integration test
PiperOrigin-RevId: 172499750
Change-Id: I7a7c23b403f649c1bbec0bb068e1285e02fddd22
|
|
1. Only update secondary info when it's changed.
2. Removed redundant call to update notification on activity start (b/36649622)
3. Use same call back for notification update from contact info query to avoid duplicated call backs.
The actual latency reduction is insignificant (<10%).
Bug: 36649622,64542087
Test: manual
PiperOrigin-RevId: 172475223
Change-Id: I1c91cb5715287991de774a1d9b95e4c8b722d28f
|
|
Fixed notifying for Duo missed calls using the new constants to check if a call is a Duo call.
Bug: 66946794
Test: existing tests, manual
PiperOrigin-RevId: 172400311
Change-Id: I84ec0ac5c933cf1aec68b6d1f422c2effe6b69ec
|
|
Bug: 67709163
Test: NewSearchFragmentTest
PiperOrigin-RevId: 172378559
Change-Id: I2b92e1e06057a57638d23a333d04239b2e288bc1
|
|
This CL adds a new item to the simulator menu:
- Add GSM conference
The GSM conference action creates a conference with 5 phone calls.
Users can individually separate or kick calls out of the conference. Hanging up the second last call finishes the conference.
Bug: 67785540
Test: SimulatorConferenceTest
PiperOrigin-RevId: 172377631
Change-Id: Ic30fa6c65cf782247f75bcdd1ecbd86b1c16f143
|
|
Promo was being collapsed because rotate causes list to be scrolled at IDLE state. Make the drag more explicit by including the fastScroller drag state instead
manually verified fast scrolling still minimizes promo and rotating while promo is expanded keeps it expanded
Bug: 67670326
Test: ContactsPromoFragmentTest
PiperOrigin-RevId: 172352966
Change-Id: Iab5438501db1d54b7ffac3339faecde0256a3632
|
|
Bug: 67419607
Test: manual
PiperOrigin-RevId: 172349180
Change-Id: I305f8a0e5ae90b2e5e8f77772edfb0b973aca096
|
|
In previous change, we use AudioRouteSelectorDialogFragment.onCancel() instead of onDismiss(). And selecting an item only calls onDismiss() instead of onCancel(), so the activity is not finished.
In this change we finish the activity when an item is selected.
Test: manual
PiperOrigin-RevId: 172342660
Change-Id: I2d34874ae9e1a7e5ad858b4f1ba855b48647d995
|
|
Now that our Duo integration is public, we no longer need a code name.
To avoid any disruption, logging and config related names were not changed.
Bug: 63753964
Test: manual, existing tests
PiperOrigin-RevId: 172172738
Change-Id: Ib9d3d80761944d850c8c4886def9fef9a28539a4
|
|
There was a race where the dialog could sometimes get detached before the success callback finished. The callback would attempt to show a snackbar using [fragment.]getString(), which throws when the fragment is detached.
The fix is to just use the activity to get the string (which has already been asserted to be valid).
Bug: 65968151
Test: unit
PiperOrigin-RevId: 172169503
Change-Id: If86250b14038958e6668b26d1f150619fe3eefae
|
|
This is a dialer only feature and will not be available in the framework.
Test: unit tests.
PiperOrigin-RevId: 172166023
Change-Id: Ib2a0101386a9d892dab87c7c4fb8d4728d8c55f0
|
|
- Dialpad now hides if user tries to scroll w/ a search query.
- Search now closes if the user touches the blank area w/o a search query.
- Since we don't even show location results in dialpad search,
we no longer request location permission in it.
Bug: 67657783,67656915
Test: tba
PiperOrigin-RevId: 172162620
Change-Id: I33a814797a053600e56fb163fd55b0c43e00a9c6
|
|
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change.
Bug: 64541209,65460373
Test: manual
PiperOrigin-RevId: 172154863
Change-Id: Iaf6e217df284e6df6f13688ac6aa677481a575e0
|
|
Test: existing tests, manual (tested on Nexus 6 running M)
PiperOrigin-RevId: 172122858
Change-Id: Ib22e33de3ed134cf76a06af54d054dbb92f91039
|
|
Added a check for null notification tags when updating voicemail notifications.
Bug: 67607115
Test: manual and unit test
PiperOrigin-RevId: 172121860
Change-Id: If9fd6ca972a5a1dbd48a9c529f3cb46c3c93fa2a
|
|
Currently the SystemCallLogDataSource queries the call log table with CONTENT_URI. This works for the call log tab, but will not work for the voicemail tab. To allow the voicemail tab to query annotated call log for voicemail information, we need to surface up voicemail data from the system call log data source into the annotated call log.
Bug: 64882313,33006245
Test: Unit tests, also verified that in the call log only the non-voicemail entries show
PiperOrigin-RevId: 172036196
Change-Id: Ieac855ae854a043207c9ae668280391c790ac33d
|
|
video call.
Bug: 67717800
Test: GoogleCallLogAdapterTest
PiperOrigin-RevId: 172013208
Change-Id: I86c4ca1ef7caf1899cb9587d98233a9e707b7f3d
|
|
Bug: 66946794
Test: MissedCallNotifierTest
PiperOrigin-RevId: 172007792
Change-Id: I14a2c0b6a5ad5a5b8acd449214c91bff68282b6a
|
|
Bug: 66633426
Test: LegacyVoicemailNotificationReceiverTest
PiperOrigin-RevId: 172007744
Change-Id: Ic67566c22659b51d605c92d2673f9baddaee531f
|
|
video: https://drive.google.com/open?id=0B2Hce9qilHmvZkREWm1BMURJNjQ
Bug: 67635181
Test: n/a
PiperOrigin-RevId: 171928416
Change-Id: Id0ef91647ec15ea970a691b1ae896010a12e6bb8
|
|
There are many binder call triggered by IPC on main thread. This change will try to reduce them by caching thing that's bound to a call. It reduce total binder transaction from 1002 to 664 and saves ~11% latency of incoming call on locked screen.
1. Cache isVoiceMailNumber in DialerCall
2. Cache call capable accounts in DialerCall
3. Cache current country iso in DialerCall
4. Don't set orientation change if it's not changed.
This change also add lots of trace info. It won't affect release build though since they are stripped out by proguard.
Bug: 64542087
Test: manual
PiperOrigin-RevId: 171901266
Change-Id: Iec48f030529aa59974212147276f6d0ae121872a
|
|
Author: tomoyuki.nishikawa@sony.com
This change was inspired by http://aosp/508735
Even though VideoProfile.isVideo(getVideoState() returns true when starting a video call, ImsVideoTech is not ready until call.getVideoCall() returns not null (see https://android.googlesource.com/platform/packages/apps/Dialer/+/master/java/com/android/incallui/videotech/ims/ImsVideoTech.java#66)
During the time between VideoProfile.isVideo(getVideoState() being true but call.getVideoCall() returning null, we are incorrectly showing the phone call UI instead of the video call UI. To fix this, we need to trust the VideoProfile check in addition to the VideoTech check.
We still need to check VideoTech for other video options aside from just IMS VT.
Bug: 67712159
Test: manual
PiperOrigin-RevId: 171892356
Change-Id: Ibe1f9de60aaa4adc971401bee0277961cfe037e4
|
|
* Remove old language icon from bottom row.
Screenshot=In change as scuba test
Bug: 64205446
Test: new unit tests
PiperOrigin-RevId: 171858076
Change-Id: Idf781be193dae3593f778af1ac833f046abd87e3
|
|
Previously before showing a voicemail notification dialer checks if the count has changed to avoid showing duplicated notifications. With the dismissed flag in place the count changed check is redundant, and it prevents the notification to reshow after reboot.
Also updated the EXTRA_IS_REFRESH to use the O_MR public version.
Bug: 66633426
Test: LegacyVoicemailNotificationReceiverTest
PiperOrigin-RevId: 171760393
Change-Id: I508b8f42a44fd849ab7c8ca6fe9d4e7e8a38b1c7
|
|
Also added ability to click on row to call.
Required plumbing through the original phone number and phone account info through AnnotatedCallLog and CoalescedAnnotatedCallLog, so that clicking to dial doesn't require an additional lookup.
Required some refactoring:
-created autovalue for CoalescedRow.
-created autovalue for ContactPrimaryActionInfo and use it in ContactActionBottomSheet
-moved logic for building primary and secondary text into CallLogUtils so it can be shared between call log list and bottom sheets
-moved clipboard logic to own package for copying numbers
Bug: 34672501
Test: unit
PiperOrigin-RevId: 171760252
Change-Id: I645d89974460b611c1d9668c3ca3e50a716c7f8f
|
|
For fast users/testing suites, it's possible to hit a race condition
where onBackPressed is called multiple times in a way that allows the
second call to endCallComposerSession to happen and crash.
This CL fixes the issue by checking that the session still exists prior
to calling endCallComposerSession.
I tried to write tests for this, but since the code guards against this
from happening, I wasn't able to get the code into a situation to cause
the crash.
Bug: 64136293
Test: none
PiperOrigin-RevId: 171758119
Change-Id: Ie12fd2f4390329b9bebb503fa3cf0f26d3bc1caf
|
|
Bug: 67605130
Test: Cp2PhoneLookupTest
PiperOrigin-RevId: 171757865
Change-Id: If92e759567456dda09a925e9c625df001f2d573f
|
|
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIdVZ2dE44MzNUZ2pkdUY5ZVdycHp0R1ZsLUtZ
Bug: 67634990
Test: manual
PiperOrigin-RevId: 171757382
Change-Id: If11b88a0682e5da9454238fa19fb78972115fb23
|
|
If a PhoneAccount declared it is CAPABILITY_SELF_MANAGED, it should handle the in call UI and notifications itself, but might still write to call log with EXTRA_LOG_SELF_MANAGED_CALLS}.
Bug: 66946794
Test: MissedCallNotifierTest
PiperOrigin-RevId: 171727177
Change-Id: I34444857d432d6bb72983c0ba919bcfef885192b
|
|
Bug: 67635072
Test: n/a
PiperOrigin-RevId: 171720799
Change-Id: Ie64f7daa071986b23653876172011d4f2343fc69
|
|
When the call is still ringing, a new button is added to allow to user to call with the other SIM. A background worker will be created to hang up the phone and redial with the other SIM. The in call UI will be prevented from ending during the process.
Video: https://drive.google.com/a/google.com/file/d/0B2eYBUUznfyTSl9MdXQ0V1ZzQkE/view?usp=sharing
UX has not been finalized, the icon and position are just placeholder.
Bug: 64215256
Test: SwapSimWorkerTest
PiperOrigin-RevId: 171715715
Change-Id: Idb3f486e9fc9a45d4c5e244af2d7d91b075bf0f2
|
|
cl/170943038 groups calls in the call log according to their corresponding actions (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set.
Bug: 66026167
Test: CallDetailsActivityTest.callbackButtonLoggedForLightbringerCall, CallDetailsActivityTest.callbackButtonLoggedForVideoCall, CallDetailsActivityTest.callbackButtonLoggedForVoiceCall
PiperOrigin-RevId: 171703514
Change-Id: I534e1d22f1355f261105a6bde74285403fc9ed87
|
|
supported.
Test: manual
PiperOrigin-RevId: 171610298
Change-Id: I12ca284927603804b8761db695d35a1c79fa93f3
|
|
One of the biggest issues with the FAB is that it doesn't
scale in/out properly. It looked more like setVisibility was
being called instead. This CL migrates the FAB controller to
use the built in scale in/out methods #show and #hide and the
animation is much nicer.
Some of the other issues were:
- Now scaling animation is correct and visible.
- No longer flashes when going in/out of search.
- No longer shows on top of the return to call controller.
- No longer bugs when switching between VVM TOS and contacts.
- No longer shows FAB over VVM TOS when entering/exiting search
Bug: 62588192,35359563,64116334,27458212,37991480,67419607
Test: manual
PiperOrigin-RevId: 171608105
Change-Id: I9b3f61df35abf3659a432adf411b1b7d20eba683
|
|
Currently different types of calls can be grouped together (e.g., 1 voice call and 1 IMS call to/from the same number), which makes it difficult to choose the icon for the call detail UI's call back button.
This CL adds an extra constraint that separates different call types (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set.
Bug: 66026167
Test: CallLogGroupBuilderTest.addGroups_MixedEntries_PartiallyGroupedByAction
PiperOrigin-RevId: 171602617
Change-Id: Id8170206009ba836a40c38a86914c71d5c7701dc
|
|
* Add missing assisted dialing to calls from contacts in the call log.
* Add missing assisted dialing to calls from dialpad and normal search.
Bug: 63995025,63995261
Test: unit test
PiperOrigin-RevId: 171593967
Change-Id: I4e63ef1dcd7ee1b2b5cbb8ecb4d8da744d90bd66
|
|
Test: StatusBarNotifierTest
PiperOrigin-RevId: 171588023
Change-Id: I05e176ef1032da00c4b75a83e92f39e8293d598e
|
|
Tracking bug to fix the refactoring: http://b/67512378
Bug: 67470678
Test: manual
PiperOrigin-RevId: 171553078
Change-Id: Ib83e4240d6024347f97d246f9b526c3ccbf02057
|
|
When any locks are acquired, the InCallActivity will not auto-finish when there are no active calls. The disconnected cause and reject with SMS dialogs are migrated to use this API, which prevents the activity form ending before the user has finished interacting with the dialogs.
Bug: 64215256
Test: InCallPresenterTest
PiperOrigin-RevId: 171362338
Change-Id: Ied07ebbf6bee056ea6b2314c57f3324561b1651a
|
|
This CL adds a method to DialerPhoneNumberUtil which returns a Future
holding the result of parsing a number into the DialerPhoneNumber proto.
This will be used in the APDL integration as it will use Futures as
well.
The CL also changes DialerExecutors.lowPriorityThreadPool to be an
ExecutorService instead of an Executor (the super type) so it can be
used in MoreExecutors.listeningDecorator.
Test: TAP
PiperOrigin-RevId: 171347542
Change-Id: I620aacf3304d625f57af6d2b89a36f11b44008dd
|
|
Do the following when a participant is on hold:
- Add "On hold • " in front of the number
- Gray out avatar and text (contact name & number)
Notice:
We only have the on hold state information for VoLTE conference call and IMS conference call. So the change only works for them (not for GSM/CDMA conference call).
Test: ConferenceManagerPresenterTest
PiperOrigin-RevId: 171345423
Change-Id: Ie5fe2fc1097f4858604283989dcb916c2ac21972
|
|
QA noticed that the error message 'Transcription not available. Unsupported language'
didnt fit on one line and got truncated. This cl removes the single line constraint
for that text field.
Bug: 67384287
Test: manual
PiperOrigin-RevId: 171316291
Change-Id: I41f98fe207ebeca900bf4fd51cd4e95e20981a9a
|
|
The label is colorized with the SIM color, if the system UI decides to respect it.
screenshot:
https://screenshot.googleplex.com/PzkCKdQJ7Wy
Bug: 64215023
Test: StatusBarNotifierTest
PiperOrigin-RevId: 171234005
Change-Id: I684753b6181bdfe601244d01ab608fcd5d5dc422
|
|
This is a regression caused by cl/165479077.
Bug: 63038002
Test: manual
PiperOrigin-RevId: 171193536
Change-Id: Ib0ca2af64b5fdce2b5f3c78f171b8d5fe0388f47
|
|
Documentation clearly states that cursor loaders will close all cursors for
you. This CL removes all calls to cursor.close() after onLoaderFinished is
called.
Bug: 66902052
Test: n/a
PiperOrigin-RevId: 171087171
Change-Id: If771fbea52e03ffdd3652af2699c393cc7424de3
|
|
As per the material desing spec [1], floating action buttons should be 56dp
in size normally and 40dp on small displays (like in multiwindow mode) while
always maintaing a 24dp image size.
screenshot (mw): http://screen/URJrg1WoQfn
screenshot (normal): http://screen/TUU65D1sSHp
[1]
https://material.io/guidelines/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button
Bug: 67312080
Test: n/a
PiperOrigin-RevId: 171086404
Change-Id: Ib213cf3c94dbb0f0df5b21f23f3022a8f53d80a8
|
|
Bug: 65559651
Test: MissedCallNotifierTest
PiperOrigin-RevId: 171070314
Change-Id: I57e6e0b55a07430daad944473ae4eb427d56ee96
|
|
Bug: 67379105
Test: LightbringerTechTest
PiperOrigin-RevId: 171069656
Change-Id: I8aa9d5a1886d98b6039eeec993b91dd2b600d415
|
|
Since lists are passed by reference, if the directory list passed into
RemoteContactsCursorLoader was modified before #lodInBackground was called, the
directory list would change and crash when compared to the list of cursors.
Since directory lists are small, there shouldn't be any memory issues with
copying the list.
Additionally, this CL adds some logging to the new Search Fragment.
Bug: 66902071,66902062
Test: RemoteContactsCursorLoaderTest
PiperOrigin-RevId: 171063035
Change-Id: Id2faa542805da4167fc7045e6fbe71d02c644ab6
|
|
and using non-breaking space in dialer TOS 'learn more' link.
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuIV3BWWmxSTTlJQ2dBTnR2UHRGWjZJRlFQUGo0
https://drive.google.com/open?id=0B9o_KvtLkcuIOEJjanVhMXlfck81aU02Y0I2MkVtWFNOVGp3
Bug: 67379747
Test: manual and updated unit tests
PiperOrigin-RevId: 171025914
Change-Id: I9c4bfd899805681492a5063ee1bc674bbb98f630
|
|
last 3.
This is according to the latest PRD:
https://docs.google.com/document/d/1FLoQ6kNYL-QKplbniJAIUCHku87S9eYuYPs6IXe-U78
Also cleaned up warnings in CallLogQueryHandler.
Screenshot: https://screenshot.googleplex.com/Z7p4BRVpLpE
Bug: 34672501
Test: unit
PiperOrigin-RevId: 170941445
Change-Id: Ibf79b70eda3837ea46d365729aaed0a87961e42b
|
|
Use startForeground()/stopForeground() for posting notification instead of NotificationManager.notify()/cancel(). It makes incoming and ongoing notification foreground and not able to snooze. It also colorize ongoing call notification for Android O, since we already setColorized().
Use setPriority(Notification.PRIORITY_MAX) for pre-O, and NotificationManager.IMPORTANCE_MAX for O. It makes incoming and ongoing notification stay on the top.
Test: StatusBarNotifierTest*2
PiperOrigin-RevId: 170924163
Change-Id: Iab1415b0161a4623a1ccf52d3948f32b6f93eeb2
|