summaryrefslogtreecommitdiff
path: root/java/com/android
AgeCommit message (Collapse)Author
2018-02-09Add LookupUri to PeopApiPhoneLookupInfotwyen
Bug: 72108777 Test: Unit tests PiperOrigin-RevId: 185058075 Change-Id: I161b5127fdc94c0b77536d2901e2c24d7f1eeb7c
2018-02-09Implemented NUI menu items.calderwoodra
Bug: 72526274 Test: implemented PiperOrigin-RevId: 185046520 Change-Id: I4740c0f4cadb39058a197f270f4fb0ad54846a69
2018-02-09Implemented GoogleMainSearchController to customize menu to GoogleDialer.calderwoodra
This change doesn't implement any of the menu actinos, it just abstracts some components so that the GoogleDialer toolbar menu can show help and feedback (and thus, AOSP won't). Bug: 72526274 Test: implemented PiperOrigin-RevId: 185033936 Change-Id: I30f8cde6705145ef95efcfc82973a8aa2b16e4ee
2018-02-09Show reject hint text for all incoming callswangqi
The function setHintText sets the hint text reject text to null when hintText for answering a call is non-null. Correcting so the reject text is always be set to call_incoming_swipe_to_reject regardless of the value of hintText. This is an upstream change from: https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/612667 Bug: 73018780 Test: manual PiperOrigin-RevId: 185020322 Change-Id: I413f8cf63a1b11e70300536a13c1a8a103d847cc
2018-02-09Show icon and label for a spam number in the new call log.linyuh
Bug: 73077158 Test: CallLogEntryTextTest, GlidePhotoManagerImplTest, PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 185017362 Change-Id: I113472482da2213d17a847054272a22249edc578
2018-02-09Support GID1 for VVM configstwyen
This CL allows VVM configs to be specifed with Group identifier, which takes precedence over configs with only MCC/MNC. TelephonyVvmConfigManger is renamed to DialerVvmConfigManger. It was created when VVM was still in telephony, and need to separate itself from the CarrierConfig app. Bug: 72666573 Test: Unit tests PiperOrigin-RevId: 184924155 Change-Id: Ic71e99ed2b3015eed87dfb7e111538ff3b744206
2018-02-09Add VVM Config for Bouygues FRtwyen
Bug: 72647204 Test: Tested by Bouygues PiperOrigin-RevId: 184914101 Change-Id: Ic7dec5ee33a959751062127ab010dc79f6fb2bae
2018-02-09Fix new special codesroldenburg
Bug: 72162360 Test: existing test (SpecialCharSequenceMgrTest) PiperOrigin-RevId: 184913147 Change-Id: If801b4521939e9fad6ea7227368b9f5146bf46bc
2018-02-09Handle concurrently deleted rows in all updateSmartDialDatabase cursorsmaxwelb
Bug: 73074317 Test: Not possible, see above PiperOrigin-RevId: 184893521 Change-Id: Iecb99c658dafa98a2518202c14e67c4494983090
2018-02-09Deleted some unused classescalderwoodra
Test: tap PiperOrigin-RevId: 184876627 Change-Id: I8db7e08b3fe2f652f8733ecba7f8bc99803944fc
2018-02-06Bubble layout change.yueg
- Flip back-to-call button icon. - Use different button height for portrait and landscape. In order to make it work, we also create new ViewHolder object when bubble shows and remove reset() when bubble hides. Bug: 67605985 Test: NewBubbleImplIntegrationTest, NewBubbleImplTest, NewReturnToCallControllerTest PiperOrigin-RevId: 184768224 Change-Id: If4e613b12e39c647c34f4cb63a7f934043d42ec7
2018-02-06Adding voicemail donation promomdooley
This cl shows a voicemail donation promo the first time a user tries to rate a transcription. It also changes the good/bad rating links to thumbs up/down icons. The 'learn more' link still needs the real URL. screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuIOERUNUJId3FVY3UzUS0wVUdQQVpCS1lmM3Nz https://drive.google.com/open?id=0B9o_KvtLkcuIWkNVMDV1VTJ4VUMtakVwSE1UTGdUWjljTUV3 https://drive.google.com/open?id=0B9o_KvtLkcuIeU1ndG1palRkTnNJQWVYLXgyMnd4TjBDOFI4 mocks: https://drive.google.com/file/d/1FIhXDkn3h3xI7liVdJEraq47MoKQM3hi/view https://drive.google.com/file/d/1uTm58QCvFOBycsGP21vgvEGTq_Imgkqi/view Bug: 37340510 Test: manual tests PiperOrigin-RevId: 184745497 Change-Id: I40fd1e211311c3127f215ede2e44b22f345dcf8b
2018-02-06Fix NPE when querying preferred without an accounttwyen
Bug: 72986691 Test: Unit tests PiperOrigin-RevId: 184743227 Change-Id: I2e37c2916ce05a72324f68c4530b7f6f3daf23eb
2018-02-06Implement SpamPhoneLookuplinyuh
Bug: 70989534 Test: SpamPhoneLookupTest PiperOrigin-RevId: 184738576 Change-Id: I63743e5df155a8d31ffa5e2ee3b88e2446023a28
2018-02-06Uncompress .dex/.so files in Dialererfanian
Bug: 68722828 Test: used zipalign to verify dex files were uncompressed. PiperOrigin-RevId: 184728960 Change-Id: I6536c96a5ad91b11273ce36786ef9a3aed2ecc9c
2018-02-06Implemented GoogleMainActivity.calderwoodra
This Activity is only visible if you flip the flag in the AndroidManifest. Bug: 72525324 Test: implemented PiperOrigin-RevId: 184719387 Change-Id: I88d7ee1be537cbe5aa5cd4ee5a8f84d56bddb757
2018-02-06Include the timestamp in the data returned by the Spam interface.linyuh
Bug: 70989530 Test: Unit tests PiperOrigin-RevId: 184703655 Change-Id: I043c05a2db9f05745952ee04a84912f7540a9a17
2018-02-05Visual Voicemail notifications now go to MainActivity when enabled.calderwoodra
Bug: 72525615 Test: VisualVoicemailNotifierTest PiperOrigin-RevId: 184625656 Change-Id: I8a0b53e12ebe8382f5bc5febd7a6ec448a255f2f
2018-02-05Don't set the "incomplete" bit for empty numbers.zachh
There will never be contact information for an empty number, so don't bother trying to look them up at render time. This also prevents a crash in the new voicemail fragment that occurs due to an assertion that voicemail rows will never be incomplete, when it may be possible for a voicemail to exist with an empty number. Also, don't set short numbers in VoicemailPopulator, since we don't expect this to be possible and would like to avoid crashing in the aforementioned assertion when using simulator. Test: unit PiperOrigin-RevId: 184615402 Change-Id: I5286112b57179e002f04de81c04475f30b3e1833
2018-02-05Updated bottom nav to match redlines.calderwoodra
Bug: 72525324 Test: manual PiperOrigin-RevId: 184615350 Change-Id: Ic5701d67111e38f73dfa4be31dd89115ad7f5bb8
2018-02-05Match redlines in new call log.zachh
This includes: -Moved call count to after icons -Bold PhoneAccount for new calls -Fixed recycling issues in call type icons and phone account -Fixed cropping at bottom of "y" character (see b/67913060) -Reduced nesting in layout -Removed dimens.xml as it shouldn't be shared by voicemail -Set the alpha for Wifi/HD icons depending on read/unread status -Don't color call type icons, except for missed -Call type icons scale with display size -Call type icons are larger (18dp) in new UI Note that FrameLayout is used to ensure that icons/callCount view is not clipped, and instead contact name is ellipsized when the content is too wide to fit. Bug: 67913060,70989593,70989611 Test: unit and manual PiperOrigin-RevId: 184605728 Change-Id: Ie36c89354cbe4444ad2b42b6b0040430e396691c
2018-02-05Missed calls now go to MainActivity if you have the component enabled.calderwoodra
This CL has a few changes of varying relevance: Most Relevance: - MissedCallNotifications will open MainActivity if the component is enabled (Meaning the launcher is in their app drawer and the flag is flipped). - Implemented show tab intent (open MainActivity directly to a specific tab) - Tests Some Relevance: - Implemented checking for ACTION_DIAL intents (dialpad will open immediately) - Tests Not Relevant but nice QoL changes: - Added tests for missed calls being marked as read - Makes espresso tests more horizontal to reduce timeouts - Bug: 72525550,72525615 Test: implemented PiperOrigin-RevId: 184600627 Change-Id: If96a44ce252e97c022ebc1b58fa783b3326035e7
2018-02-05Check for null column before getting contact_idmaxwelb
Bug: 72320869 Test: None :/. See above, I tried PiperOrigin-RevId: 184576992 Change-Id: I2c9eb095d298043ec3d4bc514c0ffa6bd8a98241
2018-02-05Remove experiment flag "enable_dual_alphabets_on_t9".linyuh
Test: Existing tests PiperOrigin-RevId: 184574898 Change-Id: I66f8fabacada8a86a0d36b904a47f38f0290867a
2018-02-05Make transcription text blackuabdullah
Makes the color of the transcription text different from the secondary text as expected by the spec. Bug: 72746803 Test: N/A PiperOrigin-RevId: 184372919 Change-Id: I3de30a3031a57d1bf3600c491e3881152aee9b03
2018-02-05Remove bubble v1.yueg
Bug: 67605985 Test: manual PiperOrigin-RevId: 184358120 Change-Id: I17288da2b059f18bd51247e27aa174c7994e6f05
2018-02-02Add phone account id and component name to NUI VM Pre-call.uabdullah
Adds the support for NUI VM Tab to add phone account handle information to Pre-Call. This is used when making a call via the voicemail tab. Bug: 72449246 Test: existing unit test PiperOrigin-RevId: 184357841 Change-Id: Icc086c878c86cf5204511860d4524ff2ea1f8935
2018-02-02Exit early when phone_lookup returned duplicated results for Preferred SIMtwyen
Previously all results are validated then checked if there are duplicate. In this CL once duplicates are found it will exit early. Bug: 72873001 Test: Existing unit tests. No behavior changes except query counts and latency which we don't test. PiperOrigin-RevId: 184355913 Change-Id: I5ef89c25b100752d939daba69fcfeca3c9d32521
2018-02-02Update the SpeakEasy component.erfanian
Test: unit tests PiperOrigin-RevId: 184352489 Change-Id: If3f2414dd9769dc54035c7fcf5afe925af3006db
2018-02-02Update text on after call spam notification and dialog.wangqi
This change also includes: 1. Fixes formatting of phone number in the dialog. 2. Remove body text if the dialog. 3. Update to material design dialog style. Bug: 72120616 Test: manual PiperOrigin-RevId: 184350133 Change-Id: I8bdd9c792877822fe18ba6aae6c04136a603dbba
2018-02-02Bump version codes and name to v18roldenburg
Test: n/a PiperOrigin-RevId: 184350063 Change-Id: Iaab629a6658d8b597e047a59b42e451a60c54d79
2018-02-02Implemented drag to remove in NUI with old favorites.calderwoodra
This change moves the remove button to overlap the search bar instead of reside underneath it since we no longer have top tabs. Bug: 72722364 Test: manual PiperOrigin-RevId: 184347110 Change-Id: I5bfa70fec9dd7ee6ee0b7270039931f9277291f4
2018-02-02NUI VM Transcribed by Google UI Supportuabdullah
Shows the "Transcribed by Google" logo for voicemails transcribed by Google Bug: 72491920 Test: Unit Tests PiperOrigin-RevId: 184343786 Change-Id: I9d662860e218ff555c65f667f4ee15015df47ab2
2018-02-02Implemented multiselect in NUI for VisualVoicemailFragment.calderwoodra
This solution has a couple hacks in it because the DialtactsActivity has a non-support ActionBar and MainActivity has a support Toolbar. When multiselect is implemented for NewVoicemailFragment, we should be careful to use support action mode instead of non-support action mode so that the transitions and styling are seamless and consistent. Bug: 72722083 Test: manual PiperOrigin-RevId: 184343414 Change-Id: Id16652de2d0add7b7c304d1cedb429fe9b1cf338
2018-02-02Add Support for transcription state in the AnnotatedCallLoguabdullah
Transcription state column is needed for voicemail transcriptions. This CL adds the support for it in the NUI so that it maybe used by the VM Tab. Bug: 72491920 Test: Unit Tests PiperOrigin-RevId: 184335015 Change-Id: I14a71890224216c957e0d6146af9dafaa1550865
2018-02-02Add assert check for INVALID NUMBERS in NUI Voicemailuabdullah
We do not expect any invalid numbers for the voicemail tab. We crash the app if an invalid number is detected in the NUI VM tab, so that we can handle invalid numbers for voicemail accordingly. Bug: 72863479 Test: N/A PiperOrigin-RevId: 184333020 Change-Id: Ifd769da08c7cba3aab555b56eef799de47810fb3
2018-02-02Split MainActivity into two peers, old and new to keep logic isolated.calderwoodra
This change updates MainActivity to defer lifecycle callbacks and other relevant methods to which ever peer is active, old or new. The old peer implements the logic for the old fragments. The new peer implements the logic for the new fragments. MainActivity implements the logic that is shared or common between the two like last tab, post call, search, dialpad, ect. Bug: 72525324 Test: pending PiperOrigin-RevId: 184317828 Change-Id: Ie73733f2a3837c9d63e54cf5b142984633340731
2018-02-02Refresh annotated call log from the voicemail tabuabdullah
This CL copies the code dealing with refreshing the annotated call log from the NewCallLogFragment and applies it to the NewVoicemailFragment. This is necessary since the NewVoicemailFragment should be able to refresh the annotated call log without depending on the user going to the call log fragment for the update. The only thing we don't copy over is the logic and handling when the CP2 info is incomplete for a number (INVALID number), however we do not expect any invalid numbers for voicemail and as such have added an assert for that. Bug: 72523272 Test: Unit Tests PiperOrigin-RevId: 184292549 Change-Id: I2994974fe60221a4854fed5f9d80d3d428449ae9
2018-02-01internal changeAndroid Dialer
Bug: 68825005 Test: Added unit tests on CallFeedbackListenerImpl, CallFeedbackNotificationManager and DialerCall. Also manually verified the change. PiperOrigin-RevId: 184211115 Change-Id: I50927036c3cd5d47862704376e2eef108c473fbf
2018-02-01Add suggestion reason ACCOUNTtwyen
Bug: 72817785 Test: Unit tests PiperOrigin-RevId: 184178722 Change-Id: I7154058ab7ac1a94adc781a1aa9a49a3f13c1599
2018-02-01Handle missing contact permission for preferred SIMtwyen
Bug: 72163953,72749906 Test: Unit tests PiperOrigin-RevId: 184167756 Change-Id: I19f4a71fb443fbb31960be486c3c5e996535fc32
2018-02-01This text is for dismiss button in dialog that's to dismiss the dialog afterwangqi
a call, instead of to hang up the call. Bug: 72120616 Test: none PiperOrigin-RevId: 184162123 Change-Id: I20dbdb258ad0640fa4ed8cf6492549ba9c62eda6
2018-01-31Implemented Last tab in NUI.calderwoodra
Now when the user exits Dialer NUI, next time they open Dialer they will return to the same location they were before. This change also preserves active tab through configuration changes. Bug: 72068052,72722083 Test: MainActivityIntegrationTest PiperOrigin-RevId: 184085830 Change-Id: Ic6d3bf7c9089b38d480dfc658127eec6c9c55bfb
2018-01-31Added old voicemail to NUI activity.calderwoodra
Bug: 72722364 Test: existing PiperOrigin-RevId: 184083186 Change-Id: Ia51a50b343f75eec74a02dc6b4383341f939793d
2018-01-31Updating Dialer v17 licenses.Android Dialer
Bug: 72757397 Test: 'N/A' PiperOrigin-RevId: 184082977 Change-Id: I3375fe14b81dffc4d8b54468c95b67ebe2b38fd1
2018-01-31Add a BatchSpamChecker for InAppSpam.linyuh
Bug: 72443587 Test: BatchSpamCheckerTest, SpamDatabaseUtilsTest PiperOrigin-RevId: 184076803 Change-Id: Ib11ca44190a28e28843ef4674c0abebc4203c46a
2018-01-31Implemented missed call/voicemail notifications in NUI.calderwoodra
This CL shows and updates the missed call/voicemail count in the bottom nav. It also clears the call log notifications when the user either leaves the call log fragment or closes the activity after 3 seconds of browsing the call log. Bug: 72525595 Test: tba PiperOrigin-RevId: 184071058 Change-Id: I540c9e3d815e022b5e311cb02a3995e241b8a984
2018-01-31Fullly disable VVM if carrier VVM app is installed.twyen
Previously it is only disabled when the user has not changed the VVM settings, and the user can still re-enable it. After this CL, VVM will always be disabled, and the settings will be hidden. Bug: 72668279 Test: Unit tests PiperOrigin-RevId: 184063245 Change-Id: I42c12f3fd2f3e397158e08b26875a7e99a766d33
2018-01-31Add arrow icon to bubble sound button when Bluetooth is connected.yueg
It's an indicator that the button triggers another list. Bug: 67605985 Test: manual PiperOrigin-RevId: 184042869 Change-Id: I3fea526a322dcc3935af111ebd0916b7c5ffcb24
2018-01-31Remove bubble from AOSP.yueg
Bug: 67605985 Test: NewBubbleImplTest, NewBubbleImplIntegrationTest, NewReturnToCallControllerTest PiperOrigin-RevId: 184026033 Change-Id: Ie141ce9a0265ce3a08c01943cdeb94e2cd962e9f
2018-01-30Limit new special codesroldenburg
Bug: 72162360 Test: SpecialCharSequenceMgrTest PiperOrigin-RevId: 183921310 Change-Id: I3a47106a42a6e7c3b903f595f690c7d125e72a04
2018-01-30Don't override contactExists if there is no update from Cequint Caller ID.wangqi
Bug: 72485878 Test: none PiperOrigin-RevId: 183915863 Change-Id: Ib035855d944c91145418222cc390be066744b4fb
2018-01-30Make default lastModified timestamp configurablemaxwelb
Bug: 72320869 Test: manually verified that the config value is used PiperOrigin-RevId: 183911716 Change-Id: I15bc2c4505306eb65446a792b305226255ae4315
2018-01-30Added old call log to NUI.calderwoodra
Bug: 72618828 Test: existing PiperOrigin-RevId: 183902491 Change-Id: I079aca188b52c29c12b3cae7e57bf71a4e883898
2018-01-30Add old speed dial fragment to NUI.calderwoodra
Bug: 72618868 Test: existing PiperOrigin-RevId: 183896896 Change-Id: I9b90aaa02e1c40f38fbbe636f4e51cfd01c570f6
2018-01-30Added badge count feature to bottom nav.calderwoodra
This Change doesn't actually fetch the badge counts, but it's now possible to set badge counts. Bug: 72525595 Test: manual PiperOrigin-RevId: 183887322 Change-Id: I452ca6352133befc8cc2a39c44cd84a33fd66d42
2018-01-30Allow delete of Restricted number entriesroldenburg
Bug: 72639087 Test: CallDetailsActivityTest PiperOrigin-RevId: 183872706 Change-Id: I2c3241b3b9059fe4ed82d79902a474df3d5975a4
2018-01-30Update FragUtils to encourage better readability in Activities.calderwoodra
Bug: 72525324 Test: existing PiperOrigin-RevId: 183776841 Change-Id: Ia78002d3da823a228cf5a29f93cd53ad21105f94
2018-01-29Added a hack for NUI because of a dependency cycle.calderwoodra
In order for NUI to include the old fragments, it needs a dependency on dialer/app. In order for Dialtacts to show the NUI shortcut, it needs a dependency on dialer/main. This change removes the requirement for Dialtacts by copying some of the code from dialer/main into dialer/app. Bug: 72525324 Test: existing PiperOrigin-RevId: 183769521 Change-Id: I29d00f22efecee35ca25f0b4172413c370f2506b
2018-01-29Use application context when fetching shared prefs.zachh
Using non-application contexts incurs extra disk access because shared prefs are cached per context. Test: manually ejected sim and observed no strict mode violations PiperOrigin-RevId: 183739285 Change-Id: I9337e226ae1e060478219cf495752ceccf5a31e6
2018-01-29Added is_valid and post_dial_portion fields to DialerPhoneNumber.zachh
These are frequently used attributes of numbers that we can compute once at parse-time. Also did some general cleanup of DialerPhoneNumberUtil: -Removed unused Future version of parse() -Remove formatToValidE164 now that the new fields are available -Inlined normalizeNumber() Bug: 72563861 Test: existing PiperOrigin-RevId: 183720128 Change-Id: I702dc265360e590439c5352c493ae8a858f36812
2018-01-26Reworked the internals of DialerPhoneNumber.zachh
It turns out the storing the libphonenumber representation of the number is not particularly useful because even formatting these objects cannot be done on the main thread. Rather than propagate the requirement of using PhoneNumberUtil (and background threads by extension) in the call log UI, we now just store a dialer-normalized version of the number which contains all information required by the UI in a way that allows us to avoid any background work in the UI code. Bug: 72563861 Test: existing PiperOrigin-RevId: 183463907 Change-Id: I4bdadaccb7a84033b3c72c54fe3833064f587ee3
2018-01-26Implemented Post Call in NUI.calderwoodra
Bug: 72525658 Test: PostCallIntegrationTest PiperOrigin-RevId: 183441836 Change-Id: Ie1f8da1a7e24b22c5aa79cfa2a1261beb23579a1
2018-01-26Disable phone icon for unknown numbers in NUI Voicemailuabdullah
The phone icon should be disabled for unknown numbers in the NUI Voicemail, so that those numbers may not be called. This should have the same logic as as what we do for the call log. Bug: 72449247 Test: Unit Test PiperOrigin-RevId: 183428831 Change-Id: If1ecc3b4d47de04bccf69ae735a619f6b33c3bbd
2018-01-26Pressing dial with an empty dialpad now queries the last number in NUI.calderwoodra
Bug: 72526019 Test: manual PiperOrigin-RevId: 183425741 Change-Id: Ied1b369d00baefe02db04ade26bee9faac4f829c
2018-01-26Disable seekbar user seekinguabdullah
By default the seekbar should be disabled unless being played or the voicemails have downloaded. This first part of the seekbar update ensures that a user is not able to seek, and the seekbar will only be updated automatically when the voicemail is being played. Bug: 7252855 Test: N/A PiperOrigin-RevId: 183419966 Change-Id: I4e492279402d76d3e1ece03dded9b402c88138c8
2018-01-26Add voice search to NUI.calderwoodra
Bug: 72525718 Test: MainActivityIntegrationTest PiperOrigin-RevId: 183418364 Change-Id: I30a4b7fe3e8a82c1b5cddcd747bd01ebd127b624
2018-01-26Added number presentation to AnnotatedCallLog.zachh
Updated the new call log UI to properly show text based on the presentation. Bug: 70989592 Test: unit PiperOrigin-RevId: 183414195 Change-Id: I2123f37cd3c733060125b6e894c1a80be4193ad6
2018-01-26Add enriched calling simulation.weijiaxu
Test: on a local device. PiperOrigin-RevId: 183414102 Change-Id: I56efda40994e9f0b84f462e42301adbf625273e5
2018-01-26Add logging that assisted dialing was used.erfanian
Previously we only logged during degenerative events. Bug: 72174016 Test: none PiperOrigin-RevId: 183392966 Change-Id: Ibf4b8ce08dff39e9bba2f698162683c2431d06eb
2018-01-25Implement initial calling in NUI Voicemailuabdullah
When a user presses the phone icon in NUI voicemail, we should make a phone call. This does not handle phone account handling and disabling showing the phone icon for unknown numbers (tracked in b/72449247 and b/72449246) Bug: 72449869 Test: Unit test PiperOrigin-RevId: 183318358 Change-Id: I075ae79ec6896f2b9244f990bd2a01493c495e07
2018-01-25Update preferred SIM SuggestionProvidertwyen
"remember this SIM" checkbox state is reported to the provider. The other SIM is reported to the provider when "change SIM" is used Bug: 70503524 Test: Unit tests PiperOrigin-RevId: 183308581 Change-Id: I3d097d14a503c759f130044c9a9c48c420eee19d
2018-01-25Remove non call log dependencies on PhoneAccountUtiltwyen
Methods moved to TelecomUtils Test: Unit tests PiperOrigin-RevId: 183305626 Change-Id: Idd6604e58c06a36066bd49870849dd71747969c6
2018-01-25Route speaker via speaker and headset when tapping speaker button in NUI VMuabdullah
Clicking the speaker button in the NUI VM for a voicemail entry alternates playing the audio via the speaker and headset. This CL does not change the state of the speaker icon, that will be done in a follow up CL (cl/183175378) and the todo for that has been added. Bug: 69858226 Test: N/A PiperOrigin-RevId: 183304029 Change-Id: I3a55e62ab8d1203f659a45db9534fd69deda122f
2018-01-25Show voicemail error messages for NUIuabdullah
This CL shows the voicemail error messages for both VVM and OMTP type voicemails. It hooks upto the existing error framework and retrieves the voicemail error states and then displays it. Bug: 71700117 Test: Unit Tests PiperOrigin-RevId: 183301455 Change-Id: Ib2b7fb957fbfd2af2227747d327cef466259eb6f
2018-01-25Prevent VvmNetworkRequestCallback from releasing twicetwyen
It is unclear from the docs or implementation what callbacks are invoked when the network is lost, or does the system release the callback for us somewhere else. In this CL VvmNetworkRequestCallback.releaseNetwork() will be guarded from calling twice, and log levels for callbacks are raised. Bug: 64243619 Test: N/A, repro steps unknown. PiperOrigin-RevId: 183298754 Change-Id: I5e589b2b59478b270890056fa08abb306ee1600c
2018-01-25By pass media player strict mode violationuabdullah
The media player throws a strict mode violation when setting the data source and calling prepare async. This currently makes the voicemail fragment unusable since you can't play voicemails. I've added a todo to remove this in the future. Test: N/A PiperOrigin-RevId: 183298572 Change-Id: I821a700cc7e60d0bdde7ec4d7b543dfa7acaf274
2018-01-25Explicitly disable strict mode during the assisted dialing action.erfanian
Dialing is a critical path and there is no opportunity to perform this action asynchronously. Starting in P we could leverage the libphonenumber instance that would live in PhoneGlobals and share that to warm up the disk reads. Bug: 70860471 Test: none. Unit tests do not trigger strict mode violations. PiperOrigin-RevId: 183292426 Change-Id: I607c6af4d725272152f31e619367fdde5ed07302
2018-01-25Set avatar as background instead of src.yueg
Since we don't need background any more, setting avatar as background makes elevation work on the same view. So we don't need setOutlineProvider() which might provide a different outline to the image's. Also fix an windowParams NPE. Test: manual PiperOrigin-RevId: 183289973 Change-Id: I452b3f2b66b1810839626f57449be7d10662f2c5
2018-01-25Reset invalid selected countries to the default value.erfanian
In some cases, we may revoke countries or make them otherwise unavailable to assisted dialing. In this case, we reset the preference back the the default value, which is always the zeroth value. Bug: 72322367 Test: new unit test PiperOrigin-RevId: 183238476 Change-Id: Ib5cf200f6da04e332b6248b04057d5de0f64d01f
2018-01-24Add skeleton for SpamPhoneLookuplinyuh
Bug: 70989534 Test: SpamPhoneLookupTest PiperOrigin-RevId: 183174131 Change-Id: I46e819a0710ccce293195594e2f249e91d74551a
2018-01-24Show Icon and label for blocked numberstwyen
CallLogPhoto.getPhotoUri() returns a URI to a drawable so it will be easier to transition into glide. Meanwhile ContactPhotoManager will just show the drawable directly. Bug: 70989547 Test: Unit tests PiperOrigin-RevId: 183163818 Change-Id: I4ee4ff98782e35d2be03dfe14f8bf3dfd6ded074
2018-01-24Bubble v2 a11y.yueg
- Set checkable for bubble buttons so the check status of non checkable button (back to call, end call) is not read. - Add support for bottom action buttons. Test: manual PiperOrigin-RevId: 183150371 Change-Id: Ifae9c912ec923e8d2cda3146413138bd2eb94b47
2018-01-24Add flag to enable NUI shortcut.calderwoodra
Bug: 64655802 Test: n/a PiperOrigin-RevId: 183149638 Change-Id: Idc58efced8f70311eccd67f403bc5bd98f3f8518
2018-01-24Rename "ApdlInfo" as "SpamInfo" in proto PhoneLookupInfo.linyuh
Bug: 70989534 Test: Existing tests PiperOrigin-RevId: 183145910 Change-Id: I60b0122fb236a7e7ee7b746867c40fefe0a3b487
2018-01-24Add support for forwarding more special codesroldenburg
Bug: 72162360 Test: SpecialCharSequenceMgrTest, manual PiperOrigin-RevId: 183138805 Change-Id: I57903a6b3bc30243e4f225d758d1ace550e8ab99
2018-01-24Define methods in Spam interface to be used later in the PhoneLookup for ↵linyuh
spam features. Bug: 70989534 Test: ApdlSpamTest, InAppSpamTest PiperOrigin-RevId: 183138320 Change-Id: I647568c31e234995f44d6cbeb2f97f73952db6bb
2018-01-24Link to the correct Assisted Dialing settings depending on platform version.erfanian
Bug: 72162646 Test: unit tests PiperOrigin-RevId: 183134859 Change-Id: I73d3349f0ff33188cfe0a121b7737a57155683c7
2018-01-24Add foreground service permissionroldenburg
Bug: 72116995 Test: built APK, verified permission PiperOrigin-RevId: 183126225 Change-Id: I0889ea619a21413e510a7b58143c5011ed81b688
2018-01-24Fixed a regression where we incorrectly reported that the dialpad was visible.calderwoodra
A request was made to update the value of #isDialpadVisible, in the process a regression was introduced that would cause #isDialpadVisible to return true when the dialpad's root view was null. This caused a NPE when we tried to animate it. We should now return the correct value in the scenarios important to our partners as well our users and animations. Bug: 64657832,72384544 Test: manual/logging PiperOrigin-RevId: 183122628 Change-Id: I981e944dbb003064163b8ec11883dbc5381cba0e
2018-01-24Add support for yesterday header in NUI Voicemail Tabuabdullah
Currently NUI only supports today and older, however we also need to support yesterday and be consistent with the call log. Bug: 69858354,72331988 Test: Unit Tests PiperOrigin-RevId: 183121631 Change-Id: Ica75164c28ee60a2f776287eefd7eed5db08e035
2018-01-23Updated nearby places search permission icon for Material.calderwoodra
Bug: 68272797 Test: manual PiperOrigin-RevId: 183023158 Change-Id: Iccee9278a89c944c443cb0d4022554ce7f634bab
2018-01-23Updated call number by NW is not displayedwangqi
CallCardPresenter updates a call number if the number is updated by NW. But the logic is worng. The comparing numbers are always same. Because it compares with the same objects in DialerCall#areSameNumber. This is a upstream change from: https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/556000 originating number is shown in the call screen. Bug: 70201489 Test: manual - Verified that a call number that changed from a PiperOrigin-RevId: 183022988 Change-Id: I04305998e77ca120b1248636c63984b3d20f0db1
2018-01-23Search no longer crashes if you don't have the contacts permission.calderwoodra
Bug: 71737256 Test: NewSearchFragmentTest PiperOrigin-RevId: 183020934 Change-Id: Ifed4364901ca77036fa6d0b149857fbbd7e9fca0
2018-01-23-Add cleaning blocked numbers stored in a separate database when people try ↵weijiaxu
to clean calllog database. Bug: 71898641,72104419 Test: On a local device. PiperOrigin-RevId: 183016474 Change-Id: Ib59bf558d5552e9b88c3feee1c47d96791fd542c
2018-01-23Don't garbage collect voicemails in AnnotatedCallLog.zachh
We currently limit the size of AnnotatedCallLog to 999 via a trigger, but it doesn't exclude voicemails. Since we don't want to ever garbage collect the user's voicemails, exclude them from the trigger. This means that we can no longer assume a maximum size for the table (the user culd have more than 999 voicemails) so I've updated the places in the code where we did that before. Finally, I changed AnnotatedCallLog's CALL_TYPE column to be non-null. This is so that we can have more confidence that the trigger will work as intended. Null values cannot be compared in SQLite, so an expression like "where call_type != 4" won't actually match a null call type. Rather than implicitly fail to clean up such rows, we just crash completely when encountering such rows (even though I don't expect that to happen). Bug: 70989634 Test: unit PiperOrigin-RevId: 183006714 Change-Id: I9f4394a4812afe4b65c1e8427c355d825356557c
2018-01-23Bubble bottom action changes.yueg
- Hide bottom action view when bubble move canceled - Get display height every time when show bottom action view (onConfigurationChanged() won't be called when bubble is not visible) Test: manual PiperOrigin-RevId: 182979768 Change-Id: I989422c4ab5866b22c78bffbc82f229842a6dd9e
2018-01-23Contacts recyclerview is now hidden when we don't have contacts permission.calderwoodra
Bug: 71867982 Test: ContactsFragmentTest PiperOrigin-RevId: 182977635 Change-Id: Ibdefc49c76dd607c5f1316ae46da5e38f74c0e85
2018-01-23Moved coalesced_ids.proto and number_attributes.proto to ↵zachh
calllog/database/contract. The "model" package should be reserved for call history proper (and not voicemail) so it shouldn't contain things needed by voicemail. Test: existing PiperOrigin-RevId: 182976719 Change-Id: I463c8ed4600950a8d18db49d991609bfaa49c709
2018-01-23Write PhoneLookup results to PhoneLookupHistory in RealtimeRowProcessor.zachh
This is an optimization to reduce "popping" in the new call log. Since we have to do the PhoneLookup anyway to update the UI, we may as well write the result to PhoneLookupHistory so that the next time the AnnotatedCallLog is refreshed, the updated results can be retrieved from PhoneLookupHistory. I also updated RealtimeRowProcessorTest to use FakePhoneLookup rather than the real Cp2PhoneLookup since RealtimeRowProcessor no longer uses Cp2PhoneLookup directly (it was updated to use the general-purpose PhoneLookup in a previous CL but I didn't update the test at that time). Test: unit PiperOrigin-RevId: 182974567 Change-Id: I813e9d69f802ca08757238290fdfcf58e78b3592