Age | Commit message (Collapse) | Author |
|
|
|
|
|
[Issue/Cause of defect]
If partner device is rotated during video screen of target device is in
background, and then resumes to foreground, partner image will be shown
with incorrect dimensions.
Because when video screen goes to background, VideoCallPresenter stops
checking CVO(Coordination of Video Orientation) of partner device. And
when video screen is resumed to foreground, there is no logic to update
partner image with latest peer dimensions.
[How to fix]
Even if video screen is in background, CVO(peer dimensions) is notified
to DialerCall. Therefore DialerCall should store the dimensions. And
when video screen resumes to fore, VideoCallPresenter should update the
screen with correct(latest) peer dimensions.
Test: manual - Checked that the partner image is shown with correct
dimensions.
Bug: 111575038
Change-Id: I32ff5407f1222b232b47a35e7083a473be67b468
|
|
"Ongoing video call" is displayed in dialing state on the notification.
But "Dialing" should be displayed.
Wrong order of condition to decide the text causes this issue. It should
have checked dialing state before checking video call state.
To resolve this issue, check the dialing sate at first and then, check
the video call sate.
Bug: 111424745
Test: manual - Checked "Dialing" is displayed if it is dialing state.
Change-Id: Id03909178370df3cc4905699f46e13f9a39aeb45
|
|
Test: make
Change-Id: Ib75f4f25e91067311de244d7f1fb95bc898aec22
|
|
This reverts commit a45b5e0299bad5aa6d287179d2c476570f14f347.
Change-Id: I062108a36138f1023e549dafad7518177da74a03
|
|
This reverts commit 36d5b93da4f93e50deb496daa5ad820c48aa7b01.
Change-Id: I533bc3f7d592a6e257d184f0d3730b4be95f2af2
|
|
This reverts commit 988dac56b45e935b99b125f608a2019ce836602b.
Change-Id: I825b8ef2074592fcf23a419cd2cb4d0185035df7
|
|
This reverts commit b6c615dba7609e5134e960a92e723cfeadfbc589.
Change-Id: Ibfe295c51323b4e0352098470921ffae114f5c83
|
|
This reverts commit 4af5facf5a45bb06beebdba790af2807c39e7649.
Change-Id: I3d923cb1cdfb31aa9db4384d554fff3ecbfbe4aa
|
|
This reverts commit 79a9ae7be17c7fe50e6812a47cdd6e7ce5d07966.
Change-Id: Ib60e15fba40207884cb2f9d4f0e65fd599b33ae5
|
|
This reverts commit 19e85a54d723bbe23e51bed70df89bd3861570d7.
Change-Id: Ic450c3012496a20c67327fc64e6b8a1047ea6995
|
|
This reverts commit 20f8f6018e0f80083ebbabb43965ec19996d5f87.
Change-Id: I170c7dff3dff788bf12e9572195ddb3453f058bb
|
|
This reverts commit 27d7f0a5a307c15dee5a048ec36ca256fa90d1bd.
Change-Id: I492d6039813499517ca2243b0e04bfea3d957233
|
|
Bug: 79878432
Test: manual
PiperOrigin-RevId: 202678951
Change-Id: I89cf9dc7ec78f2b6bd10889d50d3c9a139168bca
|
|
Test: tap
PiperOrigin-RevId: 202663404
Change-Id: Ic229d77f8f14bb9e60e82889ed5788dee600e957
|
|
Test: Existing tests
PiperOrigin-RevId: 202589482
Change-Id: I6982e4069d30032bf46caf3c9984dfc0e7196f6f
|
|
Bug: 110177989
Test: manual
PiperOrigin-RevId: 202337281
Change-Id: I277fcbc77ad50c4ed04f92d0541b67043bc8bef8
|
|
Bug: 79878432
Test: manual
PiperOrigin-RevId: 202228927
Change-Id: Ia68d3b1366a36ba5bdde85049b1b23ca98495ed1
|
|
Bug: 79878432
Test: manual
PiperOrigin-RevId: 202185676
Change-Id: I53c3896a68f9dbed9316360d7f4ad6dd7cbe17ec
|
|
Test: manual
PiperOrigin-RevId: 202040098
Change-Id: Id9a6c59d343634473fc2f695d6eafefd16b3c1b7
|
|
Bug: 110173835
Test: unit
PiperOrigin-RevId: 202029563
Change-Id: I62021e0f68beb6eff52b475626c40876daf53fbf
|
|
and Chinese keyboard.
Bug: 110564298
Test: manual
PiperOrigin-RevId: 202027152
Change-Id: If27d23fb04abe6db49748dec68c4cd9be5f11fb1
|
|
Bug: 79878432
Test: manual
PiperOrigin-RevId: 202022343
Change-Id: I7239b13e53a537e20af4b2684a53108aeea16025
|
|
Moving it outside contacts.commons reduces dependency to legacy code. Also removed redundant implementations such as caching SharedPreferences (it is already cached), custom ListPreferences (standard ListPreferences already have what we want), and corrected preference storage location (allow standard ListPreferences to work)
TEST=TAP
Test: TAP
PiperOrigin-RevId: 202000393
Change-Id: I45374e610b3510784b5a4da92e5d8462cbfc92bb
|
|
Bug: 79878432
Test: manual
PiperOrigin-RevId: 201764305
Change-Id: I09d0df697c4eb93a732053280fe4b79513ebfe75
|
|
Bug: 79878432
Test: manual
PiperOrigin-RevId: 201763780
Change-Id: I3ea0fb46c3904060927b68417699708d2e62b08a
|
|
Bug: 79878432
Test: screen diff tests
PiperOrigin-RevId: 201758864
Change-Id: Ib3ed6636df3d337cb2fa7c5f6d8f24da035cbd0c
|
|
Test: N/A
PiperOrigin-RevId: 201614430
Change-Id: Ia154343ce4dd3447811d21f29aeed546f524ef48
|
|
Bug: 79878432
Test: manual
PiperOrigin-RevId: 201608196
Change-Id: Idff45359c5ddf3dacbeb77b103d3b53d3bf34334
|
|
Per android documentation, LAYOUT_IN_DISPLAY_CUTOUT_MODE_NEVER should be used for activities that changes SYSTEM_UI_FLAG_FULLSCREEN on runtime to avoid relayout. It has caused flickering issues for video calls.
SYSTEM_UI_FLAG_FULLSCREEN is only used in InCallActivity
TEST=manual
Bug: 110489070
Test: manual
PiperOrigin-RevId: 201590805
Change-Id: Ia5ee986540fc3b10ddda7f4c9d1a13ed35c43828
|
|
Test: manual
PiperOrigin-RevId: 201390999
Change-Id: Ifa4b124d0d94d97f2aa1d3675130c7eef1f289c1
|
|
Bug: 109890761,73736474,73737524,73773935,79701706
Test: Unit Test
PiperOrigin-RevId: 201379249
Change-Id: I0a18adc4c8df33c65e81281928508897679b5994
|
|
Test: manual
PiperOrigin-RevId: 201376176
Change-Id: Iaaf29568249b470daa6fd38dae110b8528bc8493
|
|
Test: none
PiperOrigin-RevId: 201242961
Change-Id: I09e6c09a573ac3d740a42749775d9ec18aa9ee6d
|
|
When video call is disconnected,
VideoCallPresenter#checkForOrientationAllowedChange is invoked with
"Call(= null)". When Call is null, set "DISALLOW" to
Activity#setAllowOrientationChange. It causes that the end call screen
is displayed in portrait mode even if in landscape mode.
This is an upstream change:
https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/694787
Bug: 80375554
Test: manual
PiperOrigin-RevId: 201046687
Change-Id: Id08db0e399e067bd85ae44444de3e78aae14f67d
|
|
Bug: 110177989
Test: none/manual
PiperOrigin-RevId: 200771224
Change-Id: I6c9d9b6eb0aa98be8e60d693549c07fbbf73c5d7
|
|
Bug: 109763648
Test: manual
PiperOrigin-RevId: 200460856
Change-Id: I1ce385490e6ce6167f56dc32c35a931292e0d03f
|
|
DialtactsActivity will be deleted soon.
Bug: 109931227
Test: none
PiperOrigin-RevId: 200270077
Change-Id: Iafba7081bd3878c3d426cc1483cbef45a6f545a1
|
|
Test: Tap
PiperOrigin-RevId: 200252072
Change-Id: I25aea0e324b070d0f8553cb0041c6b3e9668552e
|
|
Test: manual check resource are still kept
PiperOrigin-RevId: 200237775
Change-Id: Ie6530b5317c898a85e601c4c5fb23cd9f67f5873
|
|
Bug: 109890761,73736474,79701706
Test: Unit Tests
PiperOrigin-RevId: 200237086
Change-Id: If33011f8a6477ea69f8a41d8f78ee9cf7fb51c1f
|
|
Test: manual
PiperOrigin-RevId: 200110976
Change-Id: I0cad28e7b9e650cd07423febd117b44ef61b00fd
|
|
Null pointer exception occurred when tapping speaker button on
VT call ended screen. At the ending of VT call, the call is NULL and
issue caused by accessing the call.
To resolve this issue, disable speaker button on VT call ended screen
by updating button UI when button controller is disabled.
Bug: 109765937
Test: manual - Check that speaker button is disabled on the
VT call ended screen.
This is an upstream change:
https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/699606/
Bug: 109765937
Test: manual
PiperOrigin-RevId: 200096438
Change-Id: Ibecda05fe93edd0a5bbd3bcc29107fc51d3ae2cc
|
|
Bug: 73773964
Test: none
PiperOrigin-RevId: 200079809
Change-Id: I1c505c4f63a17b34ed9fb062c9f9e1b1e16c3832
|
|
Test: manual
PiperOrigin-RevId: 199872562
Change-Id: I77e7ff7587f05c4c251ba8e55e43f32730cdc3c4
|
|
Test: manual
PiperOrigin-RevId: 199693464
Change-Id: I73428025592097e431567ef0cdf55abb84538c7c
|
|
Bug: 109653872
Test: N/A (InCallActivity is not testable, similar to cl/194824783).
PiperOrigin-RevId: 199662982
Change-Id: I4effa2454246d852837d0878246898537f799980
|
|
This fixes bug that new added call and original RTT call are both muted.
Bug: 79956827
Test: manual
PiperOrigin-RevId: 199539018
Change-Id: I242fcdd8f2e23470cf222dd4ccc390478d3e2919
|
|
Bug: 109738484
Test: manual
PiperOrigin-RevId: 199524711
Change-Id: Ia75c41004179da5eae17b6acbc952d652e8d7480
|
|
Bug: 73773964
Test: unit
PiperOrigin-RevId: 199362698
Change-Id: I4b0ab4a3c07ad8fa206753c4826b42037b8a06be
|
|
On VZW, RTT request will be accepted by modem automatically, in which case the
dialog will be useless and should be dismissed. User won't see the dialog in
this case since it's not visible yet when dismissed.
This is a workaround since change in modem/telecom is not feasible at this point.
Bug: 80259700
Test: manual
PiperOrigin-RevId: 199334017
Change-Id: Ie5fb40e7a11975a423135ad7e5e6ef2dddbac56b
|
|
Bug: 73736474
Test: unit
PiperOrigin-RevId: 199224642
Change-Id: Ie11e0bfb261a1ff49b49697314c4341cab4a48d0
|
|
Without this rule, these string resources not directly referenced by code will be stripped out by Proguard.
Bug: 80512860
Test: manual
PiperOrigin-RevId: 199201142
Change-Id: I91ea90273051b6bb6fa57d116bfb037fc86c1a94
|
|
It is a state list.
TEST=manual
Bug: 80315482
Test: manual
PiperOrigin-RevId: 199162757
Change-Id: I3be255506871e0d32e5433c2a96bf620701b9c0d
|
|
Bug: 79883035
Test: manual
PiperOrigin-RevId: 198884630
Change-Id: I61636776c234a4000dbaf1e206ffd0429364d942
|
|
Bug: 76205353
Test: GlidePhotoManagerImplTest
PiperOrigin-RevId: 198872893
Change-Id: I7957078a63af2455e439286b8d2ef719d4c9ff4e
|
|
Solves BiDi problem that might cause phone number to be displayed
incorrectly in the dialer. Issue might occur when a phone number
is concatenated with a custom number label containing an RTL-string.
Solved by changing affected labels from TextView to BidiTextView.
Removed function spanDisplayNumber in BottomRow which are now obsolete.
Updates the DialerBidiFormatter to prevent whitespace to be misplaced
within a BidiTextView.
BUG=78464687
TEST=Manual
Public-Origin-Change-Id: I789a6f76a5ca805c03a437813ce627eef7a0bf2e
Signed-off-by: Linyu He <linyuh@google.com>
Author: Torbjorn Eklund <torbjorn.eklund@sony.com>
Bug: 78464687
Test: Manual
PiperOrigin-RevId: 198823629
Change-Id: Id35c3ebf514609b4a1fe10a7ae5a297bde7c7456
|
|
Bug: 79883035
Test: manual
PiperOrigin-RevId: 198813765
Change-Id: If7dda82316946c7d1c07a3d7fb08e13c858807be
|
|
It no longer provides any value, so just use dagger directly.
Bug: 80441695
Test: tap
PiperOrigin-RevId: 198806461
Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
|
|
Bug: 80303132
Test: InAppSpamTest, verified using Blueline device
PiperOrigin-RevId: 198801576
Change-Id: I30f8c0c7c850ac4bd7b6fcf2dad18c0d70f1b2d1
|
|
Bug: 79701706
Test: tap
PiperOrigin-RevId: 198747775
Change-Id: I3bd0d26ee6621ebe428e4e8c82b51959d313608f
|
|
Test: manual
PiperOrigin-RevId: 198609574
Change-Id: Ic5e599b65d81968bdacaf6a90cb1ad34647b8419
|
|
Bug: 79522243
Test: manual
PiperOrigin-RevId: 198598685
Change-Id: I05144ec734827b29e89bbba5070c9cb0ab06c215
|
|
Test: nope
PiperOrigin-RevId: 198596861
Change-Id: Ibc2cccdcb7b02b5ba8b79f5429babc9028f282d8
|
|
Bug: 79883035
Test: tap
PiperOrigin-RevId: 198510062
Change-Id: Ia07624a4511626b2b397199f3674817612557133
|
|
Test: manual
PiperOrigin-RevId: 198488607
Change-Id: I54e2d7ac4320fd67e1670bb2e888cfe833dfb243
|
|
Test: unit
PiperOrigin-RevId: 198080186
Change-Id: I0ecc1f918b2c62e42b287e4fc9ea38fafaf1e6c9
|
|
- clear call log dialog no longer crashes
- phone account selector dialog now has a visible title
- dialpad text in the incall ui is now visible.
Bug: 80144855,80146941,80175230
Test: tap
PiperOrigin-RevId: 197952658
Change-Id: Ifaea9b798fef7e36d681a83269e4f65df33f1193
|
|
TEST=TAP
Bug: 77976254
Test: TAP
PiperOrigin-RevId: 197924728
Change-Id: I512ebe193cefae24e45c0526bcabdcb23846e236
|
|
Bug: 79523664,80195371
Test: Need to add Scuba tests (http://b/80194939)
PiperOrigin-RevId: 197821095
Change-Id: I92ea1e6b95d264ea69f7d30eea12f547ee60eeac
|
|
Test: manual
PiperOrigin-RevId: 197810897
Change-Id: Ia9dff17333152763b6c644d4f89bc32eedcc2aab
|
|
PrimaryInfo#setPhotoUri for new GlidePhotoManager implementation. As part of this addition, we also are cleaning the setPhoto(null) because this is not explicitly needed.
Bug: 76206920
Test: BottomRowTest,TopRowTest,SpeakEasyFragmentV2Test
PiperOrigin-RevId: 197785533
Change-Id: I1702f43ec206a6c31cf162978712292aff0f8a17
|
|
This enables us to have Google-Sans font in GoogleDialer and Roboto in AOSP.
Bug: 79883035
Test: tap
PiperOrigin-RevId: 197774497
Change-Id: I1d490ab196a444c62e439444627d659fc42973ea
|
|
Also cleaned up unused parameters.
TEST=TAP
Bug: 78654933
Test: TAP
PiperOrigin-RevId: 197652430
Change-Id: I1820e8c8de83fcda17f38e92d4ab1c28f519cdce
|
|
- README on how to properly theme Dialer going forward.
- Migrated all widgets to use global colors.
- Removed all activity and application themes where it wasn't necessary.
- Added themeing test rule for Espresso tests.
Bug: 79883035
Test: tap
PiperOrigin-RevId: 197634256
Change-Id: I4b7d94d45aeeb59d484b0069fdd1e200a654910b
|
|
If a device supports hiding the navigation bar and it is enabled,
preview image overlaps a call button during video call. Because the
preview layout doesn't care about the visibility of the navigation bar.
To fix the problem, use APIs of WindowInsets that care about the
visibility of the navigation bar.
Bug: 80376182
Test: manual - Checked the preview image doesn't overlap a call button
when the navigation bar is not visible.
Change-Id: I72c9d504f0485c24a6be09a50869a8248745623f
|
|
Bug: 79885898
Test: manual
PiperOrigin-RevId: 197630981
Change-Id: Ib4ace31c7c207f5ee9f69aee148ddf49021da37b
|
|
dialog.
Test: N/A
PiperOrigin-RevId: 197629283
Change-Id: Ia1765cb42f08002c671a5ac4a774d9b69dfaeda0
|
|
When a call is downgraded, video call might be set to null by telecom.
TEST=TAP
Bug: 79336398
Test: TAP
PiperOrigin-RevId: 197479259
Change-Id: Ib5400b0d59bc97b952ee64aad41812f3477a3722
|
|
Instead of fake a black bar on voice incall UI, the more reliable way is to set
navigation bar color.
Bug: 79902234
Test: manual
PiperOrigin-RevId: 197475300
Change-Id: I96085700e633570ef385386cdf366d758e50a6e2
|
|
This CL adds alternative spam words and code for using these words in an experiment.
Test: Tap, Unit tests where alterntive experiment is provided and not provided.
PiperOrigin-RevId: 197444892
Change-Id: Iff042966f1728ac571699085f07d1325e756dd36
|
|
Refactor Duo disclosure card to general promotion card.
Bug: 78905507
Test: unit tests
PiperOrigin-RevId: 197436677
Change-Id: I511c39308cadfb96ee4519b71ca29b75d0e6750b
|
|
deleted several colors and unified them across the app
migrated several alert dialogs to support alert dialogs
added many todos
migrated several tests from GoogleRobolectricTestRunner to RobolectricTestRunner
Because of the test migration:
- moved dialpad theme attributes into dialpad/theme
- moved incall ui theme attributes into incallui/theme
Bug: 79883035
Test: tap
PiperOrigin-RevId: 197246477
Change-Id: Ifc534793bc32757bbbf2007a7c40287c8d0817ad
|
|
Bug: 79723777
Test: manual
PiperOrigin-RevId: 197245874
Change-Id: Iad639ef467c8d0db861dddb7a174355127b8636c
|
|
instead of canceling it and recreating a new notification.
Test: ManuallyTested
PiperOrigin-RevId: 197093375
Change-Id: I5214acd160d10a191d66c95798b2a44cdd3a9c7e
|
|
contact photo creation. If the photoUri does not exist, GlidePhotoManagerImpl will create the needed LetterTileDrawable to use in the contact photo's place.
Bug: 76204286,76206686,76206786
Test: ContactGridManagerTest
PiperOrigin-RevId: 197034807
Change-Id: Icb286e557b21a21029bfa7e7d5a390e4eb889dde
|
|
Double clicking add call button mutes the call, and going back to in call UI doesn't unmute the call. It's because previousMuteState is set twice. We shouldn't do anything for the second click since the first click makes you leave in call UI.
Also change automaticallyMuted to automaticallyMutedByAddCall to clearly indicate the value is for add call button only.
Test: CallButtonPresenterTest
PiperOrigin-RevId: 196590319
Change-Id: I9f41b1a75ced3900ae0c4fa787f3defaf7f1cbe6
|
|
Test: tap, manual
PiperOrigin-RevId: 196582079
Change-Id: Iffbfa408cbb32e81824cd46a67d51baa270132cf
|
|
Test: Tap
PiperOrigin-RevId: 196562314
Change-Id: Ie90a5ad183d4fb65ff512ea158a8687fe1f77963
|
|
Test: tap
PiperOrigin-RevId: 196278370
Change-Id: Ied6072caf4a6e87da5ba6395db8c0b0fa55b3f97
|
|
Bug: 194611503
Test: Unit Test
PiperOrigin-RevId: 196190392
Change-Id: I11fc1a02bd89207bf1c2d12f2821ef4447529c6e
|
|
Test: presubmit.
PiperOrigin-RevId: 196158524
Change-Id: Iec1e457039e97be0236cd700d397b4095ee3c2c3
|
|
Bug: 67596257
Test: unit tests
PiperOrigin-RevId: 196049621
Change-Id: I6f9c6292b1d56e3faf7808aa668b03d07230a70b
|
|
Bug: 73774884
Test: unit
PiperOrigin-RevId: 196021103
Change-Id: Id2176e6ef4259dc6e1136564051dae14e30175d4
|
|
Test: N/A
PiperOrigin-RevId: 195995975
Change-Id: I0311770eecdf36f275d81ba481098259344cbf5b
|
|
Test: manual
PiperOrigin-RevId: 195856176
Change-Id: I8579afff48e9c07d422505b81d703adc03656435
|
|
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 195747611
Change-Id: Ibce7ef45af2f79cc5a35825a2bb38fe268a4681c
|
|
This CL consolidates common duo calling operations into precall, including checking reachability, falling back to carrier video call, placing the call to duo with startActivityForResult.
TEST=TAP
Bug: 78783816
Test: TAP
PiperOrigin-RevId: 195742478
Change-Id: I9fea1e4999f604e1f3a153b28079cd0db77b7393
|
|
Test: Build
PiperOrigin-RevId: 195498557
Change-Id: I28525d0475f847b2ff5a128580256e2688ed47d5
|