summaryrefslogtreecommitdiff
path: root/java/com/android/incallui
AgeCommit message (Collapse)Author
2018-03-01Update RTT icon on ringing screen.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187551861 Change-Id: I38facbaaa48ba4afe29e382de9c8241d8936c3ab
2018-03-01Disable phone number formatting for devices with Argentinian SIMs.linyuh
Bug: 73718977 Test: PhoneNumberHelperTest PiperOrigin-RevId: 187540382 Change-Id: I814ec62b2215c24b8cde3442c5dc83d98ad87164
2018-03-01Implement overflow menu for RTT call.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187529383 Change-Id: I6ef6593a79ef0c4fb407284eede966a1eaabcd1e
2018-03-01Updating SecondaryInfo value class to use AutoValue with builder pattern.Android Dialer
Test: CallCardPresenterTest,SecondaryInfoTest PiperOrigin-RevId: 187481728 Change-Id: I3d2b23b5d51ea1e5ff30b8f6b6570d76c006fe86
2018-02-28Remove background of RTT chat fragment.wangqi
The default incall gradiant background will be shown instead. Bug: 67596257 Test: manual PiperOrigin-RevId: 187384455 Change-Id: Icf91804d78aa98d051248a9eca0d13be0ea880f0
2018-02-27Move DirectoryCompat from "contacts/common" to "dialer/common/cp2".linyuh
Bug: 73887387 Test: Existing tests PiperOrigin-RevId: 187225355 Change-Id: I65de553078e147a46d933daf34dfd912fc8aa74c
2018-02-27Fix bug that soft keyboard pushes action bar out of window.wangqi
This is happening on outgoing call. Bug: 67596257 Test: manual PiperOrigin-RevId: 187207221 Change-Id: I09e8be0dbad695a1a5afb64e08faf533d068e5c4
2018-02-26Updating PrimaryCallState value class to use AutoValue with builder pattern.Android Dialer
Bug: 34502119 Test: BottomRowTest,CallCardPresenterTest,PrimaryCallStateTest,TopRowTest PiperOrigin-RevId: 187071451 Change-Id: Ib1b4baee397f61eade84bf1a887596dddc37230a
2018-02-26Implement logic of bottom sheet options related to spam numbers.linyuh
Bug: 70989605 Test: ShowBlockReportSpamDialogNotifierEndToEndTest + Manual PiperOrigin-RevId: 187047450 Change-Id: I23c3929135bcfe5c14fe317ef65f628dc126027f
2018-02-23Track initial call log building metrics separately from incremental building ↵zachh
metrics. This required creating "CallLogState" which is currently just a boolean value which can only be turned on once (when the annotated call log flow finishes for the first time). This CL also changes CompositePhoneLookup to no longer implement PhoneLookup. This was done to support a now reverted implementation of CallLogState but it's easier for me to keep the change and it shouldn't be harmful. Bug: 70989667 Test: unit PiperOrigin-RevId: 186852257 Change-Id: I3f342737aaf909f8230b8a69d9c21e6e5c19b84e
2018-02-23Fix bugs of RTT chat.wangqi
1. send bubble break characters to remote 2. correctly handle text replacement Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 186850402 Change-Id: I0aebb0f4315a021da1463d7903d28e912918efca
2018-02-22Fix bug in isVoicemailNumber method not returning earlyroldenburg
Bug: 72997695 Test: existing tests, LoggerUtilsTest, placed call to voicemail and verified PiperOrigin-RevId: 186677560 Change-Id: I63d0a463f890c8cc1a301daa37388f58aed33aae
2018-02-22Updating PrimaryInfo value class to use AutoValue with builder pattern.Android Dialer
Bug: 34502119 Test: BottomRowTest,CallCardPresenterTest,PrimaryInfoTest,TopRowTest PiperOrigin-RevId: 186460178 Change-Id: Ifb90019b6a5568788d51f4a55a07f7693c803eaf
2018-02-22Moved metrics related methods out of LoggingBindings.zachh
Test: existing PiperOrigin-RevId: 186413083 Change-Id: I96c88c46b0ecc01167b655fa30fc47aaa6a9e351
2018-02-22Implement read/write text stream to RttCall.wangqi
This change also: 1. Add simulator support of RTT request during call (always accept at this moment, will add random accept/decline in the future) 2. Fix bugs of putting RTT call in background and back to call Bug: 67596257 Test: Simulator PiperOrigin-RevId: 185920527 Change-Id: I51016fa6cf1ccc8a5a21335f9dacf286ae393706
2018-02-22Annotate RTT as @TargetApi(28).wangqi
Bug: 67596257 Test: lint tests PiperOrigin-RevId: 185912566 Change-Id: I281fbd62865c9de150c3e2a7a3ea79c3eb85c529
2018-02-22Move RttChatBot to simulator.wangqi
Bug: 67596257 Test: none PiperOrigin-RevId: 185561470 Change-Id: I96755cc76e2a1cba65cd496d74593cdd1dedddae
2018-02-22Update RTT call with real name/number and timer.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 185561269 Change-Id: I81bdf379dd2411540c012df40dc0461f31aca9ea
2018-02-22Add simulator RTT call.wangqi
This change will also: 1. Disable proximity sensor for RTT call 2. Update RTT call screen, including colors and banner buttons Bug: 67596257 Test: presubmit PiperOrigin-RevId: 185541897 Change-Id: I571373efbb8ced4ee2ad94879e9d37bed33b6a28
2018-02-09Update title of after call spam dialog.wangqi
Bug: 73136533 Test: none PiperOrigin-RevId: 185160539 Change-Id: I43cc987c646a13d1d012415c0869780317dcb7b8
2018-02-09Finish AudioRouteSelectorActivity when all calls disconnect.yueg
Bug: 67605985 Test: AudioRouteSelectorActivityTest PiperOrigin-RevId: 185069195 Change-Id: Icae34dd6374a775c3ad5d3835750bd2fe703dfa0
2018-02-09Show reject hint text for all incoming callswangqi
The function setHintText sets the hint text reject text to null when hintText for answering a call is non-null. Correcting so the reject text is always be set to call_incoming_swipe_to_reject regardless of the value of hintText. This is an upstream change from: https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/612667 Bug: 73018780 Test: manual PiperOrigin-RevId: 185020322 Change-Id: I413f8cf63a1b11e70300536a13c1a8a103d847cc
2018-02-06Bubble layout change.yueg
- Flip back-to-call button icon. - Use different button height for portrait and landscape. In order to make it work, we also create new ViewHolder object when bubble shows and remove reset() when bubble hides. Bug: 67605985 Test: NewBubbleImplIntegrationTest, NewBubbleImplTest, NewReturnToCallControllerTest PiperOrigin-RevId: 184768224 Change-Id: If4e613b12e39c647c34f4cb63a7f934043d42ec7
2018-02-05Remove bubble v1.yueg
Bug: 67605985 Test: manual PiperOrigin-RevId: 184358120 Change-Id: I17288da2b059f18bd51247e27aa174c7994e6f05
2018-02-02Update the SpeakEasy component.erfanian
Test: unit tests PiperOrigin-RevId: 184352489 Change-Id: If3f2414dd9769dc54035c7fcf5afe925af3006db
2018-02-02Update text on after call spam notification and dialog.wangqi
This change also includes: 1. Fixes formatting of phone number in the dialog. 2. Remove body text if the dialog. 3. Update to material design dialog style. Bug: 72120616 Test: manual PiperOrigin-RevId: 184350133 Change-Id: I8bdd9c792877822fe18ba6aae6c04136a603dbba
2018-02-01internal changeAndroid Dialer
Bug: 68825005 Test: Added unit tests on CallFeedbackListenerImpl, CallFeedbackNotificationManager and DialerCall. Also manually verified the change. PiperOrigin-RevId: 184211115 Change-Id: I50927036c3cd5d47862704376e2eef108c473fbf
2018-02-01This text is for dismiss button in dialog that's to dismiss the dialog afterwangqi
a call, instead of to hang up the call. Bug: 72120616 Test: none PiperOrigin-RevId: 184162123 Change-Id: I20dbdb258ad0640fa4ed8cf6492549ba9c62eda6
2018-01-31Add arrow icon to bubble sound button when Bluetooth is connected.yueg
It's an indicator that the button triggers another list. Bug: 67605985 Test: manual PiperOrigin-RevId: 184042869 Change-Id: I3fea526a322dcc3935af111ebd0916b7c5ffcb24
2018-01-31Remove bubble from AOSP.yueg
Bug: 67605985 Test: NewBubbleImplTest, NewBubbleImplIntegrationTest, NewReturnToCallControllerTest PiperOrigin-RevId: 184026033 Change-Id: Ie141ce9a0265ce3a08c01943cdeb94e2cd962e9f
2018-01-30Don't override contactExists if there is no update from Cequint Caller ID.wangqi
Bug: 72485878 Test: none PiperOrigin-RevId: 183915863 Change-Id: Ib035855d944c91145418222cc390be066744b4fb
2018-01-26Added number presentation to AnnotatedCallLog.zachh
Updated the new call log UI to properly show text based on the presentation. Bug: 70989592 Test: unit PiperOrigin-RevId: 183414195 Change-Id: I2123f37cd3c733060125b6e894c1a80be4193ad6
2018-01-25Update preferred SIM SuggestionProvidertwyen
"remember this SIM" checkbox state is reported to the provider. The other SIM is reported to the provider when "change SIM" is used Bug: 70503524 Test: Unit tests PiperOrigin-RevId: 183308581 Change-Id: I3d097d14a503c759f130044c9a9c48c420eee19d
2018-01-24Bubble v2 a11y.yueg
- Set checkable for bubble buttons so the check status of non checkable button (back to call, end call) is not read. - Add support for bottom action buttons. Test: manual PiperOrigin-RevId: 183150371 Change-Id: Ifae9c912ec923e8d2cda3146413138bd2eb94b47
2018-01-24Add flag to enable NUI shortcut.calderwoodra
Bug: 64655802 Test: n/a PiperOrigin-RevId: 183149638 Change-Id: Idc58efced8f70311eccd67f403bc5bd98f3f8518
2018-01-24Add foreground service permissionroldenburg
Bug: 72116995 Test: built APK, verified permission PiperOrigin-RevId: 183126225 Change-Id: I0889ea619a21413e510a7b58143c5011ed81b688
2018-01-24Fixed a regression where we incorrectly reported that the dialpad was visible.calderwoodra
A request was made to update the value of #isDialpadVisible, in the process a regression was introduced that would cause #isDialpadVisible to return true when the dialpad's root view was null. This caused a NPE when we tried to animate it. We should now return the correct value in the scenarios important to our partners as well our users and animations. Bug: 64657832,72384544 Test: manual/logging PiperOrigin-RevId: 183122628 Change-Id: I981e944dbb003064163b8ec11883dbc5381cba0e
2018-01-23Updated call number by NW is not displayedwangqi
CallCardPresenter updates a call number if the number is updated by NW. But the logic is worng. The comparing numbers are always same. Because it compares with the same objects in DialerCall#areSameNumber. This is a upstream change from: https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/556000 originating number is shown in the call screen. Bug: 70201489 Test: manual - Verified that a call number that changed from a PiperOrigin-RevId: 183022988 Change-Id: I04305998e77ca120b1248636c63984b3d20f0db1
2018-01-23Update Assisted Dialing references.erfanian
Test: existing unit tests PiperOrigin-RevId: 182949031 Change-Id: I40955c6e5f4fe06687880d3e9ef4b91ef9c0b371
2018-01-22Changed PhoneLookup#lookup to accept a DialerPhoneNumber.zachh
There's a problem with the existing implementation of RealtimeRowProcessor; when CP2 information is not present, data from other sources can potentially be erased. This CL fixes the problem by fetching the latest data from all sources, instead of just CP2. This requires being able to fetch PhoneLookup info without a Call, using only a number, so I changed PhoneLookup#lookup to accept a DialerPhoneNumber rather than a Call. (The reason that it accepted a Call was to support CNAP so we'll need a revised solution for that later.) There is a potential concern with performance in RealtimeRowProcessor due to performing a full [Composite]PhoneLookup vs. a CP2 lookup, because the full lookup includes network requests. However, it's anticipated that the real time lookups will very rarely have changes to apply so this might be OK as-is. If not, a mitigation strategy could be improving the performance of CompositePhoneLookup#lookup by short-circutiing slower sources when faster, higher priority sources have already completed. A follow-up CL will write the result of RealtimeRowProcessor queries to PhoneLookupHistory to further reduce how frequently real time updates need to be applied. Bug: 72229553 Test: existing unit PiperOrigin-RevId: 182839130 Change-Id: I8cb26827b4f4dc4702fb416234c8938179cd5ac5
2018-01-19Update Simulator to launch SpeakEasyAndroid Dialer
Test: PiperOrigin-RevId: 182625448 Change-Id: I4fe514c429a6b5a88060f326b0c73c2f3a960c1c
2018-01-18Pass PhoneAccountHandle into VideoTech isAvailableroldenburg
Bug: 71840382 Test: DuoImplTest, existing tests PiperOrigin-RevId: 182424150 Change-Id: I25607d43e1915d57134feac99b2c2240ae9559f9
2018-01-17Move onUiShowing() call from onResume/onPause to onStart/onStop.yueg
It makes sure bubble doesn't appear on split screen when in-call UI is not showing. Although bubble still shows in recents screen. It also make sure the same onUiShowing() is not called multiple times. Bug: 67605985,71746139 Test: InCallActivityTest PiperOrigin-RevId: 182280886 Change-Id: I2a28d0258c722d530000729a89751c6d6b1ee6fd
2018-01-16Use EmptyVideoTech instead of null RcsVideoShare VideoTech impl when unavailableroldenburg
Bug: 67005309,71880949 Test: VideoTechManagerTest PiperOrigin-RevId: 182091664 Change-Id: I0be4d4f9740e2bb678e772ec8526ccf176c334eb
2018-01-11Fixed bug in handling of empty numbers in new call log.zachh
Empty numbers were not being inserted into PhoneLookupHistory because the URI "content://.../PhoneLookupHistory/" is treated the same as "content://.../PhoneLookupHistory" (w/o the trailing slash). This caused the update (i.e. replace) operation to incorrectly update all rows in the table when it should have updated a single row. The fix for this was to switch to a query parameter, so the empty number URI now looks like "content://.../PhoneLookupHistory?number=" Also improved some logging while debugging this problem. Bug: 71866050 Test: unit and manual PiperOrigin-RevId: 181659081 Change-Id: Idec4fb77e74920cd5485620b0a997db03aa8ff9b
2018-01-10Add the boilerplate dagger logic for SpeakEasy.erfanian
Test: NONE PiperOrigin-RevId: 181524242 Change-Id: If5d3632421722b4da7b64f78d904b58723408b7c
2018-01-10Roll forward the broadcast in-call UI changes.yueg
Test: InCallPresenterTest PiperOrigin-RevId: 181512032 Change-Id: Id120d9fe6f46ad157eab7f97614d0c18b6aef8e1
2018-01-10Update content description of back button on banner of RTT chat.wangqi
Bug: 70177426 Test: none PiperOrigin-RevId: 181500079 Change-Id: Ia07e5fc487b9fe64ecfedb074a543fc993b303c4
2018-01-09Adjustment to banner of RTT chat window.wangqi
1. Change name and timer font to roboto medium 2. Change close button to back button Bug: 67596257,70177426 Test: manual PiperOrigin-RevId: 181404033 Change-Id: I19137c51a6617276dd5ae6a7ba47c12d995e2feb
2018-01-09Allow SimSuggestionProvider to auto select phone account.twyen
Bug: 70503524 Test: Unit tests. PiperOrigin-RevId: 181400523 Change-Id: I07f2f2cd7c1402d1acb6bfbde9db8d90c888edf6
2018-01-09Fix NPE in NewReturnToCallController.createLettleTileDrawable().yueg
After searching contact info, the associated dialer call object might be removed from CallList, which causes NPE. Test: NewReturnToCallControllerTest PiperOrigin-RevId: 181387022 Change-Id: Icabaeccc96e039c8ac53d66c23af89d3eb0823a9
2018-01-09Let RCS Video Share take over Duo as the active video tech for a callroldenburg
Bug: 67005309 Test: VideoTechManagerTest PiperOrigin-RevId: 181368613 Change-Id: I8a13bd04d3ac342a06febb7437a0e0dd3d25affd
2018-01-09Handle android.telephony.event.EVENT_CALL_FORWARDED.wangqi
Bug: 33761801 Test: none PiperOrigin-RevId: 181347696 Change-Id: Iaf09d1b45a2e97e4d8da24b5bd7172da152d703c
2018-01-09InCallActivity should not call onUiShowing(false) when recreating.yueg
InCallActivity recreates when onNewIntent() and is not visible. Althought onPause() is called, we should not call onUiShowing(false) since the activity is going to be visible. The extra call confuses bubble animation. Bug: 67605985,71746139 Test: InCallActivityTest PiperOrigin-RevId: 181343690 Change-Id: I4d540be0e3e38400322f9b9c3e71e50b1f85977c
2018-01-08Add RTT call chat window.wangqi
This change add a mock in simulator with a type bot that's simulating remote typing. The integration into incall UI will be in following changes. Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 181211591 Change-Id: If6cdcb010afc0c25e90d3a44fe349920d5a856c6
2017-12-27Remove field prefixes.linyuh
Test: Existing tests PiperOrigin-RevId: 180230450 Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
2017-12-22Update assisted dialing extras in preparation for platform implementation.erfanian
* Use only one extra as if we were going to make a request of the Platform. * Modify the incallui to handle instances where the platform may not supply TransformationInfo. This should accommodate instances where the platform "used" assisted dialing, but did not provide the necessary TransformationInfo. Test: unit tests PiperOrigin-RevId: 179841752 Change-Id: I06411dc00812dba8978a2a090d8769dcce9b2ad6
2017-12-22Bubble v2 changes.yueg
- Only show bubble for outgoing, active and background call. (Before: show bubble when is in call) - Show "Call ended" and hide bubble only when there is no outgoing, active or background call. (Before: show "Call ended" for all real call disconnection like one call in conference) - Don't show "Call ended" but only hide bubble when Duo upgrade is accepted/declined. We show bubble for Duo upgrade since the call is still connected. The solution doesn't work for fallback upgrade on pre-ODR device (so "Call ended" still shows). Bug: 67605985 Test: NewReturnToCallControllerTest PiperOrigin-RevId: 179636643 Change-Id: I5d1f6e812c94108228757af89e33d4c496beb735
2017-12-22Always have hardware acceration enabled for InCallActivityroldenburg
This is necessary because Go variants have hardware acceleration disabled at the application level for memory usage reasons. Author: srafeeqh@qti.qualcomm.com Bug: 69490087,70200603 Test: test video call PiperOrigin-RevId: 179629786 Change-Id: Idc900200f41bd1ae7920310b900df5b6e64479b9
2017-12-22Don't use phone number in spam call notificationsmaxwelb
Bug: 67775111 Test: Tap for regressions, manually verified bugreport didn't include PII PiperOrigin-RevId: 179628074 Change-Id: If9ee7fcfe709e749da33d0bddf2f7847e68cc422
2017-12-18Bubble v2 logging.yueg
Log the following actions: - expand/collapse bubble - return to call - mute/unmute - switch audio route to speaker/bluetooth/wired or earpiece - end call Bug: 67605985 Test: AudioRouteSelectorActivityTest, NewReturnToCallControllerTest PiperOrigin-RevId: 179484647 Change-Id: I4e2ee34f5550382b2e51bab16ce33e9e16caa3b2
2017-12-18Allow orientation change when receiving video upgrade request in the in-call UI.linyuh
Bug: 67764843 Test: Manual PiperOrigin-RevId: 179463451 Change-Id: Iee1999c673a0b6f67d8e538745c23e75865a5262
2017-12-18Upgrade target SDK version to 27.linyuh
Test: None PiperOrigin-RevId: 179458302 Change-Id: Ic6bfd4abe4c7f51d395488863edc1515754f6b36
2017-12-18Bubble v2 animation change.yueg
When expand/collapse, use RoundedRectRevealOutlineProvider to reveal/unreveal from top left or top right corner. It's similar to app icon popup in Pixel 2. And animate this together with bubble moving to the middle. Also reduce animation duration. Bug: 67605985 Test: manual PiperOrigin-RevId: 179435867 Change-Id: I58557f77d0db167dc9d2a2dadeb5bc4cfa16702f
2017-12-15Turning on the screen when audio stream of an incoming call is directed ↵linyuh
through Bluetooth. Bug: 70638560 Test: InCallActivityTest PiperOrigin-RevId: 179261692 Change-Id: I269c8573592e6ff6083efc201e6bede74a01ee06
2017-12-14Take into consideration special characters when we do contact match.linyuh
Bug: 30225112 Test: CallLogGroupBuilderTest, PhoneNumberHelperTest, CallerInfoTest, and Manual (see demo) PiperOrigin-RevId: 179080046 Change-Id: I8e451a6c197a6c3df4260e58d0276a5dc5b9515a
2017-12-14Recycle TypedArray for AutoResizeTextView.wangqi
Bug: 70625240 Test: none PiperOrigin-RevId: 179069025 Change-Id: Iaabbe55fdbedd8ae901c6b9cf0c67be1adb31eb4
2017-12-12Refactor CallerInfo and ContactInfoHelper to improve readability.linyuh
Test: Existing tests PiperOrigin-RevId: 178862915 Change-Id: I2dd58db10d546c062b0f43dad80f74d588cb65e1
2017-12-12Move TelecomCallUtil to com.android.dialertwyen
Since PhoneLookup exposes Call, more common access to the utility is required. Bug: 70355819 Test: TelecomCallUtilTest PiperOrigin-RevId: 178847628 Change-Id: I6cf55ad4e3566596b7b2e8cffb5a1614e6640a8b
2017-12-12InCallActivity#isDialpadVisible() now returns the correct value.calderwoodra
Bug: 64657832 Test: manual/logging PiperOrigin-RevId: 178824989 Change-Id: I202389123732c05680ba329313e889437fb4a806
2017-12-12BEGIN_PUBLIClinyuh
Automated rollback of changelist 172505648 Bug: 30225112 Test: None PiperOrigin-RevId: 178815682 Change-Id: I1fe1eef49d587314d32e7125f5106769b3099ad3
2017-12-11Also show bubble avatar for incoming call and outgoing call.yueg
Instead of just showing avatar for active or background call, we should also show avatar for other calls. In the order: 1. incoming call 2. outgoing call 3. active or background call Test: NewReturnToCallControllerTest PiperOrigin-RevId: 178675371 Change-Id: Ibf8b757821d9a6420ba56439e4f6a93e9e5c3d91
2017-12-11Update Spam module to use Daggermaxwelb
Test: TAP PiperOrigin-RevId: 178650781 Change-Id: I299907ac43d48b984b092433c9b651aadb17c62a
2017-12-07Added manifest override for PhoneLookupHistory provider.zachh
Enabled PhoneLookupHistoryRecorder. Bug: 34672501 Test: manual PiperOrigin-RevId: 178030404 Change-Id: I4626262ebed14a9478f5ac8fc89fc81655e98b70
2017-12-07Hide bubble in (New)ReturnToCallController.tearDown().yueg
There is the case that onDisconnect() is not called but InCallService is unbind. Currently we only hide bubble when call disconnected. We should also do it when InCallService is unbind. Test: NewReturnToCallControllerTest, ReturnToCallControllerTest PiperOrigin-RevId: 178029862 Change-Id: I6806c5c80adb06317f09019bdf3420b462225945
2017-12-07Temporarily disable PhoneHistoryRecorder.zachh
PhoneLookupHistory provider isn't correct overridden in GoogleDialer manifest. I'l fix that in a later CL. Test: manual PiperOrigin-RevId: 177988816 Change-Id: I42af03d22db50bd70219d52826294529462bae43
2017-12-07Bubble v2 animation changes.yueg
Including: - expanded view expands/collapses from top of itself - small icon on avatar shows on left side when bubble is on right side - when expand on bottom, bubble move up a bit so that expanded view doesn't go off screen. It also go back to previous position when collapse. - remove animation for collapse when move expanded bubble This change should not enable bubble v2 for anyone. Bug: 67605985 Test: manual PiperOrigin-RevId: 177974562 Change-Id: Id83f3f744b717d51fbe58e58769ac2cd2810d2b5
2017-12-07Added PhoneLookupHistoryRecorder.zachh
When a call is added in InCallUi, it fetches the current PhoneLookupInfo for the call and writes it to PhoneLookupHistory. Required updating PhoneLookupHistoryContentProvider#update to use "replace" to (presumably) atomically insert when a row is missing. Bug: 34672501 Test: unit PiperOrigin-RevId: 177896892 Change-Id: I43f9ded240a81156722be816a9635d586de642a1
2017-11-30Rollback Broadcast in-call UI changes.yueg
Test: none PiperOrigin-RevId: 177490090 Change-Id: Ide2ea08f89b8a8072913617e6ce4587abffc7df4
2017-11-30Fix NPE crash on video call.wangqi
Bug: 69960961 Test: manual PiperOrigin-RevId: 177486235 Change-Id: I241867456830e0a8479ed0652aac71abc77c86e3
2017-11-30*** Reason for rollback ***roldenburg
Copybara is fixed for AOSP export Bug: 68665330 Test: rollback PiperOrigin-RevId: 177480870 Change-Id: I0ba38e213bb840436fa6dafc4af0a79019ee93f4
2017-11-29Enable timer in emergency call.wangqi
"This phone's number: xxx" is shown for emergency call which replaces in call timer. This change move it to under emergency location service so timer could be shown again. Bug: 69810801 Test: manual PiperOrigin-RevId: 177363955 Change-Id: I543fbbee869923800ffd92a5799819b712f0b953
2017-11-29Prevent change SIM icon from showing during a voicemail calltwyen
Calling the VM other number is to complicated for this release. Bug: 69803593 Test: CallButtonPresenterTest PiperOrigin-RevId: 177193486 Change-Id: I4149abe1d6eea48bb5399e12b9ce43a8e1ef4b37
2017-11-29Refactor DialpadFragment's DtmfKeyListenermaxwelb
This change is the refactoring on DtmfKeyListener and adding tests. The class is an overridden version of DialerKeyListener, but it also supports direct onKeyDown and onKeyUp hooks from the DialpadFragment. There was a lot of duplicated code between these hooks and the overridden methods so the code was refactored to share more logic. The interesting part of this change is using EMPTY_SPANNABLE to call into super type methods instead of having to copy the implementation. This change may also help with OutOfMemoryExceptions because the DtmfKeyListener is promoted from a non-static inner class to a top level class. It no longer maintains an implicit reference to the DialpadFragment, holding onto the DialpadPresenter instead. To support testing this code, the ShadowCall had to be updated since it didn't support checking when a Dtmf tone was playing. Bug: 69133398 Test: DtmfKeyListenerTest, InCallActivityTest PiperOrigin-RevId: 177092841 Change-Id: I368083c71982e14db0ad936432a3a5bdf0dde5ee
2017-11-29Add impressions for dual sim featurestwyen
Bug: 69618691 Test: CallingAccountSelectorTest PiperOrigin-RevId: 177062349 Change-Id: I4bc9098d06c541b607cca293269cf3489077b6c2
2017-11-22Prevent SIM selection and change SIM from showing when there are active callstwyen
Most devices are DSDS (dual SIM dual standby) which only one SIM can have active calls at a time. Telecom will ignore the phone account handle and use the current active SIM. The SIM selection dialog has no effect, and the change SIM button will just redial with the same SIM. Bug: 69417430 Test: CallingAccountSelectorTest, CallButtonPresenterTest PiperOrigin-RevId: 176718021 Change-Id: I231cfeaa5ff77c29cdaf8e0865d096c85cfb7fc4
2017-11-22Bubble v2 UI changes.yueg
Including: - Use exit-to-app icon instead of fullscreen icon for back-to-call button - Use ripple for first button since it needs top-rounded background - Change red hang-up button color and grey icon and text color - Change some dimensions Bug: 67605985 Test: manual PiperOrigin-RevId: 176678427 Change-Id: I3f7836d832f7130f82d7f3764fb392807f3fab9a
2017-11-21Adding call feedback mechanismAndroid Dialer
Test: No impact on existing functionalities PiperOrigin-RevId: 176562444 Change-Id: I209379dde3e920a27d6e735c8494647154e40e5a
2017-11-21Merge what's left in InCallActivityCommon into InCallActivity.linyuh
Bug: 69272096 Test: None PiperOrigin-RevId: 176443652 Change-Id: I90da4789deb4b6337a38cfe010b8aee5090d35e0
2017-11-20Implement SIM selection dialogtwyen
Bug: 64216442,64214592,64213352 Test: N/A PiperOrigin-RevId: 176424724 Change-Id: I1709156098a14ac3bd35d98b913e7b881fcd9b2b
2017-11-18Added place voice call search action to regular search.calderwoodra
When a user types a phone number into the search bar, there isn't an intuitive way for them to place a call when the number doesn't match any existing contacts in the new search UI. This change adds the option to place a voice call from regular search, like the old UI. Bug: 69385190 Test: NSFT PiperOrigin-RevId: 176189153 Change-Id: I6c1561bcce104c56855d996570a79b34da7230ff
2017-11-18Merge the following methods in InCallActivityCommon into InCallActivity:linyuh
01. handleDialerKeyDown(int, KeyEvent), 02. onBackPressed(boolean), 03. onDestroy(), 04. onKeyDown(int, KeyEvent), 05. onKeyUp(int, KeyEvent), 06. onPause(), 07. onSaveInstanceState(Bundle), 08. onStart(), 09. onStop(), 10. updateNavigationBar(boolean), and 11. updateTaskDescription(). Note that InCallActivityCommon#handleDialerKeyDown(int, KeyEvent) is merged into InCallActivity#onKeyDown(int, KeyEvent). This is part of the effort to delete InCallActivityCommon. Bug: 69272096 Test: None PiperOrigin-RevId: 176161247 Change-Id: I6e74c7feec5414fb4bc58814eef3bd297d6eb96f
2017-11-18Implement change SIM animationtwyen
CheckableLabledButton will no longer set icon if the icon has not changed, so the animation will not be interrupted. Bug: 64215256 Test: N/A PiperOrigin-RevId: 176047325 Change-Id: I8cb0c6e706b931406e78c91821f75e266e453ceb
2017-11-18Merge the following methods in InCallActivityCommon into InCallActivity:linyuh
1. maybeShowErrorDialogOnDisconnect(DisconnectMessage), 2. onDialogDismissed(), 3. showErrorDialog(Dialog, CharSequence), 4. showInternationalCallOnWifiDialog(DialerCall), 5. showWifiFailedDialog(DialerCall), and 6. showWifiToLteHandoverToast(DialerCall). Renaming in InCallActivity: 1. "maybeShowErrorDialogOnDisconnect" -> "showDialogOrToastForDisconnectedCall", 2. "onHandoverToWifiFailed" -> "showDialogOrToastForWifiHandoverFailure", 3. "onInternationalCallOnWifi" -> "showDialogForInternationalCallOnWifi", and 4. "onWiFiToLteHandover" -> "showToastForWiFiToLteHandover". This is part of the effort to delete InCallActivityCommon. Bug: 69272096 Test: None PiperOrigin-RevId: 175991784 Change-Id: I0b31bd93437e633d2f77b09982e0c7fc94ad8a32
2017-11-18Remove unused code InCallUiBings.getUiReadyBroadcastIntent().yueg
It also fixes NPE when mContext is null in InCallPresenter.onUiShowing(). Test: InCallPresenterTest PiperOrigin-RevId: 175898339 Change-Id: Id4aad7e15310663b9f561e5bdc56be5106e24ca8
2017-11-18Move the following methods from InCallActivityCommon to InCallActivity:linyuh
1. enableInCallOrientationEventListener(boolean) 2. isDialpadVisible() 3. getDialpadFragment() This is part of the effort to delete InCallActivityCommon. Bug: 69272096 Test: None PiperOrigin-RevId: 175898158 Change-Id: Ib0f58dbe35d528a475268a86b2af4119e7cfa381
2017-11-18Automated rollbackroldenburg
END_PUBLIC BEGIN_PUBLIC Automated rollback of changelist 169615685 Test: rollback PiperOrigin-RevId: 175863544 Change-Id: I8785da90afed236cbe897efe774263765f188b14
2017-11-18Move InCallActivityCommon#dismissPendingDialogs to InCallActivity.linyuh
This is part of the effort to delete InCallActivityCommon. Related instance variables remain in InCallActivityCommon for now as they are used in several other places. Temporary getters/setters are added in InCallActivityCommon so that InCallActivity has access to these instance variables. Bug: 69272096 Test: None PiperOrigin-RevId: 175853702 Change-Id: Iaeb96c8ad7acb628393dd5c775ad7f3b40940a2b
2017-11-18Automated rollbackroldenburg
END_PUBLIC BEGIN_PUBLIC Automated rollback of changelist 169756942 Test: rollback PiperOrigin-RevId: 175849764 Change-Id: I3be3899682db84521fd933a5f058d5518ecb1fa1
2017-11-18Move InCallActivityCommon#dismissKeyGuard to InCallActivity.linyuh
This is part of the effort to delete InCallActivityCommon. There are 25 references to InCallActivityCommon in InCallActivity and we will remove them one at a time. Bug: 69272096 Test: None PiperOrigin-RevId: 175718978 Change-Id: I0713bd28c2d34791045be2bb851003000b88abca