Age | Commit message (Collapse) | Author |
|
Bug: 71840382
Test: DuoImplTest, existing tests
PiperOrigin-RevId: 182424150
Change-Id: I25607d43e1915d57134feac99b2c2240ae9559f9
|
|
It makes sure bubble doesn't appear on split screen when in-call UI is not showing. Although bubble still shows in recents screen.
It also make sure the same onUiShowing() is not called multiple times.
Bug: 67605985,71746139
Test: InCallActivityTest
PiperOrigin-RevId: 182280886
Change-Id: I2a28d0258c722d530000729a89751c6d6b1ee6fd
|
|
Bug: 67005309,71880949
Test: VideoTechManagerTest
PiperOrigin-RevId: 182091664
Change-Id: I0be4d4f9740e2bb678e772ec8526ccf176c334eb
|
|
Empty numbers were not being inserted into PhoneLookupHistory because the URI "content://.../PhoneLookupHistory/" is treated the same as "content://.../PhoneLookupHistory" (w/o the trailing slash). This caused the update (i.e. replace) operation to incorrectly update all rows in the table when it should have updated a single row.
The fix for this was to switch to a query parameter, so the empty number URI now looks like "content://.../PhoneLookupHistory?number="
Also improved some logging while debugging this problem.
Bug: 71866050
Test: unit and manual
PiperOrigin-RevId: 181659081
Change-Id: Idec4fb77e74920cd5485620b0a997db03aa8ff9b
|
|
Test: NONE
PiperOrigin-RevId: 181524242
Change-Id: If5d3632421722b4da7b64f78d904b58723408b7c
|
|
Test: InCallPresenterTest
PiperOrigin-RevId: 181512032
Change-Id: Id120d9fe6f46ad157eab7f97614d0c18b6aef8e1
|
|
Bug: 70177426
Test: none
PiperOrigin-RevId: 181500079
Change-Id: Ia07e5fc487b9fe64ecfedb074a543fc993b303c4
|
|
1. Change name and timer font to roboto medium
2. Change close button to back button
Bug: 67596257,70177426
Test: manual
PiperOrigin-RevId: 181404033
Change-Id: I19137c51a6617276dd5ae6a7ba47c12d995e2feb
|
|
Bug: 70503524
Test: Unit tests.
PiperOrigin-RevId: 181400523
Change-Id: I07f2f2cd7c1402d1acb6bfbde9db8d90c888edf6
|
|
After searching contact info, the associated dialer call object might be removed from CallList, which causes NPE.
Test: NewReturnToCallControllerTest
PiperOrigin-RevId: 181387022
Change-Id: Icabaeccc96e039c8ac53d66c23af89d3eb0823a9
|
|
Bug: 67005309
Test: VideoTechManagerTest
PiperOrigin-RevId: 181368613
Change-Id: I8a13bd04d3ac342a06febb7437a0e0dd3d25affd
|
|
Bug: 33761801
Test: none
PiperOrigin-RevId: 181347696
Change-Id: Iaf09d1b45a2e97e4d8da24b5bd7172da152d703c
|
|
InCallActivity recreates when onNewIntent() and is not visible. Althought onPause() is called, we should not call onUiShowing(false) since the activity is going to be visible. The extra call confuses bubble animation.
Bug: 67605985,71746139
Test: InCallActivityTest
PiperOrigin-RevId: 181343690
Change-Id: I4d540be0e3e38400322f9b9c3e71e50b1f85977c
|
|
This change add a mock in simulator with a type bot that's simulating remote typing. The integration into incall UI will be in following changes.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 181211591
Change-Id: If6cdcb010afc0c25e90d3a44fe349920d5a856c6
|
|
Test: Existing tests
PiperOrigin-RevId: 180230450
Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
|
|
* Use only one extra as if we were going to make a request of the Platform.
* Modify the incallui to handle instances where the platform may not supply TransformationInfo.
This should accommodate instances where the platform "used" assisted dialing,
but did not provide the necessary TransformationInfo.
Test: unit tests
PiperOrigin-RevId: 179841752
Change-Id: I06411dc00812dba8978a2a090d8769dcce9b2ad6
|
|
- Only show bubble for outgoing, active and background call. (Before: show bubble when is in call)
- Show "Call ended" and hide bubble only when there is no outgoing, active or background call. (Before: show "Call ended" for all real call disconnection like one call in conference)
- Don't show "Call ended" but only hide bubble when Duo upgrade is accepted/declined. We show bubble for Duo upgrade since the call is still connected. The solution doesn't work for fallback upgrade on pre-ODR device (so "Call ended" still shows).
Bug: 67605985
Test: NewReturnToCallControllerTest
PiperOrigin-RevId: 179636643
Change-Id: I5d1f6e812c94108228757af89e33d4c496beb735
|
|
This is necessary because Go variants have hardware acceleration disabled at
the application level for memory usage reasons.
Author: srafeeqh@qti.qualcomm.com
Bug: 69490087,70200603
Test: test video call
PiperOrigin-RevId: 179629786
Change-Id: Idc900200f41bd1ae7920310b900df5b6e64479b9
|
|
Bug: 67775111
Test: Tap for regressions, manually verified bugreport didn't include PII
PiperOrigin-RevId: 179628074
Change-Id: If9ee7fcfe709e749da33d0bddf2f7847e68cc422
|
|
Log the following actions:
- expand/collapse bubble
- return to call
- mute/unmute
- switch audio route to speaker/bluetooth/wired or earpiece
- end call
Bug: 67605985
Test: AudioRouteSelectorActivityTest, NewReturnToCallControllerTest
PiperOrigin-RevId: 179484647
Change-Id: I4e2ee34f5550382b2e51bab16ce33e9e16caa3b2
|
|
Bug: 67764843
Test: Manual
PiperOrigin-RevId: 179463451
Change-Id: Iee1999c673a0b6f67d8e538745c23e75865a5262
|
|
Test: None
PiperOrigin-RevId: 179458302
Change-Id: Ic6bfd4abe4c7f51d395488863edc1515754f6b36
|
|
When expand/collapse, use RoundedRectRevealOutlineProvider to reveal/unreveal
from top left or top right corner. It's similar to app icon popup in Pixel 2.
And animate this together with bubble moving to the middle. Also reduce animation duration.
Bug: 67605985
Test: manual
PiperOrigin-RevId: 179435867
Change-Id: I58557f77d0db167dc9d2a2dadeb5bc4cfa16702f
|
|
through Bluetooth.
Bug: 70638560
Test: InCallActivityTest
PiperOrigin-RevId: 179261692
Change-Id: I269c8573592e6ff6083efc201e6bede74a01ee06
|
|
Bug: 30225112
Test: CallLogGroupBuilderTest, PhoneNumberHelperTest, CallerInfoTest, and Manual (see demo)
PiperOrigin-RevId: 179080046
Change-Id: I8e451a6c197a6c3df4260e58d0276a5dc5b9515a
|
|
Bug: 70625240
Test: none
PiperOrigin-RevId: 179069025
Change-Id: Iaabbe55fdbedd8ae901c6b9cf0c67be1adb31eb4
|
|
Test: Existing tests
PiperOrigin-RevId: 178862915
Change-Id: I2dd58db10d546c062b0f43dad80f74d588cb65e1
|
|
Since PhoneLookup exposes Call, more common access to the utility is required.
Bug: 70355819
Test: TelecomCallUtilTest
PiperOrigin-RevId: 178847628
Change-Id: I6cf55ad4e3566596b7b2e8cffb5a1614e6640a8b
|
|
Bug: 64657832
Test: manual/logging
PiperOrigin-RevId: 178824989
Change-Id: I202389123732c05680ba329313e889437fb4a806
|
|
Automated rollback of changelist 172505648
Bug: 30225112
Test: None
PiperOrigin-RevId: 178815682
Change-Id: I1fe1eef49d587314d32e7125f5106769b3099ad3
|
|
Instead of just showing avatar for active or background call, we should also show avatar for other calls. In the order:
1. incoming call
2. outgoing call
3. active or background call
Test: NewReturnToCallControllerTest
PiperOrigin-RevId: 178675371
Change-Id: Ibf8b757821d9a6420ba56439e4f6a93e9e5c3d91
|
|
Test: TAP
PiperOrigin-RevId: 178650781
Change-Id: I299907ac43d48b984b092433c9b651aadb17c62a
|
|
Enabled PhoneLookupHistoryRecorder.
Bug: 34672501
Test: manual
PiperOrigin-RevId: 178030404
Change-Id: I4626262ebed14a9478f5ac8fc89fc81655e98b70
|
|
There is the case that onDisconnect() is not called but InCallService is unbind. Currently we only hide bubble when call disconnected. We should also do it when InCallService is unbind.
Test: NewReturnToCallControllerTest, ReturnToCallControllerTest
PiperOrigin-RevId: 178029862
Change-Id: I6806c5c80adb06317f09019bdf3420b462225945
|
|
PhoneLookupHistory provider isn't correct overridden in GoogleDialer manifest. I'l fix that in a later CL.
Test: manual
PiperOrigin-RevId: 177988816
Change-Id: I42af03d22db50bd70219d52826294529462bae43
|
|
Including:
- expanded view expands/collapses from top of itself
- small icon on avatar shows on left side when bubble is on right side
- when expand on bottom, bubble move up a bit so that expanded view doesn't go off screen. It also go back to previous position when collapse.
- remove animation for collapse when move expanded bubble
This change should not enable bubble v2 for anyone.
Bug: 67605985
Test: manual
PiperOrigin-RevId: 177974562
Change-Id: Id83f3f744b717d51fbe58e58769ac2cd2810d2b5
|
|
When a call is added in InCallUi, it fetches the current PhoneLookupInfo for the call and writes it to PhoneLookupHistory.
Required updating PhoneLookupHistoryContentProvider#update to use "replace" to (presumably) atomically insert when a row is missing.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 177896892
Change-Id: I43f9ded240a81156722be816a9635d586de642a1
|
|
Test: none
PiperOrigin-RevId: 177490090
Change-Id: Ide2ea08f89b8a8072913617e6ce4587abffc7df4
|
|
Bug: 69960961
Test: manual
PiperOrigin-RevId: 177486235
Change-Id: I241867456830e0a8479ed0652aac71abc77c86e3
|
|
Copybara is fixed for AOSP export
Bug: 68665330
Test: rollback
PiperOrigin-RevId: 177480870
Change-Id: I0ba38e213bb840436fa6dafc4af0a79019ee93f4
|
|
"This phone's number: xxx" is shown for emergency call which replaces in call
timer. This change move it to under emergency location service so timer could
be shown again.
Bug: 69810801
Test: manual
PiperOrigin-RevId: 177363955
Change-Id: I543fbbee869923800ffd92a5799819b712f0b953
|
|
Calling the VM other number is to complicated for this release.
Bug: 69803593
Test: CallButtonPresenterTest
PiperOrigin-RevId: 177193486
Change-Id: I4149abe1d6eea48bb5399e12b9ce43a8e1ef4b37
|
|
This change is the refactoring on DtmfKeyListener and adding
tests. The class is an overridden version of DialerKeyListener, but it also
supports direct onKeyDown and onKeyUp hooks from the DialpadFragment. There was
a lot of duplicated code between these hooks and the overridden methods so the
code was refactored to share more logic. The interesting part of this change is
using EMPTY_SPANNABLE to call into super type methods instead of having to copy
the implementation.
This change may also help with OutOfMemoryExceptions because the DtmfKeyListener
is promoted from a non-static inner class to a top level class. It no longer
maintains an implicit reference to the DialpadFragment, holding onto the
DialpadPresenter instead.
To support testing this code, the ShadowCall had to be updated since it didn't
support checking when a Dtmf tone was playing.
Bug: 69133398
Test: DtmfKeyListenerTest, InCallActivityTest
PiperOrigin-RevId: 177092841
Change-Id: I368083c71982e14db0ad936432a3a5bdf0dde5ee
|
|
Bug: 69618691
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 177062349
Change-Id: I4bc9098d06c541b607cca293269cf3489077b6c2
|
|
Most devices are DSDS (dual SIM dual standby) which only one SIM can have active calls at a time. Telecom will ignore the phone account handle and use the current active SIM. The SIM selection dialog has no effect, and the change SIM button will just redial with the same SIM.
Bug: 69417430
Test: CallingAccountSelectorTest, CallButtonPresenterTest
PiperOrigin-RevId: 176718021
Change-Id: I231cfeaa5ff77c29cdaf8e0865d096c85cfb7fc4
|
|
Including:
- Use exit-to-app icon instead of fullscreen icon for back-to-call button
- Use ripple for first button since it needs top-rounded background
- Change red hang-up button color and grey icon and text color
- Change some dimensions
Bug: 67605985
Test: manual
PiperOrigin-RevId: 176678427
Change-Id: I3f7836d832f7130f82d7f3764fb392807f3fab9a
|
|
Test: No impact on existing functionalities
PiperOrigin-RevId: 176562444
Change-Id: I209379dde3e920a27d6e735c8494647154e40e5a
|
|
Bug: 69272096
Test: None
PiperOrigin-RevId: 176443652
Change-Id: I90da4789deb4b6337a38cfe010b8aee5090d35e0
|
|
Bug: 64216442,64214592,64213352
Test: N/A
PiperOrigin-RevId: 176424724
Change-Id: I1709156098a14ac3bd35d98b913e7b881fcd9b2b
|
|
When a user types a phone number into the search bar, there isn't an intuitive
way for them to place a call when the number doesn't match any existing
contacts in the new search UI. This change adds the option to place a voice
call from regular search, like the old UI.
Bug: 69385190
Test: NSFT
PiperOrigin-RevId: 176189153
Change-Id: I6c1561bcce104c56855d996570a79b34da7230ff
|
|
01. handleDialerKeyDown(int, KeyEvent),
02. onBackPressed(boolean),
03. onDestroy(),
04. onKeyDown(int, KeyEvent),
05. onKeyUp(int, KeyEvent),
06. onPause(),
07. onSaveInstanceState(Bundle),
08. onStart(),
09. onStop(),
10. updateNavigationBar(boolean), and
11. updateTaskDescription().
Note that InCallActivityCommon#handleDialerKeyDown(int, KeyEvent) is merged into InCallActivity#onKeyDown(int, KeyEvent).
This is part of the effort to delete InCallActivityCommon.
Bug: 69272096
Test: None
PiperOrigin-RevId: 176161247
Change-Id: I6e74c7feec5414fb4bc58814eef3bd297d6eb96f
|
|
CheckableLabledButton will no longer set icon if the icon has not changed, so the animation will not be interrupted.
Bug: 64215256
Test: N/A
PiperOrigin-RevId: 176047325
Change-Id: I8cb0c6e706b931406e78c91821f75e266e453ceb
|
|
1. maybeShowErrorDialogOnDisconnect(DisconnectMessage),
2. onDialogDismissed(),
3. showErrorDialog(Dialog, CharSequence),
4. showInternationalCallOnWifiDialog(DialerCall),
5. showWifiFailedDialog(DialerCall), and
6. showWifiToLteHandoverToast(DialerCall).
Renaming in InCallActivity:
1. "maybeShowErrorDialogOnDisconnect" -> "showDialogOrToastForDisconnectedCall",
2. "onHandoverToWifiFailed" -> "showDialogOrToastForWifiHandoverFailure",
3. "onInternationalCallOnWifi" -> "showDialogForInternationalCallOnWifi", and
4. "onWiFiToLteHandover" -> "showToastForWiFiToLteHandover".
This is part of the effort to delete InCallActivityCommon.
Bug: 69272096
Test: None
PiperOrigin-RevId: 175991784
Change-Id: I0b31bd93437e633d2f77b09982e0c7fc94ad8a32
|
|
It also fixes NPE when mContext is null in InCallPresenter.onUiShowing().
Test: InCallPresenterTest
PiperOrigin-RevId: 175898339
Change-Id: Id4aad7e15310663b9f561e5bdc56be5106e24ca8
|
|
1. enableInCallOrientationEventListener(boolean)
2. isDialpadVisible()
3. getDialpadFragment()
This is part of the effort to delete InCallActivityCommon.
Bug: 69272096
Test: None
PiperOrigin-RevId: 175898158
Change-Id: Ib0f58dbe35d528a475268a86b2af4119e7cfa381
|
|
END_PUBLIC
BEGIN_PUBLIC
Automated rollback of changelist 169615685
Test: rollback
PiperOrigin-RevId: 175863544
Change-Id: I8785da90afed236cbe897efe774263765f188b14
|
|
This is part of the effort to delete InCallActivityCommon. Related instance variables remain in InCallActivityCommon for now as they are used in several other places. Temporary getters/setters are added in InCallActivityCommon so that InCallActivity has access to these instance variables.
Bug: 69272096
Test: None
PiperOrigin-RevId: 175853702
Change-Id: Iaeb96c8ad7acb628393dd5c775ad7f3b40940a2b
|
|
END_PUBLIC
BEGIN_PUBLIC
Automated rollback of changelist 169756942
Test: rollback
PiperOrigin-RevId: 175849764
Change-Id: I3be3899682db84521fd933a5f058d5518ecb1fa1
|
|
This is part of the effort to delete InCallActivityCommon. There are 25 references to InCallActivityCommon in InCallActivity and we will remove them one at a time.
Bug: 69272096
Test: None
PiperOrigin-RevId: 175718978
Change-Id: I0713bd28c2d34791045be2bb851003000b88abca
|
|
Bug: 38453773
Test: InCallActivityTest
PiperOrigin-RevId: 175230358
Change-Id: I2460308e1af554e2198c256fb1f4c62d2b8124b2
|
|
Including:
- change action icon color
- hide TextView for name if name is empty
- if name is empty, use number to generate avatar
- don't show number type
Bug: 67053842
Test: manual
PiperOrigin-RevId: 175188810
Change-Id: I4ba40e5332d7b8567932360d36c8dc6ec3d604a5
|
|
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction.
Bug: 64216442
Test: manual
PiperOrigin-RevId: 174924323
Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
|
|
Test: In dialer lab.
PiperOrigin-RevId: 174781953
Change-Id: I987c0d191a7c5613debb857bab9438d0c1aa20a7
|
|
Author: Ravi Paluri <rpaluri@codeaurora.org>
Bug: 68677786
Test: CallButtonPresenterTest
PiperOrigin-RevId: 174740252
Change-Id: If20e9fb92c4d729a75edf8ac6d088a88d4d319d8
|
|
Public-Origin-Change-Id: If22474d96ee53ce4f7c31fac828fb56022f4fa49
Signed-off-by: Allen Calderwood <calderwoodra@google.com>
Author: Kitta Koutarou <koutarou.x.kitta@sonymobile.com>
Bug: 62440523
Test: manual
PiperOrigin-RevId: 174532793
Change-Id: I436307d42f42387c3d37eb79c99ef9200703d57f
|
|
We show OnHoldFragment for new conference call, and remove it after updating info. After cl/172475223, the update only happens once and sometimes removing the fragment happens before adding the fragment. Committing synchronously fix the bug.
Test: manual
PiperOrigin-RevId: 174374676
Change-Id: I5337f6592ca2924ed6a089ecaefe00d920f85738
|
|
Including:
- merge end call button with other buttons
- add ripple effect for buttons
- adjust elevation according to material design guide
- add triangle in expanded view
Bug: 67605985
Test: manual
PiperOrigin-RevId: 174253861
Change-Id: I7b5315245a322235efb39a9cda26b8686cc7bbf9
|
|
Ringtone should be stopped if user uses the "respond via message"
option because user already notices the incoming call and user
just feels the ringtone is noisy.
Author: Takeshi Tanigawa <takeshi.tanigawa@sonymobile.com>
Bug: 63089671
Test: AnswerFragmentTest
PiperOrigin-RevId: 174249368
Change-Id: I2c6353cd662f23c20ac3ce873c38f18e8378b0a9
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174197504
Change-Id: Ide61f65a9dc1c104fa5bf136143c34e193c21396
|
|
Bug: 67605985
Test: NewBubbleIntegrationTest, NewReturnToCallControllerTest
PiperOrigin-RevId: 174089572
Change-Id: Icaeb41482cffe522e09ee1ec068b5d47f476b146
|
|
Refresh heads up notification to show only accept and reject options when
incoming Video call is handed over to CS.
Author: Suresh Koleti <skolet@codeaurora.org>
Bug: 63157046
Test: StatusBarNotifierTest
PiperOrigin-RevId: 174077146
Change-Id: Ic74d5a201392c6764ee33f1512bf528f86b80f69
|
|
Test: Run in dialer lab
PiperOrigin-RevId: 174075702
Change-Id: Ib663dc34d2c0c9e737c6d5f13b16d2b42b714127
|
|
We now use dagger everywhere for consistency and explicitness.
Test: tap
PiperOrigin-RevId: 174071122
Change-Id: I15d2f8261a7b753353be9e7d3b80692aa0c1b64d
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174055180
Change-Id: Iac6deb8f9dcb6f3e9da6dfd0d732f29cc34bb7f6
|
|
Test: none
PiperOrigin-RevId: 174042820
Change-Id: Ia09f55d9f38b9335b23234cfe399987a3f3a65b1
|
|
The bug is caused by old StatusBarNotifier object cancelling new notification. Remove listener for InCallPresenter is safer than for StatusBarNotifer.
Test: manual
PiperOrigin-RevId: 173734079
Change-Id: Iefdc2d0e399da97bf31dbd5f99beb9ed34bcd874
|
|
This CL accepts this AOSP CL: ag/64881150
Author: Ravi Paluri <rpaluri@codeaurora.org>
Bug: 64881150
Test: manual, ImsVideoTechTest
PiperOrigin-RevId: 173734014
Change-Id: Ibccc610c85c4bd06f34fc6bb057c356dd74f362d
|
|
Add hold button for all phone types and rely on SUPPORT_HOLD capability to show it.
The issue is that if GSM call is made on devices with CDMA + GSM sim, the default phone type is CDMA so the hold button is not available. This change is a workaround that adding hold button to CDMA button chooser so button choose of all phone type has hold button available and it's totally controlled by telecom's CAPABILITY_SUPPORT_HOLD and CAPABILITY_HOLD. It shouldn't affect CDMA call.
Idealy we should use correct phone type but unfortunately it's not well supported on pre-O device.
This is upstream change from
https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/482377/
Bug: 63911282
Test: ButtonChooserIntegrationTest
PiperOrigin-RevId: 173614690
Change-Id: I6e17c1cc69ad50b1ba4c9b09804d5a7b5eeaf496
|
|
DialerUtils#getDefaultSharedPreferenceForDeviceProtectedStorageContext(Context) to StorageComponent.
Bug: 30224215
Test: none
PiperOrigin-RevId: 173612463
Change-Id: Ia89d5d85c31ea2114b196393ae43b803023fc9bf
|
|
This change also add a handy adb command script run before UI integration test.
Bug: 67429956
Test: IncallActivityTest
PiperOrigin-RevId: 173565382
Change-Id: I9b8b957f00a0b7d11dbb7f40e8c9f1dbdb8c3928
|
|
Migrate the existing app latency test to a new solution from Project Fi team.
The main change on this new solution is that the data collection part is done by Primes now.
Also, a few changes has been made on DialerPrimes class and a new Dialer variant dialer_release_test has been created.
The benefits of using primes to collect data are:
1. latency tests dont need to insert lines of code to track latency in dialer codebase
2. be able to collect data on any variants with or without Proguard
3. latency tests now only contain ui interaction to trigger scenarios on which we want add measurements
4. share the same logic with primes on production so that data from testbeds and normal users are comparable.
5. easier for anyone to add interesting data entries.
----------Mobile Harness Below-----------------------------------
RELNOTES[INC]:Add entries for dialer to use mobileharness plugin.
Test: No
PiperOrigin-RevId: 173481741
Change-Id: Ia6812794141382898bea4b34bca90278c5663464
|
|
The locked phone icon will be shown for voice privacy call on CDMA for non-hold status(dialing, ongoing etc.)
The onhold icon is same as usual.
This change also update on hold icon to quantum vector drawable resources.
WANT_LGTM=all
Bug: 37529280
Test: StatusBarNotifierTest
PiperOrigin-RevId: 173451922
Change-Id: I71d4c03b6953ca72def339c9c0a77bacbaf145f8
|
|
Bug: 68143529
Test: none
PiperOrigin-RevId: 173439449
Change-Id: I80ebb4e8b17551144e492424e7aa6d92f26cc576
|
|
We were not using the VideoTech interface for these calls and as a result could
not restore the camera when swapping calls.
Bug: 68160072
Test: manual
PiperOrigin-RevId: 173437432
Change-Id: Iec1d363178e2332014f95246637c23f9040cdfee
|
|
By always creating executor services via dagger, we can now bind special versions during espresso tests that can implement idling resources. We should be using idling resources during espresso tests for threads that we create ourselves, because espresso does not know about them.
Hopefully this reduces some of the flakiness of espresso tests that we have today.
This required converting all existing calls to DialerExecutors to pass a context used to fetch the component, and also required creating new application classes for espresso tests.
Test: temporarily added a task which just slept to DialtactsActivity and verified that its integration test failed due to idling resource timeout
PiperOrigin-RevId: 173334773
Change-Id: I876a93022d235d62cfc377bf5b06687e21a34758
|
|
It fixes AOSP for package name conflict.
Test: manual
PiperOrigin-RevId: 173298696
Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
|
|
In InCallServiceImpl.tearDown(), we should only clear inCallService after
InCallPresenter.tearDown() where we remove all notification.
Also remove null
assertion in stopForegroundNotification() since other crash should only happens
when there is no notification.
Test: StatusBarNotifierTest
PiperOrigin-RevId: 172657924
Change-Id: I86e720b80f885aa93f12215fda899ee62eeaba5b
|
|
When determining whether two phone numbers are identical enough for caller ID purposes, the Contacts Provider ignores special dialable characters such as '#', '*', '+', etc. This makes it possible for the cursor returned by the Contacts Provider to have multiple rows even when the URI asks for a specific number.
For example, suppose the user has two contacts whose numbers are "#123" and "123", respectively. When the URI asks for number "123", both numbers will be returned. Therefore, the following strategy is employed to find a match.
If the cursor points to a global phone number (i.e., a number that can be accepted by PhoneNumberUtils#isGlobalPhoneNumber(String)) and the lookup number in the URI is a PARTIAL match, the cursor is a match.
If the cursor points to a number that is not a global phone number, the cursor is a match iff the lookup number in the URI is an EXACT match.
There is no matched cursor in all other circumstances.
UI demo:
Suppose the user has a contact named "Service1" with number "#123".
Before:
Incall UI after the user dials "123": https://photos.app.goo.gl/xFWCD4qy2VR3YEuJ2
Call log UI after the call ends: https://photos.app.goo.gl/FT28GdTBy1dtANtI2
After:
Incall UI after the user dials "123": https://photos.app.goo.gl/Io3BisQmsyfnvitV2
Call log UI after the call ends: https://photos.app.goo.gl/6GgRrmx75yUTga3B3
Bug: 30225112
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 172505648
Change-Id: Ida554313455ff9ce40432897681f89f58d64af04
|
|
1. Only update secondary info when it's changed.
2. Removed redundant call to update notification on activity start (b/36649622)
3. Use same call back for notification update from contact info query to avoid duplicated call backs.
The actual latency reduction is insignificant (<10%).
Bug: 36649622,64542087
Test: manual
PiperOrigin-RevId: 172475223
Change-Id: I1c91cb5715287991de774a1d9b95e4c8b722d28f
|
|
In previous change, we use AudioRouteSelectorDialogFragment.onCancel() instead of onDismiss(). And selecting an item only calls onDismiss() instead of onCancel(), so the activity is not finished.
In this change we finish the activity when an item is selected.
Test: manual
PiperOrigin-RevId: 172342660
Change-Id: I2d34874ae9e1a7e5ad858b4f1ba855b48647d995
|
|
Now that our Duo integration is public, we no longer need a code name.
To avoid any disruption, logging and config related names were not changed.
Bug: 63753964
Test: manual, existing tests
PiperOrigin-RevId: 172172738
Change-Id: Ib9d3d80761944d850c8c4886def9fef9a28539a4
|
|
Test: existing tests, manual (tested on Nexus 6 running M)
PiperOrigin-RevId: 172122858
Change-Id: Ib22e33de3ed134cf76a06af54d054dbb92f91039
|
|
There are many binder call triggered by IPC on main thread. This change will try to reduce them by caching thing that's bound to a call. It reduce total binder transaction from 1002 to 664 and saves ~11% latency of incoming call on locked screen.
1. Cache isVoiceMailNumber in DialerCall
2. Cache call capable accounts in DialerCall
3. Cache current country iso in DialerCall
4. Don't set orientation change if it's not changed.
This change also add lots of trace info. It won't affect release build though since they are stripped out by proguard.
Bug: 64542087
Test: manual
PiperOrigin-RevId: 171901266
Change-Id: Iec48f030529aa59974212147276f6d0ae121872a
|
|
Author: tomoyuki.nishikawa@sony.com
This change was inspired by http://aosp/508735
Even though VideoProfile.isVideo(getVideoState() returns true when starting a video call, ImsVideoTech is not ready until call.getVideoCall() returns not null (see https://android.googlesource.com/platform/packages/apps/Dialer/+/master/java/com/android/incallui/videotech/ims/ImsVideoTech.java#66)
During the time between VideoProfile.isVideo(getVideoState() being true but call.getVideoCall() returning null, we are incorrectly showing the phone call UI instead of the video call UI. To fix this, we need to trust the VideoProfile check in addition to the VideoTech check.
We still need to check VideoTech for other video options aside from just IMS VT.
Bug: 67712159
Test: manual
PiperOrigin-RevId: 171892356
Change-Id: Ibe1f9de60aaa4adc971401bee0277961cfe037e4
|
|
* Remove old language icon from bottom row.
Screenshot=In change as scuba test
Bug: 64205446
Test: new unit tests
PiperOrigin-RevId: 171858076
Change-Id: Idf781be193dae3593f778af1ac833f046abd87e3
|
|
When the call is still ringing, a new button is added to allow to user to call with the other SIM. A background worker will be created to hang up the phone and redial with the other SIM. The in call UI will be prevented from ending during the process.
Video: https://drive.google.com/a/google.com/file/d/0B2eYBUUznfyTSl9MdXQ0V1ZzQkE/view?usp=sharing
UX has not been finalized, the icon and position are just placeholder.
Bug: 64215256
Test: SwapSimWorkerTest
PiperOrigin-RevId: 171715715
Change-Id: Idb3f486e9fc9a45d4c5e244af2d7d91b075bf0f2
|
|
Test: StatusBarNotifierTest
PiperOrigin-RevId: 171588023
Change-Id: I05e176ef1032da00c4b75a83e92f39e8293d598e
|
|
Tracking bug to fix the refactoring: http://b/67512378
Bug: 67470678
Test: manual
PiperOrigin-RevId: 171553078
Change-Id: Ib83e4240d6024347f97d246f9b526c3ccbf02057
|
|
When any locks are acquired, the InCallActivity will not auto-finish when there are no active calls. The disconnected cause and reject with SMS dialogs are migrated to use this API, which prevents the activity form ending before the user has finished interacting with the dialogs.
Bug: 64215256
Test: InCallPresenterTest
PiperOrigin-RevId: 171362338
Change-Id: Ied07ebbf6bee056ea6b2314c57f3324561b1651a
|
|
Do the following when a participant is on hold:
- Add "On hold • " in front of the number
- Gray out avatar and text (contact name & number)
Notice:
We only have the on hold state information for VoLTE conference call and IMS conference call. So the change only works for them (not for GSM/CDMA conference call).
Test: ConferenceManagerPresenterTest
PiperOrigin-RevId: 171345423
Change-Id: Ie5fe2fc1097f4858604283989dcb916c2ac21972
|