Age | Commit message (Collapse) | Author |
|
Bug: 74022483
Test: InCallPresenterTest
PiperOrigin-RevId: 194877539
Change-Id: If140d716a8019738e145c24cbaab3c03827662cb
|
|
Bug: 74022483
Test: manual
PiperOrigin-RevId: 194864239
Change-Id: I89a186faa1831634bbaecbe30c83bded4b321c06
|
|
Thre is no point to save an empty transcript.
This change will also prevent showing transcript button in call details.
Bug: 70177426
Test: manual
PiperOrigin-RevId: 194863630
Change-Id: Iee4e5c0929c3ebfc75377ed0f529934a6cfe01f5
|
|
When dual SIM selection support is added to In Call UI it was a rush order and codes are duplicated. This CL moves the duplicated logic into PreferredAccountWorker so the same dialog can be shown for both.
TEST=manual
Bug: 69675796,72618783
Test: manual
PiperOrigin-RevId: 194845320
Change-Id: Id283ca7616580b0efd4e8f02e63691c70ee7f93c
|
|
Test: manual
PiperOrigin-RevId: 194828525
Change-Id: Ib9f1faece83525c00feadf32b43a6901d54ea76e
|
|
UiListener nulls out the callbacks onDetach(), which is after onSaveInstanceState().
TEST=N/A InCallActivity is not testable.
Bug: 78517857
Test: N/A InCallActivity is not testable.
PiperOrigin-RevId: 194824783
Change-Id: I2c4f41cf58a498a841f69ef078e58d07ec5b3c5a
|
|
Bug: 74022483
Test: manual
PiperOrigin-RevId: 194822680
Change-Id: I4df144b21a0fc32e39eb970fadc24ef7eb6e7199
|
|
If the call disconnects when RTT UI is in background, any messages received from remote should be saved to transcript. RttCallPrensenter might not be available at this point, so the job is done inside DialerCall#onRemovedFromCallList
Bug: 78576798
Test: presubmit
PiperOrigin-RevId: 194821868
Change-Id: I10381b1c292f918763360c7a4bcd0470250f2293
|
|
Bug: 78519871
Test: none
PiperOrigin-RevId: 194814100
Change-Id: Iaaa1b250ca8242f459e89043915db1328ae50f49
|
|
Bug: 74022483
Test: manual
PiperOrigin-RevId: 194600612
Change-Id: Idc15d873abfcb47a799e43468ffdd0fe1d90cc5c
|
|
This refactoring will remove dependency on incall/call package for those classes only dependent on DialerCall.State.
The benefit is to remove unnecessary dependency and avoid potential loop dependency in the future.
Test: presubmit
PiperOrigin-RevId: 194594382
Change-Id: I6b3241bcf10a0a15c495c3c90a13f174c32e3f72
|
|
Bug: 74022483,74238896
Test: InCallPresenterTest, AudioRouteSelectorDialogFragmentTest
PiperOrigin-RevId: 194589147
Change-Id: If8c6e79838d27b1ca33ed677c19f6555cbdb4494
|
|
Test: manual
PiperOrigin-RevId: 194561401
Change-Id: Ia94765a3979b5f3c3e4d02c1dc235f5e41fbf6f9
|
|
Bug: 70989584
Test: CequintPhoneLookupTest
PiperOrigin-RevId: 194493484
Change-Id: I59f9b334f0a218e7ba1c34948db4ddbf11490df3
|
|
notification.
Test: N/A
PiperOrigin-RevId: 194465415
Change-Id: Ica9301f4315b549c343112a824c8f7c51213bb99
|
|
This change also increase the button size for easier clicking.
Bug: 76207637
Test: manual
PiperOrigin-RevId: 194440220
Change-Id: I1d5742876e4a9ce27b81182e2abd5d2a27c71790
|
|
Bug: 78519871
Test: RttChatFragmentTest.java
PiperOrigin-RevId: 194421459
Change-Id: I4d04ee3045afdd4d5553032d7434ead280810543
|
|
This is caused by transcript set to non-null again in some cases.
Test: manual
PiperOrigin-RevId: 194303928
Change-Id: Ife5e6bad3874751efab1d94a4262d83017b79808
|
|
Bug: 74022483
Test: InCallPresenterTest
PiperOrigin-RevId: 194275941
Change-Id: If5a40a9778e3c0f5a05c7e33f365cb609bf6e74a
|
|
1. Hide input box when RTT call is not connected
2. Auto show keyboard when RTT call is connected
Bug: 70177426,76209308
Test: manual
PiperOrigin-RevId: 194273134
Change-Id: I36916560910e5bd47c291c8d3864db3948304db0
|
|
Before this CL it is ran on a non-UI task, where the callback might happen after the activity has already ended.
TEST=manual
Bug: 78517857
Test: manual
PiperOrigin-RevId: 194169377
Change-Id: I0011019cb31b0b2c01c9d774776fb44dcac4d8c6
|
|
Bug: 70989584
Test: None
PiperOrigin-RevId: 194161852
Change-Id: I35e0748ab634a84f6b6a19b790bfc55090026a35
|
|
This CL also unifies the disabled color for primary and secondary text.
The in call UI dialog will be implemented in a followup CL.
TEST=TAP
DEFAULT_VALUE_OK=no server.
Bug: 69675796,72618783
Test: TAP
PiperOrigin-RevId: 194147061
Change-Id: I5be5a45a7df09061a3bf391f6ae2a32d9c73b6e3
|
|
This is used to inform the user an account cannot be used right now. On most dual SIM devices, only a single SIM can make calls at the same time. The UI will be implemented in a followup CL.
This CL also packs the parameters of SelectPhoneAccountDialogFragment into a proto. There are too many arguments and it needs structured representation.
TEST=TAP
Bug: 69675796,72618783
Test: TAP
PiperOrigin-RevId: 194139636
Change-Id: I7d9f92c73b650654fff28ba625a2c8e3dfa0b96c
|
|
Bug: 78243122
Test: none
PiperOrigin-RevId: 194128823
Change-Id: Ic886fd9c2236bbac4cbc884b7d777cea20451f0b
|
|
Bug: 74022483
Test: InCallPresenterTest
PiperOrigin-RevId: 194125192
Change-Id: Ie7c50554079fe3a0a23b18ac44fc81b913c3e619
|
|
Dual SIM features need to know what phone account the current call is using because usually only one SIM can be in a call at the same time.
TEST=TAP
Bug: 69675796,72618783
Test: TAP
PiperOrigin-RevId: 194121273
Change-Id: I512eb7aca2050f38449b0a911dea9cee9b5ffdb5
|
|
Bug: 78243122
Test: CallListTest
PiperOrigin-RevId: 194111299
Change-Id: I8cb3a0266b6796321e83a2a703630a745879be97
|
|
TEST=TAP
Bug: 73012833,73718978
Test: TAP
PiperOrigin-RevId: 194110263
Change-Id: I54dbbaada89e4974030e0b3a397040d4d686bcae
|
|
notification.
Bug: 76436793
Test: SpamNotificationServiceTest
PiperOrigin-RevId: 194006876
Change-Id: I7325599cc5581200f124a8fb64a8f4938675c734
|
|
Bug: 74022483
Test: InCallPresenterTest
PiperOrigin-RevId: 193975862
Change-Id: I7b5bdbd986b3f4a543e1591d06a0829b7fe72e6a
|
|
Bug: 70988915
Test: CompositePhoneLookupTest, PhoneLookupTest
PiperOrigin-RevId: 193592973
Change-Id: I27b6a63049117ce6d31e50aea9c56c14f01d0e1d
|
|
Test: manual
PiperOrigin-RevId: 193581061
Change-Id: Ia28f86c82f94ecd68623cfaa9c401073579358e5
|
|
Bug: 70177426
Test: RttTranscriptUtilTest
PiperOrigin-RevId: 193549902
Change-Id: Icb10e44edf32ef7913783628b38861465d0f6c93
|
|
Test: BluetoothDeviceProviderTest
PiperOrigin-RevId: 193401073
Change-Id: I3483392d1d7a473a753477074b5c377af257186e
|
|
notification
Test: N/A
PiperOrigin-RevId: 193290689
Change-Id: Idff99e2f67d5161d09b7ea3c0818ed92d2286b61
|
|
Use ShortNumberInfo to identify shortcodes and apply more basic matching for them; without this short codes like '5555' and '55555' would match due to being a SHORT_NSN_MATCH even though they should not match.
Also removed the PhoneNumberUtil argument from DialerPhoneNumberUtil's constructor as it was always PhoneNumberUtil.getInstance(). (This allowed me to do a similar thing for ShortNumberInfo.getInstance()).
TEST=unit
Bug: 71586485
Test: unit
PiperOrigin-RevId: 193288929
Change-Id: Ia16c78e7eee5e0912d3913660952b9ee32713731
|
|
Bug: 73774242
Test: unit
PiperOrigin-RevId: 193262041
Change-Id: Idc0de19cc6d58cf79715ec243108c53b9b1df848
|
|
Bug: 67596257
Test: CallDetailsCursorLoaderTest
PiperOrigin-RevId: 193259769
Change-Id: I8c6a8eb9a6bf06e9c1c25c45fc035f8db8ae5a65
|
|
Bug: 73736190,73775046
Test: none
PiperOrigin-RevId: 193239591
Change-Id: I0af371b59e57a902df8162f3f04ba8e5a7900588
|
|
Bug: 73774461,73774884,73775516,73775590,73775873
Test: unit/manual
PiperOrigin-RevId: 193236364
Change-Id: I03726ed7e5a3383f6e8632fb2cf9b948c3203f87
|
|
1. Save RTT transcript when call is destroyed
2. Show RTT transcript link when it's available
Bug: 67596257,77717594
Test: manual
PiperOrigin-RevId: 192673172
Change-Id: If541ad9137c965166548d2fb449e835b95566727
|
|
Bug: 73774461,73774884,73775516,73775590
Test: unit
PiperOrigin-RevId: 192456945
Change-Id: I0f0b44e56550939d4af16297bd305297e6c74310
|
|
Bug: 74238896
Test: ButtonControllerTest
PiperOrigin-RevId: 192370117
Change-Id: I265cc9541957c2dd376176ed7a703b4938fe4563
|
|
Bug: 77666799
Test: existing tests in InCallPresenterTest
PiperOrigin-RevId: 192191167
Change-Id: Ifa35451cf94d925f9d73397460b48754952cb216
|
|
Bug: 74022483
Test: InCallPresenterTest
PiperOrigin-RevId: 191941513
Change-Id: If2090c6dae63981a46586d785e2836edbdf8a729
|
|
This is to test how the fragment handle messages.
Test: RttChatFragmentTest
PiperOrigin-RevId: 191912866
Change-Id: Ia50688cdf8eceab376e163aa09bda56406a64933
|
|
Bug: 74022483
Test: InCallPresenterTest
PiperOrigin-RevId: 191825857
Change-Id: I9c70290da32484faf42a2a25fd6b22ba706cb63e
|
|
Bug: 73736474
Test: unit tests
PiperOrigin-RevId: 191776448
Change-Id: Idf3eaee2d6639d5a6643c9670230e88d0028bf3c
|
|
This is caused by not dismissing error dialog when recreating InCallActivity.
The dialog will be shown again after recreating.
Bug: 71376489,77152802
Test: manual
PiperOrigin-RevId: 191775030
Change-Id: I07ef5041979c0bbb2d44df9e41b55f0ac41e9339
|
|
Bug: 77486043
Test: unit tests
PiperOrigin-RevId: 191660058
Change-Id: Ia68c8b06e266950cb964a796ea338e4bbc1d6b07
|
|
Bug: 73775453,73775590
Test: unit tests
PiperOrigin-RevId: 191657758
Change-Id: If1ae5505185191f04fd57aa828ae5bcc9c21b173
|
|
This change also moved chat history to be saved in DialerCall, thus it will be persist when switching calls.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 191626079
Change-Id: I65e9c6ac7aa41beb45dfe561b0a48506ea938e6f
|
|
Bug: 70177426
Test: unit
PiperOrigin-RevId: 191612825
Change-Id: I1a72ca86fe9c74fb6420dcfa14f417a8aa6bd5d7
|
|
This should be handled by PhoneAccount.hasCapabilities(PhoneAccount.CAPABILITY_RTT)
Test: none
PiperOrigin-RevId: 191522319
Change-Id: I28244a725c63fb3b83e97fd9a585473a94da96d9
|
|
Change to use public android API of button style.
Also changed padding left and right to 16dp (up from default 8dp).
Bug: 70177426
Test: manual
PiperOrigin-RevId: 191505606
Change-Id: Ic984f95843775af3057fb15bf5fe54d3384c478d
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 191365412
Change-Id: Ida741a837d6495c0d5f51b748f4d6c09a1beafec
|
|
Bug: 70177426
Test: manual
PiperOrigin-RevId: 191348602
Change-Id: I332d53ab0c3c628b3dca0c184435bafcf2a13d02
|
|
Bug: 76227259
Test: manual
PiperOrigin-RevId: 191347301
Change-Id: I18d63f4e85ca07be00f7564a5ee256d3a6b1b480
|
|
This button has higher priority over add call button if RTT is enabled.
Bug: 67596257
Test: ButtonChooserIntegrationTest
PiperOrigin-RevId: 191129313
Change-Id: I5a3302a0970e77a933439749e0e559a691235523
|
|
Now we also show bubble in onCallListChange(), but we shouldn't show bubble after dismiss in this case.
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 191101307
Change-Id: I13ff6bf4ae7ab574966c43c0e6fee13853899ba0
|
|
Bug: 74022483
Test: manual
PiperOrigin-RevId: 191098829
Change-Id: I715a97ba48db9a3a81ef7b27750131a3a3a331b7
|
|
1. Don't close overflow menu after menu item is clicked.
2. Add correct shadow and animation to overflow menu.
3. Only scroll when remote message is updated if input box is empty.
4. Only hide keyboard if scrolling up is triggered by user.
5. Add paddingTop to recyclerView so that first message won't be covered by toolbar.
Bug: 70177426
Test: manual
PiperOrigin-RevId: 191002774
Change-Id: Ic69f80323e3d31d7853d4e8d0c6e4c100fe4a776
|
|
Bug: 75602772,77235335
Test: ImsVideoTechTest
PiperOrigin-RevId: 190988177
Change-Id: I2f4883f6bf492b380ef839562fd65ff6ac630bfb
|
|
Bug: 76221932
Test: manual
PiperOrigin-RevId: 190948113
Change-Id: I4151ab3fc5231183d49fc1bdc247a09e5ffadc22
|
|
Bug: 65490850
Test: manual
PiperOrigin-RevId: 190859631
Change-Id: I89aeb41a7709e9366367cdc54ba506e276685b5f
|
|
The call for incoming call is covered in StatusBarNotifier.onStateChange(). The two calls in InCallActivity is not useful (maybe is before notification becoming foreground).
Test: manual
PiperOrigin-RevId: 190845157
Change-Id: I0f84f15cfda5294566fa8976e09aac5163f85aa9
|
|
Test: Existing tests
PiperOrigin-RevId: 190820867
Change-Id: I4835bcbc7698075fb54015dccc6823ada4c71651
|
|
Icons in video call screen will be replaced in following change.
Bug: 76221932
Test: manual
PiperOrigin-RevId: 190534558
Change-Id: Ia8abb468c71ffa4f6322043bc3bbbbe475b20a1f
|
|
Test: Existing tests
PiperOrigin-RevId: 190516504
Change-Id: I5fa9e123b45beb9728257ecd160a348fb3f4732c
|
|
up to N.
Test: Existing tests
PiperOrigin-RevId: 190508397
Change-Id: Ia5f33e45af1d1cc666fec5f43efa564b2b68c193
|
|
setting interface.
Test: All the existing tests
PiperOrigin-RevId: 190314880
Change-Id: I030acbd70120f508c5a4616757d89113524110fa
|
|
Solves copy and paste error where call to setLabel and setLocation has
been mixed up. Problem was introduced in:
Ifb90019b6a5568788d51f4a55a07f7693c803eaf
Bug: 76190741
Test: Verifies that phone number is correct in callscreen when calling
contact
Cherry picked from https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/648300
Bug: 76190741
Test: N/A
PiperOrigin-RevId: 190305044
Change-Id: Ie268f02cabadc939e6a2e1f73ae4e126e314dc57
|
|
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig.
Other related changes to help accomplish this:
-Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework.
-Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest).
-The "Main" package is also on longer needed since it existed to control the shortcut.
Bug: 74821995
Test: existing
PiperOrigin-RevId: 190251418
Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
|
|
The assisted dialed string will also along show with the "calling via" label. To handle the long string, Top row is now a marquee.
Bug: 72571130
Test: Unit tests
PiperOrigin-RevId: 190156719
Change-Id: I18a13712bdc9d780f744ef65a1773d249e40fb15
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 190126654
Change-Id: I412f8fbf5b345005f9fb3651c345303d965e4e02
|
|
After this change, user will be able to delete text in previous finished bubble. It will also correctly handle deletion from remote.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 190122728
Change-Id: Ifebcbe874e5f03857d109b58e758e53f408e7e44
|
|
Manually set to M
- MissedCallNotifierTest (not sure what the issue is here...)
- CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown)
- MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory))
Ignore Tests
- a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason)
- VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear)
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190030202
Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
|
|
This CL updates the call log to show "Emergency number" for call log rows from
numbers that PhoneNumberUtils.isEmergencyNumber considers to be emergency
numbers.
Bug: 66926712
Test: Manual, see above
PiperOrigin-RevId: 189953302
Change-Id: Ibaae243ead8b918a26f6058164316e042a4f82fd
|
|
If we get no location data for emergency call, we used to show spinner forever. This change shows error after 5s with no data, but still tries to get location.
Test: LocationFragmentTest
PiperOrigin-RevId: 189946803
Change-Id: Iaa0b429eec806337b9ab9cae3ca95e737fc667bf
|
|
Bug: 73774242
Test: unit tests where they exist
PiperOrigin-RevId: 189853302
Change-Id: Ibf3431cc0d7716c2c53c7ea165dfc130102a1bc7
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Other usages already has the null check.
Bug: 75598828
Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause.
PiperOrigin-RevId: 189644833
Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
|
|
Also change "done" button to "send" in input box and disallow multiple line since return will be interpreted as "send".
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189409725
Change-Id: I3d3bf3e11cd04d6689125399f4567e88ee3f28f0
|
|
Previously it is unclear what the "county ISO" should be so the originating county of the SIM is used. When telecom writes to the call log the county the user is in is used. This caused the DialerPhoneNumber key in in call UI and call log to differ and info to be lost.
In this CL, the current country is used in PhoneLookupHistoryRecorder to make it consistent with the call log.
PhoneLookupHistoryRecorder is currently the only consumer for telecom call util.getCountryCode().
Additionally, dialer/location no longer depends on dialer/util. dialer/util has too many unnecessary dependencies that will cause cycles.
Bug: 73752730
Test: Unit tests
PiperOrigin-RevId: 189378542
Change-Id: I59773f7745c835a6523efda951c475e2fde9aaf9
|
|
Bug: 73741286
Test: none
PiperOrigin-RevId: 189377028
Change-Id: Ifb9c6375d0026fb012ae868741b471f2ca02c5f9
|
|
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 189225436
Change-Id: I845855d0b66941e311f3db239d10249015473c65
|
|
This happens when outgoing video call is accepted as voice call or switching
between video call and voice call.
Bug: 71590134
Test: manual
PiperOrigin-RevId: 189206585
Change-Id: I564c261614990b9b6baab6025f1625f42058ba70
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189204691
Change-Id: I9ecd36ce1c27072dea4ae87beeecd4565bf05378
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189064976
Change-Id: I3265881114baceb4d63fcc3d55d1c904cd3216dc
|
|
Incall and answer screen is using transparent status and navigation bar, while RTT screen is using customized color. Switch between them require correct setting of system UI.
Bug: 67596257
Test: manually test to make RTT call and voice call, then switch between them.
PiperOrigin-RevId: 188956868
Change-Id: I3c17ff453be943f0b2ad28fe5cae434453fbe326
|
|
The metadata belongs with the voicemail settings menu, which is moved into dialer a while ago. Not moving the metadata causes build variants without VVM to have duplicated voicemail settings in telephony and dialer.
Also removed the redundant metadata in incall ui manifest.
Bug: 73096806
Test: manual
PiperOrigin-RevId: 188756468
Change-Id: I00174f84024c5b9ab809d99e40a55d22a07bd063
|
|
Test: BubbleImplTest, BubbleImplIntegrationTest, ReturnToCallControllerTest, ReturnToCallActionReceiverTest, BottomActionViewControllerTest, ChangeOnScreenBoundsTest
PiperOrigin-RevId: 188558386
Change-Id: Ieab3ee3f148092312a50597b41c0975419756e23
|
|
This is to prevent dialpad showing with keyboard open.
The alternative way to dismiss keyboard after dialpad shows up doesn't work.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188556453
Change-Id: I4b917d8ac83246d2002641ae7759261699149c65
|
|
Thus putting call into background won't lose the history.
This is only stored in memory by making RttChatMessage Parcelable and saved
along with fragment's life cycle.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188500104
Change-Id: I11e8e55f0475defd9c3b9a8cc10db4186392ddd8
|
|
This change also dismiss overflow menu when any button is clicked inside it.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188424236
Change-Id: I90b803d592f12525cdb8727aaeebc45c3da5dcdd
|
|
We used to only show bubble when leaving in-call UI, so answering from Bluetooth does not show bubble. Fix it by also showing bubble in onCallListChanged().
Test: NewReturnToCallControllerTest
PiperOrigin-RevId: 188403460
Change-Id: I5e6a3c37b2773e426dcc73ae5661b9e145b20cb8
|
|
Instead of using things provided by Android of onTextChanged, we compare the
text in EditText with the text in bubble before the change and compute the
delta string need to send to remote party. This way we could minimize
characters sent thus reduce latency.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 188389325
Change-Id: I3023b484c32b2369ca8720104da74cf6906bb46e
|
|
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 188373256
Change-Id: I0f0798a5310225456619757dcca5bbd5df372b91
|
|
Bug: 70989547
Test: ShowBlockReportSpamDialogNotifierEndToEndTest
PiperOrigin-RevId: 188351591
Change-Id: I634fb821592bdc890df291fdf83cdf307c94ffa9
|
|
Bug: 73994020
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 188260007
Change-Id: I23025e9b9454f487117c35e7a3b09307371ae825
|