Age | Commit message (Collapse) | Author |
|
Set EVENT_MERGE_START for foregroundConnection and backgroundConnection
but don't set EVENT_MERGE_COMPLETE when there is ImsException
Bug: 121105030
Change-Id: Ib376b24e5d307d8907d7ec2c8a3e025c04682d88
|
|
Change-Id: Ia30a3c46e9c37d7d73288ec605af8efc3a46a323
|
|
[Issue/Cause of defect]
If partner device is rotated during video screen of target device is in
background, and then resumes to foreground, partner image will be shown
with incorrect dimensions.
Because when video screen goes to background, VideoCallPresenter stops
checking CVO(Coordination of Video Orientation) of partner device. And
when video screen is resumed to foreground, there is no logic to update
partner image with latest peer dimensions.
[How to fix]
Even if video screen is in background, CVO(peer dimensions) is notified
to DialerCall. Therefore DialerCall should store the dimensions. And
when video screen resumes to fore, VideoCallPresenter should update the
screen with correct(latest) peer dimensions.
Test: manual - Checked that the partner image is shown with correct
dimensions.
Bug: 111575038
Change-Id: I32ff5407f1222b232b47a35e7083a473be67b468
|
|
Test: Existing tests
PiperOrigin-RevId: 202589482
Change-Id: I6982e4069d30032bf46caf3c9984dfc0e7196f6f
|
|
Bug: 110177989
Test: manual
PiperOrigin-RevId: 202337281
Change-Id: I277fcbc77ad50c4ed04f92d0541b67043bc8bef8
|
|
Test: manual
PiperOrigin-RevId: 201390999
Change-Id: Ifa4b124d0d94d97f2aa1d3675130c7eef1f289c1
|
|
Bug: 110177989
Test: none/manual
PiperOrigin-RevId: 200771224
Change-Id: I6c9d9b6eb0aa98be8e60d693549c07fbbf73c5d7
|
|
Bug: 109763648
Test: manual
PiperOrigin-RevId: 200460856
Change-Id: I1ce385490e6ce6167f56dc32c35a931292e0d03f
|
|
It no longer provides any value, so just use dagger directly.
Bug: 80441695
Test: tap
PiperOrigin-RevId: 198806461
Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
|
|
Bug: 79522243
Test: manual
PiperOrigin-RevId: 198598685
Change-Id: I05144ec734827b29e89bbba5070c9cb0ab06c215
|
|
- README on how to properly theme Dialer going forward.
- Migrated all widgets to use global colors.
- Removed all activity and application themes where it wasn't necessary.
- Added themeing test rule for Espresso tests.
Bug: 79883035
Test: tap
PiperOrigin-RevId: 197634256
Change-Id: I4b7d94d45aeeb59d484b0069fdd1e200a654910b
|
|
Test: Tap
PiperOrigin-RevId: 196562314
Change-Id: Ie90a5ad183d4fb65ff512ea158a8687fe1f77963
|
|
Test: tap
PiperOrigin-RevId: 196278370
Change-Id: Ied6072caf4a6e87da5ba6395db8c0b0fa55b3f97
|
|
Bug: 67596257
Test: unit tests
PiperOrigin-RevId: 196049621
Change-Id: I6f9c6292b1d56e3faf7808aa668b03d07230a70b
|
|
This change also add a null check for RttCall when saving RTT transcript.
Test: DialerCallTest
PiperOrigin-RevId: 195293823
Change-Id: I67cf3410480ac106933486d9d31f0fbb3183b074
|
|
There are some upcoming changes to CallList#onCallAdded, so this CL adds the
tests needed to verify that behavior doesn't regress. This became something of a
rabbit hole because:
1) CallListTest needed to use a FakeSpam so spam status could be changed
2) FakeSpam needed updates so it wouldn't crash when CallList calls it. This was
implemented as a no-op for simplicity. It also needed to support the single
number lookup method.
3) FakeCall needed updates to support setting the details' extras (needed tests)
4) ShadowCall needed updates to support setting the details' extras
5) DetailsProperty needed a new value
6) There was an old TODO to use a string that's now visible in the SDK
7) SharedPrefConfigProvider needed a new method to set the emergency call window
long.
Bug: 33779976,79171382
Test: Tap
PiperOrigin-RevId: 195287258
Change-Id: Ib8b9fde35263183393e9bcbdcf73eeada24f28eb
|
|
Test: unit
PiperOrigin-RevId: 195188099
Change-Id: Ie2273229c257a9a767715831c15d90a6985fdda8
|
|
Bug: 76224138
Test: DialerCallTest
PiperOrigin-RevId: 195027298
Change-Id: I5e341af68d7efedff6047421c9fd45b612133a8c
|
|
Thre is no point to save an empty transcript.
This change will also prevent showing transcript button in call details.
Bug: 70177426
Test: manual
PiperOrigin-RevId: 194863630
Change-Id: Iee4e5c0929c3ebfc75377ed0f529934a6cfe01f5
|
|
If the call disconnects when RTT UI is in background, any messages received from remote should be saved to transcript. RttCallPrensenter might not be available at this point, so the job is done inside DialerCall#onRemovedFromCallList
Bug: 78576798
Test: presubmit
PiperOrigin-RevId: 194821868
Change-Id: I10381b1c292f918763360c7a4bcd0470250f2293
|
|
This refactoring will remove dependency on incall/call package for those classes only dependent on DialerCall.State.
The benefit is to remove unnecessary dependency and avoid potential loop dependency in the future.
Test: presubmit
PiperOrigin-RevId: 194594382
Change-Id: I6b3241bcf10a0a15c495c3c90a13f174c32e3f72
|
|
This is caused by transcript set to non-null again in some cases.
Test: manual
PiperOrigin-RevId: 194303928
Change-Id: Ife5e6bad3874751efab1d94a4262d83017b79808
|
|
Dual SIM features need to know what phone account the current call is using because usually only one SIM can be in a call at the same time.
TEST=TAP
Bug: 69675796,72618783
Test: TAP
PiperOrigin-RevId: 194121273
Change-Id: I512eb7aca2050f38449b0a911dea9cee9b5ffdb5
|
|
Bug: 78243122
Test: CallListTest
PiperOrigin-RevId: 194111299
Change-Id: I8cb3a0266b6796321e83a2a703630a745879be97
|
|
Test: manual
PiperOrigin-RevId: 193581061
Change-Id: Ia28f86c82f94ecd68623cfaa9c401073579358e5
|
|
Bug: 70177426
Test: RttTranscriptUtilTest
PiperOrigin-RevId: 193549902
Change-Id: Icb10e44edf32ef7913783628b38861465d0f6c93
|
|
Bug: 73736190,73775046
Test: none
PiperOrigin-RevId: 193239591
Change-Id: I0af371b59e57a902df8162f3f04ba8e5a7900588
|
|
1. Save RTT transcript when call is destroyed
2. Show RTT transcript link when it's available
Bug: 67596257,77717594
Test: manual
PiperOrigin-RevId: 192673172
Change-Id: If541ad9137c965166548d2fb449e835b95566727
|
|
This change also moved chat history to be saved in DialerCall, thus it will be persist when switching calls.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 191626079
Change-Id: I65e9c6ac7aa41beb45dfe561b0a48506ea938e6f
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 191365412
Change-Id: Ida741a837d6495c0d5f51b748f4d6c09a1beafec
|
|
This button has higher priority over add call button if RTT is enabled.
Bug: 67596257
Test: ButtonChooserIntegrationTest
PiperOrigin-RevId: 191129313
Change-Id: I5a3302a0970e77a933439749e0e559a691235523
|
|
Bug: 65490850
Test: manual
PiperOrigin-RevId: 190859631
Change-Id: I89aeb41a7709e9366367cdc54ba506e276685b5f
|
|
up to N.
Test: Existing tests
PiperOrigin-RevId: 190508397
Change-Id: Ia5f33e45af1d1cc666fec5f43efa564b2b68c193
|
|
Bug: 73774242
Test: unit tests where they exist
PiperOrigin-RevId: 189853302
Change-Id: Ibf3431cc0d7716c2c53c7ea165dfc130102a1bc7
|
|
Previously preferred SIM is handled only by precall, which covers dialing with dialer or with the special receiver contacts uses. If a third party app uses ACTION_CALL or telecomManager.placeCall(), then the in call UI will be launched directly and the old account selection dialog will be used without preferred SIM support.
In this CL logic from CallingAccountSelector is refactored out so InCallActivity can use it for the dialog.
Bug: 73718976
Test: Unit tests, In call UI not covered.
PiperOrigin-RevId: 188214007
Change-Id: Ifaacf982a3e98601dc362b649c3501d4ee96e63e
|
|
The user starts a video call a warning dialog shall be presented.
If the user presses "OK" with the "Do not show again" box selected,
the dialog shall not be presented anymore.
Test: manual - Verified that a warning dialog about charges is shown
when a video call is started if
KEY_SHOW_VIDEO_CALL_CHARGES_ALERT_DIALOG_BOOL is true.
This is an upstream change from:
https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/518977/8
Bug: 67832837
Test: partner manual test
PiperOrigin-RevId: 188103414
Change-Id: I62628a32557297acaef096db90d2ddf049ef5017
|
|
Bug: 73727182
Test: tested
PiperOrigin-RevId: 187673539
Change-Id: I9c790e912990fb8dc46da1c1057339c979ac9501
|
|
Bug: 72997695
Test: existing tests, LoggerUtilsTest, placed call to voicemail and verified
PiperOrigin-RevId: 186677560
Change-Id: I63d0a463f890c8cc1a301daa37388f58aed33aae
|
|
This change also:
1. Add simulator support of RTT request during call (always accept at this moment, will add random accept/decline in the future)
2. Fix bugs of putting RTT call in background and back to call
Bug: 67596257
Test: Simulator
PiperOrigin-RevId: 185920527
Change-Id: I51016fa6cf1ccc8a5a21335f9dacf286ae393706
|
|
Bug: 67596257
Test: lint tests
PiperOrigin-RevId: 185912566
Change-Id: I281fbd62865c9de150c3e2a7a3ea79c3eb85c529
|
|
This change will also:
1. Disable proximity sensor for RTT call
2. Update RTT call screen, including colors and banner buttons
Bug: 67596257
Test: presubmit
PiperOrigin-RevId: 185541897
Change-Id: I571373efbb8ced4ee2ad94879e9d37bed33b6a28
|
|
Bug: 68825005
Test: Added unit tests on CallFeedbackListenerImpl, CallFeedbackNotificationManager and DialerCall. Also manually verified the change.
PiperOrigin-RevId: 184211115
Change-Id: I50927036c3cd5d47862704376e2eef108c473fbf
|
|
CallCardPresenter updates a call number if the number is updated by NW.
But the logic is worng. The comparing numbers are always same. Because
it compares with the same objects in DialerCall#areSameNumber.
This is a upstream change from:
https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/556000
originating number is shown in the call screen.
Bug: 70201489
Test: manual - Verified that a call number that changed from a
PiperOrigin-RevId: 183022988
Change-Id: I04305998e77ca120b1248636c63984b3d20f0db1
|
|
Test: existing unit tests
PiperOrigin-RevId: 182949031
Change-Id: I40955c6e5f4fe06687880d3e9ef4b91ef9c0b371
|
|
Bug: 71840382
Test: DuoImplTest, existing tests
PiperOrigin-RevId: 182424150
Change-Id: I25607d43e1915d57134feac99b2c2240ae9559f9
|
|
Bug: 67005309,71880949
Test: VideoTechManagerTest
PiperOrigin-RevId: 182091664
Change-Id: I0be4d4f9740e2bb678e772ec8526ccf176c334eb
|
|
Bug: 67005309
Test: VideoTechManagerTest
PiperOrigin-RevId: 181368613
Change-Id: I8a13bd04d3ac342a06febb7437a0e0dd3d25affd
|
|
Bug: 33761801
Test: none
PiperOrigin-RevId: 181347696
Change-Id: Iaf09d1b45a2e97e4d8da24b5bd7172da152d703c
|
|
Test: Existing tests
PiperOrigin-RevId: 180230450
Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
|
|
* Use only one extra as if we were going to make a request of the Platform.
* Modify the incallui to handle instances where the platform may not supply TransformationInfo.
This should accommodate instances where the platform "used" assisted dialing,
but did not provide the necessary TransformationInfo.
Test: unit tests
PiperOrigin-RevId: 179841752
Change-Id: I06411dc00812dba8978a2a090d8769dcce9b2ad6
|
|
Since PhoneLookup exposes Call, more common access to the utility is required.
Bug: 70355819
Test: TelecomCallUtilTest
PiperOrigin-RevId: 178847628
Change-Id: I6cf55ad4e3566596b7b2e8cffb5a1614e6640a8b
|
|
It fixes AOSP for package name conflict.
Test: manual
PiperOrigin-RevId: 173298696
Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
|
|
Now that our Duo integration is public, we no longer need a code name.
To avoid any disruption, logging and config related names were not changed.
Bug: 63753964
Test: manual, existing tests
PiperOrigin-RevId: 172172738
Change-Id: Ib9d3d80761944d850c8c4886def9fef9a28539a4
|
|
There are many binder call triggered by IPC on main thread. This change will try to reduce them by caching thing that's bound to a call. It reduce total binder transaction from 1002 to 664 and saves ~11% latency of incoming call on locked screen.
1. Cache isVoiceMailNumber in DialerCall
2. Cache call capable accounts in DialerCall
3. Cache current country iso in DialerCall
4. Don't set orientation change if it's not changed.
This change also add lots of trace info. It won't affect release build though since they are stripped out by proguard.
Bug: 64542087
Test: manual
PiperOrigin-RevId: 171901266
Change-Id: Iec48f030529aa59974212147276f6d0ae121872a
|
|
Author: tomoyuki.nishikawa@sony.com
This change was inspired by http://aosp/508735
Even though VideoProfile.isVideo(getVideoState() returns true when starting a video call, ImsVideoTech is not ready until call.getVideoCall() returns not null (see https://android.googlesource.com/platform/packages/apps/Dialer/+/master/java/com/android/incallui/videotech/ims/ImsVideoTech.java#66)
During the time between VideoProfile.isVideo(getVideoState() being true but call.getVideoCall() returning null, we are incorrectly showing the phone call UI instead of the video call UI. To fix this, we need to trust the VideoProfile check in addition to the VideoTech check.
We still need to check VideoTech for other video options aside from just IMS VT.
Bug: 67712159
Test: manual
PiperOrigin-RevId: 171892356
Change-Id: Ibe1f9de60aaa4adc971401bee0277961cfe037e4
|
|
* Remove old language icon from bottom row.
Screenshot=In change as scuba test
Bug: 64205446
Test: new unit tests
PiperOrigin-RevId: 171858076
Change-Id: Idf781be193dae3593f778af1ac833f046abd87e3
|
|
Tracking bug to fix the refactoring: http://b/67512378
Bug: 67470678
Test: manual
PiperOrigin-RevId: 171553078
Change-Id: Ib83e4240d6024347f97d246f9b526c3ccbf02057
|
|
Do the following when a participant is on hold:
- Add "On hold • " in front of the number
- Gray out avatar and text (contact name & number)
Notice:
We only have the on hold state information for VoLTE conference call and IMS conference call. So the change only works for them (not for GSM/CDMA conference call).
Test: ConferenceManagerPresenterTest
PiperOrigin-RevId: 171345423
Change-Id: Ie5fe2fc1097f4858604283989dcb916c2ac21972
|
|
The problem is that InCallActivityCommon#onStop will try to commit any fragment which will crash.
This change also fix a bug that simulatorRemoteVideo is not stopped after hanging up.
Bug: 67045513
Test: manual
PiperOrigin-RevId: 170380589
Change-Id: I25e0f43141eaa573189f4d9c0109fd2689c10374
|
|
Screeshot:
Before:
https://screenshot.googleplex.com/bnByOaCTV4O
After:
https://screenshot.googleplex.com/v0vhkuuvT28
Bug: 38347145
Test: manual
PiperOrigin-RevId: 169933363
Change-Id: Ia3728be488ff329531c171b03a3045f1839d1d5e
|
|
video call upgrade and calling from call log is logged
Bug: 66222115
Test: DialerCallTest, GoogleCallLogAdapterTest
PiperOrigin-RevId: 169703001
Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b
|
|
And fix a related test in ImsVideoTechTest.
LOG_STORAGE_INCREASE(GB/week): 0.7
5M active block user/day * 10 events/active = 350M event/wk
350M event/wk * (2 [bool])/event = 0.7GB/wk
Test: LoggerUtilsTest
PiperOrigin-RevId: 169153878
Change-Id: Ia8038a5b0961f1a5572541f21df7a2680d85bbbb
|
|
The subcription number might be different than the line1 number (sim number),
which could be confusion to user during emergency call when it's not same as
the sim number the user knows of.
Bug: 65685277
Test: manual
PiperOrigin-RevId: 169147724
Change-Id: I2f89559d10a188b13937e80528b756cc9b11a02e
|
|
Previously, Android's Dialer app was developed in an internal Google
source control system and only exported to public during AOSP drops.
The Dialer team is now switching to a public development model similar
to the telephony team.
This CL represents all internal Google changes that were committed to
Dialer between the public O release and today's tip of tree on internal
master. This CL squashes those changes into a single commit.
In subsequent changes, changes will be exported on a per-commit basis.
Test: make, flash install, run
Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160
Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8
PiperOrigin-RevId: 167068436
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC32
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC32
This release contains the following bug fixes since RC17:
Bug: 33176679 33272455 3646510 36773894 37297649 37413780
37513689 37640315 37680595 37698062 37873639 37901752
37919295 37953423 38062852 38069600 38137349 38173549
38180252 38191514
Test: make, on device
Change-Id: I4e4bb630082758e418ff24892b7db3142c6eb09a
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC16
Branch: dialer-android_release_branch/153304843.1
dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC16
This release contains the following bug fixes since RC00:
Bug: 37324705 35304403 36067503 35304446 33203808 37280992
37346084 35766990 37481880 37424493 36470282 37347691
37519015 37168472 35805360 37545472 27704934 36515614
35766990 37577470 34739750 35801628 36788693 35264204
36708536 37628370 36904650 37314436 37642171 37530847
37637799 37666625 37548549 37648036 37636412 37323529
37630507 35919141 37198343 37548572 36178218 37640315
37663896 37720467 37275944 37710497 31634477 37744796
37348506 37744796 37568534 37672424 34872683 34873026
37681461 34873295 37748373 37526812 37618638 37663896
37536088 37727455 37165687 36651204 36900708 37323529
36902926 37256480 37328353 37432034 37436952 34093562
37720889 37321935 37780300 37781115 37755902 36588206
34258266 37290464 37698062 37618638 37473004 37432034
37918676 37870494 37722091
Test: make, on device
Change-Id: I99e1a484ccd578c1f8a13e7a6a4b4952f0791297
|
|
RC00 is based on:
branch: dialer-android_release_branch/153304843.1
synced to: 153304843
following the instructions at go/dialer-aosp-release.
In this release:
* Removes final apache sources.
* Uses native lite compilation.
More drops will follow with subsequent release candidates
until we reach our final v10 release, in cadence with our
prebuilt drops.
Test: TreeHugger, on device
Change-Id: Ic9684057230f9b579c777820c746cd21bf45ec0f
|
|
cl/152373142.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/151342913 (3/27/2017) to cl/152373142 (4/06/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I2fbc88cf6867b90ac8b65f75e5e34468988c7217
|
|
cl/151128062
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/150756069 (3/21/2017) to cl/151128062 (3/24/2017).
Notable this release:
- Explicitly enumerate host and target dependencies.
- Update proguard flag references.
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Bug: 33210202 36511925
Addresses
33210202 - Proguard support
36511925 - Compiler warnings when building against platform sdk
Change-Id: I448ec3b3f2358886859cf7a4ef76a8fcef3244ae
|
|
* Refactor voicemail component
* Add new enriched calling components
Test: treehugger, manual aosp testing
Change-Id: I521a0f86327d4b42e14d93927c7d613044ed5942
|
|
Test: Built package and system image.
This change clobbers the old source, and is an export
from an internal Google repository.
The internal repository was forked form Android in March,
and this change includes modifications since then, to
near the v8 release.
Since the fork, we've moved code from monolithic to independent modules. In addition,
we've switched to Blaze/Bazel as the build sysetm. This export, however, still uses make.
New dependencies have been added:
- Dagger
- Auto-Value
- Glide
- Libshortcutbadger
Going forward, development will still be in Google3, and the Gerrit release
will become an automated export, with the next drop happening in ~ two weeks.
Android.mk includes local modifications from ToT.
Abridged changelog:
Bug fixes
● Not able to mute, add a call when using Phone app in multiwindow mode
● Double tap on keypad triggering multiple key and tones
● Reported spam numbers not showing as spam in the call log
● Crash when user tries to block number while Phone app is not set as default
● Crash when user picks a number from search auto-complete list
Visual Voicemail (VVM) improvements
● Share Voicemail audio via standard exporting mechanisms that support file attachment
(email, MMS, etc.)
● Make phone number, email and web sites in VVM transcript clickable
● Set PIN before declining VVM Terms of Service {Carrier}
● Set client type for outbound visual voicemail SMS {Carrier}
New incoming call and incall UI on older devices
(Android M)
● Updated Phone app icon
● New incall UI (large buttons, button labels)
● New and animated Answer/Reject gestures
Accessibility
● Add custom answer/decline call buttons on answer screen for touch exploration
accessibility services
● Increase size of touch target
● Add verbal feedback when a Voicemail fails to load
● Fix pressing of Phone buttons while in a phone call using Switch Access
● Fix selecting and opening contacts in talkback mode
● Split focus for ‘Learn More’ link in caller id & spam to help distinguish similar text
Other
● Backup & Restore for App Preferences
● Prompt user to enable Wi-Fi calling if the call ends due to out of service and Wi-Fi is
connected
● Rename “Dialpad” to “Keypad”
● Show "Private number" for restricted calls
● Delete unused items (vcard, add contact, call history) from Phone menu
Change-Id: I2a7e53532a24c21bf308bf0a6d178d7ddbca4958
|