Age | Commit message (Collapse) | Author |
|
This change expands Cequint Caller ID to more provider name and adds signature
check to avoid fake provider fraud.
Bug: 69061848,69310040
Test: CequintPackageUtilsTest
PiperOrigin-RevId: 176386836
Change-Id: Ie8759ae5acb18fe8fe61f365065ae020428a7880
|
|
This means that names like "Bob Dylan" can be displayed as "Dylan, Bob" and
the names are now able to be sorted by last name as well.
This change also adds content descriptions to search icon for a11y.
Bug: 68293751
Test: NewSearchFragmentTest
PiperOrigin-RevId: 176382228
Change-Id: I5b2b0f3f3f1e2f23ea6b745fd809adfb0ba6242c
|
|
recycling views.
The adapter maintains the state of those voicemails that were expanded. When the views are recycled we ensure that the expanded view holder whenever visible is expanded. However when an expanded viewholder is collapsed, taken out of view and then brought back into view (recycled), the expanded state is preserved. This CL ensures that this no longer happens.
Bug: 64882313,68382421
Test: Unit test
PiperOrigin-RevId: 176233960
Change-Id: Ib57859a287ec0c4f9e955a0fc01a49f093023fd1
|
|
When a user types a phone number into the search bar, there isn't an intuitive
way for them to place a call when the number doesn't match any existing
contacts in the new search UI. This change adds the option to place a voice
call from regular search, like the old UI.
Bug: 69385190
Test: NSFT
PiperOrigin-RevId: 176189153
Change-Id: I6c1561bcce104c56855d996570a79b34da7230ff
|
|
during search.
We have observed in the wild that some apps implementing remote directory don't seem to respect the where clause.
Note that if a search returns 10 results, and 4 of them have null numbers, we will only show 6 numbers where ideally we'd show 10. (It would take a lot of work to fix that just to workaround misbehaving providers which I don't think is worthwhile.)
Bug: 68942044
Test: unit + manually changed guard condition and observed rows hidden
PiperOrigin-RevId: 176183008
Change-Id: Icdb26fa043644e27a4b6ac3c767c728b3ca224ff
|
|
Changes:
1. Rewrote the logic to pick a NumberFormat.
2. Deleted dead method setShowVoicemailButton(boolean) and field mCanDigitsBeEdited.
3. Deleted the redundant SDK version check when getting a Drawable.
Test: DialpadFragmentIntegrationTest
PiperOrigin-RevId: 176181808
Change-Id: Iee4e3db8535ebbea3d4c63c8d8c1d3eb342b538e
|
|
Bug: 66900825
Test: manual
PiperOrigin-RevId: 176155772
Change-Id: Ibe722477b90671b55ff7bf5405de9fb66569d43e
|
|
Bug: 68942044
Test: NO
PiperOrigin-RevId: 176147553
Change-Id: Ia22751f02cdd621c2095e8e476a3077db2c541fa
|
|
This cl just adds a check before starting a transcription job
to verify that the user has accepted the appropriate TOS. Its
a rather big cl just because it had to expose some TOS acceptance
details that were previously encapsulated in the VoicemailTosMessageCreator.
Bug: 69267260
Test: manual and unit tests
PiperOrigin-RevId: 176132370
Change-Id: Ic28fb197a07f9df7a9b5f1729c84566cba0890fc
|
|
This cl adds two classes, one to calculate a base multiplier for an exponential backoff series and the other to return sequential values in an exponential backoff series.
This cl has a number of advantages over the previous one, such as:
- separating the base multiplier calculation from the exponential backoff class so that a standard exponential backoff class like com.google.common.labs.concurrent.RetryStrategy.ExponentialBackoff could be used instead if it becomes open source
- allows the backoff sequence to be scaled by specify an initial backoff delay
- uses milliseconds instead of arbitrary time units which allows the tolerance to be set automatically when calculating the base multiplier
WANT_LGTM=zachh
Bug: 66966157
Test: unit tests
PiperOrigin-RevId: 176130268
Change-Id: I75135d4df16f642ea9dd3ef9ff9498981beae2c6
|
|
This CL adds a module that can query providers to aid users choosing which SIM to call with.
Bug: 64214592
Test: MotoSuggestionProviderTest
PiperOrigin-RevId: 176129303
Change-Id: Idb6314ad7f5a1bcd20b5b9173d3bfd873383cc84
|
|
Updated the following contents:
1.Fix the order of spawning connections for GSM conference.
2.Make VOLTE conference call more realistic.
3.Fix minor bugs about simulator.
4.Add SimulatorConnectionsBank class to store connection tags created by simulator.
5.Fix tests influenced by SimulatorConnectionsBank.
WANT_LGTM=wangqi
Bug: 67785540
Test: In dialer lab.
PiperOrigin-RevId: 176127584
Change-Id: I846174b97ed9329df6347583c41095f45f43494b
|
|
Test: DialpadFragmentIntegrationTest
PiperOrigin-RevId: 176122540
Change-Id: Iebf5ab67569fd4532411cfdae20ad5fb91cbcc55
|
|
Added a carrier config and check to see if the carrier allows over
the top voicemail transcription, and if not do not attempt transcription.
Bug: 68951869
Test: manual and unit test
PiperOrigin-RevId: 176065849
Change-Id: I69df1f2867420d7fdcc7f0a31e0e6c26da67abb1
|
|
If no actions require an activity, instead of launching the PreCallActivity, all actions will be performed immediately, and the call intent will be sent to telecom directly.
This reduces the latency & risk when mutli SIM is not supported.
Bug: 68953196
Test: PreCallImplTest, HeadlessPreCallCoordinatorTest
PiperOrigin-RevId: 176032790
Change-Id: I03258e8643f18c65a8e5b1a84b18b71b30638044
|
|
Also extracted FakePhoneLookup to a testing package.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 175923790
Change-Id: I866708a676e788051b369a024344967975c05979
|
|
EXTRA_PHONE_ACCOUNT_HANDLE is not implemented in O. subId is required to determine which SIM the settings is for.
Bug: 67669006
Test: VoicemailSettingsFragmentTest, TelecomUtilTest
PiperOrigin-RevId: 175913331
Change-Id: I84f9e19b711c5baa275d934cfdfd5b7a2d4b6f6d
|
|
Contacts need to check the meta-data to decide if the preferred SIM UI should be shown.
Bug: 64213352
Test: N/A
PiperOrigin-RevId: 175912590
Change-Id: Ic02ca47ab156c3bb752b33c97cfb3b62f45a3667
|
|
This change also enables search actions to be visible in regular search.
screenshot: http://screen/ULBgq2RnKnM
Bug: 68730642,67657783,68775021,66723880
Test: manual
PiperOrigin-RevId: 175892821
Change-Id: I2c71fe8ffa2ffddfbc88d777909c4837e0ea4384
|
|
This change updates search fragment to now preprocess query
results and hold them in memory. This significantly improves the
lookup runtime to be O(logn) on average and O(N) worst case.
Bug: 69100384
Test: existing (plus some time measurement regression tests)
PiperOrigin-RevId: 175891990
Change-Id: I6d7ae61c478b544af42d954af4e8580e052693ba
|
|
There must be a bug in FloatingActionButton because when you call
setImageDrawable multiple times (possibly with the same drawable/icon), the FAB
renders with no icon present. That's why the icon would disappear in
Fragment#onResume.
Bug: 69006360
Test: manual
PiperOrigin-RevId: 175878924
Change-Id: I1c36be3f9aeb003410f0bdbb9d52b5a483262f03
|
|
Replaces the existing buttons with Image Buttons using standards images. Also added a phone button.
Bug: 64882313,68382421
Test: Unit Tests
PiperOrigin-RevId: 175843834
Change-Id: I21898f7da72f3dd17fce0047b11349737b373513
|
|
Test: PreferredSimFallBackProviderTest
PiperOrigin-RevId: 175769540
Change-Id: Ie4e33f32ae9e99da92baa9906a3576df31b1b0a3
|
|
This allows one notification per SIM to be shown on multi SIM devices
Bug: 64010653
Test: LegacyVoicemailNotifierTest
PiperOrigin-RevId: 175756590
Change-Id: I8c2fe3ec06c5e6868ddc647742ab9ef422494b3b
|
|
Voicemail URI and duration are both retrieved from VoicemailEntry. This CL combines it.
This was a todo added from http://cl/175585919
Test: unit tests
PiperOrigin-RevId: 175718355
Change-Id: I7d2748cf6e110e494f6895c512ce355aa2d048a7
|
|
The duration of the voicemail shown in the seekbar/media player (upon expanding) should be the same as the duration shown when the voicemail view holder is collapsed. Both values are retrieved from the same source (VoicemailEntry).
Bug: 64882313,68382421,69268144
Test: Unit Tests
PiperOrigin-RevId: 175712662
Change-Id: I70496c004d52deb1793e6d6354b0ec79bf4c4398
|
|
This will be used in the PhoneLookupDataSource. A separate URI is necessary because the content provider APIs do not provide a mechanism for querying using the "distinct" keyword.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 175706603
Change-Id: Ia455a18d10afb116d26f69e8b0c7493f4f877d0b
|
|
This CL fixes crashes that are caused by opening the
PhoneDisambiguationDialogFragment after the associated activity is destroyed.
This is done by detecting when the activity is destroyed or finished.
Bug: 69133504
Test: PhoneNumberInteractionTest
PiperOrigin-RevId: 175623483
Change-Id: Ic639e9e9421205edcb5438d594bb144c6b09dd86
|
|
Adds the UX support for showing the seekbar in the NUI Media player. It also shows a starting and total duration text as well, though as of right now it's a static value and will be updated in a follow up CL.
Bug: 64882313,68382421,69268144
Test: Unit tests
PiperOrigin-RevId: 175595293
Change-Id: I14440599d52352c213c7513dd2d0a8aef2f51bfe
|
|
Before prompting the user to select the SIM, CallingAccountSelector will lookup the fallback preferred SIM database to see if a preferred SIM is already set and bypass the selection. If the number is in contacts the user will also have the option to store the selected SIM as preferred.
Bug: 64213352
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 175592732
Change-Id: I6a5a8ad8772eccfb4a119c529dcd3945b9dc0b1e
|
|
This CL adds an activity that will forward parameters to PreCall so external apps like contact can utilize SIM selection or assisted dialing features. The caller needs to have CALL_PHONE permission.
Bug: 64213352
Test: LaunchPreCallActivityTest
PiperOrigin-RevId: 175591732
Change-Id: I096ea022d5ed87c29ffb191cd1bdb04e3a17c945
|
|
Voicemails that are available locally on the device (have been downloaded from the voicemail server) will have their "HAS_CONTENT" column set to one. This CL adds the plumbing logic of checking that when a user presses the play button, if the voicemail is available locally, it is played.
Bug: 64882313,68382421
Test: Existing unit tests
PiperOrigin-RevId: 175590204
Change-Id: Id164d08c16b89c84a75af0c4a7c899c02d64fff7
|
|
Bug: 69133607
Test: manual
PiperOrigin-RevId: 175586518
Change-Id: I9c03da6f559e2943d30220aefc399ba2a7842f29
|
|
Test: LoggerUtilsTest
PiperOrigin-RevId: 175555340
Change-Id: Ic38e4e60559d91d3471629a5ffff496081fb5fb9
|
|
The PhoneAccountHandle is keyed with the DATA_ID of a Phone row in the Contacts provider.
Bug: 64213352
Test: PreferredSimFallbackProviderTest
PiperOrigin-RevId: 175354818
Change-Id: I828ff9d5a1e03e18b05256bcf8a61170be8ce7bc
|
|
They should work now that we target guava 20 instead of 18 in AOSP.
Test: tap
PiperOrigin-RevId: 175354039
Change-Id: Id7844c3a1c8e29e5ecb13fa36a92dd80be0cfc7c
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 175342952
Change-Id: I0e0318c5471605dfc47553552f558c65d41f9e9e
|
|
This is caused by normalizing numbers from dialpad search into search box, while "add new contacts" and "send sms" etc. wouldn't work properly without full number.
This change also fix "send sms" in old search fragment.
This change includes upstream change from:
https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/530377/
Change address format when sending message from smart dial
In Android O, send search key number as address to message app.
In Android N, send real input number as address to message app.
Fixed the issue by reverting to Android N implementation.
Affected Area:
Send SMS operation from Dialer smart dial search result list.
Bug: 68962106
Test: manual
PiperOrigin-RevId: 175317850
Change-Id: I96dd576144f93f7502977bfdb4b9e9d9c8f73526
|
|
PhoneLookupInfo should contain one message per PhoneLookup implementation for clarity. Instead of having a repeated Cp2Info field, we now have a single Cp2Info field which wraps a repeated Cp2ContactInfo field.
Also added ApdlInfo to the message to make testing of CompositePhoneLookup more realistic, in that it tests merging across submessages now. (ApdlInfo is more or less a placeholder until ApdlPhoneLookup is implemented.)
Test: yes
PiperOrigin-RevId: 175316738
Change-Id: I196c2eaa885e1268ff80ebaad6d85840a9cc7a15
|
|
Bug: 34672501
Test: yes
PiperOrigin-RevId: 175243488
Change-Id: Iec3b5eb0e81f6e6cc04c64c3ea65c9c7fcb33fe3
|
|
The declared type of "STRING" has an affinity of NUMERIC, not TEXT per:
https://sqlite.org/datatype3.html
Bug: 34672501
Test: existing
PiperOrigin-RevId: 175237916
Change-Id: I220a35f3060eb60870f6e930c821bdb2f6d2c7ed
|
|
Bug: 68848807
Test: unit
PiperOrigin-RevId: 175190786
Change-Id: I15b525951cb87afb8b48f3bdb2174605c94c99cf
|
|
Including:
- change action icon color
- hide TextView for name if name is empty
- if name is empty, use number to generate avatar
- don't show number type
Bug: 67053842
Test: manual
PiperOrigin-RevId: 175188810
Change-Id: I4ba40e5332d7b8567932360d36c8dc6ec3d604a5
|
|
Bug: 68844134
Test: n/a
PiperOrigin-RevId: 175102999
Change-Id: I63e930809d4bb96669062f724fb9cab90d675afa
|
|
This CL adds an executor which runs tasks on the Ui thread, using the existing
ThreadUtil class.
Bug: 67752611
Test: UiThreadExecutorTest
PiperOrigin-RevId: 175046280
Change-Id: Iff15e216be0e91891a9d63fddf1288ecbec41f83
|
|
Bug: 68840377
Test: manual verify no regression from inconsistently showing promo
PiperOrigin-RevId: 174957368
Change-Id: I0ed4fa1b24e693e91705744f60a7a385385cec64
|
|
contacts.
Bug: 68942044
Test: none
PiperOrigin-RevId: 174944384
Change-Id: Ie03ce41e517cfb73081231898a7e9dcc3feee2f2
|
|
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction.
Bug: 64216442
Test: manual
PiperOrigin-RevId: 174924323
Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
|
|
CallingAccountSelector examines the CallIntentBuilder, and if the PhoneAccountHandle is missing on a multi-SIM device while the default is not set, it will show a dialog to let the user select it. This step used to be after the in call UI is launched and telecom wants dialer to disambiguate. This step is moved to pre call as dialer need more control, like voicemail calls should always prompt, or the preferred SIM info might be available. This also allows telecom to send the selected PhoneAccountHandle to other apps so they have more information on how to rewrite numbers.
AssistedDialAction replaces the step previously in CallIntentBuilder.build(), and rewrites the URI.
Pre-call actions are not hooked up for dialing in this CL yet, assisted dialing will still be broken.
Bug: 64216442
Test: CallingAccountSelectorTest, AssistedDialActionTest
PiperOrigin-RevId: 174917321
Change-Id: Iba2e9092f83c036b402d4044a48ff5c44e806210
|
|
When the user makes a call, the PreCallCoordinator will get a list of actions to perform from PreCallActionProviderComponent and apply them to the pending CallIntentBuilder, before sending the built intent to telecom
Bug: 64216442
Test: PreCallExecutorImplTest
PiperOrigin-RevId: 174911537
Change-Id: Ide5ec431d4e6e7879fcdfdbbbd7ea5eed9963b2c
|
|
Multi-SIM and several other new features requires additional user input (ie. select the phone account to call with) or processing (ie. rewrite phone number for assisted dialing) before the call is actually made. The plan is to use a chain of pre-call actions to complete the dialing infomation,with the CallIntentBuilder holding the intermediate steps. For example, a pre-call action can examine the CallIntentBuilder and figure that the PhoneAccountHandle cannot be inferred, and show a dialog for the user the select it. Only after pre-call actions are completed, the intent is built and sent to telecom.
Since pre-call actions involves dialogs and the process can be interrupted, the CallIntentBuilder must be persistable so the state can be restored. This CL made it parcelable so it can be stored with onSaveInstanceState().
The AssistedDialingMediator in CallIntentBuilder is temporarily removed as it would be called using a pre-call action in a future CL.
Bug: 64216442
Test: CallIntentBuilderTest
PiperOrigin-RevId: 174902775
Change-Id: Icf2f8fae620868d1a2f5acf0d08ae0a6bec4fb76
|
|
Test: Manual
PiperOrigin-RevId: 174792372
Change-Id: I80ff3852c40cd532fdd2ed332e8b84ffb211a6e2
|
|
All voicemails are called by using CallIntentBuilder.forVoicemail() so the PhoneAccountHandle can be designated. A future CL will use dialogs to customize the call (multi SIM selection, RTT, etc.)
As a result voicemail error messages and legacy voicemail notifications will call the account it is received from directly.
Bug: 64216442
Test: Unit tests
PiperOrigin-RevId: 174784322
Change-Id: Ibe1c57bc7852e3d55a39a0cc2da19b6a79954c0f
|
|
improve reliability.
Bug: 68941995
Test: Manual
PiperOrigin-RevId: 174782574
Change-Id: I93f358507f1f60b87e26e1bdcddf50ed1ef8e1b2
|
|
Test: In dialer lab.
PiperOrigin-RevId: 174781953
Change-Id: I987c0d191a7c5613debb857bab9438d0c1aa20a7
|
|
Author: Ravi Paluri <rpaluri@codeaurora.org>
Bug: 68677786
Test: CallButtonPresenterTest
PiperOrigin-RevId: 174740252
Change-Id: If20e9fb92c4d729a75edf8ac6d088a88d4d319d8
|
|
This adds a file called new_voicemail_media_player_layout.xml that can be expanded and collapsed on tapping the voicemail entry. This file will later be updated in accordance with the specs, but the logic for expansion and collapsing would not be affected by the future cosmetic change.
Video=https://drive.google.com/open?id=1aIpmVfUYrFrg_FZ4tRX_TX6pU9YgPQaN
Bug: 64882313,68382421
Test: Unit Tests
PiperOrigin-RevId: 174713873
Change-Id: I15a6c5f01715429a6eb51fee447a5b42f25fdb56
|
|
Bug: 34672501
Test: unit
PiperOrigin-RevId: 174532642
Change-Id: I0115fb26f99fe764bc90625e3ed51f3c4c99439d
|
|
Test: Cp2PhoneLookupTest
PiperOrigin-RevId: 174525877
Change-Id: I7888f3b6adc58416c560271166ec6bd85306d58b
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174493347
Change-Id: I06d5d3d8877ac29d148b3945e28dc0a094660eca
|
|
Bug: 30215380
Test: QueryBoldingUtilTest, QueryFilteringUtilTest, ContactFilterCursorTest
PiperOrigin-RevId: 174408771
Change-Id: I4c601b16dd90db6b7b2a05c9daa6804749ea2a43
|
|
Currently we only show as much of the voicemail transcription, as we can see on the first line. This CL allows us to tap the voicemail, so that it is expanded and the whole transcription is now visible.
Bug: 68382421,64882313
Test: Unit Tests
PiperOrigin-RevId: 174267231
Change-Id: I19d3dea028c06d7c31aeb2949a19360eff648dcd
|
|
IsDirty is implemented by (possibly in parallel) executing all child lookups, and completing as soon as the first lookup reports itself as dirty, cancelling other lookups upon completion.
If a lookup fails for some reason, it is treated as not being dirty.
This required adding a new method DialerFutures#firstMatching.
Bug: 34672501
Test: yes
PiperOrigin-RevId: 174261470
Change-Id: Icb4f7b5d9926094fc446542411d15d02a4b873a3
|
|
Test: none
PiperOrigin-RevId: 174258291
Change-Id: Idf4eb0096fef383bd5f3544fdedba03528d14f41
|
|
in cl/173731907 we added a setting for donating voicemails, but didn't
distinguish between when this feature is enabled/disabled by the user
or by configuration. this cl fixes that by adding a method to check
if the feature is available (ie enabled by config).
Bug: 62423454
Test: manual and unit test
PiperOrigin-RevId: 174245260
Change-Id: I45a59de7f4a171d759e2fcf86db27a100a84de67
|
|
Test: no
PiperOrigin-RevId: 174239092
Change-Id: I6672c5b0a41df6426b527d1565f0cb216dc82917
|
|
The display name mixed with Hebrew and English is not displayed
correctly at call log, because the TextDirection of the display name
area is not set correctly. Fixed by correctly setting TextDirection.
Affected Area:
Direction of display name of call log list.
Bug: 68024853
Public-Origin-Change-Id: I3fb0e248d380d5431a8026b8491534b46911af99
Signed-off-by: Eric Erfanian <erfanian@google.com>
Author: yuichiro fujiwara <yuichiro.fujiwara@sony.com>
Test: manual
PiperOrigin-RevId: 174200487
Change-Id: Ib2d207ebb91a99662e4156f84c696caca82f877a
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174197504
Change-Id: Ide61f65a9dc1c104fa5bf136143c34e193c21396
|
|
The voicemail module should not contain any UI code.
Bug: 37258159
Test: DialerSettingsActivityTest,VoicemailSettingsFragmentTest. A future CL is refactoring VoicemailChangePinActivity into a fragment.
PiperOrigin-RevId: 174125949
Change-Id: I89cf6a083b0a0952332440d76e7ae0cb1c801931
|
|
This change removes restriction of showing HD icon only for some Motorola
devices.
After this change, any devices writing
android.provider.CallLog.Calls.FEATURES_HD_CALL into call logs' feature will
be able to show HD icon.
To be able to write HD features into call logs, both CarrierConfigManager#KEY_DISPLAY_HD_AUDIO_PROPERTY_BOOL and CarrierConfigManager#KEY_IDENTIFY_HIGH_DEFINITION_CALLS_IN_CALL_LOG_BOOL must be enabled.
It's part of upstream change to enable HD icon in call logs:
https://android-review.googlesource.com/#/q/topic:hd_icon_call_log
Bug: 68108125
Test: none
PiperOrigin-RevId: 174091763
Change-Id: I17c62153ebbc866c91acdaa7a7fcbd124594772b
|
|
calldetails package.
Test: tap
PiperOrigin-RevId: 174084052
Change-Id: I10c07767392060fafed048a74df5aece4090cd68
|
|
Test: Run in dialer lab
PiperOrigin-RevId: 174075702
Change-Id: Ib663dc34d2c0c9e737c6d5f13b16d2b42b714127
|
|
We need to be able to write the shared prefs when the device is in direct boot mode, and this data is not sensitive so can be unencrypted.
Bug: 68350256
Test: existing unit, manual
PiperOrigin-RevId: 174075154
Change-Id: Ib52e11c6abba0812d1dc07c642691359089c3e6e
|
|
We now use dagger everywhere for consistency and explicitness.
Test: tap
PiperOrigin-RevId: 174071122
Change-Id: I15d2f8261a7b753353be9e7d3b80692aa0c1b64d
|
|
This allows users to override our automatically selected country code.
Bug: 63994464
Test: unit tests
PiperOrigin-RevId: 174064853
Change-Id: I12bd770300b041f3c7d5b8d5f5c0b75c4945492e
|
|
Bug: 67785540
Test: On a walleye.
PiperOrigin-RevId: 174062497
Change-Id: I757b423f1c9ffe286fab15d3d8b5be8fe7c549dc
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174055180
Change-Id: Iac6deb8f9dcb6f3e9da6dfd0d732f29cc34bb7f6
|
|
Because the phone is one of the few applications that operate
when the phone is locked, disable the feature to avoid reading/writing
any encrypted preferences while the user is in the locked state.
I do not anticipate this being a necessary feature when
the device is locked.
Bug: 65399148
Test: unit test
PiperOrigin-RevId: 174044403
Change-Id: I1b9a2ac677ced2af06455a384bf169c417ffc1a5
|
|
Fleshed out docs for PhoneLookup.
Added dagger components and modules.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 173977963
Change-Id: If07795d9d3d56a59afd27cdda3e98543bf30fdb8
|
|
app open
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change.
This change also fixes flaky test of voicemailTabVisibleNotVisible_volumeStreamCorrect.
Bug: 64541209,65460373,67297718
Test: DialtactsActivityIntegrationTest
PiperOrigin-RevId: 173734472
Change-Id: Ifd4a3064a6fdcffe5a373eaad6ee4aeebdadda1e
|
|
In portrait mode, we surround the icon and letters with a linear layout so that we can adjust its height.
In landscape mode, we add a horizontal placeholder to each key's layout so that we can adjust its width.
This approach was put forward by Ryan Oldenburg (roldenburg@).
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 173717443
Change-Id: I9b60657ca20d371a60c303a9683578663fc28a09
|
|
No changes are made to the portrait-mode UI.
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 173710022
Change-Id: I9ef8a57b044e069af2eb886ea6baa30c279f4f70
|
|
The current implementation is easy to read but causes klippy warnings.
Also removed the AnnotatedCallLogDatabaseHelperTest.voicemailColumnsExist and combined it with the onCreate Test
Test: Unit Test
PiperOrigin-RevId: 173614534
Change-Id: If00f7e91f48e582aa481268d88a4871cc2364684
|
|
DialerUtils#getDefaultSharedPreferenceForDeviceProtectedStorageContext(Context) to StorageComponent.
Bug: 30224215
Test: none
PiperOrigin-RevId: 173612463
Change-Id: Ia89d5d85c31ea2114b196393ae43b803023fc9bf
|
|
When dialer application class got launced but GoogleDialtactsActivity was not launched, there was an unstopped timer started by dialer application, causing the measurement to be very huge next time.
Test: Run on devices in dialer lab.
PiperOrigin-RevId: 173570185
Change-Id: If835c7b0b7cf01b9ec3f7bc36a5104f57c697908
|
|
Checks if a cp2 contact has been modified or deleted.
Bug: 67605130,64099602
Test: Cp2PhoneLookupTest
PiperOrigin-RevId: 173499443
Change-Id: I1fa267c05732fba09f00113232d4370b159aa735
|
|
Migrate the existing app latency test to a new solution from Project Fi team.
The main change on this new solution is that the data collection part is done by Primes now.
Also, a few changes has been made on DialerPrimes class and a new Dialer variant dialer_release_test has been created.
The benefits of using primes to collect data are:
1. latency tests dont need to insert lines of code to track latency in dialer codebase
2. be able to collect data on any variants with or without Proguard
3. latency tests now only contain ui interaction to trigger scenarios on which we want add measurements
4. share the same logic with primes on production so that data from testbeds and normal users are comparable.
5. easier for anyone to add interesting data entries.
----------Mobile Harness Below-----------------------------------
RELNOTES[INC]:Add entries for dialer to use mobileharness plugin.
Test: No
PiperOrigin-RevId: 173481741
Change-Id: Ia6812794141382898bea4b34bca90278c5663464
|
|
Moved SearchContactViewHolder listener logic from SearchAdapter
to SearchFragment to make it easier to close search after placing a call.
Bug: 68201142
Test: existing + DialtactsActivityTest
PiperOrigin-RevId: 173454972
Change-Id: Ib5715d0f427d62344641b4bf841d34145fc3f65e
|
|
Follow repro steps to see contacts promo always consistently shown
Bug: 68158965
Test: manual
PiperOrigin-RevId: 173427472
Change-Id: I3717ee674aa81d1f1c563920796ef0f21dcdd963
|
|
VoicemailUri is required to play voicemail audio files. We need it to be able to play the voicemails in the voicemail tab. A follow up CL will be using the uri to play the audio, but via a media player.
Bug: 64882313
Test: Unit tests
PiperOrigin-RevId: 173422683
Change-Id: Ib438e3020c83e11a2c54c3e941c93e83dba9bc90
|
|
By always creating executor services via dagger, we can now bind special versions during espresso tests that can implement idling resources. We should be using idling resources during espresso tests for threads that we create ourselves, because espresso does not know about them.
Hopefully this reduces some of the flakiness of espresso tests that we have today.
This required converting all existing calls to DialerExecutors to pass a context used to fetch the component, and also required creating new application classes for espresso tests.
Test: temporarily added a task which just slept to DialtactsActivity and verified that its integration test failed due to idling resource timeout
PiperOrigin-RevId: 173334773
Change-Id: I876a93022d235d62cfc377bf5b06687e21a34758
|
|
It didn't sit well with me that we would check for platform eligibility
in two places.
Test: existing unit tests;
PiperOrigin-RevId: 173334224
Change-Id: Ia7075bc40e935c2794646671b5cfea34b7a06afb
|
|
It fixes AOSP for package name conflict.
Test: manual
PiperOrigin-RevId: 173298696
Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
|
|
*** Reason for rollback ***
Causes crashes on rotation: http://b/67839843
*** Original change description ***
Do not load every DialtactsActivity fragment on app open
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the ch...
***
Bug: 64541209,65460373
Test: Manually verified regression fixed
PiperOrigin-RevId: 172684553
Change-Id: I9a5b30d6619d930adfb82b19ac3ff9da00decaaa
|
|
call log UI.
Currently we use PhoneNumberUtils#compare(String, String) to determine whether two numbers in the call log should be grouped. The method ignores special dialable characters such as "#", "*", "+", etc, which can cause phone numbers and service dialing numbers to be grouped.
For example, suppose the user has a contact named "John Smith" with number 123456789 and a contact named "Service" with number #123456789, and called each contact once. The old grouping logic will put the two numbers in the same group.
The new grouping logic in this CL can separate the two numbers.
Bug: 30225112
Test: CallLogGroupBuilderTest, PhoneNumberHelperTest
PiperOrigin-RevId: 172683494
Change-Id: Ie9e7b7418d6d7c74830cbae09c04ff1feb1b827d
|
|
Bug: 36565933
Test: manual, just moving
PiperOrigin-RevId: 172671853
Change-Id: I415f5b7e518cca22fad96b017a573322af3f73be
|
|
Bug: 67322107
Test: manual
PiperOrigin-RevId: 172656296
Change-Id: Ia8b7d508ef35ff0091b762c28e1091af60ce15b4
|
|
Bug: 67914094
Test: unit tests
PiperOrigin-RevId: 172650441
Change-Id: Ie7df3174a07df2de3a102fb70a126004f704b22f
|
|
Bulk insert is implemented in ag/3073902
When more than one voicemail is inserted into the VoicemailProvider, the URI type is Voicemails.DIR_TYPE instead of ITEM_TYPE. This CL adds support to the new type.
Previously when multiple voicemails are being notified, each one of them will generate a ringtone because the notifiction is set to alert children. In this CL, the summary will have alert instead, and will only alert when new voicemails are received.
Bug: 21281858
Test: VisualVoicemailNotifierTest
PiperOrigin-RevId: 172546076
Change-Id: I4df6098fc3a793139e3d4e77fe1339efdc001944
|
|
The numbers used to be cropped (http://screen/YYBG8T0Ma0J). We've fixed that issue in this CL and also removed the term "call_log" from the file name.
Screenshot:
http://screen/uHCPwf5smVX
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 172541833
Change-Id: Ib2746b38284c2c04c84ab369d449412d8a9880b4
|