summaryrefslogtreecommitdiff
path: root/java/com/android/dialer
AgeCommit message (Collapse)Author
2018-01-03Only consider writable accounts for preferred SIMtwyen
Some apps will add their own account to contacts and cause PhoneLookup to return multiple accounts. Since Contacts cannot write to these accounts the preferred SIM settings on them does not make sense. In this CL a reduced version of AccountTypeManager is used to determine if the account is writable. External accounts (which capabilities are determined by parsing their sync adapter) are not supported. Bug: 70689051 Test: CallingAccountSelectorTest PiperOrigin-RevId: 180693656 Change-Id: I24e93860cd576777c6d3861f65f75baa234dac87
2018-01-02Add assisted dialing to the new call log.erfanian
Bug: 70506228 Test: new unit tests PiperOrigin-RevId: 180610636 Change-Id: I7f498df1a529737bf8473584836bdc3e04a5043c
2018-01-02Bubble v2 dismiss.yueg
Drag and drop bubble to bottom to hide or end call. Flinging to bottom does not trigger the actions. Color/text is not final. Navigation bar is not hiden and the change will be in a following CL. Bug: 67605985 Test: NewBubbleTest PiperOrigin-RevId: 180608133 Change-Id: Iff4cb32226d8fbf0f8e5319f6876a1d74c336b4a
2018-01-02Fix accessibility bugs with transcription rating UImdooley
Bug: 71504376 Test: manual using accessibility scanner PiperOrigin-RevId: 180597338 Change-Id: Ie672d3718fec369cfcdec0eef09fb203da8ea8b9
2018-01-02Add assisted dialing indicators to the old call log.erfanian
Modify the call log grouping strategy. The strategy is as follows: When comparing the current group to the next candidate to add to that group, if the assisted dialing feature tag differs between the two, create a new group. Thus, if a call has other features like wifi or hd, we ignore those features when making grouping decisions. Bug: 70506228 Test: unit tests PiperOrigin-RevId: 180592125 Change-Id: I73d130bd9eb23706a04cb02f5711200729d978b6
2018-01-02Support assisted dialing in CallDetailsActivity when launched from the new ↵linyuh
call log UI. Bug: 70218437 Test: ModulesTest PiperOrigin-RevId: 180577770 Change-Id: Idbfe48ea22d422c90d970d633a952a7200f49f82
2018-01-02Add assisted dialing to the call composer activity.erfanian
Bug: 70802770 Test: didn't see a great place to test this. PiperOrigin-RevId: 180563660 Change-Id: I1ecb83fd48a499d8636dcace930498c1508c07ae
2017-12-28Allow language change to take effect in T9 search without relaunching Dialer.linyuh
Bug: 30215380,70633239,70856260 Test: Manual PiperOrigin-RevId: 180276925 Change-Id: Ia0a7c435e48303781917bf0cc2e69995ee652ad9
2017-12-27Remove field prefixes.linyuh
Test: Existing tests PiperOrigin-RevId: 180230450 Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
2017-12-27Fixing transcription branding UI bugmdooley
Needed to set the branding text (to an empty string) when the transcription rating text is visible, so that both aren't displayed at the same time. Bug: 71361435 Test: manual PiperOrigin-RevId: 180218087 Change-Id: I04e485727267c306c7eb8f3780424855aaddebe5
2017-12-27Parameterized PhoneLookup with submessage type.zachh
This allows indvidual PhoneLookups to define and deal mostly with their own submessage type (with the exception of trivial setter and getter methods for converting from/to PhoneLookupInfo). This also simplifies the FakePhoneLookup and tests which use it a bit, I think. Bug: 34672501 Test: unit PiperOrigin-RevId: 179976215 Change-Id: I2db1fc85771621be2f2afcd6af114d82680e30d0
2017-12-22Enable multi-sim support in assisted dialing.erfanian
* Add a new flag to enable or disable multi-sim support. * Add a new mock method to the ShadowTelephonyMananger to support N+. * Use new O+ API when available. This logic is client specific, and is unecessary in the platform. Bug: 69861007 Test: new unit tests PiperOrigin-RevId: 179970674 Change-Id: Id9889c81e3c196f4a246f0a604d08b81cc906499
2017-12-22Update unread voicemails as read in the NUI Voicemail by unbolding when ↵uabdullah
expanded. A voicemail will be marked as read when up tap on it. When it's unread its shown as a unbold voicemail. This CL marks a voicemail as read and updates the underlying table when its expanded. Bug: 64882313,70950649 Test: Unit Tests PiperOrigin-RevId: 179963238 Change-Id: Ia968178a49e2f7ae83b859dcdbda71acd5383f03
2017-12-22Use ICU Localization for country names in settings.erfanian
Bug: 69798116 Test: existing unit tests PiperOrigin-RevId: 179959039 Change-Id: Iee6959b30345c044e85c2048954ce06555984926
2017-12-22Automated rollback of changelist 179615699calderwoodra
Bug: 36841782 Test: tap PiperOrigin-RevId: 179874507 Change-Id: I6634243136520d7f13bbe3637ed4d890c38bf887
2017-12-22Automated rollback of changelist 179847039calderwoodra
Bug: 36841782 Test: tap PiperOrigin-RevId: 179873378 Change-Id: I5e579f11c9738a75f312be33de556fd2bb3dac42
2017-12-22Differentiate read/unread voicemails in the NUI Voicemail by bolding.uabdullah
Voicemails that are unread in the annotated call log table will show up as bold. Voicemails that are marked as read will show up as normal (non bold). A follow up CL will update the underlying table and mark them as read when a viewholder is expanded. Bug: 64882313,70900195 Test: Unit Tests PiperOrigin-RevId: 179872932 Change-Id: I927711aa8c6c6324e43f519c14a58b5f2b8e7ca9
2017-12-22Use CHAR_TO_KEY_MAPS in DialpadCharMappings in SmartDialMaps.linyuh
This way we don't have to manually keep the maps in sync. Bug: 30215380,70633239 Test: Existing unit tests PiperOrigin-RevId: 179871748 Change-Id: Idd4cc1155068bb31c17deae80b98d73363fad770
2017-12-22Reorganize classes related to smart dial.linyuh
Bug: 30215380,70633239 Test: Existing tests PiperOrigin-RevId: 179868033 Change-Id: If8cdbdfafb3a66397623578131649cb8adc18733
2017-12-22Use the orientation obtained in onFinishInflate as the truth in DialpadView.linyuh
Bug: 69665429 Test: Manual PiperOrigin-RevId: 179847326 Change-Id: Iaf40910dd4692bbed73d2496ffd27f60d2e28307
2017-12-22Added context menu for favorite contacts in new speed dial.calderwoodra
Bug: 36841782 Test: n/a PiperOrigin-RevId: 179847039 Change-Id: I5006e074fff4041eef54c9b81280097ac30be5b3
2017-12-22Update assisted dialing extras in preparation for platform implementation.erfanian
* Use only one extra as if we were going to make a request of the Platform. * Modify the incallui to handle instances where the platform may not supply TransformationInfo. This should accommodate instances where the platform "used" assisted dialing, but did not provide the necessary TransformationInfo. Test: unit tests PiperOrigin-RevId: 179841752 Change-Id: I06411dc00812dba8978a2a090d8769dcce9b2ad6
2017-12-22Quick fix for bugs on simulator voice call.weijiaxu
-Fix incoming spam call which doesn't respond to UI interaction. Reason for that was connectionTag didn't get assigned. -Fix dialog of custom incoming/outgoing call. Current value of callerIdPresentationChoice is 0 which leads dialer to show UNKNOWN number on InCallUiActivity. Set callerIdPresentationChoice to 1 (ALLOWED) as default value. Test: on a local device. PiperOrigin-RevId: 179760724 Change-Id: I68f6e238ecd78a017d6539b25f95645c72e2cd0f
2017-12-22Fixed crash in UiListener when launching activity with screen off.zachh
When launching MainActivity with the screen off (e.g. from Android Studio) the application would crash due to: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState Also use FragmentPagerAdapter in MainPagerAdapter as the number of tabs is small and can be stored in memory. Test: manual PiperOrigin-RevId: 179734952 Change-Id: Ib2ca9674f3174493da55bbbf0ef4053fcf73ab47
2017-12-22Handle contacts which have been disassociated with a number in Cp2PhoneLookup.zachh
Bug: 34672501 Test: unit PiperOrigin-RevId: 179726904 Change-Id: I6a81ef28675af7f95139193b69f87decddc4c844
2017-12-22Fixed crash in PinnedShortcuts.zachh
It was expecting only shortcuts for contacts but we also have the "NUI Launcher" shortcut now, so ignore it when attempting to update. Test: unit PiperOrigin-RevId: 179726507 Change-Id: I45e1594250ed70fcd1d18bfead5a9b4e9e46a58b
2017-12-22Added copySubMessage method to PhoneLookup interface.zachh
The existing way that protos are merged in CompositePhoneLookup is not correct because foo_submessage from BarDataSource may incorrectly contribute old information to the merged message. The new copySubMessage method makes it so that each PhoneLookup is responsible for defining which submessage it is responsible for and prevents the problem. Test: unit PiperOrigin-RevId: 179707015 Change-Id: I566305cf64c46c698f14812d9241d166ac75a6d3
2017-12-22Bubble v2 changes.yueg
- Only show bubble for outgoing, active and background call. (Before: show bubble when is in call) - Show "Call ended" and hide bubble only when there is no outgoing, active or background call. (Before: show "Call ended" for all real call disconnection like one call in conference) - Don't show "Call ended" but only hide bubble when Duo upgrade is accepted/declined. We show bubble for Duo upgrade since the call is still connected. The solution doesn't work for fallback upgrade on pre-ODR device (so "Call ended" still shows). Bug: 67605985 Test: NewReturnToCallControllerTest PiperOrigin-RevId: 179636643 Change-Id: I5d1f6e812c94108228757af89e33d4c496beb735
2017-12-22Include inserted calls for consideration in PhoneLookupDataSource.zachh
If there is a new call with a number that hasn't been seen before, it should be considered the same as numbers that are already part of the call log. Bug: 34672501 Test: unit PiperOrigin-RevId: 179628789 Change-Id: I422c24c444958dd8842aa14cf8a8069da5cec2c1
2017-12-22Register content observer when voicemail table changes.uabdullah
When a new voicemail is received, it is written in the voicemail table by the Voicemail service. However the new voicemail will not get updated/shown in the New Voicemail UI as the annotated call log would be stale. This CL ensures that when the voicemail is added, the annotated call log is marked dirty and refreshed. This way the new voicemail will be shown in the new voicemail UI. Since a new voicemail is also added, we want to make sure the headers for "today" and "older", their positions are also updated accordingly. Bug: 64882313 Test: Unit tests PiperOrigin-RevId: 179623267 Change-Id: I5dfc84f62f9f37c57ffb2dbbe7e848a58306a19d
2017-12-22Add SmartDialMaps for the Bulgarian alphabet and the Ukrainian alphabet.linyuh
Bug: 30215380,70633239 Test: BulgarianSmartDialMapTest, UkrainianSmartDialMapTest PiperOrigin-RevId: 179621038 Change-Id: I1a5ad97ba7cd4e9e0edffb3cb39f40c4c5d137a1
2017-12-22Remove voicemail from UI only after delete request.uabdullah
Bug: 64882313 Test: N/A PiperOrigin-RevId: 179616641 Change-Id: Ie9e67226dc7cd4082ca4f7fd3ca5725bb854bca2
2017-12-22Implemented SpeedDialEntry Room Database.calderwoodra
This CL includes everything needed to interface with the SpeedDialEntry database. As an excersice to demonstrate it's functionlity, it also updates favorites to read from SpeedDialEntry database and the add favorites screen to insert into it. Bug: 36841782 Test: existing PiperOrigin-RevId: 179615699 Change-Id: I8938ef87244dffbd240506c112b445d147a88193
2017-12-20Populate voicemails in simulatoruabdullah
Adds the logic for only adding voicemails (no call log) in the simulator menu. Also adds the logic for adding a fast voicemail, which only adds 1 voicemail. Bug: 64882313 Test: N/A PiperOrigin-RevId: 179615214 Change-Id: I5a55df44d94b6123eaed6bc56439472b1ab81151
2017-12-20Print array map for debugging purposes.uabdullah
A small bug that only printed the last value of the array map and not all of it. Bug: 64882313 Test: N/A PiperOrigin-RevId: 179605815 Change-Id: I7230508f47e6603470d8067ef5233ae3c9af8911
2017-12-19Add flags for the Duo install, activate and invite buttonsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179596742 Change-Id: Ic5616af0680e36786ae5261813eae71cf096b084
2017-12-19Support dual alphabets in smart dial.linyuh
Bug: 30215380,70633239 Test: CompositeSmartDialMapTest, LatinSmartDialMapTest, RussianSmartDialMapTest, SmartDialNameMatcherTest PiperOrigin-RevId: 179580982 Change-Id: I5e4c3e61f0dfdc6ca1e80a93bb985ffec08dd8b0
2017-12-19Ignore deleted voicemail for notificationtwyen
Some voicemail sources keep deleted voicemails in the database for a while. Before this CL if the voicemail is deleted through blocking it will still be returned with CallLogNotificationQueryHelper.getNewVoicemail(), and deleted again. The Deletion triggers a notification update, and the phone enters a loop. If there are other voicemails, the phone will alert every time. In this CL, deleted voicemails are no longer returned with the new voicemail query. Also if All voicemails already has a notification, the user will not be alerted. Bug: 70585368 Test: VisualVoicmailUpdateTaskTest, CallLogNotificationQueryHelperTest PiperOrigin-RevId: 179575512 Change-Id: I352bbf7d0a9d5e2132b5f968e5b5776c9fd518c6
2017-12-18Bubble v2 logging.yueg
Log the following actions: - expand/collapse bubble - return to call - mute/unmute - switch audio route to speaker/bluetooth/wired or earpiece - end call Bug: 67605985 Test: AudioRouteSelectorActivityTest, NewReturnToCallControllerTest PiperOrigin-RevId: 179484647 Change-Id: I4e2ee34f5550382b2e51bab16ce33e9e16caa3b2
2017-12-18Ensure we do not have a null data string before checking for Duoroldenburg
Bug: 70794242 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179480604 Change-Id: Ic53ca21fb7e81390f45b116677df689d3d8fdb67
2017-12-18Added tests for SmartDialNameMatcher.calderwoodra
Bug: 30215380 Test: this cl PiperOrigin-RevId: 179468203 Change-Id: I2996a15135cde48094cb8f430b2fd6d7eeee6ec7
2017-12-18Added tests for latin smart dial map.calderwoodra
Bug: 30215380 Test: this CL PiperOrigin-RevId: 179461976 Change-Id: I05dc2ddde58533ef2caef7ccd3327d36c7bf4e55
2017-12-18Upgrade target SDK version to 27.linyuh
Test: None PiperOrigin-RevId: 179458302 Change-Id: Ic6bfd4abe4c7f51d395488863edc1515754f6b36
2017-12-15Implemented Cp2PhoneLookup#lookup.zachh
Bug: 34672501 Test: unit PiperOrigin-RevId: 179278530 Change-Id: If629aa2c31efad790c8c70e8066dc9a5612d1fc3
2017-12-15Support empty PhoneLookupInfo in Cp2PhoneLookup.zachh
This is necessary to support the case when the user has just upgraded to the new UI and there is no PhoneLookupHistory data yet, or they have cleared their data. Bug: 70570635 Test: unit and manual PiperOrigin-RevId: 179261139 Change-Id: I1e521d2e86bd3f8643c5c0bb537a52c41f1ceb6d
2017-12-15Hide "Invite" and "Set up" Duo buttons for spam and voicemail callsroldenburg
Bug: 70681464 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179224173 Change-Id: I7b70f478898fade5cc5a9bf50581d35f2ce2261f
2017-12-15Implement basic bottom sheet in NUI Voicemail tab.uabdullah
Implement the basic bottom sheet that displays name, location add to contacts, send a message and copy number option. Bug: 64882313,70682949 Test: Unit test, additional unit tests in the next CL that will implement calling from bottom sheet. PiperOrigin-RevId: 179212401 Change-Id: I23281587a0d42cea595e4dc1608f997036e2dbd0
2017-12-15Remove voicemail settings if missing permissiontwyen
Bug: 70282673 Test: DialerSettingsActivityTest PiperOrigin-RevId: 179124385 Change-Id: I9a7f8edc4ae8df44891f551a8aa561bd81922f66
2017-12-14Handle ActivityNotFoundException when starting intent from IntentModuletwyen
Bug: 70515828 Test: IntentModuleTest PiperOrigin-RevId: 179123113 Change-Id: I3cfed7570505c058f3e86054186115db98bb2a8e
2017-12-14Add PreCall step to check permissiontwyen
If CALL_PHONE is missing PreCall will abort immediately and show a toast. Bug: 70565989,70566029 Test: PermissionCheckActionTest PiperOrigin-RevId: 179123070 Change-Id: I0d43c6acd44e77562752c871bed0223b2f787dde
2017-12-14Implement PeopleApiPhoneLookuptwyen
This CL rewrites com.google.android.dialer.reverselookup and uses gRPC instead to perform People API queries. Bug: 70355819 Test: PeopleApiPhoneLookupTest, PeopleApiPHoneLookupInfoTransformerTest PiperOrigin-RevId: 179122466 Change-Id: I769c8b420b9d71b9787d844380b2aceb7ff2c63c
2017-12-14Refactor add to contacts, send a message and copy number modules for bottom ↵uabdullah
sheet These three modules are to be shared between the voicemail and call log bottom sheets. This CL refactors it such that the functions take in generic parameters instead of coalesced annotated call log row so that they can be used by the voicemail tab. Bug: 64882313,70682949 Test: Existing tests PiperOrigin-RevId: 179110882 Change-Id: I2e8edafbf50e51d2299bfbcb95957e40c1b366ec
2017-12-14Use Dagger to get Duo instance in CallLogListItemViewHolderroldenburg
Bug: 70402153 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179106427 Change-Id: I2c82e95022c461d251d3385841640bc31d8aa765
2017-12-14Add input dialog for simulator to use customized number.weijiaxu
Add dialog for user to input whatever numbers with whatever types they want. With this functionality, users can use simulator to test payphone number, private number and etc.. This is a part of feature request in b/70244000. Bug: 70244000 Test: On a local device. PiperOrigin-RevId: 179105057 Change-Id: Ibb386e209d0907d23773cd2c55939b500de4d8f6
2017-12-14Add impressions for Duo related events (install, activate and invite)roldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179085188 Change-Id: I7546cf7e35bbdd3788b03d19627d9a04f612335f
2017-12-14Take into consideration special characters when we do contact match.linyuh
Bug: 30225112 Test: CallLogGroupBuilderTest, PhoneNumberHelperTest, CallerInfoTest, and Manual (see demo) PiperOrigin-RevId: 179080046 Change-Id: I8e451a6c197a6c3df4260e58d0276a5dc5b9515a
2017-12-14Support deleting voicemailsuabdullah
Allows voicemails to be deleted when tapping on the delete icon. Upon tapping the delete button this first deletes/hides it in the recyler view and then subsequently deletes it from the underlying table. Test: Unit test PiperOrigin-RevId: 179055594 Change-Id: I98bb7694d59b7edfcaa4ae162b194c0ef3a0292e
2017-12-14Implemented disambig dialog for new speed dial fragment.calderwoodra
This change implements the logic to build the disambig dialog and display the relevant information. Future CLs will: - Implement the logic for favoriting a communication avenue - Polish the UI Bug: 36841782 Test: DisambigDialogTest PiperOrigin-RevId: 179012593 Change-Id: I4294f4ae2a475b1e560eabd424e54a829c0d7829
2017-12-14Support normalization of numbers in Cp2PhoneLookup.zachh
Bug: 34672501 Test: unit PiperOrigin-RevId: 179012381 Change-Id: Icb78c73e243702a71f1a48692151b696ae2ac95f
2017-12-13Take user to install Duo if they tap "Set up" without the app installedroldenburg
Bug: 70034799 Test: DuoImplTest, GoogleCallLogAdapterTest PiperOrigin-RevId: 178981398 Change-Id: Id524dfe61bf3a2358d863dd8d5f7c6c083b8063c
2017-12-13Add reloadReachabilities to Duo interfaceroldenburg
Bug: 70034799 Test: DuoImplTest, GoogleDialtactsActivityTest PiperOrigin-RevId: 178971440 Change-Id: Ib624bd340fbeac11474db198763ae77eddb03ae3
2017-12-13Integrate CallDetailsActivity with the new call log UI.linyuh
Bug: 70218437 Test: CallDetailsActivityTest, CallDetailsCursorLoaderTest, ModulesTest PiperOrigin-RevId: 178918820 Change-Id: Ib8034190550e8ca8e6e7fd9ce521bfadc73e834f
2017-12-12Refactor CallerInfo and ContactInfoHelper to improve readability.linyuh
Test: Existing tests PiperOrigin-RevId: 178862915 Change-Id: I2dd58db10d546c062b0f43dad80f74d588cb65e1
2017-12-12Move TelecomCallUtil to com.android.dialertwyen
Since PhoneLookup exposes Call, more common access to the utility is required. Bug: 70355819 Test: TelecomCallUtilTest PiperOrigin-RevId: 178847628 Change-Id: I6cf55ad4e3566596b7b2e8cffb5a1614e6640a8b
2017-12-12Cleanup. Changing voicemail_transcription_enabled to ↵mdooley
voicemail_transcription_available Follow the convention that features allowed by server configuration flags use the word 'available' and when a feature is allowed by the user via settings then use the word 'enabled' Bug: 37340510 Test: manual and updated unit tests PiperOrigin-RevId: 178831467 Change-Id: I5691fd7db45a70908d32cdac2b049fe76e6a0680
2017-12-12BEGIN_PUBLIClinyuh
Automated rollback of changelist 172505648 Bug: 30225112 Test: None PiperOrigin-RevId: 178815682 Change-Id: I1fe1eef49d587314d32e7125f5106769b3099ad3
2017-12-12BEGIN_PUBLIClinyuh
Automated rollback of changelist 172683494 Bug: 30225112 Test: None PiperOrigin-RevId: 178807986 Change-Id: I45978ea4daab71985ac93c3c3a0439fdd8e873d5
2017-12-12BEGIN_PUBLICroldenburg
Automated rollback of changelist 172956409 Bug: 30225112 Test: rollback PiperOrigin-RevId: 178805314 Change-Id: Ia85b10081948b64d4cfc9c9d10d35679df8296ef
2017-12-12Download and play voicemails from server when not locally available.uabdullah
Test: Unit tests PiperOrigin-RevId: 178791213 Change-Id: I9e68c561285988cc1def894f5c7ecf9715ecf6b6
2017-12-12Updated writing of PhoneLookup columns in annotated call log.zachh
We're not going to use the "cached" columns from the system call log any longer, and instead will write them using PhoneLookup. Bug: 34672501 Test: unit PiperOrigin-RevId: 178788155 Change-Id: I9255dd3cb727eef3b45bc05aeb3c6fd6fd513d63
2017-12-11Implement today and older for NUI Voicemail and update MediaPlayerView testsuabdullah
This CL also updates the tests that were TODOs from http://b/70401224 to allow testing the MediaPlayerView SCREENSHOT: Today: http://screen/8KvVtLtHeq4 Older: http://screen/5oskBZPbDR5 Test: Unit tests PiperOrigin-RevId: 178699528 Change-Id: Idab797eff18fd277618938a8a54da350c60b3d54
2017-12-11Play voicemails, update seekbar timer, allow seeking, and maintain state ↵uabdullah
after recycling. This CL adds the support for playing voicemails, changing the play button to pause button when playing the voicemail, updating the seekbar and duration timer when the voicemail is being played. It also adds the support to preserve the state of the media player such that when scrolling and recycling views, when an expanded and playing voicemail is recycled back into view, it's most recent state is shown i.e the duration and the seekbar are upto date. Video: https://drive.google.com/open?id=1CKbLK5-1YDeXBZFiKvuTxoPuFJQ1rbj7 Test: Unit tests PiperOrigin-RevId: 178681663 Change-Id: Ifdd1d945572926bdc7d652aa7a876d3156fc21ce
2017-12-11Don't save UI executor in UiListener.zachh
When an activity is killed by the system, a new UiListener is created and attached, but it doesn't have its executor set. Rather than save it as an instance field, just get the Ui executor when needed, by passing the context to the listen method. Bug: 70510707 Test: unit and manual via "don't keep activities" developer option PiperOrigin-RevId: 178668338 Change-Id: I5360b525377edab5f3a117d1f0f50bf6da6a6f0c
2017-12-11Update Spam module to use Daggermaxwelb
Test: TAP PiperOrigin-RevId: 178650781 Change-Id: I299907ac43d48b984b092433c9b651aadb17c62a
2017-12-08Implemented adding a new favorites contact flow NUI.calderwoodra
This change consists of mainly 3 things: - Update contacts fragment to meet AddFavoriteActivity requirements - Implement AddFavoriteActivity - Passing the contact back to SpeedDialFragment Bug: 36841782 Test: SpeedDialIntegrationTest PiperOrigin-RevId: 178461265 Change-Id: Ib3a13eae311acf6ce10a94df4f2c95b9af120cff
2017-12-08Add "Set up" and "Invite" for video to call log entry actionsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 178434462 Change-Id: I220cb74116aaa5dc3518de0dd20f2cdefda4049b
2017-12-08Fix voicemail populator bug and change emergency call to emergency call back.weijiaxu
The voicemail populator bug was caused by missing Voicemail.PHONE_ACCOUNT_COMPONENT_NAME. Since we are making incoming emergency call by simulator. The name should be emergency call back. Bug: 70246587 Test: On a local device. PiperOrigin-RevId: 178424437 Change-Id: I471b2d19d1d431e2180a1f0481153831a9e51040
2017-12-08In the coalesced call log, replace column NUMBER_CALLS with a new column ↵linyuh
COALESCED_IDS. For a row in the coalesced call log, COALESCED_IDS contains IDs of the corresponding rows in the annotated call log. These IDs will be used to (1) launch CallDetailsActivity or (2) delete the row in the call log UI. Bug: 70218437 Test: CoalescerTest, CoalescedAnnotatedCallLogCursorLoaderTest PiperOrigin-RevId: 178392968 Change-Id: I2d6cd46bec4d47a9e18941b7a019f39403fa76f5
2017-12-07Add Context to Duo interface isEnabledroldenburg
Bug: 70034799 Test: DuoImplTest PiperOrigin-RevId: 178326133 Change-Id: Ie4a0e717d9f1c9c066cb535a44721aeea3c265cc
2017-12-07Migrate cp2 search to use SmartDialerCursorLoader and Phone.CONTENT_FILTER_URI.calderwoodra
Bug: 70336190,70348007 Test: existing PiperOrigin-RevId: 178325355 Change-Id: Ic43beb7a10c5127083ed33e69603b25b2831754f
2017-12-07Implemented PhoneLookupDataSource#onSuccesfulFill.zachh
Required adding applyBatch functionality to PhoneLookupHistoryContentProvider so that the updates can be performed in a transaction. This code was just copied and modified from AnnotatedCallLogContentProvider. Also removed the trigger which limited the size of the PhoneLookupHistory, since we now delete rows from PhoneLookupHistory when the last occurrence of a number is deleted from AnnotatedCallLog. Since AnnotatedCallLog is bounded to 1000 rows PhoneLookupHistory is now indirectly bounded by that as well. Bug: 34672501 Test: unit PiperOrigin-RevId: 178323464 Change-Id: I233163fe70641b0e4b1d4c5c0e8970ad0b4b167d
2017-12-07Fixed compile error in AOSP due to use of guava 23 API.zachh
Futures.submitAsync is V23 and AOSP is currently stuck at V20. This is just a completely non-sensical dummy implementation of DialerFutureSerializer until we can figure out what to do. Test: tap PiperOrigin-RevId: 178323108 Change-Id: I1dc2c8ddfa7ef3e15170543dadefbe4fc2e19226
2017-12-07Add isActivated check to Duo interfaceroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 178292533 Change-Id: I9769a7fbe0edcc42eff99d636334a0c2eaf14779
2017-12-07Made PhoneLookupDataSource implementation async.zachh
We were previously calling get() which can cause deadlocks. Bug: 34672501 Test: existing PiperOrigin-RevId: 178192772 Change-Id: Id9088b12b765307c778d101d847cb1016ea828d1
2017-12-07Renamed PhoneLookup#bulkUpdate to #getMostRecentPhoneLookupInfo.zachh
This is just to more clearly convey what the method does. Bug: 34672501 Test: existing PiperOrigin-RevId: 178188575 Change-Id: Id02f34b1d79346ecd8ca9eebc043fe9b3063264b
2017-12-07Added bindings for ListeningExecutorServices.zachh
Use them where appropriate. Bug: 34672501 Test: existing PiperOrigin-RevId: 178182298 Change-Id: If454225e0d636c7cb14b5af02d46780d7732abf0
2017-12-07Use explicit version constant for AD ceiling.erfanian
Test: tap PiperOrigin-RevId: 178121918 Change-Id: Ia60c844181b63b527ce9753a9bef96d7b7076c40
2017-12-07Add Assisted Dialing Call Details Implementation.erfanian
This includes all of the work specified in the UX layouts, with the exception of the parenthetical country code. Because the canonical mapping of dial prefixes to country codes is not contained in this package, some thought needs to be given on the best way to implement this part of the spec. This change also introduces a fallback error text, in case the client experiences bad data from the call log. Test: new unit tests PiperOrigin-RevId: 178038123 Change-Id: I88eec72a73820e092f24c5f53ee9520a42486ada
2017-12-07Switched CallLogDataSource interface to be Future based.zachh
Bug: 34672501 Test: existing PiperOrigin-RevId: 178038086 Change-Id: I1230992ad04bb4415f5a29bd15802d23dff88012
2017-12-07Add DialpadView's OnPreDrawListener in onFinishInflate() to ensure the ↵linyuh
layout is inflated before adjustments are made. Bug: 69665429 Test: DialpadFragmentIntegrationTest PiperOrigin-RevId: 178031541 Change-Id: I8e8799fd26a151a5357cd0bf4e2d886c802a15a5
2017-12-07Grouping each listener's logic in an inner class in CallDetailsActivity.linyuh
Bug: 70218437 Test: Existing tests PiperOrigin-RevId: 178029820 Change-Id: I60afe7c6d61a61ce4aa2fd2e30fbd5d869072930
2017-12-07Check for null subscription info list in TelecomUtil#getSubscriptionInfo.zachh
The javadoc for the method states that it can return null if the current state is unknown. Bug: 70224613 Test: unit PiperOrigin-RevId: 178020566 Change-Id: I4cd6f76b7c0572d1c9797eba4bf9c3981846468e
2017-12-07Ignore "new" voicemails that are too old for notificationstwyen
Bug: 68049435 Test: CallLogNotificationQueryHelperTest PiperOrigin-RevId: 178016400 Change-Id: I6ddbebc9edce6830966072d42cf05eb21f26c8ac
2017-12-07Display the automatically detected home country in assisted dialing settings.erfanian
Some degenerative cases are considered, like detected home countries that are currently unavailable. Bug: 68775522 Test: unit tests PiperOrigin-RevId: 178007559 Change-Id: Id85d7a2af1aa67757450bbbc80fd3ee67790b21c
2017-12-07Add DATA_USAGE column to the annotated call log.linyuh
Data in this column are copied from the DATA_USAGE column in the system call log (android.provider.CallLog.Calls#DATA_USAGE). Bug: 70218437 Test: AnnotatedCallLogDatabaseHelperTest, SystemCallLogDataSourceTest PiperOrigin-RevId: 177999609 Change-Id: I64d70734e8e85767f1e93a4a22ce2aae6c2168a1
2017-12-07Refactor Assisted Dialing Settings into standalone activity.erfanian
This will enable easier porting back into the framework. Test: existing tests PiperOrigin-RevId: 177960274 Change-Id: I1aa18734758900a93b19f4bb87b7759f6f7ca370
2017-12-07Added PhoneLookupHistoryRecorder.zachh
When a call is added in InCallUi, it fetches the current PhoneLookupInfo for the call and writes it to PhoneLookupHistory. Required updating PhoneLookupHistoryContentProvider#update to use "replace" to (presumably) atomically insert when a row is missing. Bug: 34672501 Test: unit PiperOrigin-RevId: 177896892 Change-Id: I43f9ded240a81156722be816a9635d586de642a1
2017-12-07Added PhoneLookupSelector.zachh
This class is responsible for prioritizing and selecting data from a PhoneLookupInfo object, which contains information from many phone lookup sources. Bug: 34672501 Test: unit PiperOrigin-RevId: 177893924 Change-Id: Ib98a4656fe87141162a7ac53af4a0ad421196046
2017-12-07Removed timestamps from PhoneLookup APIs.zachh
Also added onSuccessfulBulkUpdate method. It is safer for each PhoneLookup to keep track of its own last processed time via shared prefs where the value saved is the actual last processed timestamp from the underlying data. This is because it is difficult or impossible to select a single time that spans lookups due to queries being run and processed at different times. The onSuccessfulBulkUpdate method is provided as a hook for PhoneLookups to persist their shared pref once they know the result of bulkUpdate have been successfully saved. Finally, removed usage of the lastModified timestamp from PhoneLookupHistory in PhoneLookupDataSource since I believe the cases it was originally intended to cover are now handled by populateInserts(). Bug: 34672501 Test: unit PiperOrigin-RevId: 177891586 Change-Id: I072409fc217e4d7e36816548862e8b358aebf165
2017-12-04Add filtration logic to Assisted Dialing Settings.erfanian
The filtration logic will only show countries in the country picker if the feature is enabled for those countries. This will not cover the regressive case where a user has already selected a default option, but then the option is later removed. This behavior is currently undefined. Bug: 69274259 Test: unit tests PiperOrigin-RevId: 177881199 Change-Id: I113f6d25249c42c1bd98383fd6ee0bc6a8c0e615
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 11:21:03 +0000