summaryrefslogtreecommitdiff
path: root/java/com/android/dialer
AgeCommit message (Collapse)Author
2017-12-19Support dual alphabets in smart dial.linyuh
Bug: 30215380,70633239 Test: CompositeSmartDialMapTest, LatinSmartDialMapTest, RussianSmartDialMapTest, SmartDialNameMatcherTest PiperOrigin-RevId: 179580982 Change-Id: I5e4c3e61f0dfdc6ca1e80a93bb985ffec08dd8b0
2017-12-19Ignore deleted voicemail for notificationtwyen
Some voicemail sources keep deleted voicemails in the database for a while. Before this CL if the voicemail is deleted through blocking it will still be returned with CallLogNotificationQueryHelper.getNewVoicemail(), and deleted again. The Deletion triggers a notification update, and the phone enters a loop. If there are other voicemails, the phone will alert every time. In this CL, deleted voicemails are no longer returned with the new voicemail query. Also if All voicemails already has a notification, the user will not be alerted. Bug: 70585368 Test: VisualVoicmailUpdateTaskTest, CallLogNotificationQueryHelperTest PiperOrigin-RevId: 179575512 Change-Id: I352bbf7d0a9d5e2132b5f968e5b5776c9fd518c6
2017-12-18Bubble v2 logging.yueg
Log the following actions: - expand/collapse bubble - return to call - mute/unmute - switch audio route to speaker/bluetooth/wired or earpiece - end call Bug: 67605985 Test: AudioRouteSelectorActivityTest, NewReturnToCallControllerTest PiperOrigin-RevId: 179484647 Change-Id: I4e2ee34f5550382b2e51bab16ce33e9e16caa3b2
2017-12-18Ensure we do not have a null data string before checking for Duoroldenburg
Bug: 70794242 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179480604 Change-Id: Ic53ca21fb7e81390f45b116677df689d3d8fdb67
2017-12-18Added tests for SmartDialNameMatcher.calderwoodra
Bug: 30215380 Test: this cl PiperOrigin-RevId: 179468203 Change-Id: I2996a15135cde48094cb8f430b2fd6d7eeee6ec7
2017-12-18Added tests for latin smart dial map.calderwoodra
Bug: 30215380 Test: this CL PiperOrigin-RevId: 179461976 Change-Id: I05dc2ddde58533ef2caef7ccd3327d36c7bf4e55
2017-12-18Upgrade target SDK version to 27.linyuh
Test: None PiperOrigin-RevId: 179458302 Change-Id: Ic6bfd4abe4c7f51d395488863edc1515754f6b36
2017-12-15Implemented Cp2PhoneLookup#lookup.zachh
Bug: 34672501 Test: unit PiperOrigin-RevId: 179278530 Change-Id: If629aa2c31efad790c8c70e8066dc9a5612d1fc3
2017-12-15Support empty PhoneLookupInfo in Cp2PhoneLookup.zachh
This is necessary to support the case when the user has just upgraded to the new UI and there is no PhoneLookupHistory data yet, or they have cleared their data. Bug: 70570635 Test: unit and manual PiperOrigin-RevId: 179261139 Change-Id: I1e521d2e86bd3f8643c5c0bb537a52c41f1ceb6d
2017-12-15Hide "Invite" and "Set up" Duo buttons for spam and voicemail callsroldenburg
Bug: 70681464 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179224173 Change-Id: I7b70f478898fade5cc5a9bf50581d35f2ce2261f
2017-12-15Implement basic bottom sheet in NUI Voicemail tab.uabdullah
Implement the basic bottom sheet that displays name, location add to contacts, send a message and copy number option. Bug: 64882313,70682949 Test: Unit test, additional unit tests in the next CL that will implement calling from bottom sheet. PiperOrigin-RevId: 179212401 Change-Id: I23281587a0d42cea595e4dc1608f997036e2dbd0
2017-12-15Remove voicemail settings if missing permissiontwyen
Bug: 70282673 Test: DialerSettingsActivityTest PiperOrigin-RevId: 179124385 Change-Id: I9a7f8edc4ae8df44891f551a8aa561bd81922f66
2017-12-14Handle ActivityNotFoundException when starting intent from IntentModuletwyen
Bug: 70515828 Test: IntentModuleTest PiperOrigin-RevId: 179123113 Change-Id: I3cfed7570505c058f3e86054186115db98bb2a8e
2017-12-14Add PreCall step to check permissiontwyen
If CALL_PHONE is missing PreCall will abort immediately and show a toast. Bug: 70565989,70566029 Test: PermissionCheckActionTest PiperOrigin-RevId: 179123070 Change-Id: I0d43c6acd44e77562752c871bed0223b2f787dde
2017-12-14Implement PeopleApiPhoneLookuptwyen
This CL rewrites com.google.android.dialer.reverselookup and uses gRPC instead to perform People API queries. Bug: 70355819 Test: PeopleApiPhoneLookupTest, PeopleApiPHoneLookupInfoTransformerTest PiperOrigin-RevId: 179122466 Change-Id: I769c8b420b9d71b9787d844380b2aceb7ff2c63c
2017-12-14Refactor add to contacts, send a message and copy number modules for bottom ↵uabdullah
sheet These three modules are to be shared between the voicemail and call log bottom sheets. This CL refactors it such that the functions take in generic parameters instead of coalesced annotated call log row so that they can be used by the voicemail tab. Bug: 64882313,70682949 Test: Existing tests PiperOrigin-RevId: 179110882 Change-Id: I2e8edafbf50e51d2299bfbcb95957e40c1b366ec
2017-12-14Use Dagger to get Duo instance in CallLogListItemViewHolderroldenburg
Bug: 70402153 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179106427 Change-Id: I2c82e95022c461d251d3385841640bc31d8aa765
2017-12-14Add input dialog for simulator to use customized number.weijiaxu
Add dialog for user to input whatever numbers with whatever types they want. With this functionality, users can use simulator to test payphone number, private number and etc.. This is a part of feature request in b/70244000. Bug: 70244000 Test: On a local device. PiperOrigin-RevId: 179105057 Change-Id: Ibb386e209d0907d23773cd2c55939b500de4d8f6
2017-12-14Add impressions for Duo related events (install, activate and invite)roldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179085188 Change-Id: I7546cf7e35bbdd3788b03d19627d9a04f612335f
2017-12-14Take into consideration special characters when we do contact match.linyuh
Bug: 30225112 Test: CallLogGroupBuilderTest, PhoneNumberHelperTest, CallerInfoTest, and Manual (see demo) PiperOrigin-RevId: 179080046 Change-Id: I8e451a6c197a6c3df4260e58d0276a5dc5b9515a
2017-12-14Support deleting voicemailsuabdullah
Allows voicemails to be deleted when tapping on the delete icon. Upon tapping the delete button this first deletes/hides it in the recyler view and then subsequently deletes it from the underlying table. Test: Unit test PiperOrigin-RevId: 179055594 Change-Id: I98bb7694d59b7edfcaa4ae162b194c0ef3a0292e
2017-12-14Implemented disambig dialog for new speed dial fragment.calderwoodra
This change implements the logic to build the disambig dialog and display the relevant information. Future CLs will: - Implement the logic for favoriting a communication avenue - Polish the UI Bug: 36841782 Test: DisambigDialogTest PiperOrigin-RevId: 179012593 Change-Id: I4294f4ae2a475b1e560eabd424e54a829c0d7829
2017-12-14Support normalization of numbers in Cp2PhoneLookup.zachh
Bug: 34672501 Test: unit PiperOrigin-RevId: 179012381 Change-Id: Icb78c73e243702a71f1a48692151b696ae2ac95f
2017-12-13Take user to install Duo if they tap "Set up" without the app installedroldenburg
Bug: 70034799 Test: DuoImplTest, GoogleCallLogAdapterTest PiperOrigin-RevId: 178981398 Change-Id: Id524dfe61bf3a2358d863dd8d5f7c6c083b8063c
2017-12-13Add reloadReachabilities to Duo interfaceroldenburg
Bug: 70034799 Test: DuoImplTest, GoogleDialtactsActivityTest PiperOrigin-RevId: 178971440 Change-Id: Ib624bd340fbeac11474db198763ae77eddb03ae3
2017-12-13Integrate CallDetailsActivity with the new call log UI.linyuh
Bug: 70218437 Test: CallDetailsActivityTest, CallDetailsCursorLoaderTest, ModulesTest PiperOrigin-RevId: 178918820 Change-Id: Ib8034190550e8ca8e6e7fd9ce521bfadc73e834f
2017-12-12Refactor CallerInfo and ContactInfoHelper to improve readability.linyuh
Test: Existing tests PiperOrigin-RevId: 178862915 Change-Id: I2dd58db10d546c062b0f43dad80f74d588cb65e1
2017-12-12Move TelecomCallUtil to com.android.dialertwyen
Since PhoneLookup exposes Call, more common access to the utility is required. Bug: 70355819 Test: TelecomCallUtilTest PiperOrigin-RevId: 178847628 Change-Id: I6cf55ad4e3566596b7b2e8cffb5a1614e6640a8b
2017-12-12Cleanup. Changing voicemail_transcription_enabled to ↵mdooley
voicemail_transcription_available Follow the convention that features allowed by server configuration flags use the word 'available' and when a feature is allowed by the user via settings then use the word 'enabled' Bug: 37340510 Test: manual and updated unit tests PiperOrigin-RevId: 178831467 Change-Id: I5691fd7db45a70908d32cdac2b049fe76e6a0680
2017-12-12BEGIN_PUBLIClinyuh
Automated rollback of changelist 172505648 Bug: 30225112 Test: None PiperOrigin-RevId: 178815682 Change-Id: I1fe1eef49d587314d32e7125f5106769b3099ad3
2017-12-12BEGIN_PUBLIClinyuh
Automated rollback of changelist 172683494 Bug: 30225112 Test: None PiperOrigin-RevId: 178807986 Change-Id: I45978ea4daab71985ac93c3c3a0439fdd8e873d5
2017-12-12BEGIN_PUBLICroldenburg
Automated rollback of changelist 172956409 Bug: 30225112 Test: rollback PiperOrigin-RevId: 178805314 Change-Id: Ia85b10081948b64d4cfc9c9d10d35679df8296ef
2017-12-12Download and play voicemails from server when not locally available.uabdullah
Test: Unit tests PiperOrigin-RevId: 178791213 Change-Id: I9e68c561285988cc1def894f5c7ecf9715ecf6b6
2017-12-12Updated writing of PhoneLookup columns in annotated call log.zachh
We're not going to use the "cached" columns from the system call log any longer, and instead will write them using PhoneLookup. Bug: 34672501 Test: unit PiperOrigin-RevId: 178788155 Change-Id: I9255dd3cb727eef3b45bc05aeb3c6fd6fd513d63
2017-12-11Implement today and older for NUI Voicemail and update MediaPlayerView testsuabdullah
This CL also updates the tests that were TODOs from http://b/70401224 to allow testing the MediaPlayerView SCREENSHOT: Today: http://screen/8KvVtLtHeq4 Older: http://screen/5oskBZPbDR5 Test: Unit tests PiperOrigin-RevId: 178699528 Change-Id: Idab797eff18fd277618938a8a54da350c60b3d54
2017-12-11Play voicemails, update seekbar timer, allow seeking, and maintain state ↵uabdullah
after recycling. This CL adds the support for playing voicemails, changing the play button to pause button when playing the voicemail, updating the seekbar and duration timer when the voicemail is being played. It also adds the support to preserve the state of the media player such that when scrolling and recycling views, when an expanded and playing voicemail is recycled back into view, it's most recent state is shown i.e the duration and the seekbar are upto date. Video: https://drive.google.com/open?id=1CKbLK5-1YDeXBZFiKvuTxoPuFJQ1rbj7 Test: Unit tests PiperOrigin-RevId: 178681663 Change-Id: Ifdd1d945572926bdc7d652aa7a876d3156fc21ce
2017-12-11Don't save UI executor in UiListener.zachh
When an activity is killed by the system, a new UiListener is created and attached, but it doesn't have its executor set. Rather than save it as an instance field, just get the Ui executor when needed, by passing the context to the listen method. Bug: 70510707 Test: unit and manual via "don't keep activities" developer option PiperOrigin-RevId: 178668338 Change-Id: I5360b525377edab5f3a117d1f0f50bf6da6a6f0c
2017-12-11Update Spam module to use Daggermaxwelb
Test: TAP PiperOrigin-RevId: 178650781 Change-Id: I299907ac43d48b984b092433c9b651aadb17c62a
2017-12-08Implemented adding a new favorites contact flow NUI.calderwoodra
This change consists of mainly 3 things: - Update contacts fragment to meet AddFavoriteActivity requirements - Implement AddFavoriteActivity - Passing the contact back to SpeedDialFragment Bug: 36841782 Test: SpeedDialIntegrationTest PiperOrigin-RevId: 178461265 Change-Id: Ib3a13eae311acf6ce10a94df4f2c95b9af120cff
2017-12-08Add "Set up" and "Invite" for video to call log entry actionsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 178434462 Change-Id: I220cb74116aaa5dc3518de0dd20f2cdefda4049b
2017-12-08Fix voicemail populator bug and change emergency call to emergency call back.weijiaxu
The voicemail populator bug was caused by missing Voicemail.PHONE_ACCOUNT_COMPONENT_NAME. Since we are making incoming emergency call by simulator. The name should be emergency call back. Bug: 70246587 Test: On a local device. PiperOrigin-RevId: 178424437 Change-Id: I471b2d19d1d431e2180a1f0481153831a9e51040
2017-12-08In the coalesced call log, replace column NUMBER_CALLS with a new column ↵linyuh
COALESCED_IDS. For a row in the coalesced call log, COALESCED_IDS contains IDs of the corresponding rows in the annotated call log. These IDs will be used to (1) launch CallDetailsActivity or (2) delete the row in the call log UI. Bug: 70218437 Test: CoalescerTest, CoalescedAnnotatedCallLogCursorLoaderTest PiperOrigin-RevId: 178392968 Change-Id: I2d6cd46bec4d47a9e18941b7a019f39403fa76f5
2017-12-07Add Context to Duo interface isEnabledroldenburg
Bug: 70034799 Test: DuoImplTest PiperOrigin-RevId: 178326133 Change-Id: Ie4a0e717d9f1c9c066cb535a44721aeea3c265cc
2017-12-07Migrate cp2 search to use SmartDialerCursorLoader and Phone.CONTENT_FILTER_URI.calderwoodra
Bug: 70336190,70348007 Test: existing PiperOrigin-RevId: 178325355 Change-Id: Ic43beb7a10c5127083ed33e69603b25b2831754f
2017-12-07Implemented PhoneLookupDataSource#onSuccesfulFill.zachh
Required adding applyBatch functionality to PhoneLookupHistoryContentProvider so that the updates can be performed in a transaction. This code was just copied and modified from AnnotatedCallLogContentProvider. Also removed the trigger which limited the size of the PhoneLookupHistory, since we now delete rows from PhoneLookupHistory when the last occurrence of a number is deleted from AnnotatedCallLog. Since AnnotatedCallLog is bounded to 1000 rows PhoneLookupHistory is now indirectly bounded by that as well. Bug: 34672501 Test: unit PiperOrigin-RevId: 178323464 Change-Id: I233163fe70641b0e4b1d4c5c0e8970ad0b4b167d
2017-12-07Fixed compile error in AOSP due to use of guava 23 API.zachh
Futures.submitAsync is V23 and AOSP is currently stuck at V20. This is just a completely non-sensical dummy implementation of DialerFutureSerializer until we can figure out what to do. Test: tap PiperOrigin-RevId: 178323108 Change-Id: I1dc2c8ddfa7ef3e15170543dadefbe4fc2e19226
2017-12-07Add isActivated check to Duo interfaceroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 178292533 Change-Id: I9769a7fbe0edcc42eff99d636334a0c2eaf14779
2017-12-07Made PhoneLookupDataSource implementation async.zachh
We were previously calling get() which can cause deadlocks. Bug: 34672501 Test: existing PiperOrigin-RevId: 178192772 Change-Id: Id9088b12b765307c778d101d847cb1016ea828d1
2017-12-07Renamed PhoneLookup#bulkUpdate to #getMostRecentPhoneLookupInfo.zachh
This is just to more clearly convey what the method does. Bug: 34672501 Test: existing PiperOrigin-RevId: 178188575 Change-Id: Id02f34b1d79346ecd8ca9eebc043fe9b3063264b
2017-12-07Added bindings for ListeningExecutorServices.zachh
Use them where appropriate. Bug: 34672501 Test: existing PiperOrigin-RevId: 178182298 Change-Id: If454225e0d636c7cb14b5af02d46780d7732abf0
2017-12-07Use explicit version constant for AD ceiling.erfanian
Test: tap PiperOrigin-RevId: 178121918 Change-Id: Ia60c844181b63b527ce9753a9bef96d7b7076c40
2017-12-07Add Assisted Dialing Call Details Implementation.erfanian
This includes all of the work specified in the UX layouts, with the exception of the parenthetical country code. Because the canonical mapping of dial prefixes to country codes is not contained in this package, some thought needs to be given on the best way to implement this part of the spec. This change also introduces a fallback error text, in case the client experiences bad data from the call log. Test: new unit tests PiperOrigin-RevId: 178038123 Change-Id: I88eec72a73820e092f24c5f53ee9520a42486ada
2017-12-07Switched CallLogDataSource interface to be Future based.zachh
Bug: 34672501 Test: existing PiperOrigin-RevId: 178038086 Change-Id: I1230992ad04bb4415f5a29bd15802d23dff88012
2017-12-07Add DialpadView's OnPreDrawListener in onFinishInflate() to ensure the ↵linyuh
layout is inflated before adjustments are made. Bug: 69665429 Test: DialpadFragmentIntegrationTest PiperOrigin-RevId: 178031541 Change-Id: I8e8799fd26a151a5357cd0bf4e2d886c802a15a5
2017-12-07Grouping each listener's logic in an inner class in CallDetailsActivity.linyuh
Bug: 70218437 Test: Existing tests PiperOrigin-RevId: 178029820 Change-Id: I60afe7c6d61a61ce4aa2fd2e30fbd5d869072930
2017-12-07Check for null subscription info list in TelecomUtil#getSubscriptionInfo.zachh
The javadoc for the method states that it can return null if the current state is unknown. Bug: 70224613 Test: unit PiperOrigin-RevId: 178020566 Change-Id: I4cd6f76b7c0572d1c9797eba4bf9c3981846468e
2017-12-07Ignore "new" voicemails that are too old for notificationstwyen
Bug: 68049435 Test: CallLogNotificationQueryHelperTest PiperOrigin-RevId: 178016400 Change-Id: I6ddbebc9edce6830966072d42cf05eb21f26c8ac
2017-12-07Display the automatically detected home country in assisted dialing settings.erfanian
Some degenerative cases are considered, like detected home countries that are currently unavailable. Bug: 68775522 Test: unit tests PiperOrigin-RevId: 178007559 Change-Id: Id85d7a2af1aa67757450bbbc80fd3ee67790b21c
2017-12-07Add DATA_USAGE column to the annotated call log.linyuh
Data in this column are copied from the DATA_USAGE column in the system call log (android.provider.CallLog.Calls#DATA_USAGE). Bug: 70218437 Test: AnnotatedCallLogDatabaseHelperTest, SystemCallLogDataSourceTest PiperOrigin-RevId: 177999609 Change-Id: I64d70734e8e85767f1e93a4a22ce2aae6c2168a1
2017-12-07Refactor Assisted Dialing Settings into standalone activity.erfanian
This will enable easier porting back into the framework. Test: existing tests PiperOrigin-RevId: 177960274 Change-Id: I1aa18734758900a93b19f4bb87b7759f6f7ca370
2017-12-07Added PhoneLookupHistoryRecorder.zachh
When a call is added in InCallUi, it fetches the current PhoneLookupInfo for the call and writes it to PhoneLookupHistory. Required updating PhoneLookupHistoryContentProvider#update to use "replace" to (presumably) atomically insert when a row is missing. Bug: 34672501 Test: unit PiperOrigin-RevId: 177896892 Change-Id: I43f9ded240a81156722be816a9635d586de642a1
2017-12-07Added PhoneLookupSelector.zachh
This class is responsible for prioritizing and selecting data from a PhoneLookupInfo object, which contains information from many phone lookup sources. Bug: 34672501 Test: unit PiperOrigin-RevId: 177893924 Change-Id: Ib98a4656fe87141162a7ac53af4a0ad421196046
2017-12-07Removed timestamps from PhoneLookup APIs.zachh
Also added onSuccessfulBulkUpdate method. It is safer for each PhoneLookup to keep track of its own last processed time via shared prefs where the value saved is the actual last processed timestamp from the underlying data. This is because it is difficult or impossible to select a single time that spans lookups due to queries being run and processed at different times. The onSuccessfulBulkUpdate method is provided as a hook for PhoneLookups to persist their shared pref once they know the result of bulkUpdate have been successfully saved. Finally, removed usage of the lastModified timestamp from PhoneLookupHistory in PhoneLookupDataSource since I believe the cases it was originally intended to cover are now handled by populateInserts(). Bug: 34672501 Test: unit PiperOrigin-RevId: 177891586 Change-Id: I072409fc217e4d7e36816548862e8b358aebf165
2017-12-04Add filtration logic to Assisted Dialing Settings.erfanian
The filtration logic will only show countries in the country picker if the feature is enabled for those countries. This will not cover the regressive case where a user has already selected a default option, but then the option is later removed. This behavior is currently undefined. Bug: 69274259 Test: unit tests PiperOrigin-RevId: 177881199 Change-Id: I113f6d25249c42c1bd98383fd6ee0bc6a8c0e615
2017-11-30Implemented new favorites list UI.calderwoodra
Bug: 36841782 Test: implemented PiperOrigin-RevId: 177516412 Change-Id: If9478ce22c10fd17e352d5fdcc2c0bef5e14a6d8
2017-11-30Action bar is no longer visible in dialpad search after configuartion change.calderwoodra
If a user, for example, opened dialpad search then entered multiwindow mode, the actionbar would be visible and search results maligned. This change corrects that by updating it's state once possible. Test: manual PiperOrigin-RevId: 177497979 Change-Id: I41d4910b5bb92e29623960e7d4741a9a961e5b9e
2017-11-30*** Reason for rollback ***roldenburg
Copybara is fixed for AOSP export Bug: 68665330 Test: rollback PiperOrigin-RevId: 177480870 Change-Id: I0ba38e213bb840436fa6dafc4af0a79019ee93f4
2017-11-29Implemented fill for PhoneLookupDataSource.zachh
Rewrote FakePhoneLookup to be more realistic. Bug: 34672501 Test: unit PiperOrigin-RevId: 177376374 Change-Id: Ifcd52b16b7046f39d1bfc0e8b8e76452a9daadd2
2017-11-29Search contacts now update when there are changes to the cp2 db.calderwoodra
Since we close the original cursor we queried in the cursor loader, we need to assign a new content observer to the cursor we build so that our search results update when there are changes to the contacts db. Bug: 63830179 Test: manual PiperOrigin-RevId: 177368459 Change-Id: I025ea70334265cb2fdc651ed7ea046b039738e94
2017-11-29Bump API ceiling for Assisted Dialing.erfanian
Bug: 69857502 Test: TAP PiperOrigin-RevId: 177367228 Change-Id: Id79546672fa8bf3bf85bbe569ef638970b1365d8
2017-11-29Add flag to control default assisted dialing state during precall flow.erfanian
Currently, the only other client that is initiating calls is Contacts, and we consider that to be a non-idle-dial. Bug: 69860859 Test: existing unit tests PiperOrigin-RevId: 177367226 Change-Id: I22de38dc973f5a1eecfe42833110690744c317fd
2017-11-29Move country constraint logic into standalone class.erfanian
In a subsequent change, the assisted dialing settings will be able to use the parsing logic to filter the available countries listed in the settings. Bug: 69274259 Test: existing tests PiperOrigin-RevId: 177338864 Change-Id: I8ef76874d5f6d885b415174371225b738cc68716
2017-11-29Adjust strings for select SIM dialogtwyen
Test: N/A PiperOrigin-RevId: 177336359 Change-Id: Icec2eacef55ea6c1b3aad00fe10cde6284c89e25
2017-11-29Delete voicemails when disabling visual voicemailmdooley
For privacy reasons we now delete all voicemails and transcriptions when the user disables visual voicemail, (after confirming that they want to do this via a dialog). Note: we only delete voicemails whose source package is the google dialer. Note: the voicemails will be re-downloaded and re-transcribed if the user re-enables visual voicemail Bug: 69323147 Test: manual and unit test PiperOrigin-RevId: 177315139 Change-Id: Ie04496dc5960b485794733fbf74f7f704e806023
2017-11-29Format number for SIM selectiontwyen
Bug: 69812286 Test: PhoneNumberHelperTest PiperOrigin-RevId: 177227451 Change-Id: I6cf53e50d17860f4374cbd9a94451bc0731905a4
2017-11-29Disable phone number formatting on the dialpad when making domestic call to ↵linyuh
Argentina mobile numbers. Bug: 30224215 Test: DialerPhoneNumberFormattingTextWatcherTest, DialpadFragmentIntegrationTest PiperOrigin-RevId: 177218942 Change-Id: Id6eaaad2f6d81e591d59a1d8444f45fb06f3f8d5
2017-11-29Prevent PreCallActivity from showing in lockscreen if it is not started in ↵twyen
the lockscreen Bug: 69812359 Test: PreCallActivityTest PiperOrigin-RevId: 177193665 Change-Id: Ic61819b8456ee22c01228d6be2255b3f2c1e418a
2017-11-29Expose user home country code as public method in Mediator Interface.erfanian
This will be used in a subsequent change to show the user the default/predetected country code in the assisted dialing settings. Bug: 68775522 Test: unit tests PiperOrigin-RevId: 177168946 Change-Id: Ic738a6ddde8766962a725668f6db5056ab0bcafd
2017-11-29Update assisted dialing setting text.erfanian
Bug: 69562852 Test: none PiperOrigin-RevId: 177165337 Change-Id: I297faa26d778ec39f2365e84e90398e7ab49f353
2017-11-29Contact list no longer jumps to the top when the cp2 database updates.calderwoodra
The contacts fragment recycler view was rebuilding the adapter and layout manager each time the Contacts.CONTENT_URI observered a content change. Now we simply update the adapter's cursor and notifyDataSetChanged. This keeps the recycler view in place through all changes (inserts, deletes and updates). This change also fixes another bug replated to contacts fragment not refreshing when the contacts permission was granted in another part of the UI. Bug: 64044576,67781478,68179085 Test: manual PiperOrigin-RevId: 177106761 Change-Id: Ib6a929efb047001d681cb008c3ede69860146836
2017-11-29Adjust strings for select SIM dialogtwyen
Test: N/A PiperOrigin-RevId: 177075957 Change-Id: Idf4546c57aba72470e07614d2a20d828da8ee08d
2017-11-29Add impressions for dual sim featurestwyen
Bug: 69618691 Test: CallingAccountSelectorTest PiperOrigin-RevId: 177062349 Change-Id: I4bc9098d06c541b607cca293269cf3489077b6c2
2017-11-28Adding transcription rating feedbackmdooley
Allow users who have agreed to donate their voicemails to also provide transcription quality feedback. screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIajVtdFN3Y0Qydmx2NXJYN2N3OVA3N0h5UEdR Bug: 68712148 Test: manual and new unit tests PiperOrigin-RevId: 176774942 Change-Id: I08b9afbbefaedfb0de5199038a1d2769bd983855
2017-11-22Fix the crash caused by DialpadView's OnPreDrawListener.linyuh
OnPreDrawListener can be triggered AFTER a device orientation change but BEFORE DialpadView's onDetachedFromWindow() and onFinishInflate() are called, i.e., the listener will attempt to adjust the layout before it is inflated, which results in a crash. This fix is to remove the listener after all keys are adjusted for the first time since no more adjustments will be needed during the rest of DialpadView's lifecycle. Bug: 69665429 Test: DialpadFragmentIntegrationTest PiperOrigin-RevId: 176718488 Change-Id: Iff8a4108c73054a9e76725ef85e2559b90fe5f3e
2017-11-22Prevent SIM selection and change SIM from showing when there are active callstwyen
Most devices are DSDS (dual SIM dual standby) which only one SIM can have active calls at a time. Telecom will ignore the phone account handle and use the current active SIM. The SIM selection dialog has no effect, and the change SIM button will just redial with the same SIM. Bug: 69417430 Test: CallingAccountSelectorTest, CallButtonPresenterTest PiperOrigin-RevId: 176718021 Change-Id: I231cfeaa5ff77c29cdaf8e0865d096c85cfb7fc4
2017-11-22Fix showing CallingAccountSelector in lock screentwyen
FLAG_SHOW_WHEN_LOCKED is added to PreCallActivity so it can be launched in lockscreen. PreCallCoordinator now grabs new instances of PreCallActions onResume so the state can be flushed. If it is reused states like PendingAction might be used after it is discarded. Added null check before discarding fragment because it might not be created yet due to background query. Bug: 69570769 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176714225 Change-Id: I8b09441bd1cdb8df835978a1d82b53a3d3d056e0
2017-11-22Automated rollback of changelist 176587256twyen
Bug: 69570769 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176706378 Change-Id: I50da0d2dd40a83ae6c1189fed2693368369849d3
2017-11-22Check Contacts support for preferred SIMtwyen
Preferred SIM can only be enabled when both dialer and the system contact app supports it. This CL checks if the app for ACTION_QUICK_CONTACT has the metadata supports_per_number_preferred_account. Also added a flag to disable the whole preferred SIM feature. Bug: 69638458 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176687062 Change-Id: Id00debe2393068a422907a9eff2ac4ef0fcf6f8e
2017-11-22Add SpamJobType for all spam job IDs.wangqi
Bug: 69556012 Test: SpamJobSchedulerTest PiperOrigin-RevId: 176683042 Change-Id: I2807510e3c511c1672ed2c49117ad03b92c4cee5
2017-11-22Bubble v2 UI changes.yueg
Including: - Use exit-to-app icon instead of fullscreen icon for back-to-call button - Use ripple for first button since it needs top-rounded background - Change red hang-up button color and grey icon and text color - Change some dimensions Bug: 67605985 Test: manual PiperOrigin-RevId: 176678427 Change-Id: I3f7836d832f7130f82d7f3764fb392807f3fab9a
2017-11-22Allow deleting a call log entry in the call log UI and the call details UI.linyuh
In the call log UI, an entry can be deleted by selecting "delete" in its context menu. In the call details UI, a "delete" button is added at the bottom. The "delete" icon at the top right of the call details UI is removed. Public-Origin-Change-Id: Iabe1310fb9a97a277cf482a3fd61ffccbec125fe Signed-off-by: Linyu He <linyuh@google.com> Author: Masafumi Miya <masafumi.miya@sony.com> Bug: 38188896 Test: CallLogActivityIntegrationTest, CallDetailsActivityIntegrationTest PiperOrigin-RevId: 176677167 Change-Id: I2e31cd112efdfb83393f5e68ce016dcf36ac4858
2017-11-22Fix showing CallingAccountSelector in lock screentwyen
android:showWhenLocked and FLAG_SHOW_WHEN_LOCKED is added to PreCallActivity so it can be launched in lockscreen. PreCallCoordinator now grabs new instances of PreCallActions onResume so the state can be flushed. If it is reused states like PendingAction might be used after it is discarded. Added null check before discarding fragment because it might not be created yet due to background query. Bug: 69570769 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176587256 Change-Id: Iaa7145e860136e9177f568e2c84461ed5efa12a1
2017-11-21Adding call feedback mechanismAndroid Dialer
Test: No impact on existing functionalities PiperOrigin-RevId: 176562444 Change-Id: I209379dde3e920a27d6e735c8494647154e40e5a
2017-11-21Require N for preferred SIM querytwyen
PhoneLookup.DATA_ID is only available after N. The fallback database should address this in a future CL. Bug: 69420158 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176534281 Change-Id: I51ae1705fce6d7d4138b41fbd00d131447e49786
2017-11-21Reduced jank when placing a call from search UI.calderwoodra
I accidently made the search/dialtacts UI TOO performant and everything was happening too quickly. Postponed closing the dialpad and exiting search until onPause, but immediately close the keyboard so it isn't visible over the in call ui. Bug: 69313203,68857994 Test: see video PiperOrigin-RevId: 176531801 Change-Id: I52729c451d46ad00ac87c47f189134694554d33a
2017-11-21Nearby places location permission request is now in a card view.calderwoodra
Bug: 68272141 Test: n/a PiperOrigin-RevId: 176531675 Change-Id: Ia6cc29c4285ebe280d23a81f91007a02a65855b3
2017-11-20Quick fix recursively importing.weijiaxu
Test: On a local device. PiperOrigin-RevId: 176443649 Change-Id: I73982924baf6ce0e947137766ec0038decd716e5
2017-11-20Add impression to track when users explicitly disable assisted dialing.erfanian
Test: new unit tests PiperOrigin-RevId: 176438950 Change-Id: Ic0747302170593b91da4148029396c36ab070c6e
2017-11-20Initialize executors before updating change PIN statetwyen
When the activity is launched it might immediately attempt to verify the stored pin, which happened before the executor is initialized Bug: 69179171 Test: N/A - legacy code, refactoring required PiperOrigin-RevId: 176433263 Change-Id: I8202a760dbfc7759e128ef31d477510526d0bee7
2017-11-20Implement SIM selection dialogtwyen
Bug: 64216442,64214592,64213352 Test: N/A PiperOrigin-RevId: 176424724 Change-Id: I1709156098a14ac3bd35d98b913e7b881fcd9b2b