Age | Commit message (Collapse) | Author |
|
QA noticed that the error message 'Transcription not available. Unsupported language'
didnt fit on one line and got truncated. This cl removes the single line constraint
for that text field.
Bug: 67384287
Test: manual
PiperOrigin-RevId: 171316291
Change-Id: I41f98fe207ebeca900bf4fd51cd4e95e20981a9a
|
|
Documentation clearly states that cursor loaders will close all cursors for
you. This CL removes all calls to cursor.close() after onLoaderFinished is
called.
Bug: 66902052
Test: n/a
PiperOrigin-RevId: 171087171
Change-Id: If771fbea52e03ffdd3652af2699c393cc7424de3
|
|
As per the material desing spec [1], floating action buttons should be 56dp
in size normally and 40dp on small displays (like in multiwindow mode) while
always maintaing a 24dp image size.
screenshot (mw): http://screen/URJrg1WoQfn
screenshot (normal): http://screen/TUU65D1sSHp
[1]
https://material.io/guidelines/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button
Bug: 67312080
Test: n/a
PiperOrigin-RevId: 171086404
Change-Id: Ib213cf3c94dbb0f0df5b21f23f3022a8f53d80a8
|
|
Bug: 65559651
Test: MissedCallNotifierTest
PiperOrigin-RevId: 171070314
Change-Id: I57e6e0b55a07430daad944473ae4eb427d56ee96
|
|
Since lists are passed by reference, if the directory list passed into
RemoteContactsCursorLoader was modified before #lodInBackground was called, the
directory list would change and crash when compared to the list of cursors.
Since directory lists are small, there shouldn't be any memory issues with
copying the list.
Additionally, this CL adds some logging to the new Search Fragment.
Bug: 66902071,66902062
Test: RemoteContactsCursorLoaderTest
PiperOrigin-RevId: 171063035
Change-Id: Id2faa542805da4167fc7045e6fbe71d02c644ab6
|
|
and using non-breaking space in dialer TOS 'learn more' link.
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuIV3BWWmxSTTlJQ2dBTnR2UHRGWjZJRlFQUGo0
https://drive.google.com/open?id=0B9o_KvtLkcuIOEJjanVhMXlfck81aU02Y0I2MkVtWFNOVGp3
Bug: 67379747
Test: manual and updated unit tests
PiperOrigin-RevId: 171025914
Change-Id: I9c4bfd899805681492a5063ee1bc674bbb98f630
|
|
last 3.
This is according to the latest PRD:
https://docs.google.com/document/d/1FLoQ6kNYL-QKplbniJAIUCHku87S9eYuYPs6IXe-U78
Also cleaned up warnings in CallLogQueryHandler.
Screenshot: https://screenshot.googleplex.com/Z7p4BRVpLpE
Bug: 34672501
Test: unit
PiperOrigin-RevId: 170941445
Change-Id: Ibf79b70eda3837ea46d365729aaed0a87961e42b
|
|
Use startForeground()/stopForeground() for posting notification instead of NotificationManager.notify()/cancel(). It makes incoming and ongoing notification foreground and not able to snooze. It also colorize ongoing call notification for Android O, since we already setColorized().
Use setPriority(Notification.PRIORITY_MAX) for pre-O, and NotificationManager.IMPORTANCE_MAX for O. It makes incoming and ongoing notification stay on the top.
Test: StatusBarNotifierTest*2
PiperOrigin-RevId: 170924163
Change-Id: Iab1415b0161a4623a1ccf52d3948f32b6f93eeb2
|
|
The data here can be used to drive the in call ui
by providing key information about the transformation
process.
Bug: 63995261
Test: unit tests
PiperOrigin-RevId: 170885399
Change-Id: I525aa1f987b3dfd9548ef8656d97efa7fce2b692
|
|
Screenshot:http://screen/dwihQaaeaQC
Bug: 64882313,33006245
Test: NewVoicemailCallLogViewHolderTest, NewVoicemailCallLogAdapterTest
PiperOrigin-RevId: 170542645
Change-Id: I00c145c5856c3f1f53d12b0fd7bd80c63bb8a094
|
|
This avoid some spurious strict mode violations.
Test: observed no strict mode notification launching google dialer
PiperOrigin-RevId: 170505918
Change-Id: Ie48671dcd306ea18b041a0bd7989b419bab903f5
|
|
Project Fi devices crash when declining voicemail TOS because
of an invalid PhoneAccountHandle. This cl fixes the problem by
not showing the TOS when the PhoneAccountHandle is not valid.
Bug: 67001886,66969838
Test: manual and updated unit tests
PiperOrigin-RevId: 170418189
Change-Id: I36dd0b10ab7468b0937a81f3f0427a4d64091955
|
|
The problem is that InCallActivityCommon#onStop will try to commit any fragment which will crash.
This change also fix a bug that simulatorRemoteVideo is not stopped after hanging up.
Bug: 67045513
Test: manual
PiperOrigin-RevId: 170380589
Change-Id: I25e0f43141eaa573189f4d9c0109fd2689c10374
|
|
Previously post call notifications are inserted by launching CallLogNotificationService. This usually works because the call has just broght dialer to the foreground and there are some grace period before the app is consider background again. However if the post call message comes later background check will crash the app.
This CL made the broadcast receiver async and complete the insertion in a worker since it wouldn't take more than a few seconds.
Bug: 66444859
Test: unit tests
PiperOrigin-RevId: 170275928
Change-Id: I0ff396b51a173f2e4bab0bca6b6e5c5b56ab62da
|
|
This implements the core assisted dialing logic specified in
go/assisted-dialing-dd-v1
Bug: 36414469,63995261
Test: new unit tests
PiperOrigin-RevId: 170232634
Change-Id: I3b668c3a0e9fb5398eca4614548c8141b200e70e
|
|
-bypassed violations are no longer logged in AospDialer
The default implementation will use system strict mode and crash on bugfood build same as before.
Bug: 66003745
Test: manual
PiperOrigin-RevId: 170214128
Change-Id: Iab630f19499e90b15eb0b7f0707b4a70c7d81fbe
|
|
This will allow us to tune the polling rate.
Bug: 66966157
Test: none
PiperOrigin-RevId: 170210987
Change-Id: I6ef204acc6e0d43a3ada524511866d4a629fe1e2
|
|
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIdGY1RnVXM3JuMXB4OVRVOFhrSU9qRDR6c2pj
Bug: 37340510
Test: manual
PiperOrigin-RevId: 170131627
Change-Id: Ib022bba44e24675082299132a5965fbcb58257fa
|
|
Test: N/A
PiperOrigin-RevId: 170130892
Change-Id: Ifc59f239043c66eaa8341fe34c080dad08454236
|
|
Screenshot:http://screen/RK42CXn5uB6
Bug: 64882313,33006245
Test: VoicemailFragmentTest, NewVoicemailCallLogAdapterTest, NewVoicemailCallLogViewHolderTest
PiperOrigin-RevId: 170129401
Change-Id: Ib82357763bd9cf9f215804225be009650402fe84
|
|
On M the framework does not retain the hidden state of a fragment properly when restoring it from a savedInstanceState. This appears to be fixed in N, but the exact cause and fix are unknown. This behavior will cause a fragment previously hidden coming back as visible when the device is rotated or going through any save/restore life cycle.
Previously whether to show the dialpad is stored in a separate flag, and the dialpad will be hidden when it is reattached. This was regresed in cl/169614750
In this CL, if the saved mIsDialpadShown indicate the dialpad should not be shown, but the dialpad is not hidden, it will be hidden on resume.
Bug: 66893723
Test: DialtactsActivityTest
PiperOrigin-RevId: 170124711
Change-Id: I6f8ed21fb970d6f688cb75f854442115a6803f3c
|
|
These are old code and considered to be grandfathered in.
Cleaned up some warnings in GoogleLocationSettingHelper.
Bug: 66498656
Test: none
PiperOrigin-RevId: 170090310
Change-Id: I2c43564af751eb5f431a395d75afa5ce126b5d18
|
|
after rotation
mCurrentPage is set onResume before the fragment is attached. In this CL, mCurrentPage is still used for page change, but for resume and pause, it is detected directly in CallLogFragment using getUserVisibleHint()
Bug: 65161134
Test: manual - change call volume after rotation, check ToS FAB not visible after rotation. CallLogFragment is not testable.
PiperOrigin-RevId: 169984576
Change-Id: I870cbe3b83e38ac2cb505193309ab4f8e75a859f
|
|
The about in settings is removed in google dialer, it is accessed through the dialtacts overflow "Help & feedback" instead:
https://screenshot.googleplex.com/9L1kdQz6c2B
https://screenshot.googleplex.com/FqqdG6X9JTR
Note that help articles has not been migrated at this moment.
Features in the original about is placed in the overflow
https://screenshot.googleplex.com/OmCVPqwGBM9
Version info is stock google help
https://screenshot.googleplex.com/EdveVnXUSML
Privacy policy/Terms of service opens the browser to the link we had before
Open source license opens the same license activity in about.
Bug: 34872689
Test: manual
PiperOrigin-RevId: 169953610
Change-Id: Ib1c25ddecbf28293b447112cb280a8f9788692d3
|
|
Change verizon's ToS title to use the string 'visual voicemail'
This change seems a bit strange since the verizon legal text uses the string 'Visual Voice Mail', but the title uses 'visual voice mail'
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuIR1lmaUF4OXk1SnFLdS1fbFpfMlFieWlTQ25v
https://drive.google.com/open?id=0B9o_KvtLkcuIRURWd0hhYjc4NUdKQ1hzM2RIcG5fSmlHcGhJ
Bug: 37340510
Test: update unit tests
PiperOrigin-RevId: 169933539
Change-Id: Idba526293604b7a27083a91b86825ef66ce23bcd
|
|
The problem was that the same notification id was being used by
both VisualVoicemailNotifier and MissedCallNotifier, causing the
voicemail notification update code to filter out missed call notifications
instead of ignoring them.
Bug: 66168999
Test: manual and verified existing unit tests pass
PiperOrigin-RevId: 169925851
Change-Id: Ifa69506a250557dd7bba631122fdd6d0744d6341
|
|
We think it's viewed by user if it's showing and user scrolls on call log tab,
since action in the same tab that moves the dialog is a strong proof.
Test: GoogleCallLogAdapterTest
PiperOrigin-RevId: 169763132
Change-Id: Ie520c65627b1e5d364860507321fb268c89e0cf7
|
|
Bug: 35359461
Test: none
PiperOrigin-RevId: 169752834
Change-Id: If78723774babb86a55e07d4b94d9f1d784791b76
|
|
screenshots
http://screen/d2qPOq3h1o1
http://screen/wHcnO5LXRO2
Bug: 65858857
Test: n/a
PiperOrigin-RevId: 169748652
Change-Id: Ie255f0d9be958f004c8bc9639d478553f66109d3
|
|
video call upgrade and calling from call log is logged
Bug: 66222115
Test: DialerCallTest, GoogleCallLogAdapterTest
PiperOrigin-RevId: 169703001
Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b
|
|
Also fixes an issue where if the promo is shown after the dialpad or search UI is brought up then the promo will be added to the bottom of those UIs.
Bug: 64491095
Test: manual
PiperOrigin-RevId: 169700496
Change-Id: I76a1aa977df623964b843d8e4b20146ba7c2f874
|
|
SimpleDateFormatter just wasn't working. This CL simplifies this method to
something similar to what we had before the call details rewrite. To avoid
going through the trouble of having the strings retranslated through the i18n
coordinator, I've left them as is and worked around it.
screenshots:
before: http://screen/eJqs5EijCYe
after: http://screen/AbrLFn0caL0
Bug: 63370483
Test: existing
PiperOrigin-RevId: 169626011
Change-Id: I160529e276db2fc098a29b005db104e7ac601f15
|
|
To repro the bug:
1) Turn on "Don't keep activities" option in developer options
2) Open dialpad
3) Press home
4) Launch dialer from home screen
5) Observe blank screen
Bug: 65458054,64129606
Test: unit
PiperOrigin-RevId: 169614750
Change-Id: I65e53add0f1f53c510c402f4f8b7ed60dcef273b
|
|
Bug: 64302851
Test: manual
PiperOrigin-RevId: 169600984
Change-Id: I65376894012f2d570b6c918f3f5575e7f45bf938
|
|
1. Use existing country iso info instead of guessing current country iso from sim and locale for blocked number.
2. Use country iso of current sim instead of default sim for incall location info. This fixes bug in multi sim device when default sim is out of service and making call with the other sim.
Bug: 65399976
Test: manual
PiperOrigin-RevId: 169554641
Change-Id: I416d7e2d6bc3c872bfec3eda4005a5a1684f0e40
|
|
Illustration icon TBD
https://photos.app.goo.gl/ZDLNLlXg9VBKNHGx1
Manual testing of duplicates promo end to end flow accept/dismiss states
Bug: 64491095
Test: http://sponge/db7bd5c3-ec97-46c8-a058-ed7f46a5e4ce
PiperOrigin-RevId: 169480950
Change-Id: Ia553e87ce72d84a001769851abb925da1ab31756
|
|
This change adds a dismiss button to the location permission prompt shown in
the search UI. A few other minor changes:
- Permission prompt is always the first element in the list
- Adjusted a few dimensions and strings
screenshot: http://screen/9CkRPUQ5dwh
Bug: 65858857
Test: SAT, NSFT
PiperOrigin-RevId: 169466585
Change-Id: I8177c23fe3f635fec5fdcdbe6675428cebb19f5d
|
|
This change adds a prompt inline the search fragment list view
to request the location permission (if they haven't already
granted it).
screenshot: http://screen/upu9t55mghq
Bug: 65858857
Test: NSFT, SAT, SCMT
PiperOrigin-RevId: 169447095
Change-Id: I6c312057ff3c4e2362ce21b0c57e1e5de7b25ce0
|
|
Test: TH
Change-Id: I48e807f3eafbc82401b2674a2610b20bf118c275
|
|
The underlying issue was that if a query was input that filtered out all of the
on device contacts, then the device rotated, the cursor would be reloaded with
all contacts filtered and getCount == 0. This would cause the cursor to never be
set in SearchCursorManager and on device contacts would no longer be shown
because the cursor wasn't being saved.
The reason this check was here, was because cursor headers were being managed
by SearchCursorManager. Since headers were moved into the cursors we no
longer need to set cursors to null if they are empty.
Bug: 65859191
Test: existing
PiperOrigin-RevId: 169425922
Change-Id: I0baf31c3747d679f394f3746f609b9487e52472d
|
|
Also repostion contact icon (for allen, is there a bug for that?)
Originally i tried wrapping the transcription in a ScrollView,
but that didn't really work since there's no easy way to set
a max-height for it. Since most voicemails transcriptions are
not that long, an easier solution was just to not limit the number
of lines for the transcription.
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuINkdXeVV0U0dOZVNfdExzSDNsai1Ld2F3ZlBN
https://drive.google.com/open?id=0B9o_KvtLkcuIZTZFQzRQaW1nblBPN2JkVW1hMkR3YWl1b2JV
Bug: 64211399
Test: manual
PiperOrigin-RevId: 169425482
Change-Id: I63c9165f48d902c06e288280116cd9b95d67852c
|
|
When a user dials a number with post dial digits, they are now
carried to contact details and used when they redial that number.
Additionally, when a user clicks on a photo in call details, they will
be taken to Bugle now. This behavior already exists with messages in CD.
Bug: 62236726,62230491
Test: CDEVHT
PiperOrigin-RevId: 169422921
Change-Id: I1507cb64876540cfc9a683a5a1ea01910443f77b
|
|
This CL partially revert cl/159492498, since data SMS cannot be properly processed under FBE and visual voicemail notification won't be received.
Bug: 65555345
Test: LegacyVoicemailNotificationReceiverTest
PiperOrigin-RevId: 169321096
Change-Id: I7134d80479efef67de8d5d44131eea30f82297a0
|
|
The problem was that the query for looking up a voicemail by URI was broken
which was causing the notifications to be cancelled then when they were supposed
to be updated they were actually getting re-added thus causing the notification
sound.
Bug: 65692173
Test: manual and unit test
PiperOrigin-RevId: 169304391
Change-Id: I1e8f648231b6f0ab984a5b0e4facd8351b01391a
|
|
Lightbringer.supportsUpgrade() is changed to return absent optional when it does not have data for the number. Seeing this LightbringerTech will use Lightbringer.updateReachability() to retrieve it from the remote package, which will store it in the reachability cache.
Bug: 63601277
Test: RemoteReachabillityQueryHandlerTest, LightbringerTechTest
PiperOrigin-RevId: 169283953
Change-Id: I3f26d9158fc6cfed196fd533da2aad598c8e6a7a
|
|
Bug: 65648343
Test: updated unit tests (already submitted in previous cl)
PiperOrigin-RevId: 169280819
Change-Id: I5950087765ffd038c31b872c6468951472980407
|
|
Zero suggest in dialpad search clutters the UI and we shouldn't show and search
results until the user has input something into the dialpad.
Additionally, this change ensures the fab stays hidden through device rotation
in regular search.
Bug: 65858825
Test: implemented
PiperOrigin-RevId: 169270161
Change-Id: Ia08ce56ffd02f74ea9e4d9d8a1efc3726fcc66d9
|
|
So we can associate all bubble actions with call id, and analyze bubble actions per call session.
Also move code for sending primary action back to primaryButtonClick(), which is introduced in cl/167347311.
Test: manual
PiperOrigin-RevId: 169152088
Change-Id: I97f0971f162684d882f6addbc012f6e8552216b7
|
|
This CL adds logic to persist the search query and call
initiation type through configuration changes like device
rotation.
list of bugs:
https://docs.google.com/document/d/1GajzkAqXXRqbj_-qeYeDxIKr0fPsSZC3nXhRkIQg5tE/edit#heading=h.bopot1qivvxg
Bug: 65751247
Test: NSFT
PiperOrigin-RevId: 169146766
Change-Id: I7a68c01d5698c07a362ad621642a9138fd9a9aaa
|
|
v13 is now at go/dialer-v13, I've set it's max version to 1899999.
Test: N/A
PiperOrigin-RevId: 169123311
Change-Id: Ib8304953d0ad974a2f22c1b390ff3bb180360244
|
|
Bug: 65686665
Test: manual
PiperOrigin-RevId: 168983351
Change-Id: I6443a05c8435e777c52ed3586dfc228a0fb0f51f
|
|
Bug: 65687672
Test: existing
PiperOrigin-RevId: 168951800
Change-Id: Ie840acd608424551198ba3440d6060a7cd7a629f
|
|
Users using touch to explore with TalkBack on the dialpad would occasionally
call voicemail if they hovered over 1 for a long period of time. This
functionality doesn't align with keyboards, where a long hover still acts as a
normal click. This CL updates the Dialpad to align better with a keyboard and
now users can only speeddial voicemail and type a 0 with double-tap activation.
Bug: 62712616
Test: manual
PiperOrigin-RevId: 168909308
Change-Id: Ib46342f173aef7c2ef64c2b42745966f83266b98
|
|
Also replace deprecate android:singleLine=true with android:maxLines=1
video: https://drive.google.com/open?id=0B9o_KvtLkcuIWGVBOElWdFNKa1E
Bug: 65678844
Test: manual
PiperOrigin-RevId: 168858718
Change-Id: I8be70e8496a8f0c562ca09eb315bb4e28b3e9c00
|
|
verizon TOS screen shot 1: https://drive.google.com/open?id=0B9o_KvtLkcuIU3VpLUpqcXBUYy1QY19UUk81a29sdGQyNEZZ
verizon TOS screen shot 2: https://drive.google.com/open?id=0B9o_KvtLkcuIN3R6SUFjS3RVTWhZQUM1UzhoajhNUF9ZbzJJ
non-verizon TOS screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIeVFYaWhYZmRzYVctU2F6N1VqazcycGpmNmRZ
Bug: 37340510
Test: manual and update unit test
PiperOrigin-RevId: 168851805
Change-Id: I7be27360093cae315b7249152e10d1beae5c5966
|
|
Bug: 65212837
Test: DialpadFragmentTest
PiperOrigin-RevId: 168745371
Change-Id: I62da45cdac58e3387343589b952e5d6bce7a4ee2
|
|
Test: manual
PiperOrigin-RevId: 168612783
Change-Id: I811133aee3301bac6936d5ba101719c30322d3be
|
|
VVM can be "activated" through restoring shared preferences from another device. In this case the SMS filter in telephony is still not configured, and needs to be set up.
Bug: 65542413
Test: ActivationTaskTest
PiperOrigin-RevId: 168560153
Change-Id: I46dd9b31e43899d8d567e7e6baebf06559548525
|
|
Bug: 64399026
Test: None.
PiperOrigin-RevId: 168456040
Change-Id: I65fdae8dff1c9bb8e05e79f3ece2480b92f08c69
|
|
Test: manual
PiperOrigin-RevId: 168427349
Change-Id: Ie58920b76266ebb298210b5faac8fcbda4dbcd15
|
|
If it's a swipe, onPageScrolled() is called several times before onPageScrollStateChanged(SCROLL_STATE_SETTLING) and onPageSelected().
If it's a click, only onPageScrollStateChanged(SCROLL_STATE_SETTLING) is called before onPageSelected().
And onPageScrollStateChanged(SCROLL_STATE_SETTLING) will not be called if user don't switch to a new tab.
We use the difference to tell if user switching tabs by swiping or clicking.
Test: DialtactsActivityTest
PiperOrigin-RevId: 168403148
Change-Id: Iaaf84ab9c4955d0bc2c1e9857ba59fd37b3984af
|
|
When opening a voicemail setting from Dialer with
ACTION_CONFIGURE_VOICEMAIL, no subId is passed.
So on a multi-SIM device, it is always configuration on the default
phone regardless of SIM.
To solve this, set the PhoneAccountHandle to intent extra for
ACTION_CONFIGURE_VOICEMAIL. In the advanced settings, obtains subId
from the PhoneAccountHandle.
Test: manual - Checked that correct PhoneAccountHandle will be passed
with ACTION_CONFIGURE_VOICEMAIL intent
Bug: 65001008
Author: xuegang.x.liu <xuegang.x.liu@sony.com>
Bug: 65001008
Test: manual - Checked that correct PhoneAccountHandle will be passed
PiperOrigin-RevId: 168019873
Change-Id: I8578dd2c4ac24e4af121a90b2b175baae2832461
|
|
Bug: 64716624
Test: manual
PiperOrigin-RevId: 168017541
Change-Id: Ia8e581f19a0a9c4d45bacc4ab94e54131763640a
|
|
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search results if the results do not fill the entire
view. The keyboard overlaps the results and there is no way to get to the
enter list without dismissing the keyboard.
10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow
points down but works like back button
Bug: 62685859,63691995,63939331,64137632,64902476
Test: manual
PiperOrigin-RevId: 168004913
Change-Id: Ia566fce6d90454a3eae6ecccfa81ce7e909e878f
|
|
This is mostly just a revived version of cl/158901400. It adds a job service that is triggered by changes to the voicemail database. The job updates voicemail notifications,
as necessary.
video of notification update:
https://drive.google.com/open?id=0B9o_KvtLkcuId1ptNk1EbGotWFU
Bug: 37340510,27535759
Test: manual and unit test
PiperOrigin-RevId: 167934550
Change-Id: I36f03c0769645f7a0cb478172171f1079eca2108
|
|
Changing voicemail notifications to match the latest mocks,
(replacing the 'Voicemail' title with what was the notification
content, and putting the voicemail status or transcription in
the notification content). The notifications will be updated in
a following cl.
screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIbDdjaTNHTFFZLW9YZEo1SG5scDR6SzloaWc4
Bug: 37340510
Test: manual
PiperOrigin-RevId: 167928866
Change-Id: I81492f7fbf1cc398401a948e036854d6a8ff878b
|
|
*** Reason for rollback ***
Turns out blocked number activity is actually used for devices on M.
*** Original change description ***
Removes the unused dialer/app/filterednumber package.
***
Test: n/a
PiperOrigin-RevId: 167663280
Change-Id: I6af1fc7d6eb61f946d4fba255fe7374bcdee0e72
|
|
*** Reason for rollback ***
Based off a CL that needs to be rolled back.
*** Original change description ***
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search...
***
Bug: 64902476,64137632,62685859,63691995,63939331
Test: n/a
PiperOrigin-RevId: 167661409
Change-Id: I0627d54af33fb55c64b5edcd459dde6a73d93266
|
|
-add branding 'Google is transcribing'
-add branding 'Transcribed by Google'
in-progress screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVVTX3BBZkNzV180alZPQ3EtR3gzRFNoamhV
transcribed by screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuISUdaRjBlUFpjYTBWWTg1STVHS0oyQmNiSUVR
Bug: 37340510
Test: manual
PiperOrigin-RevId: 167620447
Change-Id: I5526bebb6999cf77b0902ae50ca72e380538a6e7
|
|
Apparently, scheduling a new job when one is already running (even using the enqueue api) causes the running job to be stopped. We weren't handling that case correctly. This cl makes sure no more work is attempted after a job is stopped by cancelling any
active transcription task. We request that stopped task be rescheduled by the job scheduler, so it will get run eventually.
I was able to verify this fix by sending a new voicemail while backfill old transcription tasks were running.
Bug: 64908823,63524274,65129734,63803709
Test: manual and unit tests
PiperOrigin-RevId: 167617191
Change-Id: Icc92997c2687e61bef9b3b7f9ff572da2cb4ed2e
|
|
Each trace info will add several milliseconds overhead and it's not used by end user.
Bug: 64542087
Test: none.
PiperOrigin-RevId: 167614347
Change-Id: I70c032fde162d6c8aa46be72c9ece3b7c3249fe8
|
|
When the call log is restored by the system, all items are marked as new even though they could already been read. This causes a torrent of "missed" calls after restoring call log with the setup wizard.
This CL ignore read entities in the query.
Bug: 62871863
Test: CallLogNotificationQueryHelperTest
PiperOrigin-RevId: 167602820
Change-Id: Iba5609ace895a309685bfcd61eae85e080562ec5
|
|
Users can now create new contacts, add to existing contacts, send sms and make
ViLTE calls from dialpad search results.
screenshot: http://screen/7iR038nUvmh
from the bugbash:
11. Missing “Create new contact” “Add to a contact” “Send SMS” from search results with a phone number search
Bug: 64902476
Test: many
PiperOrigin-RevId: 167362073
Change-Id: I2f94d863035c119ec526e02e088992c618a858a9
|
|
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search results if the results do not fill the entire
view. The keyboard overlaps the results and there is no way to get to the
enter list without dismissing the keyboard.
10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow
points down but works like back button
Bug: 64902476,64137632,62685859,63691995,63939331
Test: manual
PiperOrigin-RevId: 167332236
Change-Id: I1c0b5b429316dae119b5fb21be4303d7fe052e35
|
|
This CL updates version codes and name for Dialer v12.1 to 17*****. Doing so also bumps v13 to 18*****.
Test: N/A
PiperOrigin-RevId: 167326768
Change-Id: I3765a9ae8b06669a3eb96fef03a8a1432b3fc278
|
|
These new states will be used to show descriptive failure messages to the user.
Also moved the VoicemailCompat class to avoid duplicate code.
Bug: 37340510
Test: none
PiperOrigin-RevId: 167314611
Change-Id: I618d7f196ea2b0161cbd33479553cae3521328d7
|
|
Test: manual
PiperOrigin-RevId: 167310802
Change-Id: Ie27a1b2f4daf73133edfb9de7f4e4aff1d87b6c8
|
|
Somehow a null action will be sent to the receiver.
Bug: 64934925
Test: LegacyVoicemailNotificationReceiveverTest
PiperOrigin-RevId: 167300542
Change-Id: Ifa001d102d265e1dad42806b48f0a1710d05b195
|
|
This CL uses the simulator connection service to perform integration
tests for incallui.
The main pieces of this CL are:
- DialerCallEvent - this is how we track changes to the incallui calls
- Simulator.Event - this is how we track changes to a simulator
connection
With the above two we can do things like:
- block until a DialerCall switches from ACTIVE TO ONHOLD:
- DialerCallEspresso.waitForNextEvent(tracker, call, new
DialerCallEvent(STATE_CHANGE, "ACTIVE", "ONHOLD")
- block for a connection to recive a particular DTMF code:
- SimulatorConnectionEspresso.waitForNextEvent(call, Event.DTMF)
Future CLs will include things like:
- fling to answer / reject
- conference calls
- screenshot diffing
- video calling
Test: InCallActivityTest
PiperOrigin-RevId: 167211015
Change-Id: Ib013b10fe963092fad0816b07b1659efd69d9468
|
|
screenshots:
default: http://screen/qEdB51A3PDn
zero-query: http://screen/qEBDg0auGA8
query: http://screen/SuLp2GwyvYr
Bug: 64806278
Test: manual
PiperOrigin-RevId: 167205946
Change-Id: I07563fd23801da8d9d2eb95f6d09a079474403eb
|
|
The TelecomManager#isInCall method returns true anytime the user is in a call.
Starting in O, the APIs include support for self-managed ConnectionServices so that other apps like Duo can tell Telecom about its calls. So, if the user is in a Duo call, isInCall would return true.
Dialer uses this to determine whether to show the "return to call in progress" when Dialer is launched.
Instead, Dialer should use TelecomManager#isInManagedCall, which only returns true if the device is in a managed call which Dialer would know about.
Bug: 36991070
Test: none
PiperOrigin-RevId: 167200903
Change-Id: I12ac7b893dcbfa2fc842ca5ab356fbbc490a098b
|
|
When the dialpad closes and we enter regular search, the fragment translates
downwards so the upper contact is not cropped. This resulted in the bottom
contact being cropped. Now the fragment translates and resizes so all contacts
fit in the provided space.
from the bugbash:
#20: last contact is hidden off screen when in regular search
screenshot: http://screen/vbduKLKKor2
Bug: 64902476,36880551
Test: manual
PiperOrigin-RevId: 167189351
Change-Id: I3ba5795ba4c2f781dc320add3928c5ad74070b46
|
|
Bug: 64129606
Test: none
PiperOrigin-RevId: 167174480
Change-Id: I4b5a494b0b334b42ee053c4d4d1e81d7699461d0
|
|
There was an issue where businesses' and remote contacts' contact photos
wouldn't open contact cards correctly. The issue was rooted in the incorrect
contact uri being assigned to the quick contact badge.
from the bugbash:
16. Tap on business icon from search results says “ no application found” instead of opening the business info
17. Same as #16 but with contact from Directory Google.com - “The contact doesn’t exist” when tapping contact icon
Bug: 64902476
Test: existing
PiperOrigin-RevId: 167111016
Change-Id: I4b6f7ca812d2fc4dc220951e8c05db2c8b8d6114
|
|
Test: http://screen/9eBrOUZj90T
PiperOrigin-RevId: 167099613
Change-Id: I3ae96b376ced290ff9d1f328cfaf29b8f8fce979
|
|
Previously, Android's Dialer app was developed in an internal Google
source control system and only exported to public during AOSP drops.
The Dialer team is now switching to a public development model similar
to the telephony team.
This CL represents all internal Google changes that were committed to
Dialer between the public O release and today's tip of tree on internal
master. This CL squashes those changes into a single commit.
In subsequent changes, changes will be exported on a per-commit basis.
Test: make, flash install, run
Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160
Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8
PiperOrigin-RevId: 167068436
|
|
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC45
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC45
This release contains the following bug fixes since RC39:
Bug: 38131932 38302993 38347350 38368993 38395481
62100344
Test: make, on device
Change-Id: Ib4af5dcc58c684d51ea1f4628b301e40184b81b3
|
|
ActionBarActivity has been deprecated for 2+ years and has been
extending AppCompatActivity for all that time. These changes
should be no-ops.
Bug: 35253513
Test: None
Change-Id: Ic87c8db6f9733fbcfa59d3bc08c77013799ae652
(cherry picked from commit 27b5eaeb2d0cdffb0b89db4971894548da8afdd4)
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC39
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC39
This release contains the following bug fixes since RC32:
Bug: 38137349 38249439 38299262 38329114
Test: make
Change-Id: I65f695db8aa20902fa60835d58b41cfdfe42704b
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC32
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC32
This release contains the following bug fixes since RC17:
Bug: 33176679 33272455 3646510 36773894 37297649 37413780
37513689 37640315 37680595 37698062 37873639 37901752
37919295 37953423 38062852 38069600 38137349 38173549
38180252 38191514
Test: make, on device
Change-Id: I4e4bb630082758e418ff24892b7db3142c6eb09a
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC17
Branch: dialer-android_release_branch/153304843.1
dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC17
This release contains the following bug fixes since RC16:
Bug: 37962346
Test: make, on device
Change-Id: I1852cc096ef242c7bfcd85b11f954ddb00903c39
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC16
Branch: dialer-android_release_branch/153304843.1
dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC16
This release contains the following bug fixes since RC00:
Bug: 37324705 35304403 36067503 35304446 33203808 37280992
37346084 35766990 37481880 37424493 36470282 37347691
37519015 37168472 35805360 37545472 27704934 36515614
35766990 37577470 34739750 35801628 36788693 35264204
36708536 37628370 36904650 37314436 37642171 37530847
37637799 37666625 37548549 37648036 37636412 37323529
37630507 35919141 37198343 37548572 36178218 37640315
37663896 37720467 37275944 37710497 31634477 37744796
37348506 37744796 37568534 37672424 34872683 34873026
37681461 34873295 37748373 37526812 37618638 37663896
37536088 37727455 37165687 36651204 36900708 37323529
36902926 37256480 37328353 37432034 37436952 34093562
37720889 37321935 37780300 37781115 37755902 36588206
34258266 37290464 37698062 37618638 37473004 37432034
37918676 37870494 37722091
Test: make, on device
Change-Id: I99e1a484ccd578c1f8a13e7a6a4b4952f0791297
|
|
RC00 is based on:
branch: dialer-android_release_branch/153304843.1
synced to: 153304843
following the instructions at go/dialer-aosp-release.
In this release:
* Removes final apache sources.
* Uses native lite compilation.
More drops will follow with subsequent release candidates
until we reach our final v10 release, in cadence with our
prebuilt drops.
Test: TreeHugger, on device
Change-Id: Ic9684057230f9b579c777820c746cd21bf45ec0f
|
|
Test: builds, boots
Change-Id: I223faf55c1e1b4d81d11b4c8b2d93ccd131c969b
Fixes: 37775662
Fixes: 37748635
Fixes: 37673408
Fixes: 37672564
Fixes: 37672218
Fixes: 37638323
Fixes: 37637423
|
|
cl/152373142.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/151342913 (3/27/2017) to cl/152373142 (4/06/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I2fbc88cf6867b90ac8b65f75e5e34468988c7217
|
|
cl/151342913.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/151128062 (3/24/2017) to cl/151342913 (3/27/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I8d4855628b62e9067e71f32ed40317617a1e3b02
|
|
cl/151128062
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/150756069 (3/21/2017) to cl/151128062 (3/24/2017).
Notable this release:
- Explicitly enumerate host and target dependencies.
- Update proguard flag references.
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Bug: 33210202 36511925
Addresses
33210202 - Proguard support
36511925 - Compiler warnings when building against platform sdk
Change-Id: I448ec3b3f2358886859cf7a4ef76a8fcef3244ae
|
|
cl/150756069
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/150392808 (3/16/2017) to cl/150756069 (3/21/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I0888b5db52efb28eb8194600e0c7804592f975f3
|
|
cl/150622237"
This reverts commit 06b6b56e9eaa91ebf757ea641e38a9c885fa40bd.
Change-Id: Ida8c5ee67669524dc63b9adc60a6dd392cb9b9a6
|