summaryrefslogtreecommitdiff
path: root/java/com/android/dialer
AgeCommit message (Collapse)Author
2017-10-16Rename Lightbringer to Duoroldenburg
Now that our Duo integration is public, we no longer need a code name. To avoid any disruption, logging and config related names were not changed. Bug: 63753964 Test: manual, existing tests PiperOrigin-RevId: 172172738 Change-Id: Ib9d3d80761944d850c8c4886def9fef9a28539a4
2017-10-13Fixed crash which occurred when clearing call log containing enriched call data.zachh
There was a race where the dialog could sometimes get detached before the success callback finished. The callback would attempt to show a snackbar using [fragment.]getString(), which throws when the fragment is detached. The fix is to just use the activity to get the string (which has already been asserted to be valid). Bug: 65968151 Test: unit PiperOrigin-RevId: 172169503 Change-Id: If86250b14038958e6668b26d1f150619fe3eefae
2017-10-13Add config provider value for dynamic locales for assisted dialing.erfanian
This is a dialer only feature and will not be available in the framework. Test: unit tests. PiperOrigin-RevId: 172166023 Change-Id: Ib2a0101386a9d892dab87c7c4fb8d4728d8c55f0
2017-10-13Bug fixes for new search ui w/ Dialpad.calderwoodra
- Dialpad now hides if user tries to scroll w/ a search query. - Search now closes if the user touches the blank area w/o a search query. - Since we don't even show location results in dialpad search, we no longer request location permission in it. Bug: 67657783,67656915 Test: tba PiperOrigin-RevId: 172162620 Change-Id: I33a814797a053600e56fb163fd55b0c43e00a9c6
2017-10-13Do not load every DialtactsActivity fragment on app openroldenburg
With this change we now only load the Favorites and Call Log Fragments when the app opens. Paging to the CallLogFragment makes the ContactsFragment load as we would want. This should result in a faster app start time. I'll need to verify the impact of this using the same method as http://cl/170422671 I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change. Bug: 64541209,65460373 Test: manual PiperOrigin-RevId: 172154863 Change-Id: Iaf6e217df284e6df6f13688ac6aa677481a575e0
2017-10-13Fixing voicemail notification bugmdooley
Added a check for null notification tags when updating voicemail notifications. Bug: 67607115 Test: manual and unit test PiperOrigin-RevId: 172121860 Change-Id: If9fd6ca972a5a1dbd48a9c529f3cb46c3c93fa2a
2017-10-13Use CONTENT_URI_WITH_VOICEMAIL for SystemCallLogDataSourceuabdullah
Currently the SystemCallLogDataSource queries the call log table with CONTENT_URI. This works for the call log tab, but will not work for the voicemail tab. To allow the voicemail tab to query annotated call log for voicemail information, we need to surface up voicemail data from the system call log data source into the annotated call log. Bug: 64882313,33006245 Test: Unit tests, also verified that in the call log only the non-voicemail entries show PiperOrigin-RevId: 172036196 Change-Id: Ieac855ae854a043207c9ae668280391c790ac33d
2017-10-12Set the secondary action to be a voice call when the primary action is a ↵linyuh
video call. Bug: 67717800 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 172013208 Change-Id: I86c4ca1ef7caf1899cb9587d98233a9e707b7f3d
2017-10-12Handle invalid PhoneAccountHandle component name in MissedCallNotifiertwyen
Bug: 66946794 Test: MissedCallNotifierTest PiperOrigin-RevId: 172007792 Change-Id: I14a2c0b6a5ad5a5b8acd449214c91bff68282b6a
2017-10-12Use TelephonyManagerCompat for IS_REFRESHtwyen
Bug: 66633426 Test: LegacyVoicemailNotificationReceiverTest PiperOrigin-RevId: 172007744 Change-Id: Ic67566c22659b51d605c92d2673f9baddaee531f
2017-10-12Updated animation to enter and exit search ui.calderwoodra
video: https://drive.google.com/open?id=0B2Hce9qilHmvZkREWm1BMURJNjQ Bug: 67635181 Test: n/a PiperOrigin-RevId: 171928416 Change-Id: Id0ef91647ec15ea970a691b1ae896010a12e6bb8
2017-10-12Optimization for incoming call latency.wangqi
There are many binder call triggered by IPC on main thread. This change will try to reduce them by caching thing that's bound to a call. It reduce total binder transaction from 1002 to 664 and saves ~11% latency of incoming call on locked screen. 1. Cache isVoiceMailNumber in DialerCall 2. Cache call capable accounts in DialerCall 3. Cache current country iso in DialerCall 4. Don't set orientation change if it's not changed. This change also add lots of trace info. It won't affect release build though since they are stripped out by proguard. Bug: 64542087 Test: manual PiperOrigin-RevId: 171901266 Change-Id: Iec48f030529aa59974212147276f6d0ae121872a
2017-10-12Fix incallui to use latest ux mocks for assisted dialing.erfanian
* Remove old language icon from bottom row. Screenshot=In change as scuba test Bug: 64205446 Test: new unit tests PiperOrigin-RevId: 171858076 Change-Id: Idf781be193dae3593f778af1ac833f046abd87e3
2017-10-12Remove voicemail count changed check for legacy notificationstwyen
Previously before showing a voicemail notification dialer checks if the count has changed to avoid showing duplicated notifications. With the dismissed flag in place the count changed check is redundant, and it prevents the notification to reshow after reboot. Also updated the EXTRA_IS_REFRESH to use the O_MR public version. Bug: 66633426 Test: LegacyVoicemailNotificationReceiverTest PiperOrigin-RevId: 171760393 Change-Id: I508b8f42a44fd849ab7c8ca6fe9d4e7e8a38b1c7
2017-10-11Added basic bottom sheet to new call log.Zachary Heidepriem
Also added ability to click on row to call. Required plumbing through the original phone number and phone account info through AnnotatedCallLog and CoalescedAnnotatedCallLog, so that clicking to dial doesn't require an additional lookup. Required some refactoring: -created autovalue for CoalescedRow. -created autovalue for ContactPrimaryActionInfo and use it in ContactActionBottomSheet -moved logic for building primary and secondary text into CallLogUtils so it can be shared between call log list and bottom sheets -moved clipboard logic to own package for copying numbers Bug: 34672501 Test: unit PiperOrigin-RevId: 171760252 Change-Id: I645d89974460b611c1d9668c3ca3e50a716c7f8f
2017-10-11Handle race condition with CallComposerActivity.onBackPressedmaxwelb
For fast users/testing suites, it's possible to hit a race condition where onBackPressed is called multiple times in a way that allows the second call to endCallComposerSession to happen and crash. This CL fixes the issue by checking that the session still exists prior to calling endCallComposerSession. I tried to write tests for this, but since the code guards against this from happening, I wasn't able to get the code into a situation to cause the crash. Bug: 64136293 Test: none PiperOrigin-RevId: 171758119 Change-Id: Ie12fd2f4390329b9bebb503fa3cf0f26d3bc1caf
2017-10-11Skeleton implementation of PhoneLookup and Cp2PhoneLookup.calderwoodra
Bug: 67605130 Test: Cp2PhoneLookupTest PiperOrigin-RevId: 171757865 Change-Id: If92e759567456dda09a925e9c625df001f2d573f
2017-10-11Change voicemail transcription progress stringmdooley
screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVZ2dE44MzNUZ2pkdUY5ZVdycHp0R1ZsLUtZ Bug: 67634990 Test: manual PiperOrigin-RevId: 171757382 Change-Id: If11b88a0682e5da9454238fa19fb78972115fb23
2017-10-11Ignore self-manged calls for missed call notificationtwyen
If a PhoneAccount declared it is CAPABILITY_SELF_MANAGED, it should handle the in call UI and notifications itself, but might still write to call log with EXTRA_LOG_SELF_MANAGED_CALLS}. Bug: 66946794 Test: MissedCallNotifierTest PiperOrigin-RevId: 171727177 Change-Id: I34444857d432d6bb72983c0ba919bcfef885192b
2017-10-11Remove period from location request string.calderwoodra
Bug: 67635072 Test: n/a PiperOrigin-RevId: 171720799 Change-Id: Ie64f7daa071986b23653876172011d4f2343fc69
2017-10-11Implement SIM swappingtwyen
When the call is still ringing, a new button is added to allow to user to call with the other SIM. A background worker will be created to hang up the phone and redial with the other SIM. The in call UI will be prevented from ending during the process. Video: https://drive.google.com/a/google.com/file/d/0B2eYBUUznfyTSl9MdXQ0V1ZzQkE/view?usp=sharing UX has not been finalized, the icon and position are just placeholder. Bug: 64215256 Test: SwapSimWorkerTest PiperOrigin-RevId: 171715715 Change-Id: Idb3f486e9fc9a45d4c5e244af2d7d91b075bf0f2
2017-10-11Set an appropriate icon for the call detail UI's callback button.linyuh
cl/170943038 groups calls in the call log according to their corresponding actions (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set. Bug: 66026167 Test: CallDetailsActivityTest.callbackButtonLoggedForLightbringerCall, CallDetailsActivityTest.callbackButtonLoggedForVideoCall, CallDetailsActivityTest.callbackButtonLoggedForVoiceCall PiperOrigin-RevId: 171703514 Change-Id: I534e1d22f1355f261105a6bde74285403fc9ed87
2017-10-10Hide the text view showing call type or location when assisted dialing is ↵Android Dialer
supported. Test: manual PiperOrigin-RevId: 171610298 Change-Id: I12ca284927603804b8761db695d35a1c79fa93f3
2017-10-10Improved FAB UX.calderwoodra
One of the biggest issues with the FAB is that it doesn't scale in/out properly. It looked more like setVisibility was being called instead. This CL migrates the FAB controller to use the built in scale in/out methods #show and #hide and the animation is much nicer. Some of the other issues were: - Now scaling animation is correct and visible. - No longer flashes when going in/out of search. - No longer shows on top of the return to call controller. - No longer bugs when switching between VVM TOS and contacts. - No longer shows FAB over VVM TOS when entering/exiting search Bug: 62588192,35359563,64116334,27458212,37991480,67419607 Test: manual PiperOrigin-RevId: 171608105 Change-Id: I9b3f61df35abf3659a432adf411b1b7d20eba683
2017-10-10Group calls in the call log according to their corresponding actions.Android Dialer
Currently different types of calls can be grouped together (e.g., 1 voice call and 1 IMS call to/from the same number), which makes it difficult to choose the icon for the call detail UI's call back button. This CL adds an extra constraint that separates different call types (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set. Bug: 66026167 Test: CallLogGroupBuilderTest.addGroups_MixedEntries_PartiallyGroupedByAction PiperOrigin-RevId: 171602617 Change-Id: Id8170206009ba836a40c38a86914c71d5c7701dc
2017-10-10Add assisted dialing to outbound calls that qualify.erfanian
* Add missing assisted dialing to calls from contacts in the call log. * Add missing assisted dialing to calls from dialpad and normal search. Bug: 63995025,63995261 Test: unit test PiperOrigin-RevId: 171593967 Change-Id: I4e63ef1dcd7ee1b2b5cbb8ecb4d8da744d90bd66
2017-10-06Adding Future method for DialerPhoneNumberUtilmaxwelb
This CL adds a method to DialerPhoneNumberUtil which returns a Future holding the result of parsing a number into the DialerPhoneNumber proto. This will be used in the APDL integration as it will use Futures as well. The CL also changes DialerExecutors.lowPriorityThreadPool to be an ExecutorService instead of an Executor (the super type) so it can be used in MoreExecutors.listeningDecorator. Test: TAP PiperOrigin-RevId: 171347542 Change-Id: I620aacf3304d625f57af6d2b89a36f11b44008dd
2017-10-06Show on hold in management screen for conference call.yueg
Do the following when a participant is on hold: - Add "On hold • " in front of the number - Gray out avatar and text (contact name & number) Notice: We only have the on hold state information for VoLTE conference call and IMS conference call. So the change only works for them (not for GSM/CDMA conference call). Test: ConferenceManagerPresenterTest PiperOrigin-RevId: 171345423 Change-Id: Ie5fe2fc1097f4858604283989dcb916c2ac21972
2017-10-06Allow for multi-line transcription error messagesmdooley
QA noticed that the error message 'Transcription not available. Unsupported language' didnt fit on one line and got truncated. This cl removes the single line constraint for that text field. Bug: 67384287 Test: manual PiperOrigin-RevId: 171316291 Change-Id: I41f98fe207ebeca900bf4fd51cd4e95e20981a9a
2017-10-05No longer close cursors manually after onLoadFinished is called.calderwoodra
Documentation clearly states that cursor loaders will close all cursors for you. This CL removes all calls to cursor.close() after onLoaderFinished is called. Bug: 66902052 Test: n/a PiperOrigin-RevId: 171087171 Change-Id: If771fbea52e03ffdd3652af2699c393cc7424de3
2017-10-05FAB now properly scales in multiwindowed mode.calderwoodra
As per the material desing spec [1], floating action buttons should be 56dp in size normally and 40dp on small displays (like in multiwindow mode) while always maintaing a 24dp image size. screenshot (mw): http://screen/URJrg1WoQfn screenshot (normal): http://screen/TUU65D1sSHp [1] https://material.io/guidelines/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button Bug: 67312080 Test: n/a PiperOrigin-RevId: 171086404 Change-Id: Ib213cf3c94dbb0f0df5b21f23f3022a8f53d80a8
2017-10-04Inserting post call notes now compares notifications using fuzzy matching.calderwoodra
Bug: 65559651 Test: MissedCallNotifierTest PiperOrigin-RevId: 171070314 Change-Id: I57e6e0b55a07430daad944473ae4eb427d56ee96
2017-10-04Copy directory list into new list to prevent modifications.calderwoodra
Since lists are passed by reference, if the directory list passed into RemoteContactsCursorLoader was modified before #lodInBackground was called, the directory list would change and crash when compared to the list of cursors. Since directory lists are small, there shouldn't be any memory issues with copying the list. Additionally, this CL adds some logging to the new Search Fragment. Bug: 66902071,66902062 Test: RemoteContactsCursorLoaderTest PiperOrigin-RevId: 171063035 Change-Id: Id2faa542805da4167fc7045e6fbe71d02c644ab6
2017-10-04Remove 'learn more' link from verizon voicemail TOS textmdooley
and using non-breaking space in dialer TOS 'learn more' link. screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuIV3BWWmxSTTlJQ2dBTnR2UHRGWjZJRlFQUGo0 https://drive.google.com/open?id=0B9o_KvtLkcuIOEJjanVhMXlfck81aU02Y0I2MkVtWFNOVGp3 Bug: 67379747 Test: manual and updated unit tests PiperOrigin-RevId: 171025914 Change-Id: I9c4bfd899805681492a5063ee1bc674bbb98f630
2017-10-04Only show the most recent call type icon in the new call log, instead of the ↵zachh
last 3. This is according to the latest PRD: https://docs.google.com/document/d/1FLoQ6kNYL-QKplbniJAIUCHku87S9eYuYPs6IXe-U78 Also cleaned up warnings in CallLogQueryHandler. Screenshot: https://screenshot.googleplex.com/Z7p4BRVpLpE Bug: 34672501 Test: unit PiperOrigin-RevId: 170941445 Change-Id: Ibf79b70eda3837ea46d365729aaed0a87961e42b
2017-10-04Make incoming and ongoing call notification foreground and highest priority.yueg
Use startForeground()/stopForeground() for posting notification instead of NotificationManager.notify()/cancel(). It makes incoming and ongoing notification foreground and not able to snooze. It also colorize ongoing call notification for Android O, since we already setColorized(). Use setPriority(Notification.PRIORITY_MAX) for pre-O, and NotificationManager.IMPORTANCE_MAX for O. It makes incoming and ongoing notification stay on the top. Test: StatusBarNotifierTest*2 PiperOrigin-RevId: 170924163 Change-Id: Iab1415b0161a4623a1ccf52d3948f32b6f93eeb2
2017-10-03Expose more transformation state.erfanian
The data here can be used to drive the in call ui by providing key information about the transformation process. Bug: 63995261 Test: unit tests PiperOrigin-RevId: 170885399 Change-Id: I525aa1f987b3dfd9548ef8656d97efa7fce2b692
2017-10-03Create UI support for voicemail transcription, location, date and duration.uabdullah
Screenshot:http://screen/dwihQaaeaQC Bug: 64882313,33006245 Test: NewVoicemailCallLogViewHolderTest, NewVoicemailCallLogAdapterTest PiperOrigin-RevId: 170542645 Change-Id: I00c145c5856c3f1f53d12b0fd7bd80c63bb8a094
2017-10-03Warmup shared prefs in googledialer when strict mode is enabled.zachh
This avoid some spurious strict mode violations. Test: observed no strict mode notification launching google dialer PiperOrigin-RevId: 170505918 Change-Id: Ie48671dcd306ea18b041a0bd7989b419bab903f5
2017-10-02Check for valid phone account before displaying voicemail TOSmdooley
Project Fi devices crash when declining voicemail TOS because of an invalid PhoneAccountHandle. This cl fixes the problem by not showing the TOS when the PhoneAccountHandle is not valid. Bug: 67001886,66969838 Test: manual and updated unit tests PiperOrigin-RevId: 170418189 Change-Id: I36dd0b10ab7468b0937a81f3f0427a4d64091955
2017-10-02Fix crash on hanging up simulator video call.wangqi
The problem is that InCallActivityCommon#onStop will try to commit any fragment which will crash. This change also fix a bug that simulatorRemoteVideo is not stopped after hanging up. Bug: 67045513 Test: manual PiperOrigin-RevId: 170380589 Change-Id: I25e0f43141eaa573189f4d9c0109fd2689c10374
2017-09-28Use goAsync() and dialer executor to insert post call notificationstwyen
Previously post call notifications are inserted by launching CallLogNotificationService. This usually works because the call has just broght dialer to the foreground and there are some grace period before the app is consider background again. However if the post call message comes later background check will crash the app. This CL made the broadcast receiver async and complete the insertion in a worker since it wouldn't take more than a few seconds. Bug: 66444859 Test: unit tests PiperOrigin-RevId: 170275928 Change-Id: I0ff396b51a173f2e4bab0bca6b6e5c5b56ab62da
2017-09-28Add the assisted dialing logic module.erfanian
This implements the core assisted dialing logic specified in go/assisted-dialing-dd-v1 Bug: 36414469,63995261 Test: new unit tests PiperOrigin-RevId: 170232634 Change-Id: I3b668c3a0e9fb5398eca4614548c8141b200e70e
2017-09-28Refactor DialerStrictMode into an interface.wangqi
-bypassed violations are no longer logged in AospDialer The default implementation will use system strict mode and crash on bugfood build same as before. Bug: 66003745 Test: manual PiperOrigin-RevId: 170214128 Change-Id: Iab630f19499e90b15eb0b7f0707b4a70c7d81fbe
2017-09-28Adding logging for transcription polling requestsmdooley
This will allow us to tune the polling rate. Bug: 66966157 Test: none PiperOrigin-RevId: 170210987 Change-Id: I6ef204acc6e0d43a3ada524511866d4a629fe1e2
2017-09-27Updating non-verizon ToS string for declining ToSmdooley
screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdGY1RnVXM3JuMXB4OVRVOFhrSU9qRDR6c2pj Bug: 37340510 Test: manual PiperOrigin-RevId: 170131627 Change-Id: Ib022bba44e24675082299132a5965fbcb58257fa
2017-09-27Update v13 licencesuabdullah
Test: N/A PiperOrigin-RevId: 170130892 Change-Id: Ifc59f239043c66eaa8341fe34c080dad08454236
2017-09-27Setup recycler view for new voicemail uiuabdullah
Screenshot:http://screen/RK42CXn5uB6 Bug: 64882313,33006245 Test: VoicemailFragmentTest, NewVoicemailCallLogAdapterTest, NewVoicemailCallLogViewHolderTest PiperOrigin-RevId: 170129401 Change-Id: Ib82357763bd9cf9f215804225be009650402fe84
2017-09-27Force dialpad to hide on resume if it should be hiddentwyen
On M the framework does not retain the hidden state of a fragment properly when restoring it from a savedInstanceState. This appears to be fixed in N, but the exact cause and fix are unknown. This behavior will cause a fragment previously hidden coming back as visible when the device is rotated or going through any save/restore life cycle. Previously whether to show the dialpad is stored in a separate flag, and the dialpad will be hidden when it is reattached. This was regresed in cl/169614750 In this CL, if the saved mIsDialpadShown indicate the dialpad should not be shown, but the dialpad is not hidden, it will be hidden on resume. Bug: 66893723 Test: DialtactsActivityTest PiperOrigin-RevId: 170124711 Change-Id: I6f8ed21fb970d6f688cb75f854442115a6803f3c
2017-09-27Bypassed some strict mode violations.zachh
These are old code and considered to be grandfathered in. Cleaned up some warnings in GoogleLocationSettingHelper. Bug: 66498656 Test: none PiperOrigin-RevId: 170090310 Change-Id: I2c43564af751eb5f431a395d75afa5ce126b5d18
2017-09-26Fix onVisible/onNotVisible called on CallLogFragment without being attahced ↵twyen
after rotation mCurrentPage is set onResume before the fragment is attached. In this CL, mCurrentPage is still used for page change, but for resume and pause, it is detected directly in CallLogFragment using getUserVisibleHint() Bug: 65161134 Test: manual - change call volume after rotation, check ToS FAB not visible after rotation. CallLogFragment is not testable. PiperOrigin-RevId: 169984576 Change-Id: I870cbe3b83e38ac2cb505193309ab4f8e75a859f
2017-09-26Use help center for GoogleDialer abouttwyen
The about in settings is removed in google dialer, it is accessed through the dialtacts overflow "Help & feedback" instead: https://screenshot.googleplex.com/9L1kdQz6c2B https://screenshot.googleplex.com/FqqdG6X9JTR Note that help articles has not been migrated at this moment. Features in the original about is placed in the overflow https://screenshot.googleplex.com/OmCVPqwGBM9 Version info is stock google help https://screenshot.googleplex.com/EdveVnXUSML Privacy policy/Terms of service opens the browser to the link we had before Open source license opens the same license activity in about. Bug: 34872689 Test: manual PiperOrigin-RevId: 169953610 Change-Id: Ib1c25ddecbf28293b447112cb280a8f9788692d3
2017-09-26Tweaking verizon's voicemail TOS textmdooley
Change verizon's ToS title to use the string 'visual voicemail' This change seems a bit strange since the verizon legal text uses the string 'Visual Voice Mail', but the title uses 'visual voice mail' screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuIR1lmaUF4OXk1SnFLdS1fbFpfMlFieWlTQ25v https://drive.google.com/open?id=0B9o_KvtLkcuIRURWd0hhYjc4NUdKQ1hzM2RIcG5fSmlHcGhJ Bug: 37340510 Test: update unit tests PiperOrigin-RevId: 169933539 Change-Id: Idba526293604b7a27083a91b86825ef66ce23bcd
2017-09-25Fixing bug where missed call notifications were getting clobberedmdooley
The problem was that the same notification id was being used by both VisualVoicemailNotifier and MissedCallNotifier, causing the voicemail notification update code to filter out missed call notifications instead of ignoring them. Bug: 66168999 Test: manual and verified existing unit tests pass PiperOrigin-RevId: 169925851 Change-Id: Ifa69506a250557dd7bba631122fdd6d0744d6341
2017-09-25Don't show Lightbringer disclosure dialog after 1 day since viewed.yueg
We think it's viewed by user if it's showing and user scrolls on call log tab, since action in the same tab that moves the dialog is a strong proof. Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 169763132 Change-Id: Ie520c65627b1e5d364860507321fb268c89e0cf7
2017-09-25Update HD and Wifi feature of call log to use framework API.wangqi
Bug: 35359461 Test: none PiperOrigin-RevId: 169752834 Change-Id: If78723774babb86a55e07d4b94d9f1d784791b76
2017-09-25Updated image asset in location permission request.calderwoodra
screenshots http://screen/d2qPOq3h1o1 http://screen/wHcnO5LXRO2 Bug: 65858857 Test: n/a PiperOrigin-RevId: 169748652 Change-Id: Ie255f0d9be958f004c8bc9639d478553f66109d3
2017-09-22Log non-contact lightbringer actionstwyen
video call upgrade and calling from call log is logged Bug: 66222115 Test: DialerCallTest, GoogleCallLogAdapterTest PiperOrigin-RevId: 169703001 Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b
2017-09-22Delay commiting of promo fragment until user visits the contacts tabAndroid Dialer
Also fixes an issue where if the promo is shown after the dialpad or search UI is brought up then the promo will be added to the bottom of those UIs. Bug: 64491095 Test: manual PiperOrigin-RevId: 169700496 Change-Id: I76a1aa977df623964b843d8e4b20146ba7c2f874
2017-09-22Fixed call duration bug.calderwoodra
SimpleDateFormatter just wasn't working. This CL simplifies this method to something similar to what we had before the call details rewrite. To avoid going through the trouble of having the strings retranslated through the i18n coordinator, I've left them as is and worked around it. screenshots: before: http://screen/eJqs5EijCYe after: http://screen/AbrLFn0caL0 Bug: 63370483 Test: existing PiperOrigin-RevId: 169626011 Change-Id: I160529e276db2fc098a29b005db104e7ac601f15
2017-09-22Fixed bug where dialer would sometimes show blank screen.zachh
To repro the bug: 1) Turn on "Don't keep activities" option in developer options 2) Open dialpad 3) Press home 4) Launch dialer from home screen 5) Observe blank screen Bug: 65458054,64129606 Test: unit PiperOrigin-RevId: 169614750 Change-Id: I65e53add0f1f53c510c402f4f8b7ed60dcef273b
2017-09-22Adding some contacts permission guards.calderwoodra
Bug: 64302851 Test: manual PiperOrigin-RevId: 169600984 Change-Id: I65376894012f2d570b6c918f3f5575e7f45bf938
2017-09-22Better handling country iso when getting geo location of phone number.wangqi
1. Use existing country iso info instead of guessing current country iso from sim and locale for blocked number. 2. Use country iso of current sim instead of default sim for incall location info. This fixes bug in multi sim device when default sim is out of service and making call with the other sim. Bug: 65399976 Test: manual PiperOrigin-RevId: 169554641 Change-Id: I416d7e2d6bc3c872bfec3eda4005a5a1684f0e40
2017-09-22Dialer integration of contacts suggestions promoAndroid Dialer
Illustration icon TBD https://photos.app.goo.gl/ZDLNLlXg9VBKNHGx1 Manual testing of duplicates promo end to end flow accept/dismiss states Bug: 64491095 Test: http://sponge/db7bd5c3-ec97-46c8-a058-ed7f46a5e4ce PiperOrigin-RevId: 169480950 Change-Id: Ia553e87ce72d84a001769851abb925da1ab31756
2017-09-22Added dismiss button to location permission request.calderwoodra
This change adds a dismiss button to the location permission prompt shown in the search UI. A few other minor changes: - Permission prompt is always the first element in the list - Adjusted a few dimensions and strings screenshot: http://screen/9CkRPUQ5dwh Bug: 65858857 Test: SAT, NSFT PiperOrigin-RevId: 169466585 Change-Id: I8177c23fe3f635fec5fdcdbe6675428cebb19f5d
2017-09-22Added location permission request inline the search fragment.calderwoodra
This change adds a prompt inline the search fragment list view to request the location permission (if they haven't already granted it). screenshot: http://screen/upu9t55mghq Bug: 65858857 Test: NSFT, SAT, SCMT PiperOrigin-RevId: 169447095 Change-Id: I6c312057ff3c4e2362ce21b0c57e1e5de7b25ce0
2017-09-22Update package assets and strings.Eric Erfanian
Test: TH Change-Id: I48e807f3eafbc82401b2674a2610b20bf118c275
2017-09-20Fixed issue where all contacts weren't beign shown.calderwoodra
The underlying issue was that if a query was input that filtered out all of the on device contacts, then the device rotated, the cursor would be reloaded with all contacts filtered and getCount == 0. This would cause the cursor to never be set in SearchCursorManager and on device contacts would no longer be shown because the cursor wasn't being saved. The reason this check was here, was because cursor headers were being managed by SearchCursorManager. Since headers were moved into the cursors we no longer need to set cursors to null if they are empty. Bug: 65859191 Test: existing PiperOrigin-RevId: 169425922 Change-Id: I0baf31c3747d679f394f3746f609b9487e52472d
2017-09-20Don't truncate long voicemail transcriptionsmdooley
Also repostion contact icon (for allen, is there a bug for that?) Originally i tried wrapping the transcription in a ScrollView, but that didn't really work since there's no easy way to set a max-height for it. Since most voicemails transcriptions are not that long, an easier solution was just to not limit the number of lines for the transcription. screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuINkdXeVV0U0dOZVNfdExzSDNsai1Ld2F3ZlBN https://drive.google.com/open?id=0B9o_KvtLkcuIZTZFQzRQaW1nblBPN2JkVW1hMkR3YWl1b2JV Bug: 64211399 Test: manual PiperOrigin-RevId: 169425482 Change-Id: I63c9165f48d902c06e288280116cd9b95d67852c
2017-09-20Added some bug fixes in call details.calderwoodra
When a user dials a number with post dial digits, they are now carried to contact details and used when they redial that number. Additionally, when a user clicks on a photo in call details, they will be taken to Bugle now. This behavior already exists with messages in CD. Bug: 62236726,62230491 Test: CDEVHT PiperOrigin-RevId: 169422921 Change-Id: I1507cb64876540cfc9a683a5a1ea01910443f77b
2017-09-19Show legacy voicemail notification under FBEtwyen
This CL partially revert cl/159492498, since data SMS cannot be properly processed under FBE and visual voicemail notification won't be received. Bug: 65555345 Test: LegacyVoicemailNotificationReceiverTest PiperOrigin-RevId: 169321096 Change-Id: I7134d80479efef67de8d5d44131eea30f82297a0
2017-09-19Fix notification update bugmdooley
The problem was that the query for looking up a voicemail by URI was broken which was causing the notifications to be cancelled then when they were supposed to be updated they were actually getting re-added thus causing the notification sound. Bug: 65692173 Test: manual and unit test PiperOrigin-RevId: 169304391 Change-Id: I1e8f648231b6f0ab984a5b0e4facd8351b01391a
2017-09-19Perform remote reachability query if caller is not in contactstwyen
Lightbringer.supportsUpgrade() is changed to return absent optional when it does not have data for the number. Seeing this LightbringerTech will use Lightbringer.updateReachability() to retrieve it from the remote package, which will store it in the reachability cache. Bug: 63601277 Test: RemoteReachabillityQueryHandlerTest, LightbringerTechTest PiperOrigin-RevId: 169283953 Change-Id: I3f26d9158fc6cfed196fd533da2aad598c8e6a7a
2017-09-19Only enable voicemail transcription on android O and latermdooley
Bug: 65648343 Test: updated unit tests (already submitted in previous cl) PiperOrigin-RevId: 169280819 Change-Id: I5950087765ffd038c31b872c6468951472980407
2017-09-19Removed zero suggest from dialpad search in new search fragment.calderwoodra
Zero suggest in dialpad search clutters the UI and we shouldn't show and search results until the user has input something into the dialpad. Additionally, this change ensures the fab stays hidden through device rotation in regular search. Bug: 65858825 Test: implemented PiperOrigin-RevId: 169270161 Change-Id: Ia08ce56ffd02f74ea9e4d9d8a1efc3726fcc66d9
2017-09-18Use logCallImpression for bubble expand/collapse if possible.yueg
So we can associate all bubble actions with call id, and analyze bubble actions per call session. Also move code for sending primary action back to primaryButtonClick(), which is introduced in cl/167347311. Test: manual PiperOrigin-RevId: 169152088 Change-Id: I97f0971f162684d882f6addbc012f6e8552216b7
2017-09-18Now persist state through configuration changes in Search.calderwoodra
This CL adds logic to persist the search query and call initiation type through configuration changes like device rotation. list of bugs: https://docs.google.com/document/d/1GajzkAqXXRqbj_-qeYeDxIKr0fPsSZC3nXhRkIQg5tE/edit#heading=h.bopot1qivvxg Bug: 65751247 Test: NSFT PiperOrigin-RevId: 169146766 Change-Id: I7a68c01d5698c07a362ad621642a9138fd9a9aaa
2017-09-18Bump versions for v14maxwelb
v13 is now at go/dialer-v13, I've set it's max version to 1899999. Test: N/A PiperOrigin-RevId: 169123311 Change-Id: Ib8304953d0ad974a2f22c1b390ff3bb180360244
2017-09-18Fixed crash when users press back twice in call composer.calderwoodra
Bug: 65686665 Test: manual PiperOrigin-RevId: 168983351 Change-Id: I6443a05c8435e777c52ed3586dfc228a0fb0f51f
2017-09-18Pressing back when the dialpad is empty now exist the search UI.calderwoodra
Bug: 65687672 Test: existing PiperOrigin-RevId: 168951800 Change-Id: Ie840acd608424551198ba3440d6060a7cd7a629f
2017-09-18Dialpad VM and + are now only accessible w/ double-tap instead of long hover.calderwoodra
Users using touch to explore with TalkBack on the dialpad would occasionally call voicemail if they hovered over 1 for a long period of time. This functionality doesn't align with keyboards, where a long hover still acts as a normal click. This CL updates the Dialpad to align better with a keyboard and now users can only speeddial voicemail and type a 0 with double-tap activation. Bug: 62712616 Test: manual PiperOrigin-RevId: 168909308 Change-Id: Ib46342f173aef7c2ef64c2b42745966f83266b98
2017-09-15Make voicemail transcription text selectable and phone numbers clickablemdooley
Also replace deprecate android:singleLine=true with android:maxLines=1 video: https://drive.google.com/open?id=0B9o_KvtLkcuIWGVBOElWdFNKa1E Bug: 65678844 Test: manual PiperOrigin-RevId: 168858718 Change-Id: I8be70e8496a8f0c562ca09eb315bb4e28b3e9c00
2017-09-15Updating voicemail TOS UI to match mocksmdooley
verizon TOS screen shot 1: https://drive.google.com/open?id=0B9o_KvtLkcuIU3VpLUpqcXBUYy1QY19UUk81a29sdGQyNEZZ verizon TOS screen shot 2: https://drive.google.com/open?id=0B9o_KvtLkcuIN3R6SUFjS3RVTWhZQUM1UzhoajhNUF9ZbzJJ non-verizon TOS screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIeVFYaWhYZmRzYVctU2F6N1VqazcycGpmNmRZ Bug: 37340510 Test: manual and update unit test PiperOrigin-RevId: 168851805 Change-Id: I7be27360093cae315b7249152e10d1beae5c5966
2017-09-15Dialpad chooser now properly shows when in a call.calderwoodra
Bug: 65212837 Test: DialpadFragmentTest PiperOrigin-RevId: 168745371 Change-Id: I62da45cdac58e3387343589b952e5d6bce7a4ee2
2017-09-13Fixed an animation bug in new search fragment that was clipping results.calderwoodra
Test: manual PiperOrigin-RevId: 168612783 Change-Id: I811133aee3301bac6936d5ba101719c30322d3be
2017-09-13Setup SMS filter even if VVM is already activatedtwyen
VVM can be "activated" through restoring shared preferences from another device. In this case the SMS filter in telephony is still not configured, and needs to be set up. Bug: 65542413 Test: ActivationTaskTest PiperOrigin-RevId: 168560153 Change-Id: I46dd9b31e43899d8d567e7e6baebf06559548525
2017-09-13Log opening dialpad.yueg
Bug: 64399026 Test: None. PiperOrigin-RevId: 168456040 Change-Id: I65fdae8dff1c9bb8e05e79f3ece2480b92f08c69
2017-09-13Fixed crash in RemoteContactCusror.calderwoodra
Test: manual PiperOrigin-RevId: 168427349 Change-Id: Ie58920b76266ebb298210b5faac8fcbda4dbcd15
2017-09-13Log swiping and clicking for switching tabs.yueg
If it's a swipe, onPageScrolled() is called several times before onPageScrollStateChanged(SCROLL_STATE_SETTLING) and onPageSelected(). If it's a click, only onPageScrollStateChanged(SCROLL_STATE_SETTLING) is called before onPageSelected(). And onPageScrollStateChanged(SCROLL_STATE_SETTLING) will not be called if user don't switch to a new tab. We use the difference to tell if user switching tabs by swiping or clicking. Test: DialtactsActivityTest PiperOrigin-RevId: 168403148 Change-Id: Iaaf84ab9c4955d0bc2c1e9857ba59fd37b3984af
2017-09-11Send PhoneAccountHandle with ACTION_CONFIGURE_VOICEMAILtwyen
When opening a voicemail setting from Dialer with ACTION_CONFIGURE_VOICEMAIL, no subId is passed. So on a multi-SIM device, it is always configuration on the default phone regardless of SIM. To solve this, set the PhoneAccountHandle to intent extra for ACTION_CONFIGURE_VOICEMAIL. In the advanced settings, obtains subId from the PhoneAccountHandle. Test: manual - Checked that correct PhoneAccountHandle will be passed with ACTION_CONFIGURE_VOICEMAIL intent Bug: 65001008 Author: xuegang.x.liu <xuegang.x.liu@sony.com> Bug: 65001008 Test: manual - Checked that correct PhoneAccountHandle will be passed PiperOrigin-RevId: 168019873 Change-Id: I8578dd2c4ac24e4af121a90b2b175baae2832461
2017-09-11Fix NPE in contacts fragment.calderwoodra
Bug: 64716624 Test: manual PiperOrigin-RevId: 168017541 Change-Id: Ia8e581f19a0a9c4d45bacc4ab94e54131763640a
2017-09-11This is a rollforward of cl/167332236calderwoodra
Improved behavior of back button in search ui. Pressing the back button in the search UI now functions as follows: - If the keyboard is opened, the keyboard is minimized - If the dialpad is opened, the dialpad is closed - If the keyboard and dialpad is closed, the search ui is closed Our existing behavior was dependent on whether a query had been built yet. basically, if the user pressed back with no query selected, the search ui was closed. From the bugbash: 7. No scroll bar in the search results if the results do not fill the entire view. The keyboard overlaps the results and there is no way to get to the enter list without dismissing the keyboard. 10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow points down but works like back button Bug: 62685859,63691995,63939331,64137632,64902476 Test: manual PiperOrigin-RevId: 168004913 Change-Id: Ia566fce6d90454a3eae6ecccfa81ce7e909e878f
2017-09-11Updating voicemail notificationsmdooley
This is mostly just a revived version of cl/158901400. It adds a job service that is triggered by changes to the voicemail database. The job updates voicemail notifications, as necessary. video of notification update: https://drive.google.com/open?id=0B9o_KvtLkcuId1ptNk1EbGotWFU Bug: 37340510,27535759 Test: manual and unit test PiperOrigin-RevId: 167934550 Change-Id: I36f03c0769645f7a0cb478172171f1079eca2108
2017-09-11Updating voicemail notifications for transcription, part 2mdooley
Changing voicemail notifications to match the latest mocks, (replacing the 'Voicemail' title with what was the notification content, and putting the voicemail status or transcription in the notification content). The notifications will be updated in a following cl. screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIbDdjaTNHTFFZLW9YZEo1SG5scDR6SzloaWc4 Bug: 37340510 Test: manual PiperOrigin-RevId: 167928866 Change-Id: I81492f7fbf1cc398401a948e036854d6a8ff878b
2017-09-11Automated g4 rollback of changelist 167310802.calderwoodra
*** Reason for rollback *** Turns out blocked number activity is actually used for devices on M. *** Original change description *** Removes the unused dialer/app/filterednumber package. *** Test: n/a PiperOrigin-RevId: 167663280 Change-Id: I6af1fc7d6eb61f946d4fba255fe7374bcdee0e72
2017-09-11Automated g4 rollback of changelist 167332236.calderwoodra
*** Reason for rollback *** Based off a CL that needs to be rolled back. *** Original change description *** Improved behavior of back button in search ui. Pressing the back button in the search UI now functions as follows: - If the keyboard is opened, the keyboard is minimized - If the dialpad is opened, the dialpad is closed - If the keyboard and dialpad is closed, the search ui is closed Our existing behavior was dependent on whether a query had been built yet. basically, if the user pressed back with no query selected, the search ui was closed. From the bugbash: 7. No scroll bar in the search... *** Bug: 64902476,64137632,62685859,63691995,63939331 Test: n/a PiperOrigin-RevId: 167661409 Change-Id: I0627d54af33fb55c64b5edcd459dde6a73d93266
2017-09-11Updating transcription UI to match latest mocks, part 1mdooley
-add branding 'Google is transcribing' -add branding 'Transcribed by Google' in-progress screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVVTX3BBZkNzV180alZPQ3EtR3gzRFNoamhV transcribed by screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuISUdaRjBlUFpjYTBWWTg1STVHS0oyQmNiSUVR Bug: 37340510 Test: manual PiperOrigin-RevId: 167620447 Change-Id: I5526bebb6999cf77b0902ae50ca72e380538a6e7
2017-09-11Fixing transcription crashes caused by job stoppagemdooley
Apparently, scheduling a new job when one is already running (even using the enqueue api) causes the running job to be stopped. We weren't handling that case correctly. This cl makes sure no more work is attempted after a job is stopped by cancelling any active transcription task. We request that stopped task be rescheduled by the job scheduler, so it will get run eventually. I was able to verify this fix by sending a new voicemail while backfill old transcription tasks were running. Bug: 64908823,63524274,65129734,63803709 Test: manual and unit tests PiperOrigin-RevId: 167617191 Change-Id: Icc92997c2687e61bef9b3b7f9ff572da2cb4ed2e
2017-09-11Strip trace info for release build.wangqi
Each trace info will add several milliseconds overhead and it's not used by end user. Bug: 64542087 Test: none. PiperOrigin-RevId: 167614347 Change-Id: I70c032fde162d6c8aa46be72c9ece3b7c3249fe8
2017-09-11Ignore read missed calls and voicemails for notificationtwyen
When the call log is restored by the system, all items are marked as new even though they could already been read. This causes a torrent of "missed" calls after restoring call log with the setup wizard. This CL ignore read entities in the query. Bug: 62871863 Test: CallLogNotificationQueryHelperTest PiperOrigin-RevId: 167602820 Change-Id: Iba5609ace895a309685bfcd61eae85e080562ec5
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 12:45:13 +0000