summaryrefslogtreecommitdiff
path: root/java/com/android/dialer
AgeCommit message (Collapse)Author
2018-04-10Wire up SpeedDial fragment with SpeedDialUiItemLoader.calderwoodra
This change is mostly just a migration from a cursor loader and cursor to a listenable future and list of POJOs. Bug: 36841782 Test: tap PiperOrigin-RevId: 192349724 Change-Id: I37140dcc2e5e03bc5745573c0d777e18c4f1a880
2018-04-10For an audio call log entry, add a video call option in the bottom sheet if ↵linyuh
the capability is present. Bug: 70989603 Test: ModulesTest PiperOrigin-RevId: 192302145 Change-Id: I3162e7d22223aa02709d0d401c70c6fc37a00e3b
2018-04-09Autogenerate IDs for inserts and consolidate loader into one transaction.calderwoodra
Bug: 36841782,77724716,77725859 Test: implemented PiperOrigin-RevId: 192191296 Change-Id: I7a22367b33c7555d014a29a2af2942f2eb76c0a5
2018-04-09Implemented SpeedDialUiItemLoader.calderwoodra
SpeedDialUiItemLoader builds a listenable future for returning a list of SpeedDialUiItems which are the POJO representation of each speed dial list element. Bug: 36841782 Test: SpeedDialContentObserverTest PiperOrigin-RevId: 192186376 Change-Id: I70f3abbeac14117ff4a68355e3a07b395b72386b
2018-04-08Have PhoneLookup read carrier presence data from CP2.linyuh
Bug: 70988687 Test: Cp2DefaultDirectoryPhoneLookupTest, PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 192085574 Change-Id: I4512c9e2e9e14340fa3aa9b2d7d6aaea6344bba6
2018-04-06Update ToS for donationuabdullah
Disambiguates the "this" by adding the reference to settings as required by privacy. Test: N/A PiperOrigin-RevId: 191970994 Change-Id: Idc357e8c908b4f54273bf1b2823a6759ea1332b6
2018-04-06Resolve resource conflicts.linyuh
Bug: 77710848 Test: None PiperOrigin-RevId: 191957734 Change-Id: I0b2674298722a405f4f2e970e877671cff37e60f
2018-04-06Change voicemail empty state icon to voicemail icon.calderwoodra
Bug: 75962146 Test: screenshot PiperOrigin-RevId: 191948101 Change-Id: Icba3cb63cbfe42ce0f193e731dbe2240b3dfc27d
2018-04-06Convert new speed dial to support fragment and add it to new peer.calderwoodra
Bug: 36841782 Test: MainActivityNewPeerTest PiperOrigin-RevId: 191924314 Change-Id: I5e4a4adadd5477115d6b4daf8afb8c6f819496c8
2018-04-06Only request focus on search edit text when it's slide down.calderwoodra
Bug: 77586391 Test: manual PiperOrigin-RevId: 191924178 Change-Id: I792a6f0308f0dde9b4ae82227aa6a8327208a192
2018-04-06Reorganized rootcomponentgenerator package and added demo.Zachary Heidepriem
-Moved rootcomponentgenerator/annotations to dialer/inject to reduce the number of deps engineers need to include -Move rootcomponentgenerator/processor into rootcomponentgenerator/ since the other package is now gone -Added inject/demo and tests TEST=unit, tap Test: unit, tap PiperOrigin-RevId: 191916595 Change-Id: Ic155808c7435bdce198970caa92309edb9fadac8
2018-04-05Exclude Duo audio calls from the new call log.linyuh
Bug: 77496097 Test: SystemCallLogDataSourceTest PiperOrigin-RevId: 191845115 Change-Id: Id0d3770e0cd21383cf2f4c5ae5314ca4de258edd
2018-04-05Add Spam#updateSpamSync API to control when syncing the Apdl spam list is ↵maxwelb
enabled Bug: 69072794 Test: Tap PiperOrigin-RevId: 191824966 Change-Id: Ia219074f32f77f308d88e9c29edb1e56c694bcc7
2018-04-05Change @DialerComponent to @IncludeInDialerRoot and turn on ↵weijiaxu
@IncludeInDialerRoot in root component generator. Test: local test. PiperOrigin-RevId: 191820677 Change-Id: I9df15cccf65e8c51c8fadf57eabec4fd41a51007
2018-04-05Expand Duo Interfacetwyen
Added status() and audioCallable() TEST=TAP Bug: 76430187 Test: TAP PiperOrigin-RevId: 191767563 Change-Id: I5852b93bd3042f3c6ed8f2155e57fdefe58edd32
2018-04-05Support new voicemail fragment in old peer.uabdullah
This makes the old peer read the CallLogConfig#isNewVoicemailFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewVoicemail and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog database would be read, which would trigger creation. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the voicemail tab, call log tab and ensuring that they are independent. Bug: 77601968 Test: unit and manual. Some tests are failing, so to ensure we can have the voicemail ready for the bug bash tomorrow, I've ignored them temporarily but will be fixed in a follow up CL (tracked by b/77601893) PiperOrigin-RevId: 191738860 Change-Id: I24ca38b862e98324cf802a3020e7e9df31c0b966
2018-04-04Fix search bar margin issue in RTLtwyen
The RemoveView is pushing it around. Since RemoveView and SearchBarView are mutually exclusive, this CL put them into a FrameLayout to avoid position interference. Bug: 77273749 Test: manual PiperOrigin-RevId: 191678018 Change-Id: If4000f63c77c9da6794193d389f890d21452dcbf
2018-04-04Prevent crash when dialpad animation ends after activity is saved.twyen
Bug: 77484989 Test: TAP PiperOrigin-RevId: 191677909 Change-Id: If49a357a9ba158cd740eb789befd2ff802f670d4
2018-04-04Fixed some issues in dialer's dialpad for talkback users.calderwoodra
- Content description for voicemail button is now "1... double tap and hold to call vociemail" - Content description for 0 button is now "0... double tap and hold for plus symbol" Bug: 19621015,62712616 Test: manual + a11y office hours PiperOrigin-RevId: 191673375 Change-Id: I9b5d8d875f1bf218be6fcc33dff4ac9e479e4f43
2018-04-04Voicemail and Call log notifications now open GoogleMainActivity.calderwoodra
Bug: 75972847,77595270 Test: manual PiperOrigin-RevId: 191672019 Change-Id: I9ea7fb67b4dffeb6acb30840eaf093e4d00a3bcf
2018-04-04Added some logging for mysterious bugs.calderwoodra
Bug: 74196353,77485680,77486095,77540395 Test: tap PiperOrigin-RevId: 191666270 Change-Id: I0423735dde42299bf33ea0b8482c03fd3c2d4675
2018-04-04Migrate RTT chat history to use proto buffer.wangqi
This change also moved chat history to be saved in DialerCall, thus it will be persist when switching calls. Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 191626079 Change-Id: I65e9c6ac7aa41beb45dfe561b0a48506ea938e6f
2018-04-04Use the default phone account for a voice call when the call log item is for ↵linyuh
Duo. Bug: 77535982 Test: ModulesTest + Manual PiperOrigin-RevId: 191612821 Change-Id: I417b46ed3ec131bf409c427d82f5b2fa6b791054
2018-04-04Explicitly hide the badge in ContactPhotoView when it shouldn't be shown.linyuh
Bug: 70988682 Test: ContactPhotoViewTest PiperOrigin-RevId: 191600243 Change-Id: I60f979241898f1799a57c2401cbddb8975a9caa7
2018-04-03Remove reference to RTT system setting.wangqi
This should be handled by PhoneAccount.hasCapabilities(PhoneAccount.CAPABILITY_RTT) Test: none PiperOrigin-RevId: 191522319 Change-Id: I28244a725c63fb3b83e97fd9a585473a94da96d9
2018-04-03Don't deadlock in DialerDatabaseHelper.zachh
The fix is to use FutureSerializer instead of synchronizing on the method. FutureSerializer provides the guarantee that the next AsyncCallable won't even be submitted until the ListenableFuture returned by the previous one completes. Bug: 73877234 Test: added sleep to update task, and verified that resuming activity > 5 times does not deadlock the app PiperOrigin-RevId: 191494662 Change-Id: I5dc2bed7e117fd3ba5a3cd6a8c39c82a565ce070
2018-04-03Fix NPE for details numbermaxwelb
The phone number can be null in the call log (typically for conference calls), but this wasn't handled properly for calls from non-contacts. This CL fixes the issue by instead using the display number. PhoneNumberUtils properly handles null values and can parse the formatted version. Bug: 77486039 Test: manual :/ PiperOrigin-RevId: 191492307 Change-Id: I1be427b3f4ed1381bea3943d130256618f730f5d
2018-04-03Per linguists' request, increase CHAR_LIMIT of "Carrier video" from 30 to 31.linyuh
Bug: 77513242 Test: None PiperOrigin-RevId: 191470111 Change-Id: I0220a342dc1ff04f247ad09dc1fc308f61bbe80c
2018-04-03Fix permissionroldenburg
Bug: 76445204 Test: manual PiperOrigin-RevId: 191470043 Change-Id: I8d57331b2fbeff358535d92852d6bbb2ac677613
2018-04-03Handle missed calls for new call log in old peer.zachh
Test: unit PiperOrigin-RevId: 191380073 Change-Id: If554d5ee0c55754802692a364bae591c3951c060
2018-04-03Separate calls with the video feature from others when coalescing rows in ↵linyuh
the new call log. Test: CoalescerTest PiperOrigin-RevId: 191376690 Change-Id: Id5939175edddd164a1b477319fb20e6d2a9671a9
2018-04-03Support placing Duo calls in the new UI's bottom sheet.linyuh
Bug: 70988685 Test: DuoCallModuleTest, PlaceDuoCallEndToEndTest, Manual testing PiperOrigin-RevId: 191372706 Change-Id: I439be71c361eaca722820b81278e5f95322e100c
2018-04-03Turn off component generating step of RootComponentGenerato and ↵weijiaxu
@DialerCompoennt. Delete related tests. Test: On a local device. PiperOrigin-RevId: 191365675 Change-Id: Ia90463b936f3f07df99909c463b2bdb51223fbe6
2018-03-30Use IS_READ instead of NEW in new call log.zachh
We want to be more consistent with other usages of NEW in the app, i.e. NEW should be used primarily by notifications. Bug: 74821515 Test: unit PiperOrigin-RevId: 191139559 Change-Id: Ib6fbead8b5589aedd881db26a07f7daed4d83543
2018-03-30Add upgrade to RTT call button.wangqi
This button has higher priority over add call button if RTT is enabled. Bug: 67596257 Test: ButtonChooserIntegrationTest PiperOrigin-RevId: 191129313 Change-Id: I5a3302a0970e77a933439749e0e559a691235523
2018-03-30Add SpeedDialEntry database helper.calderwoodra
Bug: 36841782 Test: SpeedDialEntryDatabaseHelperTest PiperOrigin-RevId: 191121137 Change-Id: Iab712d5fac56e515bd4e977282656bf80db4337d
2018-03-30Added logging for popping in new call log.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 191099351 Change-Id: I47f1e487e2a0cc23af7b39ae89e20abf993933ea
2018-03-30Log the number of "invalid" CP2 rows.zachh
Also use a flag to control the threshold at which we process invalid numbers. Bug: 70989667 Test: unit PiperOrigin-RevId: 191095892 Change-Id: Idb424831d637ae44e5e5915afaf59c3d534ce4a0
2018-03-30Implement new blockingtwyen
Old blocking is deprecated. Bug: 70989544 Test: TAP PiperOrigin-RevId: 191086875 Change-Id: Icde4963fce603fc4e16e486b78c070bd439e26e4
2018-03-30Differentiate video call types (carrier/Duo) in call descriptions for the ↵linyuh
new UI. Bug: 70988686 Test: CallLogEntryTextTest PiperOrigin-RevId: 191071267 Change-Id: I392e3b4c47e266f0a553fe28079d4800fc174a8f
2018-03-29Update what happens when donation is rejected & use correct donation ↵uabdullah
availability check Checking donation is not a simple config check, but everything that donation availability is dependent on via the isVoicemailDonationAvailable() helper method. We update the code accordingly. When the user declines the promo for donation, we should also update the toggle accordingly. Bug: 74033229 Test: N/A PiperOrigin-RevId: 191011808 Change-Id: I6e4ff9914355deed72175179fc7b9009f2395ef5
2018-03-29Mark spam voicemail as old after we auto block it.Android Dialer
Bug: 77242856 Test: N/A PiperOrigin-RevId: 191002650 Change-Id: Ia74423f28a40f148d507fb9f907fc2e5c41fc183
2018-03-29Fixed a few issues in search with new nav.calderwoodra
- back arrow in search now flips in RTL mode http://screen/1eccBLDqPp0 - search text no longer overlaps icons http://screen/Mq0omQEuZez - keyboard now always closes on pause - location permission is no longer visible in dialpad search Bug: 73088433,74784637,76117373,76440832,76441216 Test: keyboard and rtl tested manually, added test for location permission PiperOrigin-RevId: 190981686 Change-Id: Ia121d410c158df0de9cd731ab280a6d8e9b300d9
2018-03-29Replace png icons with vector drawable for video call screen.wangqi
Bug: 76221932 Test: manual PiperOrigin-RevId: 190948113 Change-Id: I4151ab3fc5231183d49fc1bdc247a09e5ffadc22
2018-03-29Badge contact photos for video calls in the bottom sheet.linyuh
Bug: 70988682 Test: Existing tests PiperOrigin-RevId: 190946639 Change-Id: Iaa8294e8ba6e85ab3c27bb2e67200d7972a240f2
2018-03-28Show toast when handing off from LTE to WiFiroldenburg
Bug: 65490850 Test: manual PiperOrigin-RevId: 190859631 Change-Id: I89aeb41a7709e9366367cdc54ba506e276685b5f
2018-03-28Create a common widget (ContactPhotoView) for a contact photo and its ↵linyuh
optional badge. Bug: 70988682 Test: ContactPhotoViewTest PiperOrigin-RevId: 190855440 Change-Id: Ib658efa6486b66548c710804049517905dc67b13
2018-03-28Update spam blocking promo wordings.Android Dialer
Bug: 75308663 Test: N/A PiperOrigin-RevId: 190825933 Change-Id: Iaf112cfec81c82e127d77aedba351788a03eee54
2018-03-28Replace assets "quantum_ic_videocam_white_24" with a vector asset.linyuh
Test: Existing tests PiperOrigin-RevId: 190820867 Change-Id: I4835bcbc7698075fb54015dccc6823ada4c71651
2018-03-28Delete dialer blocking in NUItwyen
System blocking should be used instead. These code are obsolete. Bug: 70989544 Test: TAP PiperOrigin-RevId: 190818334 Change-Id: I71475905ba110fdc0560991a2a9c2b9e2f2de9f2
2018-03-28Turn transcription on if new user accepts Dialer ToSuabdullah
When a user accepts the Dialer ToS for the first time, we should also enable transcription if it is available. Bug: 74033229 Test: N/A PiperOrigin-RevId: 190794147 Change-Id: I7eb9b3d481426aceb55a8990fdbd246101937e7b
2018-03-28When declining Transcription ToS, we should hide the feature ToS.uabdullah
When a user declines the transcription, we should turn off transcription and never show the transcription promo ever again. Bug: 74033229 Test: N/A PiperOrigin-RevId: 190790323 Change-Id: Ida60592b0550b18b28e7f7a7a22d19100f56231a
2018-03-28Badge contact photos in the new call log for video calls.linyuh
Bug: 70988682 Test: NewCallLogViewHolderTest PiperOrigin-RevId: 190783830 Change-Id: Ib0b1ec23b7c278b83516019924b6c68ff12adaf9
2018-03-27Support new call log fragment in old peer.zachh
This makes the old peer read the CallLogConfig#isNewCallLogFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewCallLog and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog and PhoneLookupHistory databases would be read, which would trigger creation. I don't expect this to be a common case because 1) we hopefully never have to disable the framework and 2) Framework is only updated on Phenotype broadcasts and JobScheduler jobs, which hopefully don't typically happen when user is viewing the call log. However, I still want to make sure that if it happens we don't irreversibly break users when we turn the framework back on. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the call log tab, speed dial tab, and while the activity was paused (pressing Home after viewing call log). Note that this CL doesn't address showing missed calls and badge counts correctly with the new fragment; that will come in a later CL. Bug: 74821995 Test: unit and manual PiperOrigin-RevId: 190706481 Change-Id: I618d9c1649169abd65733502cfebc662a835e787
2018-03-27Use CallLogConfig for enabling new peer.zachh
ConfigProvider should not be used directly for reading NUI flags as CallLogConfig needs to perform work when they change. Bug: 74821995 Test: existing PiperOrigin-RevId: 190698415 Change-Id: Ic084d9032d2a6f35ffba9f395eaaff9053cfa262
2018-03-27Turn on transcription when existing dialer user accepts ToS and ↵uabdullah
transcription is available. Also updated the isVoicemailAvailable helper method, since just checking if the flag and OS is not enough (we have other things such as is VVM enabled, is VM activated), if we don't do this, it doesnt make sense to turn on transcription e.g Why what would happen if transcription is turned on but vvm is disabled Bug: 74033229 Test: Added a todo, will be added later (there are a few more similar CL's that I am sending for other ToS conditions) to ensure the logic is correct for all ToS conditions first and I can add a test right at the end for all conditions. PiperOrigin-RevId: 190696695 Change-Id: I9cb063a97e11943abeb1f823dc661efe88dfa3f1
2018-03-27Turn off transcription when user declines tos (existing dialer user)uabdullah
When an existing dialer user is shown the ToS and they declines it, the transcription setting must be turned off, to respect the users wishes. We also no longer take the user to the settings page. Bug: 74033229,77147114 Test: Unit test PiperOrigin-RevId: 190682249 Change-Id: I8c0abf9f3cbb15ded12a760abe540c557fd2e7d3
2018-03-27Delete debugging logging statement in voicemail spam blockingAndroid Dialer
Test: N/A PiperOrigin-RevId: 190673495 Change-Id: I1587449f6b0b53e7a16aac0b334225649a94f27b
2018-03-27Add permission for in-call visibility changeroldenburg
Bug: 76445204 Test: n/a PiperOrigin-RevId: 190650130 Change-Id: I594a16676cfcca4e6a10c1f5bc6604509417ad23
2018-03-27Update T-Mo Transcription ToS for existing usersuabdullah
Adds the we can turn off transcription from settings. Bug: 76226374 Test: N/A PiperOrigin-RevId: 190626638 Change-Id: I22b56f133cc83749cdd52a4406be0c36c5a0d0ac
2018-03-27Update T-Mo Transcription ToSuabdullah
Adds the we can turn off transcription from settings. Bug: 76226374 Test: N/A PiperOrigin-RevId: 190623712 Change-Id: Ib2990f9ba025cc5a7f51ba7f7b7d85085327cae9
2018-03-26Remove TODOs left for M in the new call log as the min SDK has been bumped to N.linyuh
Bug: 72125574 Test: None. PiperOrigin-RevId: 190572832 Change-Id: I581d3c9e366a1190c1608b369700aeb511fe51d1
2018-03-26Change the maximum number of notifications per tag from 10 to 8.linyuh
For grouped notifications, the system UI only displays the last 8. Bug: 74132249 Test: NotificationThrottlerTest PiperOrigin-RevId: 190544350 Change-Id: Idc52f4e98c1262bcb16a7a5052829b0a0faaacc6
2018-03-26Fixed drag to remove favorite contacts on a few devices.calderwoodra
There were 2 issues at play here: 1) views not being able to leave the list view bounds 2) RemoveView not getting drag events. Their resolutions are: 1) add a drag drop listener to the root layout of the activity, now the view can be dragged anywhere. 2) Drag events are only sent to views that are visible, so we no longer set the remove view visibility to GONE and instead set it's contents to GONE. Bug: 76086197 Test: manual PiperOrigin-RevId: 190526568 Change-Id: I3360015f65a134a896601d6298d07163844e302c
2018-03-26Add 311910 to motorola sprint configs.twyen
Bug: 76405608 Test: TAP PiperOrigin-RevId: 190517564 Change-Id: If0de75264b9c604f6bdf9536997c95c3cee9e0b5
2018-03-26Remove obsolete methods in CompatUtils and rename it as "LocaleUtils".linyuh
Test: Existing tests PiperOrigin-RevId: 190516504 Change-Id: I5fa9e123b45beb9728257ecd160a348fb3f4732c
2018-03-26Placing a call from a search action now closes the keyboard.calderwoodra
Bug: 74784637 Test: impl PiperOrigin-RevId: 190515545 Change-Id: I70f2e6db078f3a83fc33e8493b6af143184fe736
2018-03-26Add Motorola hidden menu to all Sprint MCCMNCstwyen
Before this CL it is only added to 310120. The values are moved to the base values, and the overrides override the enabled flag instead. Multiple SPN matching is also added. Bug: 76405608 Test: TAP PiperOrigin-RevId: 190515244 Change-Id: Ia937f0300ade57dc7a1b36df1433865ee4837a23
2018-03-26Remove obsolete version checks and compat utilities after min SDK was bumped ↵linyuh
up to N. Test: Existing tests PiperOrigin-RevId: 190508397 Change-Id: Ia5f33e45af1d1cc666fec5f43efa564b2b68c193
2018-03-26Bump version codes and name to v20roldenburg
Test: n/a PiperOrigin-RevId: 190500474 Change-Id: I1d73a90bf37b36c454b2d72102193764f4e25013
2018-03-26Move spam setting related methods out of spam interface into a separate spamAndroid Dialer
setting interface. Test: All the existing tests PiperOrigin-RevId: 190314880 Change-Id: I030acbd70120f508c5a4616757d89113524110fa
2018-03-26Add logging support for auto blocked spam calls.Android Dialer
Test: N/A PiperOrigin-RevId: 190307083 Change-Id: Ifb0ee63d8d9c7cd247f2a2d36595e48f33fa72af
2018-03-26Forward extras from pre call external receivers to placeCall().twyen
All extras that CallIntentBuilder handles will be stripped and read into the builder. Other entries will be send to telecom when the intent is build. Renamed CallIntentBuilder.outGoingCallExtras for clarity. Bug: 72877810 Test: Unit tests PiperOrigin-RevId: 190301333 Change-Id: I9a8bf6664b270078d91dbfb3398f8990d243b9f8
2018-03-26Bumped a few more tests to N.calderwoodra
Bug: 73902692 Test: tap PiperOrigin-RevId: 190298092 Change-Id: Icb9f26a93b6e3c27a836442c48a9dd6f99124785
2018-03-26Check empty number before querying data ID for preferred accounttwyen
In call UI might use PreferredAccountWorker with a voicemail URI that has no numbers. Bug: 76205637 Test: Unit tests PiperOrigin-RevId: 190298082 Change-Id: I9949de5499958c408d6e1bf18cab6e77852d2487
2018-03-26Fix UK numbers in international format with extra 0twyen
See class comment on UkRegionPrefixInInternationalFormatHandler Bug: 32501490 Test: Unit tests PiperOrigin-RevId: 190296011 Change-Id: I6f01935f022fc288ad702735b38cb297fb9d2621
2018-03-26Cleaned up the AndroidManifest Intent Filters.calderwoodra
Bug: 75962274,75967273,75972847 Test: manual PiperOrigin-RevId: 190251834 Change-Id: I3673a6b20a886ded86dc4e1a8f75a82e5e0bb199
2018-03-26Removed NUI shortcut.zachh
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig. Other related changes to help accomplish this: -Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework. -Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest). -The "Main" package is also on longer needed since it existed to control the shortcut. Bug: 74821995 Test: existing PiperOrigin-RevId: 190251418 Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
2018-03-26Implement wifi emergency calling warningtwyen
The warning is shown when there is no service, and the carrier requires the message to be shown because they cannot make emergency call over wifi. Bug: 68030294 Test: Unit tests, integration tests. PiperOrigin-RevId: 190241868 Change-Id: Ia6b838ac1e8e62ad6b40d97c1cf1a970491c1e6f
2018-03-26Fix CallLogGroupBuilderTest after min SDK was bumped up to N.linyuh
Bug: 76154272 Test: CallLogGroupBuilderTest PiperOrigin-RevId: 190187854 Change-Id: Ib96c406c4bb0627729c24c58c526850ff4fda22f
2018-03-26Show SIM auto select reason in in call UItwyen
The assisted dialed string will also along show with the "calling via" label. To handle the long string, Top row is now a marquee. Bug: 72571130 Test: Unit tests PiperOrigin-RevId: 190156719 Change-Id: I18a13712bdc9d780f744ef65a1773d249e40fb15
2018-03-26Correctly display phone numbers containing whitespaces in RTL context.linyuh
Bug: 74421656 Test: DialerBidiFormatterTest PiperOrigin-RevId: 190154072 Change-Id: Ic7cb3be702dd28b07b6e5e1e6d89f75f0bb12655
2018-03-26Increase minSdk to 24.calderwoodra
Manually set to M - MissedCallNotifierTest (not sure what the issue is here...) - CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown) - MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory)) Ignore Tests - a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason) - VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear) Bug: 73902692 Test: tap PiperOrigin-RevId: 190030202 Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
2018-03-26Delete old search, old contacts, p13n logger, filtered numbers add number ↵calderwoodra
search. These components are safe to delete because: - New Contacts has been in prod for several releases. - New Search has been in in prod for 2 releases. - p13n logger was based on old search and is no longer being implemented in Dialer. - Filtered Number Settings contact search since we no longer support M. Bug: 37208802,73902692 Test: tap PiperOrigin-RevId: 189992017 Change-Id: I2720a252ababd164b5d0fb1011753a3c96a704d1
2018-03-26Add learn more info to VM Transcription settinguabdullah
Updates the transcription setting from using a switch preference to a SwitchPreferenceWithClickableSummary. This allows the voicemail transcription setting preferences summary to be clicked and opened to the specified learn more url. Bug: 74033229 Test: Unit Tests PiperOrigin-RevId: 189983125 Change-Id: I1b162f3e2e582243fe8f84633e9401155170194c
2018-03-26Add RootComponentGenerator to auto-generate root components for different ↵Weijia Xu
dialer variants. Bug: 35612086 Test: Test included PiperOrigin-RevId: 189981890 Change-Id: Ife99969189d5d37bb1ad8ba61361a51e78abdfbb
2018-03-22Use SwitchPreferenceWithClickableSummary instead of SwitchPreference for VM ↵uabdullah
Donation The learn more link needs to be in the summary of the switch preference, however having a hyperlink in the summary text view of a switch preference does not open the hyperlink. To do this we made our custom switch preference which allows the summary to be clicked. All other aspects of the switch preference remain the same. Bug: 74033229 Test: Unit test PiperOrigin-RevId: 189978676 Change-Id: I31e744f3545e576ee3f5ac4a8fee249e22835e19
2018-03-22Removed appContext from CallLogDataSource and PhoneLookup.zachh
Impls can access appContext via dagger. Test: existing PiperOrigin-RevId: 189974157 Change-Id: Ie64d2c6f9ba08fc914d3c31f7e014c2beef3ab00
2018-03-22Show VM activating in settingsuabdullah
When a user enters the voicemail settings page and the voicemail is still being activated, we need to show the "Activating...." string to tell the user that something is still happening. This is important since unless the activation has happened, other settings are not visible e.g transcription and donation Bug: 76107888 Test: N/A PiperOrigin-RevId: 189970472 Change-Id: Ib9eeee64cd67c2adc4830a743516851ffa637fbf
2018-03-22Enable and disable the call log framework on flag changes.zachh
Bug: 74821995 Test: unit PiperOrigin-RevId: 189969399 Change-Id: I8e287cc7884dde7640721bd385fe383a4635f3c8
2018-03-21Display "Emergency number" in the call log for emergency numbersmaxwelb
This CL updates the call log to show "Emergency number" for call log rows from numbers that PhoneNumberUtils.isEmergencyNumber considers to be emergency numbers. Bug: 66926712 Test: Manual, see above PiperOrigin-RevId: 189953302 Change-Id: Ibaae243ead8b918a26f6058164316e042a4f82fd
2018-03-21Remove "contacts/common" from the dependency list of package "dialer/widget".linyuh
Bug: 74421656 Test: Existing tests PiperOrigin-RevId: 189935875 Change-Id: I834e15b7ff102ea021d7a99ebe568998a9c43603
2018-03-20Added "clearData" to CallLogDataSource and PhoneLookup interfaces.zachh
This is necessary to disable the call log framework via flags. This isn't yet called anywhere. Bug: 74821995 Test: unit PiperOrigin-RevId: 189838957 Change-Id: I926c02c41151528eabc208c874acbfe7897a2f93
2018-03-20Identify MMI codes specific to some OEM devices via hard-coding.linyuh
Bug: 72162360 Test: SpecialCharSequenceMgrTest, TranssionUtilsTest PiperOrigin-RevId: 189825957 Change-Id: Ia161ad47c4122d33c108b545540707bb18076464
2018-03-20Mitigate some of the jank in opening/closeing search.calderwoodra
There is still some jank on first open, but it's much less janky on close and consecutive open calls. Test: existing tests confirm no regressions PiperOrigin-RevId: 189802733 Change-Id: I49d6c2def7c33be0fdbb79c89772a5e4513cde3b
2018-03-20Fix animation of first time showing dialpad FAB.wangqi
In order to correctly show animation, we have to ensure: 1. fab.scaleIn() is not called before dialpad is slide up. 2. fab is invisible before scaleIn is called. Caveat: This change is not tested on old UI (DialtactsActivity) since it's deprecated. Test: manual PiperOrigin-RevId: 189765153 Change-Id: Iada96b2789f96ca1612ae2048020a649f8b57b6b
2018-03-20Added unregisterContentResolvers() to CallLogDataSource and PhoneLookup.zachh
This is needed to support flag changes which should cause the call log framework to become disabled. It's not called anywhere yet. Bug: 74821995 Test: unit PiperOrigin-RevId: 189761665 Change-Id: I914c690448f03ebacd7d05c9ad082aba7bf1a4ce
2018-03-19Make the top row of the bottom sheet not clickable.linyuh
Test: Existing tests PiperOrigin-RevId: 189683790 Change-Id: I0209e7fa839175041da29e9a6d8a590133121376
2018-03-19Convert @AutoValue VoicemailEntry to a protolinyuh
Test: Existing tests PiperOrigin-RevId: 189678764 Change-Id: I6b9edd99e727788c65d325c1be43f0190c25c30e
2018-03-19Convert @AutoValue CoalescedRow to a protolinyuh
Test: Existing tests PiperOrigin-RevId: 189675976 Change-Id: Ieae92b5ac2aefd3f0397bbb07ebb1c97bd72ed42