Age | Commit message (Collapse) | Author |
|
The filtration logic will only show countries
in the country picker if the feature is enabled
for those countries.
This will not cover the regressive case where
a user has already selected a default option,
but then the option is later removed. This
behavior is currently undefined.
Bug: 69274259
Test: unit tests
PiperOrigin-RevId: 177881199
Change-Id: I113f6d25249c42c1bd98383fd6ee0bc6a8c0e615
|
|
Bug: 36841782
Test: implemented
PiperOrigin-RevId: 177516412
Change-Id: If9478ce22c10fd17e352d5fdcc2c0bef5e14a6d8
|
|
If a user, for example, opened dialpad search then entered multiwindow mode,
the actionbar would be visible and search results maligned. This change
corrects that by updating it's state once possible.
Test: manual
PiperOrigin-RevId: 177497979
Change-Id: I41d4910b5bb92e29623960e7d4741a9a961e5b9e
|
|
Copybara is fixed for AOSP export
Bug: 68665330
Test: rollback
PiperOrigin-RevId: 177480870
Change-Id: I0ba38e213bb840436fa6dafc4af0a79019ee93f4
|
|
Rewrote FakePhoneLookup to be more realistic.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 177376374
Change-Id: Ifcd52b16b7046f39d1bfc0e8b8e76452a9daadd2
|
|
Since we close the original cursor we queried in the cursor loader,
we need to assign a new content observer to the cursor we build so
that our search results update when there are changes to the contacts
db.
Bug: 63830179
Test: manual
PiperOrigin-RevId: 177368459
Change-Id: I025ea70334265cb2fdc651ed7ea046b039738e94
|
|
Bug: 69857502
Test: TAP
PiperOrigin-RevId: 177367228
Change-Id: Id79546672fa8bf3bf85bbe569ef638970b1365d8
|
|
Currently, the only other client that is initiating
calls is Contacts, and we consider that to be a
non-idle-dial.
Bug: 69860859
Test: existing unit tests
PiperOrigin-RevId: 177367226
Change-Id: I22de38dc973f5a1eecfe42833110690744c317fd
|
|
In a subsequent change, the assisted dialing settings
will be able to use the parsing logic to filter
the available countries listed in the settings.
Bug: 69274259
Test: existing tests
PiperOrigin-RevId: 177338864
Change-Id: I8ef76874d5f6d885b415174371225b738cc68716
|
|
Test: N/A
PiperOrigin-RevId: 177336359
Change-Id: Icec2eacef55ea6c1b3aad00fe10cde6284c89e25
|
|
For privacy reasons we now delete all voicemails and transcriptions when
the user disables visual voicemail, (after confirming that they want to do this
via a dialog).
Note: we only delete voicemails whose source package is the google dialer.
Note: the voicemails will be re-downloaded and re-transcribed if the user re-enables visual voicemail
Bug: 69323147
Test: manual and unit test
PiperOrigin-RevId: 177315139
Change-Id: Ie04496dc5960b485794733fbf74f7f704e806023
|
|
Bug: 69812286
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 177227451
Change-Id: I6cf53e50d17860f4374cbd9a94451bc0731905a4
|
|
Argentina mobile numbers.
Bug: 30224215
Test: DialerPhoneNumberFormattingTextWatcherTest, DialpadFragmentIntegrationTest
PiperOrigin-RevId: 177218942
Change-Id: Id6eaaad2f6d81e591d59a1d8444f45fb06f3f8d5
|
|
the lockscreen
Bug: 69812359
Test: PreCallActivityTest
PiperOrigin-RevId: 177193665
Change-Id: Ic61819b8456ee22c01228d6be2255b3f2c1e418a
|
|
This will be used in a subsequent change to show the user
the default/predetected country code in the assisted dialing
settings.
Bug: 68775522
Test: unit tests
PiperOrigin-RevId: 177168946
Change-Id: Ic738a6ddde8766962a725668f6db5056ab0bcafd
|
|
Bug: 69562852
Test: none
PiperOrigin-RevId: 177165337
Change-Id: I297faa26d778ec39f2365e84e90398e7ab49f353
|
|
The contacts fragment recycler view was rebuilding the adapter and layout
manager each time the Contacts.CONTENT_URI observered a content change. Now we
simply update the adapter's cursor and notifyDataSetChanged. This keeps the
recycler view in place through all changes (inserts, deletes and updates).
This change also fixes another bug replated to contacts fragment not refreshing
when the contacts permission was granted in another part of the UI.
Bug: 64044576,67781478,68179085
Test: manual
PiperOrigin-RevId: 177106761
Change-Id: Ib6a929efb047001d681cb008c3ede69860146836
|
|
Test: N/A
PiperOrigin-RevId: 177075957
Change-Id: Idf4546c57aba72470e07614d2a20d828da8ee08d
|
|
Bug: 69618691
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 177062349
Change-Id: I4bc9098d06c541b607cca293269cf3489077b6c2
|
|
Allow users who have agreed to donate their voicemails to also provide
transcription quality feedback.
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIajVtdFN3Y0Qydmx2NXJYN2N3OVA3N0h5UEdR
Bug: 68712148
Test: manual and new unit tests
PiperOrigin-RevId: 176774942
Change-Id: I08b9afbbefaedfb0de5199038a1d2769bd983855
|
|
OnPreDrawListener can be triggered AFTER a device orientation change but BEFORE DialpadView's onDetachedFromWindow() and onFinishInflate() are called, i.e., the listener will attempt to adjust the layout before it is inflated, which results in a crash.
This fix is to remove the listener after all keys are adjusted for the first time since no more adjustments will be needed during the rest of DialpadView's lifecycle.
Bug: 69665429
Test: DialpadFragmentIntegrationTest
PiperOrigin-RevId: 176718488
Change-Id: Iff8a4108c73054a9e76725ef85e2559b90fe5f3e
|
|
Most devices are DSDS (dual SIM dual standby) which only one SIM can have active calls at a time. Telecom will ignore the phone account handle and use the current active SIM. The SIM selection dialog has no effect, and the change SIM button will just redial with the same SIM.
Bug: 69417430
Test: CallingAccountSelectorTest, CallButtonPresenterTest
PiperOrigin-RevId: 176718021
Change-Id: I231cfeaa5ff77c29cdaf8e0865d096c85cfb7fc4
|
|
FLAG_SHOW_WHEN_LOCKED is added to PreCallActivity so it can be launched in lockscreen.
PreCallCoordinator now grabs new instances of PreCallActions onResume so the state can be flushed. If it is reused states like PendingAction might be used after it is discarded.
Added null check before discarding fragment because it might not be created yet due to background query.
Bug: 69570769
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 176714225
Change-Id: I8b09441bd1cdb8df835978a1d82b53a3d3d056e0
|
|
Bug: 69570769
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 176706378
Change-Id: I50da0d2dd40a83ae6c1189fed2693368369849d3
|
|
Preferred SIM can only be enabled when both dialer and the system contact app supports it. This CL checks if the app for ACTION_QUICK_CONTACT has the metadata supports_per_number_preferred_account. Also added a flag to disable the whole preferred SIM feature.
Bug: 69638458
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 176687062
Change-Id: Id00debe2393068a422907a9eff2ac4ef0fcf6f8e
|
|
Bug: 69556012
Test: SpamJobSchedulerTest
PiperOrigin-RevId: 176683042
Change-Id: I2807510e3c511c1672ed2c49117ad03b92c4cee5
|
|
Including:
- Use exit-to-app icon instead of fullscreen icon for back-to-call button
- Use ripple for first button since it needs top-rounded background
- Change red hang-up button color and grey icon and text color
- Change some dimensions
Bug: 67605985
Test: manual
PiperOrigin-RevId: 176678427
Change-Id: I3f7836d832f7130f82d7f3764fb392807f3fab9a
|
|
In the call log UI, an entry can be deleted by selecting "delete" in its context menu.
In the call details UI, a "delete" button is added at the bottom.
The "delete" icon at the top right of the call details UI is removed.
Public-Origin-Change-Id: Iabe1310fb9a97a277cf482a3fd61ffccbec125fe
Signed-off-by: Linyu He <linyuh@google.com>
Author: Masafumi Miya <masafumi.miya@sony.com>
Bug: 38188896
Test: CallLogActivityIntegrationTest, CallDetailsActivityIntegrationTest
PiperOrigin-RevId: 176677167
Change-Id: I2e31cd112efdfb83393f5e68ce016dcf36ac4858
|
|
android:showWhenLocked and FLAG_SHOW_WHEN_LOCKED is added to PreCallActivity so it can be launched in lockscreen.
PreCallCoordinator now grabs new instances of PreCallActions onResume so the state can be flushed. If it is reused states like PendingAction might be used after it is discarded.
Added null check before discarding fragment because it might not be created yet due to background query.
Bug: 69570769
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 176587256
Change-Id: Iaa7145e860136e9177f568e2c84461ed5efa12a1
|
|
Test: No impact on existing functionalities
PiperOrigin-RevId: 176562444
Change-Id: I209379dde3e920a27d6e735c8494647154e40e5a
|
|
PhoneLookup.DATA_ID is only available after N. The fallback database should address this in a future CL.
Bug: 69420158
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 176534281
Change-Id: I51ae1705fce6d7d4138b41fbd00d131447e49786
|
|
I accidently made the search/dialtacts UI TOO performant and everything was
happening too quickly. Postponed closing the dialpad and exiting search until
onPause, but immediately close the keyboard so it isn't visible over the in
call ui.
Bug: 69313203,68857994
Test: see video
PiperOrigin-RevId: 176531801
Change-Id: I52729c451d46ad00ac87c47f189134694554d33a
|
|
Bug: 68272141
Test: n/a
PiperOrigin-RevId: 176531675
Change-Id: Ia6cc29c4285ebe280d23a81f91007a02a65855b3
|
|
Test: On a local device.
PiperOrigin-RevId: 176443649
Change-Id: I73982924baf6ce0e947137766ec0038decd716e5
|
|
Test: new unit tests
PiperOrigin-RevId: 176438950
Change-Id: Ic0747302170593b91da4148029396c36ab070c6e
|
|
When the activity is launched it might immediately attempt to verify the stored pin, which happened before the executor is initialized
Bug: 69179171
Test: N/A - legacy code, refactoring required
PiperOrigin-RevId: 176433263
Change-Id: I8202a760dbfc7759e128ef31d477510526d0bee7
|
|
Bug: 64216442,64214592,64213352
Test: N/A
PiperOrigin-RevId: 176424724
Change-Id: I1709156098a14ac3bd35d98b913e7b881fcd9b2b
|
|
When resumed runNextAction() will assert that pendingAction is null so if there's any it won't be interrupted. When the coordinator is paused all dialogs and pending actions must be discarded. If the pending action is not properly discarded it will still assert when trying to call finish().
Bug: 69069675
Test: PreCallCoordinatorImplTest
PiperOrigin-RevId: 176420108
Change-Id: Ie89bda3621371a105dc58ff02d83812194a1ea0b
|
|
Bug: 69431528
Test: On a local device.
PiperOrigin-RevId: 176420058
Change-Id: I3013800d86597b19268723377112286d2e2ceb68
|
|
Bug: 69463065
Test: manual
PiperOrigin-RevId: 176399153
Change-Id: I699688ab47c1ba497a0b6bb3301380a8e06f2ee2
|
|
Since CallingAccountSelector is currently the only action that requires a UI, disabling it will effectively revert the PreCall behavior back to pre-PreCall era, sending intents to telecom directly.
Bug: 68953196
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 176398440
Change-Id: I612a56bc66f32cf72779bd7c507de6a0784f1298
|
|
This was caused by cl/176065849 where we added a per carrier check
to see if transcription is supported.
new screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuINkJ0R0JPTUZWSlpDMmlaRFdEUnJkY3pyTmxR
Bug: 67457582
Test: manual and updated unit test
PiperOrigin-RevId: 176389716
Change-Id: Ib41607a0ec6e9b40092d32fe055db80b6f9f8301
|
|
Including when:
- onStop()
- switching tabs
Also move old CallLogActivityTest to espresso directory.
Test: CallLogActivityTest
PiperOrigin-RevId: 176387019
Change-Id: Icbb77747882c8a5e35595557baa6917a4dc674b6
|
|
This change expands Cequint Caller ID to more provider name and adds signature
check to avoid fake provider fraud.
Bug: 69061848,69310040
Test: CequintPackageUtilsTest
PiperOrigin-RevId: 176386836
Change-Id: I02bb3f67d74f7cccbf99b0967e517595c6c2033b
|
|
This means that names like "Bob Dylan" can be displayed as "Dylan, Bob" and
the names are now able to be sorted by last name as well.
This change also adds content descriptions to search icon for a11y.
Bug: 68293751
Test: NewSearchFragmentTest
PiperOrigin-RevId: 176382228
Change-Id: Ia890ad20e9e484fa9c4622c4b899b33f5b6e3990
|
|
recycling views.
The adapter maintains the state of those voicemails that were expanded. When the views are recycled we ensure that the expanded view holder whenever visible is expanded. However when an expanded viewholder is collapsed, taken out of view and then brought back into view (recycled), the expanded state is preserved. This CL ensures that this no longer happens.
Bug: 64882313,68382421
Test: Unit test
PiperOrigin-RevId: 176233960
Change-Id: Ib57859a287ec0c4f9e955a0fc01a49f093023fd1
|
|
When a user types a phone number into the search bar, there isn't an intuitive
way for them to place a call when the number doesn't match any existing
contacts in the new search UI. This change adds the option to place a voice
call from regular search, like the old UI.
Bug: 69385190
Test: NSFT
PiperOrigin-RevId: 176189153
Change-Id: I6c1561bcce104c56855d996570a79b34da7230ff
|
|
during search.
We have observed in the wild that some apps implementing remote directory don't seem to respect the where clause.
Note that if a search returns 10 results, and 4 of them have null numbers, we will only show 6 numbers where ideally we'd show 10. (It would take a lot of work to fix that just to workaround misbehaving providers which I don't think is worthwhile.)
Bug: 68942044
Test: unit + manually changed guard condition and observed rows hidden
PiperOrigin-RevId: 176183008
Change-Id: Icdb26fa043644e27a4b6ac3c767c728b3ca224ff
|
|
Changes:
1. Rewrote the logic to pick a NumberFormat.
2. Deleted dead method setShowVoicemailButton(boolean) and field mCanDigitsBeEdited.
3. Deleted the redundant SDK version check when getting a Drawable.
Test: DialpadFragmentIntegrationTest
PiperOrigin-RevId: 176181808
Change-Id: Iee4e3db8535ebbea3d4c63c8d8c1d3eb342b538e
|
|
Bug: 66900825
Test: manual
PiperOrigin-RevId: 176155772
Change-Id: Ibe722477b90671b55ff7bf5405de9fb66569d43e
|
|
Bug: 68942044
Test: NO
PiperOrigin-RevId: 176147553
Change-Id: Ia22751f02cdd621c2095e8e476a3077db2c541fa
|
|
This cl just adds a check before starting a transcription job
to verify that the user has accepted the appropriate TOS. Its
a rather big cl just because it had to expose some TOS acceptance
details that were previously encapsulated in the VoicemailTosMessageCreator.
Bug: 69267260
Test: manual and unit tests
PiperOrigin-RevId: 176132370
Change-Id: Ic28fb197a07f9df7a9b5f1729c84566cba0890fc
|
|
This cl adds two classes, one to calculate a base multiplier for an exponential backoff series and the other to return sequential values in an exponential backoff series.
This cl has a number of advantages over the previous one, such as:
- separating the base multiplier calculation from the exponential backoff class so that a standard exponential backoff class like com.google.common.labs.concurrent.RetryStrategy.ExponentialBackoff could be used instead if it becomes open source
- allows the backoff sequence to be scaled by specify an initial backoff delay
- uses milliseconds instead of arbitrary time units which allows the tolerance to be set automatically when calculating the base multiplier
WANT_LGTM=zachh
Bug: 66966157
Test: unit tests
PiperOrigin-RevId: 176130268
Change-Id: I75135d4df16f642ea9dd3ef9ff9498981beae2c6
|
|
This CL adds a module that can query providers to aid users choosing which SIM to call with.
Bug: 64214592
Test: MotoSuggestionProviderTest
PiperOrigin-RevId: 176129303
Change-Id: Idb6314ad7f5a1bcd20b5b9173d3bfd873383cc84
|
|
Updated the following contents:
1.Fix the order of spawning connections for GSM conference.
2.Make VOLTE conference call more realistic.
3.Fix minor bugs about simulator.
4.Add SimulatorConnectionsBank class to store connection tags created by simulator.
5.Fix tests influenced by SimulatorConnectionsBank.
WANT_LGTM=wangqi
Bug: 67785540
Test: In dialer lab.
PiperOrigin-RevId: 176127584
Change-Id: I846174b97ed9329df6347583c41095f45f43494b
|
|
Test: DialpadFragmentIntegrationTest
PiperOrigin-RevId: 176122540
Change-Id: Iebf5ab67569fd4532411cfdae20ad5fb91cbcc55
|
|
Added a carrier config and check to see if the carrier allows over
the top voicemail transcription, and if not do not attempt transcription.
Bug: 68951869
Test: manual and unit test
PiperOrigin-RevId: 176065849
Change-Id: I69df1f2867420d7fdcc7f0a31e0e6c26da67abb1
|
|
If no actions require an activity, instead of launching the PreCallActivity, all actions will be performed immediately, and the call intent will be sent to telecom directly.
This reduces the latency & risk when mutli SIM is not supported.
Bug: 68953196
Test: PreCallImplTest, HeadlessPreCallCoordinatorTest
PiperOrigin-RevId: 176032790
Change-Id: I03258e8643f18c65a8e5b1a84b18b71b30638044
|
|
Also extracted FakePhoneLookup to a testing package.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 175923790
Change-Id: I866708a676e788051b369a024344967975c05979
|
|
EXTRA_PHONE_ACCOUNT_HANDLE is not implemented in O. subId is required to determine which SIM the settings is for.
Bug: 67669006
Test: VoicemailSettingsFragmentTest, TelecomUtilTest
PiperOrigin-RevId: 175913331
Change-Id: I84f9e19b711c5baa275d934cfdfd5b7a2d4b6f6d
|
|
Contacts need to check the meta-data to decide if the preferred SIM UI should be shown.
Bug: 64213352
Test: N/A
PiperOrigin-RevId: 175912590
Change-Id: Ic02ca47ab156c3bb752b33c97cfb3b62f45a3667
|
|
This change also enables search actions to be visible in regular search.
screenshot: http://screen/ULBgq2RnKnM
Bug: 68730642,67657783,68775021,66723880
Test: manual
PiperOrigin-RevId: 175892821
Change-Id: I2c71fe8ffa2ffddfbc88d777909c4837e0ea4384
|
|
This change updates search fragment to now preprocess query
results and hold them in memory. This significantly improves the
lookup runtime to be O(logn) on average and O(N) worst case.
Bug: 69100384
Test: existing (plus some time measurement regression tests)
PiperOrigin-RevId: 175891990
Change-Id: I6d7ae61c478b544af42d954af4e8580e052693ba
|
|
There must be a bug in FloatingActionButton because when you call
setImageDrawable multiple times (possibly with the same drawable/icon), the FAB
renders with no icon present. That's why the icon would disappear in
Fragment#onResume.
Bug: 69006360
Test: manual
PiperOrigin-RevId: 175878924
Change-Id: I1c36be3f9aeb003410f0bdbb9d52b5a483262f03
|
|
Replaces the existing buttons with Image Buttons using standards images. Also added a phone button.
Bug: 64882313,68382421
Test: Unit Tests
PiperOrigin-RevId: 175843834
Change-Id: I21898f7da72f3dd17fce0047b11349737b373513
|
|
Test: PreferredSimFallBackProviderTest
PiperOrigin-RevId: 175769540
Change-Id: Ie4e33f32ae9e99da92baa9906a3576df31b1b0a3
|
|
This allows one notification per SIM to be shown on multi SIM devices
Bug: 64010653
Test: LegacyVoicemailNotifierTest
PiperOrigin-RevId: 175756590
Change-Id: I8c2fe3ec06c5e6868ddc647742ab9ef422494b3b
|
|
Voicemail URI and duration are both retrieved from VoicemailEntry. This CL combines it.
This was a todo added from http://cl/175585919
Test: unit tests
PiperOrigin-RevId: 175718355
Change-Id: I7d2748cf6e110e494f6895c512ce355aa2d048a7
|
|
The duration of the voicemail shown in the seekbar/media player (upon expanding) should be the same as the duration shown when the voicemail view holder is collapsed. Both values are retrieved from the same source (VoicemailEntry).
Bug: 64882313,68382421,69268144
Test: Unit Tests
PiperOrigin-RevId: 175712662
Change-Id: I70496c004d52deb1793e6d6354b0ec79bf4c4398
|
|
This will be used in the PhoneLookupDataSource. A separate URI is necessary because the content provider APIs do not provide a mechanism for querying using the "distinct" keyword.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 175706603
Change-Id: Ia455a18d10afb116d26f69e8b0c7493f4f877d0b
|
|
This CL fixes crashes that are caused by opening the
PhoneDisambiguationDialogFragment after the associated activity is destroyed.
This is done by detecting when the activity is destroyed or finished.
Bug: 69133504
Test: PhoneNumberInteractionTest
PiperOrigin-RevId: 175623483
Change-Id: Ic639e9e9421205edcb5438d594bb144c6b09dd86
|
|
Adds the UX support for showing the seekbar in the NUI Media player. It also shows a starting and total duration text as well, though as of right now it's a static value and will be updated in a follow up CL.
Bug: 64882313,68382421,69268144
Test: Unit tests
PiperOrigin-RevId: 175595293
Change-Id: I14440599d52352c213c7513dd2d0a8aef2f51bfe
|
|
Before prompting the user to select the SIM, CallingAccountSelector will lookup the fallback preferred SIM database to see if a preferred SIM is already set and bypass the selection. If the number is in contacts the user will also have the option to store the selected SIM as preferred.
Bug: 64213352
Test: CallingAccountSelectorTest
PiperOrigin-RevId: 175592732
Change-Id: I6a5a8ad8772eccfb4a119c529dcd3945b9dc0b1e
|
|
This CL adds an activity that will forward parameters to PreCall so external apps like contact can utilize SIM selection or assisted dialing features. The caller needs to have CALL_PHONE permission.
Bug: 64213352
Test: LaunchPreCallActivityTest
PiperOrigin-RevId: 175591732
Change-Id: I096ea022d5ed87c29ffb191cd1bdb04e3a17c945
|
|
Voicemails that are available locally on the device (have been downloaded from the voicemail server) will have their "HAS_CONTENT" column set to one. This CL adds the plumbing logic of checking that when a user presses the play button, if the voicemail is available locally, it is played.
Bug: 64882313,68382421
Test: Existing unit tests
PiperOrigin-RevId: 175590204
Change-Id: Id164d08c16b89c84a75af0c4a7c899c02d64fff7
|
|
Bug: 69133607
Test: manual
PiperOrigin-RevId: 175586518
Change-Id: I9c03da6f559e2943d30220aefc399ba2a7842f29
|
|
Test: LoggerUtilsTest
PiperOrigin-RevId: 175555340
Change-Id: Ic38e4e60559d91d3471629a5ffff496081fb5fb9
|
|
The PhoneAccountHandle is keyed with the DATA_ID of a Phone row in the Contacts provider.
Bug: 64213352
Test: PreferredSimFallbackProviderTest
PiperOrigin-RevId: 175354818
Change-Id: I828ff9d5a1e03e18b05256bcf8a61170be8ce7bc
|
|
They should work now that we target guava 20 instead of 18 in AOSP.
Test: tap
PiperOrigin-RevId: 175354039
Change-Id: Id7844c3a1c8e29e5ecb13fa36a92dd80be0cfc7c
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 175342952
Change-Id: I0e0318c5471605dfc47553552f558c65d41f9e9e
|
|
This is caused by normalizing numbers from dialpad search into search box, while "add new contacts" and "send sms" etc. wouldn't work properly without full number.
This change also fix "send sms" in old search fragment.
This change includes upstream change from:
https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/530377/
Change address format when sending message from smart dial
In Android O, send search key number as address to message app.
In Android N, send real input number as address to message app.
Fixed the issue by reverting to Android N implementation.
Affected Area:
Send SMS operation from Dialer smart dial search result list.
Bug: 68962106
Test: manual
PiperOrigin-RevId: 175317850
Change-Id: I96dd576144f93f7502977bfdb4b9e9d9c8f73526
|
|
PhoneLookupInfo should contain one message per PhoneLookup implementation for clarity. Instead of having a repeated Cp2Info field, we now have a single Cp2Info field which wraps a repeated Cp2ContactInfo field.
Also added ApdlInfo to the message to make testing of CompositePhoneLookup more realistic, in that it tests merging across submessages now. (ApdlInfo is more or less a placeholder until ApdlPhoneLookup is implemented.)
Test: yes
PiperOrigin-RevId: 175316738
Change-Id: I196c2eaa885e1268ff80ebaad6d85840a9cc7a15
|
|
Bug: 34672501
Test: yes
PiperOrigin-RevId: 175243488
Change-Id: Iec3b5eb0e81f6e6cc04c64c3ea65c9c7fcb33fe3
|
|
The declared type of "STRING" has an affinity of NUMERIC, not TEXT per:
https://sqlite.org/datatype3.html
Bug: 34672501
Test: existing
PiperOrigin-RevId: 175237916
Change-Id: I220a35f3060eb60870f6e930c821bdb2f6d2c7ed
|
|
Bug: 68848807
Test: unit
PiperOrigin-RevId: 175190786
Change-Id: I15b525951cb87afb8b48f3bdb2174605c94c99cf
|
|
Including:
- change action icon color
- hide TextView for name if name is empty
- if name is empty, use number to generate avatar
- don't show number type
Bug: 67053842
Test: manual
PiperOrigin-RevId: 175188810
Change-Id: I4ba40e5332d7b8567932360d36c8dc6ec3d604a5
|
|
Bug: 68844134
Test: n/a
PiperOrigin-RevId: 175102999
Change-Id: I63e930809d4bb96669062f724fb9cab90d675afa
|
|
This CL adds an executor which runs tasks on the Ui thread, using the existing
ThreadUtil class.
Bug: 67752611
Test: UiThreadExecutorTest
PiperOrigin-RevId: 175046280
Change-Id: Iff15e216be0e91891a9d63fddf1288ecbec41f83
|
|
Bug: 68840377
Test: manual verify no regression from inconsistently showing promo
PiperOrigin-RevId: 174957368
Change-Id: I0ed4fa1b24e693e91705744f60a7a385385cec64
|
|
contacts.
Bug: 68942044
Test: none
PiperOrigin-RevId: 174944384
Change-Id: Ie03ce41e517cfb73081231898a7e9dcc3feee2f2
|
|
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction.
Bug: 64216442
Test: manual
PiperOrigin-RevId: 174924323
Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
|
|
CallingAccountSelector examines the CallIntentBuilder, and if the PhoneAccountHandle is missing on a multi-SIM device while the default is not set, it will show a dialog to let the user select it. This step used to be after the in call UI is launched and telecom wants dialer to disambiguate. This step is moved to pre call as dialer need more control, like voicemail calls should always prompt, or the preferred SIM info might be available. This also allows telecom to send the selected PhoneAccountHandle to other apps so they have more information on how to rewrite numbers.
AssistedDialAction replaces the step previously in CallIntentBuilder.build(), and rewrites the URI.
Pre-call actions are not hooked up for dialing in this CL yet, assisted dialing will still be broken.
Bug: 64216442
Test: CallingAccountSelectorTest, AssistedDialActionTest
PiperOrigin-RevId: 174917321
Change-Id: Iba2e9092f83c036b402d4044a48ff5c44e806210
|
|
When the user makes a call, the PreCallCoordinator will get a list of actions to perform from PreCallActionProviderComponent and apply them to the pending CallIntentBuilder, before sending the built intent to telecom
Bug: 64216442
Test: PreCallExecutorImplTest
PiperOrigin-RevId: 174911537
Change-Id: Ide5ec431d4e6e7879fcdfdbbbd7ea5eed9963b2c
|
|
Multi-SIM and several other new features requires additional user input (ie. select the phone account to call with) or processing (ie. rewrite phone number for assisted dialing) before the call is actually made. The plan is to use a chain of pre-call actions to complete the dialing infomation,with the CallIntentBuilder holding the intermediate steps. For example, a pre-call action can examine the CallIntentBuilder and figure that the PhoneAccountHandle cannot be inferred, and show a dialog for the user the select it. Only after pre-call actions are completed, the intent is built and sent to telecom.
Since pre-call actions involves dialogs and the process can be interrupted, the CallIntentBuilder must be persistable so the state can be restored. This CL made it parcelable so it can be stored with onSaveInstanceState().
The AssistedDialingMediator in CallIntentBuilder is temporarily removed as it would be called using a pre-call action in a future CL.
Bug: 64216442
Test: CallIntentBuilderTest
PiperOrigin-RevId: 174902775
Change-Id: Icf2f8fae620868d1a2f5acf0d08ae0a6bec4fb76
|
|
Test: Manual
PiperOrigin-RevId: 174792372
Change-Id: I80ff3852c40cd532fdd2ed332e8b84ffb211a6e2
|
|
All voicemails are called by using CallIntentBuilder.forVoicemail() so the PhoneAccountHandle can be designated. A future CL will use dialogs to customize the call (multi SIM selection, RTT, etc.)
As a result voicemail error messages and legacy voicemail notifications will call the account it is received from directly.
Bug: 64216442
Test: Unit tests
PiperOrigin-RevId: 174784322
Change-Id: Ibe1c57bc7852e3d55a39a0cc2da19b6a79954c0f
|
|
improve reliability.
Bug: 68941995
Test: Manual
PiperOrigin-RevId: 174782574
Change-Id: I93f358507f1f60b87e26e1bdcddf50ed1ef8e1b2
|
|
Test: In dialer lab.
PiperOrigin-RevId: 174781953
Change-Id: I987c0d191a7c5613debb857bab9438d0c1aa20a7
|
|
Author: Ravi Paluri <rpaluri@codeaurora.org>
Bug: 68677786
Test: CallButtonPresenterTest
PiperOrigin-RevId: 174740252
Change-Id: If20e9fb92c4d729a75edf8ac6d088a88d4d319d8
|
|
This adds a file called new_voicemail_media_player_layout.xml that can be expanded and collapsed on tapping the voicemail entry. This file will later be updated in accordance with the specs, but the logic for expansion and collapsing would not be affected by the future cosmetic change.
Video=https://drive.google.com/open?id=1aIpmVfUYrFrg_FZ4tRX_TX6pU9YgPQaN
Bug: 64882313,68382421
Test: Unit Tests
PiperOrigin-RevId: 174713873
Change-Id: I15a6c5f01715429a6eb51fee447a5b42f25fdb56
|