Age | Commit message (Collapse) | Author |
|
voicemail fragment
Bug: 70989658
Test: Manual
PiperOrigin-RevId: 197046549
Change-Id: I11f9515aad0b5d9c07ebb5d3ff480ed6751bd187
|
|
Bug: 70989658
Test: Manual
PiperOrigin-RevId: 196907085
Change-Id: If3db2d6906245f052e756b315365b9d306f9d06d
|
|
Bug: 71719349
Test: CallLogEntryTextTest, HistoryItemActionModulesBuilderTest
PiperOrigin-RevId: 195694340
Change-Id: Ib53305c36f7ca062ef798ab3f61585d3c71adef3
|
|
Test: HistoryItemActionModulesBuilderTest, ModulesTest
PiperOrigin-RevId: 195294876
Change-Id: Iac44f965a585975389da7dee758a94a8ad8311d3
|
|
Disambiguates the "this" by adding the reference to settings as required by privacy.
Test: N/A
PiperOrigin-RevId: 191970994
Change-Id: Idc357e8c908b4f54273bf1b2823a6759ea1332b6
|
|
Bug: 70988682
Test: Existing tests
PiperOrigin-RevId: 190946639
Change-Id: Iaa8294e8ba6e85ab3c27bb2e67200d7972a240f2
|
|
When a user accepts the Dialer ToS for the first time, we should also enable transcription if it is available.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 190794147
Change-Id: I7eb9b3d481426aceb55a8990fdbd246101937e7b
|
|
When a user declines the transcription, we should turn off transcription and never show the transcription promo ever again.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 190790323
Change-Id: Ida60592b0550b18b28e7f7a7a22d19100f56231a
|
|
transcription is available.
Also updated the isVoicemailAvailable helper method, since just checking if the flag and OS is not enough (we have other things such as is VVM enabled, is VM activated), if we don't do this, it doesnt make sense to turn on transcription e.g Why what would happen if transcription is turned on but vvm is disabled
Bug: 74033229
Test: Added a todo, will be added later (there are a few more similar CL's that I am sending for other ToS conditions) to ensure the logic is correct for all ToS conditions first and I can add a test right at the end for all conditions.
PiperOrigin-RevId: 190696695
Change-Id: I9cb063a97e11943abeb1f823dc661efe88dfa3f1
|
|
When an existing dialer user is shown the ToS and they declines it, the transcription setting must be turned off, to respect the users wishes.
We also no longer take the user to the settings page.
Bug: 74033229,77147114
Test: Unit test
PiperOrigin-RevId: 190682249
Change-Id: I8c0abf9f3cbb15ded12a760abe540c557fd2e7d3
|
|
Adds the we can turn off transcription from settings.
Bug: 76226374
Test: N/A
PiperOrigin-RevId: 190626638
Change-Id: I22b56f133cc83749cdd52a4406be0c36c5a0d0ac
|
|
Adds the we can turn off transcription from settings.
Bug: 76226374
Test: N/A
PiperOrigin-RevId: 190623712
Change-Id: Ib2990f9ba025cc5a7f51ba7f7b7d85085327cae9
|
|
up to N.
Test: Existing tests
PiperOrigin-RevId: 190508397
Change-Id: Ia5f33e45af1d1cc666fec5f43efa564b2b68c193
|
|
Manually set to M
- MissedCallNotifierTest (not sure what the issue is here...)
- CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown)
- MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory))
Ignore Tests
- a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason)
- VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear)
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190030202
Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
|
|
Updates the transcription setting from using a switch preference to a SwitchPreferenceWithClickableSummary. This allows the voicemail transcription setting preferences summary to be clicked and opened to the specified learn more url.
Bug: 74033229
Test: Unit Tests
PiperOrigin-RevId: 189983125
Change-Id: I1b162f3e2e582243fe8f84633e9401155170194c
|
|
Donation
The learn more link needs to be in the summary of the switch preference, however having a hyperlink in the summary text view of a switch preference does not open the hyperlink. To do this we made our custom switch preference which allows the summary to be clicked. All other aspects of the switch preference remain the same.
Bug: 74033229
Test: Unit test
PiperOrigin-RevId: 189978676
Change-Id: I31e744f3545e576ee3f5ac4a8fee249e22835e19
|
|
When a user enters the voicemail settings page and the voicemail is still being activated, we need to show the "Activating...." string to tell the user that something is still happening. This is important since unless the activation has happened, other settings are not visible e.g transcription and donation
Bug: 76107888
Test: N/A
PiperOrigin-RevId: 189970472
Change-Id: Ib9eeee64cd67c2adc4830a743516851ffa637fbf
|
|
Test: Existing tests
PiperOrigin-RevId: 189683790
Change-Id: I0209e7fa839175041da29e9a6d8a590133121376
|
|
Test: Existing tests
PiperOrigin-RevId: 189678764
Change-Id: I6b9edd99e727788c65d325c1be43f0190c25c30e
|
|
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following:
- ensuring that when the VVM toggle is turned off, transcription and donations are gone.
- when transcription is off, donation preference is gone.
- donation is only available when transcription is available and enabled
- as part of the refactor, fixes existing logging bugs
- breaks preferences and its associated methods into helper methods when possible
- groups relevant preferences together when possible
Bug: 74033229
Test: Unit tests
PiperOrigin-RevId: 189418217
Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
|
|
For simplicity, instead of resolve the nui shortcut string, I
deleted it since it isn't used anymore.
Test: build log
PiperOrigin-RevId: 189260472
Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
|
|
Add 6dp of spacing between transcription and the secondary text.
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188902056
Change-Id: Iba1c9c110bd238842567e7b1b36a757d388cea2d
|
|
Makes the views where the voicemails are displayed and the empty view white.
Bug: 74402112
Test: N/A
PiperOrigin-RevId: 188901487
Change-Id: I55a12dd067e66cc0f4efca3eb79b5a8f9e761082
|
|
Decrease the padding from 10dp to 4dp for bottom and top
Bug: 68727352
Test: N/A
PiperOrigin-RevId: 188776245
Change-Id: I7ced053a5989e15e84fad6a264683a5c8e5d9339
|
|
Makes the avatar and more icon the same as the nui call log.
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188756733
Change-Id: I93303a2a872ac156470d223d6fb4fd2959766adc
|
|
The metadata belongs with the voicemail settings menu, which is moved into dialer a while ago. Not moving the metadata causes build variants without VVM to have duplicated voicemail settings in telephony and dialer.
Also removed the redundant metadata in incall ui manifest.
Bug: 73096806
Test: manual
PiperOrigin-RevId: 188756468
Change-Id: I00174f84024c5b9ab809d99e40a55d22a07bd063
|
|
Makes the redlines similar to what we have for the call log nui. The values are structured and copied as much as possible from /calllog/ui/res/layout/new_call_log_*.xml
Things to note for:
-Today/Older header the same as call log
-More items all the way to the right
-Padding in voicemail icon gone
-Removed padding between each recycler view item
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188547442
Change-Id: I515d75e392591243510634c3fabe444a7ba10d7f
|
|
When a voicemail is deleted we have to allow the user the option of cancelling the deleting of voicemail. This is done by showing the user a snack bar which when a user taps will prevent the voicemail from being deleted.
This CL only adds the underlying logic for the delete/undelete to take place via a ScheduledFuture, it does not fix all the UI issues that come with it, which will be sent in a follow up CL, issues such as:
-Updating the group label when a delete/undo happens
-Updating the entries above and below when a delete/undo happens
-Showing the empty view immediately when a user deletes a single voicemail
-Removing the empty view immediately when a user taps undo
-Updating tests
Bug: 69858266
Test: Manual
PiperOrigin-RevId: 188424489
Change-Id: Iecf5cb7be5b80fa5e91acaad3a7cc4a6c8702521
|
|
Adds a divider line to differentiate the voicemail entries and the alerts.
Bug: 73158572
Test: N/A
PiperOrigin-RevId: 188389442
Change-Id: I33bd32fc310cdf52f20bcb2d0b2cd4266420cab6
|
|
Bug: 74202944
Test: Existing tests
PiperOrigin-RevId: 188060790
Change-Id: I4d79a353abf767935383d4149f261f5e96fd7acb
|
|
Bug: 74028377
Test: Manual :/
PiperOrigin-RevId: 187634587
Change-Id: I51be6c151db37988bd68558a6af8c2bab31939a1
|
|
This CL updates the icon for the empty voicemail tab and updates the tint of it as well. It also updates the size of the voicemail icon when in landscape mode.
Bug: 25661977,74085541
Test: N/A
PiperOrigin-RevId: 187557890
Change-Id: Ic19643f4e63e3ce70ba6b029ce45a570404f28e7
|
|
Bug: 73780748
Test: PhoneLookupInfoConsolidatorTest
PiperOrigin-RevId: 187404074
Change-Id: I1db81304909fbf63aba00088c12e18922042c3b1
|
|
When there are no voicemails to be shown, we show an empty view. This is done by hiding the recycler view and showing the empty view. Similarly when a voicemail is present, we hide the empty view and then show the recycler view.
Bug: 25661977
Test: Unit Tests
PiperOrigin-RevId: 187396952
Change-Id: Ifa718fb05c1be37aabdf4c91bc2c1653357565b2
|
|
All voicemails played from the VM tab should always be played from the non-speaker mode.
Bug: 71500892
Test: N/A
PiperOrigin-RevId: 187388964
Change-Id: I3f6a5887784b0192074157cfd8a91727d124ed06
|
|
Bug: 73798533
Test: Manual :/
PiperOrigin-RevId: 187383740
Change-Id: I0f35ccbf19a59b35338cb144f0192b692585159f
|
|
long method signatures.
Test: Existing tests
PiperOrigin-RevId: 187338094
Change-Id: I0d7a5206d127931d322b5604b2bb81f5202b8de8
|
|
Test: Existing tests
PiperOrigin-RevId: 187254014
Change-Id: I8a57b632d45e87ad075eb8bbb25180858e890f08
|
|
Bug: 73816729
Test: Existing tests
PiperOrigin-RevId: 187230516
Change-Id: I59d70b9676e2972b80f124f29f2c1cb1858efef8
|
|
Bug: 70989605
Test: ShowBlockReportSpamDialogNotifierEndToEndTest + Manual
PiperOrigin-RevId: 187047450
Change-Id: I23c3929135bcfe5c14fe317ef65f628dc126027f
|
|
this cl moves the TextViewPreference from dialer to third_party so it can be
shared (sorry i meant to make that a separate cl, but forgot to switch branches).
and it uses the TextViewPreference to add some informational text to the voicemail settings.
screen shot:
https://drive.google.com/open?id=0B9o_KvtLkcuIbENkeHRCSTUyOVpkM0JEZ0liMHphMnVzVHlN
mock:
https://drive.google.com/file/d/1gKt72pY-igXfphpamf8CqZV8HEmnOexj/view
Bug: 37340510
Test: manual test
PiperOrigin-RevId: 186388299
Change-Id: I2c142f1214a9424bec0bc7f12d841f0eeaef96f1
|
|
is truly visible.
Bug: 73347270
Test: NewCallLogFragmentTest, NewVoicemailFragmentTest
PiperOrigin-RevId: 186350076
Change-Id: Ib3e320f02a02795acb8b7d2017818b36df3dd49d
|
|
Bug: 73347270
Test: Existing tests + RefreshAnnotatedCallLogNotifierTest
PiperOrigin-RevId: 186347066
Change-Id: I5a530416bdaa9edc7131a0d5ced44f1b5ee1692b
|
|
Bug: 70989605
Test: ModulesTest
PiperOrigin-RevId: 185392711
Change-Id: I709a1e307925f1c99d2740ed52dc2b7784bca986
|
|
When a voicemail is deleted we mark it as deleted in the database. However to ensure that a voicemail gets deleted on the server, we need to upload it as well by forcing a upload sync, which we do after a successful marking it as deleted.
Bug: 73087132
Test: N/A
PiperOrigin-RevId: 185377828
Change-Id: Ia023cd7c5c283034c78022bcb6d4ce78e410de76
|
|
Earlier we were using the legacy CallLogQueryHandler for querying the voicemail status table. However we should be using UI Listeners instead in NUI. This CL queries the voicemail status table and returns a list of voicemail status', which are then used to display the corresponding error messages.
This CL also moved VoicemailStatus out of the legacy dialer/database and moves it to dialer/voicemailstatus and ensures that there are no dependencies on the legacy dialer/database in the NUI.
Bug: 73139237
Test: Unit tests
PiperOrigin-RevId: 185321023
Change-Id: Id16ea475b6a52da380fbf8b3590dc75cbcdc370e
|
|
Bug: 73077158
Test: CallLogEntryTextTest, GlidePhotoManagerImplTest, PhoneLookupInfoConsolidatorTest
PiperOrigin-RevId: 185017362
Change-Id: I113472482da2213d17a847054272a22249edc578
|
|
Makes the color of the transcription text different from the secondary text as expected by the spec.
Bug: 72746803
Test: N/A
PiperOrigin-RevId: 184372919
Change-Id: I3de30a3031a57d1bf3600c491e3881152aee9b03
|
|
Adds the support for NUI VM Tab to add phone account handle information to Pre-Call. This is used when making a call via the voicemail tab.
Bug: 72449246
Test: existing unit test
PiperOrigin-RevId: 184357841
Change-Id: Icc086c878c86cf5204511860d4524ff2ea1f8935
|
|
Shows the "Transcribed by Google" logo for voicemails transcribed by Google
Bug: 72491920
Test: Unit Tests
PiperOrigin-RevId: 184343786
Change-Id: I9d662860e218ff555c65f667f4ee15015df47ab2
|
|
Transcription state column is needed for voicemail transcriptions. This CL adds the support for it in the NUI so that it maybe used by the VM Tab.
Bug: 72491920
Test: Unit Tests
PiperOrigin-RevId: 184335015
Change-Id: I14a71890224216c957e0d6146af9dafaa1550865
|
|
We do not expect any invalid numbers for the voicemail tab. We crash the app if an invalid number is detected in the NUI VM tab, so that we can handle invalid numbers for voicemail accordingly.
Bug: 72863479
Test: N/A
PiperOrigin-RevId: 184333020
Change-Id: Ifd769da08c7cba3aab555b56eef799de47810fb3
|
|
This CL copies the code dealing with refreshing the annotated call log from the NewCallLogFragment and applies it to the NewVoicemailFragment. This is necessary since the NewVoicemailFragment should be able to refresh the annotated call log without depending on the user going to the call log fragment for the update. The only thing we don't copy over is the logic and handling when the CP2 info is incomplete for a number (INVALID number), however we do not expect any invalid numbers for voicemail and as such have added an assert for that.
Bug: 72523272
Test: Unit Tests
PiperOrigin-RevId: 184292549
Change-Id: I2994974fe60221a4854fed5f9d80d3d428449ae9
|
|
It turns out the storing the libphonenumber representation of the number is not particularly useful because even formatting these objects cannot be done on the main thread. Rather than propagate the requirement of using PhoneNumberUtil (and background threads by extension) in the call log UI, we now just store a dialer-normalized version of the number which contains all information required by the UI in a way that allows us to avoid any background work in the UI code.
Bug: 72563861
Test: existing
PiperOrigin-RevId: 183463907
Change-Id: I4bdadaccb7a84033b3c72c54fe3833064f587ee3
|
|
The phone icon should be disabled for unknown numbers in the NUI Voicemail, so that those numbers may not be called. This should have the same logic as as what we do for the call log.
Bug: 72449247
Test: Unit Test
PiperOrigin-RevId: 183428831
Change-Id: If1ecc3b4d47de04bccf69ae735a619f6b33c3bbd
|
|
By default the seekbar should be disabled unless being played or the voicemails have downloaded. This first part of the seekbar update ensures that a user is not able to seek, and the seekbar will only be updated automatically when the voicemail is being played.
Bug: 7252855
Test: N/A
PiperOrigin-RevId: 183419966
Change-Id: I4e492279402d76d3e1ece03dded9b402c88138c8
|
|
When a user presses the phone icon in NUI voicemail, we should make a phone call.
This does not handle phone account handling and disabling showing the phone icon for unknown numbers (tracked in b/72449247 and b/72449246)
Bug: 72449869
Test: Unit test
PiperOrigin-RevId: 183318358
Change-Id: I075ae79ec6896f2b9244f990bd2a01493c495e07
|
|
Clicking the speaker button in the NUI VM for a voicemail entry alternates playing the audio via the speaker and headset. This CL does not change the state of the speaker icon, that will be done in a follow up CL (cl/183175378) and the todo for that has been added.
Bug: 69858226
Test: N/A
PiperOrigin-RevId: 183304029
Change-Id: I3a55e62ab8d1203f659a45db9534fd69deda122f
|
|
This CL shows the voicemail error messages for both VVM and OMTP type voicemails. It hooks upto the existing error framework and retrieves the voicemail error states and then displays it.
Bug: 71700117
Test: Unit Tests
PiperOrigin-RevId: 183301455
Change-Id: Ib2b7fb957fbfd2af2227747d327cef466259eb6f
|
|
The media player throws a strict mode violation when setting the data source and calling prepare async. This currently makes the voicemail fragment unusable since you can't play voicemails. I've added a todo to remove this in the future.
Test: N/A
PiperOrigin-RevId: 183298572
Change-Id: I821a700cc7e60d0bdde7ec4d7b543dfa7acaf274
|
|
CallLogPhoto.getPhotoUri() returns a URI to a drawable so it will be easier to transition into glide. Meanwhile ContactPhotoManager will just show the drawable directly.
Bug: 70989547
Test: Unit tests
PiperOrigin-RevId: 183163818
Change-Id: I4ee4ff98782e35d2be03dfe14f8bf3dfd6ded074
|
|
Currently NUI only supports today and older, however we also need to support yesterday and be consistent with the call log.
Bug: 69858354,72331988
Test: Unit Tests
PiperOrigin-RevId: 183121631
Change-Id: Ica75164c28ee60a2f776287eefd7eed5db08e035
|
|
All packages relating to NUI voicemail should be under third_party/java_src/android_app/dialer/java/com/android/dialer/voicemail/listui. Since there is a chance that during NUI development the legacy third_party/java_src/android_app/dialer/java/com/android/dialer/app/voicemail/error might undergo changes, it makes sense to move this package to the nui, so that no changes in the legacy code are missed for nui. This refactoring would also allow us to ensure that the strings do not need to be translated and that most of the code can be re-used for nui by hooking up the fragment and adapter to voicemail/listui/error.
Bug: 71700117
Test: Unit tests
PiperOrigin-RevId: 182868896
Change-Id: I23329654df5ce2bf612101708ed001ca308ae1ac
|
|
Bug: 72235391
Test: Manual
PiperOrigin-RevId: 182848699
Change-Id: I587f5f4dd770278747114da17581c8fc253651c0
|
|
Bug: 70989595
Test: CallLogDatesTest, CallLogEntryTextTest
PiperOrigin-RevId: 182809700
Change-Id: I84b699536ae7f77e6c27db0b1b008e3ebc6216c2
|
|
Voicemail Tab
The older header must take into account and be offset when there is a voicemail alert being shown.
Bug: 71700117
Test: N/A
PiperOrigin-RevId: 182243160
Change-Id: Ib38ba82e75fedf9a2939078447e4791f5239524c
|
|
This allow extra information from PhoneLookup to be more easily added. Only PhoneLookupSelector and the proto will be affected for new attributes.
Test: Unit tests.
PiperOrigin-RevId: 181675568
Change-Id: I4e0bc1c6005b58a9b684b030b55bea6223af9ce3
|
|
This CL only setups the layouts, images and strings associated with the voicemail terms of service. Additional logic of when to display the ToS will be in a follow up CL.
Bug: 71699918
Test: N/A
PiperOrigin-RevId: 181548639
Change-Id: Ia99dcc5ad8a96dcac71946fe611b3ee4ad24814f
|
|
This CL setups the initial adapter logic to be able to display voicemail error messages.
The errors and the code to display those errors will be shown in a follow up CL.
Bug: 71700117
Test: N/A
PiperOrigin-RevId: 181210330
Change-Id: I5b9e9e675ad7a4825692fb93ca4237d05b0407f0
|
|
Test: Existing tests
PiperOrigin-RevId: 180230450
Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
|
|
expanded.
A voicemail will be marked as read when up tap on it. When it's unread its shown as a unbold voicemail. This CL marks a voicemail as read and updates the underlying table when its expanded.
Bug: 64882313,70950649
Test: Unit Tests
PiperOrigin-RevId: 179963238
Change-Id: Ia968178a49e2f7ae83b859dcdbda71acd5383f03
|
|
Voicemails that are unread in the annotated call log table will show up as bold. Voicemails that are marked as read will show up as normal (non bold). A follow up CL will update the underlying table and mark them as read when a viewholder is expanded.
Bug: 64882313,70900195
Test: Unit Tests
PiperOrigin-RevId: 179872932
Change-Id: I927711aa8c6c6324e43f519c14a58b5f2b8e7ca9
|
|
When a new voicemail is received, it is written in the voicemail table by the Voicemail service. However the new voicemail will not get updated/shown in the New Voicemail UI as the annotated call log would be stale. This CL ensures that when the voicemail is added, the annotated call log is marked dirty and refreshed. This way the new voicemail will be shown in the new voicemail UI. Since a new voicemail is also added, we want to make sure the headers for "today" and "older", their positions are also updated accordingly.
Bug: 64882313
Test: Unit tests
PiperOrigin-RevId: 179623267
Change-Id: I5dfc84f62f9f37c57ffb2dbbe7e848a58306a19d
|
|
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 179616641
Change-Id: Ie9e67226dc7cd4082ca4f7fd3ca5725bb854bca2
|
|
A small bug that only printed the last value of the array map and not all of it.
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 179605815
Change-Id: I7230508f47e6603470d8067ef5233ae3c9af8911
|
|
Implement the basic bottom sheet that displays name, location add to contacts, send a message and copy number option.
Bug: 64882313,70682949
Test: Unit test, additional unit tests in the next CL that will implement calling from bottom sheet.
PiperOrigin-RevId: 179212401
Change-Id: I23281587a0d42cea595e4dc1608f997036e2dbd0
|
|
Allows voicemails to be deleted when tapping on the delete icon.
Upon tapping the delete button this first deletes/hides it in the recyler view and then subsequently deletes it from the underlying table.
Test: Unit test
PiperOrigin-RevId: 179055594
Change-Id: I98bb7694d59b7edfcaa4ae162b194c0ef3a0292e
|
|
Test: Unit tests
PiperOrigin-RevId: 178791213
Change-Id: I9e68c561285988cc1def894f5c7ecf9715ecf6b6
|
|
This CL also updates the tests that were TODOs from http://b/70401224 to allow testing the MediaPlayerView
SCREENSHOT:
Today: http://screen/8KvVtLtHeq4
Older: http://screen/5oskBZPbDR5
Test: Unit tests
PiperOrigin-RevId: 178699528
Change-Id: Idab797eff18fd277618938a8a54da350c60b3d54
|
|
after recycling.
This CL adds the support for playing voicemails, changing the play button to pause button when playing the voicemail, updating the seekbar and duration timer when the voicemail is being played. It also adds the support to preserve the state of the media player such that when scrolling and recycling views, when an expanded and playing voicemail is recycled back into view, it's most recent state is shown i.e the duration and the seekbar are upto date.
Video: https://drive.google.com/open?id=1CKbLK5-1YDeXBZFiKvuTxoPuFJQ1rbj7
Test: Unit tests
PiperOrigin-RevId: 178681663
Change-Id: Ifdd1d945572926bdc7d652aa7a876d3156fc21ce
|
|
For privacy reasons we now delete all voicemails and transcriptions when
the user disables visual voicemail, (after confirming that they want to do this
via a dialog).
Note: we only delete voicemails whose source package is the google dialer.
Note: the voicemails will be re-downloaded and re-transcribed if the user re-enables visual voicemail
Bug: 69323147
Test: manual and unit test
PiperOrigin-RevId: 177315139
Change-Id: Ie04496dc5960b485794733fbf74f7f704e806023
|
|
When the activity is launched it might immediately attempt to verify the stored pin, which happened before the executor is initialized
Bug: 69179171
Test: N/A - legacy code, refactoring required
PiperOrigin-RevId: 176433263
Change-Id: I8202a760dbfc7759e128ef31d477510526d0bee7
|
|
recycling views.
The adapter maintains the state of those voicemails that were expanded. When the views are recycled we ensure that the expanded view holder whenever visible is expanded. However when an expanded viewholder is collapsed, taken out of view and then brought back into view (recycled), the expanded state is preserved. This CL ensures that this no longer happens.
Bug: 64882313,68382421
Test: Unit test
PiperOrigin-RevId: 176233960
Change-Id: Ib57859a287ec0c4f9e955a0fc01a49f093023fd1
|
|
EXTRA_PHONE_ACCOUNT_HANDLE is not implemented in O. subId is required to determine which SIM the settings is for.
Bug: 67669006
Test: VoicemailSettingsFragmentTest, TelecomUtilTest
PiperOrigin-RevId: 175913331
Change-Id: I84f9e19b711c5baa275d934cfdfd5b7a2d4b6f6d
|
|
Replaces the existing buttons with Image Buttons using standards images. Also added a phone button.
Bug: 64882313,68382421
Test: Unit Tests
PiperOrigin-RevId: 175843834
Change-Id: I21898f7da72f3dd17fce0047b11349737b373513
|
|
Voicemail URI and duration are both retrieved from VoicemailEntry. This CL combines it.
This was a todo added from http://cl/175585919
Test: unit tests
PiperOrigin-RevId: 175718355
Change-Id: I7d2748cf6e110e494f6895c512ce355aa2d048a7
|
|
The duration of the voicemail shown in the seekbar/media player (upon expanding) should be the same as the duration shown when the voicemail view holder is collapsed. Both values are retrieved from the same source (VoicemailEntry).
Bug: 64882313,68382421,69268144
Test: Unit Tests
PiperOrigin-RevId: 175712662
Change-Id: I70496c004d52deb1793e6d6354b0ec79bf4c4398
|
|
Adds the UX support for showing the seekbar in the NUI Media player. It also shows a starting and total duration text as well, though as of right now it's a static value and will be updated in a follow up CL.
Bug: 64882313,68382421,69268144
Test: Unit tests
PiperOrigin-RevId: 175595293
Change-Id: I14440599d52352c213c7513dd2d0a8aef2f51bfe
|
|
Voicemails that are available locally on the device (have been downloaded from the voicemail server) will have their "HAS_CONTENT" column set to one. This CL adds the plumbing logic of checking that when a user presses the play button, if the voicemail is available locally, it is played.
Bug: 64882313,68382421
Test: Existing unit tests
PiperOrigin-RevId: 175590204
Change-Id: Id164d08c16b89c84a75af0c4a7c899c02d64fff7
|
|
This adds a file called new_voicemail_media_player_layout.xml that can be expanded and collapsed on tapping the voicemail entry. This file will later be updated in accordance with the specs, but the logic for expansion and collapsing would not be affected by the future cosmetic change.
Video=https://drive.google.com/open?id=1aIpmVfUYrFrg_FZ4tRX_TX6pU9YgPQaN
Bug: 64882313,68382421
Test: Unit Tests
PiperOrigin-RevId: 174713873
Change-Id: I15a6c5f01715429a6eb51fee447a5b42f25fdb56
|
|
Currently we only show as much of the voicemail transcription, as we can see on the first line. This CL allows us to tap the voicemail, so that it is expanded and the whole transcription is now visible.
Bug: 68382421,64882313
Test: Unit Tests
PiperOrigin-RevId: 174267231
Change-Id: I19d3dea028c06d7c31aeb2949a19360eff648dcd
|
|
in cl/173731907 we added a setting for donating voicemails, but didn't
distinguish between when this feature is enabled/disabled by the user
or by configuration. this cl fixes that by adding a method to check
if the feature is available (ie enabled by config).
Bug: 62423454
Test: manual and unit test
PiperOrigin-RevId: 174245260
Change-Id: I45a59de7f4a171d759e2fcf86db27a100a84de67
|
|
The voicemail module should not contain any UI code.
Bug: 37258159
Test: DialerSettingsActivityTest,VoicemailSettingsFragmentTest. A future CL is refactoring VoicemailChangePinActivity into a fragment.
PiperOrigin-RevId: 174125949
Change-Id: I89cf6a083b0a0952332440d76e7ae0cb1c801931
|
|
VoicemailUri is required to play voicemail audio files. We need it to be able to play the voicemails in the voicemail tab. A follow up CL will be using the uri to play the audio, but via a media player.
Bug: 64882313
Test: Unit tests
PiperOrigin-RevId: 173422683
Change-Id: Ib438e3020c83e11a2c54c3e941c93e83dba9bc90
|
|
It fixes AOSP for package name conflict.
Test: manual
PiperOrigin-RevId: 173298696
Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
|
|
The numbers used to be cropped (http://screen/YYBG8T0Ma0J). We've fixed that issue in this CL and also removed the term "call_log" from the file name.
Screenshot:
http://screen/uHCPwf5smVX
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 172541833
Change-Id: Ib2746b38284c2c04c84ab369d449412d8a9880b4
|
|
This CL lays the foundation of querying the annotated call log, retrieving only the voicemail entries and some of the voicemail information in the Voicemail tab. This CL only displays the name/number as well as the corresponding photo of the voicemails present on the device.
WANT_LGTM=zachh
SCREENSHOT: http://screen/YYBG8T0Ma0J
Bug: 33006245, 64882313
Test: Unit tests and manual verification.
PiperOrigin-RevId: 172504512
Change-Id: Ie7187b021abf42d1a4522458a1ab28537a7c222c
|
|
Screenshot:http://screen/dwihQaaeaQC
Bug: 64882313,33006245
Test: NewVoicemailCallLogViewHolderTest, NewVoicemailCallLogAdapterTest
PiperOrigin-RevId: 170542645
Change-Id: I00c145c5856c3f1f53d12b0fd7bd80c63bb8a094
|
|
Screenshot:http://screen/RK42CXn5uB6
Bug: 64882313,33006245
Test: VoicemailFragmentTest, NewVoicemailCallLogAdapterTest, NewVoicemailCallLogViewHolderTest
PiperOrigin-RevId: 170129401
Change-Id: Ib82357763bd9cf9f215804225be009650402fe84
|
|
Previously, Android's Dialer app was developed in an internal Google
source control system and only exported to public during AOSP drops.
The Dialer team is now switching to a public development model similar
to the telephony team.
This CL represents all internal Google changes that were committed to
Dialer between the public O release and today's tip of tree on internal
master. This CL squashes those changes into a single commit.
In subsequent changes, changes will be exported on a per-commit basis.
Test: make, flash install, run
Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160
Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8
PiperOrigin-RevId: 167068436
|