Age | Commit message (Collapse) | Author |
|
Updates the transcription setting from using a switch preference to a SwitchPreferenceWithClickableSummary. This allows the voicemail transcription setting preferences summary to be clicked and opened to the specified learn more url.
Bug: 74033229
Test: Unit Tests
PiperOrigin-RevId: 189983125
Change-Id: I1b162f3e2e582243fe8f84633e9401155170194c
|
|
Donation
The learn more link needs to be in the summary of the switch preference, however having a hyperlink in the summary text view of a switch preference does not open the hyperlink. To do this we made our custom switch preference which allows the summary to be clicked. All other aspects of the switch preference remain the same.
Bug: 74033229
Test: Unit test
PiperOrigin-RevId: 189978676
Change-Id: I31e744f3545e576ee3f5ac4a8fee249e22835e19
|
|
When a user enters the voicemail settings page and the voicemail is still being activated, we need to show the "Activating...." string to tell the user that something is still happening. This is important since unless the activation has happened, other settings are not visible e.g transcription and donation
Bug: 76107888
Test: N/A
PiperOrigin-RevId: 189970472
Change-Id: Ib9eeee64cd67c2adc4830a743516851ffa637fbf
|
|
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following:
- ensuring that when the VVM toggle is turned off, transcription and donations are gone.
- when transcription is off, donation preference is gone.
- donation is only available when transcription is available and enabled
- as part of the refactor, fixes existing logging bugs
- breaks preferences and its associated methods into helper methods when possible
- groups relevant preferences together when possible
Bug: 74033229
Test: Unit tests
PiperOrigin-RevId: 189418217
Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
|
|
The metadata belongs with the voicemail settings menu, which is moved into dialer a while ago. Not moving the metadata causes build variants without VVM to have duplicated voicemail settings in telephony and dialer.
Also removed the redundant metadata in incall ui manifest.
Bug: 73096806
Test: manual
PiperOrigin-RevId: 188756468
Change-Id: I00174f84024c5b9ab809d99e40a55d22a07bd063
|
|
Bug: 74028377
Test: Manual :/
PiperOrigin-RevId: 187634587
Change-Id: I51be6c151db37988bd68558a6af8c2bab31939a1
|
|
Bug: 73798533
Test: Manual :/
PiperOrigin-RevId: 187383740
Change-Id: I0f35ccbf19a59b35338cb144f0192b692585159f
|
|
this cl moves the TextViewPreference from dialer to third_party so it can be
shared (sorry i meant to make that a separate cl, but forgot to switch branches).
and it uses the TextViewPreference to add some informational text to the voicemail settings.
screen shot:
https://drive.google.com/open?id=0B9o_KvtLkcuIbENkeHRCSTUyOVpkM0JEZ0liMHphMnVzVHlN
mock:
https://drive.google.com/file/d/1gKt72pY-igXfphpamf8CqZV8HEmnOexj/view
Bug: 37340510
Test: manual test
PiperOrigin-RevId: 186388299
Change-Id: I2c142f1214a9424bec0bc7f12d841f0eeaef96f1
|
|
Test: Existing tests
PiperOrigin-RevId: 180230450
Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
|
|
For privacy reasons we now delete all voicemails and transcriptions when
the user disables visual voicemail, (after confirming that they want to do this
via a dialog).
Note: we only delete voicemails whose source package is the google dialer.
Note: the voicemails will be re-downloaded and re-transcribed if the user re-enables visual voicemail
Bug: 69323147
Test: manual and unit test
PiperOrigin-RevId: 177315139
Change-Id: Ie04496dc5960b485794733fbf74f7f704e806023
|
|
When the activity is launched it might immediately attempt to verify the stored pin, which happened before the executor is initialized
Bug: 69179171
Test: N/A - legacy code, refactoring required
PiperOrigin-RevId: 176433263
Change-Id: I8202a760dbfc7759e128ef31d477510526d0bee7
|
|
EXTRA_PHONE_ACCOUNT_HANDLE is not implemented in O. subId is required to determine which SIM the settings is for.
Bug: 67669006
Test: VoicemailSettingsFragmentTest, TelecomUtilTest
PiperOrigin-RevId: 175913331
Change-Id: I84f9e19b711c5baa275d934cfdfd5b7a2d4b6f6d
|
|
in cl/173731907 we added a setting for donating voicemails, but didn't
distinguish between when this feature is enabled/disabled by the user
or by configuration. this cl fixes that by adding a method to check
if the feature is available (ie enabled by config).
Bug: 62423454
Test: manual and unit test
PiperOrigin-RevId: 174245260
Change-Id: I45a59de7f4a171d759e2fcf86db27a100a84de67
|
|
The voicemail module should not contain any UI code.
Bug: 37258159
Test: DialerSettingsActivityTest,VoicemailSettingsFragmentTest. A future CL is refactoring VoicemailChangePinActivity into a fragment.
PiperOrigin-RevId: 174125949
Change-Id: I89cf6a083b0a0952332440d76e7ae0cb1c801931
|