Age | Commit message (Collapse) | Author |
|
Test: Existing tests
PiperOrigin-RevId: 189678764
Change-Id: I6b9edd99e727788c65d325c1be43f0190c25c30e
|
|
When a voicemail is deleted we have to allow the user the option of cancelling the deleting of voicemail. This is done by showing the user a snack bar which when a user taps will prevent the voicemail from being deleted.
This CL only adds the underlying logic for the delete/undelete to take place via a ScheduledFuture, it does not fix all the UI issues that come with it, which will be sent in a follow up CL, issues such as:
-Updating the group label when a delete/undo happens
-Updating the entries above and below when a delete/undo happens
-Showing the empty view immediately when a user deletes a single voicemail
-Removing the empty view immediately when a user taps undo
-Updating tests
Bug: 69858266
Test: Manual
PiperOrigin-RevId: 188424489
Change-Id: Iecf5cb7be5b80fa5e91acaad3a7cc4a6c8702521
|
|
When a voicemail is deleted we mark it as deleted in the database. However to ensure that a voicemail gets deleted on the server, we need to upload it as well by forcing a upload sync, which we do after a successful marking it as deleted.
Bug: 73087132
Test: N/A
PiperOrigin-RevId: 185377828
Change-Id: Ia023cd7c5c283034c78022bcb6d4ce78e410de76
|
|
Earlier we were using the legacy CallLogQueryHandler for querying the voicemail status table. However we should be using UI Listeners instead in NUI. This CL queries the voicemail status table and returns a list of voicemail status', which are then used to display the corresponding error messages.
This CL also moved VoicemailStatus out of the legacy dialer/database and moves it to dialer/voicemailstatus and ensures that there are no dependencies on the legacy dialer/database in the NUI.
Bug: 73139237
Test: Unit tests
PiperOrigin-RevId: 185321023
Change-Id: Id16ea475b6a52da380fbf8b3590dc75cbcdc370e
|
|
Bug: 73077158
Test: CallLogEntryTextTest, GlidePhotoManagerImplTest, PhoneLookupInfoConsolidatorTest
PiperOrigin-RevId: 185017362
Change-Id: I113472482da2213d17a847054272a22249edc578
|
|
This CL shows the voicemail error messages for both VVM and OMTP type voicemails. It hooks upto the existing error framework and retrieves the voicemail error states and then displays it.
Bug: 71700117
Test: Unit Tests
PiperOrigin-RevId: 183301455
Change-Id: Ib2b7fb957fbfd2af2227747d327cef466259eb6f
|
|
Currently NUI only supports today and older, however we also need to support yesterday and be consistent with the call log.
Bug: 69858354,72331988
Test: Unit Tests
PiperOrigin-RevId: 183121631
Change-Id: Ica75164c28ee60a2f776287eefd7eed5db08e035
|
|
Bug: 70989595
Test: CallLogDatesTest, CallLogEntryTextTest
PiperOrigin-RevId: 182809700
Change-Id: I84b699536ae7f77e6c27db0b1b008e3ebc6216c2
|
|
Voicemail Tab
The older header must take into account and be offset when there is a voicemail alert being shown.
Bug: 71700117
Test: N/A
PiperOrigin-RevId: 182243160
Change-Id: Ib38ba82e75fedf9a2939078447e4791f5239524c
|
|
This CL setups the initial adapter logic to be able to display voicemail error messages.
The errors and the code to display those errors will be shown in a follow up CL.
Bug: 71700117
Test: N/A
PiperOrigin-RevId: 181210330
Change-Id: I5b9e9e675ad7a4825692fb93ca4237d05b0407f0
|
|
When a new voicemail is received, it is written in the voicemail table by the Voicemail service. However the new voicemail will not get updated/shown in the New Voicemail UI as the annotated call log would be stale. This CL ensures that when the voicemail is added, the annotated call log is marked dirty and refreshed. This way the new voicemail will be shown in the new voicemail UI. Since a new voicemail is also added, we want to make sure the headers for "today" and "older", their positions are also updated accordingly.
Bug: 64882313
Test: Unit tests
PiperOrigin-RevId: 179623267
Change-Id: I5dfc84f62f9f37c57ffb2dbbe7e848a58306a19d
|
|
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 179616641
Change-Id: Ie9e67226dc7cd4082ca4f7fd3ca5725bb854bca2
|
|
A small bug that only printed the last value of the array map and not all of it.
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 179605815
Change-Id: I7230508f47e6603470d8067ef5233ae3c9af8911
|
|
Allows voicemails to be deleted when tapping on the delete icon.
Upon tapping the delete button this first deletes/hides it in the recyler view and then subsequently deletes it from the underlying table.
Test: Unit test
PiperOrigin-RevId: 179055594
Change-Id: I98bb7694d59b7edfcaa4ae162b194c0ef3a0292e
|
|
Test: Unit tests
PiperOrigin-RevId: 178791213
Change-Id: I9e68c561285988cc1def894f5c7ecf9715ecf6b6
|
|
This CL also updates the tests that were TODOs from http://b/70401224 to allow testing the MediaPlayerView
SCREENSHOT:
Today: http://screen/8KvVtLtHeq4
Older: http://screen/5oskBZPbDR5
Test: Unit tests
PiperOrigin-RevId: 178699528
Change-Id: Idab797eff18fd277618938a8a54da350c60b3d54
|
|
after recycling.
This CL adds the support for playing voicemails, changing the play button to pause button when playing the voicemail, updating the seekbar and duration timer when the voicemail is being played. It also adds the support to preserve the state of the media player such that when scrolling and recycling views, when an expanded and playing voicemail is recycled back into view, it's most recent state is shown i.e the duration and the seekbar are upto date.
Video: https://drive.google.com/open?id=1CKbLK5-1YDeXBZFiKvuTxoPuFJQ1rbj7
Test: Unit tests
PiperOrigin-RevId: 178681663
Change-Id: Ifdd1d945572926bdc7d652aa7a876d3156fc21ce
|
|
recycling views.
The adapter maintains the state of those voicemails that were expanded. When the views are recycled we ensure that the expanded view holder whenever visible is expanded. However when an expanded viewholder is collapsed, taken out of view and then brought back into view (recycled), the expanded state is preserved. This CL ensures that this no longer happens.
Bug: 64882313,68382421
Test: Unit test
PiperOrigin-RevId: 176233960
Change-Id: Ib57859a287ec0c4f9e955a0fc01a49f093023fd1
|
|
Voicemails that are available locally on the device (have been downloaded from the voicemail server) will have their "HAS_CONTENT" column set to one. This CL adds the plumbing logic of checking that when a user presses the play button, if the voicemail is available locally, it is played.
Bug: 64882313,68382421
Test: Existing unit tests
PiperOrigin-RevId: 175590204
Change-Id: Id164d08c16b89c84a75af0c4a7c899c02d64fff7
|
|
Currently we only show as much of the voicemail transcription, as we can see on the first line. This CL allows us to tap the voicemail, so that it is expanded and the whole transcription is now visible.
Bug: 68382421,64882313
Test: Unit Tests
PiperOrigin-RevId: 174267231
Change-Id: I19d3dea028c06d7c31aeb2949a19360eff648dcd
|
|
It fixes AOSP for package name conflict.
Test: manual
PiperOrigin-RevId: 173298696
Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
|
|
The numbers used to be cropped (http://screen/YYBG8T0Ma0J). We've fixed that issue in this CL and also removed the term "call_log" from the file name.
Screenshot:
http://screen/uHCPwf5smVX
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 172541833
Change-Id: Ib2746b38284c2c04c84ab369d449412d8a9880b4
|
|
This CL lays the foundation of querying the annotated call log, retrieving only the voicemail entries and some of the voicemail information in the Voicemail tab. This CL only displays the name/number as well as the corresponding photo of the voicemails present on the device.
WANT_LGTM=zachh
SCREENSHOT: http://screen/YYBG8T0Ma0J
Bug: 33006245, 64882313
Test: Unit tests and manual verification.
PiperOrigin-RevId: 172504512
Change-Id: Ie7187b021abf42d1a4522458a1ab28537a7c222c
|