summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/main
AgeCommit message (Collapse)Author
2021-08-21Automatic translation importMichael Bestas
Change-Id: Ie3a73c54c766044acbcc8608dd54cc502518799e
2021-07-12Dialer: improve search barTimi Rautamäki
* Make background color lighter * Update border radius * Update ripple to follow border radius * Remove the background color, use same as activity * Update the back-icon color to white/black for consistency Change-Id: I648a2bd0da47fec99d8a8457c70451e77ed9f8be
2021-07-12Dialer: set statusbar color same as activity backgroundTimi Rautamäki
* Keep styles that use actionBar as is because it uses normal actionbar * Set light statusbar attribute for some styles Change-Id: I8748aa4d12f8e0c68d14d514ea5a2bd4100ee3ca
2021-07-12Dialer: correct the expanded search bar heightTimi Rautamäki
This causes the expand animation to be choppy first time Test: make Dialer, verify the animation no longer shifts the view first time the animation is played. Change-Id: Ia72b38ab39f19c2518385d6a858dc2fd194bbb55
2021-05-22Dialer: Remove unused resourcesMichael Bestas
These have been removed in previous commits Change-Id: Ib8a32eae0acef2eec6250db64ff1e96c521c17d3
2021-05-22Dialer: use black/white navigation colorsTimi
Change-Id: I9d2ee0bbc7d765e605d6f60c7866565c83dff295
2021-03-14Dialer: Add a helpline phone bookMichael W
* Expose the sensitive numbers to the user so they can easily call one of them * Make sure to leave as few traces of access as possible: * Calling a number closes the helpline activity * Opening a link closes the helpline activity * Before opening a link, a warning about browser history appears * This makes use of a changed xml-format, which now allows adding various things: <item> <categories>violence|human trafficking</categories> <name>Some NGO or whatever</name> <number>1234</number> <anything>anything else</anything> </item> Change-Id: I952bf10ee9516b83e595d8a19450696b303393b6
2021-02-28Automatic translation importMichael Bestas
Change-Id: I74c642b3b9aad5034895cc0cc72a8f3c986797db
2020-12-12Fix translation of 'contacts' tab title and main menu.Danny Baumann
AOSP migrated those items to new strings, but those strings don't have any translations. Just use the previous string instances instead, which still exist and have valid translations. Change-Id: I55d7e5a5bf630e5813d2a2c22888b906b704e3f5
2020-12-12Dialer: Use a DayNight launch themeScott Warner
This prevents the white launch screen from appearing when the system theme is dark Change-Id: I1ee8ff493910578b5e5c9de67ea1f7390178051a
2020-12-12Allow per-call account selection.Danny Baumann
Change-Id: Ieac27294f4069b2cff17bb39a0954f74320ad943
2018-07-10Revert "UI refresh for search bar."Eric Erfanian
This reverts commit febe3b19e7b211c233a576d20080cb2c1f2fcaee. Change-Id: I423f619d15a46072d43b31713ecd113fda0fcafc
2018-07-10Revert "UI refresh for search fragment."Eric Erfanian
This reverts commit f375be6e66c0c06db3a8f045b31425153b9a0902. Change-Id: I5de808d63bed90276481acc3f898a89f8bac2be1
2018-07-10Revert "UI refresh for FAB."Eric Erfanian
This reverts commit 53a524743f84155de2773cd9ad2da011e4435ceb. Change-Id: I8f233fb26f46fd3e11bf0b4bd0b4c7ef84d95c50
2018-07-10Revert "UI refresh for bottom nav bar."Eric Erfanian
This reverts commit 9af4b65fa7717a647e3c8996cbbbcc93637aeab4. Change-Id: I5610ae55eb9c22609e3e6a73ea0ce6a5ef3c0cda
2018-06-28Remove redundant @TargetApi, @RequiresApi and @SuppressWarningslinyuh
Test: Existing tests PiperOrigin-RevId: 202589482 Change-Id: I6982e4069d30032bf46caf3c9984dfc0e7196f6f
2018-06-28Fix scroll for new favoritesyueg
Test: SpeedDialAdapterTest PiperOrigin-RevId: 202543795 Change-Id: I1eec7a7328da3037b4d1cbacc7d9b211305e3eb0
2018-06-28UI refresh for bottom nav bar.wangqi
Bug: 73963403 Test: manual PiperOrigin-RevId: 202535473 Change-Id: Iccb4e72c63cbf031399448ee2def5dcb3a152081
2018-06-28UI refresh for FAB.wangqi
Bug: 73963403 Test: manual PiperOrigin-RevId: 202531720 Change-Id: I11ec4567dce161c5d3199e0159fe838b036489d7
2018-06-28UI refresh for search fragment.wangqi
Bug: 79879991 Test: manual PiperOrigin-RevId: 202392606 Change-Id: I24ba1177d11433b76bf6fe0c64d97368a6a1e328
2018-06-27UI refresh for search bar.wangqi
Bug: 79879991 Test: manual PiperOrigin-RevId: 202354447 Change-Id: Id6121d8807c4da4864f10ea27a4f2ee92a7699a1
2018-06-26Don't submit fragment transaction to show search when the activity state has ↵zachh
been saved. Bug: 109887880 Test: unit PiperOrigin-RevId: 201749785 Change-Id: I84dbef78969346ebfeed600ff6aaf015c62abb86
2018-06-19Drag favorite to removeyueg
Test: RemoveViewHolderTest, SpeedDialAdapterTest PiperOrigin-RevId: 201266033 Change-Id: Ie7ed9bac8ad9c7bbc35c351409b629e3fbad3de8
2018-06-12Fix voicemail multi-select title text coloryueg
Test: manual PiperOrigin-RevId: 200265855 Change-Id: I4f082c7db8a2a1df51e13265766d8c3923368f8f
2018-06-12Reorganized activities in manifests.zachh
Bug: 109931227 Test: manual PiperOrigin-RevId: 200232293 Change-Id: Id82ce87014a2a16b6b27398b7de2019e96c5d95b
2018-06-08Use an intent action to launch MainActivity instead of class reference to ↵zachh
DialtactsActivity. We can't just replace DialtactsActivity with MainActivity because a circular dependency would be created. Instead create a new dialer-specific "main" intent action and use it. Bug: 109931227 Test: manual PiperOrigin-RevId: 199868961 Change-Id: I0ef72ed418280eeb64ea1ea854d215093b0dba27
2018-06-08Moved EXTRA_CLEAR_NEW_VOICEMAILS to MainComponent.zachh
This needs to be moved in order to delete DialtactsActivity. Bug: 109931227 Test: none PiperOrigin-RevId: 199820125 Change-Id: I2b2c190152834bd1d0d0510f8e01110f05a5a8f3
2018-06-07Removed "last_tab_enabled" flag.zachh
END_PUBLIC The bottom nav buttons do not work correctly when this flag is not enabled (see bugs). This flag is intended to always be true via an experiment but can be false for example when the user clears data or just launched dialer for the first time and hasn't received config flags. It is not likely that we will ever want to turn off this behavior, so this change simply removes all support for it. TEST=unit Bug: 109762667,79485008 Test: unit PiperOrigin-RevId: 199660314 Change-Id: I105f6c553c7541673b6d5dd7abf4d29f566e155f
2018-06-01Inlined ConfigProviderBindings.get() and removed ConfigProviderBindings.zachh
It no longer provides any value, so just use dagger directly. Bug: 80441695 Test: tap PiperOrigin-RevId: 198806461 Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
2018-06-01Some minor tweaks to the UI.calderwoodra
Bug: 79883035 Test: tap PiperOrigin-RevId: 198510062 Change-Id: Ia07624a4511626b2b397199f3674817612557133
2018-06-01Fix dialpad theme on incall screen.wangqi
Test: manual PiperOrigin-RevId: 198488607 Change-Id: I54e2d7ac4320fd67e1670bb2e888cfe833dfb243
2018-05-29Converted ThemeUtil into a DaggerModule.calderwoodra
This enables us to have Google-Sans font in GoogleDialer and Roboto in AOSP. Bug: 79883035 Test: tap PiperOrigin-RevId: 197774497 Change-Id: I1d490ab196a444c62e439444627d659fc42973ea
2018-05-29Began implementation of Dialer dark theme.calderwoodra
- README on how to properly theme Dialer going forward. - Migrated all widgets to use global colors. - Removed all activity and application themes where it wasn't necessary. - Added themeing test rule for Espresso tests. Bug: 79883035 Test: tap PiperOrigin-RevId: 197634256 Change-Id: I4b7d94d45aeeb59d484b0069fdd1e200a654910b
2018-05-21Check READ_PHONE_STATE for isVoicemailAvailable()twyen
TelecomUtil.has*Permission() pass if the dialer is the default dialer. In reality most API does not allow the default dialer do whatever they want. PermissionUtil should be used instead. TEST=uabdullah please fix your "Temporary" @Ignore Bug: 77907588 Test: uabdullah please fix your "Temporary" @Ignore PiperOrigin-RevId: 197442842 Change-Id: I1e6f275e2b8e6d3cfa54ddb8cd24f7d47f9462ca
2018-05-21Add promotion module.wangqi
Refactor Duo disclosure card to general promotion card. Bug: 78905507 Test: unit tests PiperOrigin-RevId: 197436677 Change-Id: I511c39308cadfb96ee4519b71ca29b75d0e6750b
2018-05-21Implement a global theme to be easily configured in Dialer.calderwoodra
deleted several colors and unified them across the app migrated several alert dialogs to support alert dialogs added many todos migrated several tests from GoogleRobolectricTestRunner to RobolectricTestRunner Because of the test migration: - moved dialpad theme attributes into dialpad/theme - moved incall ui theme attributes into incallui/theme Bug: 79883035 Test: tap PiperOrigin-RevId: 197246477 Change-Id: Ifc534793bc32757bbbf2007a7c40287c8d0817ad
2018-05-18Fix video call from search stripping + prefixtwyen
The smart dial normalization remove non-digits, so the raw number must be set. TEST=TAP Bug: 79400183 Test: TAP PiperOrigin-RevId: 197208475 Change-Id: I303f1b19c30f11303066750f7a830f33ab79ce4f
2018-05-17Internal change.linyuh
Bug: 38502365 Test: None PiperOrigin-RevId: 197043585 Change-Id: If9baef5cdd59d6f94cca6d6298efe59d4e296485
2018-05-15Initialize dialpadFragment and searchFragment with FragmentManager when ↵twyen
MainSearchController is created If the controller is recreated the same fragments should be used. TEST=TAP Bug: 77540395 Test: TAP PiperOrigin-RevId: 196575979 Change-Id: I80a239296079ea625b076c0c42cff1a71ffbd4c0
2018-05-15Compress all of dialer's png files.calderwoodra
Test: tap PiperOrigin-RevId: 196575887 Change-Id: If2d07a2db075697f490d99021ad0616b40a3aff7
2018-05-15Exit multiselect mode when opening the dialpad.calderwoodra
Bug: 79183384 Test: manual PiperOrigin-RevId: 196344851 Change-Id: I9f5c0e52cb4efe9e63e2c19a4f62ee0b9a23412f
2018-05-11Use old BottomSheetBehavior.wangqi
Test: presubmit PiperOrigin-RevId: 196285108 Change-Id: Ie424d231ced4066b0d5b734bebae443942994943
2018-05-11Prevent showDialpad from adding multiple instances of fragmentstwyen
Previously when the dialpad is shown the fragment manager is checked to decide whether to create a new fragment or not. This check does not account for pending transactions. If multiple ACTION_DIAL intents is received before the first showDialpad transaction is actually committed (due to the system lagging), multiple dialpad fragment will be added and cause crashes. In this CL, the MainSearchController will hold on to the dialpad and search fragment instance, instead of querying the fragment manager. TEST=manual - modify code to delay the commit. The timing is difficult to set up in tests. Bug: 77540395 Test: manual - modify code to delay the commit. The timing is difficult to set up in tests. PiperOrigin-RevId: 196197187 Change-Id: Ie649a9fba0ecfd8944781949c179ac8739930830
2018-05-11Add RTT after call promo bottomsheet.wangqi
Bug: 67596257 Test: unit tests PiperOrigin-RevId: 196049621 Change-Id: I6f9c6292b1d56e3faf7808aa668b03d07230a70b
2018-05-09Always fetch status onResume and add logging for voicemail status in ↵uabdullah
OldMainPeer and Always fetch the voicemail status when resuming OldMainPeerActivity. There is no reason why this should not happen. TEST=N/A Bug: 79365547 Test: N/A PiperOrigin-RevId: 195744525 Change-Id: Ie31551bfecd5056b0b3b559946e9cd2c8f6ef23f
2018-05-09Place Duo calls with PreCalltwyen
This CL consolidates common duo calling operations into precall, including checking reachability, falling back to carrier video call, placing the call to duo with startActivityForResult. TEST=TAP Bug: 78783816 Test: TAP PiperOrigin-RevId: 195742478 Change-Id: I9fea1e4999f604e1f3a153b28079cd0db77b7393
2018-05-09Don't commit fragment transactions if it's not safe.calderwoodra
Bug: 77807682 Test: listnr PiperOrigin-RevId: 195477904 Change-Id: I5408f4fad9bbc20ff7ce72b25201c23b11a35c43
2018-05-09Replace assert checks with safety checks instead.calderwoodra
Bug: 79239533 Test: tap PiperOrigin-RevId: 195456757 Change-Id: Ief432ae2fbd54d20f8fca198e102b22b169bcb77
2018-05-04Don't force open keyboard when RTT is active.wangqi
Bug: 79094585 Test: manual PiperOrigin-RevId: 195130360 Change-Id: I2763ddd950d0fe2479b442fe18363b8ec45a3178
2018-04-28Handle missing permission.READ_CALL_LOG when initializing the badge for ↵linyuh
missed calls. Bug: 78458610 Test: MainActivityOldPeerTest PiperOrigin-RevId: 194555035 Change-Id: Ib3ef02ec3f4a8ce7cfce6d052fce3b9b6daf75e5
2018-04-25Show clear frequents option in the toolbar if there are suggested contacts.calderwoodra
Bug: 36841782 Test: SpeedDialAdapterTest PiperOrigin-RevId: 194210091 Change-Id: I5b8ad5ca43ee6f519de09ad2a8b1b959637a825b
2018-04-17Don't slide the toolbar up if we've scheduled a runnable to slide it up.calderwoodra
Bug: 78132954 Test: listnr PiperOrigin-RevId: 193279654 Change-Id: I0d6e2e39d2f695b2e7d51ddf8c5abbc689187fbd
2018-04-17Improved handling of IS_READ in new call log.zachh
It is not marked "not null" in the system call log and our simulator gives it null data, so handle it more gracefully to be on the safe side. Also enforce "not null" for IS_READ and NEW in annotated call log as I observed that happening somehow (possibly from older builds though). TEST=existing Test: existing PiperOrigin-RevId: 193271095 Change-Id: I780db20c9d6ea5cf5e1d757def9ea06b492267c1
2018-04-17Export activities with exported aliases.calderwoodra
Bug: 77974883 Test: tap PiperOrigin-RevId: 193225925 Change-Id: I0698abffa232a2e3a575de80642005b454a743ca
2018-04-16Don't close search if the user leaves with the dialpad open.calderwoodra
Bug: 77736276 Test: MainActivityOldPeerSearchIntegrationTest PiperOrigin-RevId: 193081987 Change-Id: I466b6094f4d7851033be3bf68f170485a2ec733d
2018-04-12Add SpeedDialFragment to the old peer.calderwoodra
Bug: 36841782 Test: OldMainActivityPeerTest PiperOrigin-RevId: 192647371 Change-Id: I3fff1784ce642b86f1e87a27e38737833f74c6b0
2018-04-06Convert new speed dial to support fragment and add it to new peer.calderwoodra
Bug: 36841782 Test: MainActivityNewPeerTest PiperOrigin-RevId: 191924314 Change-Id: I5e4a4adadd5477115d6b4daf8afb8c6f819496c8
2018-04-06Only request focus on search edit text when it's slide down.calderwoodra
Bug: 77586391 Test: manual PiperOrigin-RevId: 191924178 Change-Id: I792a6f0308f0dde9b4ae82227aa6a8327208a192
2018-04-05Support new voicemail fragment in old peer.uabdullah
This makes the old peer read the CallLogConfig#isNewVoicemailFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewVoicemail and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog database would be read, which would trigger creation. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the voicemail tab, call log tab and ensuring that they are independent. Bug: 77601968 Test: unit and manual. Some tests are failing, so to ensure we can have the voicemail ready for the bug bash tomorrow, I've ignored them temporarily but will be fixed in a follow up CL (tracked by b/77601893) PiperOrigin-RevId: 191738860 Change-Id: I24ca38b862e98324cf802a3020e7e9df31c0b966
2018-04-04Fix search bar margin issue in RTLtwyen
The RemoveView is pushing it around. Since RemoveView and SearchBarView are mutually exclusive, this CL put them into a FrameLayout to avoid position interference. Bug: 77273749 Test: manual PiperOrigin-RevId: 191678018 Change-Id: If4000f63c77c9da6794193d389f890d21452dcbf
2018-04-04Prevent crash when dialpad animation ends after activity is saved.twyen
Bug: 77484989 Test: TAP PiperOrigin-RevId: 191677909 Change-Id: If49a357a9ba158cd740eb789befd2ff802f670d4
2018-04-04Added some logging for mysterious bugs.calderwoodra
Bug: 74196353,77485680,77486095,77540395 Test: tap PiperOrigin-RevId: 191666270 Change-Id: I0423735dde42299bf33ea0b8482c03fd3c2d4675
2018-04-03Handle missed calls for new call log in old peer.zachh
Test: unit PiperOrigin-RevId: 191380073 Change-Id: If554d5ee0c55754802692a364bae591c3951c060
2018-04-03Support placing Duo calls in the new UI's bottom sheet.linyuh
Bug: 70988685 Test: DuoCallModuleTest, PlaceDuoCallEndToEndTest, Manual testing PiperOrigin-RevId: 191372706 Change-Id: I439be71c361eaca722820b81278e5f95322e100c
2018-03-29Fixed a few issues in search with new nav.calderwoodra
- back arrow in search now flips in RTL mode http://screen/1eccBLDqPp0 - search text no longer overlaps icons http://screen/Mq0omQEuZez - keyboard now always closes on pause - location permission is no longer visible in dialpad search Bug: 73088433,74784637,76117373,76440832,76441216 Test: keyboard and rtl tested manually, added test for location permission PiperOrigin-RevId: 190981686 Change-Id: Ia121d410c158df0de9cd731ab280a6d8e9b300d9
2018-03-27Support new call log fragment in old peer.zachh
This makes the old peer read the CallLogConfig#isNewCallLogFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewCallLog and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog and PhoneLookupHistory databases would be read, which would trigger creation. I don't expect this to be a common case because 1) we hopefully never have to disable the framework and 2) Framework is only updated on Phenotype broadcasts and JobScheduler jobs, which hopefully don't typically happen when user is viewing the call log. However, I still want to make sure that if it happens we don't irreversibly break users when we turn the framework back on. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the call log tab, speed dial tab, and while the activity was paused (pressing Home after viewing call log). Note that this CL doesn't address showing missed calls and badge counts correctly with the new fragment; that will come in a later CL. Bug: 74821995 Test: unit and manual PiperOrigin-RevId: 190706481 Change-Id: I618d9c1649169abd65733502cfebc662a835e787
2018-03-27Use CallLogConfig for enabling new peer.zachh
ConfigProvider should not be used directly for reading NUI flags as CallLogConfig needs to perform work when they change. Bug: 74821995 Test: existing PiperOrigin-RevId: 190698415 Change-Id: Ic084d9032d2a6f35ffba9f395eaaff9053cfa262
2018-03-26Fixed drag to remove favorite contacts on a few devices.calderwoodra
There were 2 issues at play here: 1) views not being able to leave the list view bounds 2) RemoveView not getting drag events. Their resolutions are: 1) add a drag drop listener to the root layout of the activity, now the view can be dragged anywhere. 2) Drag events are only sent to views that are visible, so we no longer set the remove view visibility to GONE and instead set it's contents to GONE. Bug: 76086197 Test: manual PiperOrigin-RevId: 190526568 Change-Id: I3360015f65a134a896601d6298d07163844e302c
2018-03-26Remove obsolete methods in CompatUtils and rename it as "LocaleUtils".linyuh
Test: Existing tests PiperOrigin-RevId: 190516504 Change-Id: I5fa9e123b45beb9728257ecd160a348fb3f4732c
2018-03-26Cleaned up the AndroidManifest Intent Filters.calderwoodra
Bug: 75962274,75967273,75972847 Test: manual PiperOrigin-RevId: 190251834 Change-Id: I3673a6b20a886ded86dc4e1a8f75a82e5e0bb199
2018-03-26Removed NUI shortcut.zachh
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig. Other related changes to help accomplish this: -Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework. -Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest). -The "Main" package is also on longer needed since it existed to control the shortcut. Bug: 74821995 Test: existing PiperOrigin-RevId: 190251418 Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
2018-03-20Mitigate some of the jank in opening/closeing search.calderwoodra
There is still some jank on first open, but it's much less janky on close and consecutive open calls. Test: existing tests confirm no regressions PiperOrigin-RevId: 189802733 Change-Id: I49d6c2def7c33be0fdbb79c89772a5e4513cde3b
2018-03-16Make MainActivity the default activity for AOSP.calderwoodra
This also finishes moving all of the old tests over from Dialtacts to Main. The only 2 tests that fail are: - searchBoxClosedWhenHandlingNotificationIntent - openSearchFragment_fabGoneInRegularSearchAfterRotation I will fix these in a follow up CL. Bug: 72525887 Test: dialer_aosp build target launches MainActivity, TAP PiperOrigin-RevId: 189408987 Change-Id: Ice30191d95c19c62bcd89503e89f66440f30beac
2018-03-16Check if dialpad is already open when handleing new intents.calderwoodra
If the user had the dialpad open when they received a call, they could potentially crash dialer if they pressed add call or clicked on a phone number in another app. Bug: 74711879 Test: manual PiperOrigin-RevId: 189371425 Change-Id: I14df55e2467be07dd30e3971004e601216f57daf
2018-03-15Adjust bottom nav margins, sizes, ect.calderwoodra
Test: n/a PiperOrigin-RevId: 189274795 Change-Id: I495e326ce74568d8add739275562284ef12e276f
2018-03-15Resolve all build resource conflicts.calderwoodra
For simplicity, instead of resolve the nui shortcut string, I deleted it since it isn't used anymore. Test: build log PiperOrigin-RevId: 189260472 Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
2018-03-15Register ShowBlockReportSpamDialogReceiver in MainActivity.linyuh
Bug: 73830902 Test: Manual PiperOrigin-RevId: 189222303 Change-Id: I0397986d784d28e7948b39778319e3936f6c55e9
2018-03-14Split CallDetailsActivitylinyuh
Bug: 74202944 Test: Existing tests PiperOrigin-RevId: 189095432 Change-Id: I13015ee6c5767edd95b78c3fb2e7338495e9e1d7
2018-03-13Fixed overlapping fragments issue.calderwoodra
Fast consercutive calls to #showFragment can have undesirable effects because fragment manager doesn't handle transactions sychronously. This CL resolves one of the scanrios where voicemail fetch status was calling #showFragment nearly simulataniously to the #onHandleIntent call. This issue may show itself again and I'm looking into more long term solutions but we should be fine in the short term since the all of our fragment logic is implemented. Bug: 74051208,74621909 Test: manual PiperOrigin-RevId: 188956984 Change-Id: I0796e31b03e0b749ae7e81f82859ea6f814a5fb5
2018-03-13Removed references to MainActivity since they weren't necessary.calderwoodra
Test: existing PiperOrigin-RevId: 188928916 Change-Id: I2b6fb73545194fa175526a77ce2a76b1d23c049d
2018-03-12Keyboard and search now close when appropriate.calderwoodra
Keyboard should close when: - requeting permission - placing a call - leaving the app Search should close when: - placing a call - leaving the app Bug: 74235853 Test: search closing onPause tests already exist (MainActivityOldPeerSearchIntegrationTest#placingCallFromSearchClosesSearch) PiperOrigin-RevId: 188812026 Change-Id: Iaee084c59b4c514d10375deff5d73d5a456ef9df
2018-03-08Bring back new navigation screen event logging.yueg
Test: MainActivityOldPeerTest PiperOrigin-RevId: 188409482 Change-Id: I0c132c49d63b9af849522851c55f51d431faa603
2018-03-07Combine fragment hide/show transactions into one transaction.roldenburg
My hypothesis is that trying to commit multiple seperate transactions back to back causes the fragment container to get into a weird state. So this change has two parts: - Disable preloading call log - Combine the seperate hide/show transactions into one transaction - Don't call conflicting transactions (i.e. hide then immediately show) Bug: 74051208 Test: existing tests, manual PiperOrigin-RevId: 188215791 Change-Id: I699fc02f1e2716bc019a29dc047ee4bc0d52df35
2018-03-06NUI loggingyueg
- Add screen events for 4 tabs, dialpad and search. - Add impressions for opening MainActivity with tabs/dialpad (non user tab selection). - Add impression for VVM visible. Bug: 72525843 Test: MainActivityOldPeerTest, MainSearchControllerTest PiperOrigin-RevId: 188090249 Change-Id: Ifdf3519f07d7230f20b5d82691a96747b1944d63
2018-03-01Implemented DialerFloatingActionButtoncalderwoodra
Implemented wrapper class for FloatingActionButton to resolve some of FloatingActinButton's many issues. One of which is alllowing clicks while animating that was causing a crash in NUI. This change also fixes an issue with the dialpad exit animation. Bug: 73995512 Test: Robolectric and Espresso don't support these kinds of tests very well PiperOrigin-RevId: 187556390 Change-Id: I4cb7c2346a0ef09f2f3d8b48e7e14d01460cd1a7
2018-03-01Rename NUI logging prefix from NUI_ to MAIN_yueg
Bug: 72525843 Test: none PiperOrigin-RevId: 187500135 Change-Id: Iaa73b9355a6b5c299f73fd113eb1f74a3eb47dd4
2018-03-01Added same primes metrics that existed in Dialtacts to NUI.calderwoodra
Test: n/a PiperOrigin-RevId: 187442952 Change-Id: I9463e2c976102276ebc5886531397ad0cf160b78
2018-02-28Preload call log fragment on app start.calderwoodra
Default is set to true but if we see issues with startup latency we can disable this server side. Test: n/a PiperOrigin-RevId: 187419851 Change-Id: I6d1debfed86dbcaf3ee73ec0906e514a2687e2c0
2018-02-28Some small bug fixes in NUI.calderwoodra
- Never show the dialpad chooser in MainActivity. - If the call log changed while dialer was in the background, it would trigger the content observer to fetch the new info, which would request it's parent that wasn't there. Now we register/unregister them in onResume/onPause. This is safe to do because we force refresh the data onResume anyways, so any changes will still be shown. Bug: 73972084,73975555,73995512 Test: manual PiperOrigin-RevId: 187407058 Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030
2018-02-28Parity of OldMainActivityPeer with ListsFragment for VMuabdullah
This CL helps to ensure that when the VVM settings toggle is turned on or off, or a sim is swapped, inserted or removed the VM tab disappears and appears, just like it currently does. When a VM tab disappears we also move to the speed dial index. Bug: 73123614,73998717 Test: N/A PiperOrigin-RevId: 187400703 Change-Id: I76a0b43da86713caa67956413a39299c7ecbc8d1
2018-02-27Do not show the voicemail tab if the VM toggle is turned off.uabdullah
Bug: 73123614 Test: N/A PiperOrigin-RevId: 187255950 Change-Id: I9ab50a7a8052f325f1743721bf6432e6c4787a4e
2018-02-27Fab now hides/shows correctly when you enter and leave the voicemail tab.calderwoodra
Test: manual, going between tabs hides/shows the fab properly when ToS is (in)visible. PiperOrigin-RevId: 187253210 Change-Id: Ied9ea44892786268b9dfa68816840dfbfc74aa6e
2018-02-27Fixed some a11y issues in MainActivity.calderwoodra
- main fragments are no longer detected by talkback while search is open. - FAB now has a content description Bug: 73587831,73891132 Test: tap PiperOrigin-RevId: 187248081 Change-Id: I5a8fe2df23542d19c935cba77d1337ec753064af
2018-02-27Implement contacts promo in NUI.yueg
Bug: 72525950 Test: ContactsPromoFragmentTest, MainSearchControllerTest, OldGoogleMainActivityPeerTest PiperOrigin-RevId: 187224361 Change-Id: Idc43255ccc673c6c5c17b70d1f367d1a4802bfd0
2018-02-26Added Call History activity to MainMenu.calderwoodra
Test: MainActivityOldPeerIntegrationTest PiperOrigin-RevId: 187080344 Change-Id: I1c9fd942a4c198c9a914d6aefe7c4cc638f39c01
2018-02-26Implement logic of bottom sheet options related to spam numbers.linyuh
Bug: 70989605 Test: ShowBlockReportSpamDialogNotifierEndToEndTest + Manual PiperOrigin-RevId: 187047450 Change-Id: I23c3929135bcfe5c14fe317ef65f628dc126027f
2018-02-24Cancel Old SpeedDial contact loaders when they are reset.calderwoodra
This prevents to many loaders running at the same time and crashing the application for using too many threads at once. Also made a few UI changes: - Change Android nav bar color to #FFF - Move badges down 2dp - Limit badges to 9+ (instead of 99+, added flag to configure this) - search bar no longer has rounded corners when expanded Bug: 72525324 Test: MainActivityOldPeerTest PiperOrigin-RevId: 186894920 Change-Id: I36fc5d8794440b707184d54de427db5910ec5b8e
2018-02-24Fixed a few bugs in NUI Main Activity.calderwoodra
- Normalized the search query returned from DialpadFragment - Dial button now updates when given a psuedo emergency number - 'Clear frequents' now displays and functions properly in the menu - Added simulator to the menu Bug: 72525324 Test: added tests for clear frequents (only prod feature). PiperOrigin-RevId: 186875815 Change-Id: I3bad3c71b355b987fc85777550bfa1de5028c3a4
2018-02-22NUI bug fixes: handling intents and onActivityResult.calderwoodra
- Handle Calls.CONTENT_TYPE intents - Handle Add Call intents - Handle onActivityResults Bug: 72525324,72525840 Test: implemented PiperOrigin-RevId: 186523438 Change-Id: Ia014e5e10ee0be2f32a09df79b3ade12d09814e9
2018-02-22Fixed some Dialer theming bugs in NUI.calderwoodra
- URL links are now blue - Raised buttons are now blue w/ white text - android nav bar is white - call log actions/icons are the correct colors - search bar hint text is the correct color Bug: 72525324 Test: screenshot PiperOrigin-RevId: 186484088 Change-Id: I1863a28e1ea9bf16863f42299afca319a6bdcc97