Age | Commit message (Collapse) | Author |
|
Fast consercutive calls to #showFragment can have undesirable effects because
fragment manager doesn't handle transactions sychronously. This CL resolves one
of the scanrios where voicemail fetch status was calling #showFragment nearly
simulataniously to the #onHandleIntent call.
This issue may show itself again and I'm looking into more long term solutions
but we should be fine in the short term since the all of our fragment logic
is implemented.
Bug: 74051208,74621909
Test: manual
PiperOrigin-RevId: 188956984
Change-Id: I0796e31b03e0b749ae7e81f82859ea6f814a5fb5
|
|
- Add screen events for 4 tabs, dialpad and search.
- Add impressions for opening MainActivity with tabs/dialpad (non user tab selection).
- Add impression for VVM visible.
Bug: 72525843
Test: MainActivityOldPeerTest, MainSearchControllerTest
PiperOrigin-RevId: 188090249
Change-Id: Ifdf3519f07d7230f20b5d82691a96747b1944d63
|
|
This CL helps to ensure that when the VVM settings toggle is turned on or off, or a sim is swapped, inserted or removed the VM tab disappears and appears, just like it currently does. When a VM tab disappears we also move to the speed dial index.
Bug: 73123614,73998717
Test: N/A
PiperOrigin-RevId: 187400703
Change-Id: I76a0b43da86713caa67956413a39299c7ecbc8d1
|
|
In the case where the user is not able to dial into the voicemail tab, or there exists another voicemail app, or VVM is not supported, we do not want to show the VM tab.
This CL does not update the activity when a sim is inserted/removed.
Bug: 73123614
Test: Unit tests
PiperOrigin-RevId: 186433072
Change-Id: I0396b1e15c9a4740eee721af89dbfdf95696cace
|
|
Playing with the existing app, the missed call becomes unbolded when:
1) Expanding the row. The closest analog of this is in the new UI is opening the bottom sheet, I've done that.
2) Swiping away from the call history tab. This can't be done in NewCallLogFragment because it doesn't know if the user is selected a new tab or pressed Home. So, I implemented this in NewMainActivityPeer.
3) After viewing the call log for 3(ish) seconds and leaving the activity pressing Home/Back. This is best done in NewCallLogFragment#onResume since MainActivity doesn't always know when the fragment is being displayed (it could be done after the user comes back to the app after pressing Home for example).
Note that the notification is also removed in all of these cases.
Also note that dismissing the notification makes the call unbolded (but this case already appears to be handled via the system call log content observer).
Also, as part of writing tests for this, I made TestCallLogProvider more realistic.
Bug: 70989622
Test: manual
PiperOrigin-RevId: 185457438
Change-Id: Ib360d3bc73083bd1a018ed98e2b7d9a69fb7fafb
|
|
Bug: 72525324
Test: manual
PiperOrigin-RevId: 184615350
Change-Id: Ic5701d67111e38f73dfa4be31dd89115ad7f5bb8
|