summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/calllog
AgeCommit message (Collapse)Author
2020-12-12Updated target SDK from 28 to 29.Raman Tenneti
Merged the following change from internal source: cl/305938566 Do not use EXTRA_IS_HANDOVER for API levels 28 and above When targeting API level 29, this field becomes blacklisted. Since the Handover feature is officially supported via a public API since API level 28, we do not need to check for the internal field when the API level is 28+. go/forrest_run/L11100000565062425 BUG: 143990966 Test: manual and CTS tests. Change-Id: Ib3fda29b4d5714efc52b29f49ca4a9a310584fff
2020-12-12Dialer: Fix proto warning with optmize for liteLuca Stefani
* option optimize_for = LITE_RUNTIME is ignored in proto 3+ * Instead we should use the java_lite compiler via the LOCAL_PROTOC_OPTIMIZE_TYPE flag which defaults to lite in java projects Test: m Dialer, no warnings Change-Id: I552f5895bbe8192a4ae870bb48e5ef6a9e7e8c78
2018-07-10Update translation strings.Eric Erfanian
Test: make Change-Id: Ib75f4f25e91067311de244d7f1fb95bc898aec22
2018-06-28Remove redundant @TargetApi, @RequiresApi and @SuppressWarningslinyuh
Test: Existing tests PiperOrigin-RevId: 202589482 Change-Id: I6982e4069d30032bf46caf3c9984dfc0e7196f6f
2018-06-28Avoid updating system call log cache when the call log is being builttwyen
The initial build can contain up to 1000 rows, which may be more the what the system call log can handle with a batch operation. Initial build does not create any additional information, so the cache does not need to be updated. This CL also limits the cache updater to 100 rows as a safety measure. TEST=TAP Bug: 77292040 Test: TAP PiperOrigin-RevId: 202563376 Change-Id: Iff515ae2b76a19d63d9d794a0d443cc8332e83a4
2018-06-28Also ignore IllegalStateException thrown by SQLiteClosable when coalescing ↵linyuh
fails. Test: Manual PiperOrigin-RevId: 202499434 Change-Id: Ie41eeb782072d82c5613b44be99649f43807498d
2018-06-27Log existing call log impressions in the new call log.linyuh
Bug: 73741308 Test: DeleteCallLogItemModuleTest, HistoryItemActionModulesBuilderTest PiperOrigin-RevId: 202232055 Change-Id: Idcf29c939272a335ccea469ac331c670127c583a
2018-06-26Improved testability.zachh
Bug: 109931227 Test: unit PiperOrigin-RevId: 201752687 Change-Id: I10e101242b86d5c277b536a1e64e47f1a033e3a3
2018-06-21Only throw expected exception when coalescing fails.linyuh
Bug: 110185399 Test: Manual PiperOrigin-RevId: 201570143 Change-Id: I5cf02a838113bde2dd218b84dda2c9cccffaa322
2018-06-21Keep actions on new call log entries consistent with those in the old call log.linyuh
Bug: 110412130 Test: NewCallLogViewHolderTest, NewCallLogIntegrationTest PiperOrigin-RevId: 201543827 Change-Id: I301aaf686b729086776ab3bcc677bacd2450fea0
2018-06-20Enforce AnnotatedCallLog column constraints in its content provider.linyuh
Bug: 110185399 Test: AnnotatedCallLogConstraintsTest, AnnotatedCallLogContentProviderTest PiperOrigin-RevId: 201444134 Change-Id: I105ec7a201265ee5e7708ffb9a4b66b4cef01174
2018-06-18Improve Coalescer performancelinyuh
Bug: 77813585 Test: CoalescerTest PiperOrigin-RevId: 200764878 Change-Id: I7e3d9c3b4eab1e5de12a108b82c04704550c8c5e
2018-06-11Default column IS_VOICEMAIL_CALL to 0 in the annotated call log.linyuh
Test: AnnotatedCallLogDatabaseHelperTest PiperOrigin-RevId: 200134473 Change-Id: I1d3f43630b6cd7753ef8b72a7a02d119c8ab75cc
2018-06-11Have Coalescer return CoalescedRow protos directly.linyuh
Bug: 77813585 Test: CoalescerTest, NewCallLogAdapterTest, NewCallLogViewHolderTest PiperOrigin-RevId: 200086621 Change-Id: I8f79359a5972c578ae439aaf33233900b0606dc8
2018-06-07Wrap phone numbers in custom content descriptions in the new call log with ↵linyuh
TTS span. Bug: 70989658 Test: Manual (TTS span is not testable) PiperOrigin-RevId: 199724621 Change-Id: I6dc809660eecdd987ee966f30b68dbbf7bcf2094
2018-06-06Update call log cache when annotated call log is updated.twyen
If the NumberAttribute has changed the new data will be cached back to the call log. Also updated TestCallLogProvider to support selection with ID based URI. Note: currently the write will trigger an extra refresh, the next CL will address that. TEST=TAP Bug: 77292040 Test: TAP PiperOrigin-RevId: 199509348 Change-Id: I49c43adb5bcec96128d5ec36676c4569bf536490
2018-06-04Replace TextView with BidiTextView in the new call log where a phone number ↵linyuh
can be shown. Bug: 72162627 Test: Existing tests PiperOrigin-RevId: 199190694 Change-Id: I19f2ae7e8af452062672c67eb1be1bc6cc49b855
2018-05-30Better a11y for contact badge in the new call log.linyuh
Bug: 70989658 Test: GlidePhotoManagerImplTest PiperOrigin-RevId: 197918533 Change-Id: I61d04e270ddf4237e8ed9c10e62e8d95f86d1eca
2018-05-30Better a11y for new call log entries.linyuh
Bug: 70989658 Test: CallLogDatesTest, CallLogEntryDescriptionsTest, NewCallLogViewHolderTest PiperOrigin-RevId: 197811739 Change-Id: I0f9d1e79d8e687efffbb1dac01aaf6fa26a45f6a
2018-05-29Delete AppCompatConstantslinyuh
Test: Existing tests PiperOrigin-RevId: 197681266 Change-Id: I27fdda1d5c252993795b6eb860663c8cab0d363c
2018-05-29Began implementation of Dialer dark theme.calderwoodra
- README on how to properly theme Dialer going forward. - Migrated all widgets to use global colors. - Removed all activity and application themes where it wasn't necessary. - Added themeing test rule for Espresso tests. Bug: 79883035 Test: tap PiperOrigin-RevId: 197634256 Change-Id: I4b7d94d45aeeb59d484b0069fdd1e200a654910b
2018-05-21Add promotion module.wangqi
Refactor Duo disclosure card to general promotion card. Bug: 78905507 Test: unit tests PiperOrigin-RevId: 197436677 Change-Id: I511c39308cadfb96ee4519b71ca29b75d0e6750b
2018-05-21Implement a global theme to be easily configured in Dialer.calderwoodra
deleted several colors and unified them across the app migrated several alert dialogs to support alert dialogs added many todos migrated several tests from GoogleRobolectricTestRunner to RobolectricTestRunner Because of the test migration: - moved dialpad theme attributes into dialpad/theme - moved incall ui theme attributes into incallui/theme Bug: 79883035 Test: tap PiperOrigin-RevId: 197246477 Change-Id: Ifc534793bc32757bbbf2007a7c40287c8d0817ad
2018-05-18Remove duplicate code when constructing PhotoInfo proto.linyuh
Bug: 79770053 Test: Existing tests PiperOrigin-RevId: 197192087 Change-Id: I44c60d13c83b3e23dc141fd9e9b88e108687bf96
2018-05-17Finishing touches for accessibility in the new call log and the new ↵linyuh
voicemail fragment Bug: 70989658 Test: Manual PiperOrigin-RevId: 197046549 Change-Id: I11f9515aad0b5d9c07ebb5d3ff480ed6751bd187
2018-05-16Improve ContactPhotoViewlinyuh
Bug: 70989658 Test: NewCallLogIntegrationTest + Manual PiperOrigin-RevId: 196845473 Change-Id: Ic0cbcf668ea1921c88fb6b080308884fa1113e61
2018-05-15Add Espresso tests for the new call log.linyuh
Bug: 70989635 Test: NewCallLogIntegrationTest PiperOrigin-RevId: 196696755 Change-Id: I63c45f2996e08b40e41344fc35ce69317c08a42d
2018-05-15Don't use LoaderManager.getInstance() in dialer.zachh
It was added in support library 28 which isn't available in AOSP. TEST=none Test: none PiperOrigin-RevId: 196692493 Change-Id: Id53c298af61c4635f1874131a8ae84620669a16d
2018-05-15Register system call log content observer if user enables Phone permission.zachh
Previously, we only attempted to create the content observer in Application#onCreate and if the user didn't have the permission enabled, it wouldn't get added and would remain off for the duration of the application's life. Now we check if the observer is registered when refreshing the call log and enable it if necessary. TEST=unit Bug: 72461366 Test: unit PiperOrigin-RevId: 196543060 Change-Id: I1d58efd21fb63e0745b43ac8ff11d87562126a2f
2018-05-15Support missing phone permission in new call log.zachh
When the permission is missing, provide a link for the user to turn it on. TEST=unit Bug: 72461366 Test: unit PiperOrigin-RevId: 196329702 Change-Id: I13f8c82769a13b12e1b3bd9fc14dfda36bd9a348
2018-05-11Move coalescing logic out of AnnotatedCallLogContentProvider.linyuh
Bug: 79232964 Test: CoalescerTest, AnnotatedCallLogCursorLoaderTest, and manual testing. PiperOrigin-RevId: 196321995 Change-Id: I016bf28e0c09cf4fee5bc5a9115335fb35b7f7e9
2018-05-11Add @InstallIn and @IncludeInDialerRoot to dagger modules in dialer codebase.weijiaxu
Test: presubmit. PiperOrigin-RevId: 196158524 Change-Id: Iec1e457039e97be0236cd700d397b4095ee3c2c3
2018-05-11Add RTT after call promo bottomsheet.wangqi
Bug: 67596257 Test: unit tests PiperOrigin-RevId: 196049621 Change-Id: I6f9c6292b1d56e3faf7808aa668b03d07230a70b
2018-05-09Allow the TextView for call log primary text to adjust size when recycled.linyuh
Bug: 77835800 Test: Manual PiperOrigin-RevId: 195861757 Change-Id: I79f99c3468324922560961ea71dcc792a4d83a24
2018-05-09Added getLoggingName() to CallLogDataSource and PhoneLookup interfaces.zachh
Use it when logging performance metrics. Unfortunately the class names returned by Class#getSimpleName() are obfuscated by proguard and make viewing the metrics difficult to impossible. TEST=none Test: none PiperOrigin-RevId: 195749831 Change-Id: I40320f388d34e059c9a913e2b72a1acf1a727f60
2018-05-09Config correct layout boundaries to accommodate long text (call log & bottom ↵linyuh
sheet) Bug: 77835800 Test: Manual PiperOrigin-RevId: 195706300 Change-Id: Iccc97d5cc3ab6f196dc917faf1d7b6659b06cf30
2018-05-09Use info from EmergencyPhoneLookup to render UI for an emergency number.linyuh
Bug: 71719349 Test: CallLogEntryTextTest, HistoryItemActionModulesBuilderTest PiperOrigin-RevId: 195694340 Change-Id: Ib53305c36f7ca062ef798ab3f61585d3c71adef3
2018-05-09Implement EmergencyPhoneLookup for checking if a number is an emergency number.linyuh
Bug: 71719349 Test: EmergencyPhoneLookupTest, PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 195691356 Change-Id: I705721fa6e6a22e5b2d541578b83196181c895eb
2018-05-09Pass activity between new call log's adapter/view holder.zachh
This avoids a cast and generally improves understandability. TEST=existing Test: existing PiperOrigin-RevId: 195457457 Change-Id: Ida9d3fc85bed8ff1e0f8064805e23fab00fdeddf
2018-05-04Clear NewCallLogViewHolder.onClickListener if row is not callable.twyen
Previously the listener is not cleared, and clicking on a private will call whatever the view was previously bound to. TEST=TAP Bug: 79219109 Test: TAP PiperOrigin-RevId: 195332291 Change-Id: I4806ab659099dc7986b90c68f2e52d8efd4f5f5b
2018-05-04Mark photo info as voicemails in bottom sheettwyen
TEST=TAP Bug: 79089209 Test: TAP PiperOrigin-RevId: 195317152 Change-Id: I2d456dc786f2ea6555b76d3ef6721140acee7413
2018-05-04Simplify how we build bottom sheet options (a.k.a. modules).linyuh
Test: HistoryItemActionModulesBuilderTest, ModulesTest PiperOrigin-RevId: 195294876 Change-Id: Iac44f965a585975389da7dee758a94a8ad8311d3
2018-05-04Merge "Update targetSdkVersion to 28"android-build-prod (mdb)
2018-05-04Merge changes I481fbbc7,I57e48b5d,Ieb52489b,I2763ddd9android-build-prod (mdb)
* changes: Translation tweaks. Migrated context menu to be a PopupMenu instead. Add column for call mapping id to AnnotatedCallLog database. Don't force open keyboard when RTT is active.
2018-05-04Update targetSdkVersion to 28maxwelb
Bug: 79153175 Test: Compiled and verified that merged manifest had targetSdkVersion=28 PiperOrigin-RevId: 195145440 Change-Id: I12cde947d8fe8594f91bcc3dacdba6f9c72ac84a
2018-05-04Add column for call mapping id to AnnotatedCallLog database.wangqi
This will ensure call mapping used by RTT etc. won't break when migrating to new way to generate the call mapping id since they are stored in the database already. Bug: 77717594 Test: unit tests PiperOrigin-RevId: 195132562 Change-Id: Ieb52489b19b37ac2701967eb570a96457ceed4c0
2018-05-04Replace DuoConstants with interface.twyen
They are not constant across different Duo implementations. TEST=TAP Bug: 76430187,78783816 Test: TAP PiperOrigin-RevId: 195001650 Change-Id: I4356d04c9eeac50fefd41e1142f3123591e93bc0
2018-05-02Select SIM when calling back from call log.twyen
Previously the NUI call log call backs with whatever SIM the call was made/received in, which is inconsistent with the old UI. The Old UI behavior should be kept. TEST=TAP Bug: 78291136 Test: TAP PiperOrigin-RevId: 194878167 Change-Id: If9c5adcbed6a194c801d2b558abb45573b97d2ae
2018-04-26Show Cequint info in the new call log.linyuh
Bug: 70989584 Test: PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 194494486 Change-Id: I706802c000da953f962786bd07ca5da2fd59dc8a
2018-04-24Don't allow reporting a inaccurate number for a voicemail call.linyuh
Bug: 78291768 Test: ModulesTest PiperOrigin-RevId: 194114862 Change-Id: Iee367be53ffff5226a818ebb4af69ddd55054812
2018-04-19Use PreCall.start instead of context.startActivity when starting calls from ↵zachh
call log. For some reason not understood, startActivity with the call intent causes the current activity (MainActivity) to be paused, resumed, and paused again. This results in an opportunity to double-tap the row which causes the InCallUi to open in bubble mode (this is also not well understood). In any event, PreCall.start eventually uses TelecomManager to place the call rather than startActivity, which is presumably the thing that fixes the problem. Also refactored TestPreCallModule to remove the many test implementations of PreCall and remove the static field in the module which could cause test interference. TEST=manual Bug: 78187587 Test: manual PiperOrigin-RevId: 193596093 Change-Id: I933020d33db1c158628f14b30c2681c59c86201b
2018-04-18Support placing a call with assisted dialing in the new call log.linyuh
Bug: 70988691 Test: ModulesTest PiperOrigin-RevId: 193434411 Change-Id: I3fe493eeb2869cad0d42ccf08d57018a42b1b84e
2018-04-18Reduce the number of parameters when building bottom sheet options for ↵linyuh
telecom/Duo calls. Bug: 70988691 Test: ModulesTest, DuoCallModuleTest PiperOrigin-RevId: 193431749 Change-Id: I2af9979504b99175513cb753a030244f735828be
2018-04-17Improved support for short codes in Coalescer.zachh
Use ShortNumberInfo to identify shortcodes and apply more basic matching for them; without this short codes like '5555' and '55555' would match due to being a SHORT_NSN_MATCH even though they should not match. Also removed the PhoneNumberUtil argument from DialerPhoneNumberUtil's constructor as it was always PhoneNumberUtil.getInstance(). (This allowed me to do a similar thing for ShortNumberInfo.getInstance()). TEST=unit Bug: 71586485 Test: unit PiperOrigin-RevId: 193288929 Change-Id: Ia16c78e7eee5e0912d3913660952b9ee32713731
2018-04-17Improved handling of IS_READ in new call log.zachh
It is not marked "not null" in the system call log and our simulator gives it null data, so handle it more gracefully to be on the safe side. Also enforce "not null" for IS_READ and NEW in annotated call log as I observed that happening somehow (possibly from older builds though). TEST=existing Test: existing PiperOrigin-RevId: 193271095 Change-Id: I780db20c9d6ea5cf5e1d757def9ea06b492267c1
2018-04-16Don't show the Duo disclosure card if it's been viewed for more than 1 day.linyuh
Bug: 70989614 Test: NewCallLogAdapterTest PiperOrigin-RevId: 193101600 Change-Id: I52b0db9dc03d5e44cad7462403c2639fb33b5f33
2018-04-16Remove column PHONE_ACCOUNT_LABEL and PHONE_ACCOUNT_COLOR from the annotated ↵linyuh
call log. Bug: 77808449 Test: NewCallLogViewHolderTest + existing tests for the call log framework PiperOrigin-RevId: 193086917 Change-Id: I39244c69acf1d261699610f6010c0cf147ca3492
2018-04-13Animate duo disclosure dismissal.calderwoodra
Test: tap PiperOrigin-RevId: 192825959 Change-Id: I814537b08d9afd678c1cb88e6012e60e5511b6bb
2018-04-13Increased tap target for 3-dot menu in new call log.zachh
Accomplished by replacing margin with padding. TEST=manual Bug: 77812328 Test: manual PiperOrigin-RevId: 192818386 Change-Id: Iaf58b8460c18259a0472fd154695238c7e93a489
2018-04-12Add Duo disclosure card to the new call log.linyuh
Bug: 70989614 Test: NewCallLogAdapterTest PiperOrigin-RevId: 192692744 Change-Id: I42dbb5738558803ad6eae9fe2c2f98b31c49f360
2018-04-11Add RTT badge to new call log.wangqi
Bug: 77717594 Test: ContactPhotoViewTest PiperOrigin-RevId: 192492913 Change-Id: I6db36017fde2cf9dca580d60d5c88bf2ad2dfe16
2018-04-10For an audio call log entry, add a video call option in the bottom sheet if ↵linyuh
the capability is present. Bug: 70989603 Test: ModulesTest PiperOrigin-RevId: 192302145 Change-Id: I3162e7d22223aa02709d0d401c70c6fc37a00e3b
2018-04-05Exclude Duo audio calls from the new call log.linyuh
Bug: 77496097 Test: SystemCallLogDataSourceTest PiperOrigin-RevId: 191845115 Change-Id: Id0d3770e0cd21383cf2f4c5ae5314ca4de258edd
2018-04-05Support new voicemail fragment in old peer.uabdullah
This makes the old peer read the CallLogConfig#isNewVoicemailFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewVoicemail and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog database would be read, which would trigger creation. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the voicemail tab, call log tab and ensuring that they are independent. Bug: 77601968 Test: unit and manual. Some tests are failing, so to ensure we can have the voicemail ready for the bug bash tomorrow, I've ignored them temporarily but will be fixed in a follow up CL (tracked by b/77601893) PiperOrigin-RevId: 191738860 Change-Id: I24ca38b862e98324cf802a3020e7e9df31c0b966
2018-04-04Use the default phone account for a voice call when the call log item is for ↵linyuh
Duo. Bug: 77535982 Test: ModulesTest + Manual PiperOrigin-RevId: 191612821 Change-Id: I417b46ed3ec131bf409c427d82f5b2fa6b791054
2018-04-03Separate calls with the video feature from others when coalescing rows in ↵linyuh
the new call log. Test: CoalescerTest PiperOrigin-RevId: 191376690 Change-Id: Id5939175edddd164a1b477319fb20e6d2a9671a9
2018-04-03Support placing Duo calls in the new UI's bottom sheet.linyuh
Bug: 70988685 Test: DuoCallModuleTest, PlaceDuoCallEndToEndTest, Manual testing PiperOrigin-RevId: 191372706 Change-Id: I439be71c361eaca722820b81278e5f95322e100c
2018-03-30Use IS_READ instead of NEW in new call log.zachh
We want to be more consistent with other usages of NEW in the app, i.e. NEW should be used primarily by notifications. Bug: 74821515 Test: unit PiperOrigin-RevId: 191139559 Change-Id: Ib6fbead8b5589aedd881db26a07f7daed4d83543
2018-03-30Added logging for popping in new call log.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 191099351 Change-Id: I47f1e487e2a0cc23af7b39ae89e20abf993933ea
2018-03-29Badge contact photos for video calls in the bottom sheet.linyuh
Bug: 70988682 Test: Existing tests PiperOrigin-RevId: 190946639 Change-Id: Iaa8294e8ba6e85ab3c27bb2e67200d7972a240f2
2018-03-28Create a common widget (ContactPhotoView) for a contact photo and its ↵linyuh
optional badge. Bug: 70988682 Test: ContactPhotoViewTest PiperOrigin-RevId: 190855440 Change-Id: Ib658efa6486b66548c710804049517905dc67b13
2018-03-28Badge contact photos in the new call log for video calls.linyuh
Bug: 70988682 Test: NewCallLogViewHolderTest PiperOrigin-RevId: 190783830 Change-Id: Ib0b1ec23b7c278b83516019924b6c68ff12adaf9
2018-03-27Support new call log fragment in old peer.zachh
This makes the old peer read the CallLogConfig#isNewCallLogFragmentEnabled and show the old or new fragment accordingly. If the user is viewing the NewCallLog and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog and PhoneLookupHistory databases would be read, which would trigger creation. I don't expect this to be a common case because 1) we hopefully never have to disable the framework and 2) Framework is only updated on Phenotype broadcasts and JobScheduler jobs, which hopefully don't typically happen when user is viewing the call log. However, I still want to make sure that if it happens we don't irreversibly break users when we turn the framework back on. I tested this by flipping flags and observing underlying data being removed: > dialer-cmd configprovider set new_voicemail_fragment_enabled false > adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml I test flipping flags back and forth on the call log tab, speed dial tab, and while the activity was paused (pressing Home after viewing call log). Note that this CL doesn't address showing missed calls and badge counts correctly with the new fragment; that will come in a later CL. Bug: 74821995 Test: unit and manual PiperOrigin-RevId: 190706481 Change-Id: I618d9c1649169abd65733502cfebc662a835e787
2018-03-26Remove TODOs left for M in the new call log as the min SDK has been bumped to N.linyuh
Bug: 72125574 Test: None. PiperOrigin-RevId: 190572832 Change-Id: I581d3c9e366a1190c1608b369700aeb511fe51d1
2018-03-26Removed NUI shortcut.zachh
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig. Other related changes to help accomplish this: -Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework. -Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest). -The "Main" package is also on longer needed since it existed to control the shortcut. Bug: 74821995 Test: existing PiperOrigin-RevId: 190251418 Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
2018-03-26Increase minSdk to 24.calderwoodra
Manually set to M - MissedCallNotifierTest (not sure what the issue is here...) - CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown) - MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory)) Ignore Tests - a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason) - VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear) Bug: 73902692 Test: tap PiperOrigin-RevId: 190030202 Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
2018-03-22Removed appContext from CallLogDataSource and PhoneLookup.zachh
Impls can access appContext via dagger. Test: existing PiperOrigin-RevId: 189974157 Change-Id: Ie64d2c6f9ba08fc914d3c31f7e014c2beef3ab00
2018-03-22Enable and disable the call log framework on flag changes.zachh
Bug: 74821995 Test: unit PiperOrigin-RevId: 189969399 Change-Id: I8e287cc7884dde7640721bd385fe383a4635f3c8
2018-03-20Added "clearData" to CallLogDataSource and PhoneLookup interfaces.zachh
This is necessary to disable the call log framework via flags. This isn't yet called anywhere. Bug: 74821995 Test: unit PiperOrigin-RevId: 189838957 Change-Id: I926c02c41151528eabc208c874acbfe7897a2f93
2018-03-20Added unregisterContentResolvers() to CallLogDataSource and PhoneLookup.zachh
This is needed to support flag changes which should cause the call log framework to become disabled. It's not called anywhere yet. Bug: 74821995 Test: unit PiperOrigin-RevId: 189761665 Change-Id: I914c690448f03ebacd7d05c9ad082aba7bf1a4ce
2018-03-19Make the top row of the bottom sheet not clickable.linyuh
Test: Existing tests PiperOrigin-RevId: 189683790 Change-Id: I0209e7fa839175041da29e9a6d8a590133121376
2018-03-19Convert @AutoValue CoalescedRow to a protolinyuh
Test: Existing tests PiperOrigin-RevId: 189675976 Change-Id: Ieae92b5ac2aefd3f0397bbb07ebb1c97bd72ed42
2018-03-19Added polling job for CallLogConfig.zachh
Bug: 74821995 Test: unit PiperOrigin-RevId: 189670163 Change-Id: Ifdfcab7dc4493cbe688ef77d43df7e7a1400fa27
2018-03-19Implement VoicemailDataSourcetwyen
This data source determines if the call is to the voicemail inbox. isVoicemail() is removed from NumberAttributes and PhoneLookup. It is yet decided how in call UI should handle voicemail calls in the future. TAG_CHANGE_OK=proto not in prod yet. Please clear app data. TYPE_CHANGE_OK=above Bug: 70989587 Test: Unit tests PiperOrigin-RevId: 189650273 Change-Id: Iafebf1abb18c74301b62a72d1d04deecd6d78d29
2018-03-19Watch for phenotype flag changes and update CallLogConfig.zachh
Bug: 74821995 Test: unit PiperOrigin-RevId: 189648655 Change-Id: I9918bd6f35bf7eb1bebb9862c2d78880457efa91
2018-03-15Introduce GlidePhotoManager to CallDetailsActivitylinyuh
Bug: 74202944 Test: ModulesTest, CallDetailsActivityTest PiperOrigin-RevId: 189204143 Change-Id: I917bac76009522c6a99fdb63299556ec2a454dfa
2018-03-14Added CallLogConfig.zachh
This class is responsible for enabling or disabling the call log framework when flags change. Bug: 74821995 Test: unit PiperOrigin-RevId: 189143911 Change-Id: I4727645ce621fbc01acbcd0acab523fe955d4075
2018-03-12Use white background in new call log.zachh
Bug: 74402112 Test: none PiperOrigin-RevId: 188782198 Change-Id: I36c2adcd8f0403c88694343cbbf12e9aba229afb
2018-03-06Covnert @AutoValue PhotoInfo into a proto.linyuh
Bug: 74202944 Test: Existing tests PiperOrigin-RevId: 188060790 Change-Id: I4d79a353abf767935383d4149f261f5e96fd7acb
2018-03-02Added impression logging for AnnotatedCallLog rebuild operations.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 187694255 Change-Id: Ie6ec70a70a4c59cbdfe25c34003d21fa2f751564
2018-03-02Added timing to some more AnnotatedCallLog operations.zachh
This includes: 1) Made RefreshAnnotatedCallLogWorker.refresh() methods return a result which is "not dirty", "dirty but no changes needed" or "dirty and changes need". It will be interesting to see how often these cases occur (will log impressions in a future CL) so I thought we might as well log the latency of each case separately as well. 2) To support 1) added a new method to FutureTimer which allows you to compute the event name from the result of the timed Future. Also needed to update the Metrics interface to support deferring the event name when starting a timer via a generic token. 3) Timing the coalesce operation which is very heavyweight. 4) Made StubMetrics do some logcat logging to easily observe timing information using AOSP Bug: 70989667 Test: unit PiperOrigin-RevId: 187691203 Change-Id: I5f19a2fc94d86639486299b65b0edd66eeaab52e
2018-02-28Log contact source when reporting spam from the new UI.linyuh
Bug: 73780748 Test: PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 187404074 Change-Id: I1db81304909fbf63aba00088c12e18922042c3b1
2018-02-28Group info needed to show a block/report spam dialog into a proto to avoid ↵linyuh
long method signatures. Test: Existing tests PiperOrigin-RevId: 187338094 Change-Id: I0d7a5206d127931d322b5604b2bb81f5202b8de8
2018-02-27Internal cleanup for the new UI's bottom sheet.linyuh
Test: Existing tests PiperOrigin-RevId: 187254014 Change-Id: I8a57b632d45e87ad075eb8bbb25180858e890f08
2018-02-27Set the correct reporting location when reporting spam in the new call log.linyuh
Bug: 73816729 Test: Existing tests PiperOrigin-RevId: 187230516 Change-Id: I59d70b9676e2972b80f124f29f2c1cb1858efef8
2018-02-26Look up contacts in the local enterprise directory in the new call log.linyuh
Bug: 73547944 Test: Cp2ExtendedDirectoryPhoneLookupTest PiperOrigin-RevId: 187064655 Change-Id: Icb468e0867248f097a77134dd67a53352f7c80b0
2018-02-26Implement logic of bottom sheet options related to spam numbers.linyuh
Bug: 70989605 Test: ShowBlockReportSpamDialogNotifierEndToEndTest + Manual PiperOrigin-RevId: 187047450 Change-Id: I23c3929135bcfe5c14fe317ef65f628dc126027f
2018-02-23Track initial call log building metrics separately from incremental building ↵zachh
metrics. This required creating "CallLogState" which is currently just a boolean value which can only be turned on once (when the annotated call log flow finishes for the first time). This CL also changes CompositePhoneLookup to no longer implement PhoneLookup. This was done to support a now reverted implementation of CallLogState but it's easier for me to keep the change and it shouldn't be harmful. Bug: 70989667 Test: unit PiperOrigin-RevId: 186852257 Change-Id: I3f342737aaf909f8230b8a69d9c21e6e5c19b84e
2018-02-22Added some logcat and metrics logging for new call log.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 186726722 Change-Id: I1a68ae1e01b101b1624e4f5ede1a8d639d481ad2
2018-02-22Make MarkDirtyObserver available to all call log data sources & PhoneLookups.linyuh
Bug: 73347270 Test: Existing tests PiperOrigin-RevId: 186475562 Change-Id: I622b52f4d74b26fd084b6588da6321c46458aa9d