Age | Commit message (Collapse) | Author |
|
Author: Danny Baumann <dannybaumann@web.de>
Date: Mon Nov 11 15:36:21 2019 +0100
Fix crash in call stats.
We fed color resources into LinearColorBar now.
Change-Id: Ica6870fb6af8b982bc2710e7b63092c513fa4755
Author: Danny Baumann <dannybaumann@web.de>
Date: Mon Dec 2 09:34:22 2019 +0100
Beautify call stats details category headers.
Make them consistent with how pref category headers are displayed.
Change-Id: I4ee8bb2dae11970051552d14df2d58d7ab6a3fdf
Change-Id: I9f2b6e912ca69a5aa7a1790bed06304ee953e752
|
|
Change-Id: Ieac27294f4069b2cff17bb39a0954f74320ad943
|
|
Author: Danny Baumann <dannybaumann@web.de>
Date: Mon Jul 9 11:19:24 2018 +0200
Re-add call recording.
Change-Id: I53fadf5754b5b6cc3e9920d57480e470e2305ac0
Author: Markus Gruber <gruberma@outlook.at>
Date: Sat Oct 13 09:17:01 2018 +0200
Allow call recording for Austria
* Call recording is legal in Austria, so it should be available in the UI
Change-Id: Iaae0b222d2a1108572832732471e7e063f84dd1f
Author: Alexandre Pary <alexandre.pary@gmail.com>
Date: Wed Oct 17 11:33:35 2018 +0200
Allow call recording for Belgium
* Call recording is legal in Belgium, so it should be available in the UI
Change-Id: I0d18c5c31aa5fbde08a849932ac0c8088508dbd8
Author: Arekusu Rin <alexmatteotv@gmail.com>
Date: Thu Oct 18 10:20:42 2018 +0200
Allow call recording for Bulgaria.
* Call recording is legal, subject to certain restrictions, in Bulgaria.
Call recording without notification or one side's consent is not a
criminal offense, and only affects the admissibility of said call
recording as evidence.
Change-Id: Ie35f23056914fb2e7639ea509675e21e7fdfab26
(cherry picked from commit 4cec325c31dbe5894ab576b6161065ad0458612d)
Author: Bruno Martins <bgcngm@gmail.com>
Date: Tue Oct 23 21:03:47 2018 +0100
res: Fix malformed XML
* The legal precedent source URL includes double dashes and breaks
aapt2 compilation. Replace it by a shortened one.
Change-Id: Ic1cb1b6af16d27649e36478ca7597b78b93b1338
Author: Arekusu Rin <alexmatteotv@gmail.com>
Date: Thu Oct 25 12:50:57 2018 +0200
Enable or disable call recording for numerous countries via MCC.
* This change handles call recording within the Dialer. Changes were made
to the template of all of the XML files, and all links were changed to
https, where possible. Quotes of the precedents and/or laws can be found
within each country's XML file. Countries' whose status was not changed
are not explicitly mentioned below, despite any changes to their files.
* Call recording is disabled for: Andorra, Iceland, Indonesia, Monaco,
Switzerland, the United States of America and some of its territories -
Guam, Northern Mariana Islands, Puerto Rico and the United States Virgin Islands.
* Call recording is enabled for: Albania, American Samoa, Argentina, Armenia,
Aruba, Belarus, Bonaire, Bosnia and Herzegovina, Brazil, Canada, Chile,
Croatia, Curaçao, Cyprus, Estonia, Faroe Islands, French Guiana, French Polynesia,
Georgia, Greece, Greenland, Guadeloupe, Hungary, India, Ireland, Israel, Japan,
Kosovo, Latvia, Liechtenstein, Lithuania, Luxembourg, Malta, Martinique, Mayotte,
Moldova, Montenegro, Morocco, New Caledonia, New Zealand, North Macedonia, Peru,
Russia, Réunion, Saba, Saint Barthélemy, Saint-Martin, Saint-Pierre-et-Miquelon,
Serbia, Singapore, Sint Eustatius, Sint Maarten, Slovakia, Slovenia, South Africa,
South Korea, Turkey, Ukraine and Wallis-et-Futuna.
Change-Id: Iba5b7028d26cac281099f81bf3d5c21e2ee4d1a9
Author: Arekusu Rin <alexmatteotv@gmail.com>
Date: Wed Jun 12 09:58:05 2019 +0200
Enable Call Recording for Sri Lanka and Costa Rica.
* Call recording is enabled for: Sri Lanka (413) and Costa Rica (712).
* Fixes: Removed newline from Belgium (206) and space from Russia (250).
Change-Id: I4c9ecf41e9fd472b97fff5cd03800414737be87a
Author: Danny Baumann <dannybaumann@web.de>
Date: Thu Nov 7 08:34:44 2019 +0100
Base 'call recording allowed' decision on current country.
Selection of resources by MCC happens via the SIM MCC, but what matters
for legislation is the current country, not the country the SIM origins
from. Because of that, move the decision about whether call recording is
allowed or not to the current country instead of SIM MCC.
Change-Id: I0ee365d7af8e3392716318e5a51e12e0efe7029a
Author: Han Wang <416810799@qq.com>
Date: Wed Nov 20 13:27:00 2019 +0200
Enable call recording for China
Change-Id: Id51a2e6a119e99ff50696b50513aed323c61565c
Author: mhkjahromi <m.h.k.jahromi@gmail.com>
Date: Sat Dec 7 18:32:20 2019 +0330
Enable call recording for Iran
Change-Id: I5640405d9bd38ac3d83fd618543190c1b0d800fb
Author: Danny Baumann <dannybaumann@web.de>
Date: Thu Feb 20 13:19:27 2020 +0100
Refactor call recording to use MediaProvider.
Change-Id: Id53d43d8bf10715a1597ff754f6c38a992302190
Author: Danny Baumann <dannybaumann@web.de>
Date: Fri Jun 5 13:19:46 2020 +0200
Iterate old recordings properly when migrating call recording data.
SparseArray.get() expects a key, not an index.
Change-Id: I0ba40180dc9df9f8a8f4036ccbe47cc59a50cfbb
Change-Id: Ie9e0af8ccadb1bab1c52a5d905344d0c8fcab92c
|
|
Android N and earlier enabled Do Not Disturb mode while in a call.
Reimplement this behavior to prevent incoming notifications from
vibrating or playing sounds.
Change-Id: Ic38ac775c6e353898190e1571b6d6e521c0e5aa1
|
|
Rename it to "In-call" and adjust the preference hiding code
accordingly.
Turn checkboxes into switches for more consistency.
Change-Id: If22a58b4f82e3db59373e53da0632c126bd946f4
|
|
Change-Id: Ia30a3c46e9c37d7d73288ec605af8efc3a46a323
|
|
to the system sound settings fragment instead."
We add additional settings to this fragment, so the stated reasons for
removing it don't apply to us.
This reverts commit c378fb17f0ae994b950273e0f91b5692ad7638cf.
Change-Id: I0a8bd3135c43627d4355cc5c01c1144a03518144
|
|
Change-Id: Ice040bb2785e8e4e3828c6008121520586d269ac
Signed-off-by: Joey <joey@lineageos.org>
|
|
The public platform version no longer can be a codename, it is
always the most recently released platform. A new build property
and API provides either the offical version or the current codename
as appropriate. This will avoid breaking apps that look at the
platform version while development is under a codename.
Bug: 143175463
Test: manual
Change-Id: Ic0621234215d4ba79255b985dccdd4ae6c863fc8
Exempt-From-Owner-Approval: Previously approved, no new changes.
|
|
Reason for revert: This causes a boot issue on Taimen (b/144480969). It wasn't caught by TreeHugger due to Taimen tests being disabled due to a different lab outage (b/144350336).
Change-Id: Ib9fb23e378034fe73373030e0865c6bac99d4f37
|
|
The public platform version no longer can be a codename, it is
always the most recently released platform. A new build property
and API provides either the offical version or the current codename
as appropriate. This will avoid breaking apps that look at the
platform version while development is under a codename.
Bug: 143175463
Test: manual
Change-Id: Ic8fe4defb609dee24f53358dc7b37e3590482b27
|
|
|
|
PreferenceManager.getDefaultSharedPreferences() can only be called when the device is unlocked. The module will lazily construct the impl.
Fix defaults for contact display preferences.
If the settings are accessed before the preferences are populated the wrong default value will be used.
Test: make
Bug: 111275389, 111051362
Change-Id: I29e34d61d529c91065aa3ef952d125d83cdee982
|
|
Test: make
Change-Id: Ib75f4f25e91067311de244d7f1fb95bc898aec22
|
|
This reverts commit 9c952d8f2688350f06d65df7852756ab05b6fdab.
Change-Id: I3b2f23826c34ecdb16e786c5dd92f13ed97d88e7
|
|
Bug: 79877518
Test: manual
PiperOrigin-RevId: 202690405
Change-Id: Ibb2c5e81cb244aad25d75dc005bfc92ef775ffe1
|
|
Test: Existing tests
PiperOrigin-RevId: 202589482
Change-Id: I6982e4069d30032bf46caf3c9984dfc0e7196f6f
|
|
Bug: 80482741
Test: None
PiperOrigin-RevId: 202526514
Change-Id: Ia92b95b288638ccb77d3bac16bd8c5589326bf61
|
|
Moving it outside contacts.commons reduces dependency to legacy code. Also removed redundant implementations such as caching SharedPreferences (it is already cached), custom ListPreferences (standard ListPreferences already have what we want), and corrected preference storage location (allow standard ListPreferences to work)
TEST=TAP
Test: TAP
PiperOrigin-RevId: 202000393
Change-Id: I45374e610b3510784b5a4da92e5d8462cbfc92bb
|
|
Bug: 110530781,78281972
Test: N/A
PiperOrigin-RevId: 201729044
Change-Id: Id00e8e3e4ee89b846bce78f4a29d5e6f26384e0c
|
|
Bug: 110083450
Test: Manual
PiperOrigin-RevId: 200774928
Change-Id: I4bb036ab5b2e7dc252ad32d49d2370cd17f8e3f8
|
|
Test: manual
PiperOrigin-RevId: 200629297
Change-Id: I6346fb2eb8742902949b2627a12956f0adca78ed
|
|
Bug: 78491417,80164592
Test: VoicemailPlaybackTest
PiperOrigin-RevId: 200282735
Change-Id: I296b822550f558a8f08d6811bf557d24a52e01d9
|
|
This is due to wild card content type. It's fixed by setting audio type only.
Bug: 62050463
Test: manual
PiperOrigin-RevId: 200263392
Change-Id: Ie2ea17fc04bbf74d2ef795b71e2dfbfaea9d9cf3
|
|
Bug: 109931227
Test: manual
PiperOrigin-RevId: 200232293
Change-Id: Id82ce87014a2a16b6b27398b7de2019e96c5d95b
|
|
Previously the notification is only auto-canceled if it is deleted from the server. In this CL it will also be canceled if it is read.
TEST=TAP
Bug: 80214330
Test: TAP
PiperOrigin-RevId: 200134453
Change-Id: I716c4c6ee060a7b4162147d9bf9e2e1f5077317a
|
|
DialtactsActivity should be dead code at this point so this code should be unreachable.
Bug: 109931227
Test: none
PiperOrigin-RevId: 199872804
Change-Id: I4f4f66f5c803662de238c42dc746423c8ab1f150
|
|
We want to remove DialtactsActivity but cannot replace it with MainActivity or would create a circular dependency. Instead, just let the system to pick the activity appropriate for the dial intent (which should be MainActivity).
Bug: 109931227
Test: manual
PiperOrigin-RevId: 199871747
Change-Id: I6e4a5a854f3cd04d630df9d831df2767d411f1c1
|
|
DialtactsActivity.
We can't just replace DialtactsActivity with MainActivity because a circular dependency would be created. Instead create a new dialer-specific "main" intent action and use it.
Bug: 109931227
Test: manual
PiperOrigin-RevId: 199868961
Change-Id: I0ef72ed418280eeb64ea1ea854d215093b0dba27
|
|
This needs to be moved in order to delete DialtactsActivity.
Bug: 109931227
Test: none
PiperOrigin-RevId: 199820125
Change-Id: I2b2c190152834bd1d0d0510f8e01110f05a5a8f3
|
|
getCarrierConfig() is @Nullable. While the default implementation always return a bundle, this is not true for other carrier apps.
ShadowTelephonyManager.getCarrierConfig() now return null as default to catch this behavior.
TEST=TAP
Bug: 80629471
Test: TAP
PiperOrigin-RevId: 199327865
Change-Id: I7416bee3d5f5307919c6825fc74c26f25b6b001f
|
|
It no longer provides any value, so just use dagger directly.
Bug: 80441695
Test: tap
PiperOrigin-RevId: 198806461
Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
|
|
Bug: 79883035
Test: manual
PiperOrigin-RevId: 198799252
Change-Id: I0636351e5b9bca2c173487c8a53282ca66e61e84
|
|
Bug: 80426301,80426768
Test: Manual
PiperOrigin-RevId: 198783744
Change-Id: Ib704a710680b3cf18e4c3c91cd48e7b8491671ff
|
|
Business number from PhoneNumberService does not always have a sensible label. Previously it would be "Main", but geocode are a bit more useful.
TEST=manual, old UI has no tests.
Bug: 80251984
Test: manual, old UI has no tests.
PiperOrigin-RevId: 198455846
Change-Id: I5efbc66aa295f8039eecfbcb119f18afc735b15c
|
|
This enables us to have Google-Sans font in GoogleDialer and Roboto in AOSP.
Bug: 79883035
Test: tap
PiperOrigin-RevId: 197774497
Change-Id: I1d490ab196a444c62e439444627d659fc42973ea
|
|
Test: Existing tests
PiperOrigin-RevId: 197681266
Change-Id: I27fdda1d5c252993795b6eb860663c8cab0d363c
|
|
- README on how to properly theme Dialer going forward.
- Migrated all widgets to use global colors.
- Removed all activity and application themes where it wasn't necessary.
- Added themeing test rule for Espresso tests.
Bug: 79883035
Test: tap
PiperOrigin-RevId: 197634256
Change-Id: I4b7d94d45aeeb59d484b0069fdd1e200a654910b
|
|
TEST=unit
Bug: 79667976,79925108
Test: unit
PiperOrigin-RevId: 197468611
Change-Id: Ifedddd2bccd76b1fc2c9d3ea4e9854bfe6a218e5
|
|
The status will be stale.
TEST=TAP
Bug: 78831353
Test: TAP
PiperOrigin-RevId: 197462056
Change-Id: Iaeeae9007f6b5ad8319889a860fdcce782be8a0d
|
|
deleted several colors and unified them across the app
migrated several alert dialogs to support alert dialogs
added many todos
migrated several tests from GoogleRobolectricTestRunner to RobolectricTestRunner
Because of the test migration:
- moved dialpad theme attributes into dialpad/theme
- moved incall ui theme attributes into incallui/theme
Bug: 79883035
Test: tap
PiperOrigin-RevId: 197246477
Change-Id: Ifc534793bc32757bbbf2007a7c40287c8d0817ad
|
|
Throttled missed call notification can be post again since they are in the newCalls list and not in activeNotifications list. We should record them and don't post again.
Test: MissedCallNotifierTest, NotificationThrottlerTest
PiperOrigin-RevId: 197177610
Change-Id: I1b03029663621f0a0c06951564eadf78bad016a1
|
|
Bug: 38502365
Test: None
PiperOrigin-RevId: 197043585
Change-Id: If9baef5cdd59d6f94cca6d6298efe59d4e296485
|
|
Test: tap
PiperOrigin-RevId: 196575887
Change-Id: If2d07a2db075697f490d99021ad0616b40a3aff7
|
|
Bug: 79255819
Test: SpeedDialFragmentTest
PiperOrigin-RevId: 196560164
Change-Id: Ieb537da269d77089c4403ccb939c7194d04910bb
|
|
Bug: 79183384
Test: manual
PiperOrigin-RevId: 196344851
Change-Id: I9f5c0e52cb4efe9e63e2c19a4f62ee0b9a23412f
|
|
This CL consolidates common duo calling operations into precall, including checking reachability, falling back to carrier video call, placing the call to duo with startActivityForResult.
TEST=TAP
Bug: 78783816
Test: TAP
PiperOrigin-RevId: 195742478
Change-Id: I9fea1e4999f604e1f3a153b28079cd0db77b7393
|
|
This happens when the number exists in call log, which usually shouldn't happen but some OEMs may have different behavior. Adding an additional check to align it with call action so block option won't show up if the number is not callable.
Bug: 79202933
Test: verified on LG device.
PiperOrigin-RevId: 195480184
Change-Id: Icde5f5b0914b2198d9031d188b22a65d6a3085cc
|
|
|
|
Bug: 79153175
Test: Compiled and verified that merged manifest had targetSdkVersion=28
PiperOrigin-RevId: 195145440
Change-Id: I12cde947d8fe8594f91bcc3dacdba6f9c72ac84a
|
|
They are not constant across different Duo implementations.
TEST=TAP
Bug: 76430187,78783816
Test: TAP
PiperOrigin-RevId: 195001650
Change-Id: I4356d04c9eeac50fefd41e1142f3123591e93bc0
|
|
devices
When the SIM is removed, telephony will signal cancel notifications on the "null" account (the framework doen't know what was there.). Previously this has no effect. In this CL, all legacy voicemail notifications are removed since all SIM will be removed together.
TEST=TAP
Bug: 78446801
Test: TAP
PiperOrigin-RevId: 194856211
Change-Id: I5df97f0c73e0644daa46ab182f19e60044e39d96
|
|
Bug: 70989584
Test: CequintPhoneLookupTest
PiperOrigin-RevId: 194493484
Change-Id: I59f9b334f0a218e7ba1c34948db4ddbf11490df3
|
|
notification.
Test: N/A
PiperOrigin-RevId: 194465415
Change-Id: Ica9301f4315b549c343112a824c8f7c51213bb99
|
|
notification
Test: N/A
PiperOrigin-RevId: 193290689
Change-Id: Idff99e2f67d5161d09b7ea3c0818ed92d2286b61
|
|
TEST=unit
Test: unit
PiperOrigin-RevId: 193288015
Change-Id: I350fa06cb96ff1887c428c8d60c489ddf0da81f6
|
|
Bug: 67596257
Test: CallDetailsCursorLoaderTest
PiperOrigin-RevId: 193259769
Change-Id: I8c6a8eb9a6bf06e9c1c25c45fc035f8db8ae5a65
|
|
This is for old call log UI.
This change also improves scaling for vector drawable icons.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 192359601
Change-Id: I3322fe08b668f01c1e3a7ce3264c2988e2703aae
|
|
Bug: 75962146
Test: screenshot
PiperOrigin-RevId: 191948101
Change-Id: Icba3cb63cbfe42ce0f193e731dbe2240b3dfc27d
|
|
Bug: 36841782
Test: MainActivityNewPeerTest
PiperOrigin-RevId: 191924314
Change-Id: I5e4a4adadd5477115d6b4daf8afb8c6f819496c8
|
|
Bug: 75972847,77595270
Test: manual
PiperOrigin-RevId: 191672019
Change-Id: I9ea7fb67b4dffeb6acb30840eaf093e4d00a3bcf
|
|
The phone number can be null in the call log (typically for conference calls),
but this wasn't handled properly for calls from non-contacts.
This CL fixes the issue by instead using the display number. PhoneNumberUtils
properly handles null values and can parse the formatted version.
Bug: 77486039
Test: manual :/
PiperOrigin-RevId: 191492307
Change-Id: I1be427b3f4ed1381bea3943d130256618f730f5d
|
|
availability check
Checking donation is not a simple config check, but everything that donation availability is dependent on via the isVoicemailDonationAvailable() helper method. We update the code accordingly.
When the user declines the promo for donation, we should also update the toggle accordingly.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 191011808
Change-Id: I6e4ff9914355deed72175179fc7b9009f2395ef5
|
|
Bug: 77242856
Test: N/A
PiperOrigin-RevId: 191002650
Change-Id: Ia74423f28a40f148d507fb9f907fc2e5c41fc183
|
|
- back arrow in search now flips in RTL mode http://screen/1eccBLDqPp0
- search text no longer overlaps icons http://screen/Mq0omQEuZez
- keyboard now always closes on pause
- location permission is no longer visible in dialpad search
Bug: 73088433,74784637,76117373,76440832,76441216
Test: keyboard and rtl tested manually, added test for location permission
PiperOrigin-RevId: 190981686
Change-Id: Ia121d410c158df0de9cd731ab280a6d8e9b300d9
|
|
Bug: 76221932
Test: manual
PiperOrigin-RevId: 190948113
Change-Id: I4151ab3fc5231183d49fc1bdc247a09e5ffadc22
|
|
Test: Existing tests
PiperOrigin-RevId: 190820867
Change-Id: I4835bcbc7698075fb54015dccc6823ada4c71651
|
|
Test: N/A
PiperOrigin-RevId: 190673495
Change-Id: I1587449f6b0b53e7a16aac0b334225649a94f27b
|
|
Test: Existing tests
PiperOrigin-RevId: 190516504
Change-Id: I5fa9e123b45beb9728257ecd160a348fb3f4732c
|
|
up to N.
Test: Existing tests
PiperOrigin-RevId: 190508397
Change-Id: Ia5f33e45af1d1cc666fec5f43efa564b2b68c193
|
|
setting interface.
Test: All the existing tests
PiperOrigin-RevId: 190314880
Change-Id: I030acbd70120f508c5a4616757d89113524110fa
|
|
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190298092
Change-Id: Icb9f26a93b6e3c27a836442c48a9dd6f99124785
|
|
Bug: 75962274,75967273,75972847
Test: manual
PiperOrigin-RevId: 190251834
Change-Id: I3673a6b20a886ded86dc4e1a8f75a82e5e0bb199
|
|
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig.
Other related changes to help accomplish this:
-Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework.
-Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest).
-The "Main" package is also on longer needed since it existed to control the shortcut.
Bug: 74821995
Test: existing
PiperOrigin-RevId: 190251418
Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
|
|
Bug: 76154272
Test: CallLogGroupBuilderTest
PiperOrigin-RevId: 190187854
Change-Id: Ib96c406c4bb0627729c24c58c526850ff4fda22f
|
|
Bug: 74421656
Test: DialerBidiFormatterTest
PiperOrigin-RevId: 190154072
Change-Id: Ic7cb3be702dd28b07b6e5e1e6d89f75f0bb12655
|
|
Manually set to M
- MissedCallNotifierTest (not sure what the issue is here...)
- CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown)
- MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory))
Ignore Tests
- a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason)
- VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear)
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190030202
Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
|
|
search.
These components are safe to delete because:
- New Contacts has been in prod for several releases.
- New Search has been in in prod for 2 releases.
- p13n logger was based on old search and is no longer being implemented in
Dialer.
- Filtered Number Settings contact search since we no longer support M.
Bug: 37208802,73902692
Test: tap
PiperOrigin-RevId: 189992017
Change-Id: I2720a252ababd164b5d0fb1011753a3c96a704d1
|
|
This CL updates the call log to show "Emergency number" for call log rows from
numbers that PhoneNumberUtils.isEmergencyNumber considers to be emergency
numbers.
Bug: 66926712
Test: Manual, see above
PiperOrigin-RevId: 189953302
Change-Id: Ibaae243ead8b918a26f6058164316e042a4f82fd
|
|
Test: SpamBlockingPromoHelperTest
PiperOrigin-RevId: 189674918
Change-Id: I0b22eb9b8128125cc5b439674099820a01c3889f
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Other usages already has the null check.
Bug: 75598828
Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause.
PiperOrigin-RevId: 189644833
Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
|
|
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 189418664
Change-Id: I3dadea08dad1f2a594f5a7e0daf055721c3222a3
|
|
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following:
- ensuring that when the VVM toggle is turned off, transcription and donations are gone.
- when transcription is off, donation preference is gone.
- donation is only available when transcription is available and enabled
- as part of the refactor, fixes existing logging bugs
- breaks preferences and its associated methods into helper methods when possible
- groups relevant preferences together when possible
Bug: 74033229
Test: Unit tests
PiperOrigin-RevId: 189418217
Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
|
|
This also finishes moving all of the old tests over from
Dialtacts to Main. The only 2 tests that fail are:
- searchBoxClosedWhenHandlingNotificationIntent
- openSearchFragment_fabGoneInRegularSearchAfterRotation
I will fix these in a follow up CL.
Bug: 72525887
Test: dialer_aosp build target launches MainActivity, TAP
PiperOrigin-RevId: 189408987
Change-Id: Ice30191d95c19c62bcd89503e89f66440f30beac
|
|
This was accidentally removed in cl/176677167. This change restores
the logging in call details and also adds it to the call log menu.
Bug: 73774284
Test: OldCallDetailsActivityIntegrationTest, CallLogActivityIntegrationTest
PiperOrigin-RevId: 189279107
Change-Id: Iadda16d7f1e4d720f828b5a72f210bcb8029f939
|
|
For simplicity, instead of resolve the nui shortcut string, I
deleted it since it isn't used anymore.
Test: build log
PiperOrigin-RevId: 189260472
Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
|
|
Bug: 74017355
Test: ContentWithLearnMoreSpannerTest
PiperOrigin-RevId: 189252365
Change-Id: I3464fb56b86a6b3ddd25e9eed14152eaeed9925c
|
|
Bug: 74202944
Test: Existing tests
PiperOrigin-RevId: 189095432
Change-Id: I13015ee6c5767edd95b78c3fb2e7338495e9e1d7
|
|
This CL is a continuation of cl/187700318. In that CL, we were able to unregister
the call log's content observer and prevent this crash, but it's reshowing
itself in voicemail now.
Since the voicemail's observer is registered in the adapter and is unaware of
lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll
just check that the parent isn't null.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 188812159
Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f
|
|
Keyboard should close when:
- requeting permission
- placing a call
- leaving the app
Search should close when:
- placing a call
- leaving the app
Bug: 74235853
Test: search closing onPause tests already exist (MainActivityOldPeerSearchIntegrationTest#placingCallFromSearchClosesSearch)
PiperOrigin-RevId: 188812026
Change-Id: Iaee084c59b4c514d10375deff5d73d5a456ef9df
|
|
Test: InAppSpamTest,ApdlSpamTest,VisualVoicemailUpdateTaskTest
PiperOrigin-RevId: 188509191
Change-Id: I8b9c07dcc1c7b3b80ffc914ec99f4e6d80d50985
|
|
When a voicemail is deleted we have to allow the user the option of cancelling the deleting of voicemail. This is done by showing the user a snack bar which when a user taps will prevent the voicemail from being deleted.
This CL only adds the underlying logic for the delete/undelete to take place via a ScheduledFuture, it does not fix all the UI issues that come with it, which will be sent in a follow up CL, issues such as:
-Updating the group label when a delete/undo happens
-Updating the entries above and below when a delete/undo happens
-Showing the empty view immediately when a user deletes a single voicemail
-Removing the empty view immediately when a user taps undo
-Updating tests
Bug: 69858266
Test: Manual
PiperOrigin-RevId: 188424489
Change-Id: Iecf5cb7be5b80fa5e91acaad3a7cc4a6c8702521
|
|
Bug: 73368638
Test: CallLogAdapterTest
PiperOrigin-RevId: 188414469
Change-Id: I7d7522c841a6b4054e2e387346973c597174ee87
|
|
Bug: 70989547
Test: ShowBlockReportSpamDialogNotifierEndToEndTest
PiperOrigin-RevId: 188351591
Change-Id: I634fb821592bdc890df291fdf83cdf307c94ffa9
|
|
Bug: 73877234
Test: just logging
PiperOrigin-RevId: 188256051
Change-Id: Ic9486b3fc1d97338cb016b86a243612baa6282fe
|
|
Bug: 73798533
Test: N/A
PiperOrigin-RevId: 188046222
Change-Id: I1b66afa787bb5c91d71dbeda544218226ae8f5fd
|
|
My hypothesis is that there is a race condition where the call log changes and
we are leaving the activity before the content observer is unregistered or the
loader it starts is finished. This results in a callback calling #fetchCalls
while Dialer is in the background, resulting in a crash. This change will
confirm my hypothesis.
Even if my hypothesis is incorrect, we have similar checks throughout this
class which indicates to me that some issue exists here and that this check is
safe to do.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 187700318
Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
|
|
system sound settings fragment instead.
There is no need for dialer to have it's own sounds and vibrations fragment. Instead of maintaining two separate fragments that do that same thing (and have to be kept in sync), we can just have one source of truth and have users modify those settings. Thus we have removed the dialer and vibrations settings fragment and have it instead re-direct to the system sound settings. The automatic advantage of this is also that for dual sim cases, dialer settings don't need to be updated.
Bug: 73750524
Test: Manual. Navigated to the dialer sound and settings fragment, and it opened the system settings. Also pressing back took us back to Dialer as expected.
PiperOrigin-RevId: 187564461
Change-Id: I7d620721237f1c932ed8cea949486ae7dbdefba1
|
|
Bug: 71385186
Test: manual
PiperOrigin-RevId: 187552834
Change-Id: If4e1f7c18d5f5aae2a152762189948c3543ba321
|
|
Bug: 73718977
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 187540382
Change-Id: I814ec62b2215c24b8cde3442c5dc83d98ad87164
|